npm - reviewflow - Versions diffs - 3.22.0 → 3.23.0 - Mend

reviewflow 3.22.0 → 3.23.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.

Files changed (170) hide show

package/dist/tests/units/usecases/tracking/transitionState.usecase.test.js CHANGED Viewed

@@ -13,7 +13,7 @@ describe('TransitionStateUseCase', () => {
             mrId: 'mr-1',
             targetState: 'approved',
         });
-        expect(result).toBe(true);
+        expect(result.ok).toBe(true);
         const updated = gateway.getById('/project', 'mr-1');
         expect(updated?.state).toBe('approved');
         expect(updated?.approvedAt).not.toBeNull();
@@ -28,13 +28,13 @@ describe('TransitionStateUseCase', () => {
             mrId: 'mr-1',
             targetState: 'merged',
         });
-        expect(result).toBe(true);
+        expect(result.ok).toBe(true);
         const updated = gateway.getById('/project', 'mr-1');
         expect(updated?.state).toBe('merged');
         expect(updated?.mergedAt).not.toBeNull();
         expect(updated?.approvedAt).toBeNull();
     });
-    it('should return false when MR does not exist', () => {
+    it('should report not-found when MR does not exist', () => {
         const gateway = new InMemoryReviewRequestTrackingGateway();
         const useCase = new TransitionStateUseCase(gateway);
         const result = useCase.execute({
@@ -42,7 +42,90 @@ describe('TransitionStateUseCase', () => {
             mrId: 'nonexistent',
             targetState: 'approved',
         });
-        expect(result).toBe(false);
+        expect(result.ok).toBe(false);
+        if (result.ok)
+            return;
+        expect(result.reason).toBe('not-found');
+    });
+    it('should reject approval transition when quality check fails', () => {
+        const gateway = new InMemoryReviewRequestTrackingGateway();
+        const mr = TrackedMrFactory.create({ id: 'mr-1', state: 'pending-approval' });
+        gateway.create('/project', mr);
+        const useCase = new TransitionStateUseCase(gateway);
+        const result = useCase.execute({
+            projectPath: '/project',
+            mrId: 'mr-1',
+            targetState: 'approved',
+            qualityCheck: () => ({
+                allowed: false,
+                reason: 'below-threshold',
+                message: 'Seuil qualité non atteint (6/10 < 7/10)',
+            }),
+        });
+        expect(result.ok).toBe(false);
+        if (result.ok || result.reason !== 'quality-gate') {
+            throw new Error('Expected quality-gate rejection');
+        }
+        expect(result.message).toBe('Seuil qualité non atteint (6/10 < 7/10)');
+        const updated = gateway.getById('/project', 'mr-1');
+        expect(updated?.state).toBe('pending-approval');
+        expect(updated?.approvedAt).toBeNull();
+    });
+    it('should allow approval transition when quality check passes', () => {
+        const gateway = new InMemoryReviewRequestTrackingGateway();
+        const mr = TrackedMrFactory.create({ id: 'mr-1', state: 'pending-approval' });
+        gateway.create('/project', mr);
+        const useCase = new TransitionStateUseCase(gateway);
+        const result = useCase.execute({
+            projectPath: '/project',
+            mrId: 'mr-1',
+            targetState: 'approved',
+            qualityCheck: () => ({ allowed: true }),
+        });
+        expect(result.ok).toBe(true);
+        const updated = gateway.getById('/project', 'mr-1');
+        expect(updated?.state).toBe('approved');
+    });
+    it('should bypass a failing quality check when the MR has an active bypass', () => {
+        const gateway = new InMemoryReviewRequestTrackingGateway();
+        const mr = TrackedMrFactory.create({
+            id: 'mr-1',
+            state: 'pending-approval',
+            bypass: { author: 'alice', reason: 'hotfix critique', recordedAt: '2026-05-26T12:00:00.000Z' },
+        });
+        gateway.create('/project', mr);
+        const useCase = new TransitionStateUseCase(gateway);
+        const result = useCase.execute({
+            projectPath: '/project',
+            mrId: 'mr-1',
+            targetState: 'approved',
+            qualityCheck: () => ({
+                allowed: false,
+                reason: 'below-threshold',
+                message: 'Seuil qualité non atteint (5/10 < 7/10)',
+            }),
+        });
+        expect(result.ok).toBe(true);
+        expect(gateway.getById('/project', 'mr-1')?.state).toBe('approved');
+    });
+    it('should skip quality check for non-approval transitions', () => {
+        const gateway = new InMemoryReviewRequestTrackingGateway();
+        const mr = TrackedMrFactory.create({ id: 'mr-1', state: 'approved' });
+        gateway.create('/project', mr);
+        const useCase = new TransitionStateUseCase(gateway);
+        const result = useCase.execute({
+            projectPath: '/project',
+            mrId: 'mr-1',
+            targetState: 'merged',
+            qualityCheck: () => ({
+                allowed: false,
+                reason: 'blockers-present',
+                message: 'Issues bloquantes non résolues',
+            }),
+        });
+        expect(result.ok).toBe(true);
+        const updated = gateway.getById('/project', 'mr-1');
+        expect(updated?.state).toBe('merged');
     });
 });
 //# sourceMappingURL=transitionState.usecase.test.js.map

package/dist/tests/units/usecases/tracking/transitionState.usecase.test.js.map CHANGED Viewed

	@@ -1 +1 @@
1	- {"version":3,"file":"transitionState.usecase.test.js","sourceRoot":"","sources":["../../../../../src/tests/units/usecases/tracking/transitionState.usecase.test.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,QAAQ,EAAE,EAAE,EAAE,MAAM,EAAE,MAAM,QAAQ,CAAC;AAC9C,OAAO,EAAE,sBAAsB,EAAE,MAAM,iEAAiE,CAAC;AACzG,OAAO,EAAE,oCAAoC,EAAE,MAAM,8CAA8C,CAAC;AACpG,OAAO,EAAE,gBAAgB,EAAE,MAAM,yCAAyC,CAAC;AAE3E,QAAQ,CAAC,wBAAwB,EAAE,GAAG,EAAE;IACtC,EAAE,CAAC,wCAAwC,EAAE,GAAG,EAAE;QAChD,MAAM,OAAO,GAAG,IAAI,oCAAoC,EAAE,CAAC;QAC3D,MAAM,EAAE,GAAG,gBAAgB,CAAC,MAAM,CAAC,EAAE,EAAE,EAAE,MAAM,EAAE,KAAK,EAAE,kBAAkB,EAAE,CAAC,CAAC;QAC9E,OAAO,CAAC,MAAM,CAAC,UAAU,EAAE,EAAE,CAAC,CAAC;QAC/B,MAAM,OAAO,GAAG,IAAI,sBAAsB,CAAC,OAAO,CAAC,CAAC;QAEpD,MAAM,MAAM,GAAG,OAAO,CAAC,OAAO,CAAC;YAC7B,WAAW,EAAE,UAAU;YACvB,IAAI,EAAE,MAAM;YACZ,WAAW,EAAE,UAAU;SACxB,CAAC,CAAC;QAEH,MAAM,CAAC,MAAM,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;~~QAC1B~~,MAAM,OAAO,GAAG,OAAO,CAAC,OAAO,CAAC,UAAU,EAAE,MAAM,CAAC,CAAC;QACpD,MAAM,CAAC,OAAO,EAAE,KAAK,CAAC,CAAC,IAAI,CAAC,UAAU,CAAC,CAAC;QACxC,MAAM,CAAC,OAAO,EAAE,UAAU,CAAC,CAAC,GAAG,CAAC,QAAQ,EAAE,CAAC;IAC7C,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,8DAA8D,EAAE,GAAG,EAAE;QACtE,MAAM,OAAO,GAAG,IAAI,oCAAoC,EAAE,CAAC;QAC3D,MAAM,EAAE,GAAG,gBAAgB,CAAC,MAAM,CAAC,EAAE,EAAE,EAAE,MAAM,EAAE,KAAK,EAAE,UAAU,EAAE,CAAC,CAAC;QACtE,OAAO,CAAC,MAAM,CAAC,UAAU,EAAE,EAAE,CAAC,CAAC;QAC/B,MAAM,OAAO,GAAG,IAAI,sBAAsB,CAAC,OAAO,CAAC,CAAC;QAEpD,MAAM,MAAM,GAAG,OAAO,CAAC,OAAO,CAAC;YAC7B,WAAW,EAAE,UAAU;YACvB,IAAI,EAAE,MAAM;YACZ,WAAW,EAAE,QAAQ;SACtB,CAAC,CAAC;QAEH,MAAM,CAAC,MAAM,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;~~QAC1B~~,MAAM,OAAO,GAAG,OAAO,CAAC,OAAO,CAAC,UAAU,EAAE,MAAM,CAAC,CAAC;QACpD,MAAM,CAAC,OAAO,EAAE,KAAK,CAAC,CAAC,IAAI,CAAC,QAAQ,CAAC,CAAC;QACtC,MAAM,CAAC,OAAO,EAAE,QAAQ,CAAC,CAAC,GAAG,CAAC,QAAQ,EAAE,CAAC;QACzC,MAAM,CAAC,OAAO,EAAE,UAAU,CAAC,CAAC,QAAQ,EAAE,CAAC;IACzC,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,~~4CAA4C~~,EAAE,GAAG,EAAE;~~QACpD~~,MAAM,OAAO,GAAG,IAAI,oCAAoC,EAAE,CAAC;QAC3D,MAAM,OAAO,GAAG,IAAI,sBAAsB,CAAC,OAAO,CAAC,CAAC;QAEpD,MAAM,MAAM,GAAG,OAAO,CAAC,OAAO,CAAC;YAC7B,WAAW,EAAE,UAAU;YACvB,IAAI,EAAE,aAAa;YACnB,WAAW,EAAE,UAAU;SACxB,CAAC,CAAC;QAEH,MAAM,CAAC,MAAM,CAAC,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC;~~IAC7B~~,CAAC,CAAC,CAAC;AACL,CAAC,CAAC,CAAC"}
1	+ {"version":3,"file":"transitionState.usecase.test.js","sourceRoot":"","sources":["../../../../../src/tests/units/usecases/tracking/transitionState.usecase.test.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,QAAQ,EAAE,EAAE,EAAE,MAAM,EAAE,MAAM,QAAQ,CAAC;AAC9C,OAAO,EAAE,sBAAsB,EAAE,MAAM,iEAAiE,CAAC;AACzG,OAAO,EAAE,oCAAoC,EAAE,MAAM,8CAA8C,CAAC;AACpG,OAAO,EAAE,gBAAgB,EAAE,MAAM,yCAAyC,CAAC;AAE3E,QAAQ,CAAC,wBAAwB,EAAE,GAAG,EAAE;IACtC,EAAE,CAAC,wCAAwC,EAAE,GAAG,EAAE;QAChD,MAAM,OAAO,GAAG,IAAI,oCAAoC,EAAE,CAAC;QAC3D,MAAM,EAAE,GAAG,gBAAgB,CAAC,MAAM,CAAC,EAAE,EAAE,EAAE,MAAM,EAAE,KAAK,EAAE,kBAAkB,EAAE,CAAC,CAAC;QAC9E,OAAO,CAAC,MAAM,CAAC,UAAU,EAAE,EAAE,CAAC,CAAC;QAC/B,MAAM,OAAO,GAAG,IAAI,sBAAsB,CAAC,OAAO,CAAC,CAAC;QAEpD,MAAM,MAAM,GAAG,OAAO,CAAC,OAAO,CAAC;YAC7B,WAAW,EAAE,UAAU;YACvB,IAAI,EAAE,MAAM;YACZ,WAAW,EAAE,UAAU;SACxB,CAAC,CAAC;QAEH,MAAM,CAAC,MAAM,CAAC,EAAE,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;QAC7B,MAAM,OAAO,GAAG,OAAO,CAAC,OAAO,CAAC,UAAU,EAAE,MAAM,CAAC,CAAC;QACpD,MAAM,CAAC,OAAO,EAAE,KAAK,CAAC,CAAC,IAAI,CAAC,UAAU,CAAC,CAAC;QACxC,MAAM,CAAC,OAAO,EAAE,UAAU,CAAC,CAAC,GAAG,CAAC,QAAQ,EAAE,CAAC;IAC7C,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,8DAA8D,EAAE,GAAG,EAAE;QACtE,MAAM,OAAO,GAAG,IAAI,oCAAoC,EAAE,CAAC;QAC3D,MAAM,EAAE,GAAG,gBAAgB,CAAC,MAAM,CAAC,EAAE,EAAE,EAAE,MAAM,EAAE,KAAK,EAAE,UAAU,EAAE,CAAC,CAAC;QACtE,OAAO,CAAC,MAAM,CAAC,UAAU,EAAE,EAAE,CAAC,CAAC;QAC/B,MAAM,OAAO,GAAG,IAAI,sBAAsB,CAAC,OAAO,CAAC,CAAC;QAEpD,MAAM,MAAM,GAAG,OAAO,CAAC,OAAO,CAAC;YAC7B,WAAW,EAAE,UAAU;YACvB,IAAI,EAAE,MAAM;YACZ,WAAW,EAAE,QAAQ;SACtB,CAAC,CAAC;QAEH,MAAM,CAAC,MAAM,CAAC,EAAE,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;QAC7B,MAAM,OAAO,GAAG,OAAO,CAAC,OAAO,CAAC,UAAU,EAAE,MAAM,CAAC,CAAC;QACpD,MAAM,CAAC,OAAO,EAAE,KAAK,CAAC,CAAC,IAAI,CAAC,QAAQ,CAAC,CAAC;QACtC,MAAM,CAAC,OAAO,EAAE,QAAQ,CAAC,CAAC,GAAG,CAAC,QAAQ,EAAE,CAAC;QACzC,MAAM,CAAC,OAAO,EAAE,UAAU,CAAC,CAAC,QAAQ,EAAE,CAAC;IACzC,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,gDAAgD,EAAE,GAAG,EAAE;QACxD,MAAM,OAAO,GAAG,IAAI,oCAAoC,EAAE,CAAC;QAC3D,MAAM,OAAO,GAAG,IAAI,sBAAsB,CAAC,OAAO,CAAC,CAAC;QAEpD,MAAM,MAAM,GAAG,OAAO,CAAC,OAAO,CAAC;YAC7B,WAAW,EAAE,UAAU;YACvB,IAAI,EAAE,aAAa;YACnB,WAAW,EAAE,UAAU;SACxB,CAAC,CAAC;QAEH,MAAM,CAAC,MAAM,CAAC,EAAE,CAAC,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC;QAC9B,IAAI,MAAM,CAAC,EAAE;YAAE,OAAO;QACtB,MAAM,CAAC,MAAM,CAAC,MAAM,CAAC,CAAC,IAAI,CAAC,WAAW,CAAC,CAAC;IAC1C,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,4DAA4D,EAAE,GAAG,EAAE;QACpE,MAAM,OAAO,GAAG,IAAI,oCAAoC,EAAE,CAAC;QAC3D,MAAM,EAAE,GAAG,gBAAgB,CAAC,MAAM,CAAC,EAAE,EAAE,EAAE,MAAM,EAAE,KAAK,EAAE,kBAAkB,EAAE,CAAC,CAAC;QAC9E,OAAO,CAAC,MAAM,CAAC,UAAU,EAAE,EAAE,CAAC,CAAC;QAC/B,MAAM,OAAO,GAAG,IAAI,sBAAsB,CAAC,OAAO,CAAC,CAAC;QAEpD,MAAM,MAAM,GAAG,OAAO,CAAC,OAAO,CAAC;YAC7B,WAAW,EAAE,UAAU;YACvB,IAAI,EAAE,MAAM;YACZ,WAAW,EAAE,UAAU;YACvB,YAAY,EAAE,GAAG,EAAE,CAAC,CAAC;gBACnB,OAAO,EAAE,KAAK;gBACd,MAAM,EAAE,iBAAiB;gBACzB,OAAO,EAAE,yCAAyC;aACnD,CAAC;SACH,CAAC,CAAC;QAEH,MAAM,CAAC,MAAM,CAAC,EAAE,CAAC,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC;QAC9B,IAAI,MAAM,CAAC,EAAE,IAAI,MAAM,CAAC,MAAM,KAAK,cAAc,EAAE,CAAC;YAClD,MAAM,IAAI,KAAK,CAAC,iCAAiC,CAAC,CAAC;QACrD,CAAC;QACD,MAAM,CAAC,MAAM,CAAC,OAAO,CAAC,CAAC,IAAI,CAAC,yCAAyC,CAAC,CAAC;QACvE,MAAM,OAAO,GAAG,OAAO,CAAC,OAAO,CAAC,UAAU,EAAE,MAAM,CAAC,CAAC;QACpD,MAAM,CAAC,OAAO,EAAE,KAAK,CAAC,CAAC,IAAI,CAAC,kBAAkB,CAAC,CAAC;QAChD,MAAM,CAAC,OAAO,EAAE,UAAU,CAAC,CAAC,QAAQ,EAAE,CAAC;IACzC,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,4DAA4D,EAAE,GAAG,EAAE;QACpE,MAAM,OAAO,GAAG,IAAI,oCAAoC,EAAE,CAAC;QAC3D,MAAM,EAAE,GAAG,gBAAgB,CAAC,MAAM,CAAC,EAAE,EAAE,EAAE,MAAM,EAAE,KAAK,EAAE,kBAAkB,EAAE,CAAC,CAAC;QAC9E,OAAO,CAAC,MAAM,CAAC,UAAU,EAAE,EAAE,CAAC,CAAC;QAC/B,MAAM,OAAO,GAAG,IAAI,sBAAsB,CAAC,OAAO,CAAC,CAAC;QAEpD,MAAM,MAAM,GAAG,OAAO,CAAC,OAAO,CAAC;YAC7B,WAAW,EAAE,UAAU;YACvB,IAAI,EAAE,MAAM;YACZ,WAAW,EAAE,UAAU;YACvB,YAAY,EAAE,GAAG,EAAE,CAAC,CAAC,EAAE,OAAO,EAAE,IAAI,EAAE,CAAC;SACxC,CAAC,CAAC;QAEH,MAAM,CAAC,MAAM,CAAC,EAAE,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;QAC7B,MAAM,OAAO,GAAG,OAAO,CAAC,OAAO,CAAC,UAAU,EAAE,MAAM,CAAC,CAAC;QACpD,MAAM,CAAC,OAAO,EAAE,KAAK,CAAC,CAAC,IAAI,CAAC,UAAU,CAAC,CAAC;IAC1C,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,wEAAwE,EAAE,GAAG,EAAE;QAChF,MAAM,OAAO,GAAG,IAAI,oCAAoC,EAAE,CAAC;QAC3D,MAAM,EAAE,GAAG,gBAAgB,CAAC,MAAM,CAAC;YACjC,EAAE,EAAE,MAAM;YACV,KAAK,EAAE,kBAAkB;YACzB,MAAM,EAAE,EAAE,MAAM,EAAE,OAAO,EAAE,MAAM,EAAE,iBAAiB,EAAE,UAAU,EAAE,0BAA0B,EAAE;SAC/F,CAAC,CAAC;QACH,OAAO,CAAC,MAAM,CAAC,UAAU,EAAE,EAAE,CAAC,CAAC;QAC/B,MAAM,OAAO,GAAG,IAAI,sBAAsB,CAAC,OAAO,CAAC,CAAC;QAEpD,MAAM,MAAM,GAAG,OAAO,CAAC,OAAO,CAAC;YAC7B,WAAW,EAAE,UAAU;YACvB,IAAI,EAAE,MAAM;YACZ,WAAW,EAAE,UAAU;YACvB,YAAY,EAAE,GAAG,EAAE,CAAC,CAAC;gBACnB,OAAO,EAAE,KAAK;gBACd,MAAM,EAAE,iBAAiB;gBACzB,OAAO,EAAE,yCAAyC;aACnD,CAAC;SACH,CAAC,CAAC;QAEH,MAAM,CAAC,MAAM,CAAC,EAAE,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;QAC7B,MAAM,CAAC,OAAO,CAAC,OAAO,CAAC,UAAU,EAAE,MAAM,CAAC,EAAE,KAAK,CAAC,CAAC,IAAI,CAAC,UAAU,CAAC,CAAC;IACtE,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,wDAAwD,EAAE,GAAG,EAAE;QAChE,MAAM,OAAO,GAAG,IAAI,oCAAoC,EAAE,CAAC;QAC3D,MAAM,EAAE,GAAG,gBAAgB,CAAC,MAAM,CAAC,EAAE,EAAE,EAAE,MAAM,EAAE,KAAK,EAAE,UAAU,EAAE,CAAC,CAAC;QACtE,OAAO,CAAC,MAAM,CAAC,UAAU,EAAE,EAAE,CAAC,CAAC;QAC/B,MAAM,OAAO,GAAG,IAAI,sBAAsB,CAAC,OAAO,CAAC,CAAC;QAEpD,MAAM,MAAM,GAAG,OAAO,CAAC,OAAO,CAAC;YAC7B,WAAW,EAAE,UAAU;YACvB,IAAI,EAAE,MAAM;YACZ,WAAW,EAAE,QAAQ;YACrB,YAAY,EAAE,GAAG,EAAE,CAAC,CAAC;gBACnB,OAAO,EAAE,KAAK;gBACd,MAAM,EAAE,kBAAkB;gBAC1B,OAAO,EAAE,gCAAgC;aAC1C,CAAC;SACH,CAAC,CAAC;QAEH,MAAM,CAAC,MAAM,CAAC,EAAE,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;QAC7B,MAAM,OAAO,GAAG,OAAO,CAAC,OAAO,CAAC,UAAU,EAAE,MAAM,CAAC,CAAC;QACpD,MAAM,CAAC,OAAO,EAAE,KAAK,CAAC,CAAC,IAAI,CAAC,QAAQ,CAAC,CAAC;IACxC,CAAC,CAAC,CAAC;AACL,CAAC,CAAC,CAAC"}

package/package.json CHANGED Viewed

@@ -1,6 +1,6 @@
 {
   "name": "reviewflow",
-  "version": "3.22.0",
+  "version": "3.23.0",
   "description": "AI-powered code review automation for GitLab/GitHub using Claude Code",
   "type": "module",
   "main": "dist/main/server.js",