reviewflow 3.22.0 → 3.23.0
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/CHANGELOG.md +9 -0
- package/README.md +44 -1
- package/dist/config/projectConfig.d.ts +1 -0
- package/dist/config/projectConfig.d.ts.map +1 -1
- package/dist/config/projectConfig.js +13 -0
- package/dist/config/projectConfig.js.map +1 -1
- package/dist/main/routes.d.ts.map +1 -1
- package/dist/main/routes.js +20 -0
- package/dist/main/routes.js.map +1 -1
- package/dist/modules/platform-integration/entities/approvalRevocation/approvalRevocation.gateway.d.ts +10 -0
- package/dist/modules/platform-integration/entities/approvalRevocation/approvalRevocation.gateway.d.ts.map +1 -0
- package/dist/modules/platform-integration/entities/approvalRevocation/approvalRevocation.gateway.js +2 -0
- package/dist/modules/platform-integration/entities/approvalRevocation/approvalRevocation.gateway.js.map +1 -0
- package/dist/modules/platform-integration/entities/github/githubIssueCommentEvent.guard.d.ts +50 -0
- package/dist/modules/platform-integration/entities/github/githubIssueCommentEvent.guard.d.ts.map +1 -0
- package/dist/modules/platform-integration/entities/github/githubIssueCommentEvent.guard.js +21 -0
- package/dist/modules/platform-integration/entities/github/githubIssueCommentEvent.guard.js.map +1 -0
- package/dist/modules/platform-integration/entities/github/githubPullRequestReviewEvent.guard.d.ts +53 -0
- package/dist/modules/platform-integration/entities/github/githubPullRequestReviewEvent.guard.d.ts.map +1 -0
- package/dist/modules/platform-integration/entities/github/githubPullRequestReviewEvent.guard.js +23 -0
- package/dist/modules/platform-integration/entities/github/githubPullRequestReviewEvent.guard.js.map +1 -0
- package/dist/modules/platform-integration/entities/gitlab/gitlabNoteEvent.guard.d.ts +62 -0
- package/dist/modules/platform-integration/entities/gitlab/gitlabNoteEvent.guard.d.ts.map +1 -0
- package/dist/modules/platform-integration/entities/gitlab/gitlabNoteEvent.guard.js +33 -0
- package/dist/modules/platform-integration/entities/gitlab/gitlabNoteEvent.guard.js.map +1 -0
- package/dist/modules/platform-integration/entities/noteComment/noteCommentPost.gateway.d.ts +9 -0
- package/dist/modules/platform-integration/entities/noteComment/noteCommentPost.gateway.d.ts.map +1 -0
- package/dist/modules/platform-integration/entities/noteComment/noteCommentPost.gateway.js +2 -0
- package/dist/modules/platform-integration/entities/noteComment/noteCommentPost.gateway.js.map +1 -0
- package/dist/modules/platform-integration/interface-adapters/controllers/webhook/eventFilter.d.ts +28 -0
- package/dist/modules/platform-integration/interface-adapters/controllers/webhook/eventFilter.d.ts.map +1 -1
- package/dist/modules/platform-integration/interface-adapters/controllers/webhook/eventFilter.js +48 -0
- package/dist/modules/platform-integration/interface-adapters/controllers/webhook/eventFilter.js.map +1 -1
- package/dist/modules/platform-integration/interface-adapters/controllers/webhook/github.controller.d.ts +10 -0
- package/dist/modules/platform-integration/interface-adapters/controllers/webhook/github.controller.d.ts.map +1 -1
- package/dist/modules/platform-integration/interface-adapters/controllers/webhook/github.controller.js +156 -1
- package/dist/modules/platform-integration/interface-adapters/controllers/webhook/github.controller.js.map +1 -1
- package/dist/modules/platform-integration/interface-adapters/controllers/webhook/gitlab.controller.d.ts +10 -0
- package/dist/modules/platform-integration/interface-adapters/controllers/webhook/gitlab.controller.d.ts.map +1 -1
- package/dist/modules/platform-integration/interface-adapters/controllers/webhook/gitlab.controller.js +126 -5
- package/dist/modules/platform-integration/interface-adapters/controllers/webhook/gitlab.controller.js.map +1 -1
- package/dist/modules/platform-integration/interface-adapters/gateways/cli/approvalRevocation.github.cli.gateway.d.ts +8 -0
- package/dist/modules/platform-integration/interface-adapters/gateways/cli/approvalRevocation.github.cli.gateway.d.ts.map +1 -0
- package/dist/modules/platform-integration/interface-adapters/gateways/cli/approvalRevocation.github.cli.gateway.js +15 -0
- package/dist/modules/platform-integration/interface-adapters/gateways/cli/approvalRevocation.github.cli.gateway.js.map +1 -0
- package/dist/modules/platform-integration/interface-adapters/gateways/cli/approvalRevocation.gitlab.cli.gateway.d.ts +8 -0
- package/dist/modules/platform-integration/interface-adapters/gateways/cli/approvalRevocation.gitlab.cli.gateway.d.ts.map +1 -0
- package/dist/modules/platform-integration/interface-adapters/gateways/cli/approvalRevocation.gitlab.cli.gateway.js +12 -0
- package/dist/modules/platform-integration/interface-adapters/gateways/cli/approvalRevocation.gitlab.cli.gateway.js.map +1 -0
- package/dist/modules/platform-integration/interface-adapters/gateways/cli/noteCommentPost.github.cli.gateway.d.ts +8 -0
- package/dist/modules/platform-integration/interface-adapters/gateways/cli/noteCommentPost.github.cli.gateway.d.ts.map +1 -0
- package/dist/modules/platform-integration/interface-adapters/gateways/cli/noteCommentPost.github.cli.gateway.js +11 -0
- package/dist/modules/platform-integration/interface-adapters/gateways/cli/noteCommentPost.github.cli.gateway.js.map +1 -0
- package/dist/modules/platform-integration/interface-adapters/gateways/cli/noteCommentPost.gitlab.cli.gateway.d.ts +8 -0
- package/dist/modules/platform-integration/interface-adapters/gateways/cli/noteCommentPost.gitlab.cli.gateway.d.ts.map +1 -0
- package/dist/modules/platform-integration/interface-adapters/gateways/cli/noteCommentPost.gitlab.cli.gateway.js +12 -0
- package/dist/modules/platform-integration/interface-adapters/gateways/cli/noteCommentPost.gitlab.cli.gateway.js.map +1 -0
- package/dist/modules/tracking/entities/bypassMarker/bypassMarker.d.ts +10 -0
- package/dist/modules/tracking/entities/bypassMarker/bypassMarker.d.ts.map +1 -0
- package/dist/modules/tracking/entities/bypassMarker/bypassMarker.js +17 -0
- package/dist/modules/tracking/entities/bypassMarker/bypassMarker.js.map +1 -0
- package/dist/modules/tracking/entities/qualityGate/qualityGate.d.ts +15 -0
- package/dist/modules/tracking/entities/qualityGate/qualityGate.d.ts.map +1 -0
- package/dist/modules/tracking/entities/qualityGate/qualityGate.js +24 -0
- package/dist/modules/tracking/entities/qualityGate/qualityGate.js.map +1 -0
- package/dist/modules/tracking/entities/tracking/trackedMr.d.ts +6 -0
- package/dist/modules/tracking/entities/tracking/trackedMr.d.ts.map +1 -1
- package/dist/modules/tracking/entities/tracking/trackedMr.js.map +1 -1
- package/dist/modules/tracking/interface-adapters/controllers/http/mrTracking.routes.d.ts +1 -0
- package/dist/modules/tracking/interface-adapters/controllers/http/mrTracking.routes.d.ts.map +1 -1
- package/dist/modules/tracking/interface-adapters/controllers/http/mrTracking.routes.js +14 -3
- package/dist/modules/tracking/interface-adapters/controllers/http/mrTracking.routes.js.map +1 -1
- package/dist/modules/tracking/interface-adapters/controllers/http/mrTrackingAdvanced.routes.d.ts.map +1 -1
- package/dist/modules/tracking/interface-adapters/controllers/http/mrTrackingAdvanced.routes.js +1 -0
- package/dist/modules/tracking/interface-adapters/controllers/http/mrTrackingAdvanced.routes.js.map +1 -1
- package/dist/modules/tracking/usecases/tracking/handlePlatformApproval.usecase.d.ts +28 -0
- package/dist/modules/tracking/usecases/tracking/handlePlatformApproval.usecase.d.ts.map +1 -0
- package/dist/modules/tracking/usecases/tracking/handlePlatformApproval.usecase.js +37 -0
- package/dist/modules/tracking/usecases/tracking/handlePlatformApproval.usecase.js.map +1 -0
- package/dist/modules/tracking/usecases/tracking/recordBypass.usecase.d.ts +28 -0
- package/dist/modules/tracking/usecases/tracking/recordBypass.usecase.d.ts.map +1 -0
- package/dist/modules/tracking/usecases/tracking/recordBypass.usecase.js +28 -0
- package/dist/modules/tracking/usecases/tracking/recordBypass.usecase.js.map +1 -0
- package/dist/modules/tracking/usecases/tracking/recordReviewCompletion.usecase.d.ts +1 -0
- package/dist/modules/tracking/usecases/tracking/recordReviewCompletion.usecase.d.ts.map +1 -1
- package/dist/modules/tracking/usecases/tracking/recordReviewCompletion.usecase.js +10 -1
- package/dist/modules/tracking/usecases/tracking/recordReviewCompletion.usecase.js.map +1 -1
- package/dist/modules/tracking/usecases/tracking/trackAssignment.usecase.d.ts.map +1 -1
- package/dist/modules/tracking/usecases/tracking/trackAssignment.usecase.js +1 -0
- package/dist/modules/tracking/usecases/tracking/trackAssignment.usecase.js.map +1 -1
- package/dist/modules/tracking/usecases/tracking/transitionState.usecase.d.ts +15 -2
- package/dist/modules/tracking/usecases/tracking/transitionState.usecase.d.ts.map +1 -1
- package/dist/modules/tracking/usecases/tracking/transitionState.usecase.js +8 -2
- package/dist/modules/tracking/usecases/tracking/transitionState.usecase.js.map +1 -1
- package/dist/tests/acceptance/170-prebuilt-worktree-lifecycle.acceptance.test.js +1 -0
- package/dist/tests/acceptance/170-prebuilt-worktree-lifecycle.acceptance.test.js.map +1 -1
- package/dist/tests/acceptance/180-quality-threshold-block-approval-iter-B.acceptance.test.d.ts +17 -0
- package/dist/tests/acceptance/180-quality-threshold-block-approval-iter-B.acceptance.test.d.ts.map +1 -0
- package/dist/tests/acceptance/180-quality-threshold-block-approval-iter-B.acceptance.test.js +294 -0
- package/dist/tests/acceptance/180-quality-threshold-block-approval-iter-B.acceptance.test.js.map +1 -0
- package/dist/tests/acceptance/180-quality-threshold-block-approval-iter-C.acceptance.test.d.ts +16 -0
- package/dist/tests/acceptance/180-quality-threshold-block-approval-iter-C.acceptance.test.d.ts.map +1 -0
- package/dist/tests/acceptance/180-quality-threshold-block-approval-iter-C.acceptance.test.js +316 -0
- package/dist/tests/acceptance/180-quality-threshold-block-approval-iter-C.acceptance.test.js.map +1 -0
- package/dist/tests/acceptance/180-quality-threshold-block-approval.acceptance.test.d.ts +20 -0
- package/dist/tests/acceptance/180-quality-threshold-block-approval.acceptance.test.d.ts.map +1 -0
- package/dist/tests/acceptance/180-quality-threshold-block-approval.acceptance.test.js +146 -0
- package/dist/tests/acceptance/180-quality-threshold-block-approval.acceptance.test.js.map +1 -0
- package/dist/tests/factories/projectConfig.factory.d.ts +1 -0
- package/dist/tests/factories/projectConfig.factory.d.ts.map +1 -1
- package/dist/tests/factories/projectConfig.factory.js +3 -0
- package/dist/tests/factories/projectConfig.factory.js.map +1 -1
- package/dist/tests/factories/trackedMr.factory.d.ts.map +1 -1
- package/dist/tests/factories/trackedMr.factory.js +1 -0
- package/dist/tests/factories/trackedMr.factory.js.map +1 -1
- package/dist/tests/stubs/approvalRevocation.stub.d.ts +7 -0
- package/dist/tests/stubs/approvalRevocation.stub.d.ts.map +1 -0
- package/dist/tests/stubs/approvalRevocation.stub.js +11 -0
- package/dist/tests/stubs/approvalRevocation.stub.js.map +1 -0
- package/dist/tests/stubs/noteCommentPost.stub.d.ts +6 -0
- package/dist/tests/stubs/noteCommentPost.stub.d.ts.map +1 -0
- package/dist/tests/stubs/noteCommentPost.stub.js +7 -0
- package/dist/tests/stubs/noteCommentPost.stub.js.map +1 -0
- package/dist/tests/units/config/projectConfig.test.js +62 -0
- package/dist/tests/units/config/projectConfig.test.js.map +1 -1
- package/dist/tests/units/interface-adapters/controllers/webhook/eventFilter.test.js +50 -1
- package/dist/tests/units/interface-adapters/controllers/webhook/eventFilter.test.js.map +1 -1
- package/dist/tests/units/interface-adapters/controllers/webhook/github.controller.test.js +6 -0
- package/dist/tests/units/interface-adapters/controllers/webhook/github.controller.test.js.map +1 -1
- package/dist/tests/units/interface-adapters/controllers/webhook/gitlab.controller.test.js +10 -0
- package/dist/tests/units/interface-adapters/controllers/webhook/gitlab.controller.test.js.map +1 -1
- package/dist/tests/units/modules/platform-integration/entities/github/githubIssueCommentEvent.guard.test.d.ts +2 -0
- package/dist/tests/units/modules/platform-integration/entities/github/githubIssueCommentEvent.guard.test.d.ts.map +1 -0
- package/dist/tests/units/modules/platform-integration/entities/github/githubIssueCommentEvent.guard.test.js +39 -0
- package/dist/tests/units/modules/platform-integration/entities/github/githubIssueCommentEvent.guard.test.js.map +1 -0
- package/dist/tests/units/modules/platform-integration/entities/github/githubPullRequestReviewEvent.guard.test.d.ts +2 -0
- package/dist/tests/units/modules/platform-integration/entities/github/githubPullRequestReviewEvent.guard.test.d.ts.map +1 -0
- package/dist/tests/units/modules/platform-integration/entities/github/githubPullRequestReviewEvent.guard.test.js +54 -0
- package/dist/tests/units/modules/platform-integration/entities/github/githubPullRequestReviewEvent.guard.test.js.map +1 -0
- package/dist/tests/units/modules/platform-integration/entities/gitlab/gitlabNoteEvent.guard.test.d.ts +2 -0
- package/dist/tests/units/modules/platform-integration/entities/gitlab/gitlabNoteEvent.guard.test.d.ts.map +1 -0
- package/dist/tests/units/modules/platform-integration/entities/gitlab/gitlabNoteEvent.guard.test.js +48 -0
- package/dist/tests/units/modules/platform-integration/entities/gitlab/gitlabNoteEvent.guard.test.js.map +1 -0
- package/dist/tests/units/modules/tracking/entities/bypassMarker/bypassMarker.test.d.ts +2 -0
- package/dist/tests/units/modules/tracking/entities/bypassMarker/bypassMarker.test.d.ts.map +1 -0
- package/dist/tests/units/modules/tracking/entities/bypassMarker/bypassMarker.test.js +29 -0
- package/dist/tests/units/modules/tracking/entities/bypassMarker/bypassMarker.test.js.map +1 -0
- package/dist/tests/units/modules/tracking/entities/qualityGate/qualityGate.test.d.ts +2 -0
- package/dist/tests/units/modules/tracking/entities/qualityGate/qualityGate.test.d.ts.map +1 -0
- package/dist/tests/units/modules/tracking/entities/qualityGate/qualityGate.test.js +52 -0
- package/dist/tests/units/modules/tracking/entities/qualityGate/qualityGate.test.js.map +1 -0
- package/dist/tests/units/modules/tracking/interface-adapters/controllers/http/mrTracking.routes.test.d.ts +2 -0
- package/dist/tests/units/modules/tracking/interface-adapters/controllers/http/mrTracking.routes.test.d.ts.map +1 -0
- package/dist/tests/units/modules/tracking/interface-adapters/controllers/http/mrTracking.routes.test.js +103 -0
- package/dist/tests/units/modules/tracking/interface-adapters/controllers/http/mrTracking.routes.test.js.map +1 -0
- package/dist/tests/units/modules/tracking/usecases/tracking/handlePlatformApproval.usecase.test.d.ts +2 -0
- package/dist/tests/units/modules/tracking/usecases/tracking/handlePlatformApproval.usecase.test.d.ts.map +1 -0
- package/dist/tests/units/modules/tracking/usecases/tracking/handlePlatformApproval.usecase.test.js +113 -0
- package/dist/tests/units/modules/tracking/usecases/tracking/handlePlatformApproval.usecase.test.js.map +1 -0
- package/dist/tests/units/modules/tracking/usecases/tracking/recordBypass.usecase.test.d.ts +2 -0
- package/dist/tests/units/modules/tracking/usecases/tracking/recordBypass.usecase.test.d.ts.map +1 -0
- package/dist/tests/units/modules/tracking/usecases/tracking/recordBypass.usecase.test.js +77 -0
- package/dist/tests/units/modules/tracking/usecases/tracking/recordBypass.usecase.test.js.map +1 -0
- package/dist/tests/units/modules/worktree-management/usecases/sweepStaleWorktrees.usecase.test.js +1 -0
- package/dist/tests/units/modules/worktree-management/usecases/sweepStaleWorktrees.usecase.test.js.map +1 -1
- package/dist/tests/units/usecases/tracking/recordReviewCompletion.usecase.test.js +71 -0
- package/dist/tests/units/usecases/tracking/recordReviewCompletion.usecase.test.js.map +1 -1
- package/dist/tests/units/usecases/tracking/transitionState.usecase.test.js +87 -4
- package/dist/tests/units/usecases/tracking/transitionState.usecase.test.js.map +1 -1
- package/package.json +1 -1
|
@@ -0,0 +1,294 @@
|
|
|
1
|
+
/**
|
|
2
|
+
* SPEC-180 — Block approval below quality threshold (Iteration B)
|
|
3
|
+
*
|
|
4
|
+
* Outer-loop acceptance test (SDD) for the comment-based bypass mechanism.
|
|
5
|
+
* Exercises POST /webhooks/gitlab with X-Gitlab-Event: Note Hook events and
|
|
6
|
+
* the chained recordReviewCompletion → bypass-reset path.
|
|
7
|
+
*
|
|
8
|
+
* In-scope scenarios from docs/specs/180-quality-threshold-block-approval.md:
|
|
9
|
+
* 4: bypass with reason → state transition to approved allowed + bypass recorded
|
|
10
|
+
* 5: bypass without reason → reject with FR message + no bypass stored + FR comment posted
|
|
11
|
+
* 9: new review after bypass → bypass cleared + state re-evaluated under normal gate
|
|
12
|
+
* 10: bypass on already-qualified MR → bypass recorded + no state change
|
|
13
|
+
*
|
|
14
|
+
* Out of scope: scenario 6 (platform unapprove on platform-side approval — iter C).
|
|
15
|
+
*/
|
|
16
|
+
import { vi } from 'vitest';
|
|
17
|
+
const mockRepoConfig = {
|
|
18
|
+
name: 'test-project',
|
|
19
|
+
platform: 'gitlab',
|
|
20
|
+
localPath: '/home/user/projects/test-project',
|
|
21
|
+
remoteUrl: 'https://gitlab.com/test-org/test-project.git',
|
|
22
|
+
skill: 'review-front',
|
|
23
|
+
enabled: true,
|
|
24
|
+
};
|
|
25
|
+
const mockConfig = {
|
|
26
|
+
server: { port: 3000 },
|
|
27
|
+
user: { gitlabUsername: 'claude-bot', githubUsername: 'claude-bot' },
|
|
28
|
+
queue: { maxConcurrent: 1, deduplicationWindowMs: 60000 },
|
|
29
|
+
repositories: [mockRepoConfig],
|
|
30
|
+
};
|
|
31
|
+
vi.mock('@/config/loader.js', () => ({
|
|
32
|
+
loadConfig: vi.fn(() => mockConfig),
|
|
33
|
+
findRepositoryByProjectPath: vi.fn(() => mockRepoConfig),
|
|
34
|
+
findRepositoryByRemoteUrl: vi.fn(() => mockRepoConfig),
|
|
35
|
+
}));
|
|
36
|
+
vi.mock('@/security/verifier.js', () => ({
|
|
37
|
+
verifyGitLabSignature: vi.fn(() => ({ valid: true })),
|
|
38
|
+
getGitLabEventType: vi.fn(() => 'Note Hook'),
|
|
39
|
+
}));
|
|
40
|
+
vi.mock('@/frameworks/queue/pQueueAdapter.js', () => ({
|
|
41
|
+
createJobId: vi.fn((prefix, projectPath, mrNumber) => `${prefix}-${projectPath}-${mrNumber}`),
|
|
42
|
+
enqueueReview: vi.fn(() => Promise.resolve(true)),
|
|
43
|
+
updateJobProgress: vi.fn(),
|
|
44
|
+
cancelJob: vi.fn(),
|
|
45
|
+
}));
|
|
46
|
+
vi.mock('@/claude/invoker.js', () => ({
|
|
47
|
+
invokeClaudeReview: vi.fn(),
|
|
48
|
+
sendNotification: vi.fn(),
|
|
49
|
+
}));
|
|
50
|
+
vi.mock('@/main/websocket.js', () => ({
|
|
51
|
+
startWatchingReviewContext: vi.fn(),
|
|
52
|
+
stopWatchingReviewContext: vi.fn(),
|
|
53
|
+
}));
|
|
54
|
+
vi.mock('@/config/projectConfig.js', () => ({
|
|
55
|
+
loadProjectConfig: vi.fn(() => ({ qualityThreshold: 7 })),
|
|
56
|
+
getProjectAgents: vi.fn(() => null),
|
|
57
|
+
getProjectAgentsOrFocusDefaults: vi.fn(() => null),
|
|
58
|
+
getFollowupAgents: vi.fn(() => null),
|
|
59
|
+
getProjectLanguage: vi.fn(() => 'en'),
|
|
60
|
+
}));
|
|
61
|
+
import { describe, it, expect, beforeEach, afterEach } from 'vitest';
|
|
62
|
+
import { handleGitLabWebhook } from '../../modules/platform-integration/interface-adapters/controllers/webhook/gitlab.controller.js';
|
|
63
|
+
import { InMemoryReviewRequestTrackingGateway } from '../../tests/stubs/reviewRequestTracking.stub.js';
|
|
64
|
+
import { StubNoteCommentPostGateway } from '../../tests/stubs/noteCommentPost.stub.js';
|
|
65
|
+
import { TrackedMrFactory } from '../../tests/factories/trackedMr.factory.js';
|
|
66
|
+
import { createStubLogger } from '../../tests/stubs/logger.stub.js';
|
|
67
|
+
import { RecordBypassUseCase } from '../../modules/tracking/usecases/tracking/recordBypass.usecase.js';
|
|
68
|
+
import { RecordReviewCompletionUseCase } from '../../modules/tracking/usecases/tracking/recordReviewCompletion.usecase.js';
|
|
69
|
+
import { TransitionStateUseCase } from '../../modules/tracking/usecases/tracking/transitionState.usecase.js';
|
|
70
|
+
import { TrackAssignmentUseCase } from '../../modules/tracking/usecases/tracking/trackAssignment.usecase.js';
|
|
71
|
+
import { RecordPushUseCase } from '../../modules/tracking/usecases/tracking/recordPush.usecase.js';
|
|
72
|
+
import { CheckFollowupNeededUseCase } from '../../modules/tracking/usecases/tracking/checkFollowupNeeded.usecase.js';
|
|
73
|
+
import { SyncThreadsUseCase } from '../../modules/tracking/usecases/tracking/syncThreads.usecase.js';
|
|
74
|
+
import { evaluateQualityGate } from '../../modules/tracking/entities/qualityGate/qualityGate.js';
|
|
75
|
+
const PROJECT_PATH = '/home/user/projects/test-project';
|
|
76
|
+
const MR_NUMBER = 42;
|
|
77
|
+
const MR_ID = `gitlab-test-org/test-project-${MR_NUMBER}`;
|
|
78
|
+
function buildNoteEvent(noteBody, authorUsername = 'alice') {
|
|
79
|
+
return {
|
|
80
|
+
object_kind: 'note',
|
|
81
|
+
event_type: 'note',
|
|
82
|
+
user: { username: authorUsername, name: authorUsername },
|
|
83
|
+
project: {
|
|
84
|
+
id: 1,
|
|
85
|
+
name: 'test-project',
|
|
86
|
+
path_with_namespace: 'test-org/test-project',
|
|
87
|
+
web_url: 'https://gitlab.com/test-org/test-project',
|
|
88
|
+
git_http_url: 'https://gitlab.com/test-org/test-project.git',
|
|
89
|
+
},
|
|
90
|
+
object_attributes: {
|
|
91
|
+
id: 999,
|
|
92
|
+
note: noteBody,
|
|
93
|
+
noteable_type: 'MergeRequest',
|
|
94
|
+
noteable_id: MR_NUMBER,
|
|
95
|
+
},
|
|
96
|
+
merge_request: {
|
|
97
|
+
iid: MR_NUMBER,
|
|
98
|
+
title: 'Test MR',
|
|
99
|
+
state: 'opened',
|
|
100
|
+
source_branch: 'feature/test',
|
|
101
|
+
target_branch: 'main',
|
|
102
|
+
url: `https://gitlab.com/test-org/test-project/-/merge_requests/${MR_NUMBER}`,
|
|
103
|
+
},
|
|
104
|
+
};
|
|
105
|
+
}
|
|
106
|
+
function createDeterministicNow() {
|
|
107
|
+
return () => '2026-05-26T12:00:00.000Z';
|
|
108
|
+
}
|
|
109
|
+
function buildDeps(tracking, noteCommentPost) {
|
|
110
|
+
const threadFetchGateway = { fetchThreads: vi.fn(() => []) };
|
|
111
|
+
return {
|
|
112
|
+
reviewContextGateway: {
|
|
113
|
+
create: vi.fn(() => ({ success: true, filePath: '' })),
|
|
114
|
+
read: vi.fn(() => null),
|
|
115
|
+
delete: vi.fn(() => ({ success: true, deleted: true })),
|
|
116
|
+
exists: vi.fn(() => false),
|
|
117
|
+
getFilePath: vi.fn(() => ''),
|
|
118
|
+
appendAction: vi.fn(() => ({ success: true })),
|
|
119
|
+
updateProgress: vi.fn(() => ({ success: true })),
|
|
120
|
+
setResult: vi.fn(() => ({ success: true })),
|
|
121
|
+
},
|
|
122
|
+
threadFetchGateway,
|
|
123
|
+
diffMetadataFetchGateway: { fetchDiffMetadata: vi.fn(() => undefined) },
|
|
124
|
+
diffStatsFetchGateway: { fetchDiffStats: vi.fn(() => null) },
|
|
125
|
+
trackAssignment: new TrackAssignmentUseCase(tracking),
|
|
126
|
+
recordCompletion: new RecordReviewCompletionUseCase(tracking),
|
|
127
|
+
recordPush: new RecordPushUseCase(tracking),
|
|
128
|
+
transitionState: new TransitionStateUseCase(tracking),
|
|
129
|
+
checkFollowupNeeded: new CheckFollowupNeededUseCase(tracking),
|
|
130
|
+
syncThreads: new SyncThreadsUseCase(tracking, threadFetchGateway),
|
|
131
|
+
recordBypass: new RecordBypassUseCase(tracking),
|
|
132
|
+
noteCommentPostGateway: noteCommentPost,
|
|
133
|
+
now: createDeterministicNow(),
|
|
134
|
+
enforceBudget: {
|
|
135
|
+
execute: vi.fn(async () => ({
|
|
136
|
+
accepted: true,
|
|
137
|
+
status: {
|
|
138
|
+
limitUsd: 200,
|
|
139
|
+
consumedUsd: 0,
|
|
140
|
+
remainingUsd: 200,
|
|
141
|
+
percentUsed: 0,
|
|
142
|
+
exceeded: false,
|
|
143
|
+
periodStart: '2026-05-01T00:00:00.000Z',
|
|
144
|
+
},
|
|
145
|
+
})),
|
|
146
|
+
},
|
|
147
|
+
broadcastBudgetExceeded: vi.fn(),
|
|
148
|
+
getRepositories: vi.fn(() => [mockRepoConfig]),
|
|
149
|
+
removeWorktree: vi.fn(async () => ({ status: 'removed' })),
|
|
150
|
+
};
|
|
151
|
+
}
|
|
152
|
+
describe('Acceptance — SPEC-180 Iteration B: Comment-based bypass', () => {
|
|
153
|
+
let tracking;
|
|
154
|
+
let noteCommentPost;
|
|
155
|
+
let deps;
|
|
156
|
+
let mockReply;
|
|
157
|
+
const logger = createStubLogger();
|
|
158
|
+
beforeEach(() => {
|
|
159
|
+
vi.clearAllMocks();
|
|
160
|
+
tracking = new InMemoryReviewRequestTrackingGateway();
|
|
161
|
+
noteCommentPost = new StubNoteCommentPostGateway();
|
|
162
|
+
deps = buildDeps(tracking, noteCommentPost);
|
|
163
|
+
mockReply = {
|
|
164
|
+
status: vi.fn().mockReturnThis(),
|
|
165
|
+
send: vi.fn().mockReturnThis(),
|
|
166
|
+
};
|
|
167
|
+
});
|
|
168
|
+
afterEach(() => {
|
|
169
|
+
vi.resetAllMocks();
|
|
170
|
+
});
|
|
171
|
+
describe('Rule: bypass with reason overrides the quality gate', () => {
|
|
172
|
+
it('scenario 4 — bypass marker with reason allows approval despite failing gate', async () => {
|
|
173
|
+
tracking.create(PROJECT_PATH, TrackedMrFactory.create({
|
|
174
|
+
id: MR_ID,
|
|
175
|
+
mrNumber: MR_NUMBER,
|
|
176
|
+
platform: 'gitlab',
|
|
177
|
+
project: 'test-org/test-project',
|
|
178
|
+
state: 'pending-approval',
|
|
179
|
+
latestScore: 5,
|
|
180
|
+
openThreads: 1,
|
|
181
|
+
}));
|
|
182
|
+
const noteBody = '/bypass-quality "hotfix critique"';
|
|
183
|
+
const request = {
|
|
184
|
+
body: buildNoteEvent(noteBody),
|
|
185
|
+
headers: {},
|
|
186
|
+
};
|
|
187
|
+
await handleGitLabWebhook(request, mockReply, logger, tracking, deps);
|
|
188
|
+
const afterBypass = tracking.getById(PROJECT_PATH, MR_ID);
|
|
189
|
+
expect(afterBypass?.bypass).toEqual({
|
|
190
|
+
author: 'alice',
|
|
191
|
+
reason: 'hotfix critique',
|
|
192
|
+
recordedAt: '2026-05-26T12:00:00.000Z',
|
|
193
|
+
});
|
|
194
|
+
const transitionResult = deps.transitionState.execute({
|
|
195
|
+
projectPath: PROJECT_PATH,
|
|
196
|
+
mrId: MR_ID,
|
|
197
|
+
targetState: 'approved',
|
|
198
|
+
qualityCheck: (mr) => evaluateQualityGate({
|
|
199
|
+
latestScore: mr.latestScore,
|
|
200
|
+
blockingIssues: mr.openThreads,
|
|
201
|
+
threshold: 7,
|
|
202
|
+
}),
|
|
203
|
+
});
|
|
204
|
+
expect(transitionResult.ok).toBe(true);
|
|
205
|
+
const final = tracking.getById(PROJECT_PATH, MR_ID);
|
|
206
|
+
expect(final?.state).toBe('approved');
|
|
207
|
+
});
|
|
208
|
+
});
|
|
209
|
+
describe('Rule: bypass without reason is rejected with a French message', () => {
|
|
210
|
+
it('scenario 5 — bypass marker without reason posts FR comment and does not store bypass', async () => {
|
|
211
|
+
tracking.create(PROJECT_PATH, TrackedMrFactory.create({
|
|
212
|
+
id: MR_ID,
|
|
213
|
+
mrNumber: MR_NUMBER,
|
|
214
|
+
platform: 'gitlab',
|
|
215
|
+
project: 'test-org/test-project',
|
|
216
|
+
state: 'pending-approval',
|
|
217
|
+
latestScore: 5,
|
|
218
|
+
openThreads: 0,
|
|
219
|
+
}));
|
|
220
|
+
const request = {
|
|
221
|
+
body: buildNoteEvent('/bypass-quality'),
|
|
222
|
+
headers: {},
|
|
223
|
+
};
|
|
224
|
+
await handleGitLabWebhook(request, mockReply, logger, tracking, deps);
|
|
225
|
+
expect(noteCommentPost.calls).toHaveLength(1);
|
|
226
|
+
expect(noteCommentPost.calls[0]).toEqual({
|
|
227
|
+
projectPath: 'test-org/test-project',
|
|
228
|
+
mrNumber: MR_NUMBER,
|
|
229
|
+
body: 'Le bypass nécessite une raison explicite. Format attendu : /bypass-quality "raison"',
|
|
230
|
+
});
|
|
231
|
+
const updated = tracking.getById(PROJECT_PATH, MR_ID);
|
|
232
|
+
expect(updated?.bypass).toBeNull();
|
|
233
|
+
});
|
|
234
|
+
});
|
|
235
|
+
describe('Rule: a new review resets any active bypass', () => {
|
|
236
|
+
it('scenario 9 — new completed review clears bypass and re-evaluates state', () => {
|
|
237
|
+
tracking.create(PROJECT_PATH, TrackedMrFactory.create({
|
|
238
|
+
id: MR_ID,
|
|
239
|
+
mrNumber: MR_NUMBER,
|
|
240
|
+
platform: 'gitlab',
|
|
241
|
+
project: 'test-org/test-project',
|
|
242
|
+
state: 'pending-approval',
|
|
243
|
+
latestScore: 5,
|
|
244
|
+
openThreads: 0,
|
|
245
|
+
bypass: { author: 'alice', reason: 'hotfix critique', recordedAt: '2026-05-25T08:00:00.000Z' },
|
|
246
|
+
}));
|
|
247
|
+
const recordCompletion = new RecordReviewCompletionUseCase(tracking);
|
|
248
|
+
const result = recordCompletion.execute({
|
|
249
|
+
projectPath: PROJECT_PATH,
|
|
250
|
+
mrId: MR_ID,
|
|
251
|
+
reviewData: {
|
|
252
|
+
type: 'review',
|
|
253
|
+
durationMs: 30000,
|
|
254
|
+
score: 8,
|
|
255
|
+
blocking: 0,
|
|
256
|
+
warnings: 0,
|
|
257
|
+
suggestions: 0,
|
|
258
|
+
threadsOpened: 0,
|
|
259
|
+
threadsClosed: 0,
|
|
260
|
+
},
|
|
261
|
+
qualityThreshold: 7,
|
|
262
|
+
});
|
|
263
|
+
expect(result?.bypass).toBeNull();
|
|
264
|
+
expect(result?.state).toBe('pending-approval');
|
|
265
|
+
});
|
|
266
|
+
});
|
|
267
|
+
describe('Rule: bypass on an already-qualified MR is recorded without state change', () => {
|
|
268
|
+
it('scenario 10 — valid bypass stored, state untouched', async () => {
|
|
269
|
+
tracking.create(PROJECT_PATH, TrackedMrFactory.create({
|
|
270
|
+
id: MR_ID,
|
|
271
|
+
mrNumber: MR_NUMBER,
|
|
272
|
+
platform: 'gitlab',
|
|
273
|
+
project: 'test-org/test-project',
|
|
274
|
+
state: 'pending-approval',
|
|
275
|
+
latestScore: 9,
|
|
276
|
+
openThreads: 0,
|
|
277
|
+
}));
|
|
278
|
+
const request = {
|
|
279
|
+
body: buildNoteEvent('/bypass-quality "par précaution"'),
|
|
280
|
+
headers: {},
|
|
281
|
+
};
|
|
282
|
+
await handleGitLabWebhook(request, mockReply, logger, tracking, deps);
|
|
283
|
+
const updated = tracking.getById(PROJECT_PATH, MR_ID);
|
|
284
|
+
expect(updated?.bypass).toEqual({
|
|
285
|
+
author: 'alice',
|
|
286
|
+
reason: 'par précaution',
|
|
287
|
+
recordedAt: '2026-05-26T12:00:00.000Z',
|
|
288
|
+
});
|
|
289
|
+
expect(updated?.state).toBe('pending-approval');
|
|
290
|
+
expect(noteCommentPost.calls).toHaveLength(0);
|
|
291
|
+
});
|
|
292
|
+
});
|
|
293
|
+
});
|
|
294
|
+
//# sourceMappingURL=180-quality-threshold-block-approval-iter-B.acceptance.test.js.map
|
package/dist/tests/acceptance/180-quality-threshold-block-approval-iter-B.acceptance.test.js.map
ADDED
|
@@ -0,0 +1 @@
|
|
|
1
|
+
{"version":3,"file":"180-quality-threshold-block-approval-iter-B.acceptance.test.js","sourceRoot":"","sources":["../../../src/tests/acceptance/180-quality-threshold-block-approval-iter-B.acceptance.test.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;;;;GAcG;AAEH,OAAO,EAAE,EAAE,EAAE,MAAM,QAAQ,CAAC;AAI5B,MAAM,cAAc,GAAqB;IACvC,IAAI,EAAE,cAAc;IACpB,QAAQ,EAAE,QAAQ;IAClB,SAAS,EAAE,kCAAkC;IAC7C,SAAS,EAAE,8CAA8C;IACzD,KAAK,EAAE,cAAc;IACrB,OAAO,EAAE,IAAI;CACd,CAAC;AAEF,MAAM,UAAU,GAAG;IACjB,MAAM,EAAE,EAAE,IAAI,EAAE,IAAI,EAAE;IACtB,IAAI,EAAE,EAAE,cAAc,EAAE,YAAY,EAAE,cAAc,EAAE,YAAY,EAAE;IACpE,KAAK,EAAE,EAAE,aAAa,EAAE,CAAC,EAAE,qBAAqB,EAAE,KAAK,EAAE;IACzD,YAAY,EAAE,CAAC,cAAc,CAAC;CAC/B,CAAC;AAEF,EAAE,CAAC,IAAI,CAAC,oBAAoB,EAAE,GAAG,EAAE,CAAC,CAAC;IACnC,UAAU,EAAE,EAAE,CAAC,EAAE,CAAC,GAAG,EAAE,CAAC,UAAU,CAAC;IACnC,2BAA2B,EAAE,EAAE,CAAC,EAAE,CAAC,GAAG,EAAE,CAAC,cAAc,CAAC;IACxD,yBAAyB,EAAE,EAAE,CAAC,EAAE,CAAC,GAAG,EAAE,CAAC,cAAc,CAAC;CACvD,CAAC,CAAC,CAAC;AAEJ,EAAE,CAAC,IAAI,CAAC,wBAAwB,EAAE,GAAG,EAAE,CAAC,CAAC;IACvC,qBAAqB,EAAE,EAAE,CAAC,EAAE,CAAC,GAAG,EAAE,CAAC,CAAC,EAAE,KAAK,EAAE,IAAI,EAAE,CAAC,CAAC;IACrD,kBAAkB,EAAE,EAAE,CAAC,EAAE,CAAC,GAAG,EAAE,CAAC,WAAW,CAAC;CAC7C,CAAC,CAAC,CAAC;AAEJ,EAAE,CAAC,IAAI,CAAC,qCAAqC,EAAE,GAAG,EAAE,CAAC,CAAC;IACpD,WAAW,EAAE,EAAE,CAAC,EAAE,CAAC,CAAC,MAAc,EAAE,WAAmB,EAAE,QAAgB,EAAE,EAAE,CAAC,GAAG,MAAM,IAAI,WAAW,IAAI,QAAQ,EAAE,CAAC;IACrH,aAAa,EAAE,EAAE,CAAC,EAAE,CAAC,GAAG,EAAE,CAAC,OAAO,CAAC,OAAO,CAAC,IAAI,CAAC,CAAC;IACjD,iBAAiB,EAAE,EAAE,CAAC,EAAE,EAAE;IAC1B,SAAS,EAAE,EAAE,CAAC,EAAE,EAAE;CACnB,CAAC,CAAC,CAAC;AAEJ,EAAE,CAAC,IAAI,CAAC,qBAAqB,EAAE,GAAG,EAAE,CAAC,CAAC;IACpC,kBAAkB,EAAE,EAAE,CAAC,EAAE,EAAE;IAC3B,gBAAgB,EAAE,EAAE,CAAC,EAAE,EAAE;CAC1B,CAAC,CAAC,CAAC;AAEJ,EAAE,CAAC,IAAI,CAAC,qBAAqB,EAAE,GAAG,EAAE,CAAC,CAAC;IACpC,0BAA0B,EAAE,EAAE,CAAC,EAAE,EAAE;IACnC,yBAAyB,EAAE,EAAE,CAAC,EAAE,EAAE;CACnC,CAAC,CAAC,CAAC;AAEJ,EAAE,CAAC,IAAI,CAAC,2BAA2B,EAAE,GAAG,EAAE,CAAC,CAAC;IAC1C,iBAAiB,EAAE,EAAE,CAAC,EAAE,CAAC,GAAG,EAAE,CAAC,CAAC,EAAE,gBAAgB,EAAE,CAAC,EAAE,CAAC,CAAC;IACzD,gBAAgB,EAAE,EAAE,CAAC,EAAE,CAAC,GAAG,EAAE,CAAC,IAAI,CAAC;IACnC,+BAA+B,EAAE,EAAE,CAAC,EAAE,CAAC,GAAG,EAAE,CAAC,IAAI,CAAC;IAClD,iBAAiB,EAAE,EAAE,CAAC,EAAE,CAAC,GAAG,EAAE,CAAC,IAAI,CAAC;IACpC,kBAAkB,EAAE,EAAE,CAAC,EAAE,CAAC,GAAG,EAAE,CAAC,IAAI,CAAC;CACtC,CAAC,CAAC,CAAC;AAEJ,OAAO,EAAE,QAAQ,EAAE,EAAE,EAAE,MAAM,EAAE,UAAU,EAAE,SAAS,EAAE,MAAM,QAAQ,CAAC;AACrE,OAAO,EAAE,mBAAmB,EAAE,MAAM,4FAA4F,CAAC;AAEjI,OAAO,EAAE,oCAAoC,EAAE,MAAM,6CAA6C,CAAC;AACnG,OAAO,EAAE,0BAA0B,EAAE,MAAM,uCAAuC,CAAC;AACnF,OAAO,EAAE,gBAAgB,EAAE,MAAM,wCAAwC,CAAC;AAC1E,OAAO,EAAE,gBAAgB,EAAE,MAAM,8BAA8B,CAAC;AAChE,OAAO,EAAE,mBAAmB,EAAE,MAAM,8DAA8D,CAAC;AACnG,OAAO,EAAE,6BAA6B,EAAE,MAAM,wEAAwE,CAAC;AACvH,OAAO,EAAE,sBAAsB,EAAE,MAAM,iEAAiE,CAAC;AACzG,OAAO,EAAE,sBAAsB,EAAE,MAAM,iEAAiE,CAAC;AACzG,OAAO,EAAE,iBAAiB,EAAE,MAAM,4DAA4D,CAAC;AAC/F,OAAO,EAAE,0BAA0B,EAAE,MAAM,qEAAqE,CAAC;AACjH,OAAO,EAAE,kBAAkB,EAAE,MAAM,6DAA6D,CAAC;AACjG,OAAO,EAAE,mBAAmB,EAAE,MAAM,wDAAwD,CAAC;AAE7F,MAAM,YAAY,GAAG,kCAAkC,CAAC;AACxD,MAAM,SAAS,GAAG,EAAE,CAAC;AACrB,MAAM,KAAK,GAAG,gCAAgC,SAAS,EAAE,CAAC;AAE1D,SAAS,cAAc,CAAC,QAAgB,EAAE,cAAc,GAAG,OAAO;IAChE,OAAO;QACL,WAAW,EAAE,MAAM;QACnB,UAAU,EAAE,MAAM;QAClB,IAAI,EAAE,EAAE,QAAQ,EAAE,cAAc,EAAE,IAAI,EAAE,cAAc,EAAE;QACxD,OAAO,EAAE;YACP,EAAE,EAAE,CAAC;YACL,IAAI,EAAE,cAAc;YACpB,mBAAmB,EAAE,uBAAuB;YAC5C,OAAO,EAAE,0CAA0C;YACnD,YAAY,EAAE,8CAA8C;SAC7D;QACD,iBAAiB,EAAE;YACjB,EAAE,EAAE,GAAG;YACP,IAAI,EAAE,QAAQ;YACd,aAAa,EAAE,cAAc;YAC7B,WAAW,EAAE,SAAS;SACvB;QACD,aAAa,EAAE;YACb,GAAG,EAAE,SAAS;YACd,KAAK,EAAE,SAAS;YAChB,KAAK,EAAE,QAAQ;YACf,aAAa,EAAE,cAAc;YAC7B,aAAa,EAAE,MAAM;YACrB,GAAG,EAAE,6DAA6D,SAAS,EAAE;SAC9E;KACF,CAAC;AACJ,CAAC;AAED,SAAS,sBAAsB;IAC7B,OAAO,GAAG,EAAE,CAAC,0BAA0B,CAAC;AAC1C,CAAC;AAED,SAAS,SAAS,CAChB,QAA8C,EAC9C,eAA2C;IAE3C,MAAM,kBAAkB,GAAG,EAAE,YAAY,EAAE,EAAE,CAAC,EAAE,CAAC,GAAG,EAAE,CAAC,EAAE,CAAC,EAAE,CAAC;IAC7D,OAAO;QACL,oBAAoB,EAAE;YACpB,MAAM,EAAE,EAAE,CAAC,EAAE,CAAC,GAAG,EAAE,CAAC,CAAC,EAAE,OAAO,EAAE,IAAI,EAAE,QAAQ,EAAE,EAAE,EAAE,CAAC,CAAC;YACtD,IAAI,EAAE,EAAE,CAAC,EAAE,CAAC,GAAG,EAAE,CAAC,IAAI,CAAC;YACvB,MAAM,EAAE,EAAE,CAAC,EAAE,CAAC,GAAG,EAAE,CAAC,CAAC,EAAE,OAAO,EAAE,IAAI,EAAE,OAAO,EAAE,IAAI,EAAE,CAAC,CAAC;YACvD,MAAM,EAAE,EAAE,CAAC,EAAE,CAAC,GAAG,EAAE,CAAC,KAAK,CAAC;YAC1B,WAAW,EAAE,EAAE,CAAC,EAAE,CAAC,GAAG,EAAE,CAAC,EAAE,CAAC;YAC5B,YAAY,EAAE,EAAE,CAAC,EAAE,CAAC,GAAG,EAAE,CAAC,CAAC,EAAE,OAAO,EAAE,IAAI,EAAE,CAAC,CAAC;YAC9C,cAAc,EAAE,EAAE,CAAC,EAAE,CAAC,GAAG,EAAE,CAAC,CAAC,EAAE,OAAO,EAAE,IAAI,EAAE,CAAC,CAAC;YAChD,SAAS,EAAE,EAAE,CAAC,EAAE,CAAC,GAAG,EAAE,CAAC,CAAC,EAAE,OAAO,EAAE,IAAI,EAAE,CAAC,CAAC;SAC5C;QACD,kBAAkB;QAClB,wBAAwB,EAAE,EAAE,iBAAiB,EAAE,EAAE,CAAC,EAAE,CAAC,GAAG,EAAE,CAAC,SAAS,CAAC,EAAE;QACvE,qBAAqB,EAAE,EAAE,cAAc,EAAE,EAAE,CAAC,EAAE,CAAC,GAAG,EAAE,CAAC,IAAI,CAAC,EAAE;QAC5D,eAAe,EAAE,IAAI,sBAAsB,CAAC,QAAQ,CAAC;QACrD,gBAAgB,EAAE,IAAI,6BAA6B,CAAC,QAAQ,CAAC;QAC7D,UAAU,EAAE,IAAI,iBAAiB,CAAC,QAAQ,CAAC;QAC3C,eAAe,EAAE,IAAI,sBAAsB,CAAC,QAAQ,CAAC;QACrD,mBAAmB,EAAE,IAAI,0BAA0B,CAAC,QAAQ,CAAC;QAC7D,WAAW,EAAE,IAAI,kBAAkB,CAAC,QAAQ,EAAE,kBAAkB,CAAC;QACjE,YAAY,EAAE,IAAI,mBAAmB,CAAC,QAAQ,CAAC;QAC/C,sBAAsB,EAAE,eAAe;QACvC,GAAG,EAAE,sBAAsB,EAAE;QAC7B,aAAa,EAAE;YACb,OAAO,EAAE,EAAE,CAAC,EAAE,CAAC,KAAK,IAAI,EAAE,CAAC,CAAC;gBAC1B,QAAQ,EAAE,IAAI;gBACd,MAAM,EAAE;oBACN,QAAQ,EAAE,GAAG;oBACb,WAAW,EAAE,CAAC;oBACd,YAAY,EAAE,GAAG;oBACjB,WAAW,EAAE,CAAC;oBACd,QAAQ,EAAE,KAAK;oBACf,WAAW,EAAE,0BAA0B;iBACxC;aACF,CAAC,CAAC;SACJ;QACD,uBAAuB,EAAE,EAAE,CAAC,EAAE,EAAE;QAChC,eAAe,EAAE,EAAE,CAAC,EAAE,CAAC,GAAG,EAAE,CAAC,CAAC,cAAc,CAAC,CAAC;QAC9C,cAAc,EAAE,EAAE,CAAC,EAAE,CAAC,KAAK,IAAI,EAAE,CAAC,CAAC,EAAE,MAAM,EAAE,SAAkB,EAAE,CAAC,CAAC;KAC5B,CAAC;AAC5C,CAAC;AAED,QAAQ,CAAC,yDAAyD,EAAE,GAAG,EAAE;IACvE,IAAI,QAA8C,CAAC;IACnD,IAAI,eAA2C,CAAC;IAChD,IAAI,IAA+B,CAAC;IACpC,IAAI,SAAuB,CAAC;IAC5B,MAAM,MAAM,GAAG,gBAAgB,EAAE,CAAC;IAElC,UAAU,CAAC,GAAG,EAAE;QACd,EAAE,CAAC,aAAa,EAAE,CAAC;QACnB,QAAQ,GAAG,IAAI,oCAAoC,EAAE,CAAC;QACtD,eAAe,GAAG,IAAI,0BAA0B,EAAE,CAAC;QACnD,IAAI,GAAG,SAAS,CAAC,QAAQ,EAAE,eAAe,CAAC,CAAC;QAC5C,SAAS,GAAG;YACV,MAAM,EAAE,EAAE,CAAC,EAAE,EAAE,CAAC,cAAc,EAAE;YAChC,IAAI,EAAE,EAAE,CAAC,EAAE,EAAE,CAAC,cAAc,EAAE;SACJ,CAAC;IAC/B,CAAC,CAAC,CAAC;IAEH,SAAS,CAAC,GAAG,EAAE;QACb,EAAE,CAAC,aAAa,EAAE,CAAC;IACrB,CAAC,CAAC,CAAC;IAEH,QAAQ,CAAC,qDAAqD,EAAE,GAAG,EAAE;QACnE,EAAE,CAAC,6EAA6E,EAAE,KAAK,IAAI,EAAE;YAC3F,QAAQ,CAAC,MAAM,CACb,YAAY,EACZ,gBAAgB,CAAC,MAAM,CAAC;gBACtB,EAAE,EAAE,KAAK;gBACT,QAAQ,EAAE,SAAS;gBACnB,QAAQ,EAAE,QAAQ;gBAClB,OAAO,EAAE,uBAAuB;gBAChC,KAAK,EAAE,kBAAkB;gBACzB,WAAW,EAAE,CAAC;gBACd,WAAW,EAAE,CAAC;aACf,CAAC,CACH,CAAC;YAEF,MAAM,QAAQ,GAAG,mCAAmC,CAAC;YACrD,MAAM,OAAO,GAAG;gBACd,IAAI,EAAE,cAAc,CAAC,QAAQ,CAAC;gBAC9B,OAAO,EAAE,EAAE;aACiB,CAAC;YAE/B,MAAM,mBAAmB,CAAC,OAAO,EAAE,SAAS,EAAE,MAAM,EAAE,QAAQ,EAAE,IAAI,CAAC,CAAC;YAEtE,MAAM,WAAW,GAAG,QAAQ,CAAC,OAAO,CAAC,YAAY,EAAE,KAAK,CAAC,CAAC;YAC1D,MAAM,CAAC,WAAW,EAAE,MAAM,CAAC,CAAC,OAAO,CAAC;gBAClC,MAAM,EAAE,OAAO;gBACf,MAAM,EAAE,iBAAiB;gBACzB,UAAU,EAAE,0BAA0B;aACvC,CAAC,CAAC;YAEH,MAAM,gBAAgB,GAAG,IAAI,CAAC,eAAe,CAAC,OAAO,CAAC;gBACpD,WAAW,EAAE,YAAY;gBACzB,IAAI,EAAE,KAAK;gBACX,WAAW,EAAE,UAAU;gBACvB,YAAY,EAAE,CAAC,EAAE,EAAE,EAAE,CACnB,mBAAmB,CAAC;oBAClB,WAAW,EAAE,EAAE,CAAC,WAAW;oBAC3B,cAAc,EAAE,EAAE,CAAC,WAAW;oBAC9B,SAAS,EAAE,CAAC;iBACb,CAAC;aACL,CAAC,CAAC;YACH,MAAM,CAAC,gBAAgB,CAAC,EAAE,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;YAEvC,MAAM,KAAK,GAAG,QAAQ,CAAC,OAAO,CAAC,YAAY,EAAE,KAAK,CAAC,CAAC;YACpD,MAAM,CAAC,KAAK,EAAE,KAAK,CAAC,CAAC,IAAI,CAAC,UAAU,CAAC,CAAC;QACxC,CAAC,CAAC,CAAC;IACL,CAAC,CAAC,CAAC;IAEH,QAAQ,CAAC,+DAA+D,EAAE,GAAG,EAAE;QAC7E,EAAE,CAAC,sFAAsF,EAAE,KAAK,IAAI,EAAE;YACpG,QAAQ,CAAC,MAAM,CACb,YAAY,EACZ,gBAAgB,CAAC,MAAM,CAAC;gBACtB,EAAE,EAAE,KAAK;gBACT,QAAQ,EAAE,SAAS;gBACnB,QAAQ,EAAE,QAAQ;gBAClB,OAAO,EAAE,uBAAuB;gBAChC,KAAK,EAAE,kBAAkB;gBACzB,WAAW,EAAE,CAAC;gBACd,WAAW,EAAE,CAAC;aACf,CAAC,CACH,CAAC;YAEF,MAAM,OAAO,GAAG;gBACd,IAAI,EAAE,cAAc,CAAC,iBAAiB,CAAC;gBACvC,OAAO,EAAE,EAAE;aACiB,CAAC;YAE/B,MAAM,mBAAmB,CAAC,OAAO,EAAE,SAAS,EAAE,MAAM,EAAE,QAAQ,EAAE,IAAI,CAAC,CAAC;YAEtE,MAAM,CAAC,eAAe,CAAC,KAAK,CAAC,CAAC,YAAY,CAAC,CAAC,CAAC,CAAC;YAC9C,MAAM,CAAC,eAAe,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC,CAAC,OAAO,CAAC;gBACvC,WAAW,EAAE,uBAAuB;gBACpC,QAAQ,EAAE,SAAS;gBACnB,IAAI,EAAE,qFAAqF;aAC5F,CAAC,CAAC;YAEH,MAAM,OAAO,GAAG,QAAQ,CAAC,OAAO,CAAC,YAAY,EAAE,KAAK,CAAC,CAAC;YACtD,MAAM,CAAC,OAAO,EAAE,MAAM,CAAC,CAAC,QAAQ,EAAE,CAAC;QACrC,CAAC,CAAC,CAAC;IACL,CAAC,CAAC,CAAC;IAEH,QAAQ,CAAC,6CAA6C,EAAE,GAAG,EAAE;QAC3D,EAAE,CAAC,wEAAwE,EAAE,GAAG,EAAE;YAChF,QAAQ,CAAC,MAAM,CACb,YAAY,EACZ,gBAAgB,CAAC,MAAM,CAAC;gBACtB,EAAE,EAAE,KAAK;gBACT,QAAQ,EAAE,SAAS;gBACnB,QAAQ,EAAE,QAAQ;gBAClB,OAAO,EAAE,uBAAuB;gBAChC,KAAK,EAAE,kBAAkB;gBACzB,WAAW,EAAE,CAAC;gBACd,WAAW,EAAE,CAAC;gBACd,MAAM,EAAE,EAAE,MAAM,EAAE,OAAO,EAAE,MAAM,EAAE,iBAAiB,EAAE,UAAU,EAAE,0BAA0B,EAAE;aAC/F,CAAC,CACH,CAAC;YAEF,MAAM,gBAAgB,GAAG,IAAI,6BAA6B,CAAC,QAAQ,CAAC,CAAC;YACrE,MAAM,MAAM,GAAG,gBAAgB,CAAC,OAAO,CAAC;gBACtC,WAAW,EAAE,YAAY;gBACzB,IAAI,EAAE,KAAK;gBACX,UAAU,EAAE;oBACV,IAAI,EAAE,QAAQ;oBACd,UAAU,EAAE,KAAK;oBACjB,KAAK,EAAE,CAAC;oBACR,QAAQ,EAAE,CAAC;oBACX,QAAQ,EAAE,CAAC;oBACX,WAAW,EAAE,CAAC;oBACd,aAAa,EAAE,CAAC;oBAChB,aAAa,EAAE,CAAC;iBACjB;gBACD,gBAAgB,EAAE,CAAC;aACpB,CAAC,CAAC;YAEH,MAAM,CAAC,MAAM,EAAE,MAAM,CAAC,CAAC,QAAQ,EAAE,CAAC;YAClC,MAAM,CAAC,MAAM,EAAE,KAAK,CAAC,CAAC,IAAI,CAAC,kBAAkB,CAAC,CAAC;QACjD,CAAC,CAAC,CAAC;IACL,CAAC,CAAC,CAAC;IAEH,QAAQ,CAAC,0EAA0E,EAAE,GAAG,EAAE;QACxF,EAAE,CAAC,oDAAoD,EAAE,KAAK,IAAI,EAAE;YAClE,QAAQ,CAAC,MAAM,CACb,YAAY,EACZ,gBAAgB,CAAC,MAAM,CAAC;gBACtB,EAAE,EAAE,KAAK;gBACT,QAAQ,EAAE,SAAS;gBACnB,QAAQ,EAAE,QAAQ;gBAClB,OAAO,EAAE,uBAAuB;gBAChC,KAAK,EAAE,kBAAkB;gBACzB,WAAW,EAAE,CAAC;gBACd,WAAW,EAAE,CAAC;aACf,CAAC,CACH,CAAC;YAEF,MAAM,OAAO,GAAG;gBACd,IAAI,EAAE,cAAc,CAAC,kCAAkC,CAAC;gBACxD,OAAO,EAAE,EAAE;aACiB,CAAC;YAE/B,MAAM,mBAAmB,CAAC,OAAO,EAAE,SAAS,EAAE,MAAM,EAAE,QAAQ,EAAE,IAAI,CAAC,CAAC;YAEtE,MAAM,OAAO,GAAG,QAAQ,CAAC,OAAO,CAAC,YAAY,EAAE,KAAK,CAAC,CAAC;YACtD,MAAM,CAAC,OAAO,EAAE,MAAM,CAAC,CAAC,OAAO,CAAC;gBAC9B,MAAM,EAAE,OAAO;gBACf,MAAM,EAAE,gBAAgB;gBACxB,UAAU,EAAE,0BAA0B;aACvC,CAAC,CAAC;YACH,MAAM,CAAC,OAAO,EAAE,KAAK,CAAC,CAAC,IAAI,CAAC,kBAAkB,CAAC,CAAC;YAChD,MAAM,CAAC,eAAe,CAAC,KAAK,CAAC,CAAC,YAAY,CAAC,CAAC,CAAC,CAAC;QAChD,CAAC,CAAC,CAAC;IACL,CAAC,CAAC,CAAC;AACL,CAAC,CAAC,CAAC"}
|
package/dist/tests/acceptance/180-quality-threshold-block-approval-iter-C.acceptance.test.d.ts
ADDED
|
@@ -0,0 +1,16 @@
|
|
|
1
|
+
/**
|
|
2
|
+
* SPEC-180 — Block approval below quality threshold (Iteration C)
|
|
3
|
+
*
|
|
4
|
+
* Outer-loop acceptance test (SDD) for the platform-side revocation + FR
|
|
5
|
+
* explanatory comment on platform approval of a non-qualified merge request
|
|
6
|
+
* without an active bypass.
|
|
7
|
+
*
|
|
8
|
+
* In-scope scenarios from docs/specs/180-quality-threshold-block-approval.md:
|
|
9
|
+
* 6: platform approval on non-qualified MR → unapprove on platform + post
|
|
10
|
+
* "Approbation annulée : seuil qualité 7/10 non atteint (6/10).
|
|
11
|
+
* Utilisez `/bypass-quality "raison"` pour forcer."
|
|
12
|
+
*
|
|
13
|
+
* Both platforms (GitLab + GitHub) — the spec rule applies symmetrically.
|
|
14
|
+
*/
|
|
15
|
+
export {};
|
|
16
|
+
//# sourceMappingURL=180-quality-threshold-block-approval-iter-C.acceptance.test.d.ts.map
|
package/dist/tests/acceptance/180-quality-threshold-block-approval-iter-C.acceptance.test.d.ts.map
ADDED
|
@@ -0,0 +1 @@
|
|
|
1
|
+
{"version":3,"file":"180-quality-threshold-block-approval-iter-C.acceptance.test.d.ts","sourceRoot":"","sources":["../../../src/tests/acceptance/180-quality-threshold-block-approval-iter-C.acceptance.test.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;;;GAaG"}
|
|
@@ -0,0 +1,316 @@
|
|
|
1
|
+
/**
|
|
2
|
+
* SPEC-180 — Block approval below quality threshold (Iteration C)
|
|
3
|
+
*
|
|
4
|
+
* Outer-loop acceptance test (SDD) for the platform-side revocation + FR
|
|
5
|
+
* explanatory comment on platform approval of a non-qualified merge request
|
|
6
|
+
* without an active bypass.
|
|
7
|
+
*
|
|
8
|
+
* In-scope scenarios from docs/specs/180-quality-threshold-block-approval.md:
|
|
9
|
+
* 6: platform approval on non-qualified MR → unapprove on platform + post
|
|
10
|
+
* "Approbation annulée : seuil qualité 7/10 non atteint (6/10).
|
|
11
|
+
* Utilisez `/bypass-quality "raison"` pour forcer."
|
|
12
|
+
*
|
|
13
|
+
* Both platforms (GitLab + GitHub) — the spec rule applies symmetrically.
|
|
14
|
+
*/
|
|
15
|
+
import { vi } from 'vitest';
|
|
16
|
+
const mockRepoConfig = {
|
|
17
|
+
name: 'test-project',
|
|
18
|
+
platform: 'gitlab',
|
|
19
|
+
localPath: '/home/user/projects/test-project',
|
|
20
|
+
remoteUrl: 'https://gitlab.com/test-org/test-project.git',
|
|
21
|
+
skill: 'review-front',
|
|
22
|
+
enabled: true,
|
|
23
|
+
};
|
|
24
|
+
const mockGitHubRepoConfig = {
|
|
25
|
+
name: 'test-project',
|
|
26
|
+
platform: 'github',
|
|
27
|
+
localPath: '/home/user/projects/test-project',
|
|
28
|
+
remoteUrl: 'https://github.com/test-org/test-project.git',
|
|
29
|
+
skill: 'review-front',
|
|
30
|
+
enabled: true,
|
|
31
|
+
};
|
|
32
|
+
const mockConfig = {
|
|
33
|
+
server: { port: 3000 },
|
|
34
|
+
user: { gitlabUsername: 'claude-bot', githubUsername: 'claude-bot' },
|
|
35
|
+
queue: { maxConcurrent: 1, deduplicationWindowMs: 60000 },
|
|
36
|
+
repositories: [mockRepoConfig],
|
|
37
|
+
};
|
|
38
|
+
vi.mock('@/config/loader.js', () => ({
|
|
39
|
+
loadConfig: vi.fn(() => mockConfig),
|
|
40
|
+
findRepositoryByProjectPath: vi.fn(() => mockRepoConfig),
|
|
41
|
+
findRepositoryByRemoteUrl: vi.fn(() => mockGitHubRepoConfig),
|
|
42
|
+
}));
|
|
43
|
+
const gitLabEventTypeRef = { value: 'Merge Request Hook' };
|
|
44
|
+
const gitHubEventTypeRef = { value: 'pull_request_review' };
|
|
45
|
+
vi.mock('@/security/verifier.js', () => ({
|
|
46
|
+
verifyGitLabSignature: vi.fn(() => ({ valid: true })),
|
|
47
|
+
verifyGitHubSignature: vi.fn(() => ({ valid: true })),
|
|
48
|
+
getGitLabEventType: vi.fn(() => gitLabEventTypeRef.value),
|
|
49
|
+
getGitHubEventType: vi.fn(() => gitHubEventTypeRef.value),
|
|
50
|
+
}));
|
|
51
|
+
vi.mock('@/frameworks/queue/pQueueAdapter.js', () => ({
|
|
52
|
+
createJobId: vi.fn((prefix, projectPath, mrNumber) => `${prefix}-${projectPath}-${mrNumber}`),
|
|
53
|
+
enqueueReview: vi.fn(() => Promise.resolve(true)),
|
|
54
|
+
updateJobProgress: vi.fn(),
|
|
55
|
+
cancelJob: vi.fn(),
|
|
56
|
+
}));
|
|
57
|
+
vi.mock('@/claude/invoker.js', () => ({
|
|
58
|
+
invokeClaudeReview: vi.fn(),
|
|
59
|
+
sendNotification: vi.fn(),
|
|
60
|
+
}));
|
|
61
|
+
vi.mock('@/main/websocket.js', () => ({
|
|
62
|
+
startWatchingReviewContext: vi.fn(),
|
|
63
|
+
stopWatchingReviewContext: vi.fn(),
|
|
64
|
+
}));
|
|
65
|
+
vi.mock('@/config/projectConfig.js', () => ({
|
|
66
|
+
loadProjectConfig: vi.fn(() => ({ qualityThreshold: 7 })),
|
|
67
|
+
getProjectAgents: vi.fn(() => null),
|
|
68
|
+
getProjectAgentsOrFocusDefaults: vi.fn(() => null),
|
|
69
|
+
getFollowupAgents: vi.fn(() => null),
|
|
70
|
+
getProjectLanguage: vi.fn(() => 'en'),
|
|
71
|
+
}));
|
|
72
|
+
import { describe, it, expect, beforeEach, afterEach } from 'vitest';
|
|
73
|
+
import { handleGitLabWebhook } from '../../modules/platform-integration/interface-adapters/controllers/webhook/gitlab.controller.js';
|
|
74
|
+
import { handleGitHubWebhook } from '../../modules/platform-integration/interface-adapters/controllers/webhook/github.controller.js';
|
|
75
|
+
import { InMemoryReviewRequestTrackingGateway } from '../../tests/stubs/reviewRequestTracking.stub.js';
|
|
76
|
+
import { StubNoteCommentPostGateway } from '../../tests/stubs/noteCommentPost.stub.js';
|
|
77
|
+
import { StubApprovalRevocationGateway } from '../../tests/stubs/approvalRevocation.stub.js';
|
|
78
|
+
import { TrackedMrFactory } from '../../tests/factories/trackedMr.factory.js';
|
|
79
|
+
import { createStubLogger } from '../../tests/stubs/logger.stub.js';
|
|
80
|
+
import { RecordBypassUseCase } from '../../modules/tracking/usecases/tracking/recordBypass.usecase.js';
|
|
81
|
+
import { RecordReviewCompletionUseCase } from '../../modules/tracking/usecases/tracking/recordReviewCompletion.usecase.js';
|
|
82
|
+
import { TransitionStateUseCase } from '../../modules/tracking/usecases/tracking/transitionState.usecase.js';
|
|
83
|
+
import { TrackAssignmentUseCase } from '../../modules/tracking/usecases/tracking/trackAssignment.usecase.js';
|
|
84
|
+
import { RecordPushUseCase } from '../../modules/tracking/usecases/tracking/recordPush.usecase.js';
|
|
85
|
+
import { CheckFollowupNeededUseCase } from '../../modules/tracking/usecases/tracking/checkFollowupNeeded.usecase.js';
|
|
86
|
+
import { SyncThreadsUseCase } from '../../modules/tracking/usecases/tracking/syncThreads.usecase.js';
|
|
87
|
+
import { HandlePlatformApprovalUseCase } from '../../modules/tracking/usecases/tracking/handlePlatformApproval.usecase.js';
|
|
88
|
+
const PROJECT_PATH = '/home/user/projects/test-project';
|
|
89
|
+
const MR_NUMBER = 42;
|
|
90
|
+
const GITLAB_MR_ID = `gitlab-test-org/test-project-${MR_NUMBER}`;
|
|
91
|
+
const GITHUB_MR_ID = `github-test-org/test-project-${MR_NUMBER}`;
|
|
92
|
+
function buildGitLabApproveEvent() {
|
|
93
|
+
return {
|
|
94
|
+
object_kind: 'merge_request',
|
|
95
|
+
event_type: 'merge_request',
|
|
96
|
+
user: { username: 'alice', name: 'Alice' },
|
|
97
|
+
project: {
|
|
98
|
+
id: 1,
|
|
99
|
+
name: 'test-project',
|
|
100
|
+
path_with_namespace: 'test-org/test-project',
|
|
101
|
+
web_url: 'https://gitlab.com/test-org/test-project',
|
|
102
|
+
git_http_url: 'https://gitlab.com/test-org/test-project.git',
|
|
103
|
+
},
|
|
104
|
+
object_attributes: {
|
|
105
|
+
iid: MR_NUMBER,
|
|
106
|
+
title: 'Test MR',
|
|
107
|
+
state: 'opened',
|
|
108
|
+
action: 'approved',
|
|
109
|
+
source_branch: 'feature/test',
|
|
110
|
+
target_branch: 'main',
|
|
111
|
+
url: `https://gitlab.com/test-org/test-project/-/merge_requests/${MR_NUMBER}`,
|
|
112
|
+
draft: false,
|
|
113
|
+
},
|
|
114
|
+
};
|
|
115
|
+
}
|
|
116
|
+
function buildGitHubPullRequestReviewEvent() {
|
|
117
|
+
return {
|
|
118
|
+
action: 'submitted',
|
|
119
|
+
review: {
|
|
120
|
+
id: 12345,
|
|
121
|
+
state: 'approved',
|
|
122
|
+
user: { login: 'alice' },
|
|
123
|
+
},
|
|
124
|
+
pull_request: {
|
|
125
|
+
number: MR_NUMBER,
|
|
126
|
+
state: 'open',
|
|
127
|
+
html_url: `https://github.com/test-org/test-project/pull/${MR_NUMBER}`,
|
|
128
|
+
},
|
|
129
|
+
repository: {
|
|
130
|
+
full_name: 'test-org/test-project',
|
|
131
|
+
html_url: 'https://github.com/test-org/test-project',
|
|
132
|
+
clone_url: 'https://github.com/test-org/test-project.git',
|
|
133
|
+
},
|
|
134
|
+
sender: { login: 'alice' },
|
|
135
|
+
};
|
|
136
|
+
}
|
|
137
|
+
function buildGitLabDeps(tracking, noteCommentPost, approvalRevocation) {
|
|
138
|
+
const threadFetchGateway = { fetchThreads: vi.fn(() => []) };
|
|
139
|
+
return {
|
|
140
|
+
reviewContextGateway: {
|
|
141
|
+
create: vi.fn(() => ({ success: true, filePath: '' })),
|
|
142
|
+
read: vi.fn(() => null),
|
|
143
|
+
delete: vi.fn(() => ({ success: true, deleted: true })),
|
|
144
|
+
exists: vi.fn(() => false),
|
|
145
|
+
getFilePath: vi.fn(() => ''),
|
|
146
|
+
appendAction: vi.fn(() => ({ success: true })),
|
|
147
|
+
updateProgress: vi.fn(() => ({ success: true })),
|
|
148
|
+
setResult: vi.fn(() => ({ success: true })),
|
|
149
|
+
},
|
|
150
|
+
threadFetchGateway,
|
|
151
|
+
diffMetadataFetchGateway: { fetchDiffMetadata: vi.fn(() => undefined) },
|
|
152
|
+
diffStatsFetchGateway: { fetchDiffStats: vi.fn(() => null) },
|
|
153
|
+
trackAssignment: new TrackAssignmentUseCase(tracking),
|
|
154
|
+
recordCompletion: new RecordReviewCompletionUseCase(tracking),
|
|
155
|
+
recordPush: new RecordPushUseCase(tracking),
|
|
156
|
+
transitionState: new TransitionStateUseCase(tracking),
|
|
157
|
+
checkFollowupNeeded: new CheckFollowupNeededUseCase(tracking),
|
|
158
|
+
syncThreads: new SyncThreadsUseCase(tracking, threadFetchGateway),
|
|
159
|
+
recordBypass: new RecordBypassUseCase(tracking),
|
|
160
|
+
noteCommentPostGateway: noteCommentPost,
|
|
161
|
+
handlePlatformApproval: new HandlePlatformApprovalUseCase(tracking),
|
|
162
|
+
approvalRevocationGateway: approvalRevocation,
|
|
163
|
+
getQualityThreshold: () => 7,
|
|
164
|
+
now: () => '2026-05-26T12:00:00.000Z',
|
|
165
|
+
enforceBudget: {
|
|
166
|
+
execute: vi.fn(async () => ({
|
|
167
|
+
accepted: true,
|
|
168
|
+
status: {
|
|
169
|
+
limitUsd: 200,
|
|
170
|
+
consumedUsd: 0,
|
|
171
|
+
remainingUsd: 200,
|
|
172
|
+
percentUsed: 0,
|
|
173
|
+
exceeded: false,
|
|
174
|
+
periodStart: '2026-05-01T00:00:00.000Z',
|
|
175
|
+
},
|
|
176
|
+
})),
|
|
177
|
+
},
|
|
178
|
+
broadcastBudgetExceeded: vi.fn(),
|
|
179
|
+
getRepositories: vi.fn(() => [mockRepoConfig]),
|
|
180
|
+
removeWorktree: vi.fn(async () => ({ status: 'removed' })),
|
|
181
|
+
};
|
|
182
|
+
}
|
|
183
|
+
function buildGitHubDeps(tracking, noteCommentPost, approvalRevocation) {
|
|
184
|
+
const threadFetchGateway = { fetchThreads: vi.fn(() => []) };
|
|
185
|
+
return {
|
|
186
|
+
reviewContextGateway: {
|
|
187
|
+
create: vi.fn(() => ({ success: true, filePath: '' })),
|
|
188
|
+
read: vi.fn(() => null),
|
|
189
|
+
delete: vi.fn(() => ({ success: true, deleted: true })),
|
|
190
|
+
exists: vi.fn(() => false),
|
|
191
|
+
getFilePath: vi.fn(() => ''),
|
|
192
|
+
appendAction: vi.fn(() => ({ success: true })),
|
|
193
|
+
updateProgress: vi.fn(() => ({ success: true })),
|
|
194
|
+
setResult: vi.fn(() => ({ success: true })),
|
|
195
|
+
},
|
|
196
|
+
threadFetchGateway,
|
|
197
|
+
diffMetadataFetchGateway: { fetchDiffMetadata: vi.fn(() => undefined) },
|
|
198
|
+
diffStatsFetchGateway: { fetchDiffStats: vi.fn(() => null) },
|
|
199
|
+
trackAssignment: new TrackAssignmentUseCase(tracking),
|
|
200
|
+
recordCompletion: new RecordReviewCompletionUseCase(tracking),
|
|
201
|
+
recordPush: new RecordPushUseCase(tracking),
|
|
202
|
+
transitionState: new TransitionStateUseCase(tracking),
|
|
203
|
+
checkFollowupNeeded: new CheckFollowupNeededUseCase(tracking),
|
|
204
|
+
syncThreads: new SyncThreadsUseCase(tracking, threadFetchGateway),
|
|
205
|
+
recordBypass: new RecordBypassUseCase(tracking),
|
|
206
|
+
noteCommentPostGateway: noteCommentPost,
|
|
207
|
+
handlePlatformApproval: new HandlePlatformApprovalUseCase(tracking),
|
|
208
|
+
approvalRevocationGateway: approvalRevocation,
|
|
209
|
+
getQualityThreshold: () => 7,
|
|
210
|
+
now: () => '2026-05-26T12:00:00.000Z',
|
|
211
|
+
enforceBudget: {
|
|
212
|
+
execute: vi.fn(async () => ({
|
|
213
|
+
accepted: true,
|
|
214
|
+
status: {
|
|
215
|
+
limitUsd: 200,
|
|
216
|
+
consumedUsd: 0,
|
|
217
|
+
remainingUsd: 200,
|
|
218
|
+
percentUsed: 0,
|
|
219
|
+
exceeded: false,
|
|
220
|
+
periodStart: '2026-05-01T00:00:00.000Z',
|
|
221
|
+
},
|
|
222
|
+
})),
|
|
223
|
+
},
|
|
224
|
+
broadcastBudgetExceeded: vi.fn(),
|
|
225
|
+
getRepositories: vi.fn(() => [mockGitHubRepoConfig]),
|
|
226
|
+
removeWorktree: vi.fn(async () => ({ status: 'removed' })),
|
|
227
|
+
};
|
|
228
|
+
}
|
|
229
|
+
describe('Acceptance — SPEC-180 Iteration C: Platform approval revoked on non-qualified MR', () => {
|
|
230
|
+
let tracking;
|
|
231
|
+
let noteCommentPost;
|
|
232
|
+
let approvalRevocation;
|
|
233
|
+
let mockReply;
|
|
234
|
+
const logger = createStubLogger();
|
|
235
|
+
beforeEach(() => {
|
|
236
|
+
vi.clearAllMocks();
|
|
237
|
+
tracking = new InMemoryReviewRequestTrackingGateway();
|
|
238
|
+
noteCommentPost = new StubNoteCommentPostGateway();
|
|
239
|
+
approvalRevocation = new StubApprovalRevocationGateway();
|
|
240
|
+
mockReply = {
|
|
241
|
+
status: vi.fn().mockReturnThis(),
|
|
242
|
+
send: vi.fn().mockReturnThis(),
|
|
243
|
+
};
|
|
244
|
+
gitLabEventTypeRef.value = 'Merge Request Hook';
|
|
245
|
+
gitHubEventTypeRef.value = 'pull_request_review';
|
|
246
|
+
});
|
|
247
|
+
afterEach(() => {
|
|
248
|
+
vi.resetAllMocks();
|
|
249
|
+
});
|
|
250
|
+
describe('Rule: platform approval on non-qualified MR is revoked with FR explanation', () => {
|
|
251
|
+
it('scenario 6 (GitLab) — approved event below threshold revokes approval and posts FR comment', async () => {
|
|
252
|
+
tracking.create(PROJECT_PATH, TrackedMrFactory.create({
|
|
253
|
+
id: GITLAB_MR_ID,
|
|
254
|
+
mrNumber: MR_NUMBER,
|
|
255
|
+
platform: 'gitlab',
|
|
256
|
+
project: 'test-org/test-project',
|
|
257
|
+
state: 'pending-approval',
|
|
258
|
+
latestScore: 6,
|
|
259
|
+
openThreads: 0,
|
|
260
|
+
bypass: null,
|
|
261
|
+
}));
|
|
262
|
+
const deps = buildGitLabDeps(tracking, noteCommentPost, approvalRevocation);
|
|
263
|
+
const request = {
|
|
264
|
+
body: buildGitLabApproveEvent(),
|
|
265
|
+
headers: {},
|
|
266
|
+
};
|
|
267
|
+
await handleGitLabWebhook(request, mockReply, logger, tracking, deps);
|
|
268
|
+
expect(approvalRevocation.calls).toHaveLength(1);
|
|
269
|
+
expect(approvalRevocation.calls[0]).toMatchObject({
|
|
270
|
+
projectPath: 'test-org/test-project',
|
|
271
|
+
mrNumber: MR_NUMBER,
|
|
272
|
+
});
|
|
273
|
+
expect(noteCommentPost.calls).toHaveLength(1);
|
|
274
|
+
expect(noteCommentPost.calls[0]).toEqual({
|
|
275
|
+
projectPath: 'test-org/test-project',
|
|
276
|
+
mrNumber: MR_NUMBER,
|
|
277
|
+
body: 'Approbation annulée : seuil qualité 7/10 non atteint (6/10). Utilisez `/bypass-quality "raison"` pour forcer.',
|
|
278
|
+
});
|
|
279
|
+
const finalMr = tracking.getById(PROJECT_PATH, GITLAB_MR_ID);
|
|
280
|
+
expect(finalMr?.state).toBe('pending-approval');
|
|
281
|
+
});
|
|
282
|
+
it('scenario 6 (GitHub) — pull_request_review approved below threshold revokes review and posts FR comment', async () => {
|
|
283
|
+
tracking.create(PROJECT_PATH, TrackedMrFactory.create({
|
|
284
|
+
id: GITHUB_MR_ID,
|
|
285
|
+
mrNumber: MR_NUMBER,
|
|
286
|
+
platform: 'github',
|
|
287
|
+
project: 'test-org/test-project',
|
|
288
|
+
state: 'pending-approval',
|
|
289
|
+
latestScore: 6,
|
|
290
|
+
openThreads: 0,
|
|
291
|
+
bypass: null,
|
|
292
|
+
}));
|
|
293
|
+
const deps = buildGitHubDeps(tracking, noteCommentPost, approvalRevocation);
|
|
294
|
+
const request = {
|
|
295
|
+
body: buildGitHubPullRequestReviewEvent(),
|
|
296
|
+
headers: {},
|
|
297
|
+
};
|
|
298
|
+
await handleGitHubWebhook(request, mockReply, logger, tracking, deps);
|
|
299
|
+
expect(approvalRevocation.calls).toHaveLength(1);
|
|
300
|
+
expect(approvalRevocation.calls[0]).toMatchObject({
|
|
301
|
+
projectPath: 'test-org/test-project',
|
|
302
|
+
mrNumber: MR_NUMBER,
|
|
303
|
+
reviewId: 12345,
|
|
304
|
+
});
|
|
305
|
+
expect(noteCommentPost.calls).toHaveLength(1);
|
|
306
|
+
expect(noteCommentPost.calls[0]).toEqual({
|
|
307
|
+
projectPath: 'test-org/test-project',
|
|
308
|
+
mrNumber: MR_NUMBER,
|
|
309
|
+
body: 'Approbation annulée : seuil qualité 7/10 non atteint (6/10). Utilisez `/bypass-quality "raison"` pour forcer.',
|
|
310
|
+
});
|
|
311
|
+
const finalMr = tracking.getById(PROJECT_PATH, GITHUB_MR_ID);
|
|
312
|
+
expect(finalMr?.state).toBe('pending-approval');
|
|
313
|
+
});
|
|
314
|
+
});
|
|
315
|
+
});
|
|
316
|
+
//# sourceMappingURL=180-quality-threshold-block-approval-iter-C.acceptance.test.js.map
|