relay-runtime 13.0.0-rc.1 → 13.0.2

package/store/ClientID.js.flow

@@ -1,5 +1,5 @@
 /**
- * Copyright (c) Facebook, Inc. and its affiliates.
+ * Copyright (c) Meta Platforms, Inc. and affiliates.
  *
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.

package/store/DataChecker.js.flow

@@ -1,5 +1,5 @@
 /**
- * Copyright (c) Facebook, Inc. and its affiliates.
+ * Copyright (c) Meta Platforms, Inc. and affiliates.
  *
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.

package/store/OperationExecutor.js.flow

@@ -1,5 +1,5 @@
 /**
- * Copyright (c) Facebook, Inc. and its affiliates.
+ * Copyright (c) Meta Platforms, Inc. and affiliates.
  *
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.

package/store/RelayConcreteVariables.js.flow

@@ -1,5 +1,5 @@
 /**
- * Copyright (c) Facebook, Inc. and its affiliates.
+ * Copyright (c) Meta Platforms, Inc. and affiliates.
  *
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
@@ -18,6 +18,7 @@ import type {
   NormalizationOperation,
 } from '../util/NormalizationNode';
 import type {ReaderFragment} from '../util/ReaderNode';
+import type {ProvidedVariablesType} from '../util/RelayConcreteNode';
 import type {Variables} from '../util/RelayRuntimeTypes';
 
 const {getArgumentValues} = require('./RelayStoreUtils');
@@ -76,12 +77,15 @@ function getFragmentVariables(
 
 /**
  * Determines the variables that are in scope for a given operation given values
- * for some/all of its arguments. Extraneous input variables are filtered from
- * the output, and missing variables are set to default values (if given in the
+ * for some/all of its arguments.
+ * - extraneous input variables are filtered from the output
+ * - missing variables are set to default values (if given in the
  * operation's definition).
+ * - variables with provider modules are added
  */
 function getOperationVariables(
   operation: NormalizationOperation,
+  providedVariables: ?ProvidedVariablesType,
   variables: Variables,
 ): Variables {
   const operationVariables = {};
@@ -92,6 +96,12 @@ function getOperationVariables(
     }
     operationVariables[def.name] = value;
   });
+
+  if (providedVariables != null) {
+    Object.keys(providedVariables).forEach((varName: string) => {
+      operationVariables[varName] = providedVariables[varName].get();
+    });
+  }
   return operationVariables;
 }
 

package/store/RelayExperimentalGraphResponseHandler.js.flow

@@ -1,5 +1,5 @@
 /**
- * Copyright (c) Facebook, Inc. and its affiliates.
+ * Copyright (c) Meta Platforms, Inc. and affiliates.
  *
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
@@ -14,13 +14,10 @@ import type {
   GraphModeResponse,
   RecordChunk,
 } from './RelayExperimentalGraphResponseTransform';
-import type {
-  MutableRecordSource,
-  Record,
-} from 'relay-runtime/store/RelayStoreTypes';
+import type {MutableRecordSource, Record} from './RelayStoreTypes';
 
+const RelayModernRecord = require('./RelayModernRecord');
 const invariant = require('invariant');
-const RelayModernRecord = require('relay-runtime/store/RelayModernRecord');
 
 /**
  * Given a stream of GraphMode chunks, populate a MutableRecordSource.

package/store/RelayExperimentalGraphResponseTransform.js.flow

@@ -1,5 +1,5 @@
 /**
- * Copyright (c) Facebook, Inc. and its affiliates.
+ * Copyright (c) Meta Platforms, Inc. and affiliates.
  *
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
@@ -10,30 +10,20 @@
  */
 
 import type {ActorIdentifier} from '../multi-actor-environment/ActorIdentifier';
-import type {NormalizationOptions} from './RelayResponseNormalizer';
-import type {IncrementalDataPlaceholder} from './RelayStoreTypes';
+import type {PayloadData} from '../network/RelayNetworkTypes';
 import type {
-  DataID,
   NormalizationField,
-  NormalizationSelector,
-  PayloadData,
-} from 'relay-runtime';
-import type {GetDataID} from 'relay-runtime/store/RelayResponseNormalizer';
-import type {
   NormalizationLinkedField,
   NormalizationNode,
-} from 'relay-runtime/util/NormalizationNode';
-import type {Variables} from 'relay-runtime/util/RelayRuntimeTypes';
+} from '../util/NormalizationNode';
+import type {DataID, Variables} from '../util/RelayRuntimeTypes';
+import type {NormalizationOptions} from './RelayResponseNormalizer';
+import type {GetDataID} from './RelayResponseNormalizer';
+import type {
+  IncrementalDataPlaceholder,
+  NormalizationSelector,
+} from './RelayStoreTypes';
 
-const {getLocalVariables} = require('./RelayConcreteVariables');
-const {createNormalizationSelector} = require('./RelayModernSelector');
-const invariant = require('invariant');
-const {generateClientID} = require('relay-runtime');
-const {
-  ROOT_TYPE,
-  TYPENAME_KEY,
-  getStorageKey,
-} = require('relay-runtime/store/RelayStoreUtils');
 const {
   CLIENT_EXTENSION,
   CONDITION,
@@ -41,8 +31,15 @@ const {
   FRAGMENT_SPREAD,
   INLINE_FRAGMENT,
   LINKED_FIELD,
+  LINKED_HANDLE,
   SCALAR_FIELD,
-} = require('relay-runtime/util/RelayConcreteNode');
+  SCALAR_HANDLE,
+} = require('../util/RelayConcreteNode');
+const {getLocalVariables} = require('./RelayConcreteVariables');
+const {createNormalizationSelector} = require('./RelayModernSelector');
+const {ROOT_TYPE, TYPENAME_KEY, getStorageKey} = require('./RelayStoreUtils');
+const invariant = require('invariant');
+const {generateClientID} = require('relay-runtime');
 
 /**
  * This module is an experiment to explore a proposal normalized response format for GraphQL.
@@ -96,6 +93,10 @@ export type GraphModeChunk = DataChunk | CompleteChunk;
 
 export type GraphModeResponse = Iterable<GraphModeChunk>;
 
+export type TransformMetadata = {
+  duplicateFieldsAvoided: number,
+};
+
 /**
  * Converts a JSON response (and Normalization AST) into a stream of GraphMode chunks
  *
@@ -133,7 +134,20 @@ export function normalizeResponse(
   return normalizer.normalizeResponse(node, dataID, response);
 }
 
-class GraphModeNormalizer {
+export function normalizeResponseWithMetadata(
+  response: PayloadData,
+  selector: NormalizationSelector,
+  options: NormalizationOptions,
+): [Array<GraphModeChunk>, TransformMetadata] {
+  const {node, variables, dataID} = selector;
+  const normalizer = new GraphModeNormalizer(variables, options);
+  const chunks = Array.from(
+    normalizer.normalizeResponse(node, dataID, response),
+  );
+  return [chunks, {duplicateFieldsAvoided: normalizer.duplicateFieldsAvoided}];
+}
+
+export class GraphModeNormalizer {
   _cacheKeyToStreamID: Map<string, number>;
   _sentFields: Map<string, Set<string>>;
   _getDataId: GetDataID;
@@ -143,6 +157,7 @@ class GraphModeNormalizer {
   _path: Array<string>;
   _incrementalPlaceholders: Array<IncrementalDataPlaceholder>;
   _actorIdentifier: ?ActorIdentifier;
+  duplicateFieldsAvoided: number;
   constructor(variables: Variables, options: NormalizationOptions) {
     this._actorIdentifier = options.actorIdentifier;
     this._path = options.path ? [...options.path] : [];
@@ -151,6 +166,7 @@ class GraphModeNormalizer {
     this._sentFields = new Map();
     this._nextStreamID = 0;
     this._variables = variables;
+    this.duplicateFieldsAvoided = 0;
   }
 
   _getStreamID() {
@@ -271,6 +287,7 @@ class GraphModeNormalizer {
           // TODO: We could also opt to confirm that this matches the previously
           // seen value.
           if (sentFields.has(storageKey)) {
+            this.duplicateFieldsAvoided++;
             break;
           }
 
@@ -286,6 +303,7 @@ class GraphModeNormalizer {
           // TODO: We could also opt to confirm that this matches the previously
           // seen value.
           if (sentFields.has(storageKey)) {
+            this.duplicateFieldsAvoided++;
             break;
           }
           const fieldData = ((data[responseKey]: any): ChunkField);
@@ -379,6 +397,17 @@ class GraphModeNormalizer {
           // Since we are only expecting to handle server responses, we can skip
           // over client extensions.
           break;
+        case SCALAR_HANDLE:
+        case LINKED_HANDLE:
+          // Handles allow us to record information that will be needed to
+          // perform additional process when we insert data into the store. For
+          // example, connection edges need to be prepended/appended to the
+          // pre-existing values.
+          //
+          // GraphMode will eventually need some replacement for this, but it is
+          // not nessesary in order to measure things like response size, so we
+          // can ignore these for now.
+          break;
         default:
           throw new Error(`Unexpected selection type: ${selection.kind}`);
       }

package/store/RelayModernEnvironment.js.flow

@@ -1,5 +1,5 @@
 /**
- * Copyright (c) Facebook, Inc. and its affiliates.
+ * Copyright (c) Meta Platforms, Inc. and affiliates.
  *
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.

package/store/RelayModernFragmentSpecResolver.js.flow

@@ -1,5 +1,5 @@
 /**
- * Copyright (c) Facebook, Inc. and its affiliates.
+ * Copyright (c) Meta Platforms, Inc. and affiliates.
  *
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.

package/store/RelayModernOperationDescriptor.js.flow

@@ -1,5 +1,5 @@
 /**
- * Copyright (c) Facebook, Inc. and its affiliates.
+ * Copyright (c) Meta Platforms, Inc. and affiliates.
  *
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
@@ -44,7 +44,11 @@ function createOperationDescriptor<TQuery: OperationType>(
   dataID?: DataID = ROOT_ID,
 ): OperationDescriptor {
   const operation = request.operation;
-  const operationVariables = getOperationVariables(operation, variables);
+  const operationVariables = getOperationVariables(
+    operation,
+    request.params.providedVariables,
+    variables,
+  );
   const requestDescriptor = createRequestDescriptor(
     request,
     operationVariables,

package/store/RelayModernRecord.js.flow

@@ -1,5 +1,5 @@
 /**
- * Copyright (c) Facebook, Inc. and its affiliates.
+ * Copyright (c) Meta Platforms, Inc. and affiliates.
  *
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.

package/store/RelayModernSelector.js.flow

@@ -1,5 +1,5 @@
 /**
- * Copyright (c) Facebook, Inc. and its affiliates.
+ * Copyright (c) Meta Platforms, Inc. and affiliates.
  *
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.

package/store/RelayModernStore.js.flow

@@ -1,5 +1,5 @@
 /**
- * Copyright (c) Facebook, Inc. and its affiliates.
+ * Copyright (c) Meta Platforms, Inc. and affiliates.
  *
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
@@ -12,7 +12,6 @@
 
 'use strict';
 
-import type {ActorIdentifier} from '../multi-actor-environment/ActorIdentifier';
 import type {DataID, Disposable} from '../util/RelayRuntimeTypes';
 import type {Availability} from './DataChecker';
 import type {GetDataID} from './RelayResponseNormalizer';

package/store/RelayOperationTracker.js.flow

@@ -1,5 +1,5 @@
 /**
- * Copyright (c) Facebook, Inc. and its affiliates.
+ * Copyright (c) Meta Platforms, Inc. and affiliates.
  *
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.

package/store/RelayOptimisticRecordSource.js.flow

@@ -1,5 +1,5 @@
 /**
- * Copyright (c) Facebook, Inc. and its affiliates.
+ * Copyright (c) Meta Platforms, Inc. and affiliates.
  *
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.

package/store/RelayPublishQueue.js.flow

@@ -1,5 +1,5 @@
 /**
- * Copyright (c) Facebook, Inc. and its affiliates.
+ * Copyright (c) Meta Platforms, Inc. and affiliates.
  *
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
@@ -57,8 +57,15 @@ type PendingUpdater = {|
   +updater: StoreUpdater,
 |};
 
+const _global: typeof global | $FlowFixMe =
+  typeof global !== 'undefined'
+    ? global
+    : typeof window !== 'undefined'
+    ? window
+    : undefined;
+
 const applyWithGuard =
-  global?.ErrorUtils?.applyWithGuard ??
+  _global?.ErrorUtils?.applyWithGuard ??
   ((callback, context, args, onError, name) => callback.apply(context, args));
 
 /**

package/store/RelayReader.js.flow

@@ -1,5 +1,5 @@
 /**
- * Copyright (c) Facebook, Inc. and its affiliates.
+ * Copyright (c) Meta Platforms, Inc. and affiliates.
  *
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
@@ -109,6 +109,7 @@ class RelayReader {
   _selector: SingularReaderSelector;
   _variables: Variables;
   _resolverCache: ResolverCache;
+  _fragmentName: string;
 
   constructor(
     recordSource: RecordSource,
@@ -130,6 +131,7 @@ class RelayReader {
     this._selector = selector;
     this._variables = selector.variables;
     this._resolverCache = resolverCache;
+    this._fragmentName = selector.node.name;
   }
 
   read(): Snapshot {
@@ -267,7 +269,7 @@ class RelayReader {
       // encounter is likely to be the root cause of the error.
       return;
     }
-    const owner = this._selector.node.name;
+    const owner = this._fragmentName;
 
     switch (action) {
       case 'THROW':
@@ -275,9 +277,19 @@ class RelayReader {
         return;
       case 'LOG':
         if (this._missingRequiredFields == null) {
-          this._missingRequiredFields = {action, fields: []};
+          this._missingRequiredFields = {
+            action,
+            fields: [{path: fieldPath, owner}],
+          };
+        } else {
+          this._missingRequiredFields = {
+            action,
+            fields: [
+              ...this._missingRequiredFields.fields,
+              {path: fieldPath, owner},
+            ],
+          };
         }
-        this._missingRequiredFields.fields.push({path: fieldPath, owner});
         return;
       default:
         (action: empty);
@@ -293,13 +305,6 @@ class RelayReader {
       const selection = selections[i];
       switch (selection.kind) {
         case REQUIRED_FIELD:
-          invariant(
-            RelayFeatureFlags.ENABLE_REQUIRED_DIRECTIVES,
-            'RelayReader(): Encountered a `@required` directive at path "%s" in `%s` without the `ENABLE_REQUIRED_DIRECTIVES` feature flag enabled.',
-            selection.path,
-            this._selector.node.name,
-          );
-
           const fieldValue = this._readRequiredField(selection, record, data);
           if (fieldValue == null) {
             const {action} = selection;
@@ -490,8 +495,7 @@ class RelayReader {
         if (!RelayFeatureFlags.ENABLE_RELAY_RESOLVERS) {
           throw new Error('Relay Resolver fields are not yet supported.');
         }
-        this._readResolverField(selection.field, record, data);
-        break;
+        return this._readResolverField(selection.field, record, data);
       default:
         (selection.field.kind: empty);
         invariant(
@@ -506,7 +510,7 @@ class RelayReader {
     field: ReaderRelayResolver,
     record: Record,
     data: SelectorData,
-  ): void {
+  ): mixed {
     const {resolverModule, fragment} = field;
     const storageKey = getStorageKey(field, this._variables);
     const resolverID = ClientID.generateClientID(
@@ -519,6 +523,8 @@ class RelayReader {
     // inputs have changed since a previous evaluation:
     let fragmentValue;
     let fragmentReaderSelector;
+    let fragmentMissingRequiredFields: ?MissingRequiredFields;
+    let previousMissingRequriedFields: ?MissingRequiredFields;
     const fragmentSeenRecordIDs = new Set();
 
     const getDataForResolverFragment = singularReaderSelector => {
@@ -533,11 +539,14 @@ class RelayReader {
       try {
         this._seenRecords = fragmentSeenRecordIDs;
         const resolverFragmentData = {};
+        previousMissingRequriedFields = this._missingRequiredFields;
+        this._missingRequiredFields = null;
         this._createInlineDataOrResolverFragmentPointer(
           singularReaderSelector.node,
           record,
           resolverFragmentData,
         );
+        fragmentMissingRequiredFields = this._missingRequiredFields;
         fragmentValue = resolverFragmentData[FRAGMENTS_KEY]?.[fragment.name];
         invariant(
           typeof fragmentValue === 'object' && fragmentValue !== null,
@@ -546,42 +555,50 @@ class RelayReader {
         return fragmentValue;
       } finally {
         this._seenRecords = existingSeenRecords;
+        this._missingRequiredFields = previousMissingRequriedFields;
       }
     };
     const resolverContext = {getDataForResolverFragment};
 
-    const [result, seenRecord] = this._resolverCache.readFromCacheOrEvaluate(
-      record,
-      field,
-      this._variables,
-      () => {
-        const key = {
-          __id: RelayModernRecord.getDataID(record),
-          __fragmentOwner: this._owner,
-          __fragments: {
-            [fragment.name]: {}, // Arguments to this fragment; not yet supported.
-          },
-        };
-        return withResolverContext(resolverContext, () => {
-          // $FlowFixMe[prop-missing] - resolver module's type signature is a lie
-          const resolverResult = resolverModule(key);
-          return {
-            resolverResult,
-            fragmentValue,
-            resolverID,
-            seenRecordIDs: fragmentSeenRecordIDs,
-            readerSelector: fragmentReaderSelector,
+    const [result, seenRecord, missingRequiredFields] =
+      this._resolverCache.readFromCacheOrEvaluate(
+        record,
+        field,
+        this._variables,
+        () => {
+          const key = {
+            __id: RelayModernRecord.getDataID(record),
+            __fragmentOwner: this._owner,
+            __fragments: {
+              [fragment.name]: {}, // Arguments to this fragment; not yet supported.
+            },
           };
-        });
-      },
-      getDataForResolverFragment,
-    );
+          return withResolverContext(resolverContext, () => {
+            // $FlowFixMe[prop-missing] - resolver module's type signature is a lie
+            const resolverResult = resolverModule(key);
+            return {
+              resolverResult,
+              fragmentValue,
+              resolverID,
+              seenRecordIDs: fragmentSeenRecordIDs,
+              readerSelector: fragmentReaderSelector,
+              missingRequiredFields: fragmentMissingRequiredFields,
+            };
+          });
+        },
+        getDataForResolverFragment,
+      );
+
+    if (missingRequiredFields != null) {
+      this._addMissingRequiredFields(missingRequiredFields);
+    }
     if (seenRecord != null) {
       this._seenRecords.add(seenRecord);
     }
 
     const applicationName = field.alias ?? field.name;
     data[applicationName] = result;
+    return result;
   }
 
   _readClientEdge(
@@ -903,14 +920,37 @@ class RelayReader {
       data[ID_KEY] = RelayModernRecord.getDataID(record);
     }
     const inlineData = {};
+    const parentFragmentName = this._fragmentName;
+    this._fragmentName = fragmentSpreadOrFragment.name;
     this._traverseSelections(
       fragmentSpreadOrFragment.selections,
       record,
       inlineData,
     );
+    this._fragmentName = parentFragmentName;
     // $FlowFixMe[cannot-write] - writing into read-only field
     fragmentPointers[fragmentSpreadOrFragment.name] = inlineData;
   }
+
+  _addMissingRequiredFields(additional: MissingRequiredFields) {
+    if (this._missingRequiredFields == null) {
+      this._missingRequiredFields = additional;
+      return;
+    }
+
+    if (this._missingRequiredFields.action === 'THROW') {
+      return;
+    }
+    if (additional.action === 'THROW') {
+      this._missingRequiredFields = additional;
+      return;
+    }
+
+    this._missingRequiredFields = {
+      action: 'LOG',
+      fields: [...this._missingRequiredFields.fields, ...additional.fields],
+    };
+  }
 }
 
 module.exports = {read};

package/store/RelayRecordSource.js.flow

@@ -1,5 +1,5 @@
 /**
- * Copyright (c) Facebook, Inc. and its affiliates.
+ * Copyright (c) Meta Platforms, Inc. and affiliates.
  *
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.

package/store/RelayRecordState.js.flow

@@ -1,5 +1,5 @@
 /**
- * Copyright (c) Facebook, Inc. and its affiliates.
+ * Copyright (c) Meta Platforms, Inc. and affiliates.
  *
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.

package/store/RelayReferenceMarker.js.flow

@@ -1,5 +1,5 @@
 /**
- * Copyright (c) Facebook, Inc. and its affiliates.
+ * Copyright (c) Meta Platforms, Inc. and affiliates.
  *
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.

package/store/RelayResponseNormalizer.js.flow

@@ -1,5 +1,5 @@
 /**
- * Copyright (c) Facebook, Inc. and its affiliates.
+ * Copyright (c) Meta Platforms, Inc. and affiliates.
  *
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.

package/store/RelayStoreReactFlightUtils.js.flow

@@ -1,5 +1,5 @@
 /**
- * Copyright (c) Facebook, Inc. and its affiliates.
+ * Copyright (c) Meta Platforms, Inc. and affiliates.
  *
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.

package/store/RelayStoreSubscriptions.js.flow

@@ -1,5 +1,5 @@
 /**
- * Copyright (c) Facebook, Inc. and its affiliates.
+ * Copyright (c) Meta Platforms, Inc. and affiliates.
  *
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.

package/store/RelayStoreTypes.js.flow

@@ -1,5 +1,5 @@
 /**
- * Copyright (c) Facebook, Inc. and its affiliates.
+ * Copyright (c) Meta Platforms, Inc. and affiliates.
  *
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
@@ -117,9 +117,10 @@ type MissingRequiredField = {|
   owner: string,
 |};
 
-export type MissingRequiredFields =
+export type MissingRequiredFields = $ReadOnly<
   | {|action: 'THROW', field: MissingRequiredField|}
-  | {|action: 'LOG', fields: Array<MissingRequiredField>|};
+  | {|action: 'LOG', fields: Array<MissingRequiredField>|},
+>;
 
 export type ClientEdgeTraversalInfo = {|
   +readerClientEdge: ReaderClientEdge,

package/store/RelayStoreUtils.js.flow

@@ -1,5 +1,5 @@
 /**
- * Copyright (c) Facebook, Inc. and its affiliates.
+ * Copyright (c) Meta Platforms, Inc. and affiliates.
  *
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
@@ -219,6 +219,7 @@ const RelayStoreUtils = {
   RELAY_RESOLVER_INVALIDATION_KEY: '__resolverValueMayBeInvalid',
   RELAY_RESOLVER_INPUTS_KEY: '__resolverInputValues',
   RELAY_RESOLVER_READER_SELECTOR_KEY: '__resolverReaderSelector',
+  RELAY_RESOLVER_MISSING_REQUIRED_FIELDS_KEY: '__resolverMissingRequiredFields',
 
   formatStorageKey,
   getArgumentValue,