relay-runtime 13.0.0-rc.1 → 13.0.2

package/mutations/readUpdatableQuery_EXPERIMENTAL.js.flow

@@ -1,5 +1,5 @@
 /**
- * Copyright (c) Facebook, Inc. and its affiliates.
+ * Copyright (c) Meta Platforms, Inc. and affiliates.
  *
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
@@ -21,7 +21,7 @@ import type {OperationType} from '../util/RelayRuntimeTypes';
 const {getRequest} = require('../query/GraphQLTag');
 const {getArgumentValues} = require('../store/RelayStoreUtils');
 
-const nonUpdatableKeys = ['id', '__id', '__typename'];
+const nonUpdatableKeys = ['id', '__id', '__typename', 'js'];
 
 function readUpdatableQuery_EXPERIMENTAL<TQuery: OperationType>(
   query: GraphQLTaggedNode,
@@ -55,50 +55,46 @@ function updateProxyFromSelections<TQuery: OperationType>(
   for (const selection of selections) {
     switch (selection.kind) {
       case 'LinkedField':
-        // Linked fields are assignable if they contain fragment spreads or
-        // read-only otherwise.
-        const isAssignable = selection.selections.some(
-          item => item.kind === 'FragmentSpread',
-        );
-
-        const set = !isAssignable
-          ? undefined
-          : selection.plural
-          ? createSetterForPluralLinkedField(
-              selection,
-              queryVariables,
-              recordProxy,
-              root,
-            )
-          : createSetterForSingularLinkedField(
-              selection,
-              queryVariables,
-              recordProxy,
-              root,
-            );
-
-        const get = selection.plural
-          ? createGetterForPluralLinkedField(
-              selection,
-              queryVariables,
-              recordProxy,
-              root,
-            )
-          : createGetterForSingularLinkedField(
-              selection,
-              queryVariables,
-              recordProxy,
-              root,
-            );
-
-        Object.defineProperty(
-          mutableUpdatableProxy,
-          selection.alias ?? selection.name,
-          {
-            get,
-            set,
-          },
-        );
+        if (selection.plural) {
+          Object.defineProperty(
+            mutableUpdatableProxy,
+            selection.alias ?? selection.name,
+            {
+              // $FlowFixMe[incompatible-call] these getters and setters have different types on purpose
+              get: createGetterForPluralLinkedField(
+                selection,
+                queryVariables,
+                recordProxy,
+                root,
+              ),
+              set: createSetterForPluralLinkedField(
+                selection,
+                queryVariables,
+                recordProxy,
+                root,
+              ),
+            },
+          );
+        } else {
+          Object.defineProperty(
+            mutableUpdatableProxy,
+            selection.alias ?? selection.name,
+            {
+              get: createGetterForSingularLinkedField(
+                selection,
+                queryVariables,
+                recordProxy,
+                root,
+              ),
+              set: createSetterForSingularLinkedField(
+                selection,
+                queryVariables,
+                recordProxy,
+                root,
+              ),
+            },
+          );
+        }
         break;
       case 'ScalarField':
         const scalarFieldName = selection.alias ?? selection.name;
@@ -145,6 +141,15 @@ function updateProxyFromSelections<TQuery: OperationType>(
           );
         }
         break;
+      case 'ClientExtension':
+        updateProxyFromSelections(
+          mutableUpdatableProxy,
+          recordProxy,
+          queryVariables,
+          selection.selections,
+          root,
+        );
+        break;
       case 'FragmentSpread':
         // Explicitly ignore
         break;
@@ -162,11 +167,12 @@ function createSetterForPluralLinkedField<TQuery: OperationType>(
   recordProxy: RecordProxy,
   root: RecordSourceProxy,
 ) {
-  return function set(newValue: ?$ReadOnlyArray<{__id: string, ...}>) {
+  return function set(newValue: $ReadOnlyArray<{__id: string, ...}>) {
     const variables = getArgumentValues(selection.args ?? [], queryVariables);
     if (newValue == null) {
-      // $FlowFixMe[unclear-type] No good way to type these variables
-      recordProxy.setValue(null, selection.name, (variables: any));
+      throw new Error(
+        'Do not assign null to plural linked fields; assign an empty array instead.',
+      );
     } else {
       const recordProxies = newValue.map(item => {
         if (item == null) {
@@ -197,6 +203,7 @@ function createSetterForPluralLinkedField<TQuery: OperationType>(
     }
   };
 }
+
 function createSetterForSingularLinkedField<TQuery: OperationType>(
   selection: ReaderLinkedField,
   queryVariables: TQuery['variables'],
@@ -207,7 +214,7 @@ function createSetterForSingularLinkedField<TQuery: OperationType>(
     const variables = getArgumentValues(selection.args ?? [], queryVariables);
     if (newValue == null) {
       // $FlowFixMe[unclear-type] No good way to type these variables
-      recordProxy.setValue(null, selection.name, (variables: any));
+      recordProxy.setValue(newValue, selection.name, (variables: any));
     } else {
       const {__id} = newValue;
       if (__id == null) {

package/mutations/validateMutation.js.flow

@@ -1,5 +1,5 @@
 /**
- * Copyright (c) Facebook, Inc. and its affiliates.
+ * Copyright (c) Meta Platforms, Inc. and affiliates.
  *
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.

package/network/ConvertToExecuteFunction.js.flow

@@ -1,5 +1,5 @@
 /**
- * Copyright (c) Facebook, Inc. and its affiliates.
+ * Copyright (c) Meta Platforms, Inc. and affiliates.
  *
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.

package/network/RelayNetwork.js.flow

@@ -1,5 +1,5 @@
 /**
- * Copyright (c) Facebook, Inc. and its affiliates.
+ * Copyright (c) Meta Platforms, Inc. and affiliates.
  *
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
@@ -24,6 +24,7 @@ import type {
 } from './RelayNetworkTypes';
 import type RelayObservable from './RelayObservable';
 
+const withProvidedVariables = require('../util/withProvidedVariables');
 const {convertFetch} = require('./ConvertToExecuteFunction');
 const invariant = require('invariant');
 
@@ -45,6 +46,10 @@ function create(
     uploadables?: ?UploadableMap,
     logRequestInfo: ?LogRequestInfoFunction,
   ): RelayObservable<GraphQLResponse> {
+    const operationVariables = withProvidedVariables(
+      variables,
+      request.providedVariables,
+    );
     if (request.operationKind === 'subscription') {
       invariant(
         subscribe,
@@ -56,7 +61,7 @@ function create(
         !uploadables,
         'RelayNetwork: Cannot provide uploadables while subscribing.',
       );
-      return subscribe(request, variables, cacheConfig);
+      return subscribe(request, operationVariables, cacheConfig);
     }
 
     const pollInterval = cacheConfig.poll;
@@ -65,12 +70,14 @@ function create(
         !uploadables,
         'RelayNetwork: Cannot provide uploadables while polling.',
       );
-      return observeFetch(request, variables, {force: true}).poll(pollInterval);
+      return observeFetch(request, operationVariables, {force: true}).poll(
+        pollInterval,
+      );
     }
 
     return observeFetch(
       request,
-      variables,
+      operationVariables,
       cacheConfig,
       uploadables,
       logRequestInfo,

package/network/RelayNetworkTypes.js.flow

@@ -1,5 +1,5 @@
 /**
- * Copyright (c) Facebook, Inc. and its affiliates.
+ * Copyright (c) Meta Platforms, Inc. and affiliates.
  *
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
@@ -26,7 +26,7 @@ export interface INetwork {
 
 export type LogRequestInfoFunction = mixed => void;
 
-export type PayloadData = interface {[key: string]: mixed};
+export type PayloadData = {[key: string]: mixed};
 
 export type PayloadError = interface {
   message: string,

package/network/RelayObservable.js.flow

@@ -1,5 +1,5 @@
 /**
- * Copyright (c) Facebook, Inc. and its affiliates.
+ * Copyright (c) Meta Platforms, Inc. and affiliates.
  *
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.

package/network/RelayQueryResponseCache.js.flow

@@ -1,5 +1,5 @@
 /**
- * Copyright (c) Facebook, Inc. and its affiliates.
+ * Copyright (c) Meta Platforms, Inc. and affiliates.
  *
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.

package/network/wrapNetworkWithLogObserver.js.flow

@@ -1,5 +1,5 @@
 /**
- * Copyright (c) Facebook, Inc. and its affiliates.
+ * Copyright (c) Meta Platforms, Inc. and affiliates.
  *
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
@@ -11,8 +11,6 @@
 // flowlint ambiguous-object-type:error
 
 'use strict';
-import type {Subscription} from './RelayObservable';
-
 import type ActorSpecificEnvironment from '../multi-actor-environment/ActorSpecificEnvironment';
 import type RelayModernEnvironment from '../store/RelayModernEnvironment';
 import type {RequestParameters} from '../util/RelayConcreteNode';
@@ -23,6 +21,7 @@ import type {
   UploadableMap,
 } from './RelayNetworkTypes';
 import type RelayObservable from './RelayObservable';
+import type {Subscription} from './RelayObservable';
 
 const generateID = require('../util/generateID');
 

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "relay-runtime",
   "description": "A core runtime for building GraphQL-driven applications.",
-  "version": "13.0.0-rc.1",
+  "version": "13.0.2",
   "keywords": [
     "graphql",
     "relay"
@@ -12,7 +12,7 @@
   "repository": "facebook/relay",
   "dependencies": {
     "@babel/runtime": "^7.0.0",
-    "fbjs": "^3.0.0",
+    "fbjs": "^3.0.2",
     "invariant": "^2.2.4"
   },
   "directories": {

package/query/GraphQLTag.js.flow

@@ -1,5 +1,5 @@
 /**
- * Copyright (c) Facebook, Inc. and its affiliates.
+ * Copyright (c) Meta Platforms, Inc. and affiliates.
  *
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
@@ -39,7 +39,7 @@ export type GraphQLTaggedNode =
  * Runtime function to correspond to the `graphql` tagged template function.
  * All calls to this function should be transformed by the plugin.
  */
-function graphql(strings: Array<string>): GraphQLTaggedNode {
+function graphql(strings: Array<string>): any {
   invariant(
     false,
     'graphql: Unexpected invocation at runtime. Either the Babel transform ' +

package/query/PreloadableQueryRegistry.js.flow

@@ -1,5 +1,5 @@
 /**
- * Copyright (c) Facebook, Inc. and its affiliates.
+ * Copyright (c) Meta Platforms, Inc. and affiliates.
  *
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
@@ -11,7 +11,8 @@
 
 'use strict';
 
-import type {ConcreteRequest, Disposable} from 'relay-runtime';
+import type {ConcreteRequest} from '../util/RelayConcreteNode';
+import type {Disposable} from '../util/RelayRuntimeTypes';
 
 type Callback = (concreteRequest: ConcreteRequest) => void;
 

package/query/fetchQuery.js.flow

@@ -1,5 +1,5 @@
 /**
- * Copyright (c) Facebook, Inc. and its affiliates.
+ * Copyright (c) Meta Platforms, Inc. and affiliates.
  *
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
@@ -14,15 +14,17 @@
 'use strict';
 
 import type {
-  CacheConfig,
-  FetchQueryFetchPolicy,
-  GraphQLTaggedNode,
   IEnvironment,
   OperationDescriptor,
-  OperationType,
   Snapshot,
-  VariablesOf,
-} from 'relay-runtime';
+} from '../store/RelayStoreTypes';
+import type {
+  CacheConfig,
+  FetchQueryFetchPolicy,
+  OperationType,
+  Query,
+  Variables,
+} from '../util/RelayRuntimeTypes';
 
 const RelayObservable = require('../network/RelayObservable');
 const {
@@ -110,15 +112,15 @@ const invariant = require('invariant');
  * ```
  * NOTE: When using .toPromise(), the request cannot be cancelled.
  */
-function fetchQuery<TQuery: OperationType>(
+function fetchQuery<TVariables: Variables, TData, TRawResponse>(
   environment: IEnvironment,
-  query: GraphQLTaggedNode,
-  variables: VariablesOf<TQuery>,
+  query: Query<TVariables, TData, TRawResponse>,
+  variables: TVariables,
   options?: $ReadOnly<{|
     fetchPolicy?: FetchQueryFetchPolicy,
     networkCacheConfig?: CacheConfig,
   |}>,
-): RelayObservable<TQuery['response']> {
+): RelayObservable<TData> {
   const queryNode = getRequest(query);
   invariant(
     queryNode.params.operationKind === 'query',
@@ -135,10 +137,12 @@ function fetchQuery<TQuery: OperationType>(
   );
   const fetchPolicy = options?.fetchPolicy ?? 'network-only';
 
-  function readData(snapshot: Snapshot) {
+  function readData(snapshot: Snapshot): TData {
     if (snapshot.missingRequiredFields != null) {
       reportMissingRequiredFields(environment, snapshot.missingRequiredFields);
     }
+    /* $FlowFixMe[incompatible-return] we assume readData returns the right
+     * data just having written it from network or checked availability. */
     return snapshot.data;
   }
 

package/query/fetchQueryInternal.js.flow

@@ -1,5 +1,5 @@
 /**
- * Copyright (c) Facebook, Inc. and its affiliates.
+ * Copyright (c) Meta Platforms, Inc. and affiliates.
  *
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.

package/query/fetchQuery_DEPRECATED.js.flow

@@ -1,5 +1,5 @@
 /**
- * Copyright (c) Facebook, Inc. and its affiliates.
+ * Copyright (c) Meta Platforms, Inc. and affiliates.
  *
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.