react-native 0.84.0-nightly-20251106-de5141a3d → 0.84.0-nightly-20251107-f8198f662

package/ReactCommon/react/renderer/animationbackend/AnimationBackend.cpp

@@ -10,6 +10,18 @@
 
 namespace facebook::react {
 
+UIManagerNativeAnimatedDelegateBackendImpl::
+    UIManagerNativeAnimatedDelegateBackendImpl(
+        std::weak_ptr<UIManagerAnimationBackend> animationBackend)
+    : animationBackend_(std::move(animationBackend)) {}
+
+void UIManagerNativeAnimatedDelegateBackendImpl::runAnimationFrame() {
+  if (auto animationBackendStrong = animationBackend_.lock()) {
+    animationBackendStrong->onAnimationFrame(
+        std::chrono::steady_clock::now().time_since_epoch().count() / 1000);
+  }
+}
+
 static inline Props::Shared cloneProps(
     AnimatedProps& animatedProps,
     const ShadowNode& shadowNode) {
@@ -87,19 +99,23 @@ AnimationBackend::AnimationBackend(
 
 void AnimationBackend::onAnimationFrame(double timestamp) {
   std::unordered_map<Tag, AnimatedProps> updates;
-  std::unordered_set<const ShadowNodeFamily*> families;
+  std::unordered_map<SurfaceId, std::unordered_set<const ShadowNodeFamily*>>
+      surfaceToFamilies;
   bool hasAnyLayoutUpdates = false;
   for (auto& callback : callbacks) {
     auto muatations = callback(static_cast<float>(timestamp));
     for (auto& mutation : muatations) {
       hasAnyLayoutUpdates |= mutationHasLayoutUpdates(mutation);
-      families.insert(mutation.family);
+      const auto family = mutation.family;
+      if (family != nullptr) {
+        surfaceToFamilies[family->getSurfaceId()].insert(family);
+      }
       updates[mutation.tag] = std::move(mutation.props);
     }
   }
 
   if (hasAnyLayoutUpdates) {
-    commitUpdatesWithFamilies(families, updates);
+    commitUpdates(surfaceToFamilies, updates);
   } else {
     synchronouslyUpdateProps(updates);
   }
@@ -108,41 +124,60 @@ void AnimationBackend::onAnimationFrame(double timestamp) {
 void AnimationBackend::start(const Callback& callback, bool isAsync) {
   callbacks.push_back(callback);
   // TODO: startOnRenderCallback_ should provide the timestamp from the platform
-  startOnRenderCallback_(
-      [this]() {
-        onAnimationFrame(
-            std::chrono::steady_clock::now().time_since_epoch().count() / 1000);
-      },
-      isAsync);
+  if (startOnRenderCallback_) {
+    startOnRenderCallback_(
+        [this]() {
+          onAnimationFrame(
+              std::chrono::steady_clock::now().time_since_epoch().count() /
+              1000);
+        },
+        isAsync);
+  }
 }
 void AnimationBackend::stop(bool isAsync) {
-  stopOnRenderCallback_(isAsync);
+  if (stopOnRenderCallback_) {
+    stopOnRenderCallback_(isAsync);
+  }
   callbacks.clear();
 }
 
-void AnimationBackend::commitUpdatesWithFamilies(
-    const std::unordered_set<const ShadowNodeFamily*>& families,
+void AnimationBackend::commitUpdates(
+    const std::unordered_map<
+        SurfaceId,
+        std::unordered_set<const ShadowNodeFamily*>>& surfaceToFamilies,
     std::unordered_map<Tag, AnimatedProps>& updates) {
-  uiManager_->getShadowTreeRegistry().enumerate(
-      [families, &updates](const ShadowTree& shadowTree, bool& /*stop*/) {
-        shadowTree.commit(
-            [families, &updates](const RootShadowNode& oldRootShadowNode) {
-              return std::static_pointer_cast<RootShadowNode>(
-                  oldRootShadowNode.cloneMultiple(
-                      families,
-                      [families, &updates](
-                          const ShadowNode& shadowNode,
-                          const ShadowNodeFragment& fragment) {
-                        auto& animatedProps = updates.at(shadowNode.getTag());
-                        auto newProps = cloneProps(animatedProps, shadowNode);
-                        return shadowNode.clone(
-                            {newProps,
-                             fragment.children,
-                             shadowNode.getState()});
-                      }));
-            },
-            {.mountSynchronously = true});
-      });
+  for (const auto& surfaceEntry : surfaceToFamilies) {
+    const auto& surfaceId = surfaceEntry.first;
+    const auto& surfaceFamilies = surfaceEntry.second;
+    uiManager_->getShadowTreeRegistry().visit(
+        surfaceId, [&surfaceFamilies, &updates](const ShadowTree& shadowTree) {
+          shadowTree.commit(
+              [&surfaceFamilies,
+               &updates](const RootShadowNode& oldRootShadowNode) {
+                return std::static_pointer_cast<RootShadowNode>(
+                    oldRootShadowNode.cloneMultiple(
+                        surfaceFamilies,
+                        [&surfaceFamilies, &updates](
+                            const ShadowNode& shadowNode,
+                            const ShadowNodeFragment& fragment) {
+                          auto newProps =
+                              ShadowNodeFragment::propsPlaceholder();
+                          if (surfaceFamilies.contains(
+                                  &shadowNode.getFamily())) {
+                            auto& animatedProps =
+                                updates.at(shadowNode.getTag());
+                            newProps = cloneProps(animatedProps, shadowNode);
+                          }
+                          return shadowNode.clone(
+                              {.props = newProps,
+                               .children = fragment.children,
+                               .state = shadowNode.getState(),
+                               .runtimeShadowNodeReference = false});
+                        }));
+              },
+              {.mountSynchronously = true});
+        });
+  }
 }
 
 void AnimationBackend::synchronouslyUpdateProps(

package/ReactCommon/react/renderer/animationbackend/AnimationBackend.h

@@ -18,6 +18,18 @@
 
 namespace facebook::react {
 
+class AnimationBackend;
+
+class UIManagerNativeAnimatedDelegateBackendImpl : public UIManagerNativeAnimatedDelegate {
+ public:
+  explicit UIManagerNativeAnimatedDelegateBackendImpl(std::weak_ptr<UIManagerAnimationBackend> animationBackend);
+
+  void runAnimationFrame() override;
+
+ private:
+  std::weak_ptr<UIManagerAnimationBackend> animationBackend_;
+};
+
 struct AnimationMutation {
   Tag tag;
   const ShadowNodeFamily *family;
@@ -47,8 +59,8 @@ class AnimationBackend : public UIManagerAnimationBackend {
       DirectManipulationCallback &&directManipulationCallback,
       FabricCommitCallback &&fabricCommitCallback,
       UIManager *uiManager);
-  void commitUpdatesWithFamilies(
-      const std::unordered_set<const ShadowNodeFamily *> &families,
+  void commitUpdates(
+      const std::unordered_map<SurfaceId, std::unordered_set<const ShadowNodeFamily *>> &surfaceToFamilies,
       std::unordered_map<Tag, AnimatedProps> &updates);
   void synchronouslyUpdateProps(const std::unordered_map<Tag, AnimatedProps> &updates);
 

package/ReactCommon/react/renderer/core/EventDispatcher.cpp

@@ -6,7 +6,7 @@
  */
 
 #include "EventDispatcher.h"
-#include <cxxreact/JSExecutor.h>
+
 #include <react/renderer/core/StateUpdate.h>
 
 #include "EventQueue.h"

package/ReactCommon/react/renderer/core/EventQueueProcessor.cpp

@@ -5,13 +5,13 @@
  * LICENSE file in the root directory of this source tree.
  */
 
-#include <cxxreact/JSExecutor.h>
+#include "EventQueueProcessor.h"
+
 #include <logger/react_native_log.h>
 #include <react/featureflags/ReactNativeFeatureFlags.h>
+
 #include "EventEmitter.h"
 #include "EventLogger.h"
-#include "EventQueue.h"
-#include "ShadowNodeFamily.h"
 
 namespace facebook::react {
 

package/ReactCommon/react/runtime/ReactInstance.cpp

@@ -18,10 +18,10 @@
 #include <jsi/hermes.h>
 #include <jsi/instrumentation.h>
 #include <jsinspector-modern/HostTarget.h>
-#include <jsireact/JSIExecutor.h>
 #include <react/featureflags/ReactNativeFeatureFlags.h>
 #include <react/renderer/core/ShadowNode.h>
 #include <react/renderer/runtimescheduler/RuntimeSchedulerBinding.h>
+#include <react/runtime/JSRuntimeBindings.h>
 #include <react/timing/primitives.h>
 #include <react/utils/jsi-utils.h>
 #include <iostream>
@@ -48,6 +48,12 @@ std::shared_ptr<RuntimeScheduler> createRuntimeScheduler(
   return scheduler;
 }
 
+std::string getSyntheticBundlePath(uint32_t bundleId) {
+  std::array<char, 32> buffer{};
+  std::snprintf(buffer.data(), buffer.size(), "seg-%u.js", bundleId);
+  return buffer.data();
+}
+
 } // namespace
 
 ReactInstance::ReactInstance(
@@ -365,12 +371,8 @@ void ReactInstance::registerSegment(
     }
     LOG(WARNING) << "Starting to evaluate segment " << segmentId
                  << " in ReactInstance::registerSegment";
-#pragma clang diagnostic push
-#pragma clang diagnostic ignored "-Wdeprecated-declarations"
     runtime.evaluateJavaScript(
-        std::move(script),
-        JSExecutor::getSyntheticBundlePath(segmentId, segmentPath));
-#pragma clang diagnostic pop
+        std::move(script), getSyntheticBundlePath(segmentId));
     LOG(WARNING) << "Finished evaluating segment " << segmentId
                  << " in ReactInstance::registerSegment";
     if (hasLogger) {

package/ReactCommon/react/runtime/ReactInstance.h

@@ -13,7 +13,6 @@
 #include <jserrorhandler/JsErrorHandler.h>
 #include <jsi/jsi.h>
 #include <jsinspector-modern/ReactCdp.h>
-#include <jsireact/JSIExecutor.h>
 #include <react/renderer/runtimescheduler/RuntimeScheduler.h>
 #include <react/runtime/BufferedRuntimeExecutor.h>
 #include <react/runtime/JSRuntimeFactory.h>

package/flow/bom.js.flow

@@ -25,6 +25,10 @@ type DevToolsColor =
   | 'warning'
   | 'error';
 
+declare interface ConsoleTask {
+  run<T>(f: () => T): T;
+}
+
 // $FlowExpectedError[libdef-override] Flow core definitions are incomplete.
 declare var console: {
   // Logging
@@ -75,6 +79,9 @@ declare var console: {
     detail?: {[string]: mixed},
   ): void,
 
+  // Stack tagging
+  createTask(label: string): ConsoleTask,
+
   ...
 };
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "react-native",
-  "version": "0.84.0-nightly-20251106-de5141a3d",
+  "version": "0.84.0-nightly-20251107-f8198f662",
   "description": "A framework for building native apps using React",
   "license": "MIT",
   "repository": {
@@ -160,13 +160,13 @@
   },
   "dependencies": {
     "@jest/create-cache-key-function": "^29.7.0",
-    "@react-native/assets-registry": "0.84.0-nightly-20251106-de5141a3d",
-    "@react-native/codegen": "0.84.0-nightly-20251106-de5141a3d",
-    "@react-native/community-cli-plugin": "0.84.0-nightly-20251106-de5141a3d",
-    "@react-native/gradle-plugin": "0.84.0-nightly-20251106-de5141a3d",
-    "@react-native/js-polyfills": "0.84.0-nightly-20251106-de5141a3d",
-    "@react-native/normalize-colors": "0.84.0-nightly-20251106-de5141a3d",
-    "@react-native/virtualized-lists": "0.84.0-nightly-20251106-de5141a3d",
+    "@react-native/assets-registry": "0.84.0-nightly-20251107-f8198f662",
+    "@react-native/codegen": "0.84.0-nightly-20251107-f8198f662",
+    "@react-native/community-cli-plugin": "0.84.0-nightly-20251107-f8198f662",
+    "@react-native/gradle-plugin": "0.84.0-nightly-20251107-f8198f662",
+    "@react-native/js-polyfills": "0.84.0-nightly-20251107-f8198f662",
+    "@react-native/normalize-colors": "0.84.0-nightly-20251107-f8198f662",
+    "@react-native/virtualized-lists": "0.84.0-nightly-20251107-f8198f662",
     "abort-controller": "^3.0.0",
     "anser": "^1.4.9",
     "ansi-regex": "^5.0.0",

package/scripts/ios-configure-glog.sh

@@ -14,7 +14,12 @@ if [ -z "$CURRENT_ARCH" ] || [ "$CURRENT_ARCH" == "undefined_arch" ]; then
     # it's better to rely on platform name as fallback because architecture differs between simulator and device
 
     if [[ "$PLATFORM_NAME" == *"simulator"* ]]; then
-        CURRENT_ARCH="x86_64"
+        if [[ "$(uname -m)" == "arm64" ]]; then
+            # Apple Silicon Mac -> arm64 simulator
+            CURRENT_ARCH="arm64"
+        else
+            CURRENT_ARCH="x86_64"
+        fi
     else
         CURRENT_ARCH="arm64"
     fi

package/types_generated/Libraries/Components/Button.d.ts

@@ -4,7 +4,7 @@
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
  *
- * @generated SignedSource<<e274c506268d59995c9056015fe6b381>>
+ * @generated SignedSource<<c9de7b7b7e9d2c6170460f127e7a2659>>
  *
  * This file was translated from Flow by scripts/js-api/build-types/index.js.
  * Original file: packages/react-native/Libraries/Components/Button.js
@@ -142,9 +142,6 @@ export type ButtonProps = Readonly<{
   [button:source]:
   https://github.com/facebook/react-native/blob/HEAD/Libraries/Components/Button.js
 
-  [button:examples]:
-  https://js.coach/?menu%5Bcollections%5D=React%20Native&page=1&query=button
-
   ```jsx
   <Button
     onPress={onPressLearnMore}

package/types_generated/Libraries/StyleSheet/PlatformColorValueTypes.d.ts

@@ -4,14 +4,14 @@
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
  *
- * @generated SignedSource<<e6cfac80b368b1a3e962fdc2fbac77de>>
+ * @generated SignedSource<<6313a2ed74066cde1bcc0fbaed89176a>>
  *
  * This file was translated from Flow by scripts/js-api/build-types/index.js.
  * Original file: packages/react-native/Libraries/StyleSheet/PlatformColorValueTypes.js.flow
  */
 
 import type { ProcessedColorValue } from "./processColor";
-import type { ColorValue, NativeColorValue } from "./StyleSheet";
-export declare function PlatformColor(...names: Array<string>): ColorValue;
+import type { NativeColorValue } from "./StyleSheet";
+export declare function PlatformColor(...names: Array<string>): NativeColorValue;
 export declare function normalizeColorObject(color: NativeColorValue): null | undefined | ProcessedColorValue;
 export declare function processColorObject(color: NativeColorValue): null | undefined | NativeColorValue;

package/ReactAndroid/src/main/java/com/facebook/react/bridge/CxxModuleWrapper.kt

@@ -1,25 +0,0 @@
-/*
- * Copyright (c) Meta Platforms, Inc. and affiliates.
- *
- * This source code is licensed under the MIT license found in the
- * LICENSE file in the root directory of this source tree.
- */
-
-package com.facebook.react.bridge
-
-import com.facebook.jni.HybridData
-import com.facebook.proguard.annotations.DoNotStrip
-import com.facebook.react.common.annotations.internal.InteropLegacyArchitecture
-import com.facebook.react.common.annotations.internal.LegacyArchitectureLogger
-
-/** This does nothing interesting, except avoid breaking existing code. */
-@DoNotStrip
-@InteropLegacyArchitecture
-public open class CxxModuleWrapper protected constructor(hybridData: HybridData) :
-    CxxModuleWrapperBase(hybridData) {
-  private companion object {
-    init {
-      LegacyArchitectureLogger.assertLegacyArchitecture("CxxModuleWrapper")
-    }
-  }
-}

package/ReactAndroid/src/main/java/com/facebook/react/bridge/CxxModuleWrapperBase.kt

@@ -1,61 +0,0 @@
-/*
- * Copyright (c) Meta Platforms, Inc. and affiliates.
- *
- * This source code is licensed under the MIT license found in the
- * LICENSE file in the root directory of this source tree.
- */
-
-package com.facebook.react.bridge
-
-import com.facebook.jni.HybridData
-import com.facebook.proguard.annotations.DoNotStrip
-import com.facebook.react.common.annotations.internal.InteropLegacyArchitecture
-import com.facebook.react.common.annotations.internal.LegacyArchitectureLogLevel
-import com.facebook.react.common.annotations.internal.LegacyArchitectureLogger
-
-/**
- * A Java Object which represents a cross-platform C++ module
- *
- * This module implements the [NativeModule] interface but will never be invoked from Java, instead
- * the underlying Cxx module will be extracted by the bridge and called directly.
- */
-@DoNotStrip
-@InteropLegacyArchitecture
-public open class CxxModuleWrapperBase
-protected constructor(
-    // For creating a wrapper from C++, or from a derived class.
-    @Suppress("NoHungarianNotation") @DoNotStrip private var mHybridData: HybridData
-) : NativeModule {
-  external override fun getName(): String
-
-  override fun initialize() {
-    // do nothing
-  }
-
-  @Deprecated(
-      "The method canOverrideExistingModule is not used in the New Architecture and will be removed in a future release."
-  )
-  override fun canOverrideExistingModule(): Boolean = false
-
-  override fun invalidate() {
-    mHybridData.resetNative()
-  }
-
-  // Replace the current native module held by this wrapper by a new instance
-  protected fun resetModule(hd: HybridData) {
-    if (hd !== mHybridData) {
-      mHybridData.resetNative()
-      mHybridData = hd
-    }
-  }
-
-  private companion object {
-    init {
-      ReactNativeJNISoLoader.staticInit()
-      LegacyArchitectureLogger.assertLegacyArchitecture(
-          "CxxModuleWrapperBase",
-          LegacyArchitectureLogLevel.WARNING,
-      )
-    }
-  }
-}

package/ReactAndroid/src/main/jni/react/jni/CxxModuleWrapper.h

@@ -1,37 +0,0 @@
-/*
- * Copyright (c) Meta Platforms, Inc. and affiliates.
- *
- * This source code is licensed under the MIT license found in the
- * LICENSE file in the root directory of this source tree.
- */
-
-#pragma once
-
-#include "CxxModuleWrapperBase.h"
-
-namespace facebook::react {
-
-class CxxModuleWrapper : public jni::HybridClass<CxxModuleWrapper, CxxModuleWrapperBase> {
- public:
-  constexpr static const char *const kJavaDescriptor = "Lcom/facebook/react/bridge/CxxModuleWrapper;";
-
-  std::string getName() override
-  {
-    return module_->getName();
-  }
-
-  // This steals ownership of the underlying module for use by the C++ bridge
-  std::unique_ptr<xplat::module::CxxModule> getModule() override
-  {
-    return std::move(module_);
-  }
-
- protected:
-  friend HybridBase;
-
-  explicit CxxModuleWrapper(std::unique_ptr<xplat::module::CxxModule> module) : module_(std::move(module)) {}
-
-  std::unique_ptr<xplat::module::CxxModule> module_;
-};
-
-} // namespace facebook::react