react-native 0.84.0-nightly-20251106-de5141a3d → 0.84.0-nightly-20251107-f8198f662

package/ReactCommon/jsinspector-modern/RuntimeTargetConsole.cpp

@@ -5,6 +5,10 @@
  * LICENSE file in the root directory of this source tree.
  */
 
+#include "ConsoleTask.h"
+#include "ConsoleTaskContext.h"
+#include "ConsoleTaskOrchestrator.h"
+
 #include <jsinspector-modern/RuntimeTarget.h>
 #include <jsinspector-modern/tracing/PerformanceTracer.h>
 
@@ -477,8 +481,17 @@ void consoleTimeStamp(
   }
 
   if (performanceTracer.isTracing()) {
+    auto taskContext = ConsoleTaskOrchestrator::getInstance().top();
+
     performanceTracer.reportTimeStamp(
-        label, start, end, trackName, trackGroup, color, std::move(detail));
+        label,
+        start,
+        end,
+        trackName,
+        trackGroup,
+        color,
+        std::move(detail),
+        taskContext ? taskContext->getSerializedStackTrace() : nullptr);
   }
 
   if (ReactPerfettoLogger::isTracing()) {
@@ -521,6 +534,71 @@ void installConsoleTimeStamp(
               })));
 }
 
+/**
+ * run method of the task object returned from console.createTask().
+ */
+jsi::Value consoleTaskRun(
+    jsi::Runtime& runtime,
+    const jsi::Value* args,
+    size_t count,
+    std::shared_ptr<ConsoleTaskContext> taskContext) {
+  if (count < 1 || !args[0].isObject()) {
+    throw JSError(runtime, "First argument must be a function");
+  }
+  auto fnObj = args[0].getObject(runtime);
+  if (!fnObj.isFunction(runtime)) {
+    throw JSError(runtime, "First argument must be a function");
+  }
+
+  ConsoleTask consoleTask{taskContext};
+
+  auto fn = fnObj.getFunction(runtime);
+  return fn.call(runtime);
+}
+
+/**
+ * console.createTask. Non-standardized.
+ * https://developer.chrome.com/docs/devtools/console/api#createtask
+ */
+jsi::Value consoleCreateTask(
+    jsi::Runtime& runtime,
+    const jsi::Value* args,
+    size_t count,
+    RuntimeTargetDelegate& runtimeTargetDelegate,
+    bool enabled) {
+  if (count < 1 || !args[0].isString()) {
+    throw JSError(runtime, "First argument must be a non-empty string");
+  }
+  auto name = args[0].asString(runtime).utf8(runtime);
+  if (name.empty()) {
+    throw JSError(runtime, "First argument must be a non-empty string");
+  }
+
+  jsi::Object task{runtime};
+  std::shared_ptr<ConsoleTaskContext> taskContext = nullptr;
+  if (enabled) {
+    taskContext = std::make_shared<ConsoleTaskContext>(
+        runtime, runtimeTargetDelegate, name);
+    taskContext->schedule();
+  }
+
+  task.setProperty(
+      runtime,
+      "run",
+      jsi::Function::createFromHostFunction(
+          runtime,
+          jsi::PropNameID::forAscii(runtime, "run"),
+          0,
+          [taskContext](
+              jsi::Runtime& runtime,
+              const jsi::Value& /*thisVal*/,
+              const jsi::Value* args,
+              size_t count) {
+            return consoleTaskRun(runtime, args, count, taskContext);
+          }));
+  return task;
+}
+
 } // namespace
 
 void RuntimeTarget::installConsoleHandler() {
@@ -624,6 +702,33 @@ void RuntimeTarget::installConsoleHandler() {
      */
     installConsoleTimeStamp(runtime, originalConsole, console);
 
+    /**
+     * console.createTask
+     */
+    console.setProperty(
+        runtime,
+        "createTask",
+        jsi::Function::createFromHostFunction(
+            runtime,
+            jsi::PropNameID::forAscii(runtime, "createTask"),
+            0,
+            [state, selfWeak](
+                jsi::Runtime& runtime,
+                const jsi::Value& /*thisVal*/,
+                const jsi::Value* args,
+                size_t count) {
+              jsi::Value task;
+              tryExecuteSync(selfWeak, [&](auto& self) {
+                task = consoleCreateTask(
+                    runtime,
+                    args,
+                    count,
+                    self.delegate_,
+                    self.isConsoleCreateTaskEnabled());
+              });
+              return task;
+            }));
+
     // Install forwarding console methods.
 #define FORWARDING_CONSOLE_METHOD(name, type) \
   installConsoleMethod(#name, console_##name);

package/ReactCommon/jsinspector-modern/tests/ConsoleCreateTaskTest.cpp

@@ -0,0 +1,131 @@
+/*
+ * Copyright (c) Meta Platforms, Inc. and affiliates.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ */
+
+#include <folly/executors/QueuedImmediateExecutor.h>
+
+#include "JsiIntegrationTest.h"
+#include "engines/JsiIntegrationTestHermesEngineAdapter.h"
+
+#include <jsinspector-modern/ConsoleTaskOrchestrator.h>
+
+using namespace ::testing;
+
+namespace facebook::react::jsinspector_modern {
+
+/**
+ * A test fixture for the console.createTask API.
+ */
+class ConsoleCreateTaskTest : public JsiIntegrationPortableTestBase<
+                                  JsiIntegrationTestHermesEngineAdapter,
+                                  folly::QueuedImmediateExecutor> {};
+
+TEST_F(ConsoleCreateTaskTest, Installed) {
+  auto result = eval("typeof console.createTask");
+  auto& runtime = engineAdapter_->getRuntime();
+  EXPECT_EQ(result.asString(runtime).utf8(runtime), "function");
+}
+
+TEST_F(ConsoleCreateTaskTest, ReturnsTaskObject) {
+  auto result = eval("typeof console.createTask('test-task')");
+  auto& runtime = engineAdapter_->getRuntime();
+  EXPECT_EQ(result.asString(runtime).utf8(runtime), "object");
+}
+
+TEST_F(ConsoleCreateTaskTest, TaskObjectHasRunMethod) {
+  auto result = eval("typeof console.createTask('test-task').run");
+  auto& runtime = engineAdapter_->getRuntime();
+  EXPECT_EQ(result.asString(runtime).utf8(runtime), "function");
+}
+
+TEST_F(ConsoleCreateTaskTest, RunMethodExecutesFunction) {
+  auto result = eval(R"(
+    let executed = false;
+    const task = console.createTask('test-task');
+    task.run(() => { executed = true; });
+    executed;
+  )");
+  EXPECT_TRUE(result.getBool());
+}
+
+TEST_F(ConsoleCreateTaskTest, RunMethodReturnsValue) {
+  auto result = eval(R"(
+    const task = console.createTask('test-task');
+    task.run(() => 42);
+  )");
+  EXPECT_EQ(result.getNumber(), 42);
+}
+
+TEST_F(ConsoleCreateTaskTest, ThrowsOnNoArguments) {
+  EXPECT_THROW(eval("console.createTask()"), facebook::jsi::JSError);
+}
+
+TEST_F(ConsoleCreateTaskTest, ThrowsOnEmptyString) {
+  EXPECT_THROW(eval("console.createTask('')"), facebook::jsi::JSError);
+}
+
+TEST_F(ConsoleCreateTaskTest, ThrowsOnNonStringArgument) {
+  EXPECT_THROW(eval("console.createTask(123)"), facebook::jsi::JSError);
+  EXPECT_THROW(eval("console.createTask(null)"), facebook::jsi::JSError);
+  EXPECT_THROW(eval("console.createTask(undefined)"), facebook::jsi::JSError);
+  EXPECT_THROW(eval("console.createTask({})"), facebook::jsi::JSError);
+}
+
+TEST_F(ConsoleCreateTaskTest, RunMethodThrowsOnNoArguments) {
+  EXPECT_THROW(
+      eval(R"(
+    const task = console.createTask('test-task');
+    task.run();
+  )"),
+      facebook::jsi::JSError);
+}
+
+TEST_F(ConsoleCreateTaskTest, RunMethodThrowsOnNonFunction) {
+  EXPECT_THROW(
+      eval(R"(
+    const task = console.createTask('test-task');
+    task.run(123);
+  )"),
+      facebook::jsi::JSError);
+  EXPECT_THROW(
+      eval(R"(
+    const task = console.createTask('test-task');
+    task.run('not a function');
+  )"),
+      facebook::jsi::JSError);
+  EXPECT_THROW(
+      eval(R"(
+    const task = console.createTask('test-task');
+    task.run({});
+  )"),
+      facebook::jsi::JSError);
+}
+
+TEST_F(ConsoleCreateTaskTest, MultipleTasksCanBeCreated) {
+  auto result = eval(R"(
+    const task1 = console.createTask('task-1');
+    const task2 = console.createTask('task-2');
+    let count = 0;
+    task1.run(() => { count++; });
+    task2.run(() => { count++; });
+    count;
+  )");
+  EXPECT_EQ(result.getNumber(), 2);
+}
+
+TEST_F(ConsoleCreateTaskTest, TaskCanBeRunMultipleTimes) {
+  auto result = eval(R"(
+    const task = console.createTask('test-task');
+    let count = 0;
+    task.run(() => { count++; });
+    task.run(() => { count++; });
+    task.run(() => { count++; });
+    count;
+  )");
+  EXPECT_EQ(result.getNumber(), 3);
+}
+
+} // namespace facebook::react::jsinspector_modern

package/ReactCommon/jsinspector-modern/tests/ReactInstanceIntegrationTest.cpp

@@ -14,6 +14,7 @@
 #include <glog/logging.h>
 #include <jsinspector-modern/InspectorFlags.h>
 #include <react/featureflags/ReactNativeFeatureFlags.h>
+#include <react/runtime/JSRuntimeBindings.h>
 #include <react/runtime/hermes/HermesInstance.h>
 
 using namespace ::testing;

package/ReactCommon/jsinspector-modern/tracing/PerformanceTracer.cpp

@@ -187,7 +187,8 @@ void PerformanceTracer::reportMeasure(
     const std::string& name,
     HighResTimeStamp start,
     HighResDuration duration,
-    folly::dynamic&& detail) {
+    folly::dynamic&& detail,
+    std::optional<folly::dynamic> stackTrace) {
   if (!tracingAtomic_) {
     return;
   }
@@ -204,6 +205,7 @@ void PerformanceTracer::reportMeasure(
           .duration = duration,
           .detail = std::move(detail),
           .threadId = getCurrentThreadId(),
+          .stackTrace = std::move(stackTrace),
       });
 }
 
@@ -214,7 +216,8 @@ void PerformanceTracer::reportTimeStamp(
     std::optional<std::string> trackName,
     std::optional<std::string> trackGroup,
     std::optional<ConsoleTimeStampColor> color,
-    std::optional<folly::dynamic> detail) {
+    std::optional<folly::dynamic> detail,
+    std::optional<folly::dynamic> stackTrace) {
   if (!tracingAtomic_) {
     return;
   }
@@ -233,6 +236,7 @@ void PerformanceTracer::reportTimeStamp(
           .trackGroup = std::move(trackGroup),
           .color = std::move(color),
           .detail = std::move(detail),
+          .stackTrace = std::move(stackTrace),
           .threadId = getCurrentThreadId(),
       });
 }
@@ -606,6 +610,10 @@ void PerformanceTracer::enqueueTraceEventsFromPerformanceTracerEvent(
               beginEventArgs =
                   folly::dynamic::object("detail", folly::toJson(event.detail));
             }
+            if (event.stackTrace) {
+              beginEventArgs["data"] = folly::dynamic::object(
+                  "rnStackTrace", std::move(*event.stackTrace));
+            }
 
             auto eventId = ++performanceMeasureCount_;
 
@@ -695,6 +703,9 @@ void PerformanceTracer::enqueueTraceEventsFromPerformanceTracerEvent(
               }
               data["devtools"] = folly::toJson(devtoolsDetail);
             }
+            if (event.stackTrace) {
+              data["rnStackTrace"] = std::move(*event.stackTrace);
+            }
 
             events.emplace_back(
                 TraceEvent{

package/ReactCommon/jsinspector-modern/tracing/PerformanceTracer.h

@@ -81,7 +81,8 @@ class PerformanceTracer {
       const std::string &name,
       HighResTimeStamp start,
       HighResDuration duration,
-      folly::dynamic &&detail = nullptr);
+      folly::dynamic &&detail = nullptr,
+      std::optional<folly::dynamic> stackTrace = nullptr);
 
   /**
    * Record a "TimeStamp" Trace Event - a labelled entry on Performance
@@ -97,7 +98,8 @@ class PerformanceTracer {
       std::optional<std::string> trackName = std::nullopt,
       std::optional<std::string> trackGroup = std::nullopt,
       std::optional<ConsoleTimeStampColor> color = std::nullopt,
-      std::optional<folly::dynamic> detail = std::nullopt);
+      std::optional<folly::dynamic> detail = std::nullopt,
+      std::optional<folly::dynamic> stackTrace = std::nullopt);
 
   /**
    * Record an Event Loop tick, which will be represented as an Event Loop task
@@ -256,6 +258,7 @@ class PerformanceTracer {
     HighResDuration duration;
     folly::dynamic detail;
     ThreadId threadId;
+    std::optional<folly::dynamic> stackTrace;
     HighResTimeStamp createdAt = HighResTimeStamp::now();
   };
 
@@ -267,6 +270,7 @@ class PerformanceTracer {
     std::optional<std::string> trackGroup;
     std::optional<ConsoleTimeStampColor> color;
     std::optional<folly::dynamic> detail;
+    std::optional<folly::dynamic> stackTrace;
     ThreadId threadId;
     HighResTimeStamp createdAt = HighResTimeStamp::now();
   };

package/ReactCommon/jsinspector-modern/tracing/TargetTracingAgent.h

@@ -27,6 +27,11 @@ class TargetTracingAgent {
     (void)state_;
   }
 
+  bool isRunningInBackgroundMode()
+  {
+    return state_.mode == tracing::Mode::Background;
+  }
+
  protected:
   TraceRecordingState &state_;
 };

package/ReactCommon/jsitooling/react/runtime/JSRuntimeBindings.cpp

@@ -0,0 +1,54 @@
+/*
+ * Copyright (c) Meta Platforms, Inc. and affiliates.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ */
+
+#include "JSRuntimeBindings.h"
+
+#include <react/timing/primitives.h>
+
+namespace facebook::react {
+
+void bindNativeLogger(jsi::Runtime& runtime, Logger logger) {
+  runtime.global().setProperty(
+      runtime,
+      "nativeLoggingHook",
+      jsi::Function::createFromHostFunction(
+          runtime,
+          jsi::PropNameID::forAscii(runtime, "nativeLoggingHook"),
+          2,
+          [logger = std::move(logger)](
+              jsi::Runtime& runtime,
+              const jsi::Value& /* this */,
+              const jsi::Value* args,
+              size_t count) {
+            if (count != 2) {
+              throw std::invalid_argument(
+                  "nativeLoggingHook takes 2 arguments");
+            }
+            logger(
+                args[0].asString(runtime).utf8(runtime),
+                static_cast<unsigned int>(args[1].asNumber()));
+            return jsi::Value::undefined();
+          }));
+}
+
+void bindNativePerformanceNow(jsi::Runtime& runtime) {
+  runtime.global().setProperty(
+      runtime,
+      "nativePerformanceNow",
+      jsi::Function::createFromHostFunction(
+          runtime,
+          jsi::PropNameID::forAscii(runtime, "nativePerformanceNow"),
+          0,
+          [](jsi::Runtime& /* runtime */,
+             const jsi::Value& /* this */,
+             const jsi::Value* /* args */,
+             size_t /*count*/) {
+            return HighResTimeStamp::now().toDOMHighResTimeStamp();
+          }));
+}
+
+} // namespace facebook::react

package/ReactCommon/jsitooling/react/runtime/JSRuntimeBindings.h

@@ -0,0 +1,20 @@
+/*
+ * Copyright (c) Meta Platforms, Inc. and affiliates.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ */
+
+#pragma once
+
+#include <jsi/jsi.h>
+#include <string>
+
+namespace facebook::react {
+
+using Logger = std::function<void(const std::string &message, unsigned int logLevel)>;
+void bindNativeLogger(jsi::Runtime &runtime, Logger logger);
+
+void bindNativePerformanceNow(jsi::Runtime &runtime);
+
+} // namespace facebook::react

package/ReactCommon/react/nativemodule/samples/platform/ios/ReactCommon/RCTSampleTurboModule.mm

@@ -24,10 +24,7 @@ using namespace facebook::react;
 }
 
 // Backward-compatible export
-+ (NSString *)moduleName
-{
-  return @"SampleTurboModule";
-}
+RCT_EXPORT_MODULE()
 
 // Backward-compatible queue configuration
 + (BOOL)requiresMainQueueSetup

package/ReactCommon/react/performance/timeline/CMakeLists.txt

@@ -16,6 +16,7 @@ target_compile_options(react_performance_timeline PRIVATE -Wpedantic)
 
 target_include_directories(react_performance_timeline PUBLIC ${REACT_COMMON_DIR})
 target_link_libraries(react_performance_timeline
+        jsinspector
         jsinspector_tracing
         reactperflogger
         react_featureflags

package/ReactCommon/react/performance/timeline/PerformanceEntryReporter.cpp

@@ -7,6 +7,7 @@
 
 #include "PerformanceEntryReporter.h"
 
+#include <jsinspector-modern/ConsoleTaskOrchestrator.h>
 #include <jsinspector-modern/tracing/PerformanceTracer.h>
 #include <react/featureflags/ReactNativeFeatureFlags.h>
 #include <react/timing/primitives.h>
@@ -381,8 +382,15 @@ void PerformanceEntryReporter::traceMeasure(
     }
 
     if (performanceTracer.isTracing()) {
+      auto taskContext =
+          jsinspector_modern::ConsoleTaskOrchestrator::getInstance().top();
+
       performanceTracer.reportMeasure(
-          entry.name, entry.startTime, entry.duration, std::move(detail));
+          entry.name,
+          entry.startTime,
+          entry.duration,
+          std::move(detail),
+          taskContext ? taskContext->getSerializedStackTrace() : nullptr);
     }
   }
 }

package/ReactCommon/react/performance/timeline/React-performancetimeline.podspec

@@ -41,6 +41,7 @@ Pod::Spec.new do |s|
   resolve_use_frameworks(s, header_mappings_dir: "../../..", module_name: "React_performancetimeline")
 
   s.dependency "React-featureflags"
+  add_dependency(s, "React-jsinspector", :framework_name => 'jsinspector_modern')
   add_dependency(s, "React-jsinspectortracing", :framework_name => 'jsinspector_moderntracing')
   s.dependency "React-timing"
   s.dependency "React-perflogger"

package/ReactCommon/react/renderer/animated/NativeAnimatedNodesManager.cpp

@@ -519,6 +519,17 @@ NativeAnimatedNodesManager::ensureEventEmitterListener() noexcept {
 }
 
 void NativeAnimatedNodesManager::startRenderCallbackIfNeeded(bool isAsync) {
+  // This method can be called from either the UI thread or JavaScript thread.
+  // It ensures `startOnRenderCallback_` is called exactly once using atomic
+  // operations. We use std::atomic_bool rather than std::mutex to avoid
+  // potential deadlocks that could occur if we called external code while
+  // holding a mutex.
+  auto isRenderCallbackStarted = isRenderCallbackStarted_.exchange(true);
+  if (isRenderCallbackStarted) {
+    // onRender callback is already started.
+    return;
+  }
+
   if (ReactNativeFeatureFlags::useSharedAnimatedBackend()) {
 #ifdef RN_USE_ANIMATION_BACKEND
     if (auto animationBackend = animationBackend_.lock()) {
@@ -531,16 +542,6 @@ void NativeAnimatedNodesManager::startRenderCallbackIfNeeded(bool isAsync) {
 
     return;
   }
-  // This method can be called from either the UI thread or JavaScript thread.
-  // It ensures `startOnRenderCallback_` is called exactly once using atomic
-  // operations. We use std::atomic_bool rather than std::mutex to avoid
-  // potential deadlocks that could occur if we called external code while
-  // holding a mutex.
-  auto isRenderCallbackStarted = isRenderCallbackStarted_.exchange(true);
-  if (isRenderCallbackStarted) {
-    // onRender callback is already started.
-    return;
-  }
 
   if (startOnRenderCallback_) {
     startOnRenderCallback_([this]() { onRender(); }, isAsync);
@@ -549,18 +550,21 @@ void NativeAnimatedNodesManager::startRenderCallbackIfNeeded(bool isAsync) {
 
 void NativeAnimatedNodesManager::stopRenderCallbackIfNeeded(
     bool isAsync) noexcept {
-  if (ReactNativeFeatureFlags::useSharedAnimatedBackend()) {
-    if (auto animationBackend = animationBackend_.lock()) {
-      animationBackend->stop(isAsync);
-    }
-    return;
-  }
   // When multiple threads reach this point, only one thread should call
   // stopOnRenderCallback_. This synchronization is primarily needed during
   // destruction of NativeAnimatedNodesManager. In normal operation,
   // stopRenderCallbackIfNeeded is always called from the UI thread.
   auto isRenderCallbackStarted = isRenderCallbackStarted_.exchange(false);
 
+  if (ReactNativeFeatureFlags::useSharedAnimatedBackend()) {
+    if (isRenderCallbackStarted) {
+      if (auto animationBackend = animationBackend_.lock()) {
+        animationBackend->stop(isAsync);
+      }
+    }
+    return;
+  }
+
   if (isRenderCallbackStarted) {
     if (stopOnRenderCallback_) {
       stopOnRenderCallback_(isAsync);
@@ -988,6 +992,7 @@ AnimationMutations NativeAnimatedNodesManager::pullAnimationMutations() {
             AnimationMutation{tag, nullptr, propsBuilder.get()});
         containsChange = true;
       }
+      updateViewPropsDirect_.clear();
     }
 
     if (!containsChange) {

package/ReactCommon/react/renderer/animated/NativeAnimatedNodesManagerProvider.cpp

@@ -80,12 +80,16 @@ NativeAnimatedNodesManagerProvider::getOrCreate(
           std::move(directManipulationCallback),
           std::move(fabricCommitCallback),
           uiManager);
-#endif
 
       nativeAnimatedNodesManager_ =
           std::make_shared<NativeAnimatedNodesManager>(animationBackend_);
 
+      nativeAnimatedDelegate_ =
+          std::make_shared<UIManagerNativeAnimatedDelegateBackendImpl>(
+              animationBackend_);
+
       uiManager->unstable_setAnimationBackend(animationBackend_);
+#endif
     } else {
       nativeAnimatedNodesManager_ =
           std::make_shared<NativeAnimatedNodesManager>(
@@ -93,6 +97,10 @@ NativeAnimatedNodesManagerProvider::getOrCreate(
               std::move(fabricCommitCallback),
               std::move(startOnRenderCallback_),
               std::move(stopOnRenderCallback_));
+
+      nativeAnimatedDelegate_ =
+          std::make_shared<UIManagerNativeAnimatedDelegateImpl>(
+              nativeAnimatedNodesManager_);
     }
 
     addEventEmitterListener(
@@ -117,10 +125,6 @@ NativeAnimatedNodesManagerProvider::getOrCreate(
               return false;
             }));
 
-    nativeAnimatedDelegate_ =
-        std::make_shared<UIManagerNativeAnimatedDelegateImpl>(
-            nativeAnimatedNodesManager_);
-
     uiManager->setNativeAnimatedDelegate(nativeAnimatedDelegate_);
 
     // TODO: remove force casting.