react-native 0.0.0-263478b91 → 0.0.0-268efb102

package/React/Fabric/Mounting/ComponentViews/Picker/RCTPickerComponentView.mm

@@ -1,206 +0,0 @@
-/*
- * Copyright (c) Facebook, Inc. and its affiliates.
- *
- * This source code is licensed under the MIT license found in the
- * LICENSE file in the root directory of this source tree.
- */
-
-#import "RCTPickerComponentView.h"
-
-#import <React/RCTConvert.h>
-#import <React/RCTLog.h>
-#import <UIKit/UIKit.h>
-#import <react/renderer/components/iospicker/PickerComponentDescriptor.h>
-#import <react/renderer/components/iospicker/PickerEventEmitter.h>
-#import <react/renderer/components/iospicker/PickerProps.h>
-#import <react/renderer/textlayoutmanager/RCTAttributedTextUtils.h>
-
-#import "RCTConversions.h"
-#import "RCTFabricComponentsPlugins.h"
-
-using namespace facebook::react;
-
-@interface RCTPickerComponentView () <UIPickerViewAccessibilityDelegate, UIPickerViewDelegate, UIPickerViewDataSource>
-
-@end
-
-@implementation RCTPickerComponentView {
-  UIPickerView *_pickerView;
-  std::vector<PickerItemsStruct> _items;
-  NSInteger _selectedIndex;
-  NSString *_accessibilityLabel;
-  NSDictionary<NSAttributedStringKey, id> *_textAttributes;
-}
-
-- (instancetype)initWithFrame:(CGRect)frame
-{
-  if (self = [super initWithFrame:frame]) {
-    _pickerView = [[UIPickerView alloc] initWithFrame:self.bounds];
-    self.contentView = _pickerView;
-    [self setPropsToDefault];
-  }
-
-  return self;
-}
-
-- (void)setPropsToDefault
-{
-  static const auto defaultProps = std::make_shared<const PickerProps>();
-  _props = defaultProps;
-  _pickerView.delegate = self;
-  _pickerView.dataSource = self;
-  _selectedIndex = NSNotFound;
-  NSMutableParagraphStyle *const paragraphStyle = [NSMutableParagraphStyle new];
-  paragraphStyle.alignment = NSTextAlignmentCenter;
-  _textAttributes = @{
-    NSForegroundColorAttributeName : [UIColor blackColor],
-    NSFontAttributeName : [UIFont systemFontOfSize:21],
-    NSParagraphStyleAttributeName : paragraphStyle
-  };
-}
-
-- (void)prepareForRecycle
-{
-  [super prepareForRecycle];
-  _selectedIndex = NSNotFound;
-}
-
-#pragma mark - RCTComponentViewProtocol
-
-+ (ComponentDescriptorProvider)componentDescriptorProvider
-{
-  return concreteComponentDescriptorProvider<PickerComponentDescriptor>();
-}
-
-- (void)updateProps:(Props::Shared const &)props oldProps:(Props::Shared const &)oldProps
-{
-  const auto &oldPickerProps = *std::static_pointer_cast<const PickerProps>(_props);
-  const auto &newPickerProps = *std::static_pointer_cast<const PickerProps>(props);
-  bool needsToReload = false;
-
-  if (oldPickerProps.items != newPickerProps.items) {
-    _items = newPickerProps.items;
-    needsToReload = true;
-  }
-
-  if (oldPickerProps.selectedIndex != newPickerProps.selectedIndex) {
-    _selectedIndex = newPickerProps.selectedIndex;
-    [self setSelectedIndex];
-  }
-
-  if (oldPickerProps.textAttributes != newPickerProps.textAttributes) {
-    _textAttributes = RCTNSTextAttributesFromTextAttributes(newPickerProps.getEffectiveTextAttributes());
-    needsToReload = true;
-  }
-
-  // TODO (T75217510) - Figure out testID.
-  if (oldPickerProps.testID != newPickerProps.testID) {
-  }
-
-  if (oldPickerProps.accessibilityLabel != newPickerProps.accessibilityLabel) {
-    _accessibilityLabel = [NSString stringWithUTF8String:newPickerProps.accessibilityLabel.c_str()];
-  }
-
-  if (needsToReload) {
-    [_pickerView reloadAllComponents];
-  }
-
-  [super updateProps:props oldProps:oldProps];
-}
-
-#pragma mark - Native Commands
-
-- (void)handleCommand:(const NSString *)commandName args:(const NSArray *)args
-{
-  if ([commandName isEqualToString:@"setNativeSelectedIndex"] && [args objectAtIndex:0]) {
-    NSNumber *selectedIndex = [args objectAtIndex:0];
-    if (_selectedIndex != selectedIndex.integerValue) {
-      [self setSelectedIndex];
-    }
-  } else {
-    RCTLogWarn(@"Attempting to send unknown command to Picker component: %@", commandName);
-  }
-}
-
-- (void)setSelectedIndex
-{
-  BOOL animated = _selectedIndex != NSNotFound; // Don't animate the initial value.
-  [_pickerView selectRow:_selectedIndex inComponent:0 animated:animated];
-}
-
-#pragma mark - UIPickerViewDataSource protocol
-
-- (NSInteger)numberOfComponentsInPickerView:(__unused UIPickerView *)pickerView
-{
-  return 1;
-}
-
-- (NSInteger)pickerView:(__unused UIPickerView *)pickerView numberOfRowsInComponent:(__unused NSInteger)component
-{
-  return _items.size();
-}
-
-#pragma mark - UIPickerViewDelegate methods
-
-- (NSString *)pickerView:(__unused UIPickerView *)pickerView
-             titleForRow:(NSInteger)row
-            forComponent:(__unused NSInteger)component
-{
-  return [NSString stringWithUTF8String:_items[row].label.c_str()];
-}
-
-- (CGFloat)pickerView:(__unused UIPickerView *)pickerView rowHeightForComponent:(NSInteger)__unused component
-{
-  return ((UIFont *)_textAttributes[NSFontAttributeName]).pointSize + 19;
-}
-
-- (UIView *)pickerView:(UIPickerView *)pickerView
-            viewForRow:(NSInteger)row
-          forComponent:(NSInteger)component
-           reusingView:(UILabel *)label
-{
-  if (!label) {
-    label = [[UILabel alloc] initWithFrame:(CGRect){
-                                               CGPointZero,
-                                               {
-                                                   [pickerView rowSizeForComponent:component].width,
-                                                   [pickerView rowSizeForComponent:component].height,
-                                               }}];
-  }
-  NSMutableDictionary<NSAttributedStringKey, id> *attributes = [_textAttributes mutableCopy];
-  // Color can be passed in from <Picker style={}/> or from <Picker.Item color={}/>
-  // If Picker.Item color is set, use that. Else fall back to Picker style (with black as default).
-  if (RCTUIColorFromSharedColor(_items[row].textColor)) {
-    attributes[NSForegroundColorAttributeName] = RCTUIColorFromSharedColor(_items[row].textColor);
-  }
-  label.attributedText = [[NSAttributedString alloc] initWithString:[self pickerView:pickerView
-                                                                         titleForRow:row
-                                                                        forComponent:component]
-                                                         attributes:attributes];
-  return label;
-}
-
-- (void)pickerView:(__unused UIPickerView *)pickerView
-      didSelectRow:(NSInteger)row
-       inComponent:(__unused NSInteger)component
-{
-  _selectedIndex = row;
-  PickerEventEmitter::PickerIOSChangeEvent event = {.newValue = _items[row].value, .newIndex = (int)row};
-  if (_eventEmitter) {
-    std::static_pointer_cast<PickerEventEmitter const>(_eventEmitter)->onChange(event);
-  }
-}
-
-#pragma mark - UIPickerViewAccessibilityDelegate protocol
-
-- (NSString *)pickerView:(UIPickerView *)pickerView accessibilityLabelForComponent:(NSInteger)component
-{
-  return _accessibilityLabel;
-}
-
-@end
-
-Class<RCTComponentViewProtocol> RCTPickerCls(void)
-{
-  return RCTPickerComponentView.class;
-}

package/React/Views/RCTPicker.h

@@ -1,23 +0,0 @@
-/*
- * Copyright (c) Facebook, Inc. and its affiliates.
- *
- * This source code is licensed under the MIT license found in the
- * LICENSE file in the root directory of this source tree.
- */
-
-#import <UIKit/UIKit.h>
-
-#import <React/UIView+React.h>
-
-@interface RCTPicker : UIPickerView
-
-@property (nonatomic, copy) NSArray<NSDictionary *> *items;
-@property (nonatomic, assign) NSInteger selectedIndex;
-
-@property (nonatomic, strong) UIColor *color;
-@property (nonatomic, strong) UIFont *font;
-@property (nonatomic, assign) NSTextAlignment textAlign;
-
-@property (nonatomic, copy) RCTBubblingEventBlock onChange;
-
-@end

package/React/Views/RCTPicker.m

@@ -1,122 +0,0 @@
-/*
- * Copyright (c) Facebook, Inc. and its affiliates.
- *
- * This source code is licensed under the MIT license found in the
- * LICENSE file in the root directory of this source tree.
- */
-
-#import "RCTPicker.h"
-
-#import "RCTConvert.h"
-#import "RCTUtils.h"
-
-@interface RCTPicker () <UIPickerViewDataSource, UIPickerViewDelegate, UIPickerViewAccessibilityDelegate>
-@end
-
-@implementation RCTPicker
-
-- (instancetype)initWithFrame:(CGRect)frame
-{
-  if ((self = [super initWithFrame:frame])) {
-    _color = [UIColor blackColor];
-    _font = [UIFont systemFontOfSize:21]; // TODO: selected title default should be 23.5
-    _selectedIndex = NSNotFound;
-    _textAlign = NSTextAlignmentCenter;
-    self.delegate = self;
-    [self selectRow:0 inComponent:0
-           animated:
-               YES]; // Workaround for missing selection indicator lines (see
-                     // https://stackoverflow.com/questions/39564660/uipickerview-selection-indicator-not-visible-in-ios10)
-  }
-  return self;
-}
-
-RCT_NOT_IMPLEMENTED(-(instancetype)initWithCoder : (NSCoder *)aDecoder)
-
-- (void)setItems:(NSArray<NSDictionary *> *)items
-{
-  _items = [items copy];
-  [self setNeedsLayout];
-}
-
-- (void)setSelectedIndex:(NSInteger)selectedIndex
-{
-  if (_selectedIndex != selectedIndex) {
-    BOOL animated = _selectedIndex != NSNotFound; // Don't animate the initial value
-    _selectedIndex = selectedIndex;
-    dispatch_async(dispatch_get_main_queue(), ^{
-      [self selectRow:selectedIndex inComponent:0 animated:animated];
-    });
-  }
-}
-
-#pragma mark - UIPickerViewDataSource protocol
-
-- (NSInteger)numberOfComponentsInPickerView:(__unused UIPickerView *)pickerView
-{
-  return 1;
-}
-
-- (NSInteger)pickerView:(__unused UIPickerView *)pickerView numberOfRowsInComponent:(__unused NSInteger)component
-{
-  return _items.count;
-}
-
-#pragma mark - UIPickerViewDelegate methods
-
-- (NSString *)pickerView:(__unused UIPickerView *)pickerView
-             titleForRow:(NSInteger)row
-            forComponent:(__unused NSInteger)component
-{
-  return [RCTConvert NSString:_items[row][@"label"]];
-}
-
-- (CGFloat)pickerView:(__unused UIPickerView *)pickerView rowHeightForComponent:(NSInteger)__unused component
-{
-  return _font.pointSize + 19;
-}
-
-- (UIView *)pickerView:(UIPickerView *)pickerView
-            viewForRow:(NSInteger)row
-          forComponent:(NSInteger)component
-           reusingView:(UILabel *)label
-{
-  if (!label) {
-    label = [[UILabel alloc] initWithFrame:(CGRect){
-                                               CGPointZero,
-                                               {
-                                                   [pickerView rowSizeForComponent:component].width,
-                                                   [pickerView rowSizeForComponent:component].height,
-                                               }}];
-  }
-
-  label.font = _font;
-
-  label.textColor = [RCTConvert UIColor:_items[row][@"textColor"]] ?: _color;
-
-  label.textAlignment = _textAlign;
-  label.text = [self pickerView:pickerView titleForRow:row forComponent:component];
-  return label;
-}
-
-- (void)pickerView:(__unused UIPickerView *)pickerView
-      didSelectRow:(NSInteger)row
-       inComponent:(__unused NSInteger)component
-{
-  _selectedIndex = row;
-  if (_onChange && _items.count > (NSUInteger)row) {
-    _onChange(@{
-      @"newIndex" : @(row),
-      @"newValue" : RCTNullIfNil(_items[row][@"value"]),
-    });
-  }
-}
-
-#pragma mark - UIPickerViewAccessibilityDelegate protocol
-
-- (NSString *)pickerView:(UIPickerView *)pickerView accessibilityLabelForComponent:(NSInteger)component
-{
-  return super.accessibilityLabel;
-}
-
-@end

package/React/Views/RCTPickerManager.m

@@ -1,59 +0,0 @@
-/*
- * Copyright (c) Facebook, Inc. and its affiliates.
- *
- * This source code is licensed under the MIT license found in the
- * LICENSE file in the root directory of this source tree.
- */
-
-#import "RCTPickerManager.h"
-
-#import <React/RCTUIManager.h>
-#import "RCTBridge.h"
-#import "RCTFont.h"
-#import "RCTPicker.h"
-
-@implementation RCTPickerManager
-
-RCT_EXPORT_MODULE()
-
-- (UIView *)view
-{
-  return [RCTPicker new];
-}
-
-RCT_EXPORT_VIEW_PROPERTY(items, NSArray<NSDictionary *>)
-RCT_EXPORT_VIEW_PROPERTY(selectedIndex, NSInteger)
-RCT_REMAP_VIEW_PROPERTY(accessibilityLabel, reactAccessibilityElement.accessibilityLabel, NSString)
-RCT_EXPORT_VIEW_PROPERTY(onChange, RCTBubblingEventBlock)
-RCT_EXPORT_VIEW_PROPERTY(color, UIColor)
-RCT_EXPORT_VIEW_PROPERTY(textAlign, NSTextAlignment)
-RCT_CUSTOM_VIEW_PROPERTY(fontSize, NSNumber, RCTPicker)
-{
-  view.font = [RCTFont updateFont:view.font withSize:json ?: @(defaultView.font.pointSize)];
-}
-RCT_CUSTOM_VIEW_PROPERTY(fontWeight, NSString, __unused RCTPicker)
-{
-  view.font = [RCTFont updateFont:view.font withWeight:json]; // defaults to normal
-}
-RCT_CUSTOM_VIEW_PROPERTY(fontStyle, NSString, __unused RCTPicker)
-{
-  view.font = [RCTFont updateFont:view.font withStyle:json]; // defaults to normal
-}
-RCT_CUSTOM_VIEW_PROPERTY(fontFamily, NSString, RCTPicker)
-{
-  view.font = [RCTFont updateFont:view.font withFamily:json ?: defaultView.font.familyName];
-}
-
-RCT_EXPORT_METHOD(setNativeSelectedIndex : (nonnull NSNumber *)viewTag toIndex : (nonnull NSNumber *)index)
-{
-  [self.bridge.uiManager addUIBlock:^(RCTUIManager *uiManager, NSDictionary<NSNumber *, UIView *> *viewRegistry) {
-    UIView *view = viewRegistry[viewTag];
-    if ([view isKindOfClass:[RCTPicker class]]) {
-      [(RCTPicker *)view setSelectedIndex:index.integerValue];
-    } else {
-      RCTLogError(@"View type must be RCTPicker!");
-    }
-  }];
-}
-
-@end

package/ReactAndroid/release.gradle

@@ -1,87 +0,0 @@
-/*
- * Copyright (c) Facebook, Inc. and its affiliates.
- *
- * This source code is licensed under the MIT license found in the
- * LICENSE file in the root directory of this source tree.
- */
-
-apply(plugin: "maven")
-apply(plugin: "signing")
-
-ext {
-    AAR_OUTPUT_URL = "file://${projectDir}/../android"
-}
-
-// Gradle tasks for publishing to maven
-// 1) To install in local maven repo use :installArchives task
-// 2) To upload artifact to maven central use: :uploadArchives (you'd need to have the permission to do that)
-
-def isReleaseBuild() {
-    return VERSION_NAME.contains("SNAPSHOT") == false
-}
-
-def configureReactNativePom(def pom) {
-    pom.project {
-        name(POM_NAME)
-        artifactId(POM_ARTIFACT_ID)
-        packaging(POM_PACKAGING)
-        description("A framework for building native apps with React")
-        url("https://github.com/facebook/react-native")
-
-        scm {
-            url("https://github.com/facebook/react-native.git")
-            connection("scm:git:https://github.com/facebook/react-native.git")
-            developerConnection("scm:git:git@github.com:facebook/react-native.git")
-        }
-
-        licenses {
-            license {
-                name("MIT License")
-                url("https://github.com/facebook/react-native/blob/master/LICENSE")
-                distribution("repo")
-            }
-        }
-
-        developers {
-            developer {
-                id("facebook")
-                name("Facebook")
-            }
-        }
-    }
-}
-
-if (JavaVersion.current().isJava8Compatible()) {
-    allprojects {
-        tasks.withType(Javadoc) {
-            options.addStringOption("Xdoclint:none", "-quiet")
-        }
-    }
-}
-
-afterEvaluate { project ->
-    android.libraryVariants.all { variant ->
-        def name = variant.name.capitalize()
-        task "jar${name}"(type: Jar, dependsOn: variant.javaCompileProvider.get()) {
-            from(variant.javaCompileProvider.get().destinationDir)
-        }
-    }
-
-    version = VERSION_NAME
-    group = GROUP
-
-    signing {
-        required { isReleaseBuild() && gradle.taskGraph.hasTask("uploadArchives") }
-        sign(configurations.archives)
-    }
-
-    task installArchives(type: Upload) {
-        configuration = configurations.archives
-        repositories.mavenDeployer {
-            // Deploy to react-native/android, ready to publish to npm
-            repository(url: AAR_OUTPUT_URL)
-
-            configureReactNativePom(pom)
-        }
-    }
-}

package/ReactAndroid/src/androidTest/java/com/facebook/react/tests/DatePickerDialogTestCase.java

@@ -1,172 +0,0 @@
-/*
- * Copyright (c) Facebook, Inc. and its affiliates.
- *
- * This source code is licensed under the MIT license found in the
- * LICENSE file in the root directory of this source tree.
- */
-
-package com.facebook.react.tests;
-
-import android.app.DatePickerDialog;
-import android.content.DialogInterface;
-import android.widget.DatePicker;
-import androidx.fragment.app.DialogFragment;
-import androidx.fragment.app.Fragment;
-import com.facebook.react.bridge.BaseJavaModule;
-import com.facebook.react.bridge.JavaScriptModule;
-import com.facebook.react.bridge.ReactMethod;
-import com.facebook.react.bridge.WritableMap;
-import com.facebook.react.bridge.WritableNativeMap;
-import com.facebook.react.modules.datepicker.DatePickerDialogModule;
-import com.facebook.react.testing.ReactAppInstrumentationTestCase;
-import com.facebook.react.testing.ReactInstanceSpecForTest;
-import java.util.ArrayList;
-import java.util.Calendar;
-import java.util.List;
-
-/** Test case for {@link DatePickerDialogModule} options and callbacks. */
-public class DatePickerDialogTestCase extends ReactAppInstrumentationTestCase {
-
-  private static interface DatePickerDialogTestModule extends JavaScriptModule {
-    public void showDatePickerDialog(WritableMap options);
-  }
-
-  private static class DatePickerDialogRecordingModule extends BaseJavaModule {
-
-    private final List<Integer[]> mDates = new ArrayList<Integer[]>();
-    private int mDismissed = 0;
-    private int mErrors = 0;
-
-    @Override
-    public String getName() {
-      return "DatePickerDialogRecordingModule";
-    }
-
-    @ReactMethod
-    public void recordDate(int year, int month, int day) {
-      mDates.add(new Integer[] {year, month, day});
-    }
-
-    @ReactMethod
-    public void recordDismissed() {
-      mDismissed++;
-    }
-
-    @ReactMethod
-    public void recordError() {
-      mErrors++;
-    }
-
-    public List<Integer[]> getDates() {
-      return new ArrayList<Integer[]>(mDates);
-    }
-
-    public int getDismissed() {
-      return mDismissed;
-    }
-
-    public int getErrors() {
-      return mErrors;
-    }
-  }
-
-  final DatePickerDialogRecordingModule mRecordingModule = new DatePickerDialogRecordingModule();
-
-  @Override
-  protected ReactInstanceSpecForTest createReactInstanceSpecForTest() {
-    return super.createReactInstanceSpecForTest().addNativeModule(mRecordingModule);
-  }
-
-  @Override
-  protected String getReactApplicationKeyUnderTest() {
-    return "DatePickerDialogTestApp";
-  }
-
-  private static long getDateInMillis(int year, int month, int date) {
-    final Calendar c = Calendar.getInstance();
-    c.set(Calendar.YEAR, year);
-    c.set(Calendar.MONTH, month);
-    c.set(Calendar.DATE, date);
-    return c.getTimeInMillis();
-  }
-
-  private DatePickerDialogTestModule getTestModule() {
-    return getReactContext().getCatalystInstance().getJSModule(DatePickerDialogTestModule.class);
-  }
-
-  private DialogFragment showDialog(WritableMap options) {
-    getTestModule().showDatePickerDialog(options);
-
-    waitForBridgeAndUIIdle();
-    getInstrumentation().waitForIdleSync();
-
-    return (DialogFragment)
-        getActivity()
-            .getSupportFragmentManager()
-            .findFragmentByTag(DatePickerDialogModule.FRAGMENT_TAG);
-  }
-
-  public void testShowBasicDatePicker() {
-    final Fragment datePickerFragment = showDialog(null);
-
-    assertNotNull(datePickerFragment);
-  }
-
-  public void testPresetDate() {
-    final WritableMap options = new WritableNativeMap();
-    options.putDouble("date", getDateInMillis(2020, 5, 6));
-
-    final DialogFragment datePickerFragment = showDialog(options);
-    final DatePicker datePicker =
-        ((DatePickerDialog) datePickerFragment.getDialog()).getDatePicker();
-
-    assertEquals(2020, datePicker.getYear());
-    assertEquals(5, datePicker.getMonth());
-    assertEquals(6, datePicker.getDayOfMonth());
-  }
-
-  public void testCallback() throws Throwable {
-    final WritableMap options = new WritableNativeMap();
-    options.putDouble("date", getDateInMillis(2020, 5, 6));
-
-    final DialogFragment datePickerFragment = showDialog(options);
-
-    runTestOnUiThread(
-        new Runnable() {
-          @Override
-          public void run() {
-            ((DatePickerDialog) datePickerFragment.getDialog())
-                .getButton(DialogInterface.BUTTON_POSITIVE)
-                .performClick();
-          }
-        });
-
-    getInstrumentation().waitForIdleSync();
-    waitForBridgeAndUIIdle();
-
-    assertEquals(0, mRecordingModule.getErrors());
-    assertEquals(1, mRecordingModule.getDates().size());
-    assertEquals(2020, (int) mRecordingModule.getDates().get(0)[0]);
-    assertEquals(5, (int) mRecordingModule.getDates().get(0)[1]);
-    assertEquals(6, (int) mRecordingModule.getDates().get(0)[2]);
-  }
-
-  public void testDismissCallback() throws Throwable {
-    final DialogFragment datePickerFragment = showDialog(null);
-
-    runTestOnUiThread(
-        new Runnable() {
-          @Override
-          public void run() {
-            datePickerFragment.getDialog().dismiss();
-          }
-        });
-
-    getInstrumentation().waitForIdleSync();
-    waitForBridgeAndUIIdle();
-
-    assertEquals(0, mRecordingModule.getErrors());
-    assertEquals(0, mRecordingModule.getDates().size());
-    assertEquals(1, mRecordingModule.getDismissed());
-  }
-}