react-native 0.0.0-263478b91 → 0.0.0-268efb102

package/ReactCommon/react/renderer/graphics/platform/android/react/renderer/graphics/PlatformColorParser.h

@@ -0,0 +1,67 @@
+/*
+ * Copyright (c) Facebook, Inc. and its affiliates.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ */
+
+#pragma once
+
+#include <fbjni/fbjni.h>
+#include <react/jni/ReadableNativeMap.h>
+#include <react/renderer/core/PropsParserContext.h>
+#include <react/renderer/core/RawProps.h>
+#include <react/renderer/graphics/ColorComponents.h>
+
+namespace facebook {
+namespace react {
+
+inline ColorComponents parsePlatformColor(
+    const PropsParserContext &context,
+    const RawValue &value) {
+  ColorComponents colorComponents = {0, 0, 0, 0};
+
+  if (value.hasType<better::map<std::string, std::vector<std::string>>>()) {
+    auto map = (better::map<std::string, std::vector<std::string>>)value;
+    auto resourcePaths = map["resource_paths"];
+    auto dynamicResourcePaths = folly::dynamic::array();
+    for (const auto &resourcePath : resourcePaths) {
+      dynamicResourcePaths.push_back(resourcePath);
+    }
+    folly::dynamic dynamicPlatformColor = folly::dynamic::object();
+    dynamicPlatformColor["resource_paths"] = dynamicResourcePaths;
+
+    auto fabricUIManager =
+        context.contextContainer.at<jni::global_ref<jobject>>(
+            "FabricUIManager");
+
+    static auto getColorFromJava =
+        facebook::jni::findClassStatic(
+            "com/facebook/react/fabric/FabricUIManager")
+            ->getMethod<jint(jint, ReadableMap::javaobject)>("getColor");
+
+    jni::local_ref<ReadableNativeMap::javaobject> dynamicPlatformColorRNM =
+        ReadableNativeMap::newObjectCxxArgs(dynamicPlatformColor);
+    jni::local_ref<ReadableMap::javaobject> dynamicPlatformColorRM =
+        jni::make_local(reinterpret_cast<ReadableMap::javaobject>(
+            dynamicPlatformColorRNM.get()));
+
+    auto color = getColorFromJava(
+        fabricUIManager, context.surfaceId, dynamicPlatformColorRM.get());
+
+    dynamicPlatformColorRM.reset();
+    dynamicPlatformColorRNM.reset();
+
+    auto argb = (int64_t)color;
+    auto ratio = 255.f;
+    colorComponents.alpha = ((argb >> 24) & 0xFF) / ratio;
+    colorComponents.red = ((argb >> 16) & 0xFF) / ratio;
+    colorComponents.green = ((argb >> 8) & 0xFF) / ratio;
+    colorComponents.blue = (argb & 0xFF) / ratio;
+  }
+
+  return colorComponents;
+}
+
+} // namespace react
+} // namespace facebook

package/ReactCommon/react/renderer/graphics/platform/cxx/react/renderer/graphics/Color.cpp

@@ -10,6 +10,14 @@
 namespace facebook {
 namespace react {
 
+bool isColorMeaningful(SharedColor const &color) noexcept {
+  if (!color) {
+    return false;
+  }
+
+  return colorComponentsFromColor(color).alpha > 0;
+}
+
 SharedColor colorFromComponents(ColorComponents components) {
   float ratio = 255;
   return SharedColor(

package/ReactCommon/react/renderer/graphics/platform/cxx/react/renderer/graphics/Color.h

@@ -59,6 +59,7 @@ class SharedColor {
   Color color_;
 };
 
+bool isColorMeaningful(SharedColor const &color) noexcept;
 SharedColor colorFromComponents(ColorComponents components);
 ColorComponents colorComponentsFromColor(SharedColor color);
 

package/ReactCommon/react/renderer/graphics/platform/cxx/react/renderer/graphics/PlatformColorParser.h

@@ -0,0 +1,29 @@
+/*
+ * Copyright (c) Facebook, Inc. and its affiliates.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ */
+
+#pragma once
+
+#include <react/renderer/core/PropsParserContext.h>
+#include <react/renderer/core/RawProps.h>
+#include <react/renderer/graphics/ColorComponents.h>
+
+namespace facebook {
+namespace react {
+
+inline ColorComponents parsePlatformColor(
+    const PropsParserContext &context,
+    const RawValue &value) {
+  float alpha = 0;
+  float red = 0;
+  float green = 0;
+  float blue = 0;
+
+  return {red, green, blue, alpha};
+}
+
+} // namespace react
+} // namespace facebook

package/ReactCommon/react/renderer/graphics/platform/ios/Color.cpp

@@ -11,6 +11,14 @@
 namespace facebook {
 namespace react {
 
+bool isColorMeaningful(SharedColor const &color) noexcept {
+  if (!color) {
+    return false;
+  }
+
+  return colorComponentsFromColor(color).alpha > 0;
+}
+
 SharedColor colorFromComponents(ColorComponents components) {
   float ratio = 255;
   return SharedColor(

package/ReactCommon/react/renderer/graphics/platform/ios/Color.h

@@ -10,6 +10,7 @@
 #include <better/optional.h>
 #include <cmath>
 
+#include <folly/Hash.h>
 #include <react/renderer/graphics/ColorComponents.h>
 #include <react/renderer/graphics/Float.h>
 
@@ -18,8 +19,42 @@ namespace react {
 
 using Color = int32_t;
 
-using SharedColor = better::optional<Color>;
+class SharedColor {
+ public:
+  static const Color UndefinedColor = std::numeric_limits<Color>::max();
 
+  SharedColor() : color_(UndefinedColor) {}
+
+  SharedColor(const SharedColor &sharedColor) : color_(sharedColor.color_) {}
+
+  SharedColor(Color color) : color_(color) {}
+
+  SharedColor &operator=(const SharedColor &sharedColor) {
+    color_ = sharedColor.color_;
+    return *this;
+  }
+
+  Color operator*() const {
+    return color_;
+  }
+
+  bool operator==(const SharedColor &otherColor) const {
+    return color_ == otherColor.color_;
+  }
+
+  bool operator!=(const SharedColor &otherColor) const {
+    return color_ != otherColor.color_;
+  }
+
+  operator bool() const {
+    return color_ != UndefinedColor;
+  }
+
+ private:
+  Color color_;
+};
+
+bool isColorMeaningful(SharedColor const &color) noexcept;
 SharedColor colorFromComponents(ColorComponents components);
 ColorComponents colorComponentsFromColor(SharedColor color);
 
@@ -29,3 +64,10 @@ SharedColor whiteColor();
 
 } // namespace react
 } // namespace facebook
+
+template <>
+struct std::hash<facebook::react::SharedColor> {
+  std::size_t operator()(facebook::react::SharedColor const &color) const {
+    return hash<int>()(*color);
+  }
+};

package/ReactCommon/react/renderer/graphics/platform/ios/PlatformColorParser.h

@@ -0,0 +1,34 @@
+/*
+ * Copyright (c) Facebook, Inc. and its affiliates.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ */
+
+#pragma once
+
+#include <react/renderer/core/PropsParserContext.h>
+#include <react/renderer/core/RawProps.h>
+#include <react/renderer/graphics/ColorComponents.h>
+#include <react/renderer/graphics/RCTPlatformColorUtils.h>
+
+namespace facebook {
+namespace react {
+
+inline ColorComponents parsePlatformColor(
+    const PropsParserContext &context,
+    const RawValue &value) {
+  if (value.hasType<better::map<std::string, RawValue>>()) {
+    auto items = (better::map<std::string, RawValue>)value;
+    if (items.find("semantic") != items.end() &&
+        items.at("semantic").hasType<std::vector<std::string>>()) {
+      auto semanticItems = (std::vector<std::string>)items.at("semantic");
+      return RCTPlatformColorComponentsFromSemanticItems(semanticItems);
+    }
+  }
+
+  return {0, 0, 0, 0};
+}
+
+} // namespace react
+} // namespace facebook

package/ReactCommon/react/renderer/graphics/platform/ios/RCTPlatformColorUtils.h

@@ -0,0 +1,12 @@
+/*
+ * Copyright (c) Facebook, Inc. and its affiliates.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ */
+
+#include <react/renderer/graphics/ColorComponents.h>
+#include <vector>
+
+facebook::react::ColorComponents RCTPlatformColorComponentsFromSemanticItems(
+    std::vector<std::string> &semanticItems);

package/ReactCommon/react/renderer/graphics/platform/ios/RCTPlatformColorUtils.mm

@@ -0,0 +1,206 @@
+/*
+ * Copyright (c) Facebook, Inc. and its affiliates.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ */
+
+#import "RCTPlatformColorUtils.h"
+
+#import <Foundation/Foundation.h>
+#import <React/RCTUtils.h>
+#import <UIKit/UIKit.h>
+
+#include <string>
+
+NS_ASSUME_NONNULL_BEGIN
+
+static NSString *const kColorSuffix = @"Color";
+static NSString *const kFallbackARGBKey = @"fallback-argb";
+
+static NSDictionary<NSString *, NSDictionary *> *_PlatformColorSelectorsDict()
+{
+  static NSDictionary<NSString *, NSDictionary *> *dict;
+  static dispatch_once_t once_token;
+  dispatch_once(&once_token, ^(void) {
+    dict = @{
+      // https://developer.apple.com/documentation/uikit/uicolor/ui_element_colors
+      // Label Colors
+      @"label" : @{
+        kFallbackARGBKey : @(0xFF000000) // iOS 13.0
+      },
+      @"secondaryLabel" : @{
+        kFallbackARGBKey : @(0x993c3c43) // iOS 13.0
+      },
+      @"tertiaryLabel" : @{
+        kFallbackARGBKey : @(0x4c3c3c43) // iOS 13.0
+      },
+      @"quaternaryLabel" : @{
+        kFallbackARGBKey : @(0x2d3c3c43) // iOS 13.0
+      },
+      // Fill Colors
+      @"systemFill" : @{
+        kFallbackARGBKey : @(0x33787880) // iOS 13.0
+      },
+      @"secondarySystemFill" : @{
+        kFallbackARGBKey : @(0x28787880) // iOS 13.0
+      },
+      @"tertiarySystemFill" : @{
+        kFallbackARGBKey : @(0x1e767680) // iOS 13.0
+      },
+      @"quaternarySystemFill" : @{
+        kFallbackARGBKey : @(0x14747480) // iOS 13.0
+      },
+      // Text Colors
+      @"placeholderText" : @{
+        kFallbackARGBKey : @(0x4c3c3c43) // iOS 13.0
+      },
+      // Standard Content Background Colors
+      @"systemBackground" : @{
+        kFallbackARGBKey : @(0xFFffffff) // iOS 13.0
+      },
+      @"secondarySystemBackground" : @{
+        kFallbackARGBKey : @(0xFFf2f2f7) // iOS 13.0
+      },
+      @"tertiarySystemBackground" : @{
+        kFallbackARGBKey : @(0xFFffffff) // iOS 13.0
+      },
+      // Grouped Content Background Colors
+      @"systemGroupedBackground" : @{
+        kFallbackARGBKey : @(0xFFf2f2f7) // iOS 13.0
+      },
+      @"secondarySystemGroupedBackground" : @{
+        kFallbackARGBKey : @(0xFFffffff) // iOS 13.0
+      },
+      @"tertiarySystemGroupedBackground" : @{
+        kFallbackARGBKey : @(0xFFf2f2f7) // iOS 13.0
+      },
+      // Separator Colors
+      @"separator" : @{
+        kFallbackARGBKey : @(0x493c3c43) // iOS 13.0
+      },
+      @"opaqueSeparator" : @{
+        kFallbackARGBKey : @(0xFFc6c6c8) // iOS 13.0
+      },
+      // Link Color
+      @"link" : @{
+        kFallbackARGBKey : @(0xFF007aff) // iOS 13.0
+      },
+      // Nonadaptable Colors
+      @"darkText" : @{},
+      @"lightText" : @{},
+      // https://developer.apple.com/documentation/uikit/uicolor/standard_colors
+      // Adaptable Colors
+      @"systemBlue" : @{},
+      @"systemBrown" : @{
+        kFallbackARGBKey : @(0xFFa2845e) // iOS 13.0
+      },
+      @"systemGreen" : @{},
+      @"systemIndigo" : @{
+        kFallbackARGBKey : @(0xFF5856d6) // iOS 13.0
+      },
+      @"systemOrange" : @{},
+      @"systemPink" : @{},
+      @"systemPurple" : @{},
+      @"systemRed" : @{},
+      @"systemTeal" : @{},
+      @"systemYellow" : @{},
+      // Adaptable Gray Colors
+      @"systemGray" : @{},
+      @"systemGray2" : @{
+        kFallbackARGBKey : @(0xFFaeaeb2) // iOS 13.0
+      },
+      @"systemGray3" : @{
+        kFallbackARGBKey : @(0xFFc7c7cc) // iOS 13.0
+      },
+      @"systemGray4" : @{
+        kFallbackARGBKey : @(0xFFd1d1d6) // iOS 13.0
+      },
+      @"systemGray5" : @{
+        kFallbackARGBKey : @(0xFFe5e5ea) // iOS 13.0
+      },
+      @"systemGray6" : @{
+        kFallbackARGBKey : @(0xFFf2f2f7) // iOS 13.0
+      },
+      // Transparent Color
+      @"clear" : @{
+        kFallbackARGBKey : @(0x00000000) // iOS 13.0
+      },
+    };
+  });
+  return dict;
+}
+
+static UIColor *_UIColorFromHexValue(NSNumber *hexValue)
+{
+  NSUInteger hexIntValue = [hexValue unsignedIntegerValue];
+
+  CGFloat red = ((CGFloat)((hexIntValue & 0xFF000000) >> 24)) / 255.0;
+  CGFloat green = ((CGFloat)((hexIntValue & 0xFF0000) >> 16)) / 255.0;
+  CGFloat blue = ((CGFloat)((hexIntValue & 0xFF00) >> 8)) / 255.0;
+  CGFloat alpha = ((CGFloat)(hexIntValue & 0xFF)) / 255.0;
+
+  return [UIColor colorWithRed:red green:green blue:blue alpha:alpha];
+}
+
+static UIColor *_Nullable _UIColorFromSemanticString(NSString *semanticString)
+{
+  NSString *platformColorString = [semanticString hasSuffix:kColorSuffix]
+      ? [semanticString substringToIndex:[semanticString length] - [kColorSuffix length]]
+      : semanticString;
+  NSDictionary<NSString *, NSDictionary *> *platformColorSelectorsDict = _PlatformColorSelectorsDict();
+  NSDictionary<NSString *, id> *colorInfo = platformColorSelectorsDict[platformColorString];
+  if (colorInfo) {
+    SEL objcColorSelector = NSSelectorFromString([platformColorString stringByAppendingString:kColorSuffix]);
+    if (![UIColor respondsToSelector:objcColorSelector]) {
+      NSNumber *fallbackRGB = colorInfo[kFallbackARGBKey];
+      if (fallbackRGB) {
+        return _UIColorFromHexValue(fallbackRGB);
+      }
+    } else {
+      Class uiColorClass = [UIColor class];
+      IMP imp = [uiColorClass methodForSelector:objcColorSelector];
+      id (*getUIColor)(id, SEL) = ((id(*)(id, SEL))imp);
+      id colorObject = getUIColor(uiColorClass, objcColorSelector);
+      if ([colorObject isKindOfClass:[UIColor class]]) {
+        return colorObject;
+      }
+    }
+  }
+  return nil;
+}
+
+static inline NSString *_NSStringFromCString(
+    const std::string &string,
+    const NSStringEncoding &encoding = NSUTF8StringEncoding)
+{
+  return [NSString stringWithCString:string.c_str() encoding:encoding];
+}
+
+static inline facebook::react::ColorComponents _ColorComponentsFromUIColor(UIColor *color)
+{
+  CGFloat rgba[4];
+  RCTGetRGBAColorComponents(color.CGColor, rgba);
+  return {(float)rgba[0], (float)rgba[1], (float)rgba[2], (float)rgba[3]};
+}
+
+facebook::react::ColorComponents RCTPlatformColorComponentsFromSemanticItems(std::vector<std::string> &semanticItems)
+{
+  for (const auto &semanticCString : semanticItems) {
+    if (@available(iOS 11.0, *)) {
+      NSString *semanticNSString = _NSStringFromCString(semanticCString);
+      UIColor *uiColor = [UIColor colorNamed:semanticNSString];
+      if (uiColor != nil) {
+        return _ColorComponentsFromUIColor(uiColor);
+      }
+      uiColor = _UIColorFromSemanticString(semanticNSString);
+      if (uiColor != nil) {
+        return _ColorComponentsFromUIColor(uiColor);
+      }
+    }
+  }
+
+  return {0, 0, 0, 0};
+}
+
+NS_ASSUME_NONNULL_END

package/ReactCommon/react/renderer/imagemanager/BUCK

@@ -64,8 +64,8 @@ rn_xplat_cxx_library(
     ],
     force_static = True,
     ios_deps = [
-        "//xplat/js:RCTImage",
         "//xplat/js/react-native-github:RCTCxxBridge",
+        "//xplat/js/react-native-github:RCTImage",
     ],
     ios_exported_headers = subdir_glob(
         [

package/ReactCommon/react/renderer/imagemanager/platform/ios/RCTSyncImageManager.mm

@@ -92,7 +92,7 @@ using namespace facebook::react;
 
   auto result = dispatch_group_wait(imageWaitGroup, dispatch_time(DISPATCH_TIME_NOW, 2 * NSEC_PER_SEC));
   if (result != 0) {
-    RCTLogError(@"Getting an image timed out");
+    RCTLogError(@"Image timed out in test environment for url: %@", loaderRequest.imageURL);
   }
   return imageRequest;
 }

package/ReactCommon/react/renderer/leakchecker/LeakChecker.cpp

@@ -8,15 +8,13 @@
 #include "LeakChecker.h"
 
 #include <glog/logging.h>
+#include <jsi/instrumentation.h>
 
 namespace facebook {
 namespace react {
 
-LeakChecker::LeakChecker(
-    RuntimeExecutor const &runtimeExecutor,
-    GarbageCollectionTrigger const &garbageCollectionTrigger)
-    : runtimeExecutor_(runtimeExecutor),
-      garbageCollectionTrigger_(garbageCollectionTrigger) {}
+LeakChecker::LeakChecker(RuntimeExecutor const &runtimeExecutor)
+    : runtimeExecutor_(runtimeExecutor) {}
 
 void LeakChecker::uiManagerDidCreateShadowNodeFamily(
     ShadowNodeFamily::Shared const &shadowNodeFamily) const {
@@ -24,13 +22,12 @@ void LeakChecker::uiManagerDidCreateShadowNodeFamily(
 }
 
 void LeakChecker::stopSurface(SurfaceId surfaceId) {
-  garbageCollectionTrigger_();
-
   if (previouslyStoppedSurface_ > 0) {
     // Dispatch the check onto JavaScript thread to make sure all other
     // cleanup code has had chance to run.
     runtimeExecutor_([previouslySoppedSurface = previouslyStoppedSurface_,
-                      this](jsi::Runtime &) {
+                      this](jsi::Runtime &runtime) {
+      runtime.instrumentation().collectGarbage("LeakChecker");
       // For now check the previous surface because React uses double
       // buffering which keeps the surface that was just stopped in
       // memory. This is a documented problem in the last point of
@@ -44,7 +41,7 @@ void LeakChecker::stopSurface(SurfaceId surfaceId) {
 
 void LeakChecker::checkSurfaceForLeaks(SurfaceId surfaceId) const {
   auto weakFamilies = registry_.weakFamiliesForSurfaceId(surfaceId);
-  uint numberOfLeaks = 0;
+  unsigned int numberOfLeaks = 0;
   for (auto const &weakFamily : weakFamilies) {
     auto strong = weakFamily.lock();
     if (strong) {

package/ReactCommon/react/renderer/leakchecker/LeakChecker.h

@@ -20,9 +20,7 @@ using GarbageCollectionTrigger = std::function<void()>;
 
 class LeakChecker final {
  public:
-  LeakChecker(
-      RuntimeExecutor const &runtimeExecutor,
-      GarbageCollectionTrigger const &garbageCollectionTrigger);
+  LeakChecker(RuntimeExecutor const &runtimeExecutor);
 
   void uiManagerDidCreateShadowNodeFamily(
       ShadowNodeFamily::Shared const &shadowNodeFamily) const;
@@ -32,7 +30,6 @@ class LeakChecker final {
   void checkSurfaceForLeaks(SurfaceId surfaceId) const;
 
   RuntimeExecutor const runtimeExecutor_{};
-  GarbageCollectionTrigger const garbageCollectionTrigger_{};
 
   WeakFamilyRegistry registry_{};
   SurfaceId previouslyStoppedSurface_;

package/ReactCommon/react/renderer/mapbuffer/BUCK

@@ -40,7 +40,7 @@ rn_xplat_cxx_library(
     force_static = True,
     labels = ["supermodule:xplat/default/public.react_native.infra"],
     macosx_tests_override = [],
-    platforms = (ANDROID),
+    platforms = ANDROID,
     preprocessor_flags = [
         "-DLOG_TAG=\"ReactNative\"",
         "-DWITH_FBSYSTRACE=1",
@@ -67,7 +67,7 @@ fb_xplat_cxx_test(
         "-Wall",
     ],
     contacts = ["oncall+react_native@xmail.facebook.com"],
-    platforms = (ANDROID),
+    platforms = ANDROID,
     deps = [
         "//xplat/folly:molly",
         "//xplat/third-party/gmock:gtest",

package/ReactCommon/react/renderer/mounting/Android.mk

@@ -21,7 +21,7 @@ LOCAL_CFLAGS += -fexceptions -frtti -std=c++17 -Wall
 
 LOCAL_STATIC_LIBRARIES :=
 
-LOCAL_SHARED_LIBRARIES := libbetter libyoga libfolly_futures glog libfolly_json libglog_init libreact_render_core libreact_render_debug librrc_view librrc_root libreact_utils libreact_debug libreact_render_telemetry
+LOCAL_SHARED_LIBRARIES := libjsi libbetter libyoga libfolly_futures glog libfolly_json libglog_init libreact_render_core libreact_render_debug librrc_view librrc_root libreact_utils libreact_debug libreact_render_graphics libreact_render_telemetry
 
 include $(BUILD_SHARED_LIBRARY)
 
@@ -36,4 +36,5 @@ $(call import-module,react/renderer/debug)
 $(call import-module,react/utils)
 $(call import-module,react/debug)
 $(call import-module,yogajni)
+$(call import-module,react/renderer/graphics)
 $(call import-module,react/renderer/telemetry)

package/ReactCommon/react/renderer/mounting/Differentiator.cpp

@@ -6,7 +6,6 @@
  */
 
 #include "Differentiator.h"
-#include "DifferentiatorFlatteningClassic.h"
 
 #include <better/map.h>
 #include <better/small_vector.h>
@@ -170,8 +169,8 @@ class TinyMap final {
   }
 
   better::small_vector<Pair, DefaultSize> vector_;
-  int numErased_{0};
-  int erasedAtFront_{0};
+  size_t numErased_{0};
+  size_t erasedAtFront_{0};
 };
 
 /*
@@ -1658,13 +1657,7 @@ ShadowViewNodePair::OwningList sliceChildShadowNodeViewPairsLegacy(
 
 ShadowViewMutation::List calculateShadowViewMutations(
     ShadowNode const &oldRootShadowNode,
-    ShadowNode const &newRootShadowNode,
-    bool useNewDiffer) {
-  if (!useNewDiffer) {
-    return DifferOld::calculateShadowViewMutations(
-        oldRootShadowNode, newRootShadowNode);
-  }
-
+    ShadowNode const &newRootShadowNode) {
   SystraceSection s("calculateShadowViewMutations");
 
   // Root shadow nodes must be belong the same family.

package/ReactCommon/react/renderer/mounting/Differentiator.h

@@ -47,8 +47,7 @@ using ViewNodePairScope = std::deque<ShadowViewNodePair>;
  */
 ShadowViewMutation::List calculateShadowViewMutations(
     ShadowNode const &oldRootShadowNode,
-    ShadowNode const &newRootShadowNode,
-    bool useNewDiffer);
+    ShadowNode const &newRootShadowNode);
 
 /**
  * Generates a list of `ShadowViewNodePair`s that represents a layer of a

package/ReactCommon/react/renderer/mounting/MountingCoordinator.cpp

@@ -90,9 +90,7 @@ better::optional<MountingTransaction> MountingCoordinator::pullTransaction()
     telemetry.willDiff();
 
     auto mutations = calculateShadowViewMutations(
-        *baseRevision_.rootShadowNode,
-        *lastRevision_->rootShadowNode,
-        enableNewDiffer_);
+        *baseRevision_.rootShadowNode, *lastRevision_->rootShadowNode);
 
     telemetry.didDiff();
 
@@ -188,9 +186,5 @@ void MountingCoordinator::setMountingOverrideDelegate(
   mountingOverrideDelegate_ = delegate;
 }
 
-void MountingCoordinator::setEnableNewDiffer(bool enabled) const {
-  enableNewDiffer_ = enabled;
-}
-
 } // namespace react
 } // namespace facebook

package/ReactCommon/react/renderer/mounting/MountingCoordinator.h

@@ -71,8 +71,6 @@ class MountingCoordinator final {
 
   TelemetryController const &getTelemetryController() const;
 
-  void setEnableNewDiffer(bool enabled) const;
-
   /*
    * Methods from this section are meant to be used by
    * `MountingOverrideDelegate` only.
@@ -114,8 +112,6 @@ class MountingCoordinator final {
 
   TelemetryController telemetryController_;
 
-  mutable bool enableNewDiffer_{false};
-
 #ifdef RN_SHADOW_TREE_INTROSPECTION
   mutable StubViewTree stubViewTree_; // Protected by `mutex_`.
 #endif

package/ReactCommon/react/renderer/mounting/MountingOverrideDelegate.h

@@ -22,7 +22,7 @@ class MountingCoordinator;
 class MountingOverrideDelegate {
  public:
   virtual bool shouldOverridePullTransaction() const = 0;
-  virtual ~MountingOverrideDelegate(){};
+  virtual ~MountingOverrideDelegate() = default;
 
   /**
    * Delegates that override this method are responsible for: