react-native-vroom-chart 0.5.0 → 0.7.0

package/cpp/_core_src/chart_facade.cpp

@@ -14,6 +14,7 @@
 #include "chart.h"
 #include "drawings.h"
 #include "labels.h"
+#include "price_lines.h"
 #include "viewport.h"
 
 class SkCanvas;
@@ -62,6 +63,13 @@ int64_t damp_future_delta(int64_t delta_ms, int64_t cur_future,
 void apply_default_framing(VroomChart* chart) {
     if (chart->candles.empty()) return;
 
+    // A candle occupies the slot [time_ms, time_ms + duration) and draws centered
+    // in it, so the right edge of the view is the last slot's *end*. Pinning it to
+    // the last candle's time_ms instead puts that candle's center half a slot past
+    // the plot area, hiding the newest candle behind the y-axis strip.
+    const int64_t right_edge_ms =
+        chart->candles.back().time_ms + chart->candle_duration_ms;
+
     // Px-driven framing. Reuses the inversion from vroom_chart_scale_time_axis:
     // body_w = usable × (dur / window) × ratio  →  window = usable × dur × ratio / body_w.
     // Needs a valid layout (width_px); until size is known it falls through to
@@ -80,7 +88,7 @@ void apply_default_framing(VroomChart* chart) {
                 chart->candles.back().time_ms - chart->candles.front().time_ms;
             window_ms = std::clamp<int64_t>(window_ms, chart->candle_duration_ms,
                                             span > 0 ? span : window_ms);
-            chart->visible_end_ms = chart->candles.back().time_ms;
+            chart->visible_end_ms = right_edge_ms;
             chart->visible_start_ms = chart->visible_end_ms - window_ms;
             return;
         }
@@ -91,7 +99,7 @@ void apply_default_framing(VroomChart* chart) {
         ? chart->candles.size() - kDefaultVisible
         : 0;
     chart->visible_start_ms = chart->candles[start_idx].time_ms;
-    chart->visible_end_ms = chart->candles.back().time_ms;
+    chart->visible_end_ms = right_edge_ms;
 }
 
 // On the first manual-y gesture, adopt the on-screen auto-fit bounds so the
@@ -241,6 +249,10 @@ extern "C" void vroom_chart_reset_view(VroomChart* chart) {
     chart->visible_start_ms = 0;
     chart->visible_end_ms = 0;
     chart->price_bounds_manual = false;
+    // An asset switch reframes wholesale, so a slot-paired morph is meaningless
+    // here — drop any capture rather than leaving it to reshape the wrong data.
+    chart->morph_from.clear();
+    chart->interval_morph_t = 1.f;
     apply_default_framing(chart);
     vroom::labels::recompute_axis_width(*chart);
     if (chart->cb.on_viewport_changed) {
@@ -257,6 +269,104 @@ extern "C" void vroom_chart_reset_price_scale(VroomChart* chart) {
     chart->mark_dirty();
 }
 
+extern "C" bool vroom_chart_get_visible_price_envelope(VroomChart* chart,
+                                                       double* out_low,
+                                                       double* out_high) {
+    if (!chart) return false;
+    const auto idx = vroom::visible_indices(
+        chart->candles.data(), chart->candles.size(),
+        chart->visible_start_ms, chart->visible_end_ms);
+    if (idx.end <= idx.start) return false;
+    const auto env = vroom::price_bounds(chart->candles.data() + idx.start,
+                                         idx.end - idx.start);
+    if (out_low) *out_low = env.min;
+    if (out_high) *out_high = env.max;
+    return true;
+}
+
+extern "C" void vroom_chart_preserve_price_envelope(VroomChart* chart,
+                                                    double prev_low,
+                                                    double prev_high) {
+    // Auto mode already holds the envelope's pixel height constant (auto_price_
+    // bounds widens it by a fixed factor), so there is nothing to preserve.
+    if (!chart || !chart->price_bounds_manual) return;
+
+    double new_low = 0.0, new_high = 0.0;
+    const bool has_new =
+        vroom_chart_get_visible_price_envelope(chart, &new_low, &new_high);
+    if (!has_new || !(prev_high > prev_low) || !(new_high > new_low)) {
+        // Nothing to scale against — fall back to re-fitting the price scale.
+        vroom_chart_reset_price_scale(chart);
+        return;
+    }
+
+    chart->price_bounds = vroom::preserve_envelope_bounds(
+        chart->price_bounds, {prev_low, prev_high}, {new_low, new_high});
+    vroom::labels::recompute_axis_width(*chart);
+    chart->mark_dirty();
+}
+
+extern "C" void vroom_chart_begin_interval_morph(VroomChart* chart) {
+    if (!chart) return;
+    chart->morph_from.clear();
+    chart->interval_morph_t = 1.f;
+
+    const auto lay = chart->layout();
+    const float area_w = vroom::candle_area_width(lay);
+    const int64_t window_ms = chart->visible_end_ms - chart->visible_start_ms;
+    if (area_w <= 0.f || window_ms <= 0) return;
+
+    const auto idx = vroom::visible_indices(
+        chart->candles.data(), chart->candles.size(),
+        chart->visible_start_ms, chart->visible_end_ms);
+    const std::size_t n = idx.end - idx.start;
+    if (n == 0) return;
+    const ::VroomCandle* visible = chart->candles.data() + idx.start;
+
+    const auto bounds = chart->price_bounds_manual
+        ? chart->price_bounds
+        : vroom::auto_price_bounds(visible, n);
+
+    // Normalized so the capture is independent of both the price bounds (which
+    // the swap is about to replace) and the surface size (which may change
+    // mid-morph). Newest candle first, matching the slot indexing in
+    // candles::draw.
+    chart->morph_from.resize(n);
+    for (std::size_t k = 0; k < n; ++k) {
+        const auto& c = visible[n - 1 - k];
+        chart->morph_from[k] = vroom::CandleSnapshot{
+            vroom::candle_center_x(lay, c.time_ms, chart->candle_duration_ms,
+                                   chart->visible_start_ms, window_ms) / area_w,
+            static_cast<float>(vroom::price_fraction(bounds, c.open)),
+            static_cast<float>(vroom::price_fraction(bounds, c.high)),
+            static_cast<float>(vroom::price_fraction(bounds, c.low)),
+            static_cast<float>(vroom::price_fraction(bounds, c.close)),
+            c.close >= c.open,
+        };
+    }
+
+    // The scale the capture was taken against — the axes render their outgoing
+    // ticks from it, and it's about to be replaced on the chart itself.
+    chart->morph_from_bounds = bounds;
+    chart->morph_from_start_ms = chart->visible_start_ms;
+    chart->morph_from_end_ms = chart->visible_end_ms;
+
+    // Open the morph at 0 rather than leaving it at 1: the caller still has to
+    // push the new candles, and any frame painted in between should show the
+    // captured geometry — which is what the pre-switch frame looked like.
+    chart->interval_morph_t = 0.f;
+}
+
+extern "C" void vroom_chart_set_interval_morph(VroomChart* chart, float t) {
+    if (!chart) return;
+    chart->interval_morph_t = std::clamp(t, 0.f, 1.f);
+    if (chart->interval_morph_t >= 1.f) {
+        chart->morph_from.clear();
+        chart->morph_from.shrink_to_fit();
+    }
+    chart->mark_dirty();
+}
+
 extern "C" void vroom_chart_pan(VroomChart* chart, float dx_px, float /*dy_px*/) {
     if (!chart || dx_px == 0.f || chart->candles.empty()) return;
 
@@ -480,7 +590,7 @@ extern "C" void vroom_chart_scale_time_axis(VroomChart* chart, float dx_px) {
 extern "C" void vroom_chart_resize_indicator_pane(VroomChart* chart, float dy_px) {
     if (!chart || dy_px == 0.f) return;
 
-    const int pane_count = (chart->rsi_enabled ? 1 : 0) + (chart->macd_enabled ? 1 : 0);
+    const int pane_count = (chart->rsi.enabled ? 1 : 0) + (chart->macd.enabled ? 1 : 0);
     if (pane_count == 0) return;  // nothing below the chart to resize
 
     const auto lay = chart->layout();
@@ -534,8 +644,8 @@ extern "C" void vroom_chart_scale_indicator_axis(VroomChart* chart, float y_px,
     struct ActivePane { int order; int type; };  // type: 0 = RSI, 1 = MACD
     ActivePane panes[2];
     int count = 0;
-    if (chart->rsi_enabled) panes[count++] = {chart->rsi_order, 0};
-    if (chart->macd_enabled) panes[count++] = {chart->macd_order, 1};
+    if (chart->rsi.enabled) panes[count++] = {chart->rsi_order, 0};
+    if (chart->macd.enabled) panes[count++] = {chart->macd_order, 1};
     if (count == 0) return;
     if (count == 2 && panes[0].order > panes[1].order) {
         const ActivePane tmp = panes[0];
@@ -812,6 +922,70 @@ extern "C" void vroom_chart_set_liquidity(VroomChart* chart,
     chart->mark_dirty();
 }
 
+// ---- Price status lines ---------------------------------------------------
+
+extern "C" void vroom_chart_set_price_lines(VroomChart* chart,
+                                            const VroomPriceLine* lines,
+                                            size_t count,
+                                            const VroomPriceLineStyle* style) {
+    if (!chart) return;
+    // Deep-copy into the owning form: the label strings live in the chart, so the
+    // caller's buffers may be freed as soon as this returns.
+    chart->price_lines.clear();
+    chart->price_lines.reserve(count);
+    for (size_t i = 0; i < count; ++i) {
+        const VroomPriceLine& src = lines[i];
+        VroomChart::StoredPriceLine pl;
+        pl.price = src.price;
+        pl.color = src.color;
+        pl.width = src.width;
+        pl.line_style = src.line_style;
+        if (src.text) pl.text = src.text;
+        if (src.quantity) pl.quantity = src.quantity;
+        pl.flags = src.flags;
+        chart->price_lines.push_back(std::move(pl));
+    }
+    if (style) chart->price_line_style = *style;
+    // Drop interaction state that no longer refers to a live line — otherwise a
+    // removed line would leave a stuck hover highlight or drag preview.
+    const auto n = static_cast<int32_t>(count);
+    if (chart->hovered_price_line >= n) {
+        chart->hovered_price_line = -1;
+        chart->hovered_price_line_part = -1;
+    }
+    if (chart->dragged_price_line >= n) chart->dragged_price_line = -1;
+    chart->mark_dirty();
+}
+
+extern "C" void vroom_chart_set_price_line_hover(VroomChart* chart, int32_t index,
+                                                 int32_t part) {
+    if (!chart) return;
+    if (index < 0 || index >= static_cast<int32_t>(chart->price_lines.size())) {
+        index = -1;
+        part = -1;
+    }
+    if (chart->hovered_price_line == index && chart->hovered_price_line_part == part) {
+        return;  // hover fires on every pointer move; don't redraw for nothing
+    }
+    chart->hovered_price_line = index;
+    chart->hovered_price_line_part = part;
+    chart->mark_dirty();
+}
+
+extern "C" void vroom_chart_set_price_line_drag(VroomChart* chart, int32_t index,
+                                                double price) {
+    if (!chart) return;
+    if (index < 0 || index >= static_cast<int32_t>(chart->price_lines.size())) {
+        if (chart->dragged_price_line == -1) return;
+        chart->dragged_price_line = -1;
+        chart->mark_dirty();
+        return;
+    }
+    chart->dragged_price_line = index;
+    chart->dragged_price_line_price = price;
+    chart->mark_dirty();
+}
+
 extern "C" void vroom_chart_set_draft(VroomChart* chart, int64_t a_time,
                                       double a_price, bool has_b, int64_t b_time,
                                       double b_price, bool guide, uint32_t color,
@@ -926,6 +1100,32 @@ extern "C" bool vroom_chart_hit_test_drawing(VroomChart* chart, float x_px,
     return true;
 }
 
+extern "C" bool vroom_chart_hit_test_price_line(VroomChart* chart, float x_px,
+                                                float y_px, int32_t* out_index,
+                                                int32_t* out_part) {
+    if (!chart || chart->price_lines.empty() || chart->candles.empty()) return false;
+    const auto lay = chart->layout();
+    // Same bounds and pane geometry as draw_chart, so the grab regions line up
+    // with what's on screen.
+    const auto range = vroom::visible_indices(
+        chart->candles.data(), chart->candles.size(),
+        chart->visible_start_ms, chart->visible_end_ms);
+    const size_t n = range.end - range.start;
+    const auto bounds =
+        chart->price_bounds_manual
+            ? chart->price_bounds
+            : vroom::auto_price_bounds(chart->candles.data() + range.start, n);
+    const float candle_area_h = vroom::price_pane_bottom(lay);
+    const float candle_right =
+        chart->width_px - lay.y_axis_width_px - lay.right_padding_px;
+    const auto hit = vroom::price_lines::hit_test(*chart, lay, bounds, candle_right,
+                                                  candle_area_h, x_px, y_px);
+    if (hit.index < 0) return false;
+    if (out_index) *out_index = hit.index;
+    if (out_part) *out_part = hit.part;
+    return true;
+}
+
 extern "C" void vroom_chart_set_selected_drawing(VroomChart* chart,
                                                  int32_t index,
                                                  int32_t grabbed_endpoint) {
@@ -968,61 +1168,66 @@ extern "C" void vroom_chart_translate_drawing(VroomChart* chart, int32_t index,
 
 // ---- Indicators -----------------------------------------------------------
 
-extern "C" void vroom_chart_set_rsi(VroomChart* chart, bool enabled, int period,
-                                    double upper_band, double lower_band,
-                                    bool ma_enabled, int ma_period) {
-    if (!chart) return;
-    if (period < 2) period = 2;
-    if (ma_period < 1) ma_period = 1;
-    upper_band = std::clamp(upper_band, 0.0, 100.0);
-    lower_band = std::clamp(lower_band, 0.0, 100.0);
-
-    // Only the series-affecting fields force a recompute; band changes are
-    // render-only.
-    const bool recompute = chart->rsi_enabled != enabled ||
-                           chart->rsi_period != period ||
-                           chart->rsi_ma_enabled != ma_enabled ||
-                           chart->rsi_ma_period != ma_period;
-    const bool changed = recompute || chart->rsi_upper != upper_band ||
-                         chart->rsi_lower != lower_band;
-    if (!changed) return;
+extern "C" void vroom_chart_set_rsi(VroomChart* chart, const VroomRSI* cfg) {
+    if (!chart || !cfg) return;
+    VroomRSI next = *cfg;
+    next.enabled = next.enabled ? 1 : 0;
+    next.ma_visible = next.ma_visible ? 1 : 0;
+    next.line_visible = next.line_visible ? 1 : 0;
+    next.bands_visible = next.bands_visible ? 1 : 0;
+    if (next.period < 2) next.period = 2;
+    if (next.ma_period < 1) next.ma_period = 1;
+    next.upper_band = std::clamp(next.upper_band, 0.0, 100.0);
+    next.lower_band = std::clamp(next.lower_band, 0.0, 100.0);
+
+    // Only the series-affecting fields force a recompute; band levels, color,
+    // width, and visibility changes are render-only. The trendline is one of
+    // them: it isn't computed while hidden, so revealing it needs a recompute.
+    const VroomRSI& cur = chart->rsi;
+    const bool recompute = cur.enabled != next.enabled ||
+                           cur.period != next.period ||
+                           cur.ma_visible != next.ma_visible ||
+                           cur.ma_period != next.ma_period ||
+                           cur.ma_kind != next.ma_kind;
 
     // Pane order: claim the next slot on an off->on transition, release on off.
-    if (enabled && !chart->rsi_enabled) chart->rsi_order = chart->pane_seq++;
-    else if (!enabled) chart->rsi_order = -1;
-
-    chart->rsi_enabled = enabled;
-    chart->rsi_period = period;
-    chart->rsi_upper = upper_band;
-    chart->rsi_lower = lower_band;
-    chart->rsi_ma_enabled = ma_enabled;
-    chart->rsi_ma_period = ma_period;
+    if (next.enabled && !cur.enabled) chart->rsi_order = chart->pane_seq++;
+    else if (!next.enabled) chart->rsi_order = -1;
+
+    chart->rsi = next;
     if (recompute) chart->rsi_dirty = true;
     chart->mark_dirty();
 }
 
-extern "C" void vroom_chart_set_macd(VroomChart* chart, bool enabled, int fast,
-                                     int slow, int signal) {
-    if (!chart) return;
-    if (fast < 1) fast = 1;
-    if (slow < 1) slow = 1;
-    if (slow <= fast) slow = fast + 1;
-    if (signal < 1) signal = 1;
-
-    const bool recompute = chart->macd_enabled != enabled ||
-                           chart->macd_fast != fast ||
-                           chart->macd_slow != slow ||
-                           chart->macd_signal != signal;
-    if (!recompute) return;
-
-    if (enabled && !chart->macd_enabled) chart->macd_order = chart->pane_seq++;
-    else if (!enabled) chart->macd_order = -1;
-
-    chart->macd_enabled = enabled;
-    chart->macd_fast = fast;
-    chart->macd_slow = slow;
-    chart->macd_signal = signal;
-    chart->macd_dirty = true;
+extern "C" void vroom_chart_set_macd(VroomChart* chart, const VroomMACD* cfg) {
+    if (!chart || !cfg) return;
+    VroomMACD next = *cfg;
+    next.enabled = next.enabled ? 1 : 0;
+    next.line_visible = next.line_visible ? 1 : 0;
+    next.signal_visible = next.signal_visible ? 1 : 0;
+    next.hist_visible = next.hist_visible ? 1 : 0;
+    next.zero_visible = next.zero_visible ? 1 : 0;
+    if (next.fast < 1) next.fast = 1;
+    if (next.slow < 1) next.slow = 1;
+    if (next.slow <= next.fast) next.slow = next.fast + 1;
+    if (next.signal < 1) next.signal = 1;
+
+    // Only the series-affecting fields force a recompute; color, width, and
+    // visibility changes are render-only.
+    const VroomMACD& cur = chart->macd;
+    const bool recompute = cur.enabled != next.enabled ||
+                           cur.fast != next.fast ||
+                           cur.slow != next.slow ||
+                           cur.signal != next.signal ||
+                           cur.source != next.source ||
+                           cur.ma_kind != next.ma_kind ||
+                           cur.signal_ma_kind != next.signal_ma_kind;
+
+    if (next.enabled && !cur.enabled) chart->macd_order = chart->pane_seq++;
+    else if (!next.enabled) chart->macd_order = -1;
+
+    chart->macd = next;
+    if (recompute) chart->macd_dirty = true;
     chart->mark_dirty();
 }
 
@@ -1035,19 +1240,21 @@ extern "C" void vroom_chart_set_overlays(VroomChart* chart,
     chart->mark_dirty();
 }
 
-extern "C" void vroom_chart_set_vwap(VroomChart* chart, bool enabled,
-                                     int reset_offset_min, uint32_t color,
-                                     float width) {
-    if (!chart) return;
+extern "C" void vroom_chart_set_vwap(VroomChart* chart, const VroomVWAP* cfg) {
+    if (!chart || !cfg) return;
+    VroomVWAP next = *cfg;
+    next.enabled = next.enabled ? 1 : 0;
     // Keep the offset within a day [0, 1440).
-    int off = reset_offset_min % 1440;
-    if (off < 0) off += 1440;
-    const bool recompute =
-        chart->vwap_enabled != enabled || chart->vwap_reset_offset_min != off;
-    chart->vwap_enabled = enabled;
-    chart->vwap_reset_offset_min = off;
-    chart->vwap_color = color;
-    chart->vwap_width = width;
+    next.reset_offset_min %= 1440;
+    if (next.reset_offset_min < 0) next.reset_offset_min += 1440;
+
+    // Only the series-affecting fields force a recompute; color and width
+    // changes are render-only.
+    const VroomVWAP& cur = chart->vwap;
+    const bool recompute = cur.enabled != next.enabled ||
+                           cur.reset_offset_min != next.reset_offset_min;
+
+    chart->vwap = next;
     if (recompute) chart->vwap_dirty = true;
     chart->mark_dirty();
 }
@@ -1075,6 +1282,30 @@ extern "C" void vroom_chart_set_bollinger(VroomChart* chart,
     chart->mark_dirty();
 }
 
+extern "C" void vroom_chart_set_volume(VroomChart* chart,
+                                       const VroomVolume* cfg) {
+    if (!chart || !cfg) return;
+    VroomVolume next = *cfg;
+    next.enabled = next.enabled ? 1 : 0;
+    // Negative means "inherit", so only clamp the ranges once a value is set.
+    if (next.height_frac >= 0.f) next.height_frac = std::min(next.height_frac, 1.f);
+    if (next.opacity >= 0.f) next.opacity = std::min(next.opacity, 1.f);
+    chart->volume = next;
+    // Snap the collapse to the new target, the way set_chart_type snaps the
+    // candle↔line morph. A host that wants the toggle animated overrides this
+    // from its frame loop before the next paint.
+    chart->volume_collapse_t = next.enabled ? 0.f : 1.f;
+    chart->mark_dirty();
+}
+
+extern "C" void vroom_chart_set_volume_collapse(VroomChart* chart, float t,
+                                               int32_t easing) {
+    if (!chart) return;
+    chart->volume_collapse_t = std::clamp(t, 0.f, 1.f);
+    chart->volume_collapse_easing = easing;
+    chart->mark_dirty();
+}
+
 // ---- Direct draw (used by hosts that don't need the SkPicture cache) ------
 
 extern "C" void vroom_chart_draw(VroomChart* chart, SkCanvas* canvas) {

package/cpp/_core_src/gradient.cpp

@@ -0,0 +1,46 @@
+#include "gradient.h"
+
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wdocumentation"
+#include "include/core/SkPoint.h"
+#include "include/core/SkShader.h"
+#include "include/core/SkTileMode.h"
+// See gradient.h: the two Skia versions we build against ship different
+// linear-gradient headers, and neither ships both.
+#if __has_include("include/effects/SkGradient.h")
+#  include "include/core/SkSpan.h"
+#  include "include/effects/SkGradient.h"
+#  define VROOM_SK_MODERN_GRADIENT 1
+#else
+#  include "include/effects/SkGradientShader.h"
+#  define VROOM_SK_MODERN_GRADIENT 0
+#endif
+#pragma clang diagnostic pop
+
+namespace vroom {
+
+sk_sp<SkShader> linear_alpha_ramp(const SkPoint pts[2],
+                                  SkColor base,
+                                  float a0,
+                                  float a1) {
+#if VROOM_SK_MODERN_GRADIENT
+    const float r = SkColorGetR(base) / 255.f;
+    const float g = SkColorGetG(base) / 255.f;
+    const float b = SkColorGetB(base) / 255.f;
+    const SkColor4f colors[2] = {SkColor4f{r, g, b, a0}, SkColor4f{r, g, b, a1}};
+    const SkGradient::Colors grad_colors(
+        SkSpan<const SkColor4f>(colors, 2), SkTileMode::kClamp);
+    const SkGradient grad(grad_colors, SkGradient::Interpolation{});
+    return SkShaders::LinearGradient(pts, grad);
+#else
+    const auto to_u8 = [](float a) {
+        return static_cast<U8CPU>(a * 255.f + 0.5f);
+    };
+    const SkColor colors[2] = {SkColorSetA(base, to_u8(a0)),
+                               SkColorSetA(base, to_u8(a1))};
+    return SkGradientShader::MakeLinear(pts, colors, nullptr, 2,
+                                        SkTileMode::kClamp);
+#endif
+}
+
+}  // namespace vroom

package/cpp/_core_src/gradient.h

@@ -0,0 +1,31 @@
+// Linear-gradient helper shared by the layers that fade a fill out.
+//
+// Skia's linear-gradient API differs across the Skia versions we build against:
+// the WASM build uses a newer Skia (SkGradient.h + SkShaders::LinearGradient),
+// while react-native-skia bundles an older one (SkGradientShader::MakeLinear).
+// Neither ships both headers, so the implementation selects whichever is present
+// and callers get one signature regardless of platform.
+
+#pragma once
+
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wdocumentation"
+#include "include/core/SkColor.h"
+#include "include/core/SkRefCnt.h"
+#pragma clang diagnostic pop
+
+struct SkPoint;
+class SkShader;
+
+namespace vroom {
+
+// A gradient along pts[0] -> pts[1] holding `base`'s RGB while ramping alpha
+// from `a0` to `a1`. RGB is held constant on purpose: interpolating toward a
+// transparent black instead would darken the faded end into a grey smear.
+// Clamps at both ends, so the shader can safely cover more than the fill does.
+sk_sp<SkShader> linear_alpha_ramp(const SkPoint pts[2],
+                                  SkColor base,
+                                  float a0,
+                                  float a1);
+
+}  // namespace vroom