react-native-tvos 0.83.2-0 → 0.84.0-0

package/ReactCommon/react/runtime/TimerManager.cpp

@@ -8,7 +8,6 @@
 #include "TimerManager.h"
 
 #include <cxxreact/TraceSection.h>
-#include <react/featureflags/ReactNativeFeatureFlags.h>
 
 #include <cmath>
 #include <utility>
@@ -57,44 +56,21 @@ TimerManager::TimerManager(
     std::unique_ptr<PlatformTimerRegistry> platformTimerRegistry) noexcept
     : platformTimerRegistry_(std::move(platformTimerRegistry)) {}
 
-void TimerManager::setRuntimeExecutor(
-    RuntimeExecutor runtimeExecutor) noexcept {
-  runtimeExecutor_ = std::move(runtimeExecutor);
+TimerManager::~TimerManager() noexcept {
+  quit();
 }
 
-TimerHandle TimerManager::createReactNativeMicrotask(
-    jsi::Function&& callback,
-    std::vector<jsi::Value>&& args) {
-  // Get the id for the callback.
-  TimerHandle timerID = timerIndex_++;
-  timers_.emplace(
-      std::piecewise_construct,
-      std::forward_as_tuple(timerID),
-      std::forward_as_tuple(
-          std::move(callback), std::move(args), /* repeat */ false));
-
-  reactNativeMicrotasksQueue_.push_back(timerID);
-  return timerID;
+void TimerManager::quit() {
+  if (platformTimerRegistry_ == nullptr) {
+    return;
+  }
+  platformTimerRegistry_->quit();
+  platformTimerRegistry_ = nullptr;
 }
 
-void TimerManager::callReactNativeMicrotasks(jsi::Runtime& runtime) {
-  std::vector<TimerHandle> reactNativeMicrotasksQueue;
-  while (!reactNativeMicrotasksQueue_.empty()) {
-    reactNativeMicrotasksQueue.clear();
-    reactNativeMicrotasksQueue.swap(reactNativeMicrotasksQueue_);
-
-    for (auto reactNativeMicrotaskID : reactNativeMicrotasksQueue) {
-      // ReactNativeMicrotasks can clear other scheduled reactNativeMicrotasks.
-      auto it = timers_.find(reactNativeMicrotaskID);
-      if (it != timers_.end()) {
-        it->second.invoke(runtime);
-
-        // Invoking a timer has the potential to delete it. Do not re-use the
-        // existing iterator to erase it from the map.
-        timers_.erase(reactNativeMicrotaskID);
-      }
-    }
-  }
+void TimerManager::setRuntimeExecutor(
+    RuntimeExecutor runtimeExecutor) noexcept {
+  runtimeExecutor_ = std::move(runtimeExecutor);
 }
 
 TimerHandle TimerManager::createTimer(
@@ -156,24 +132,6 @@ TimerHandle TimerManager::createRecurringTimer(
   return timerID;
 }
 
-void TimerManager::deleteReactNativeMicrotask(
-    jsi::Runtime& runtime,
-    TimerHandle timerHandle) {
-  if (timerHandle < 0) {
-    throw jsi::JSError(
-        runtime, "clearReactNativeMicrotask was called with an invalid handle");
-  }
-
-  auto it = std::find(
-      reactNativeMicrotasksQueue_.begin(),
-      reactNativeMicrotasksQueue_.end(),
-      timerHandle);
-  if (it != reactNativeMicrotasksQueue_.end()) {
-    reactNativeMicrotasksQueue_.erase(it);
-    timers_.erase(timerHandle);
-  }
-}
-
 void TimerManager::deleteTimer(jsi::Runtime& runtime, TimerHandle timerHandle) {
   if (timerHandle < 0) {
     throw jsi::JSError(runtime, "clearTimeout called with an invalid handle");

package/ReactCommon/react/runtime/TimerManager.h

@@ -8,7 +8,6 @@
 #pragma once
 
 #include <ReactCommon/RuntimeExecutor.h>
-#include <cstdint>
 #include <unordered_map>
 #include <vector>
 
@@ -47,20 +46,21 @@ struct TimerCallback {
 class TimerManager {
  public:
   explicit TimerManager(std::unique_ptr<PlatformTimerRegistry> platformTimerRegistry) noexcept;
+  TimerManager(const TimerManager &) = delete;
+  TimerManager(TimerManager &&) = delete;
+  TimerManager &operator=(const TimerManager &) = delete;
+  TimerManager &operator=(TimerManager &&) = delete;
+  ~TimerManager() noexcept;
 
   void setRuntimeExecutor(RuntimeExecutor runtimeExecutor) noexcept;
 
-  void callReactNativeMicrotasks(jsi::Runtime &runtime);
-
   void callTimer(TimerHandle handle);
 
   void attachGlobals(jsi::Runtime &runtime);
 
- private:
-  TimerHandle createReactNativeMicrotask(jsi::Function &&callback, std::vector<jsi::Value> &&args);
-
-  void deleteReactNativeMicrotask(jsi::Runtime &runtime, TimerHandle handle);
+  void quit();
 
+ private:
   TimerHandle createTimer(
       jsi::Function &&callback,
       std::vector<jsi::Value> &&args,
@@ -88,11 +88,6 @@ class TimerManager {
   // As per WHATWG HTML 8.6.1 (Timers) ids must be greater than zero, i.e. start
   // at 1
   TimerHandle timerIndex_{1};
-
-  // The React Native microtask queue is used to back public APIs including
-  // `queueMicrotask`, `clearImmediate`, and `setImmediate` (which is used by
-  // the Promise polyfill) when the JSVM microtask mechanism is not used.
-  std::vector<TimerHandle> reactNativeMicrotasksQueue_;
 };
 
 } // namespace facebook::react

package/ReactCommon/react/runtime/hermes/CMakeLists.txt

@@ -35,8 +35,4 @@ if(${CMAKE_BUILD_TYPE} MATCHES Debug OR REACT_NATIVE_DEBUG_OPTIMIZED)
                 PRIVATE
                 -DHERMES_ENABLE_DEBUGGER=1
         )
-
-        if (HERMES_V1_ENABLED)
-                target_compile_options(bridgelesshermes PRIVATE -DHERMES_V1_ENABLED=1)
-        endif()
 endif()

package/ReactCommon/react/runtime/platform/ios/ReactCommon/RCTHost.h

@@ -18,6 +18,7 @@ NS_ASSUME_NONNULL_BEGIN
 @class RCTFabricSurface;
 @class RCTHost;
 @class RCTModuleRegistry;
+@class RCTBundleConfiguration;
 @class RCTDevMenuConfiguration;
 
 @protocol RCTTurboModuleManagerDelegate;
@@ -65,8 +66,8 @@ typedef std::shared_ptr<facebook::react::JSRuntimeFactory> (^RCTHostJSEngineProv
                turboModuleManagerDelegate:(id<RCTTurboModuleManagerDelegate>)turboModuleManagerDelegate
                          jsEngineProvider:(RCTHostJSEngineProvider)jsEngineProvider
                             launchOptions:(nullable NSDictionary *)launchOptions
-                     devMenuConfiguration:(RCTDevMenuConfiguration *__nullable)devMenuConfiguration
-    NS_DESIGNATED_INITIALIZER;
+                      bundleConfiguration:(RCTBundleConfiguration *)bundleConfiguration
+                     devMenuConfiguration:(RCTDevMenuConfiguration *)devMenuConfiguration NS_DESIGNATED_INITIALIZER;
 
 - (instancetype)initWithBundleURLProvider:(RCTHostBundleURLProvider)provider
                              hostDelegate:(id<RCTHostDelegate>)hostDelegate

package/ReactCommon/react/runtime/platform/ios/ReactCommon/RCTHost.mm

@@ -152,10 +152,6 @@ class RCTHostHostTargetDelegate : public facebook::react::jsinspector_modern::Ho
                    launchOptions:launchOptions];
 }
 
-/**
- Host initialization should not be resource intensive. A host may be created before any intention of using React Native
- has been expressed.
- */
 - (instancetype)initWithBundleURLProvider:(RCTHostBundleURLProvider)provider
                              hostDelegate:(id<RCTHostDelegate>)hostDelegate
                turboModuleManagerDelegate:(id<RCTTurboModuleManagerDelegate>)turboModuleManagerDelegate
@@ -167,24 +163,32 @@ class RCTHostHostTargetDelegate : public facebook::react::jsinspector_modern::Ho
               turboModuleManagerDelegate:turboModuleManagerDelegate
                         jsEngineProvider:jsEngineProvider
                            launchOptions:launchOptions
+                     bundleConfiguration:[RCTBundleConfiguration defaultConfiguration]
                     devMenuConfiguration:[RCTDevMenuConfiguration defaultConfiguration]];
 }
 
+/**
+ Host initialization should not be resource intensive. A host may be created before any intention of using React Native
+ has been expressed.
+ */
 - (instancetype)initWithBundleURLProvider:(RCTHostBundleURLProvider)provider
                              hostDelegate:(id<RCTHostDelegate>)hostDelegate
                turboModuleManagerDelegate:(id<RCTTurboModuleManagerDelegate>)turboModuleManagerDelegate
                          jsEngineProvider:(RCTHostJSEngineProvider)jsEngineProvider
                             launchOptions:(nullable NSDictionary *)launchOptions
+                      bundleConfiguration:(RCTBundleConfiguration *)bundleConfiguration
                      devMenuConfiguration:(RCTDevMenuConfiguration *)devMenuConfiguration
 {
   if (self = [super init]) {
     _hostDelegate = hostDelegate;
     _turboModuleManagerDelegate = turboModuleManagerDelegate;
-    _bundleManager = [RCTBundleManager new];
+    _bundleManager = [[RCTBundleManager alloc] initWithBundleConfig:bundleConfiguration];
     _moduleRegistry = [RCTModuleRegistry new];
     _jsEngineProvider = [jsEngineProvider copy];
     _launchOptions = [launchOptions copy];
 
+    [self setBundleURLProvider:provider];
+
     __weak RCTHost *weakSelf = self;
     auto bundleURLGetter = ^NSURL *() {
       RCTHost *strongSelf = weakSelf;
@@ -450,7 +454,7 @@ class RCTHostHostTargetDelegate : public facebook::react::jsinspector_modern::Ho
   // Sanitize the bundle URL
   _bundleURL = [RCTConvert NSURL:_bundleURL.absoluteString];
 
-  // Update the global bundle URLq
+  // Update the global bundle URL
   RCTReloadCommandSetBundleURL(_bundleURL);
 }
 

package/ReactCommon/yoga/yoga/algorithm/FlexDirection.h

@@ -60,9 +60,9 @@ inline PhysicalEdge flexStartEdge(FlexDirection flexDirection) {
       return PhysicalEdge::Left;
     case FlexDirection::RowReverse:
       return PhysicalEdge::Right;
+    default:
+      fatalWithMessage("Invalid FlexDirection");
   }
-
-  fatalWithMessage("Invalid FlexDirection");
 }
 
 inline PhysicalEdge flexEndEdge(FlexDirection flexDirection) {
@@ -75,9 +75,9 @@ inline PhysicalEdge flexEndEdge(FlexDirection flexDirection) {
       return PhysicalEdge::Right;
     case FlexDirection::RowReverse:
       return PhysicalEdge::Left;
+    default:
+      fatalWithMessage("Invalid FlexDirection");
   }
-
-  fatalWithMessage("Invalid FlexDirection");
 }
 
 inline PhysicalEdge inlineStartEdge(
@@ -112,9 +112,9 @@ inline Dimension dimension(FlexDirection flexDirection) {
       return Dimension::Width;
     case FlexDirection::RowReverse:
       return Dimension::Width;
+    default:
+      fatalWithMessage("Invalid FlexDirection");
   }
-
-  fatalWithMessage("Invalid FlexDirection");
 }
 
 } // namespace facebook::yoga

package/ReactCommon/yoga/yoga/algorithm/SizingMode.h

@@ -52,9 +52,9 @@ inline MeasureMode measureMode(SizingMode mode) {
       return MeasureMode::Undefined;
     case SizingMode::FitContent:
       return MeasureMode::AtMost;
+    default:
+      fatalWithMessage("Invalid SizingMode");
   }
-
-  fatalWithMessage("Invalid SizingMode");
 }
 
 inline SizingMode sizingMode(MeasureMode mode) {
@@ -65,9 +65,9 @@ inline SizingMode sizingMode(MeasureMode mode) {
       return SizingMode::MaxContent;
     case MeasureMode::AtMost:
       return SizingMode::FitContent;
+    default:
+      fatalWithMessage("Invalid MeasureMode");
   }
-
-  fatalWithMessage("Invalid MeasureMode");
 }
 
 } // namespace facebook::yoga

package/ReactCommon/yoga/yoga/style/Style.h

@@ -673,9 +673,9 @@ class YG_EXPORT Style {
         return computeRightEdge(position_, direction);
       case PhysicalEdge::Bottom:
         return computeBottomEdge(position_);
+      default:
+        fatalWithMessage("Invalid physical edge");
     }
-
-    fatalWithMessage("Invalid physical edge");
   }
 
   Style::Length computeMargin(PhysicalEdge edge, Direction direction) const {
@@ -688,9 +688,9 @@ class YG_EXPORT Style {
         return computeRightEdge(margin_, direction);
       case PhysicalEdge::Bottom:
         return computeBottomEdge(margin_);
+      default:
+        fatalWithMessage("Invalid physical edge");
     }
-
-    fatalWithMessage("Invalid physical edge");
   }
 
   Style::Length computePadding(PhysicalEdge edge, Direction direction) const {
@@ -703,9 +703,9 @@ class YG_EXPORT Style {
         return computeRightEdge(padding_, direction);
       case PhysicalEdge::Bottom:
         return computeBottomEdge(padding_);
+      default:
+        fatalWithMessage("Invalid physical edge");
     }
-
-    fatalWithMessage("Invalid physical edge");
   }
 
   Style::Length computeBorder(PhysicalEdge edge, Direction direction) const {
@@ -718,9 +718,9 @@ class YG_EXPORT Style {
         return computeRightEdge(border_, direction);
       case PhysicalEdge::Bottom:
         return computeBottomEdge(border_);
+      default:
+        fatalWithMessage("Invalid physical edge");
     }
-
-    fatalWithMessage("Invalid physical edge");
   }
 
   Direction direction_ : bitCount<Direction>() = Direction::Inherit;

package/ReactCommon/yoga/yoga/style/StyleLength.h

@@ -74,7 +74,14 @@ class StyleLength {
   }
 
   constexpr FloatOptional resolve(float referenceLength) {
+#ifdef __clang__
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wswitch-enum"
+#endif
     switch (unit_) {
+#ifdef __clang__
+#pragma clang diagnostic pop
+#endif
       case Unit::Point:
         return value_;
       case Unit::Percent:

package/ReactCommon/yoga/yoga/style/StyleSizeLength.h

@@ -99,7 +99,14 @@ class StyleSizeLength {
   }
 
   constexpr FloatOptional resolve(float referenceLength) {
+#ifdef __clang__
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wswitch-enum"
+#endif
     switch (unit_) {
+#ifdef __clang__
+#pragma clang diagnostic pop
+#endif
       case Unit::Point:
         return value_;
       case Unit::Percent:

package/flow/HermesInternalType.js

@@ -59,7 +59,7 @@ declare type $HermesInternalType = {
   +getRuntimeProperties?: () => {
     'OSS Release Version': string,
     Build: string,
-    [string]: mixed,
+    [string]: unknown,
   },
 
   /**
@@ -93,10 +93,10 @@ declare type $HermesInternalType = {
    */
   +enablePromiseRejectionTracker?: (
     options: ?{
-      whitelist?: ?Array<mixed>,
+      whitelist?: ?Array<unknown>,
       allRejections?: ?boolean,
-      onUnhandled?: ?(number, mixed) => void,
-      onHandled?: ?(number, mixed) => void,
+      onUnhandled?: ?(number, unknown) => void,
+      onHandled?: ?(number, unknown) => void,
     },
   ) => void,
 
@@ -108,7 +108,7 @@ declare type $HermesInternalType = {
   /**
    * Enqueue a JavaScript callback function as a Job into the engine Job queue.
    */
-  +enqueueJob?: <TArguments: Array<mixed>>(
-    jobCallback: (...args: TArguments) => mixed,
+  +enqueueJob?: <TArguments: Array<unknown>>(
+    jobCallback: (...args: TArguments) => unknown,
   ) => void,
 };

package/flow/bom.js.flow

@@ -25,34 +25,38 @@ type DevToolsColor =
   | 'warning'
   | 'error';
 
+declare interface ConsoleTask {
+  run<T>(f: () => T): T;
+}
+
 // $FlowExpectedError[libdef-override] Flow core definitions are incomplete.
 declare var console: {
   // Logging
-  log(...data: $ReadOnlyArray<mixed>): void,
-  trace(...data: $ReadOnlyArray<mixed>): void,
-  debug(...data: $ReadOnlyArray<mixed>): void,
-  info(...data: $ReadOnlyArray<mixed>): void,
-  warn(...data: $ReadOnlyArray<mixed>): void,
-  error(...data: $ReadOnlyArray<mixed>): void,
+  log(...data: $ReadOnlyArray<unknown>): void,
+  trace(...data: $ReadOnlyArray<unknown>): void,
+  debug(...data: $ReadOnlyArray<unknown>): void,
+  info(...data: $ReadOnlyArray<unknown>): void,
+  warn(...data: $ReadOnlyArray<unknown>): void,
+  error(...data: $ReadOnlyArray<unknown>): void,
 
   // Grouping
-  group(...data: $ReadOnlyArray<mixed>): void,
-  groupCollapsed(...data: $ReadOnlyArray<mixed>): void,
+  group(...data: $ReadOnlyArray<unknown>): void,
+  groupCollapsed(...data: $ReadOnlyArray<unknown>): void,
   groupEnd(): void,
 
   // Printing
   table(
     tabularData:
-      | $ReadOnly<{[key: string]: mixed, ...}>
-      | $ReadOnlyArray<$ReadOnly<{[key: string]: mixed, ...}>>
-      | $ReadOnlyArray<$ReadOnlyArray<mixed>>,
+      | $ReadOnly<{[key: string]: unknown, ...}>
+      | $ReadOnlyArray<$ReadOnly<{[key: string]: unknown, ...}>>
+      | $ReadOnlyArray<$ReadOnlyArray<unknown>>,
   ): void,
-  dir(...data: $ReadOnlyArray<mixed>): void,
-  dirxml(...data: $ReadOnlyArray<mixed>): void,
+  dir(...data: $ReadOnlyArray<unknown>): void,
+  dirxml(...data: $ReadOnlyArray<unknown>): void,
   clear(): void,
 
   // Utilities
-  assert(condition: mixed, ...data: $ReadOnlyArray<mixed>): void,
+  assert(condition: unknown, ...data: $ReadOnlyArray<unknown>): void,
 
   // Profiling
   profile(name?: string): void,
@@ -72,9 +76,12 @@ declare var console: {
     trackName?: string,
     trackGroup?: string,
     color?: DevToolsColor,
-    detail?: {[string]: mixed},
+    detail?: {[string]: unknown},
   ): void,
 
+  // Stack tagging
+  createTask(label: string): ConsoleTask,
+
   ...
 };
 
@@ -107,12 +114,12 @@ declare class PerformanceEntry {
 // https://w3c.github.io/user-timing/#performancemark
 declare class PerformanceMark extends PerformanceEntry {
   constructor(name: string, markOptions?: PerformanceMarkOptions): void;
-  +detail: mixed;
+  +detail: unknown;
 }
 
 // https://w3c.github.io/user-timing/#performancemeasure
 declare class PerformanceMeasure extends PerformanceEntry {
-  +detail: mixed;
+  +detail: unknown;
 }
 
 // https://w3c.github.io/server-timing/#the-performanceservertiming-interface
@@ -170,12 +177,12 @@ declare class PerformanceLongTaskTiming extends PerformanceEntry {
 
 // https://www.w3.org/TR/user-timing/#extensions-performance-interface
 declare type PerformanceMarkOptions = {
-  detail?: mixed,
+  detail?: unknown,
   startTime?: number,
 };
 
 declare type PerformanceMeasureOptions = {
-  detail?: mixed,
+  detail?: unknown,
   duration?: number,
   end?: number | string,
   start?: number | string,
@@ -242,7 +249,7 @@ declare class PerformanceObserver {
     callback: (
       entries: PerformanceObserverEntryList,
       observer: PerformanceObserver,
-    ) => mixed,
+    ) => unknown,
   ): void;
 
   disconnect(): void;
@@ -338,10 +345,10 @@ declare class WebSocket extends EventTarget {
   CONNECTING: 0;
   constructor(url: string, protocols?: string | Array<string>): void;
   extensions: string;
-  onclose: (ev: CloseEvent) => mixed;
-  onerror: (ev: $FlowFixMe) => mixed;
-  onmessage: (ev: MessageEvent) => mixed;
-  onopen: (ev: $FlowFixMe) => mixed;
+  onclose: (ev: CloseEvent) => unknown;
+  onerror: (ev: $FlowFixMe) => unknown;
+  onmessage: (ev: MessageEvent) => unknown;
+  onopen: (ev: $FlowFixMe) => unknown;
   static OPEN: 1;
   OPEN: 1;
   protocol: string;
@@ -371,7 +378,7 @@ declare class XMLHttpRequest extends EventTarget {
   onloadend: ProgressEventHandler;
   onloadstart: ProgressEventHandler;
   onprogress: ProgressEventHandler;
-  onreadystatechange: (ev: $FlowFixMe) => mixed;
+  onreadystatechange: (ev: $FlowFixMe) => unknown;
   ontimeout: ProgressEventHandler;
   open(
     method: string,
@@ -434,7 +441,7 @@ declare class Headers {
       value: string,
       name: string,
       headers: Headers,
-    ) => mixed,
+    ) => unknown,
     thisArg: This,
   ): void;
   get(name: string): null | string;
@@ -464,7 +471,7 @@ declare class URLSearchParams {
       value: string,
       name: string,
       params: URLSearchParams,
-    ) => mixed,
+    ) => unknown,
     thisArg: This,
   ): void;
   get(name: string): null | string;
@@ -604,7 +611,7 @@ declare class AbortController {
 declare class AbortSignal extends EventTarget {
   abort(reason?: $FlowFixMe): AbortSignal;
   +aborted: boolean;
-  onabort: (event: Event) => mixed;
+  onabort: (event: Event) => unknown;
   +reason: $FlowFixMe;
   throwIfAborted(): void;
   timeout(time: number): AbortSignal;

package/flow/cssom.js.flow

@@ -524,9 +524,9 @@ declare class Animation extends EventTarget {
   finish(): void;
   +finished: Promise<Animation>;
   id: string;
-  oncancel: ?(ev: AnimationPlaybackEvent) => mixed;
-  onfinish: ?(ev: AnimationPlaybackEvent) => mixed;
-  onremove: ?(ev: AnimationPlaybackEvent) => mixed;
+  oncancel: ?(ev: AnimationPlaybackEvent) => unknown;
+  onfinish: ?(ev: AnimationPlaybackEvent) => unknown;
+  onremove: ?(ev: AnimationPlaybackEvent) => unknown;
   pause(): void;
   +pending: boolean;
   persist(): void;