react-native-tvos 0.83.2-0 → 0.84.0-0

package/ReactAndroid/src/main/java/com/facebook/react/devsupport/interfaces/DevLoadingViewManager.kt

@@ -11,7 +11,12 @@ package com.facebook.react.devsupport.interfaces
 public interface DevLoadingViewManager {
   public fun showMessage(message: String)
 
-  public fun showMessage(message: String, color: Double?, backgroundColor: Double?)
+  public fun showMessage(
+      message: String,
+      color: Double?,
+      backgroundColor: Double?,
+      dismissButton: Boolean?,
+  )
 
   public fun updateProgress(status: String?, done: Int?, total: Int?)
 

package/ReactAndroid/src/main/java/com/facebook/react/devsupport/interfaces/DevSupportManager.kt

@@ -19,8 +19,8 @@ import java.io.File
 
 /**
  * Interface for accessing and interacting with development features. In dev mode, use the
- * implementation [com.facebook.react.devsupport.BridgeDevSupportManager]. In production mode, use
- * the dummy implementation [com.facebook.react.devsupport.ReleaseDevSupportManager].
+ * implementation [com.facebook.react.devsupport.BridgelessDevSupportManager]. In production mode,
+ * use the dummy implementation [com.facebook.react.devsupport.ReleaseDevSupportManager].
  */
 public interface DevSupportManager : JSExceptionHandler {
 

package/ReactAndroid/src/main/java/com/facebook/react/devsupport/interfaces/RedBoxHandler.kt

@@ -11,8 +11,8 @@ import android.content.Context
 import android.text.SpannedString
 
 /**
- * Interface used by [com.facebook.react.devsupport.BridgeDevSupportManager] to allow interception
- * on any redboxes during development and handling the information from the redbox. The
+ * Interface used by [com.facebook.react.devsupport.interfaces.DevSupportManager] to allow
+ * interception on any redboxes during development and handling the information from the redbox. The
  * implementation should be passed by setRedBoxHandler in ReactInstanceManager.
  */
 public interface RedBoxHandler {

package/ReactAndroid/src/main/java/com/facebook/react/devsupport/perfmonitor/PerfMonitorInspectorTargetBinding.kt

@@ -7,7 +7,7 @@
 
 package com.facebook.react.devsupport.perfmonitor
 
-import com.facebook.react.devsupport.interfaces.TracingState
+import com.facebook.react.devsupport.inspector.TracingState
 
 /**
  * [Experimental] Interface implemented by [com.facebook.react.runtime.ReactHostInspectorTarget]

package/ReactAndroid/src/main/java/com/facebook/react/devsupport/perfmonitor/PerfMonitorOverlayManager.kt

@@ -7,8 +7,10 @@
 
 package com.facebook.react.devsupport.perfmonitor
 
+import android.os.Handler
+import android.os.Looper
 import com.facebook.react.bridge.UiThreadUtil
-import com.facebook.react.devsupport.interfaces.TracingState
+import com.facebook.react.devsupport.inspector.TracingState
 
 internal class PerfMonitorOverlayManager(
     private val devHelper: PerfMonitorDevHelper,
@@ -21,8 +23,9 @@ internal class PerfMonitorOverlayManager(
     get() = enabled
 
   private var view: PerfMonitorOverlayView? = null
-  private var tracingState: TracingState = TracingState.ENABLEDINCDPMODE
+  private var tracingState: TracingState = TracingState.ENABLED_IN_CDP_MODE
   private var perfIssueCount: Int = 0
+  private val handler = Handler(Looper.getMainLooper())
 
   /** Enable the Perf Monitor overlay. */
   fun enable() {
@@ -75,24 +78,42 @@ internal class PerfMonitorOverlayManager(
     tracingState = state
     if (state != TracingState.DISABLED) {
       perfIssueCount = 0
+      handler.removeCallbacksAndMessages(null)
     }
     UiThreadUtil.runOnUiThread {
       view?.updateRecordingState(state)
       view?.updatePerfIssueCount(perfIssueCount)
-      view?.show()
+      if (state == TracingState.ENABLED_IN_CDP_MODE) {
+        view?.hide()
+      } else {
+        view?.show()
+      }
     }
   }
 
   override fun onPerfIssueAdded(name: String) {
+    perfIssueCount++
+
     UiThreadUtil.runOnUiThread {
-      view?.updatePerfIssueCount(++perfIssueCount)
+      view?.updatePerfIssueCount(perfIssueCount)
       view?.show()
     }
+
+    handler.postDelayed(
+        {
+          perfIssueCount--
+          UiThreadUtil.runOnUiThread {
+            view?.updatePerfIssueCount(perfIssueCount)
+            view?.show()
+          }
+        },
+        PERF_ISSUE_EXPIRY_MS,
+    )
   }
 
   private fun handleRecordingButtonPress() {
     when (tracingState) {
-      TracingState.ENABLEDINBACKGROUNDMODE -> {
+      TracingState.ENABLED_IN_BACKGROUND_MODE -> {
         devHelper.inspectorTarget?.let { target ->
           if (!target.pauseAndAnalyzeBackgroundTrace()) {
             onRequestOpenDevTools()
@@ -102,7 +123,11 @@ internal class PerfMonitorOverlayManager(
       TracingState.DISABLED -> {
         devHelper.inspectorTarget?.resumeBackgroundTrace()
       }
-      TracingState.ENABLEDINCDPMODE -> Unit
+      TracingState.ENABLED_IN_CDP_MODE -> Unit
     }
   }
+
+  companion object {
+    private const val PERF_ISSUE_EXPIRY_MS = 20_000L
+  }
 }

package/ReactAndroid/src/main/java/com/facebook/react/devsupport/perfmonitor/PerfMonitorOverlayView.kt

@@ -21,7 +21,7 @@ import android.widget.TextView
 import androidx.core.view.ViewCompat
 import androidx.core.view.WindowInsetsCompat
 import com.facebook.react.R
-import com.facebook.react.devsupport.interfaces.TracingState
+import com.facebook.react.devsupport.inspector.TracingState
 import com.facebook.react.uimanager.DisplayMetricsHolder
 import com.facebook.react.uimanager.PixelUtil
 
@@ -50,12 +50,12 @@ internal class PerfMonitorOverlayView(
   }
 
   fun updateRecordingState(state: TracingState) {
-    if (state == TracingState.ENABLEDINCDPMODE) {
+    if (state == TracingState.ENABLED_IN_CDP_MODE) {
       dialog.hide()
       return
     }
 
-    if (state == TracingState.ENABLEDINBACKGROUNDMODE) {
+    if (state == TracingState.ENABLED_IN_BACKGROUND_MODE) {
       (statusIndicator.background as GradientDrawable).setColor(Color.RED)
       statusLabel.text = "Profiling Active"
       tooltipLabel.text =
@@ -120,12 +120,12 @@ internal class PerfMonitorOverlayView(
           setTextColor(Color.WHITE)
           typeface = TYPEFACE_BOLD
           val alertDrawable =
-              context.getDrawable(android.R.drawable.ic_dialog_alert)?.apply {
+              context.getDrawable(R.drawable.ic_perf_issue)?.apply {
                 setBounds(
                     0,
                     1,
-                    dpToPx(TEXT_SIZE_PRIMARY).toInt(),
-                    dpToPx(TEXT_SIZE_PRIMARY).toInt() + 1,
+                    dpToPx(ISSUE_ICON_SIZE).toInt(),
+                    dpToPx(ISSUE_ICON_SIZE).toInt() + 1,
                 )
               }
           setCompoundDrawables(alertDrawable, null, null, null)
@@ -214,6 +214,7 @@ internal class PerfMonitorOverlayView(
     private val COLOR_OVERLAY_BORDER = Color.parseColor("#6C6C6C")
     private val TEXT_SIZE_PRIMARY = 12f
     private val TEXT_SIZE_ACCESSORY = 10f
+    private val ISSUE_ICON_SIZE = 15f
     private val TYPEFACE_BOLD = Typeface.create("sans-serif", Typeface.BOLD)
   }
 }

package/ReactAndroid/src/main/java/com/facebook/react/devsupport/perfmonitor/PerfMonitorUpdateListener.kt

@@ -7,7 +7,7 @@
 
 package com.facebook.react.devsupport.perfmonitor
 
-import com.facebook.react.devsupport.interfaces.TracingState
+import com.facebook.react.devsupport.inspector.TracingState
 
 /** [Experimental] An interface for subscribing to updates for the V2 Perf Monitor. */
 internal interface PerfMonitorUpdateListener {

package/ReactAndroid/src/main/java/com/facebook/react/fabric/FabricUIManager.java

@@ -1485,7 +1485,7 @@ public class FabricUIManager
         mBinding.driveCxxAnimations();
       }
 
-      if (mBinding != null) {
+      if (!ReactNativeFeatureFlags.disableViewPreallocationAndroid() && mBinding != null) {
         mBinding.drainPreallocateViewsQueue();
       }
 

package/ReactAndroid/src/main/java/com/facebook/react/fabric/mounting/SurfaceMountingManager.java

@@ -83,7 +83,7 @@ public class SurfaceMountingManager {
       new ConcurrentHashMap<>(); // any thread
   private final Queue<MountItem> mOnViewAttachMountItems = new ArrayDeque<>();
   private JSResponderHandler mJSResponderHandler;
-  private ViewManagerRegistry mViewManagerRegistry;
+  private final ViewManagerRegistry mViewManagerRegistry;
   private RootViewManager mRootViewManager;
   private MountItemExecutor mMountItemExecutor;
 
@@ -336,6 +336,7 @@ public class SurfaceMountingManager {
           mMountItemExecutor = null;
           mThemedReactContext = null;
           mOnViewAttachMountItems.clear();
+          mTagToSynchronousMountProps.clear();
 
           FLog.e(TAG, "Surface [" + mSurfaceId + "] was stopped on SurfaceMountingManager.");
         };

package/ReactAndroid/src/main/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlags.kt

@@ -4,7 +4,7 @@
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
  *
- * @generated SignedSource<<f350f756268554418a046d0793ee0146>>
+ * @generated SignedSource<<9406085adbc0685b473c868a27085cf8>>
  */
 
 /**
@@ -48,12 +48,6 @@ public object ReactNativeFeatureFlags {
   @JvmStatic
   public fun cxxNativeAnimatedEnabled(): Boolean = accessor.cxxNativeAnimatedEnabled()
 
-  /**
-   * Removes JS sync at end of native animation
-   */
-  @JvmStatic
-  public fun cxxNativeAnimatedRemoveJsSync(): Boolean = accessor.cxxNativeAnimatedRemoveJsSync()
-
   /**
    * Dispatch view commands in mount item order.
    */
@@ -61,10 +55,10 @@ public object ReactNativeFeatureFlags {
   public fun disableEarlyViewCommandExecution(): Boolean = accessor.disableEarlyViewCommandExecution()
 
   /**
-   * Prevents use of Fabric commit in C++ Animated implementation
+   * Force disable view preallocation for images triggered from createNode off the main thread on Android
    */
   @JvmStatic
-  public fun disableFabricCommitInCXXAnimated(): Boolean = accessor.disableFabricCommitInCXXAnimated()
+  public fun disableImageViewPreallocationAndroid(): Boolean = accessor.disableImageViewPreallocationAndroid()
 
   /**
    * Prevent FabricMountingManager from reordering mountItems, which may lead to invalid state on the UI thread
@@ -78,12 +72,24 @@ public object ReactNativeFeatureFlags {
   @JvmStatic
   public fun disableOldAndroidAttachmentMetricsWorkarounds(): Boolean = accessor.disableOldAndroidAttachmentMetricsWorkarounds()
 
+  /**
+   * Force disable subview clipping for ReactViewGroup on Android
+   */
+  @JvmStatic
+  public fun disableSubviewClippingAndroid(): Boolean = accessor.disableSubviewClippingAndroid()
+
   /**
    * Turns off the global measurement cache used by TextLayoutManager on Android.
    */
   @JvmStatic
   public fun disableTextLayoutManagerCacheAndroid(): Boolean = accessor.disableTextLayoutManagerCacheAndroid()
 
+  /**
+   * Force disable view preallocation triggered from createNode off the main thread on Android
+   */
+  @JvmStatic
+  public fun disableViewPreallocationAndroid(): Boolean = accessor.disableViewPreallocationAndroid()
+
   /**
    * When enabled, the accessibilityOrder prop will propagate to native platforms and define the accessibility order.
    */
@@ -96,6 +102,12 @@ public object ReactNativeFeatureFlags {
   @JvmStatic
   public fun enableAccumulatedUpdatesInRawPropsAndroid(): Boolean = accessor.enableAccumulatedUpdatesInRawPropsAndroid()
 
+  /**
+   * Enable antialiased border radius clipping for Android API 28 and below using manual masking with Porter-Duff compositing
+   */
+  @JvmStatic
+  public fun enableAndroidAntialiasedBorderRadiusClipping(): Boolean = accessor.enableAndroidAntialiasedBorderRadiusClipping()
+
   /**
    * Enables linear text rendering on Android wherever subpixel text rendering is enabled
    */
@@ -150,6 +162,12 @@ public object ReactNativeFeatureFlags {
   @JvmStatic
   public fun enableEagerRootViewAttachment(): Boolean = accessor.enableEagerRootViewAttachment()
 
+  /**
+   * When enabled, Android will disable Props 1.5 raw value merging when Props 2.0 is available.
+   */
+  @JvmStatic
+  public fun enableExclusivePropsUpdateAndroid(): Boolean = accessor.enableExclusivePropsUpdateAndroid()
+
   /**
    * This feature flag enables logs for Fabric.
    */
@@ -186,6 +204,12 @@ public object ReactNativeFeatureFlags {
   @JvmStatic
   public fun enableImagePrefetchingAndroid(): Boolean = accessor.enableImagePrefetchingAndroid()
 
+  /**
+   * When enabled, Android will build and initiate image prefetch requests on ImageShadowNode::layout and batch them together in a single JNI call
+   */
+  @JvmStatic
+  public fun enableImagePrefetchingJNIBatchingAndroid(): Boolean = accessor.enableImagePrefetchingJNIBatchingAndroid()
+
   /**
    * When enabled, Android will initiate image prefetch requested on ImageShadowNode::layout on the UI thread
    */
@@ -253,7 +277,7 @@ public object ReactNativeFeatureFlags {
   public fun enableNativeCSSParsing(): Boolean = accessor.enableNativeCSSParsing()
 
   /**
-   * Enable network event reporting hooks in each native platform through `NetworkReporter`. This flag should be combined with `enableResourceTimingAPI` and `fuseboxNetworkInspectionEnabled` to enable end-to-end reporting behaviour via the Web Performance API and CDP debugging respectively.
+   * Enable network event reporting hooks in each native platform through `NetworkReporter` (Web Perf APIs + CDP). This flag should be combined with `fuseboxNetworkInspectionEnabled` to enable Network CDP debugging.
    */
   @JvmStatic
   public fun enableNetworkEventReporting(): Boolean = accessor.enableNetworkEventReporting()
@@ -270,12 +294,6 @@ public object ReactNativeFeatureFlags {
   @JvmStatic
   public fun enablePropsUpdateReconciliationAndroid(): Boolean = accessor.enablePropsUpdateReconciliationAndroid()
 
-  /**
-   * Enables the reporting of network resource timings through `PerformanceObserver`.
-   */
-  @JvmStatic
-  public fun enableResourceTimingAPI(): Boolean = accessor.enableResourceTimingAPI()
-
   /**
    * When enabled, it will use SwiftUI for filter effects like blur on iOS.
    */
@@ -318,12 +336,6 @@ public object ReactNativeFeatureFlags {
   @JvmStatic
   public fun enableViewRecyclingForView(): Boolean = accessor.enableViewRecyclingForView()
 
-  /**
-   * Set clipping to drawingRect of ScrollView.
-   */
-  @JvmStatic
-  public fun enableVirtualViewClippingWithoutScrollViewClipping(): Boolean = accessor.enableVirtualViewClippingWithoutScrollViewClipping()
-
   /**
    * Enables the experimental version of `VirtualViewContainerState`.
    */
@@ -360,6 +372,12 @@ public object ReactNativeFeatureFlags {
   @JvmStatic
   public fun fixMappingOfEventPrioritiesBetweenFabricAndReact(): Boolean = accessor.fixMappingOfEventPrioritiesBetweenFabricAndReact()
 
+  /**
+   * Fix text clipping starting in Android 15 due to usage of useBoundsForWidth
+   */
+  @JvmStatic
+  public fun fixTextClippingAndroid15useBoundsForWidth(): Boolean = accessor.fixTextClippingAndroid15useBoundsForWidth()
+
   /**
    * Enable system assertion validating that Fusebox is configured with a single host. When set, the CDP backend will dynamically disable features (Perf and Network) in the event that multiple hosts are registered (undefined behaviour), and broadcast this over `ReactNativeApplication.systemStateChanged`.
    */
@@ -391,7 +409,7 @@ public object ReactNativeFeatureFlags {
   public fun overrideBySynchronousMountPropsAtMountingAndroid(): Boolean = accessor.overrideBySynchronousMountPropsAtMountingAndroid()
 
   /**
-   * Enable reporting Performance Issues (`detail.rnPerfIssue`). Displayed in the V2 Performance Monitor and the "Performance Issues" sub-panel in DevTools.
+   * Enable reporting Performance Issues (`detail.devtools.performanceIssue`). Displayed in the V2 Performance Monitor and the "Performance Issues" sub-panel in DevTools.
    */
   @JvmStatic
   public fun perfIssuesEnabled(): Boolean = accessor.perfIssuesEnabled()
@@ -421,70 +439,70 @@ public object ReactNativeFeatureFlags {
   public fun shouldPressibilityUseW3CPointerEventsForHover(): Boolean = accessor.shouldPressibilityUseW3CPointerEventsForHover()
 
   /**
-   * Do not emit touchcancel from Android ScrollView, instead native topScroll event will trigger responder transfer and terminate in RN renderer.
+   * Reset isClickable to false when recycling views on Android to avoid accessibility tools finding views with incorrect state after recycling.
    */
   @JvmStatic
-  public fun shouldTriggerResponderTransferOnScrollAndroid(): Boolean = accessor.shouldTriggerResponderTransferOnScrollAndroid()
+  public fun shouldResetClickableWhenRecyclingView(): Boolean = accessor.shouldResetClickableWhenRecyclingView()
 
   /**
-   * Skip activity identity assertion in ReactHostImpl::onHostPause()
+   * Reset OnClickListener to null when recycling views on Android to avoid accessibility tools finding views with incorrect state after recycling.
    */
   @JvmStatic
-  public fun skipActivityIdentityAssertionOnHostPause(): Boolean = accessor.skipActivityIdentityAssertionOnHostPause()
+  public fun shouldResetOnClickListenerWhenRecyclingView(): Boolean = accessor.shouldResetOnClickListenerWhenRecyclingView()
 
   /**
-   * A flag to tell Fabric to sweep active touches from JSTouchDispatcher in Android when a child native gesture is started.
+   * Fix BaseViewManager to properly set view.setEnabled() based on accessibilityState.disabled.
    */
   @JvmStatic
-  public fun sweepActiveTouchOnChildNativeGesturesAndroid(): Boolean = accessor.sweepActiveTouchOnChildNativeGesturesAndroid()
+  public fun shouldSetEnabledBasedOnAccessibilityState(): Boolean = accessor.shouldSetEnabledBasedOnAccessibilityState()
 
   /**
-   * Enables storing js caller stack when creating promise in native module. This is useful in case of Promise rejection and tracing the cause.
+   * Sets isClickable=true by default on all React Native views on Android to improve UI harvesting detection while maintaining focusable=false to preserve expected behavior.
    */
   @JvmStatic
-  public fun traceTurboModulePromiseRejectionsOnAndroid(): Boolean = accessor.traceTurboModulePromiseRejectionsOnAndroid()
+  public fun shouldSetIsClickableByDefault(): Boolean = accessor.shouldSetIsClickableByDefault()
 
   /**
-   * When enabled, runtime shadow node references will be updated during the commit. This allows running RSNRU from any thread without corrupting the renderer state.
+   * Do not emit touchcancel from Android ScrollView, instead native topScroll event will trigger responder transfer and terminate in RN renderer.
    */
   @JvmStatic
-  public fun updateRuntimeShadowNodeReferencesOnCommit(): Boolean = accessor.updateRuntimeShadowNodeReferencesOnCommit()
+  public fun shouldTriggerResponderTransferOnScrollAndroid(): Boolean = accessor.shouldTriggerResponderTransferOnScrollAndroid()
 
   /**
-   * In Bridgeless mode, use the always available javascript error reporting pipeline.
+   * Skip activity identity assertion in ReactHostImpl::onHostPause()
    */
   @JvmStatic
-  public fun useAlwaysAvailableJSErrorHandling(): Boolean = accessor.useAlwaysAvailableJSErrorHandling()
+  public fun skipActivityIdentityAssertionOnHostPause(): Boolean = accessor.skipActivityIdentityAssertionOnHostPause()
 
   /**
-   * Should this application enable the Fabric Interop Layer for Android? If yes, the application will behave so that it can accept non-Fabric components and render them on Fabric. This toggle is controlling extra logic such as custom event dispatching that are needed for the Fabric Interop Layer to work correctly.
+   * Enables storing js caller stack when creating promise in native module. This is useful in case of Promise rejection and tracing the cause.
    */
   @JvmStatic
-  public fun useFabricInterop(): Boolean = accessor.useFabricInterop()
+  public fun traceTurboModulePromiseRejectionsOnAndroid(): Boolean = accessor.traceTurboModulePromiseRejectionsOnAndroid()
 
   /**
-   * Use a native implementation of equals in NativeReadableArray.
+   * When enabled, runtime shadow node references will be updated during the commit. This allows running RSNRU from any thread without corrupting the renderer state.
    */
   @JvmStatic
-  public fun useNativeEqualsInNativeReadableArrayAndroid(): Boolean = accessor.useNativeEqualsInNativeReadableArrayAndroid()
+  public fun updateRuntimeShadowNodeReferencesOnCommit(): Boolean = accessor.updateRuntimeShadowNodeReferencesOnCommit()
 
   /**
-   * Use a native implementation of TransformHelper
+   * In Bridgeless mode, use the always available javascript error reporting pipeline.
    */
   @JvmStatic
-  public fun useNativeTransformHelperAndroid(): Boolean = accessor.useNativeTransformHelperAndroid()
+  public fun useAlwaysAvailableJSErrorHandling(): Boolean = accessor.useAlwaysAvailableJSErrorHandling()
 
   /**
-   * When enabled, the native view configs are used in bridgeless mode.
+   * Should this application enable the Fabric Interop Layer for Android? If yes, the application will behave so that it can accept non-Fabric components and render them on Fabric. This toggle is controlling extra logic such as custom event dispatching that are needed for the Fabric Interop Layer to work correctly.
    */
   @JvmStatic
-  public fun useNativeViewConfigsInBridgelessMode(): Boolean = accessor.useNativeViewConfigsInBridgelessMode()
+  public fun useFabricInterop(): Boolean = accessor.useFabricInterop()
 
   /**
-   * Uses an optimized mechanism for event batching on Android that does not need to wait for a Choreographer frame callback.
+   * When enabled, the native view configs are used in bridgeless mode.
    */
   @JvmStatic
-  public fun useOptimizedEventBatchingOnAndroid(): Boolean = accessor.useOptimizedEventBatchingOnAndroid()
+  public fun useNativeViewConfigsInBridgelessMode(): Boolean = accessor.useNativeViewConfigsInBridgelessMode()
 
   /**
    * Instead of using folly::dynamic as internal representation in RawProps and RawValue, use jsi::Value