react-native-tvos 0.78.0-0rc4 → 0.79.0-0

package/ReactAndroid/src/main/java/com/facebook/react/uimanager/drawable/InsetBoxShadowDrawable.kt

@@ -55,11 +55,9 @@ internal class InsetBoxShadowDrawable(
   private val shadowPaint =
       Paint().apply {
         color = shadowColor
-        if (blurRadius > 0) {
-          maskFilter =
-              BlurMaskFilter(
-                  FilterHelper.sigmaToRadius(blurRadius * BLUR_RADIUS_SIGMA_SCALE),
-                  BlurMaskFilter.Blur.NORMAL)
+        val convertedBlurRadius = FilterHelper.sigmaToRadius(blurRadius * BLUR_RADIUS_SIGMA_SCALE)
+        if (convertedBlurRadius > 0) {
+          maskFilter = BlurMaskFilter(convertedBlurRadius, BlurMaskFilter.Blur.NORMAL)
         }
       }
 
@@ -119,7 +117,7 @@ internal class InsetBoxShadowDrawable(
     // https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/core/paint/box_painter_base.cc;l=338;drc=0a301506035e13015ea5c8dd39164d0d5954fa60
     val blurExtent = FilterHelper.sigmaToRadius(blurRadius)
     val outerRect =
-        RectF(innerRect).apply {
+        RectF(paddingBoxRect).apply {
           inset(-blurExtent, -blurExtent)
           if (spreadExtent < 0) {
             inset(spreadExtent, spreadExtent)

package/ReactAndroid/src/main/java/com/facebook/react/uimanager/drawable/OutlineDrawable.kt

@@ -45,7 +45,7 @@ internal class OutlineDrawable(
    */
   private val gapBetweenPaths = 0.8f
 
-  public var outlineOffset: Float = outlineOffset
+  var outlineOffset: Float = outlineOffset
     set(value) {
       if (value != field) {
         field = value
@@ -53,7 +53,7 @@ internal class OutlineDrawable(
       }
     }
 
-  public var outlineStyle: OutlineStyle = outlineStyle
+  var outlineStyle: OutlineStyle = outlineStyle
     set(value) {
       if (value != field) {
         field = value
@@ -62,7 +62,7 @@ internal class OutlineDrawable(
       }
     }
 
-  public var outlineColor: Int = outlineColor
+  var outlineColor: Int = outlineColor
     set(value) {
       if (value != field) {
         field = value
@@ -71,7 +71,7 @@ internal class OutlineDrawable(
       }
     }
 
-  public var outlineWidth: Float = outlineWidth
+  var outlineWidth: Float = outlineWidth
     set(value) {
       if (value != field) {
         field = value

package/ReactAndroid/src/main/java/com/facebook/react/uimanager/drawable/OutsetBoxShadowDrawable.kt

@@ -51,11 +51,9 @@ internal class OutsetBoxShadowDrawable(
   private val shadowPaint =
       Paint().apply {
         color = shadowColor
-        if (blurRadius > 0) {
-          maskFilter =
-              BlurMaskFilter(
-                  FilterHelper.sigmaToRadius(blurRadius * BLUR_RADIUS_SIGMA_SCALE),
-                  BlurMaskFilter.Blur.NORMAL)
+        val convertedBlurRadius = FilterHelper.sigmaToRadius(blurRadius * BLUR_RADIUS_SIGMA_SCALE)
+        if (convertedBlurRadius > 0) {
+          maskFilter = BlurMaskFilter(convertedBlurRadius, BlurMaskFilter.Blur.NORMAL)
         }
       }
 

package/ReactAndroid/src/main/java/com/facebook/react/uimanager/events/BlackHoleEventDispatcher.kt

@@ -13,46 +13,38 @@ import com.facebook.common.logging.FLog
  * A singleton class that overrides [EventDispatcher] with no-op methods, to be used by callers that
  * expect an EventDispatcher when the instance doesn't exist.
  */
-public class BlackHoleEventDispatcher private constructor() : EventDispatcher {
-  public override fun dispatchEvent(event: Event<*>) {
+internal class BlackHoleEventDispatcher private constructor() : EventDispatcher {
+  override fun dispatchEvent(event: Event<*>) {
     FLog.d(
         "BlackHoleEventDispatcher",
         "Trying to emit event to JS, but the React instance isn't ready. Event: ${event.eventName}")
   }
 
-  public override fun dispatchAllEvents(): Unit = Unit
+  override fun dispatchAllEvents(): Unit = Unit
 
-  public override fun addListener(listener: EventDispatcherListener): Unit = Unit
+  override fun addListener(listener: EventDispatcherListener): Unit = Unit
 
-  public override fun removeListener(listener: EventDispatcherListener): Unit = Unit
+  override fun removeListener(listener: EventDispatcherListener): Unit = Unit
 
-  public override fun addBatchEventDispatchedListener(
-      listener: BatchEventDispatchedListener
-  ): Unit = Unit
+  override fun addBatchEventDispatchedListener(listener: BatchEventDispatchedListener): Unit = Unit
 
-  public override fun removeBatchEventDispatchedListener(
-      listener: BatchEventDispatchedListener
-  ): Unit = Unit
+  override fun removeBatchEventDispatchedListener(listener: BatchEventDispatchedListener): Unit =
+      Unit
 
   @Deprecated("Deprecated in Java")
   @Suppress("DEPRECATION")
-  public override fun registerEventEmitter(
-      uiManagerType: Int,
-      eventEmitter: RCTEventEmitter
-  ): Unit = Unit
+  override fun registerEventEmitter(uiManagerType: Int, eventEmitter: RCTEventEmitter): Unit = Unit
 
-  public override fun registerEventEmitter(
-      uiManagerType: Int,
-      eventEmitter: RCTModernEventEmitter
-  ): Unit = Unit
+  override fun registerEventEmitter(uiManagerType: Int, eventEmitter: RCTModernEventEmitter): Unit =
+      Unit
 
-  public override fun unregisterEventEmitter(uiManagerType: Int): Unit = Unit
+  override fun unregisterEventEmitter(uiManagerType: Int): Unit = Unit
 
-  public override fun onCatalystInstanceDestroyed(): Unit = Unit
+  override fun onCatalystInstanceDestroyed(): Unit = Unit
 
-  public companion object {
+  companion object {
     private val eventDispatcher: EventDispatcher = BlackHoleEventDispatcher()
 
-    public @JvmStatic fun get(): EventDispatcher = eventDispatcher
+    @JvmStatic fun get(): EventDispatcher = eventDispatcher
   }
 }

package/ReactAndroid/src/main/java/com/facebook/react/uimanager/events/FabricEventDispatcher.kt

@@ -11,10 +11,10 @@ import android.os.Handler
 import android.view.Choreographer
 import com.facebook.react.bridge.LifecycleEventListener
 import com.facebook.react.bridge.ReactApplicationContext
-import com.facebook.react.bridge.ReactNoCrashSoftException
 import com.facebook.react.bridge.ReactSoftExceptionLogger
 import com.facebook.react.bridge.UIManager
 import com.facebook.react.bridge.UiThreadUtil
+import com.facebook.react.common.annotations.UnstableReactNativeAPI
 import com.facebook.react.internal.featureflags.ReactNativeFeatureFlags
 import com.facebook.react.modules.core.ReactChoreographer
 import com.facebook.react.uimanager.UIManagerHelper
@@ -23,6 +23,8 @@ import com.facebook.systrace.Systrace
 import java.util.concurrent.CopyOnWriteArrayList
 import kotlin.concurrent.Volatile
 
+private const val TAG = "FabricEventDispatcher"
+
 /**
  * A singleton class that overrides [EventDispatcher] with no-op methods, to be used by callers that
  * expect an EventDispatcher when the instance doesn't exist.
@@ -74,9 +76,8 @@ public open class FabricEventDispatcher(reactContext: ReactApplicationContext) :
     try {
       val fabricUIManager: UIManager? =
           UIManagerHelper.getUIManager(reactContext, UIManagerType.FABRIC)
-      @Suppress("DEPRECATION")
+      @OptIn(UnstableReactNativeAPI::class)
       if (fabricUIManager is SynchronousEventReceiver) {
-        @Suppress("DEPRECATION")
         (fabricUIManager as SynchronousEventReceiver).receiveEvent(
             event.surfaceId,
             event.viewTag,
@@ -87,8 +88,8 @@ public open class FabricEventDispatcher(reactContext: ReactApplicationContext) :
             true)
       } else {
         ReactSoftExceptionLogger.logSoftException(
-            "FabricEventDispatcher",
-            ReactNoCrashSoftException(
+            TAG,
+            IllegalStateException(
                 "Fabric UIManager expected to implement SynchronousEventReceiver."))
       }
     } finally {
@@ -201,15 +202,15 @@ public open class FabricEventDispatcher(reactContext: ReactApplicationContext) :
       }
     }
 
-    public fun stop() {
+    fun stop() {
       shouldStop = true
     }
 
-    public fun resume() {
+    fun resume() {
       shouldStop = false
     }
 
-    public fun maybeDispatchBatchedEvents() {
+    fun maybeDispatchBatchedEvents() {
       if (!isFrameCallbackDispatchScheduled) {
         isFrameCallbackDispatchScheduled = true
         dispatchBatchedEvents()
@@ -221,7 +222,7 @@ public open class FabricEventDispatcher(reactContext: ReactApplicationContext) :
           .postFrameCallback(ReactChoreographer.CallbackType.TIMERS_EVENTS, currentFrameCallback)
     }
 
-    public fun maybeScheduleDispatchOfBatchedEvents() {
+    fun maybeScheduleDispatchOfBatchedEvents() {
       if (isFrameCallbackDispatchScheduled) {
         return
       }

package/ReactAndroid/src/main/java/com/facebook/react/uimanager/events/SynchronousEventReceiver.kt

@@ -8,16 +8,17 @@
 package com.facebook.react.uimanager.events
 
 import com.facebook.react.bridge.WritableMap
+import com.facebook.react.common.annotations.UnstableReactNativeAPI
 
-@Deprecated("Experimental")
-public interface SynchronousEventReceiver {
-  public fun receiveEvent(
+@UnstableReactNativeAPI
+internal interface SynchronousEventReceiver {
+  fun receiveEvent(
       surfaceId: Int,
       reactTag: Int,
       eventName: String,
       canCoalesceEvent: Boolean,
       params: WritableMap?,
       @EventCategoryDef eventCategory: Int,
-      experimental_isSynchronous: Boolean
+      experimentalIsSynchronous: Boolean
   ): Unit
 }

package/ReactAndroid/src/main/java/com/facebook/react/uimanager/events/TouchEvent.kt

@@ -64,7 +64,8 @@ public class TouchEvent private constructor() : Event<TouchEvent>() {
           coalescingKey = touchEventCoalescingKeyHelper.getCoalescingKey(gestureStartTime)
       MotionEvent.ACTION_CANCEL ->
           touchEventCoalescingKeyHelper.removeCoalescingKey(gestureStartTime)
-      else -> throw RuntimeException("Unhandled MotionEvent action: $action")
+      else ->
+          Unit // Passthrough for other actions (such as ACTION_SCROLL), coalescing is not applied
     }
 
     motionEvent = MotionEvent.obtain(motionEventToCopy)

package/ReactAndroid/src/main/java/com/facebook/react/uimanager/layoutanimation/AnimatedPropertyType.kt

@@ -19,7 +19,7 @@ internal enum class AnimatedPropertyType {
 
   companion object {
     @JvmStatic
-    public fun fromString(name: String): AnimatedPropertyType {
+    fun fromString(name: String): AnimatedPropertyType {
       return when (name) {
         "opacity" -> OPACITY
         "scaleX" -> SCALE_X

package/ReactAndroid/src/main/java/com/facebook/react/uimanager/layoutanimation/InterpolatorType.kt

@@ -7,19 +7,22 @@
 
 package com.facebook.react.uimanager.layoutanimation
 
+import com.facebook.react.common.annotations.internal.LegacyArchitecture
+
 /**
  * Enum representing the different interpolators that can be used in layout animation configuration.
  */
-public enum class InterpolatorType {
+@LegacyArchitecture
+internal enum class InterpolatorType {
   LINEAR,
   EASE_IN,
   EASE_OUT,
   EASE_IN_EASE_OUT,
   SPRING;
 
-  public companion object {
+  companion object {
     @JvmStatic
-    public fun fromString(name: String): InterpolatorType {
+    fun fromString(name: String): InterpolatorType {
       return when (name.lowercase()) {
         "linear" -> LINEAR
         "easein" -> EASE_IN

package/ReactAndroid/src/main/java/com/facebook/react/uimanager/layoutanimation/LayoutAnimationController.java

@@ -16,6 +16,7 @@ import androidx.annotation.Nullable;
 import com.facebook.react.bridge.Callback;
 import com.facebook.react.bridge.ReadableMap;
 import com.facebook.react.bridge.UiThreadUtil;
+import com.facebook.react.common.annotations.internal.LegacyArchitecture;
 import javax.annotation.concurrent.NotThreadSafe;
 
 /**
@@ -24,6 +25,7 @@ import javax.annotation.concurrent.NotThreadSafe;
  * performing an animation.
  */
 @NotThreadSafe
+@LegacyArchitecture
 public class LayoutAnimationController {
 
   private final AbstractLayoutAnimation mLayoutCreateAnimation = new LayoutCreateAnimation();

package/ReactAndroid/src/main/java/com/facebook/react/uimanager/layoutanimation/{LayoutAnimationListener.java → LayoutAnimationListener.kt}

@@ -5,9 +5,9 @@
  * LICENSE file in the root directory of this source tree.
  */
 
-package com.facebook.react.uimanager.layoutanimation;
+package com.facebook.react.uimanager.layoutanimation
 
 /** Listener invoked when a layout animation has completed. */
-public interface LayoutAnimationListener {
-  void onAnimationEnd();
+public fun interface LayoutAnimationListener {
+  public fun onAnimationEnd()
 }

package/ReactAndroid/src/main/java/com/facebook/react/uimanager/layoutanimation/{LayoutHandlingAnimation.java → LayoutHandlingAnimation.kt}

@@ -5,10 +5,10 @@
  * LICENSE file in the root directory of this source tree.
  */
 
-package com.facebook.react.uimanager.layoutanimation;
+package com.facebook.react.uimanager.layoutanimation
 
 /** Interface for an animation type that takes care of updating the view layout. */
-/* package */ interface LayoutHandlingAnimation {
+internal interface LayoutHandlingAnimation {
   /**
    * Notifies the animation of a layout update in case one occurs during the animation. This avoids
    * animating the view to the old layout since it's no longer correct; instead the animation should
@@ -19,5 +19,5 @@ package com.facebook.react.uimanager.layoutanimation;
    * @param width the new width value for the view
    * @param height the new height value for the view
    */
-  void onLayoutUpdate(int x, int y, int width, int height);
+  fun onLayoutUpdate(x: Int, y: Int, width: Int, height: Int)
 }

package/ReactAndroid/src/main/java/com/facebook/react/uimanager/layoutanimation/LayoutUpdateAnimation.kt

@@ -17,9 +17,9 @@ import android.view.animation.TranslateAnimation
  */
 internal class LayoutUpdateAnimation : AbstractLayoutAnimation() {
 
-  override internal fun isValid(): Boolean = mDurationMs > 0
+  internal override fun isValid(): Boolean = mDurationMs > 0
 
-  override internal fun createAnimationImpl(
+  internal override fun createAnimationImpl(
       view: View,
       x: Int,
       y: Int,

package/ReactAndroid/src/main/java/com/facebook/react/uimanager/layoutanimation/SimpleSpringInterpolator.kt

@@ -19,11 +19,11 @@ internal class SimpleSpringInterpolator : Interpolator {
   private val _springDamping: Float
 
   @JvmOverloads
-  public constructor(springDamping: Float = FACTOR) {
+  constructor(springDamping: Float = FACTOR) {
     _springDamping = springDamping
   }
 
-  override public fun getInterpolation(input: Float): Float =
+  override fun getInterpolation(input: Float): Float =
       // Using mSpringDamping in this equation is not really the exact mathematical springDamping,
       // but a good approximation
       // We need to replace this equation with the right Factor that accounts for damping and
@@ -33,12 +33,12 @@ internal class SimpleSpringInterpolator : Interpolator {
                   Math.sin((input - _springDamping / 4) * Math.PI * 2 / _springDamping))
           .toFloat()
 
-  public companion object {
+  companion object {
     private const val FACTOR = 0.5f
-    public const val PARAM_SPRING_DAMPING: String = "springDamping"
+    const val PARAM_SPRING_DAMPING: String = "springDamping"
 
     @JvmStatic
-    public fun getSpringDamping(params: ReadableMap): Float =
+    fun getSpringDamping(params: ReadableMap): Float =
         if (params.getType(PARAM_SPRING_DAMPING) == ReadableType.Number) {
           params.getDouble(PARAM_SPRING_DAMPING).toFloat()
         } else {

package/ReactAndroid/src/main/java/com/facebook/react/uimanager/style/BorderColors.kt

@@ -25,7 +25,7 @@ internal value class BorderColors(
     @ColorInt val edgeColors: Array<Int?> = arrayOfNulls<Int?>(LogicalEdge.values().size)
 ) {
 
-  public fun resolve(layoutDirection: Int, context: Context): ColorEdges {
+  fun resolve(layoutDirection: Int, context: Context): ColorEdges {
     return when (layoutDirection) {
       LayoutDirection.LTR ->
           ColorEdges(

package/ReactAndroid/src/main/java/com/facebook/react/uimanager/style/BorderInsets.kt

@@ -16,11 +16,11 @@ import com.facebook.react.modules.i18nmanager.I18nUtil
 internal class BorderInsets {
   private val edgeInsets = arrayOfNulls<Float?>(LogicalEdge.values().size)
 
-  public fun setBorderWidth(edge: LogicalEdge, width: Float?) {
+  fun setBorderWidth(edge: LogicalEdge, width: Float?) {
     edgeInsets[edge.ordinal] = width
   }
 
-  public fun resolve(
+  fun resolve(
       layoutDirection: Int,
       context: Context,
   ): RectF {

package/ReactAndroid/src/main/java/com/facebook/react/uimanager/style/BorderRadiusStyle.kt

@@ -30,7 +30,7 @@ public enum class BorderRadiusProp {
 }
 
 /** Represents all logical properties and shorthands for border radius. */
-public data class BorderRadiusStyle(
+internal data class BorderRadiusStyle(
     var uniform: LengthPercentage? = null,
     var topLeft: LengthPercentage? = null,
     var topRight: LengthPercentage? = null,
@@ -45,11 +45,11 @@ public data class BorderRadiusStyle(
     var endStart: LengthPercentage? = null,
     var endEnd: LengthPercentage? = null
 ) {
-  public constructor(properties: List<Pair<BorderRadiusProp, LengthPercentage>>) : this() {
+  constructor(properties: List<Pair<BorderRadiusProp, LengthPercentage>>) : this() {
     properties.forEach { (k, v) -> set(k, v) }
   }
 
-  public fun set(property: BorderRadiusProp, value: LengthPercentage?) {
+  fun set(property: BorderRadiusProp, value: LengthPercentage?) {
     when (property) {
       BorderRadiusProp.BORDER_RADIUS -> uniform = value
       BorderRadiusProp.BORDER_TOP_LEFT_RADIUS -> topLeft = value
@@ -67,7 +67,7 @@ public data class BorderRadiusStyle(
     }
   }
 
-  public fun get(property: BorderRadiusProp): LengthPercentage? {
+  fun get(property: BorderRadiusProp): LengthPercentage? {
     return when (property) {
       BorderRadiusProp.BORDER_RADIUS -> uniform
       BorderRadiusProp.BORDER_TOP_LEFT_RADIUS -> topLeft
@@ -85,7 +85,7 @@ public data class BorderRadiusStyle(
     }
   }
 
-  public fun hasRoundedBorders(): Boolean {
+  fun hasRoundedBorders(): Boolean {
     return uniform != null ||
         topLeft != null ||
         topRight != null ||
@@ -101,7 +101,7 @@ public data class BorderRadiusStyle(
         endEnd != null
   }
 
-  public fun resolve(
+  fun resolve(
       layoutDirection: Int,
       context: Context,
       width: Float,

package/ReactAndroid/src/main/java/com/facebook/react/uimanager/style/Gradient.kt

@@ -10,9 +10,7 @@ package com.facebook.react.uimanager.style
 import android.content.Context
 import android.graphics.Rect
 import android.graphics.Shader
-import com.facebook.react.bridge.ColorPropConverter
 import com.facebook.react.bridge.ReadableMap
-import com.facebook.react.bridge.ReadableType
 
 internal class Gradient(gradient: ReadableMap?, context: Context) {
   private enum class GradientType {
@@ -40,25 +38,10 @@ internal class Gradient(gradient: ReadableMap?, context: Context) {
         gradient.getArray("colorStops")
             ?: throw IllegalArgumentException("Invalid colorStops array")
 
-    val size = colorStops.size()
-    val colors = IntArray(size)
-    val positions = FloatArray(size)
-
-    for (i in 0 until size) {
-      val colorStop = colorStops.getMap(i) ?: continue
-      colors[i] =
-          if (colorStop.getType("color") == ReadableType.Map) {
-            ColorPropConverter.getColor(colorStop.getMap("color"), context)
-          } else {
-            colorStop.getInt("color")
-          }
-      positions[i] = colorStop.getDouble("position").toFloat()
-    }
-
-    linearGradient = LinearGradient(directionMap, colors, positions)
+    linearGradient = LinearGradient(directionMap, colorStops, context)
   }
 
-  public fun getShader(bounds: Rect): Shader? {
+  fun getShader(bounds: Rect): Shader? {
     return when (type) {
       GradientType.LINEAR_GRADIENT ->
           linearGradient.getShader(bounds.width().toFloat(), bounds.height().toFloat())