react-native-tvos 0.78.0-0rc4 → 0.79.0-0

package/ReactAndroid/src/main/java/com/facebook/react/uimanager/ReactClippingViewGroup.kt

@@ -0,0 +1,52 @@
+/*
+ * Copyright (c) Meta Platforms, Inc. and affiliates.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ */
+
+package com.facebook.react.uimanager
+
+import android.graphics.Rect
+import android.view.View
+
+/**
+ * Interface that should be implemented by [View] subclasses that support `removeClippedSubviews`
+ * property. When this property is set for the [ViewGroup] subclass it's responsible for detaching
+ * it's child views that are clipped by the view boundaries. Those view boundaries should be
+ * determined based on it's parent clipping area and current view's offset in parent and doesn't
+ * necessarily reflect the view visible area (in a sense of a value that [View.getGlobalVisibleRect]
+ * may return). In order to determine the clipping rect for current view helper method
+ * [ReactClippingViewGroupHelper.calculateClippingRect] can be used that takes into account parent
+ * view settings.
+ */
+public interface ReactClippingViewGroup {
+  /**
+   * Notify view that clipping area may have changed and it should recalculate the list of children
+   * that should be attached/detached. This method should be called only when property
+   * `removeClippedSubviews` is set to `true` on a view.
+   *
+   * CAUTION: Views are responsible for calling [updateClippingRect] on it's children. This should
+   * happen if child implement [ReactClippingViewGroup], return true from [getRemoveClippedSubviews]
+   * and clipping rect change of the current view may affect clipping rect of this child.
+   */
+  public fun updateClippingRect()
+
+  /**
+   * Get rectangular bounds to which view is currently clipped to. Called only on views that has set
+   * `removeCLippedSubviews` property value to `true`.
+   *
+   * @param outClippingRect output clipping rect should be written to this object.
+   */
+  public fun getClippingRect(outClippingRect: Rect)
+
+  /**
+   * Sets property `removeClippedSubviews` as a result of property update in JS. Should be called
+   * only from [ViewManager.updateView] method.
+   *
+   * Helper method [ReactClippingViewGroupHelper.applyRemoveClippedSubviewsProperty] may be used by
+   * [ViewManager] subclass to apply this property based on property update map
+   * [ReactStylesDiffMap].
+   */
+  public var removeClippedSubviews: Boolean
+}

package/ReactAndroid/src/main/java/com/facebook/react/uimanager/ReactCompoundView.kt

@@ -8,9 +8,9 @@
 package com.facebook.react.uimanager
 
 /**
- * This interface should be implemented be native {@link View} subclasses that can represent more
- * than a single react node (e.g. [TextView]). It is use by touch event emitter for determining the
- * react tag of the inner-view element that was touched.
+ * This interface should be implemented by native [View] subclasses that can represent more than a
+ * single react node (e.g. [TextView]). It is use by touch event emitter for determining the react
+ * tag of the inner-view element that was touched.
  */
 public interface ReactCompoundView {
 

package/ReactAndroid/src/main/java/com/facebook/react/uimanager/{ReactOverflowViewWithInset.java → ReactOverflowViewWithInset.kt}

@@ -5,29 +5,29 @@
  * LICENSE file in the root directory of this source tree.
  */
 
-package com.facebook.react.uimanager;
+package com.facebook.react.uimanager
 
-import android.graphics.Rect;
-import android.view.View;
+import android.graphics.Rect
+import android.view.View
 
 /**
- * Interface that should be implemented by {@link View} subclasses that support {@code overflow}
- * style and want to use the overflowInset values. This allows the overflow information to be used
- * by {@link TouchTargetHelper} to determine if a View is touchable.
+ * Interface that should be implemented by [View] subclasses that support `overflow` style and want
+ * to use the overflowInset values. This allows the overflow information to be used by
+ * [TouchTargetHelper] to determine if a View is touchable.
  */
-public interface ReactOverflowViewWithInset extends ReactOverflowView {
+internal interface ReactOverflowViewWithInset : ReactOverflowView {
   /**
    * Get the overflow inset rect values which indicate the extensions to the boundaries of current
    * view that wraps all of its children views
    *
    * @return Rect of integers indicating the left, top, right, bottom pixel extensions. The values
-   *     are non-positive (indicating enlarged boundaries).
+   *   are non-positive (indicating enlarged boundaries).
    */
-  Rect getOverflowInset();
+  val overflowInset: Rect
 
   /**
    * Set the overflow inset rect values which indicate the extensions to the boundaries of current
    * view that wraps all of its children views
    */
-  void setOverflowInset(int left, int top, int right, int bottom);
+  fun setOverflowInset(left: Int, top: Int, right: Int, bottom: Int)
 }

package/ReactAndroid/src/main/java/com/facebook/react/uimanager/ReactPointerEventsView.kt

@@ -8,7 +8,7 @@
 package com.facebook.react.uimanager
 
 /**
- * This interface should be implemented be native [View] subclasses that support pointer events
+ * This interface should be implemented by native [View] subclasses that support pointer events
  * handling. It is used to find the target View of a touch event.
  */
 public interface ReactPointerEventsView {

package/ReactAndroid/src/main/java/com/facebook/react/uimanager/ReactShadowNodeImpl.java

@@ -59,7 +59,7 @@ public class ReactShadowNodeImpl implements ReactShadowNode<ReactShadowNodeImpl>
   private static final YogaConfig sYogaConfig;
 
   static {
-    sYogaConfig = ReactYogaConfigProvider.get();
+    sYogaConfig = ReactYogaConfigProvider.INSTANCE.getYogaConfig();
   }
 
   private int mReactTag;

package/ReactAndroid/src/main/java/com/facebook/react/uimanager/ReactStage.kt

@@ -0,0 +1,36 @@
+/*
+ * Copyright (c) Meta Platforms, Inc. and affiliates.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ */
+package com.facebook.react.uimanager
+
+import androidx.annotation.IntDef
+
+/** The stage of the Surface */
+@Retention(AnnotationRetention.SOURCE)
+@IntDef(
+    value =
+        [
+            ReactStage.SURFACE_DID_INITIALIZE,
+            ReactStage.BRIDGE_DID_LOAD,
+            ReactStage.MODULE_DID_LOAD,
+            ReactStage.SURFACE_DID_RUN,
+            ReactStage.SURFACE_DID_INITIAL_RENDERING,
+            ReactStage.SURFACE_DID_INITIAL_LAYOUT,
+            ReactStage.SURFACE_DID_INITIAL_MOUNTING,
+            ReactStage.SURFACE_DID_STOP])
+public annotation class ReactStage {
+  public companion object {
+    public const val SURFACE_DID_INITIALIZE: Int = 0
+    public const val BRIDGE_DID_LOAD: Int = 1
+    public const val MODULE_DID_LOAD: Int = 2
+    public const val SURFACE_DID_RUN: Int = 3
+    public const val SURFACE_DID_INITIAL_RENDERING: Int = 4
+    public const val SURFACE_DID_INITIAL_LAYOUT: Int = 5
+    public const val SURFACE_DID_INITIAL_MOUNTING: Int = 6
+    public const val SURFACE_DID_STOP: Int = 7
+    public const val ON_ATTACH_TO_INSTANCE: Int = 101
+  }
+}

package/ReactAndroid/src/main/java/com/facebook/react/uimanager/ReactYogaConfigProvider.kt

@@ -11,18 +11,13 @@ import com.facebook.yoga.YogaConfig
 import com.facebook.yoga.YogaConfigFactory
 import com.facebook.yoga.YogaErrata
 
-public object ReactYogaConfigProvider {
+internal object ReactYogaConfigProvider {
 
-  private val yogaConfig: YogaConfig by
+  val yogaConfig: YogaConfig by
       lazy(LazyThreadSafetyMode.NONE) {
-        val config = YogaConfigFactory.create()
-        config.setPointScaleFactor(0f)
-        config.setErrata(YogaErrata.ALL)
-        config
+        YogaConfigFactory.create().apply {
+          setPointScaleFactor(0f)
+          setErrata(YogaErrata.ALL)
+        }
       }
-
-  @JvmStatic
-  public fun get(): YogaConfig {
-    return yogaConfig
-  }
 }

package/ReactAndroid/src/main/java/com/facebook/react/uimanager/{ReactZIndexedViewGroup.java → ReactZIndexedViewGroup.kt}

@@ -5,21 +5,21 @@
  * LICENSE file in the root directory of this source tree.
  */
 
-package com.facebook.react.uimanager;
+package com.facebook.react.uimanager
 
 /** ViewGroup that supports z-index. */
 public interface ReactZIndexedViewGroup {
   /**
-   * Determine the index of a child view at {@param index} considering z-index.
+   * Determine the index of a child view at [index] considering z-index.
    *
    * @param index The child view index
    * @return The child view index considering z-index
    */
-  int getZIndexMappedChildIndex(int index);
+  public fun getZIndexMappedChildIndex(index: Int): Int
 
   /**
    * Redraw the view based on updated child z-index. This should be called after updating one of its
    * child z-index.
    */
-  void updateDrawingOrder();
+  public fun updateDrawingOrder()
 }

package/ReactAndroid/src/main/java/com/facebook/react/uimanager/RootViewManager.kt

@@ -13,12 +13,12 @@ import android.widget.FrameLayout
 /** View manager for ReactRootView components. */
 internal class RootViewManager : ViewGroupManager<ViewGroup>() {
 
-  override public fun getName(): String = REACT_CLASS
+  override fun getName(): String = REACT_CLASS
 
-  override protected fun createViewInstance(reactContext: ThemedReactContext): ViewGroup =
+  override fun createViewInstance(reactContext: ThemedReactContext): ViewGroup =
       FrameLayout(reactContext)
 
-  public companion object {
-    public const val REACT_CLASS: String = "RootView"
+  companion object {
+    const val REACT_CLASS: String = "RootView"
   }
 }

package/ReactAndroid/src/main/java/com/facebook/react/uimanager/SimpleViewManager.kt

@@ -10,22 +10,22 @@ package com.facebook.react.uimanager
 import android.view.View
 
 /**
- * Common base class for most of the {@link ViewManager}s. It provides support for most common
- * properties through extending {@link BaseViewManager}. It also reduces boilerplate by specifying
- * the type of shadow node to be {@link ReactShadowNode} and providing default, empty implementation
- * for some of the methods of {@link ViewManager} interface.
+ * Common base class for most of the [ViewManager]s. It provides support for most common properties
+ * through extending [BaseViewManager]. It also reduces boilerplate by specifying the type of shadow
+ * node to be [ReactShadowNode] and providing default, empty implementation for some of the methods
+ * of [ViewManager] interface.
  *
  * @param <T> the view handled by this manager
  */
 public abstract class SimpleViewManager<T : View> : BaseViewManager<T, LayoutShadowNode>() {
 
-  override public fun createShadowNodeInstance(): LayoutShadowNode {
+  public override fun createShadowNodeInstance(): LayoutShadowNode {
     return LayoutShadowNode()
   }
 
-  override public fun getShadowNodeClass(): Class<LayoutShadowNode> {
+  public override fun getShadowNodeClass(): Class<LayoutShadowNode> {
     return LayoutShadowNode::class.java
   }
 
-  override public fun updateExtraData(root: T, extraData: Any?): Unit = Unit
+  public override fun updateExtraData(root: T, extraData: Any?): Unit = Unit
 }

package/ReactAndroid/src/main/java/com/facebook/react/uimanager/{StateWrapper.java → StateWrapper.kt}

@@ -5,12 +5,11 @@
  * LICENSE file in the root directory of this source tree.
  */
 
-package com.facebook.react.uimanager;
+package com.facebook.react.uimanager
 
-import com.facebook.react.bridge.ReadableNativeMap;
-import com.facebook.react.bridge.WritableMap;
-import com.facebook.react.common.mapbuffer.ReadableMapBuffer;
-import javax.annotation.Nullable;
+import com.facebook.react.bridge.ReadableNativeMap
+import com.facebook.react.bridge.WritableMap
+import com.facebook.react.common.mapbuffer.ReadableMapBuffer
 
 /**
  * This is a wrapper that can be used for passing State objects from Fabric C++ core to
@@ -18,26 +17,23 @@ import javax.annotation.Nullable;
  * by calling updateState, which communicates state back to the C++ layer.
  */
 public interface StateWrapper {
-
   /**
    * Get a ReadableMapBuffer object from the C++ layer, which is a K/V map of short keys to values.
    *
-   * <p>Unstable API - DO NOT USE.
+   * Unstable API - DO NOT USE.
    */
-  @Nullable
-  ReadableMapBuffer getStateDataMapBuffer();
+  public val stateDataMapBuffer: ReadableMapBuffer?
 
   /**
    * Get a ReadableNativeMap object from the C++ layer, which is a K/V map of string keys to values.
    */
-  @Nullable
-  ReadableNativeMap getStateData();
+  public val stateData: ReadableNativeMap?
 
   /**
    * Pass a map of values back to the C++ layer. The operation is performed synchronously and cannot
    * fail.
    */
-  void updateState(WritableMap map);
+  public fun updateState(map: WritableMap)
 
   /**
    * Mark state as unused and clean up in Java and in native. This should be called as early as
@@ -45,5 +41,5 @@ public interface StateWrapper {
    * used legitimately, don't destroy it! It is expected that all StateWrappers are destroyed
    * immediately upon stopSurface.
    */
-  void destroyState();
+  public fun destroyState()
 }

package/ReactAndroid/src/main/java/com/facebook/react/uimanager/UIBlock.kt

@@ -9,5 +9,5 @@ package com.facebook.react.uimanager
 
 /** A task to execute on the UI View for third party libraries. */
 public fun interface UIBlock {
-  public fun execute(nativeViewHierarchyManager: NativeViewHierarchyManager?): Unit
+  public fun execute(nativeViewHierarchyManager: NativeViewHierarchyManager): Unit
 }

package/ReactAndroid/src/main/java/com/facebook/react/uimanager/UIConstantsProviderBinding.kt

@@ -20,7 +20,7 @@ internal object UIConstantsProviderBinding {
   }
 
   @JvmStatic
-  public external fun install(
+  external fun install(
       runtimeExecutor: RuntimeExecutor,
       defaultEventTypesProvider: DefaultEventTypesProvider,
       viewManagerConstantsProvider: ConstantsForViewManagerProvider,
@@ -28,20 +28,20 @@ internal object UIConstantsProviderBinding {
   )
 
   @DoNotStripAny
-  public interface DefaultEventTypesProvider {
+  interface DefaultEventTypesProvider {
     /* Returns UIManager's constants. */
-    public fun getDefaultEventTypes(): NativeMap
+    fun getDefaultEventTypes(): NativeMap
   }
 
   @DoNotStripAny
-  public interface ConstantsForViewManagerProvider {
+  interface ConstantsForViewManagerProvider {
     /* Returns UIManager's constants. */
-    public fun getConstantsForViewManager(viewManagerName: String): NativeMap?
+    fun getConstantsForViewManager(viewManagerName: String): NativeMap?
   }
 
   @DoNotStripAny
-  public interface ConstantsProvider {
+  interface ConstantsProvider {
     /* Returns UIManager's constants. */
-    public fun getConstants(): NativeMap
+    fun getConstants(): NativeMap
   }
 }

package/ReactAndroid/src/main/java/com/facebook/react/uimanager/{UIManagerModuleListener.java → UIManagerModuleListener.kt}

@@ -5,17 +5,14 @@
  * LICENSE file in the root directory of this source tree.
  */
 
-package com.facebook.react.uimanager;
+package com.facebook.react.uimanager
 
-/**
- * Listener used to hook into the UIManager update process. Deprecated: use UIManagerListener
- * instead. This will be deleted in some future release.
- */
-@Deprecated
+/** Listener used to hook into the UIManager update process. */
+@Deprecated("Use UIManagerListener instead. This will be deleted in some future release.")
 public interface UIManagerModuleListener {
   /**
    * Called right before view updates are dispatched at the end of a batch. This is useful if a
    * module needs to add UIBlocks to the queue before it is flushed.
    */
-  void willDispatchViewUpdates(UIManagerModule uiManager);
+  public fun willDispatchViewUpdates(uiManager: UIManagerModule)
 }

package/ReactAndroid/src/main/java/com/facebook/react/uimanager/ViewManager.java

@@ -15,6 +15,8 @@ import com.facebook.common.logging.FLog;
 import com.facebook.react.bridge.BaseJavaModule;
 import com.facebook.react.bridge.ReactApplicationContext;
 import com.facebook.react.bridge.ReactContext;
+import com.facebook.react.bridge.ReactNoCrashSoftException;
+import com.facebook.react.bridge.ReactSoftExceptionLogger;
 import com.facebook.react.bridge.ReadableArray;
 import com.facebook.react.bridge.ReadableMap;
 import com.facebook.react.common.annotations.UnstableReactNativeAPI;
@@ -27,6 +29,7 @@ import com.facebook.react.uimanager.annotations.ReactPropGroup;
 import com.facebook.react.uimanager.annotations.ReactPropertyHolder;
 import com.facebook.yoga.YogaMeasureMode;
 import java.util.HashMap;
+import java.util.Iterator;
 import java.util.Map;
 import java.util.Stack;
 
@@ -39,7 +42,9 @@ import java.util.Stack;
 public abstract class ViewManager<T extends View, C extends ReactShadowNode>
     extends BaseJavaModule {
 
-  private static final String NAME = ViewManager.class.getSimpleName();
+  private static final String TAG = "ViewManager";
+
+  private @Nullable ViewManagerDelegate<T> mDelegate = null;
 
   /**
    * For View recycling: we store a Stack of unused, dead Views. This is null by default, and when
@@ -88,11 +93,11 @@ public abstract class ViewManager<T extends View, C extends ReactShadowNode>
    * @param props {@link ReactStylesDiffMap} props to update the view with
    */
   public void updateProperties(@NonNull T viewToUpdate, ReactStylesDiffMap props) {
-    final ViewManagerDelegate<T> delegate = getDelegate();
-    if (delegate != null) {
-      ViewManagerPropertyUpdater.updateProps(delegate, viewToUpdate, props);
-    } else {
-      ViewManagerPropertyUpdater.updateProps(this, viewToUpdate, props);
+    ViewManagerDelegate<T> delegate = getOrCreateViewManagerDelegate();
+    Iterator<Map.Entry<String, Object>> iterator = props.mBackingMap.getEntryIterator();
+    while (iterator.hasNext()) {
+      Map.Entry<String, Object> entry = iterator.next();
+      delegate.setProperty(viewToUpdate, entry.getKey(), entry.getValue());
     }
     onAfterUpdateTransaction(viewToUpdate);
   }
@@ -103,15 +108,31 @@ public abstract class ViewManager<T extends View, C extends ReactShadowNode>
    * then get calls to {@link ViewManagerDelegate#setProperty(View, String, Object)} for every prop
    * that must be updated and it's the delegate's responsibility to apply these values to the view.
    *
-   * <p>By default this method returns {@code null}, which means that the view manager doesn't have
-   * a delegate and the view props should be set internally by the view manager itself.
+   * <p>By default, this methods returns a generic {@link ViewManagerDelegate} which uses {@link
+   * ViewManagerSetter} to apply property updates.
    *
    * @return an instance of {@link ViewManagerDelegate} if the props of the view managed by this
    *     view manager should be set via this delegate
    */
-  @Nullable
   protected ViewManagerDelegate<T> getDelegate() {
-    return null;
+    if (this instanceof ViewManagerWithGeneratedInterface) {
+      ReactSoftExceptionLogger.logSoftException(
+          TAG,
+          new ReactNoCrashSoftException(
+              "ViewManager using codegen must override getDelegate method (name: "
+                  + getName()
+                  + ")."));
+    }
+    return new ViewManagerPropertyUpdater.GenericViewManagerDelegate<>(this);
+  }
+
+  private ViewManagerDelegate<T> getOrCreateViewManagerDelegate() {
+    ViewManagerDelegate<T> delegate = mDelegate;
+    if (delegate == null) {
+      delegate = getDelegate();
+      mDelegate = delegate;
+    }
+    return delegate;
   }
 
   /** Creates a view with knowledge of props and state. */
@@ -216,12 +237,12 @@ public abstract class ViewManager<T extends View, C extends ReactShadowNode>
     if (viewContext == null) {
       // Who knows! Anything is possible. Checking instanceof on null is an NPE,
       // So this is not redundant.
-      FLog.e(NAME, "onDropViewInstance: view [" + view.getId() + "] has a null context");
+      FLog.e(TAG, "onDropViewInstance: view [" + view.getId() + "] has a null context");
       return;
     }
     if (!(viewContext instanceof ThemedReactContext)) {
       FLog.e(
-          NAME,
+          TAG,
           "onDropViewInstance: view ["
               + view.getId()
               + "] has a context that is not a ThemedReactContext: "
@@ -306,10 +327,7 @@ public abstract class ViewManager<T extends View, C extends ReactShadowNode>
    * @param args optional arguments for the command
    */
   public void receiveCommand(@NonNull T root, String commandId, @Nullable ReadableArray args) {
-    final ViewManagerDelegate<T> delegate = getDelegate();
-    if (delegate != null) {
-      delegate.receiveCommand(root, commandId, args);
-    }
+    getOrCreateViewManagerDelegate().receiveCommand(root, commandId, args);
   }
 
   /**

package/ReactAndroid/src/main/java/com/facebook/react/uimanager/ViewManagerDelegate.kt

@@ -22,20 +22,42 @@ public interface ViewManagerDelegate<T : View> {
   /**
    * Sets a property on a view managed by this view manager.
    *
+   * We mark this method as synthetic / hide it from JVM so Java callers will call the deprecated
+   * version and overrides work correctly.
+   *
    * @param view the view to set the property on
-   * @param propName the name of the property to set (NOTE: should be `String` but is kept as
-   *   `String?` to avoid breaking changes)
+   * @param propName the name of the property to set
    * @param value the value to set the property to
    */
-  public fun setProperty(view: T, propName: String?, value: Any?)
+  @Suppress("INAPPLICABLE_JVM_NAME")
+  @JvmName("kotlinCompat\$setProperty")
+  @JvmSynthetic
+  public fun setProperty(view: T, propName: String, value: Any?)
+
+  @Suppress("INAPPLICABLE_JVM_NAME")
+  @Deprecated(message = "propName is not nullable, please update your method signature")
+  @JvmName("setProperty")
+  public fun javaCompat_setProperty(view: T, propName: String?, value: Any?): Unit =
+      setProperty(view, checkNotNull(propName), value)
 
   /**
    * Executes a command from JS to the view
    *
+   * We mark this method as synthetic / hide it from JVM so Java callers will call the deprecated
+   * version and overrides work correctly.
+   *
    * @param view the view to execute the command on
-   * @param commandName the name of the command to execute (NOTE: should be `String` but is kept as
-   *   `String?` to avoid breaking changes)
+   * @param commandName the name of the command to execute
    * @param args the arguments to pass to the command
    */
-  public fun receiveCommand(view: T, commandName: String?, args: ReadableArray?)
+  @Suppress("INAPPLICABLE_JVM_NAME")
+  @JvmName("kotlinCompat\$receiveCommand")
+  @JvmSynthetic
+  public fun receiveCommand(view: T, commandName: String, args: ReadableArray?)
+
+  @Suppress("INAPPLICABLE_JVM_NAME")
+  @Deprecated(message = "commandName is not nullable, please update your method signature")
+  @JvmName("receiveCommand")
+  public fun javaCompat_receiveCommand(view: T, commandName: String?, args: ReadableArray?): Unit =
+      receiveCommand(view, checkNotNull(commandName), args)
 }