rclnodejs 1.6.0 → 1.7.0

package/lib/interface_loader.js

@@ -17,6 +17,7 @@
 const path = require('path');
 const fs = require('fs');
 const generator = require('../rosidl_gen/index.js');
+const { TypeValidationError, ValidationError } = require('./errors.js');
 
 let interfaceLoader = {
   loadInterfaceByObject(obj) {
@@ -36,8 +37,13 @@ let interfaceLoader = {
       !obj.type ||
       !obj.name
     ) {
-      throw new TypeError(
-        'Should provide an object argument to get ROS message class'
+      throw new TypeValidationError(
+        'interfaceObject',
+        obj,
+        'object with package, type, and name properties',
+        {
+          entityType: 'interface loader',
+        }
       );
     }
     return this.loadInterface(obj.package, obj.type, obj.name);
@@ -45,9 +51,9 @@ let interfaceLoader = {
 
   loadInterfaceByString(name) {
     if (typeof name !== 'string') {
-      throw new TypeError(
-        'Should provide a string argument to get ROS message class'
-      );
+      throw new TypeValidationError('name', name, 'string', {
+        entityType: 'interface loader',
+      });
     }
 
     // TODO(Kenny): more checks of the string argument
@@ -64,8 +70,15 @@ let interfaceLoader = {
       return this.loadInterfaceByPath(packagePath, interfaces);
     }
 
-    throw new TypeError(
-      'A string argument in expected in "package/type/message" format'
+    throw new ValidationError(
+      'A string argument in expected in "package/type/message" format',
+      {
+        code: 'INVALID_INTERFACE_FORMAT',
+        argumentName: 'name',
+        providedValue: name,
+        expectedType: 'string in "package/type/message" format',
+        entityType: 'interface loader',
+      }
     );
   },
 
@@ -174,8 +187,18 @@ let interfaceLoader = {
         }
       }
     }
-    throw new Error(
-      `The message required does not exist: ${packageName}, ${type}, ${messageName} at ${generator.generatedRoot}`
+    throw new ValidationError(
+      `The message required does not exist: ${packageName}, ${type}, ${messageName} at ${generator.generatedRoot}`,
+      {
+        code: 'MESSAGE_NOT_FOUND',
+        entityType: 'interface loader',
+        details: {
+          packageName: packageName,
+          type: type,
+          messageName: messageName,
+          searchPath: generator.generatedRoot,
+        },
+      }
     );
   },
 
@@ -187,7 +210,14 @@ let interfaceLoader = {
       } else if (typeof type === 'string') {
         return this.loadInterfaceByString(type);
       }
-      throw new Error(`The message required does not exist: ${type}`);
+      throw new ValidationError(
+        `The message required does not exist: ${type}`,
+        {
+          code: 'MESSAGE_NOT_FOUND',
+          entityType: 'interface loader',
+          details: { type: type },
+        }
+      );
     }
     if (packageName && type && messageName) {
       let filePath = path.join(
@@ -208,8 +238,18 @@ let interfaceLoader = {
       }
     }
     // We cannot parse `packageName`, `type` and `messageName` from the string passed.
-    throw new Error(
-      `The message required does not exist: ${packageName}, ${type}, ${messageName} at ${generator.generatedRoot}`
+    throw new ValidationError(
+      `The message required does not exist: ${packageName}, ${type}, ${messageName} at ${generator.generatedRoot}`,
+      {
+        code: 'MESSAGE_NOT_FOUND',
+        entityType: 'interface loader',
+        details: {
+          packageName: packageName,
+          type: type,
+          messageName: messageName,
+          searchPath: generator.generatedRoot,
+        },
+      }
     );
   },
 };

package/lib/lifecycle.js

@@ -21,6 +21,7 @@ const Context = require('./context.js');
 const Node = require('./node.js');
 const NodeOptions = require('./node_options.js');
 const Service = require('./service.js');
+const { ValidationError } = require('./errors.js');
 
 const SHUTDOWN_TRANSITION_LABEL =
   rclnodejs.getLifecycleShutdownTransitionLabel();
@@ -707,8 +708,13 @@ class LifecycleNode extends Node {
           );
 
     if (!newStateObj) {
-      throw new Error(
-        `No transition available from state ${transitionIdOrLabel}.`
+      throw new ValidationError(
+        `No transition available from state ${transitionIdOrLabel}`,
+        {
+          code: 'INVALID_TRANSITION',
+          entityType: 'lifecycle node',
+          details: { transitionIdOrLabel: transitionIdOrLabel },
+        }
       );
     }
 

package/lib/logging.js

@@ -16,6 +16,7 @@
 
 const path = require('path');
 const rclnodejs = require('./native_loader.js');
+const { TypeValidationError } = require('./errors.js');
 
 /**
  * Enum for LoggingSeverity
@@ -98,7 +99,10 @@ class Logging {
    */
   setLoggerLevel(level) {
     if (typeof level !== 'number') {
-      throw new TypeError('Invalid argument');
+      throw new TypeValidationError('level', level, 'number', {
+        entityType: 'logger',
+        entityName: this._name,
+      });
     }
     rclnodejs.setLoggerLevel(this._name, level);
   }
@@ -164,7 +168,10 @@ class Logging {
 
   _log(message, severity) {
     if (typeof message !== 'string') {
-      throw new TypeError('Invalid argument');
+      throw new TypeValidationError('message', message, 'string', {
+        entityType: 'logger',
+        entityName: this._name,
+      });
     }
 
     let caller = new Caller();
@@ -204,7 +211,9 @@ class Logging {
    */
   static getLogger(name) {
     if (typeof name !== 'string') {
-      throw new TypeError('Invalid argument');
+      throw new TypeValidationError('name', name, 'string', {
+        entityType: 'logger',
+      });
     }
     return new Logging(name);
   }

package/lib/message_serialization.js

@@ -14,6 +14,8 @@
 
 'use strict';
 
+const { ValidationError } = require('./errors.js');
+
 /**
  * Check if a value is a TypedArray
  * @param {*} value - The value to check
@@ -145,8 +147,14 @@ function applySerializationMode(message, serializationMode) {
       return toJSONSafe(message);
 
     default:
-      throw new TypeError(
-        `Invalid serializationMode: ${serializationMode}. Valid modes are: 'default', 'plain', 'json'`
+      throw new ValidationError(
+        `Invalid serializationMode: ${serializationMode}. Valid modes are: 'default', 'plain', 'json'`,
+        {
+          code: 'INVALID_SERIALIZATION_MODE',
+          argumentName: 'serializationMode',
+          providedValue: serializationMode,
+          expectedType: "'default' | 'plain' | 'json'",
+        }
       );
   }
 }

package/lib/native_loader.js

@@ -17,6 +17,7 @@
 const fs = require('fs');
 const path = require('path');
 const { execSync } = require('child_process');
+const { NativeError } = require('./errors.js');
 const bindings = require('bindings');
 const debug = require('debug')('rclnodejs');
 const { detectUbuntuCodename } = require('./utils');
@@ -100,8 +101,10 @@ function loadNativeAddon() {
       return nativeModule;
     } catch (compileError) {
       debug('Forced compilation failed:', compileError.message);
-      throw new Error(
-        `Failed to force build rclnodejs from source: ${compileError.message}`
+      throw new NativeError(
+        `Failed to force build rclnodejs from source: ${compileError.message}`,
+        'Forced compilation',
+        { cause: compileError }
       );
     }
   }
@@ -163,8 +166,10 @@ function loadNativeAddon() {
       return nativeModule;
     } catch (compileError) {
       debug('Compilation failed:', compileError.message);
-      throw new Error(
-        `Failed to build rclnodejs from source: ${compileError.message}`
+      throw new NativeError(
+        `Failed to build rclnodejs from source: ${compileError.message}`,
+        'Compilation',
+        { cause: compileError }
       );
     }
   }