pumuki-ast-hooks 5.5.46 → 5.5.48

package/scripts/hooks-system/infrastructure/ast/ios/detectors/ios-god-class-detector.js

@@ -0,0 +1,79 @@
+const { SyntaxKind } = require('../ast-core');
+
+function analyzeGodClasses(sourceFile, findings, pushFinding, godClassBaseline) {
+    if (!godClassBaseline) return;
+
+    sourceFile.getDescendantsOfKind(SyntaxKind.ClassDeclaration).forEach((cls) => {
+        const className = cls.getName() || '';
+        const isValueObject = /DTO$|ViewModel$|State$|Props$|Entity$/.test(className);
+        const isTestClass = /Spec$|Test$|Mock/.test(className);
+        if (isValueObject || isTestClass) return;
+
+        const methodsCount = cls.getMethods().length;
+        const propertiesCount = cls.getProperties().length;
+        const startLine = cls.getStartLineNumber();
+        const endLine = cls.getEndLineNumber();
+        const lineCount = Math.max(0, endLine - startLine);
+
+        const decisionKinds = [
+            SyntaxKind.IfStatement,
+            SyntaxKind.ForStatement,
+            SyntaxKind.ForInStatement,
+            SyntaxKind.ForOfStatement,
+            SyntaxKind.WhileStatement,
+            SyntaxKind.DoStatement,
+            SyntaxKind.SwitchStatement,
+            SyntaxKind.ConditionalExpression,
+            SyntaxKind.TryStatement,
+            SyntaxKind.CatchClause
+        ];
+        const complexity = decisionKinds.reduce((acc, kind) => acc + cls.getDescendantsOfKind(kind).length, 0);
+
+        const clsText = cls.getFullText();
+        const concerns = new Set();
+        if (/URLSession|URLRequest|Alamofire|HTTP/i.test(clsText)) concerns.add('network');
+        if (/CoreData|Realm|SQLite|Persistence/i.test(clsText)) concerns.add('persistence');
+        if (/DispatchQueue|asyncAfter|Timer/i.test(clsText)) concerns.add('async');
+        if (/CryptoKit|Keychain|JWT|token|bearer/i.test(clsText)) concerns.add('security');
+        if (/NotificationCenter|push|local notification/i.test(clsText)) concerns.add('notifications');
+        if (/UIKit|SwiftUI|View/i.test(clsText)) concerns.add('ui');
+        if (/Logger|print\(/i.test(clsText)) concerns.add('logging');
+        const concernCount = concerns.size;
+
+        const methodsZ = godClassBaseline.robustZ(methodsCount, godClassBaseline.med.methodsCount, godClassBaseline.mad.methodsCount);
+        const propsZ = godClassBaseline.robustZ(propertiesCount, godClassBaseline.med.propertiesCount, godClassBaseline.mad.propertiesCount);
+        const linesZ = godClassBaseline.robustZ(lineCount, godClassBaseline.med.lineCount, godClassBaseline.mad.lineCount);
+        const complexityZ = godClassBaseline.robustZ(complexity, godClassBaseline.med.complexity, godClassBaseline.mad.complexity);
+
+        const sizeOutlier =
+            methodsZ >= godClassBaseline.thresholds.outlier.methodsCountZ ||
+            propsZ >= godClassBaseline.thresholds.outlier.propertiesCountZ ||
+            linesZ >= godClassBaseline.thresholds.outlier.lineCountZ;
+        const complexityOutlier = complexityZ >= godClassBaseline.thresholds.outlier.complexityZ;
+        const concernOutlier = concernCount >= godClassBaseline.thresholds.outlier.concerns;
+
+        const isMassiveFile = lineCount > 500;
+        const isAbsoluteGod = lineCount > 900 ||
+            (lineCount > 450 && complexity > 50) ||
+            (lineCount > 450 && methodsCount > 20) ||
+            (lineCount > 550 && methodsCount > 25 && complexity > 70);
+        const isUnderThreshold = lineCount < 280 && methodsCount < 15 && complexity < 28;
+
+        let signalCount = 0;
+        if (sizeOutlier) signalCount++;
+        if (complexityOutlier) signalCount++;
+        if (concernOutlier) signalCount++;
+        if (isMassiveFile) signalCount++;
+
+        if (!isUnderThreshold && (signalCount >= 2 || isAbsoluteGod)) {
+            pushFinding("backend.antipattern.god_classes", "critical", sourceFile, cls,
+                `God class detected: ${methodsCount} methods, ${propertiesCount} properties, ${lineCount} lines, complexity ${complexity}, concerns ${concernCount} - VIOLATES SRP`,
+                findings
+            );
+        }
+    });
+}
+
+module.exports = {
+    analyzeGodClasses,
+};

package/scripts/hooks-system/infrastructure/ast/ios/native-bridge.js

@@ -16,7 +16,10 @@ function getStagedSwiftFiles(repoRoot) {
       .map(s => s.trim())
       .filter(Boolean)
       .filter(p => p.endsWith('.swift'));
-  } catch {
+  } catch (error) {
+    if (process.env.DEBUG) {
+      console.debug(`[iOS NativeBridge] Failed to read staged swift files: ${error.message}`);
+    }
     return [];
   }
 }

package/skills/android-guidelines/SKILL.md

@@ -34,6 +34,7 @@ Automatically activates when working on:
 - [ ] **ViewModel**: Presentation/ui/{feature}/ViewModel
 - [ ] **Tests**: Unit + integration tests
 - [ ] **Error Handling**: Sealed class Result<T>
+- [ ] **No empty catch**: Prohibido silenciar errores en tooling (AST: common.error.empty_catch)
 
 ### New Module Checklist
 

package/skills/backend-guidelines/SKILL.md

@@ -33,6 +33,7 @@ Automatically activates when working on:
 - [ ] **Entity**: Domain model in domain/entities/
 - [ ] **Tests**: Unit + integration tests
 - [ ] **Error Handling**: Custom exceptions
+- [ ] **No empty catch**: Prohibido `catch` vacío (AST: common.error.empty_catch)
 
 ### New Module Checklist
 

package/skills/frontend-guidelines/SKILL.md

@@ -36,6 +36,7 @@ Creating a component? Follow this checklist:
 - [ ] **i18n** - Use translation hooks, no hardcoded strings
 - [ ] **Performance** - useMemo, useCallback when appropriate
 - [ ] **Testing** - React Testing Library tests
+- [ ] **No empty catch** - Prohibido silenciar errores (AST: common.error.empty_catch)
 
 ### New Feature Checklist
 

package/skills/ios-guidelines/SKILL.md

@@ -34,6 +34,7 @@ Automatically activates when working on:
 - [ ] **ViewModel**: Application/ViewModels/ (if needed)
 - [ ] **Tests**: Unit + integration tests
 - [ ] **Error Handling**: Custom Error enum
+- [ ] **No empty catch**: Prohibido `catch` vacío (AST: common.error.empty_catch)
 
 ### New Module Checklist