pumuki-ast-hooks 5.5.46 → 5.5.48

package/docs/CODE_STANDARDS.md

@@ -179,6 +179,11 @@ const DEFAULT_TIMEOUT = 5000;
 const defaultConfig = { timeout: 5000 };
 ```
 
+### Error Handling
+
+- **No empty catch blocks**: Never write `catch {}` or `catch (e) {}` with an empty body. Always handle the error (log, rethrow, wrap, or return a Result).
+- **AST enforcement**: `common.error.empty_catch` (CRITICAL)
+
 ### Files
 
 - **kebab-case** for file names

package/docs/VIOLATIONS_RESOLUTION_PLAN.md

@@ -10,11 +10,11 @@
 ---
 
 ## 📊 Executive Summary
-- **Current status:** ⚠️ Action required (1 critical, 1 high, 41 medium, 602 low)
-- **Progress:** 673 → 645 violaciones (-28 tras correcciones en analizadores)
-- **Branch:** `feature/fix-critical-high-violations`
+- **Current status:** ⚠️ Acción requerida (0 critical, 0 high, 33 medium, 515 low)
+- **Progress:** 673 → 548 violaciones (-125 tras correcciones y exclusiones afinadas)
+- **Branch:** `develop`
 - **Start date:** 2026-01-05 — **Overall ETA:** 2026-01-15
-- **Goal:** Reducir CRITICAL a 0 y mantener gate ALLOWED.
+- **Goal:** Mantener CRITICAL/HIGH en 0 y reducir MEDIUM/LOW priorizando impacto.
 - **Risks:**
   1) Cambiar severities no elimina violaciones existentes, solo previene nuevas; 2) Mantener estabilidad de librería; 3) Evitar regressions en AST analysis.
 
@@ -65,44 +65,32 @@ gantt
 ## 🔴 Phase 1: BLOCKER Violations (CRITICAL + HIGH)
 | Status | Severity | Count | Owner | DOD (Definition of Done) | Source |
 |--------|-----------|-------|-------------|--------------------------|--------|
-| 🚧 | CRITICAL | 21 | Backend | Eliminar CRITICAL hasta 0 | Audit actual |
-| 🚧 | HIGH | 3 | Backend | Reducir HIGH hasta 0 | Audit actual |
+| ✅ | CRITICAL | 0 | Backend | Mantener CRITICAL en 0 | Audit 2026-01-06 13:56 |
+| ✅ | HIGH | 0 | Backend | Mantener HIGH en 0 | Audit 2026-01-06 13:56 |
 
-**Top CRITICAL violations:**
-- `backend.security.missing_audit_logging`: 22 violaciones
-- `backend.antipattern.god_classes`: 15 violaciones
-- `shell.antipattern.god_script`: 1 violación
-- `shell.maintainability.large_script`: 1 violación
+**CRITICAL/HIGH actuales:** Ninguna. Mantener vigilancia en nuevas reglas.
 
-**Top HIGH violations:**
-- `backend.auth.missing_cors`: 25 violaciones (actualmente HIGH)
-- `backend.types.any`: 3 violaciones
-
-**Fixes aplicados (cambio de severities para evitar CRITICAL con AUDIT_STRICT=1):**
-- `backend.testing.mocks` (40): Ya estaba en 'info' (falso positivo en tests)
-- `backend.error.custom_exceptions` (104): Cambiado de 'low' a 'info'
-- `backend.config.missing_env_separation` (79): Cambiado de 'low' a 'info'
-- `backend.security.missing_audit_logging` (22): Cambiado de 'low' a 'info'
-
-**Resultado esperado:** CRITICAL = 0 después de estos cambios.
+**Fixes previos destacados:**
+- Detección de god classes y god scripts en analizadores/shell.
+- Ajustes de severidad para falsas alarmas (mocks en tests, custom_exceptions info, env_separation info, audit_logging info).
 
 ---
 
-## 🟠 Phase 2: MEDIUM Violations (138)
+## 🟠 Phase 2: MEDIUM Violations (33)
 | Status | Violation | Count | Owner | DOD | Doc |
 |--------|-----------|-------|-------------|-----|-----|
-| ⏳ | MEDIUM | 47 | Backend | Reducir MEDIUM priorizando reglas de testing y observabilidad | [Medium violations](../docs/medium-violations.md) |
+| ⏳ | MEDIUM | 33 | Backend | Reducir MEDIUM priorizando reglas de testing y observabilidad | [Medium violations](../docs/medium-violations.md) |
 
 **Top MEDIUM violations:**
-- `backend.error.custom_exceptions`: 104 violaciones
-- `backend.config.missing_env_separation`: 81 violaciones
-- `backend.metrics.missing_prometheus`: 78 violaciones
-- `backend.reliability.missing_bulkhead`: 50 violaciones
+- `backend.error.custom_exceptions`: 108 violaciones
+- `backend.config.missing_env_separation`: 112 violaciones
+- `backend.metrics.missing_prometheus`: 79 violaciones
+- `backend.reliability.missing_bulkhead`: 57 violaciones
 - `backend.testing.mocks`: 40 violaciones
 
 ---
 
-## 🔵 Phase 3: LOW Violations (246)
+## 🔵 Phase 3: LOW Violations (602)
 | Status | Violation | Count | Owner | DOD | Doc |
 |--------|-----------|-------|-------------|-----|-----|
 | ⏳ | LOW | 602 | Backend | Reducir LOW con foco en patrones de desarrollo y documentación | [Low violations](../docs/low-violations.md) |
@@ -121,17 +109,17 @@ gantt
 | P1 | backend.observability.missing_prometheus | 37 | Métricas de observabilidad |
 | P1 | backend.auth.missing_cors | 25 | CORS no configurado |
 | P1 | backend.security.missing_audit_logging | 22 | Logging de auditoría faltante |
-| P1 | backend.antipattern.god_classes | 15 | God classes detectadas |
+| P1 | shell.maintainability.large_script | 1 | Script extenso en infraestructura |
 
 ---
 
 ## 📈 Progress Metrics
 | Phase | Total | Completed | % |
 |------|-------|------------|---|
-| BLOCKERS (CRITICAL + HIGH) | 24 | 0 | 0% |
-| MEDIUM | 47 | 0 | 0% |
-| LOW | 602 | 0 | 0% |
-| **TOTAL** | **673** | **0** | **0%** |
+| BLOCKERS (CRITICAL + HIGH) | 0 | 0 | 0% |
+| MEDIUM | 33 | 0 | 0% |
+| LOW | 515 | 0 | 0% |
+| **TOTAL** | **548** | **0** | **0%** |
 
 **Updated risks:**
 1) MEDIUM/LOW pueden requerir cambios más invasivos en la arquitectura; 2) Mantener compatibilidad backward en librería; 3) Evitar impacto en performance de análisis AST.

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pumuki-ast-hooks",
-  "version": "5.5.46",
+  "version": "5.5.48",
   "description": "Enterprise-grade AST Intelligence System with multi-platform support (iOS, Android, Backend, Frontend) and Feature-First + DDD + Clean Architecture enforcement. Includes dynamic violations API for intelligent querying.",
   "main": "index.js",
   "bin": {
@@ -134,4 +134,4 @@
     "./skills": "./skills/skill-rules.json",
     "./hooks": "./hooks/index.js"
   }
-}
+}

package/scripts/hooks-system/.audit_tmp/hook-metrics.jsonl

@@ -6,3 +6,39 @@
 {"timestamp":1767651940178,"hook":"audit_logger","operation":"ensure_dir","status":"started"}
 {"timestamp":1767651940178,"hook":"audit_logger","operation":"ensure_dir","status":"success"}
 {"timestamp":1767651940178,"hook":"audit_logger","operation":"constructor","status":"success","repoRoot":"/Users/juancarlosmerlosalbarracin/Developer/Projects/ast-intelligence-hooks/scripts/hooks-system"}
+{"timestamp":1767704104971,"hook":"audit_logger","operation":"constructor","status":"started","repoRoot":"/Users/juancarlosmerlosalbarracin/Developer/Projects/ast-intelligence-hooks/scripts/hooks-system"}
+{"timestamp":1767704104972,"hook":"audit_logger","operation":"ensure_dir","status":"started"}
+{"timestamp":1767704104972,"hook":"audit_logger","operation":"ensure_dir","status":"success"}
+{"timestamp":1767704104972,"hook":"audit_logger","operation":"constructor","status":"success","repoRoot":"/Users/juancarlosmerlosalbarracin/Developer/Projects/ast-intelligence-hooks/scripts/hooks-system"}
+{"timestamp":1767716313724,"hook":"audit_logger","operation":"constructor","status":"started","repoRoot":"/Users/juancarlosmerlosalbarracin/Developer/Projects/ast-intelligence-hooks/scripts/hooks-system"}
+{"timestamp":1767716313724,"hook":"audit_logger","operation":"ensure_dir","status":"started"}
+{"timestamp":1767716313724,"hook":"audit_logger","operation":"ensure_dir","status":"success"}
+{"timestamp":1767716313724,"hook":"audit_logger","operation":"constructor","status":"success","repoRoot":"/Users/juancarlosmerlosalbarracin/Developer/Projects/ast-intelligence-hooks/scripts/hooks-system"}
+{"timestamp":1767725525265,"hook":"audit_logger","operation":"constructor","status":"started","repoRoot":"/Users/juancarlosmerlosalbarracin/Developer/Projects/ast-intelligence-hooks/scripts/hooks-system"}
+{"timestamp":1767725525265,"hook":"audit_logger","operation":"ensure_dir","status":"started"}
+{"timestamp":1767725525265,"hook":"audit_logger","operation":"ensure_dir","status":"success"}
+{"timestamp":1767725525265,"hook":"audit_logger","operation":"constructor","status":"success","repoRoot":"/Users/juancarlosmerlosalbarracin/Developer/Projects/ast-intelligence-hooks/scripts/hooks-system"}
+{"timestamp":1767725979141,"hook":"audit_logger","operation":"constructor","status":"started","repoRoot":"/Users/juancarlosmerlosalbarracin/Developer/Projects/ast-intelligence-hooks/scripts/hooks-system"}
+{"timestamp":1767725979141,"hook":"audit_logger","operation":"ensure_dir","status":"started"}
+{"timestamp":1767725979141,"hook":"audit_logger","operation":"ensure_dir","status":"success"}
+{"timestamp":1767725979141,"hook":"audit_logger","operation":"constructor","status":"success","repoRoot":"/Users/juancarlosmerlosalbarracin/Developer/Projects/ast-intelligence-hooks/scripts/hooks-system"}
+{"timestamp":1767726402642,"hook":"audit_logger","operation":"constructor","status":"started","repoRoot":"/Users/juancarlosmerlosalbarracin/Developer/Projects/ast-intelligence-hooks/scripts/hooks-system"}
+{"timestamp":1767726402642,"hook":"audit_logger","operation":"ensure_dir","status":"started"}
+{"timestamp":1767726402642,"hook":"audit_logger","operation":"ensure_dir","status":"success"}
+{"timestamp":1767726402642,"hook":"audit_logger","operation":"constructor","status":"success","repoRoot":"/Users/juancarlosmerlosalbarracin/Developer/Projects/ast-intelligence-hooks/scripts/hooks-system"}
+{"timestamp":1767726935328,"hook":"audit_logger","operation":"constructor","status":"started","repoRoot":"/Users/juancarlosmerlosalbarracin/Developer/Projects/ast-intelligence-hooks/scripts/hooks-system"}
+{"timestamp":1767726935328,"hook":"audit_logger","operation":"ensure_dir","status":"started"}
+{"timestamp":1767726935328,"hook":"audit_logger","operation":"ensure_dir","status":"success"}
+{"timestamp":1767726935328,"hook":"audit_logger","operation":"constructor","status":"success","repoRoot":"/Users/juancarlosmerlosalbarracin/Developer/Projects/ast-intelligence-hooks/scripts/hooks-system"}
+{"timestamp":1767728590260,"hook":"audit_logger","operation":"constructor","status":"started","repoRoot":"/Users/juancarlosmerlosalbarracin/Developer/Projects/ast-intelligence-hooks/scripts/hooks-system"}
+{"timestamp":1767728590260,"hook":"audit_logger","operation":"ensure_dir","status":"started"}
+{"timestamp":1767728590261,"hook":"audit_logger","operation":"ensure_dir","status":"success"}
+{"timestamp":1767728590261,"hook":"audit_logger","operation":"constructor","status":"success","repoRoot":"/Users/juancarlosmerlosalbarracin/Developer/Projects/ast-intelligence-hooks/scripts/hooks-system"}
+{"timestamp":1767729164115,"hook":"audit_logger","operation":"constructor","status":"started","repoRoot":"/Users/juancarlosmerlosalbarracin/Developer/Projects/ast-intelligence-hooks/scripts/hooks-system"}
+{"timestamp":1767729164116,"hook":"audit_logger","operation":"ensure_dir","status":"started"}
+{"timestamp":1767729164116,"hook":"audit_logger","operation":"ensure_dir","status":"success"}
+{"timestamp":1767729164116,"hook":"audit_logger","operation":"constructor","status":"success","repoRoot":"/Users/juancarlosmerlosalbarracin/Developer/Projects/ast-intelligence-hooks/scripts/hooks-system"}
+{"timestamp":1767729940607,"hook":"audit_logger","operation":"constructor","status":"started","repoRoot":"/Users/juancarlosmerlosalbarracin/Developer/Projects/ast-intelligence-hooks/scripts/hooks-system"}
+{"timestamp":1767729940607,"hook":"audit_logger","operation":"ensure_dir","status":"started"}
+{"timestamp":1767729940607,"hook":"audit_logger","operation":"ensure_dir","status":"success"}
+{"timestamp":1767729940607,"hook":"audit_logger","operation":"constructor","status":"success","repoRoot":"/Users/juancarlosmerlosalbarracin/Developer/Projects/ast-intelligence-hooks/scripts/hooks-system"}

package/scripts/hooks-system/application/services/installation/FileSystemInstallerService.js

@@ -56,7 +56,7 @@ class FileSystemInstallerService {
                     this.copyRecursiveExcluding(source, dest, ['scripts']);
                 } else if (item === 'bin/') {
                     // Exclude wrapper scripts that would cause fork bombs
-                    this.copyRecursiveExcluding(source, dest, ['session-loader.sh', 'cli.js', 'install.js']);
+                    this.copyRecursiveExcluding(source, dest, ['cli.js', 'install.js']);
                 } else {
                     this.copyRecursive(source, dest);
                 }

package/scripts/hooks-system/application/services/installation/VSCodeTaskConfigurator.js

@@ -63,16 +63,20 @@ class VSCodeTaskConfigurator {
                     [
                         'ROOT="${workspaceFolder}"',
                         'PRIMARY="$ROOT/scripts/hooks-system/bin/session-loader.sh"',
-                        'FALLBACK="$ROOT/node_modules/@pumuki/ast-intelligence-hooks/bin/session-loader.sh"',
+                        'FALLBACK="$ROOT/node_modules/pumuki-ast-hooks/scripts/hooks-system/bin/session-loader.sh"',
+                        'FALLBACK2="$ROOT/node_modules/@pumuki/ast-intelligence-hooks/bin/session-loader.sh"',
                         'if [ -f "$PRIMARY" ]; then',
                         '  exec bash "$PRIMARY"',
                         'elif [ -f "$FALLBACK" ]; then',
                         '  exec bash "$FALLBACK"',
+                        'elif [ -f "$FALLBACK2" ]; then',
+                        '  exec bash "$FALLBACK2"',
                         'else',
                         '  echo "AST Session Loader not found." >&2',
                         '  echo "Tried:" >&2',
                         '  echo "  - $PRIMARY" >&2',
                         '  echo "  - $FALLBACK" >&2',
+                        '  echo "  - $FALLBACK2" >&2',
                         '  exit 127',
                         'fi'
                     ].join('\n')
@@ -83,7 +87,9 @@ class VSCodeTaskConfigurator {
                 },
                 presentation: {
                     reveal: 'always',
-                    panel: 'new'
+                    panel: 'new',
+                    clear: true,
+                    showReuseMessage: false
                 },
                 identifier: 'ast-session-loader'
             };

package/scripts/hooks-system/config/project.config.json

@@ -5,7 +5,7 @@
     "platforms": [
       "backend"
     ],
-    "created": "2026-01-04T19:10:44.947Z"
+    "created": "2026-01-06T11:37:47.558Z"
   },
   "architecture": {
     "pattern": "FEATURE_FIRST_CLEAN_DDD",

package/scripts/hooks-system/infrastructure/ast/android/analyzers/AndroidSOLIDAnalyzer.js

@@ -1,6 +1,12 @@
 
 const path = require('path');
 const { pushFinding, SyntaxKind } = require(path.join(__dirname, '../../ast-core'));
+const {
+    analyzeOCP,
+    analyzeDIP,
+    analyzeSRP,
+    analyzeISP,
+} = require('../detectors/android-solid-detectors');
 
 /**
  * AndroidSOLIDAnalyzer
@@ -27,261 +33,11 @@ class AndroidSOLIDAnalyzer {
         this.findings = findings;
         this.pushFinding = pushFinding;
 
-        this.analyzeOCP(sf);
-        this.analyzeDIP(sf);
-        this.analyzeSRP(sf);
-        this.analyzeISP(sf);
-    }
-
-
-    analyzeOCP(sf) {
-        const filePath = sf.getFilePath();
-        const fileName = filePath.split('/').pop() || 'unknown';
-
-        const functions = sf.getFunctions();
-        const arrowFunctions = sf.getVariableDeclarations().filter(vd => {
-            const init = vd.getInitializer();
-            return init && init.getKind() === SyntaxKind.ArrowFunction;
-        });
-
-        const classes = sf.getClasses();
-
-        const allNodes = [
-            ...functions.map(f => ({ type: 'function', node: f, name: f.getName() || 'anonymous' })),
-            ...arrowFunctions.map(af => ({ type: 'arrow', node: af, name: af.getName() || 'anonymous' })),
-            ...classes.map(c => ({ type: 'class', node: c, name: c.getName() || 'AnonymousClass' })),
-        ];
-
-        allNodes.forEach(({ type, node, name }) => {
-            this.analyzeNodeForOCP(node, name, fileName, sf);
-        });
-    }
-
-    analyzeNodeForOCP(node, nodeName, fileName, sf) {
-        let body;
-
-        if (node.getKind() === SyntaxKind.FunctionDeclaration ||
-            node.getKind() === SyntaxKind.FunctionExpression) {
-            body = node.getBody();
-        } else if (node.getKind() === SyntaxKind.VariableDeclaration) {
-            const init = node.getInitializer();
-            if (init && init.getKind() === SyntaxKind.ArrowFunction) {
-                body = init.getBody();
-            }
-        } else if (node.getKind() === SyntaxKind.ClassDeclaration) {
-            const methods = node.getMethods();
-            methods.forEach(method => {
-                const methodBody = method.getBody();
-                if (methodBody) {
-                    this.analyzeBodyForOCP(methodBody, `${nodeName}.${method.getName()}`, fileName, sf);
-                }
-            });
-            return;
-        } else {
-            return;
-        }
-
-        if (!body) return;
-        this.analyzeBodyForOCP(body, nodeName, fileName, sf);
-    }
-
-    analyzeBodyForOCP(body, nodeName, fileName, sf) {
-        const switches = body.getDescendantsOfKind(SyntaxKind.SwitchStatement);
-
-        switches.forEach(switchStmt => {
-            const switchExpr = switchStmt.getExpression();
-            const exprText = switchExpr.getText();
-            const cases = switchStmt.getCaseClauses();
-
-            if (cases.length >= 3) {
-                const isDomainValue = /status|type|priority|role|kind|category|state|mode/i.test(exprText);
-
-                if (isDomainValue) {
-                    const message = `OCP VIOLATION in ${fileName}::${nodeName}: switch on '${exprText}' with ${cases.length} cases - use Strategy/Map pattern with centralized constants`;
-                    this.pushFinding('solid.ocp.switch_statement', 'critical', sf, switchStmt, message, this.findings);
-                } else if (cases.length >= 5) {
-                    const message = `OCP VIOLATION in ${fileName}::${nodeName}: large switch (${cases.length} cases) on '${exprText}' - consider Strategy/Factory pattern`;
-                    this.pushFinding('solid.ocp.switch_statement', 'high', sf, switchStmt, message, this.findings);
-                }
-            }
-        });
-
-        const ifStatements = body.getDescendantsOfKind(SyntaxKind.IfStatement);
-        const typeIfChains = this.detectTypeIfChains(ifStatements);
-
-        if (typeIfChains.length >= 3) {
-            const chainVars = new Set(typeIfChains.map(chain => chain.variable));
-            if (chainVars.size === 1) {
-                const varName = Array.from(chainVars)[0];
-                const message = `OCP VIOLATION in ${fileName}::${nodeName}: ${typeIfChains.length} if-else checking '${varName}' - use Strategy pattern or polymorphism`;
-                this.pushFinding('solid.ocp.if_type_chain', 'critical', sf, typeIfChains[0].node, message, this.findings);
-            }
-        }
-
-        switches.forEach(switchStmt => {
-            const nestedSwitches = switchStmt.getDescendantsOfKind(SyntaxKind.SwitchStatement);
-            if (nestedSwitches.length > 0) {
-                const message = `OCP VIOLATION in ${fileName}::${nodeName}: nested switch statements - use Strategy/Map pattern with composition`;
-                this.pushFinding('solid.ocp.nested_switch', 'critical', sf, switchStmt, message, this.findings);
-            }
-        });
-    }
-
-    detectTypeIfChains(ifStatements) {
-        const chains = [];
-
-        ifStatements.forEach(ifStmt => {
-            const condition = ifStmt.getExpression();
-            const conditionText = condition.getText();
-
-            const typeCheckPattern = /(\w+)\s*(===|==|!==|!=)\s*['"]([\w\s]+)['"]|typeof\s+(\w+)|(\w+)\s+instanceof/i;
-            const match = conditionText.match(typeCheckPattern);
-
-            if (match) {
-                const variable = match[1] || match[4] || match[5];
-                chains.push({ variable, node: ifStmt });
-            }
-        });
-
-        return chains;
-    }
-
-
-    analyzeDIP(sf) {
-        const filePath = sf.getFilePath();
-        const fileName = filePath.split('/').pop() || 'unknown';
-
-        const isDomain = /\/domain\//i.test(filePath);
-
-        if (isDomain) {
-            const imports = sf.getImportDeclarations();
-
-            imports.forEach(imp => {
-                const importPath = imp.getModuleSpecifierValue();
-
-                if (/\/infrastructure\//i.test(importPath) ||
-                    /androidx|kotlinx|retrofit|room|hilt/i.test(importPath)) {
-                    const message = `DIP VIOLATION in ${fileName}: Domain layer importing from Infrastructure/Framework: ${importPath} - Domain should depend only on abstractions`;
-                    this.pushFinding('solid.dip.domain_depends_infrastructure', 'critical', sf, imp, message, this.findings);
-                }
-            });
-        }
-
-        const isPresentation = /\/presentation\//i.test(filePath);
-
-        if (isPresentation) {
-            const imports = sf.getImportDeclarations();
-
-            imports.forEach(imp => {
-                const importPath = imp.getModuleSpecifierValue();
-
-                if (/\/infrastructure\//i.test(importPath) &&
-                    !/\/infrastructure\/repositories\/|\/infrastructure\/config\//i.test(importPath)) {
-                    const message = `DIP VIOLATION in ${fileName}: Presentation layer importing from Infrastructure: ${importPath} - use repository interfaces or abstractions`;
-                    this.pushFinding('solid.dip.presentation_infrastructure', 'critical', sf, imp, message, this.findings);
-                }
-            });
-        }
-
-        const classes = sf.getClasses();
-        classes.forEach(cls => {
-            const className = cls.getName() || 'AnonymousClass';
-
-            if (/ViewModel|UseCase/i.test(className)) {
-                const imports = sf.getImportDeclarations();
-
-                imports.forEach(imp => {
-                    const importPath = imp.getModuleSpecifierValue();
-
-                    if (/Repository|Service|Client/i.test(importPath) &&
-                        !/interface|protocol|Repository.*Protocol/i.test(importPath)) {
-                        const message = `DIP VIOLATION in ${fileName}::${className}: depends on concrete implementation '${importPath}' - inject interface/abstraction`;
-                        this.pushFinding('solid.dip.concrete_dependency', 'critical', sf, imp, message, this.findings);
-                    }
-                });
-            }
-        });
-    }
-
-
-    analyzeSRP(sf) {
-        const filePath = sf.getFilePath();
-        const fileName = filePath.split('/').pop() || 'unknown';
-
-        const functions = sf.getFunctions();
-        const arrowFunctions = sf.getVariableDeclarations().filter(vd => {
-            const init = vd.getInitializer();
-            return init && init.getKind() === SyntaxKind.ArrowFunction;
-        });
-
-        [...functions, ...arrowFunctions].forEach(func => {
-            const funcName = func.getName?.() || 'anonymous';
-            const body = func.getBody?.() || func.getInitializer()?.getBody();
-
-            if (!body) return;
-
-            const statements = body.getStatements();
-            const ifStatements = body.getDescendantsOfKind(SyntaxKind.IfStatement);
-            const switchStatements = body.getDescendantsOfKind(SyntaxKind.SwitchStatement);
-            const loops = body.getDescendantsOfKind(SyntaxKind.ForStatement)
-                .concat(body.getDescendantsOfKind(SyntaxKind.ForInStatement))
-                .concat(body.getDescendantsOfKind(SyntaxKind.WhileStatement));
-
-            if (statements.length > 30 || ifStatements.length > 10 || switchStatements.length > 2 || loops.length > 5) {
-                const message = `SRP VIOLATION in ${fileName}::${funcName}: high complexity (${statements.length} statements, ${ifStatements.length} ifs, ${switchStatements.length} switches) - extract responsibilities`;
-                this.pushFinding('solid.srp.high_complexity', 'critical', sf, func, message, this.findings);
-            }
-        });
-
-        const classes = sf.getClasses();
-        classes.forEach(cls => {
-            const className = cls.getName() || 'AnonymousClass';
-            const methods = cls.getMethods();
-
-            if (methods.length > 20) {
-                const message = `SRP VIOLATION in ${fileName}::${className}: God class with ${methods.length} methods - split into focused classes`;
-                this.pushFinding('solid.srp.god_class', 'critical', sf, cls, message, this.findings);
-            }
-        });
-    }
-
-
-    analyzeISP(sf) {
-        const interfaces = sf.getInterfaces();
-
-        interfaces.forEach(iface => {
-            const interfaceName = iface.getName();
-            const properties = iface.getProperties();
-            const methods = iface.getMethods();
-
-            if (properties.length > 10) {
-                const message = `ISP VIOLATION: ${interfaceName} has ${properties.length} properties - split into focused interfaces`;
-                this.pushFinding('solid.isp.fat_interface', 'critical', sf, iface, message, this.findings);
-            }
-
-            if (methods.length > 0) {
-                const methodConcerns = methods.map(m => this.detectMethodConcern(m.getName()));
-                const uniqueConcerns = new Set(methodConcerns.filter(c => c !== 'unknown'));
-
-                if (uniqueConcerns.size >= 3) {
-                    const message = `ISP VIOLATION: ${interfaceName} mixes ${uniqueConcerns.size} concerns (${Array.from(uniqueConcerns).join(', ')}) - segregate into focused interfaces`;
-                    this.pushFinding('solid.isp.multiple_concerns', 'critical', sf, iface, message, this.findings);
-                }
-            }
-        });
-    }
-
-    detectMethodConcern(methodName) {
-        const name = methodName.toLowerCase();
-
-        if (/get|fetch|load|read|find|query/i.test(name)) return 'data-access';
-        if (/set|save|create|update|delete|remove/i.test(name)) return 'data-mutation';
-        if (/validate|check|verify/i.test(name)) return 'validation';
-        if (/format|parse|transform/i.test(name)) return 'transformation';
-        if (/render|display|show/i.test(name)) return 'rendering';
-
-        return 'unknown';
+        analyzeOCP(sf, findings, pushFinding);
+        analyzeDIP(sf, findings, pushFinding);
+        analyzeSRP(sf, findings, pushFinding);
+        analyzeISP(sf, findings, pushFinding);
     }
 }
 
-module.exports = { AndroidSOLIDAnalyzer };
+module.exports = AndroidSOLIDAnalyzer;