prizmkit 1.1.154 → 1.1.156

package/bundled/dev-pipeline/scripts/generate-bugfix-prompt.py

@@ -14,13 +14,11 @@ import sys
 from continuation import add_continuation_args, append_continuation_handoff, is_continuation
 from prompt_framework import (
     browser_enabled_from_item,
-    checkpoint_group,
     checkpoint_step,
     detect_dev_server_port,
     generate_checkpoint_from_sections,
     load_section,
     merge_checkpoint_state,
-    normalize_mode,
     pipeline_checkpoint_metadata,
     read_text_file,
     render_from_sections,
@@ -63,10 +61,17 @@ BUGFIX_SECTION_TO_SKILL = {
     "bugfix-phase-init": checkpoint_step("prizmkit-init", "Initialize", [".prizmkit/bugfix/{slug}"]),
     "bugfix-phase-diagnose-plan": checkpoint_step(
         "bug-diagnosis-and-plan", "Diagnose & Plan",
-        [".prizmkit/bugfix/{slug}/spec.md", ".prizmkit/bugfix/{slug}/plan.md"],
+        [
+            ".prizmkit/bugfix/{slug}/context-snapshot.md",
+            ".prizmkit/bugfix/{slug}/spec.md",
+            ".prizmkit/bugfix/{slug}/plan.md",
+        ],
     ),
     "bugfix-phase-implement": checkpoint_step("prizmkit-implement", "Implement Fix", []),
-    "bugfix-phase-review": checkpoint_step("prizmkit-code-review", "Code Review", []),
+    "bugfix-phase-review": checkpoint_step(
+        "prizmkit-code-review", "Code Review",
+        [".prizmkit/bugfix/{slug}/review-report.md"],
+    ),
     "bugfix-phase-test": checkpoint_step(
         "prizmkit-test", "Post-Review Test Gate",
         [
@@ -75,11 +80,21 @@ BUGFIX_SECTION_TO_SKILL = {
         ],
     ),
     "phase-browser": checkpoint_step("browser-verification", "Browser Verification", []),
-    "bugfix-phase-commit-report": checkpoint_group([
-        ("prizmkit-retrospective", "Retrospective", []),
-        ("prizmkit-committer", "Commit", []),
-        ("bug-report", "Generate Fix Report", [".prizmkit/bugfix/{slug}/fix-report.md"]),
-    ]),
+    "bugfix-manual-gate": checkpoint_step(
+        "manual-verification", "Manual / Hybrid Verification", []
+    ),
+    "bugfix-phase-commit-report": checkpoint_step(
+        "bug-report", "Generate Fix Report",
+        [".prizmkit/bugfix/{slug}/fix-report.md"],
+    ),
+    "retrospective": checkpoint_step(
+        "prizmkit-retrospective", "Retrospective",
+        [".prizmkit/bugfix/{slug}/retrospective-result.json"],
+    ),
+    "runtime-commit-handoff": checkpoint_step(
+        "prizmkit-committer", "Runtime Commit Handoff",
+        [".prizmkit/bugfix/{slug}/runtime-commit-request.json"],
+    ),
 }
 
 BUGFIX_SPLIT_STEPS = {}
@@ -101,8 +116,12 @@ def parse_args():
     parser.add_argument("--state-dir", default=None, help="State directory (default: .prizmkit/state/bugfix)")
     parser.add_argument("--output", required=True, help="Output path for the rendered prompt")
     parser.add_argument("--project-root", default=None, help="AI-visible project root used for rendered prompt paths")
+    parser.add_argument(
+        "--no-checkpoint-write",
+        action="store_true",
+        help="Render and validate a preview without creating or updating checkpoint state",
+    )
     parser.add_argument("--template", default=None, help="Custom legacy template path. Defaults to section assembly.")
-    parser.add_argument("--mode", choices=["lite", "standard", "full"], default=None, help="Pipeline execution mode override")
     add_continuation_args(parser, "bugfix")
     return parser.parse_args()
 
@@ -255,16 +274,6 @@ def _args_project_root(args, script_dir):
     return resolve_project_root(script_dir)
 
 
-def determine_bugfix_mode(args, bug):
-    if args.mode:
-        return args.mode
-    return normalize_mode(
-        {"low": "lite", "medium": "lite", "high": "standard", "critical": "full"}.get(
-            str(bug.get("severity", "medium")).lower(), "lite"
-        )
-    )
-
-
 def is_recovery_like(args):
     retry_count = 0
     try:
@@ -279,13 +288,6 @@ def build_replacements(args, bug, global_context, script_dir):
     project_root = _args_project_root(args, script_dir)
     resolve_prompt_platform(project_root)
 
-    state_dir = (
-        os.path.abspath(args.state_dir)
-        if args.state_dir
-        else os.path.join(project_root, ".prizmkit", "state", "bugfix")
-    )
-    session_status_path = os.path.join(state_dir, args.bug_id, "sessions", args.session_id, "session-status.json")
-
     error_source = bug.get("error_source", {})
     error_type = error_source.get("type", "unknown") if isinstance(error_source, dict) else "unknown"
     affected_modules = bug.get("affected_modules", [])
@@ -296,7 +298,6 @@ def build_replacements(args, bug, global_context, script_dir):
     dev_port = detect_dev_server_port(project_root)
     dev_url = "http://localhost:{}".format(dev_port) if dev_port.isdigit() else "<UNKNOWN_DETECT_FROM_PROJECT_CONFIG>"
 
-    pipeline_mode = determine_bugfix_mode(args, bug)
     manual_or_hybrid = verification_type in ("manual", "hybrid")
     manual_policy = (
         "Manual/hybrid verification is executed automatically in headless mode: use available browser, CLI, API, fixture, and test evidence; document the verification evidence and proceed through review, test, retrospective, and commit."
@@ -313,7 +314,6 @@ def build_replacements(args, bug, global_context, script_dir):
         "{{TASK_TITLE}}": bug.get("title", ""),
         "{{BUG_TITLE}}": bug.get("title", ""),
         "{{SEVERITY}}": bug.get("severity", "medium"),
-        "{{PIPELINE_MODE}}": pipeline_mode,
         "{{VERIFICATION_TYPE}}": verification_type,
         "{{MANUAL_VERIFICATION_POLICY}}": manual_policy,
         "{{BUG_DESCRIPTION}}": bug.get("description", ""),
@@ -324,9 +324,9 @@ def build_replacements(args, bug, global_context, script_dir):
         "{{AC_CHECKLIST}}": format_ac_checklist(bug.get("acceptance_criteria", [])),
         "{{ENVIRONMENT}}": format_environment(bug.get("environment")),
         "{{GLOBAL_CONTEXT}}": format_global_context(global_context, project_root),
-        "{{SESSION_STATUS_PATH}}": session_status_path,
         "{{PROJECT_ROOT}}": project_root,
         "{{ARTIFACT_DIR}}": ".prizmkit/bugfix/{}".format(args.bug_id),
+        "{{FAMILY_ARTIFACTS}}": "├── fix-report.md",
         "{{CHECKPOINT_PATH}}": os.path.join(".prizmkit", "bugfix", args.bug_id, "workflow-checkpoint.json"),
         "{{CHECKPOINT_SYSTEM}}": read_checkpoint_system_section(script_dir),
         "{{FIX_SCOPE}}": fix_scope,
@@ -380,24 +380,22 @@ def render_template(template_content, replacements, bug):
     return replace_placeholders(process_conditional_blocks(template_content, bug), replacements)
 
 
-def _bugfix_header(pipeline_mode):
-    title = "# Dev-Pipeline Bug Fix Session Bootstrap — {}\n".format(pipeline_mode.title())
-    desc = {
-        "lite": "**Tier 1 — Scoped Bugfix Guidance**: use the active skills and runtime contracts for diagnosis, implementation, review, and verification.",
-        "standard": "**Tier 2 — Bugfix Review Gates**: use the active skills and runtime contracts for diagnosis, implementation, review, and verification.",
-        "full": "**Tier 3 — Full Bugfix Guardrails**: use the active skills and runtime contracts for diagnosis, implementation, review, recovery, and verification.",
-    }.get(pipeline_mode, "**Bugfix pipeline**")
-    return title + "\n" + desc + "\n"
+def _bugfix_header():
+    return (
+        "# Dev-Pipeline Bug Fix Session Bootstrap — Canonical Guidance\n\n"
+        "Use the active skills and runtime contracts for diagnosis, implementation, "
+        "review, verification, retrospective, and runtime-owned commit execution.\n"
+    )
 
 
-def assemble_bugfix_sections(pipeline_mode, sections_dir, browser_enabled, manual_gate, browser_tool="auto"):
+def assemble_bugfix_sections(sections_dir, browser_enabled, manual_gate, browser_tool="auto"):
     sections = [
-        ("header", _bugfix_header(pipeline_mode)),
+        ("header", _bugfix_header()),
         ("bugfix-session-context", load_section(sections_dir, "bugfix-session-context.md")),
         ("mission", load_section(sections_dir, "bugfix-mission.md")),
         ("bugfix-task-contract", load_section(sections_dir, "bugfix-task-contract.md")),
         ("context-budget-rules", load_section(sections_dir, "context-budget-rules.md")),
-        ("bugfix-artifacts", load_section(sections_dir, "bugfix-artifacts.md")),
+        ("artifact-manifest", load_section(sections_dir, "artifact-manifest.md")),
         ("checkpoint-system", load_section(sections_dir, "checkpoint-system.md")),
         ("execution-header", "---\n\n## Execution\n"),
         ("bugfix-phase-init", load_section(sections_dir, "bugfix-phase-init.md")),
@@ -406,7 +404,6 @@ def assemble_bugfix_sections(pipeline_mode, sections_dir, browser_enabled, manua
     sections.extend([
         ("bugfix-phase-implement", load_section(sections_dir, "bugfix-phase-implement.md")),
         ("bugfix-phase-review", load_section(sections_dir, "bugfix-phase-review.md")),
-        ("bugfix-phase-test", load_section(sections_dir, "bugfix-phase-test.md")),
     ])
     if browser_enabled:
         browser_section_file = {
@@ -417,9 +414,10 @@ def assemble_bugfix_sections(pipeline_mode, sections_dir, browser_enabled, manua
     if manual_gate:
         sections.append(("bugfix-manual-gate", load_section(sections_dir, "bugfix-phase-manual-verification.md")))
     sections.extend([
-        ("headless-commit-authorization", load_section(sections_dir, "headless-commit-authorization.md")),
+        ("bugfix-phase-test", load_section(sections_dir, "bugfix-phase-test.md")),
         ("bugfix-phase-commit-report", load_section(sections_dir, "bugfix-phase-commit-report.md")),
-        ("bugfix-session-status", load_section(sections_dir, "bugfix-session-status.md")),
+        ("retrospective", load_section(sections_dir, "retrospective.md")),
+        ("runtime-commit-handoff", load_section(sections_dir, "runtime-commit-handoff.md")),
         ("bugfix-critical-paths", load_section(sections_dir, "bugfix-critical-paths.md")),
         ("failure-capture", load_section(sections_dir, "failure-capture.md")),
         ("bugfix-reminders", load_section(sections_dir, "bugfix-reminders.md")),
@@ -427,21 +425,30 @@ def assemble_bugfix_sections(pipeline_mode, sections_dir, browser_enabled, manua
     return sections
 
 
-def generate_bugfix_checkpoint(bug_id, session_id, pipeline_mode="standard", sections=None):
-    """Generate a checkpoint definition for bugfix pipeline."""
+def generate_bugfix_checkpoint(
+    bug_id, session_id, sections=None, *, browser_enabled=False, manual_gate=False,
+):
+    """Generate a checkpoint definition for the Bugfix coordinator."""
     if sections is None:
         sections = [
             ("bugfix-phase-init", ""),
             ("bugfix-phase-diagnose-plan", ""),
             ("bugfix-phase-implement", ""),
             ("bugfix-phase-review", ""),
+        ]
+        if browser_enabled:
+            sections.append(("phase-browser", ""))
+        if manual_gate:
+            sections.append(("bugfix-manual-gate", ""))
+        sections.extend([
             ("bugfix-phase-test", ""),
             ("bugfix-phase-commit-report", ""),
-        ]
+            ("retrospective", ""),
+            ("runtime-commit-handoff", ""),
+        ])
     return generate_checkpoint_from_sections(
         sections,
         BUGFIX_SECTION_TO_SKILL,
-        pipeline_mode,
         "bugfix-pipeline",
         bug_id,
         bug_id,
@@ -485,7 +492,6 @@ def main():
         global_context = {}
 
     replacements = build_replacements(args, bug, global_context, script_dir)
-    pipeline_mode = replacements["{{PIPELINE_MODE}}"]
     browser_enabled = replacements["{{BROWSER_ENABLED}}"] == "true"
     manual_gate = bug.get("verification_type", "automated") in ("manual", "hybrid")
 
@@ -494,16 +500,17 @@ def main():
     if use_sections:
         try:
             sections = assemble_bugfix_sections(
-                pipeline_mode, sections_dir, browser_enabled, manual_gate,
+                sections_dir, browser_enabled, manual_gate,
                 browser_tool=replacements["{{BROWSER_TOOL}}"],
             )
             rendered = render_from_sections(sections, replacements)
         except FileNotFoundError as exc:
-            LOGGER.warning("Bugfix section assembly failed (%s), falling back to legacy template", exc)
-            use_sections = False
+            emit_failure("Bugfix section assembly failed: {}".format(exc))
 
     if not use_sections:
-        template_path = args.template or os.path.join(templates_dir, "bugfix-bootstrap-prompt.md")
+        if not args.template:
+            emit_failure("Canonical Bugfix prompt sections are unavailable")
+        template_path = args.template
         template_content, err = read_text_file(template_path)
         if err:
             emit_failure("Template error: {}".format(err))
@@ -519,7 +526,7 @@ def main():
         logger=LOGGER,
     )
     if not is_valid:
-        LOGGER.error("Rendered bugfix prompt failed validation: %s", "; ".join(errors))
+        emit_failure("Rendered bugfix prompt failed validation: {}".format("; ".join(errors)))
 
     err = write_output(args.output, rendered)
     if err:
@@ -527,9 +534,14 @@ def main():
 
     project_root = _args_project_root(args, script_dir)
     checkpoint_path = os.path.join(project_root, replacements["{{CHECKPOINT_PATH}}"])
-    os.makedirs(os.path.dirname(checkpoint_path), exist_ok=True)
+    if not args.no_checkpoint_write:
+        os.makedirs(os.path.dirname(checkpoint_path), exist_ok=True)
     checkpoint = generate_bugfix_checkpoint(
-        args.bug_id, args.session_id, pipeline_mode, sections if use_sections else None,
+        args.bug_id,
+        args.session_id,
+        sections if use_sections else None,
+        browser_enabled=browser_enabled,
+        manual_gate=manual_gate,
     )
     if not any(step.get("skill") == "prizmkit-test" for step in checkpoint["steps"]):
         emit_failure("Bugfix checkpoint is missing the mandatory prizmkit-test stage")
@@ -544,7 +556,7 @@ def main():
         resume_from="prizmkit-implement",
     )
 
-    if (args.resume_phase != "null" or is_continuation(args)) and os.path.exists(checkpoint_path):
+    if not args.no_checkpoint_write and (args.resume_phase != "null" or is_continuation(args)) and os.path.exists(checkpoint_path):
         try:
             with open(checkpoint_path, "r", encoding="utf-8") as f:
                 existing = json.load(f)
@@ -553,14 +565,32 @@ def main():
         except (json.JSONDecodeError, KeyError) as exc:
             LOGGER.warning("Existing bugfix checkpoint corrupted (%s) — generating fresh", exc)
 
-    with open(checkpoint_path, "w", encoding="utf-8") as f:
-        json.dump(checkpoint, f, indent=2, ensure_ascii=False)
-    LOGGER.info("Wrote bugfix checkpoint to %s", checkpoint_path)
+    if not args.no_checkpoint_write:
+        with open(checkpoint_path, "w", encoding="utf-8") as f:
+            json.dump(checkpoint, f, indent=2, ensure_ascii=False)
+        LOGGER.info("Wrote bugfix checkpoint to %s", checkpoint_path)
 
     if is_continuation(args):
         rendered = append_continuation_handoff(
             rendered, args, project_root, args.task_type, args.bug_id, args.bug_id, checkpoint,
         )
+        final_valid, final_warnings, final_errors = validate_rendered(
+            rendered,
+            required_markers=[
+                ("## Your Mission", "Mission section"),
+                ("## Execution", "Execution section"),
+                ("## Failure Capture", "Failure Capture Protocol"),
+            ],
+            logger=LOGGER,
+        )
+        if not final_valid:
+            emit_failure(
+                "Rendered bugfix continuation prompt failed validation: {}".format(
+                    "; ".join(final_errors)
+                )
+            )
+        warnings.extend(final_warnings)
+        errors.extend(final_errors)
         err = write_output(args.output, rendered)
         if err:
             emit_failure(err)
@@ -568,9 +598,8 @@ def main():
     output = {
         "success": True,
         "output_path": os.path.abspath(args.output),
-        "checkpoint_path": checkpoint_path,
+        "checkpoint_path": "" if args.no_checkpoint_write else checkpoint_path,
         "model": bug.get("model", ""),
-        "pipeline_mode": pipeline_mode,
         "render_mode": "sections" if use_sections else "legacy",
         "validation_warnings": len(warnings),
         "validation_errors": len(errors),