prizmkit 1.1.154 → 1.1.156

package/bundled/dev-pipeline/tests/test_generate_bugfix_prompt.py

@@ -182,7 +182,6 @@ class TestExplicitProjectRoot:
             state_dir=str(main_checkout / ".prizmkit" / "state" / "bugfix"),
             output=str(main_checkout / ".prizmkit" / "state" / "bugfix" / "B-001" / "sessions" / "session-1" / "bootstrap-prompt.md"),
             template=None,
-            mode=None,
             project_root=str(execution_root),
         )
         bug = {"id": "B-001", "title": "Worktree Bug", "description": "d"}
@@ -195,11 +194,7 @@ class TestExplicitProjectRoot:
         )
 
         assert replacements["{{PROJECT_ROOT}}"] == str(execution_root.resolve())
-        assert replacements["{{SESSION_STATUS_PATH}}"] == str(
-            main_checkout / ".prizmkit" / "state" / "bugfix" / "B-001" /
-            "sessions" / "session-1" / "session-status.json"
-        )
-        assert not replacements["{{SESSION_STATUS_PATH}}"].startswith(str(execution_root.resolve()))
+        assert "{{SESSION_STATUS_PATH}}" not in replacements
         assert "{{" + "DEV_" + "SUBAGENT_PATH" + "}}" not in replacements
         assert replacements["{{SESSION_LOG_PATH}}"].endswith(
             ".prizmkit/state/bugfix/B-001/sessions/session-1/logs/session.log"
@@ -321,7 +316,8 @@ def test_template_source_is_clean_for_headless_prompt_contract():
     assert "FAST_PATH=true" not in content
     assert "prizmkit-workflow" not in content
     assert "/prizmkit-test scope=this-change artifact_dir=.prizmkit/bugfix/{{BUG_ID}}/" in content
-    assert "local_commit_authorized=true" in content
+    assert "operation=prepare-runtime-commit" in content
+    assert "local_commit_authorized" not in content
     assert "push_authorized" not in content
 
 
@@ -494,11 +490,21 @@ class TestBugfixCheckpointGeneration:
             "prizmkit-implement",
             "prizmkit-code-review",
             "prizmkit-test",
+            "bug-report",
             "prizmkit-retrospective",
             "prizmkit-committer",
-            "bug-report",
         ]
+        plan_step = checkpoint["steps"][1]
+        review_step = checkpoint["steps"][3]
         test_step = checkpoint["steps"][4]
+        assert plan_step["required_artifacts"] == [
+            ".prizmkit/bugfix/B-001/context-snapshot.md",
+            ".prizmkit/bugfix/B-001/spec.md",
+            ".prizmkit/bugfix/B-001/plan.md",
+        ]
+        assert review_step["required_artifacts"] == [
+            ".prizmkit/bugfix/B-001/review-report.md"
+        ]
         assert test_step["depends_on"] == "S04"
         assert test_step["required_artifacts"] == [
             ".prizmkit/bugfix/B-001/test-report.md",
@@ -506,23 +512,31 @@ class TestBugfixCheckpointGeneration:
         ]
         assert checkpoint["steps"][5]["depends_on"] == "S05"
 
-    def test_bugfix_result_routing_stops_test_non_pass(self):
-        review = route_bugfix_repair("REVIEW_NEEDS_FIXES", repair_round=0)
-        needs_fixes = route_bugfix_repair("TEST_NEEDS_FIXES", repair_round=1)
+    def test_bugfix_result_routing_owns_bounded_test_repair(self):
+        review = route_bugfix_repair(
+            "REVIEW_NEEDS_FIXES", repair_scope="production", repair_round=0,
+        )
+        needs_fixes = route_bugfix_repair(
+            "TEST_NEEDS_FIXES", repair_scope="production", repair_round=1,
+        )
         blocked = route_bugfix_repair("TEST_BLOCKED", repair_round=1)
 
         assert review["route"] == [
             "prizmkit-implement", "prizmkit-code-review", "prizmkit-test",
         ]
         assert review["repair_round"] == 1
-        assert needs_fixes["blocked"] is True
-        assert needs_fixes["route"] == []
-        assert needs_fixes["blocked_reason"] == "test_needs_fixes"
+        assert needs_fixes["blocked"] is False
+        assert needs_fixes["route"] == [
+            "prizmkit-implement", "prizmkit-code-review", "prizmkit-test",
+        ]
+        assert needs_fixes["repair_round"] == 2
         assert blocked["blocked"] is True
         assert blocked["resumable"] is False
         assert blocked["next_stage"] is None
         assert blocked["terminal_status"] == "WORKFLOW_BLOCKED"
         assert blocked["blocked_reason"] == "test_blocked"
+        unsafe = route_bugfix_repair("REVIEW_NEEDS_FIXES", repair_round=0)
+        assert unsafe["blocked_reason"] == "unsafe_repair_scope"
 
     def test_bugfix_checkpoint_metadata_has_no_evidence_handoff(self):
         metadata = bugfix_checkpoint_metadata(
@@ -542,28 +556,51 @@ class TestBugfixCheckpointGeneration:
 
     def test_manual_bugfix_uses_automatic_verification_and_keeps_commit_gate(self):
         sections = assemble_bugfix_sections(
-            "standard", "dev-pipeline/templates/sections", False, True,
+            "dev-pipeline/templates/sections", False, True,
         )
         names = [name for name, _ in sections]
 
         assert "bugfix-manual-gate" in names
-        assert "headless-commit-authorization" in names
+        assert names.index("bugfix-manual-gate") < names.index("bugfix-phase-test")
+        assert "runtime-commit-handoff" in names
         assert "bugfix-phase-commit-report" in names
+        checkpoint = generate_bugfix_checkpoint(
+            "B-001", "session", sections=sections,
+        )
+        skills = [step["skill"] for step in checkpoint["steps"]]
+        assert skills.index("prizmkit-code-review") < skills.index(
+            "manual-verification"
+        ) < skills.index("prizmkit-test")
+        compatibility = generate_bugfix_checkpoint(
+            "B-001",
+            "session",
+            browser_enabled=True,
+            manual_gate=True,
+        )
+        compatibility_skills = [step["skill"] for step in compatibility["steps"]]
+        assert compatibility_skills.index("prizmkit-code-review") < compatibility_skills.index(
+            "browser-verification"
+        ) < compatibility_skills.index("manual-verification") < compatibility_skills.index(
+            "prizmkit-test"
+        )
 
     def test_rendered_bugfix_prompt_is_atomic_headless_and_local_commit_only(self, tmp_path):
         prompt = _render_bugfix_prompt(tmp_path)
 
         assert prompt.index("/prizmkit-code-review") < prompt.index(
             "/prizmkit-test scope=this-change artifact_dir=.prizmkit/bugfix/B-001/"
-        ) < prompt.index("### Headless Commit Authorization")
+        ) < prompt.index("### Bug Fix Report") < prompt.index("### Retrospective") < prompt.index("### Runtime Commit Handoff")
         assert "FAST_PATH=true" not in prompt
         assert "prizmkit-workflow" not in prompt
-        assert '"local_commit_authorized": true' in prompt
-        assert "push_authorized" not in prompt
-        assert "Do not ask questions, wait for user input" in prompt
-        assert "Remote publication is controlled by the runtime" in prompt
+        assert "local_commit_authorized" not in prompt
+        assert "operation=prepare-runtime-commit" in prompt
+        assert "NEVER ask for user confirmation" in prompt
+        assert "The Python runtime, not the AI session, executes" in prompt
+        assert "all `.prizmkit/**` paths are PrizmKit-internal" in prompt
+        assert "Unknown Git-visible paths are not silently ignored" in prompt
         assert "push_authorized\": true" not in prompt
         assert ".prizmkit/bugfix/B-001/" in prompt
+        assert "write the session status" not in prompt.lower()
 
     def test_setup_section_skips_and_finalization_group_expands(self):
         checkpoint = generate_bugfix_checkpoint(
@@ -572,15 +609,17 @@ class TestBugfixCheckpointGeneration:
             sections=[
                 ("bugfix-phase-init", "setup"),
                 ("bugfix-phase-implement", "implement"),
-                ("bugfix-phase-commit-report", "finalize"),
+                ("bugfix-phase-commit-report", "report"),
+                ("retrospective", "retrospective"),
+                ("runtime-commit-handoff", "commit"),
             ],
         )
 
         assert [step["skill"] for step in checkpoint["steps"]] == [
             "prizmkit-init",
             "prizmkit-implement",
+            "bug-report",
             "prizmkit-retrospective",
             "prizmkit-committer",
-            "bug-report",
         ]
         assert checkpoint["steps"][2]["depends_on"] == "S02"

package/bundled/dev-pipeline/tests/test_generate_refactor_prompt.py

@@ -8,6 +8,8 @@ import os
 from continuation import append_continuation_handoff
 from generate_refactor_prompt import (
     build_replacements,
+    format_behavior_preservation,
+    format_existing_tests,
     generate_refactor_checkpoint,
     merge_refactor_checkpoint_state,
     refactor_checkpoint_metadata,
@@ -52,6 +54,39 @@ class TestRefactorContinuationHandoff:
         assert (tmp_path / ".prizmkit/refactor/R-007/continuation-summary.md").exists()
 
 
+class TestRefactorBehaviorPreservation:
+    def test_schema_boolean_existing_tests_renders_without_iteration(self):
+        assert format_existing_tests(True) == (
+            "- Coverage declared: yes (specific test paths not supplied)"
+        )
+        assert format_existing_tests(False) == (
+            "- Coverage declared: no (specific test paths not supplied)"
+        )
+        assert "**Existing Tests Cover Scope**: yes" in format_behavior_preservation({
+            "strategy": "test-gate",
+            "existing_tests": True,
+        })
+
+    def test_historical_test_path_list_remains_supported(self):
+        value = ["test/unit.test.js", "test/integration.test.js"]
+        rendered = format_existing_tests(value)
+        assert "`test/unit.test.js`" in rendered
+        assert "`test/integration.test.js`" in rendered
+        preservation = format_behavior_preservation({
+            "strategy": "test-gate",
+            "existing_tests": value,
+        })
+        assert "**Existing Tests**" in preservation
+        assert "`test/unit.test.js`" in preservation
+
+    def test_invalid_test_shapes_degrade_to_unspecified(self):
+        assert format_existing_tests("test/unit.test.js") == "- (none specified)"
+        assert "Existing Tests" not in format_behavior_preservation({
+            "strategy": "test-gate",
+            "existing_tests": {"path": "test/unit.test.js"},
+        })
+
+
 class TestRefactorCheckpointMerge:
     def test_preserves_skipped_without_artifacts(self, tmp_path):
         fresh = generate_refactor_checkpoint("R-008", "R-008-new")
@@ -96,7 +131,6 @@ class TestExplicitProjectRoot:
             state_dir=str(project / ".prizmkit" / "state" / "refactor"),
             output=str(project / "out.md"),
             template=None,
-            mode=None,
         )
         refactor = {"id": "R-001", "title": "Restructure", "description": "d"}
 
@@ -106,10 +140,7 @@ class TestExplicitProjectRoot:
 
         assert replacements["{{PROJECT_ROOT}}"] == str(project.resolve())
         assert "{{" + "REVIEWER_" + "SUBAGENT_PATH" + "}}" not in replacements
-        assert replacements["{{SESSION_STATUS_PATH}}"] == str(
-            project / ".prizmkit" / "state" / "refactor" / "R-001" /
-            "sessions" / "session-1" / "session-status.json"
-        )
+        assert "{{SESSION_STATUS_PATH}}" not in replacements
 
     def test_build_replacements_uses_cli_project_root_for_rendered_paths(self, tmp_path, monkeypatch):
         monkeypatch.setenv("PRIZMKIT_PLATFORM", "claude")
@@ -127,7 +158,6 @@ class TestExplicitProjectRoot:
             state_dir=str(main_checkout / ".prizmkit" / "state" / "refactor"),
             output=str(main_checkout / ".prizmkit" / "state" / "refactor" / "R-001" / "sessions" / "session-1" / "bootstrap-prompt.md"),
             template=None,
-            mode=None,
             project_root=str(execution_root),
         )
         refactor = {"id": "R-001", "title": "Worktree Refactor", "description": "d"}
@@ -141,11 +171,7 @@ class TestExplicitProjectRoot:
         )
 
         assert replacements["{{PROJECT_ROOT}}"] == str(execution_root.resolve())
-        assert replacements["{{SESSION_STATUS_PATH}}"] == str(
-            main_checkout / ".prizmkit" / "state" / "refactor" / "R-001" /
-            "sessions" / "session-1" / "session-status.json"
-        )
-        assert not replacements["{{SESSION_STATUS_PATH}}"].startswith(str(execution_root.resolve()))
+        assert "{{SESSION_STATUS_PATH}}" not in replacements
         assert "{{" + "DEV_" + "SUBAGENT_PATH" + "}}" not in replacements
         assert "### Checkpoint Update Helper" in replacements["{{CHECKPOINT_SYSTEM}}"]
         assert "{{CHECKPOINT_PYTHON_CMD}}" in replacements["{{CHECKPOINT_SYSTEM}}"]
@@ -178,7 +204,6 @@ class TestRefactorPromptMaxLogRemoval:
             state_dir=None,
             output="out.md",
             template=None,
-            mode=None,
         )
         refactor = {"id": "R-001", "title": "Restructure", "description": "d"}
 
@@ -214,7 +239,8 @@ def test_template_source_is_clean_for_headless_prompt_contract():
         assert forbidden not in content
     assert "prizmkit-workflow" not in content
     assert "/prizmkit-test scope=this-change artifact_dir=.prizmkit/refactor/{{REFACTOR_ID}}/" in content
-    assert "local_commit_authorized=true" in content
+    assert "operation=prepare-runtime-commit" in content
+    assert "local_commit_authorized" not in content
     assert "push_authorized" not in content
     assert "Behavior-preservation context remains supporting input" in content
 
@@ -344,10 +370,10 @@ class TestRefactorCheckpointGeneration:
             "prizmkit-implement",
             "prizmkit-code-review",
             "prizmkit-test",
-            "prizmkit-retrospective",
-            "prizmkit-committer",
             "refactor-report",
             "completion-summary",
+            "prizmkit-retrospective",
+            "prizmkit-committer",
         ]
         assert checkpoint["steps"][4]["depends_on"] == "S04"
         assert checkpoint["steps"][4]["required_artifacts"] == [
@@ -356,22 +382,30 @@ class TestRefactorCheckpointGeneration:
         ]
         assert checkpoint["steps"][5]["depends_on"] == "S05"
 
-    def test_refactor_result_routing_stops_test_non_pass(self):
-        review = route_refactor_repair("REVIEW_NEEDS_FIXES", repair_round=0)
-        needs_fixes = route_refactor_repair("TEST_NEEDS_FIXES", repair_round=1)
+    def test_refactor_result_routing_owns_bounded_test_repair(self):
+        review = route_refactor_repair(
+            "REVIEW_NEEDS_FIXES", repair_scope="production", repair_round=0,
+        )
+        needs_fixes = route_refactor_repair(
+            "TEST_NEEDS_FIXES", repair_scope="production", repair_round=1,
+        )
         blocked = route_refactor_repair("TEST_BLOCKED", repair_round=1)
 
         assert review["route"] == [
             "prizmkit-implement", "prizmkit-code-review", "prizmkit-test",
         ]
-        assert needs_fixes["blocked"] is True
-        assert needs_fixes["route"] == []
-        assert needs_fixes["blocked_reason"] == "test_needs_fixes"
+        assert needs_fixes["blocked"] is False
+        assert needs_fixes["route"] == [
+            "prizmkit-implement", "prizmkit-code-review", "prizmkit-test",
+        ]
+        assert needs_fixes["repair_round"] == 2
         assert blocked["blocked"] is True
         assert blocked["route"] == []
         assert blocked["next_stage"] is None
         assert blocked["terminal_status"] == "WORKFLOW_BLOCKED"
         assert blocked["blocked_reason"] == "test_blocked"
+        unsafe = route_refactor_repair("TEST_NEEDS_FIXES", repair_round=0)
+        assert unsafe["blocked_reason"] == "unsafe_repair_scope"
 
     def test_refactor_checkpoint_metadata_has_no_evidence_handoff(self):
         metadata = refactor_checkpoint_metadata(
@@ -395,14 +429,26 @@ class TestRefactorCheckpointGeneration:
 
         assert prompt.index("/prizmkit-code-review") < prompt.index(
             "/prizmkit-test scope=this-change artifact_dir=.prizmkit/refactor/R-001/"
-        ) < prompt.index("### Headless Commit Authorization")
+        ) < prompt.index("### Refactor Report") < prompt.index("### Retrospective") < prompt.index("### Runtime Commit Handoff")
         assert "prizmkit-workflow" not in prompt
         assert "Existing behavior-preservation context is input to testing" in prompt
-        assert '"local_commit_authorized": true' in prompt
-        assert "push_authorized" not in prompt
-        assert "Remote publication is controlled by the runtime" in prompt
+        assert "local_commit_authorized" not in prompt
+        assert "operation=prepare-runtime-commit" in prompt
+        assert "The Python runtime, not the AI session, executes" in prompt
+        assert "all `.prizmkit/**` paths are PrizmKit-internal" in prompt
+        assert "Unknown Git-visible paths are not silently ignored" in prompt
         assert "automatic push" not in prompt.lower()
         assert "push_authorized\": true" not in prompt
+        assert "write the session status" not in prompt.lower()
+
+    def test_compatibility_checkpoint_keeps_configured_browser_before_test(self):
+        checkpoint = generate_refactor_checkpoint(
+            "R-001", "session", browser_enabled=True,
+        )
+        skills = [step["skill"] for step in checkpoint["steps"]]
+        assert skills.index("prizmkit-code-review") < skills.index(
+            "browser-verification"
+        ) < skills.index("prizmkit-test")
 
 
 class TestRefactorCheckpointGenerationLegacy:
@@ -413,16 +459,18 @@ class TestRefactorCheckpointGenerationLegacy:
             sections=[
                 ("refactor-phase-init", "setup"),
                 ("refactor-phase-implement", "implement"),
-                ("refactor-phase-commit-report", "finalize"),
+                ("refactor-phase-commit-report", "report"),
+                ("retrospective", "retrospective"),
+                ("runtime-commit-handoff", "commit"),
             ],
         )
 
         assert [step["skill"] for step in checkpoint["steps"]] == [
             "prizmkit-init",
             "prizmkit-implement",
-            "prizmkit-retrospective",
-            "prizmkit-committer",
             "refactor-report",
             "completion-summary",
+            "prizmkit-retrospective",
+            "prizmkit-committer",
         ]
         assert checkpoint["steps"][2]["depends_on"] == "S02"