principles-disciple 1.72.0 → 1.73.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (309) hide show
  1. package/openclaw.plugin.json +10 -5
  2. package/package.json +17 -19
  3. package/scripts/acceptance-test.mjs +16 -73
  4. package/scripts/sync-plugin.mjs +382 -77
  5. package/src/commands/archive-impl.ts +2 -1
  6. package/src/commands/capabilities.ts +2 -2
  7. package/src/commands/context.ts +2 -2
  8. package/src/commands/disable-impl.ts +2 -1
  9. package/src/commands/evolution-status.ts +16 -16
  10. package/src/commands/export.ts +12 -67
  11. package/src/commands/pain.ts +91 -1
  12. package/src/commands/principle-rollback.ts +2 -1
  13. package/src/commands/promote-impl.ts +7 -43
  14. package/src/commands/rollback-impl.ts +2 -1
  15. package/src/commands/rollback.ts +2 -1
  16. package/src/commands/samples.ts +2 -1
  17. package/src/commands/thinking-os.ts +2 -1
  18. package/src/config/errors.ts +18 -2
  19. package/src/constants/diagnostician.ts +2 -2
  20. package/src/constants/tools.ts +2 -1
  21. package/src/core/__tests__/focus-history.test.ts +210 -0
  22. package/src/core/config.ts +1 -1
  23. package/src/core/confirm-first-gate.ts +255 -0
  24. package/src/core/correction-cue-learner.ts +2 -136
  25. package/src/core/correction-types.ts +16 -88
  26. package/src/core/dictionary.ts +19 -20
  27. package/src/core/empathy-keyword-matcher.ts +17 -289
  28. package/src/core/empathy-types.ts +18 -229
  29. package/src/core/event-log.ts +38 -132
  30. package/src/core/evolution-reducer.ts +21 -2
  31. package/src/core/evolution-types.ts +76 -464
  32. package/src/core/file-store.ts +80 -0
  33. package/src/core/focus-history.ts +228 -955
  34. package/src/core/local-worker-routing.ts +34 -314
  35. package/src/core/merge-gate-audit.ts +0 -195
  36. package/src/core/pain-diagnostic-gate.ts +154 -0
  37. package/src/core/pain-signal.ts +21 -138
  38. package/src/core/pain.ts +15 -88
  39. package/src/core/pd-task-reconciler.ts +26 -115
  40. package/src/core/pd-task-service.ts +9 -9
  41. package/src/core/pd-task-types.ts +23 -127
  42. package/src/core/principle-compiler/__tests__/compiler-replay-gate.test.ts +174 -0
  43. package/src/core/principle-compiler/code-validator.ts +15 -42
  44. package/src/core/principle-compiler/compiler.ts +100 -15
  45. package/src/core/principle-compiler/index.ts +5 -2
  46. package/src/core/principle-compiler/template-generator.ts +4 -104
  47. package/src/core/principle-injection.ts +10 -202
  48. package/src/core/principle-internalization/filesystem-lifecycle-datasource.ts +42 -0
  49. package/src/core/principle-internalization/lifecycle-read-model.ts +39 -242
  50. package/src/core/principle-internalization/principle-lifecycle-service.ts +12 -10
  51. package/src/core/principle-tree-ledger-adapter.ts +145 -0
  52. package/src/core/principle-tree-ledger.ts +8 -6
  53. package/src/core/reflection/reflection-context.ts +14 -109
  54. package/src/core/replay-engine.ts +8 -500
  55. package/src/core/rule-host-helpers.ts +5 -35
  56. package/src/core/rule-host-types.ts +10 -82
  57. package/src/core/rule-host.ts +6 -63
  58. package/src/core/runtime-v2-prompt-activation-reader.ts +231 -0
  59. package/src/core/session-tracker.ts +87 -101
  60. package/src/core/shadow-observation-registry.ts +19 -48
  61. package/src/core/trajectory.ts +3 -1
  62. package/src/core/workflow-funnel-loader.ts +62 -68
  63. package/src/core/workspace-context.ts +46 -0
  64. package/src/core/workspace-dir-service.ts +1 -1
  65. package/src/core/workspace-dir-validation.ts +18 -9
  66. package/src/hooks/AGENTS.md +1 -1
  67. package/src/hooks/gate-block-helper.ts +46 -44
  68. package/src/hooks/gate.ts +207 -7
  69. package/src/hooks/lifecycle.ts +30 -32
  70. package/src/hooks/llm.ts +60 -32
  71. package/src/hooks/pain.ts +297 -103
  72. package/src/hooks/prompt.ts +459 -439
  73. package/src/hooks/subagent.ts +2 -29
  74. package/src/i18n/commands.ts +2 -10
  75. package/src/index.ts +95 -85
  76. package/src/openclaw-sdk.ts +311 -0
  77. package/src/service/central-database.ts +8 -4
  78. package/src/service/evolution-queue-migration.ts +2 -1
  79. package/src/service/evolution-worker.ts +163 -1786
  80. package/src/service/internalization-trigger-adapter.ts +302 -0
  81. package/src/service/keyword-optimization-service.ts +4 -4
  82. package/src/service/monitoring-query-service.ts +1 -215
  83. package/src/service/queue-io.ts +60 -331
  84. package/src/service/runtime-summary-service.ts +59 -16
  85. package/src/service/subagent-workflow/index.ts +0 -41
  86. package/src/service/subagent-workflow/types.ts +9 -120
  87. package/src/service/subagent-workflow/workflow-store.ts +2 -119
  88. package/src/service/workflow-watchdog.ts +0 -43
  89. package/src/types/event-payload.ts +16 -74
  90. package/src/types/event-types.ts +39 -547
  91. package/src/types/hygiene-types.ts +7 -30
  92. package/src/types/principle-tree-schema.ts +20 -222
  93. package/src/types/queue.ts +15 -70
  94. package/src/types/runtime-summary.ts +5 -49
  95. package/src/utils/io.ts +10 -0
  96. package/src/utils/retry.ts +1 -1
  97. package/src/utils/shadow-fingerprint.ts +2 -2
  98. package/src/utils/workspace-resolver.ts +50 -0
  99. package/templates/langs/en/core/AGENTS.md +2 -2
  100. package/templates/langs/en/core/BOOT.md +1 -1
  101. package/templates/langs/en/core/HEARTBEAT.md +2 -2
  102. package/templates/langs/en/skills/ai-sprint-orchestration/references/agent-registry.json +1 -72
  103. package/templates/langs/en/skills/ai-sprint-orchestration/references/specs/bugfix-complex-template.json +6 -6
  104. package/templates/langs/en/skills/ai-sprint-orchestration/references/specs/feature-complex-template.json +6 -6
  105. package/templates/langs/en/skills/ai-sprint-orchestration/references/specs/workflow-validation-minimal-verify.json +2 -12
  106. package/templates/langs/en/skills/ai-sprint-orchestration/references/specs/workflow-validation-minimal.json +2 -12
  107. package/templates/langs/en/skills/ai-sprint-orchestration/runtime/.gitignore +2 -2
  108. package/templates/langs/en/skills/ai-sprint-orchestration/scripts/run.mjs +51 -15
  109. package/templates/langs/en/skills/evolve-task/SKILL.md +1 -1
  110. package/templates/langs/en/skills/pd-cli-operator/SKILL.md +67 -0
  111. package/templates/langs/en/skills/pd-diagnostician/SKILL.md +1 -1
  112. package/templates/langs/en/skills/pd-mentor/SKILL.md +1 -1
  113. package/templates/langs/en/skills/pd-pain-signal/SKILL.md +17 -39
  114. package/templates/langs/en/skills/pd-runtime-v2/SKILL.md +61 -0
  115. package/templates/langs/zh/core/AGENTS.md +2 -2
  116. package/templates/langs/zh/core/BOOT.md +1 -1
  117. package/templates/langs/zh/core/HEARTBEAT.md +2 -2
  118. package/templates/langs/zh/skills/ai-sprint-orchestration/references/agent-registry.json +1 -72
  119. package/templates/langs/zh/skills/ai-sprint-orchestration/references/specs/bugfix-complex-template.json +6 -6
  120. package/templates/langs/zh/skills/ai-sprint-orchestration/references/specs/feature-complex-template.json +6 -6
  121. package/templates/langs/zh/skills/ai-sprint-orchestration/references/specs/nocturnal-trinity-quality-enhancement.json +8 -8
  122. package/templates/langs/zh/skills/ai-sprint-orchestration/references/specs/workflow-validation-minimal-verify.json +2 -12
  123. package/templates/langs/zh/skills/ai-sprint-orchestration/references/specs/workflow-validation-minimal.json +2 -12
  124. package/templates/langs/zh/skills/ai-sprint-orchestration/runtime/.gitignore +2 -2
  125. package/templates/langs/zh/skills/ai-sprint-orchestration/scripts/run.mjs +51 -15
  126. package/templates/langs/zh/skills/ai-sprint-orchestration/test/run.test.mjs +21 -5
  127. package/templates/langs/zh/skills/evolve-task/SKILL.md +2 -2
  128. package/templates/langs/zh/skills/pd-cli-operator/SKILL.md +67 -0
  129. package/templates/langs/zh/skills/pd-diagnostician/SKILL.md +1 -1
  130. package/templates/langs/zh/skills/pd-mentor/SKILL.md +1 -1
  131. package/templates/langs/zh/skills/pd-pain-signal/SKILL.md +17 -38
  132. package/templates/langs/zh/skills/pd-runtime-v2/SKILL.md +61 -0
  133. package/tests/build-artifacts.test.ts +1 -3
  134. package/tests/commands/evolution-status.test.ts +0 -118
  135. package/tests/core/bootstrap-rules.test.ts +1 -1
  136. package/tests/core/config.test.ts +1 -1
  137. package/tests/core/event-log.test.ts +35 -0
  138. package/tests/core/evolution-engine.test.ts +610 -0
  139. package/tests/core/file-store.test.ts +102 -0
  140. package/tests/core/focus-history.test.ts +203 -11
  141. package/tests/core/merge-gate-audit.test.ts +2 -169
  142. package/tests/core/model-deployment-registry.test.ts +7 -1
  143. package/tests/core/model-training-registry.test.ts +19 -0
  144. package/tests/core/observability.test.ts +0 -1
  145. package/tests/core/pain-diagnostic-gate.test.ts +498 -0
  146. package/tests/core/pain.test.ts +0 -1
  147. package/tests/core/principle-internalization/deprecated-readiness.test.ts +2 -2
  148. package/tests/core/principle-internalization/lifecycle-metrics.test.ts +2 -2
  149. package/tests/core/principle-internalization/{internalization-routing-policy.test.ts → lifecycle-routing-policy.test.ts} +6 -6
  150. package/tests/core/principle-internalization/lineage-source-retired.test.ts +56 -0
  151. package/tests/core/principle-internalization/principle-lifecycle-service.test.ts +1 -23
  152. package/tests/core/principle-tree-ledger-adapter.test.ts +253 -0
  153. package/tests/core/reflection-context.test.ts +0 -14
  154. package/tests/core/replay-engine.test.ts +127 -215
  155. package/tests/core/rule-host-helpers.test.ts +2 -2
  156. package/tests/core/rule-implementation-runtime.test.ts +0 -27
  157. package/tests/core/workflow-funnel-loader.test.ts +162 -0
  158. package/tests/core/workspace-dir-validation.test.ts +8 -1
  159. package/tests/core-anti-growth.test.ts +192 -0
  160. package/tests/hook-workspace-nextaction-contract.test.ts +42 -0
  161. package/tests/hooks/confirm-first-gate.test.ts +333 -0
  162. package/tests/hooks/gate-auto-correct-shadow.test.ts +310 -0
  163. package/tests/hooks/gate-auto-correct.test.ts +665 -0
  164. package/tests/hooks/gate-rule-host-pipeline.test.ts +2 -1
  165. package/tests/hooks/pain.test.ts +269 -12
  166. package/tests/hooks/prompt-characterization.test.ts +500 -0
  167. package/tests/hooks/prompt-size-guard.test.ts +32 -17
  168. package/tests/hooks/runtime-v2-prompt-activation.test.ts +869 -0
  169. package/tests/index.test.ts +94 -1
  170. package/tests/integration/auto-entry-gate.test.ts +248 -0
  171. package/tests/integration/internalization-trigger-guard.test.ts +69 -0
  172. package/tests/integration/m8-legacy-paths.test.ts +63 -0
  173. package/tests/integration/runtime-v2-pain-guard.test.ts +125 -0
  174. package/tests/plugin-config-resolution-cutover.test.ts +359 -0
  175. package/tests/runtime-v2-discovery-guard.test.ts +154 -0
  176. package/tests/service/central-database.test.ts +457 -0
  177. package/tests/service/evolution-worker.correction-observer.test.ts +173 -0
  178. package/tests/service/evolution-worker.timeout.test.ts +11 -129
  179. package/tests/service/internalization-trigger-adapter.test.ts +251 -0
  180. package/tests/service/monitoring-query-service.test.ts +1 -47
  181. package/tests/service/queue-io.test.ts +1 -62
  182. package/tests/service/runtime-summary-service.test.ts +3 -1
  183. package/tests/service/workflow-watchdog.test.ts +0 -91
  184. package/tests/utils/file-lock.test.ts +5 -3
  185. package/tests/utils/session-key.test.ts +52 -0
  186. package/tests/utils/subagent-probe.test.ts +48 -1
  187. package/vitest.config.ts +4 -11
  188. package/.planning/codebase/ARCHITECTURE.md +0 -157
  189. package/.planning/codebase/CONCERNS.md +0 -145
  190. package/.planning/codebase/CONVENTIONS.md +0 -148
  191. package/.planning/codebase/INTEGRATIONS.md +0 -81
  192. package/.planning/codebase/STACK.md +0 -87
  193. package/.planning/codebase/STRUCTURE.md +0 -193
  194. package/.planning/codebase/TESTING.md +0 -243
  195. package/.planning/phases/01-basic-visualization/01-GAP-CLOSURE-VERIFICATION.md +0 -113
  196. package/docs/COMMAND_REFERENCE.md +0 -76
  197. package/docs/COMMAND_REFERENCE_EN.md +0 -79
  198. package/scripts/build-web.mjs +0 -46
  199. package/scripts/diagnose-nocturnal.mjs +0 -537
  200. package/scripts/seed-nocturnal-scenarios.mjs +0 -384
  201. package/src/commands/nocturnal-review.ts +0 -322
  202. package/src/commands/nocturnal-rollout.ts +0 -790
  203. package/src/commands/nocturnal-train.ts +0 -986
  204. package/src/commands/pd-reflect.ts +0 -88
  205. package/src/core/adaptive-thresholds.ts +0 -478
  206. package/src/core/diagnostician-task-store.ts +0 -192
  207. package/src/core/nocturnal-arbiter.ts +0 -715
  208. package/src/core/nocturnal-artifact-lineage.ts +0 -116
  209. package/src/core/nocturnal-artificer.ts +0 -257
  210. package/src/core/nocturnal-candidate-scoring.ts +0 -530
  211. package/src/core/nocturnal-compliance.ts +0 -1146
  212. package/src/core/nocturnal-dataset.ts +0 -763
  213. package/src/core/nocturnal-executability.ts +0 -428
  214. package/src/core/nocturnal-export.ts +0 -499
  215. package/src/core/nocturnal-paths.ts +0 -240
  216. package/src/core/nocturnal-reasoning-deriver.ts +0 -343
  217. package/src/core/nocturnal-rule-implementation-validator.ts +0 -246
  218. package/src/core/nocturnal-snapshot-contract.ts +0 -99
  219. package/src/core/nocturnal-trajectory-extractor.ts +0 -512
  220. package/src/core/nocturnal-trinity-types.ts +0 -218
  221. package/src/core/nocturnal-trinity.ts +0 -2680
  222. package/src/core/principle-internalization/deprecated-readiness.ts +0 -93
  223. package/src/core/principle-internalization/internalization-routing-policy.ts +0 -208
  224. package/src/core/principle-internalization/lifecycle-metrics.ts +0 -152
  225. package/src/http/principles-console-route.ts +0 -709
  226. package/src/service/central-health-service.ts +0 -49
  227. package/src/service/central-overview-service.ts +0 -138
  228. package/src/service/control-ui-query-service.ts +0 -900
  229. package/src/service/cooldown-strategy.ts +0 -97
  230. package/src/service/evolution-pain-context.ts +0 -79
  231. package/src/service/evolution-query-service.ts +0 -407
  232. package/src/service/health-query-service.ts +0 -1038
  233. package/src/service/nocturnal-config.ts +0 -214
  234. package/src/service/nocturnal-runtime.ts +0 -734
  235. package/src/service/nocturnal-service.ts +0 -1605
  236. package/src/service/nocturnal-target-selector.ts +0 -545
  237. package/src/service/sleep-cycle.ts +0 -157
  238. package/src/service/startup-reconciler.ts +0 -112
  239. package/src/service/subagent-workflow/correction-observer-types.ts +0 -82
  240. package/src/service/subagent-workflow/correction-observer-workflow-manager.ts +0 -250
  241. package/src/service/subagent-workflow/deep-reflect-workflow-manager.ts +0 -1
  242. package/src/service/subagent-workflow/dynamic-timeout.ts +0 -30
  243. package/src/service/subagent-workflow/empathy-observer-workflow-manager.ts +0 -268
  244. package/src/service/subagent-workflow/nocturnal-workflow-manager.ts +0 -795
  245. package/src/service/subagent-workflow/runtime-direct-driver.ts +0 -268
  246. package/src/service/subagent-workflow/workflow-manager-base.ts +0 -580
  247. package/src/tools/write-pain-flag.ts +0 -215
  248. package/tests/commands/nocturnal-review.test.ts +0 -448
  249. package/tests/commands/nocturnal-train.test.ts +0 -97
  250. package/tests/commands/pd-reflect.test.ts +0 -49
  251. package/tests/core/adaptive-thresholds.test.ts +0 -261
  252. package/tests/core/nocturnal-arbiter.test.ts +0 -559
  253. package/tests/core/nocturnal-artifact-lineage.test.ts +0 -53
  254. package/tests/core/nocturnal-artificer.test.ts +0 -241
  255. package/tests/core/nocturnal-candidate-scoring.test.ts +0 -532
  256. package/tests/core/nocturnal-compliance-p-principles.test.ts +0 -133
  257. package/tests/core/nocturnal-compliance.test.ts +0 -646
  258. package/tests/core/nocturnal-dataset.test.ts +0 -892
  259. package/tests/core/nocturnal-e2e.test.ts +0 -234
  260. package/tests/core/nocturnal-executability.test.ts +0 -357
  261. package/tests/core/nocturnal-export.test.ts +0 -517
  262. package/tests/core/nocturnal-reasoning-deriver.test.ts +0 -372
  263. package/tests/core/nocturnal-reviewed-subset-comparison.test.ts +0 -428
  264. package/tests/core/nocturnal-rule-implementation-validator.test.ts +0 -127
  265. package/tests/core/nocturnal-snapshot-contract.test.ts +0 -121
  266. package/tests/core/nocturnal-trajectory-extractor.test.ts +0 -634
  267. package/tests/core/nocturnal-trinity.test.ts +0 -2053
  268. package/tests/core/pain-auto-repair.test.ts +0 -96
  269. package/tests/core/pain-integration.test.ts +0 -510
  270. package/tests/fixtures/nocturnal-reviewed-subset.json +0 -183
  271. package/tests/http/principles-console-route.test.ts +0 -162
  272. package/tests/integration/chaos-resilience.test.ts +0 -348
  273. package/tests/integration/empathy-workflow-integration.test.ts +0 -626
  274. package/tests/integration/pain-diagnostician-loop.e2e.test.ts +0 -380
  275. package/tests/service/control-ui-query-service.test.ts +0 -121
  276. package/tests/service/cooldown-strategy.test.ts +0 -164
  277. package/tests/service/data-endpoints-regression.test.ts +0 -834
  278. package/tests/service/empathy-observer-workflow-manager.test.ts +0 -175
  279. package/tests/service/evolution-worker.nocturnal.test.ts +0 -601
  280. package/tests/service/nocturnal-runtime-hardening.test.ts +0 -118
  281. package/tests/service/nocturnal-runtime.test.ts +0 -473
  282. package/tests/service/nocturnal-service-code-candidate.test.ts +0 -330
  283. package/tests/service/nocturnal-target-selector.test.ts +0 -615
  284. package/tests/service/startup-reconciler.test.ts +0 -148
  285. package/tests/tools/write-pain-flag.test.ts +0 -358
  286. package/ui/src/App.tsx +0 -45
  287. package/ui/src/api.ts +0 -220
  288. package/ui/src/charts.tsx +0 -955
  289. package/ui/src/components/ErrorState.tsx +0 -6
  290. package/ui/src/components/Loading.tsx +0 -13
  291. package/ui/src/components/ProtectedRoute.tsx +0 -12
  292. package/ui/src/components/Shell.tsx +0 -91
  293. package/ui/src/components/WorkspaceConfig.tsx +0 -178
  294. package/ui/src/components/index.ts +0 -5
  295. package/ui/src/context/auth.tsx +0 -80
  296. package/ui/src/context/theme.tsx +0 -66
  297. package/ui/src/hooks/useAutoRefresh.ts +0 -39
  298. package/ui/src/i18n/ui.ts +0 -473
  299. package/ui/src/main.tsx +0 -16
  300. package/ui/src/pages/EvolutionPage.tsx +0 -333
  301. package/ui/src/pages/FeedbackPage.tsx +0 -138
  302. package/ui/src/pages/GateMonitorPage.tsx +0 -136
  303. package/ui/src/pages/LoginPage.tsx +0 -89
  304. package/ui/src/pages/OverviewPage.tsx +0 -599
  305. package/ui/src/pages/SamplesPage.tsx +0 -174
  306. package/ui/src/pages/ThinkingModelsPage.tsx +0 -702
  307. package/ui/src/styles.css +0 -2020
  308. package/ui/src/types.ts +0 -384
  309. package/ui/src/utils/format.ts +0 -15
@@ -1,559 +0,0 @@
1
- import { describe, it, expect } from 'vitest';
2
- import {
3
- validateArtifact,
4
- parseAndValidateArtifact,
5
- type ArbiterResult,
6
- } from '../../src/core/nocturnal-arbiter.js';
7
-
8
- describe('Nocturnal Arbiter', () => {
9
- // -------------------------------------------------------------------------
10
- // Valid artifact factory
11
- // -------------------------------------------------------------------------
12
-
13
- function makeValidArtifact(overrides: Record<string, unknown> = {}): Record<string, unknown> {
14
- return {
15
- artifactId: 'a1b2c3d4-e5f6-7890-abcd-ef1234567890',
16
- sessionId: 'session-abc123',
17
- principleId: 'T-08',
18
- sourceSnapshotRef: 'snapshot-2026-03-27-001',
19
- badDecision: 'After bash command failed, immediately retried without diagnosing the root cause',
20
- betterDecision: 'Check the error message and verify preconditions before retrying a failed bash command',
21
- rationale: 'Treating each failure as a signal to diagnose rather than blindly retry prevents repeated failures',
22
- createdAt: '2026-03-27T12:00:00.000Z',
23
- ...overrides,
24
- };
25
- }
26
-
27
- // -------------------------------------------------------------------------
28
- // Tests: validateArtifact — valid inputs
29
- // -------------------------------------------------------------------------
30
-
31
- describe('validateArtifact', () => {
32
- it('passes a valid artifact with all required fields', () => {
33
- const artifact = makeValidArtifact();
34
- const result = validateArtifact(artifact);
35
- expect(result.passed).toBe(true);
36
- expect(result.artifact).toBeDefined();
37
- expect(result.failures).toHaveLength(0);
38
- });
39
-
40
- it('passes with optional sourceSnapshotRef present', () => {
41
- const artifact = makeValidArtifact({ sourceSnapshotRef: 'snapshot-custom-001' });
42
- const result = validateArtifact(artifact);
43
- expect(result.passed).toBe(true);
44
- });
45
-
46
- it('passes when principleId and sessionId cross-validate against expected values', () => {
47
- const artifact = makeValidArtifact({ principleId: 'T-08', sessionId: 'session-abc123' });
48
- const result = validateArtifact(artifact, {
49
- expectedPrincipleId: 'T-08',
50
- expectedSessionId: 'session-abc123',
51
- });
52
- expect(result.passed).toBe(true);
53
- });
54
-
55
- it('passes a minimal but complete artifact', () => {
56
- // Only required fields, no optional
57
- const artifact = {
58
- artifactId: '11111111-2222-4333-aaaa-555555555555',
59
- sessionId: 'session-minimal',
60
- principleId: 'T-01',
61
- badDecision: 'Edited a file without reading it first',
62
- betterDecision: 'Read the file before editing to understand its current state',
63
- rationale: 'Surveying the existing territory before making changes prevents conflicts',
64
- createdAt: '2026-03-27T12:00:00.000Z',
65
- };
66
- const result = validateArtifact(artifact);
67
- expect(result.passed).toBe(true);
68
- });
69
- });
70
-
71
- // -------------------------------------------------------------------------
72
- // Tests: validateArtifact — invalid JSON structure
73
- // -------------------------------------------------------------------------
74
-
75
- describe('validateArtifact — invalid JSON structure', () => {
76
- it('rejects null', () => {
77
- const result = validateArtifact(null);
78
- expect(result.passed).toBe(false);
79
- expect(result.failures[0].reason).toContain('must be a JSON object');
80
- });
81
-
82
- it('rejects undefined', () => {
83
- const result = validateArtifact(undefined);
84
- expect(result.passed).toBe(false);
85
- expect(result.failures[0].reason).toContain('must be a JSON object');
86
- });
87
-
88
- it('rejects an array', () => {
89
- const result = validateArtifact([{ artifactId: 'xxx' }]);
90
- expect(result.passed).toBe(false);
91
- expect(result.failures[0].reason).toContain('must be a JSON object');
92
- });
93
-
94
- it('rejects a string', () => {
95
- const result = validateArtifact('not an object');
96
- expect(result.passed).toBe(false);
97
- expect(result.failures[0].reason).toContain('must be a JSON object');
98
- });
99
-
100
- it('rejects a number', () => {
101
- const result = validateArtifact(42);
102
- expect(result.passed).toBe(false);
103
- expect(result.failures[0].reason).toContain('must be a JSON object');
104
- });
105
- });
106
-
107
- // -------------------------------------------------------------------------
108
- // Tests: validateArtifact — invalid flag from reflector
109
- // -------------------------------------------------------------------------
110
-
111
- describe('validateArtifact — invalid flag', () => {
112
- it('rejects artifact with invalid: true', () => {
113
- const artifact = makeValidArtifact({ invalid: true, reason: 'no clear violation found' });
114
- const result = validateArtifact(artifact);
115
- expect(result.passed).toBe(false);
116
- expect(result.failures[0].reason).toContain('invalid');
117
- });
118
-
119
- it('rejects artifact with invalid: "true" (string)', () => {
120
- const artifact = makeValidArtifact({ invalid: 'true', reason: 'no violation' });
121
- const result = validateArtifact(artifact);
122
- expect(result.passed).toBe(false);
123
- expect(result.failures[0].reason).toContain('invalid');
124
- });
125
- });
126
-
127
- // -------------------------------------------------------------------------
128
- // Tests: validateArtifact — missing required fields
129
- // -------------------------------------------------------------------------
130
-
131
- describe('validateArtifact — missing required fields', () => {
132
- it('rejects missing artifactId', () => {
133
- const artifact = makeValidArtifact();
134
- delete artifact.artifactId;
135
- const result = validateArtifact(artifact);
136
- expect(result.passed).toBe(false);
137
- expect(result.failures.some(f => f.field === 'artifactId')).toBe(true);
138
- });
139
-
140
- it('rejects empty artifactId', () => {
141
- const artifact = makeValidArtifact({ artifactId: '' });
142
- const result = validateArtifact(artifact);
143
- expect(result.passed).toBe(false);
144
- expect(result.failures.some(f => f.field === 'artifactId')).toBe(true);
145
- });
146
-
147
- it('rejects whitespace-only artifactId', () => {
148
- const artifact = makeValidArtifact({ artifactId: ' ' });
149
- const result = validateArtifact(artifact);
150
- expect(result.passed).toBe(false);
151
- expect(result.failures.some(f => f.field === 'artifactId')).toBe(true);
152
- });
153
-
154
- it('rejects missing sessionId', () => {
155
- const artifact = makeValidArtifact();
156
- delete artifact.sessionId;
157
- const result = validateArtifact(artifact);
158
- expect(result.passed).toBe(false);
159
- expect(result.failures.some(f => f.field === 'sessionId')).toBe(true);
160
- });
161
-
162
- it('rejects missing principleId', () => {
163
- const artifact = makeValidArtifact();
164
- delete artifact.principleId;
165
- const result = validateArtifact(artifact);
166
- expect(result.passed).toBe(false);
167
- expect(result.failures.some(f => f.field === 'principleId')).toBe(true);
168
- });
169
-
170
- it('rejects missing badDecision', () => {
171
- const artifact = makeValidArtifact();
172
- delete artifact.badDecision;
173
- const result = validateArtifact(artifact);
174
- expect(result.passed).toBe(false);
175
- expect(result.failures.some(f => f.field === 'badDecision')).toBe(true);
176
- });
177
-
178
- it('rejects missing betterDecision', () => {
179
- const artifact = makeValidArtifact();
180
- delete artifact.betterDecision;
181
- const result = validateArtifact(artifact);
182
- expect(result.passed).toBe(false);
183
- expect(result.failures.some(f => f.field === 'betterDecision')).toBe(true);
184
- });
185
-
186
- it('rejects missing rationale', () => {
187
- const artifact = makeValidArtifact();
188
- delete artifact.rationale;
189
- const result = validateArtifact(artifact);
190
- expect(result.passed).toBe(false);
191
- expect(result.failures.some(f => f.field === 'rationale')).toBe(true);
192
- });
193
-
194
- it('rejects missing createdAt', () => {
195
- const artifact = makeValidArtifact();
196
- delete artifact.createdAt;
197
- const result = validateArtifact(artifact);
198
- expect(result.passed).toBe(false);
199
- expect(result.failures.some(f => f.field === 'createdAt')).toBe(true);
200
- });
201
-
202
- it('rejects empty createdAt', () => {
203
- const artifact = makeValidArtifact({ createdAt: '' });
204
- const result = validateArtifact(artifact);
205
- expect(result.passed).toBe(false);
206
- expect(result.failures.some(f => f.field === 'createdAt')).toBe(true);
207
- });
208
- });
209
-
210
- // -------------------------------------------------------------------------
211
- // Tests: validateArtifact — invalid field formats
212
- // -------------------------------------------------------------------------
213
-
214
- describe('validateArtifact — invalid field formats', () => {
215
- it('rejects artifactId that is not a valid UUID', () => {
216
- const artifact = makeValidArtifact({ artifactId: 'not-a-uuid' });
217
- const result = validateArtifact(artifact);
218
- expect(result.passed).toBe(false);
219
- expect(result.failures.some(f => f.field === 'artifactId')).toBe(true);
220
- });
221
-
222
- it('rejects createdAt that is not ISO 8601', () => {
223
- const artifact = makeValidArtifact({ createdAt: '2026-03-27' });
224
- const result = validateArtifact(artifact);
225
- expect(result.passed).toBe(false);
226
- expect(result.failures.some(f => f.field === 'createdAt')).toBe(true);
227
- });
228
-
229
- it('rejects createdAt with time but no seconds', () => {
230
- const artifact = makeValidArtifact({ createdAt: '2026-03-27T12:00Z' });
231
- const result = validateArtifact(artifact);
232
- expect(result.passed).toBe(false);
233
- expect(result.failures.some(f => f.field === 'createdAt')).toBe(true);
234
- });
235
-
236
- it('rejects createdAt with milliseconds (valid ISO but our format is different)', () => {
237
- // Our regex requires .SSS after T
238
- const artifact = makeValidArtifact({ createdAt: '2026-03-27T12:00:00Z' });
239
- const result = validateArtifact(artifact);
240
- // Actually this should pass — our regex allows optional .SSS
241
- // Let's test the other direction
242
- const artifact2 = makeValidArtifact({ createdAt: '2026-03-27T12:00:00.123Z' });
243
- const result2 = validateArtifact(artifact2);
244
- expect(result2.passed).toBe(true);
245
- });
246
- });
247
-
248
- // -------------------------------------------------------------------------
249
- // Tests: validateArtifact — cross-validation
250
- // -------------------------------------------------------------------------
251
-
252
- describe('validateArtifact — cross-validation', () => {
253
- it('rejects principleId mismatch', () => {
254
- const artifact = makeValidArtifact({ principleId: 'T-08' });
255
- const result = validateArtifact(artifact, { expectedPrincipleId: 'T-01' });
256
- expect(result.passed).toBe(false);
257
- expect(result.failures.some(f => f.reason.includes('principleId mismatch'))).toBe(true);
258
- });
259
-
260
- it('rejects sessionId mismatch', () => {
261
- const artifact = makeValidArtifact({ sessionId: 'session-abc' });
262
- const result = validateArtifact(artifact, { expectedSessionId: 'session-xyz' });
263
- expect(result.passed).toBe(false);
264
- expect(result.failures.some(f => f.reason.includes('sessionId mismatch'))).toBe(true);
265
- });
266
-
267
- it('passes when principleId matches expected', () => {
268
- const artifact = makeValidArtifact({ principleId: 'T-08' });
269
- const result = validateArtifact(artifact, { expectedPrincipleId: 'T-08' });
270
- expect(result.passed).toBe(true);
271
- });
272
-
273
- it('passes when sessionId matches expected', () => {
274
- const artifact = makeValidArtifact({ sessionId: 'session-abc' });
275
- const result = validateArtifact(artifact, { expectedSessionId: 'session-abc' });
276
- expect(result.passed).toBe(true);
277
- });
278
-
279
- it('passes when no expected values provided', () => {
280
- const artifact = makeValidArtifact({ principleId: 'T-99', sessionId: 'session-xyz' });
281
- const result = validateArtifact(artifact);
282
- expect(result.passed).toBe(true);
283
- });
284
- });
285
-
286
- // -------------------------------------------------------------------------
287
- // Tests: validateArtifact — placeholder detection
288
- // -------------------------------------------------------------------------
289
-
290
- describe('validateArtifact — placeholder detection', () => {
291
- const placeholderTests = [
292
- { value: '<placeholder>', expected: true },
293
- { value: '<uuid>', expected: true },
294
- { value: '<session-id>', expected: true },
295
- { value: '<principle-id>', expected: true },
296
- { value: 'undefined', expected: true },
297
- { value: 'null', expected: true },
298
- { value: 'N/A', expected: true },
299
- { value: 'TODO', expected: true },
300
- { value: 'FIXME', expected: true },
301
- { value: 'valid decision text', expected: false },
302
- { value: 'Read the file before editing', expected: false },
303
- ];
304
-
305
- placeholderTests.forEach(({ value, expected }) => {
306
- it(`badDecision: '${value}' → ${expected ? 'rejected' : 'accepted'}`, () => {
307
- const artifact = makeValidArtifact({ badDecision: value });
308
- const result = validateArtifact(artifact);
309
- if (expected) {
310
- expect(result.passed).toBe(false);
311
- expect(result.failures.some(f => f.reason.includes('placeholder'))).toBe(true);
312
- } else {
313
- expect(result.passed).toBe(true);
314
- }
315
- });
316
- });
317
-
318
- it('rejects betterDecision containing placeholder', () => {
319
- const artifact = makeValidArtifact({ betterDecision: '<action>' });
320
- const result = validateArtifact(artifact);
321
- expect(result.passed).toBe(false);
322
- expect(result.failures.some(f => f.field === 'betterDecision')).toBe(true);
323
- });
324
-
325
- it('rejects rationale containing placeholder', () => {
326
- const artifact = makeValidArtifact({ rationale: 'TODO: add rationale' });
327
- const result = validateArtifact(artifact);
328
- expect(result.passed).toBe(false);
329
- expect(result.failures.some(f => f.field === 'rationale')).toBe(true);
330
- });
331
- });
332
-
333
- // -------------------------------------------------------------------------
334
- // Tests: validateArtifact — raw content detection
335
- // -------------------------------------------------------------------------
336
-
337
- describe('validateArtifact — raw content detection', () => {
338
- it('rejects badDecision containing function definition', () => {
339
- const artifact = makeValidArtifact({ badDecision: 'function handleError() { return 1; }' });
340
- const result = validateArtifact(artifact);
341
- expect(result.passed).toBe(false);
342
- expect(result.failures.some(f => f.reason.includes('raw/private content'))).toBe(true);
343
- });
344
-
345
- it('rejects badDecision containing import statement', () => {
346
- const artifact = makeValidArtifact({ badDecision: 'import { foo } from "./bar"; doSomething();' });
347
- const result = validateArtifact(artifact);
348
- expect(result.passed).toBe(false);
349
- expect(result.failures.some(f => f.reason.includes('raw/private content'))).toBe(true);
350
- });
351
-
352
- it('rejects betterDecision containing credential assignment pattern', () => {
353
- // api_key= with an actual value is a credential leak
354
- const artifact = makeValidArtifact({ betterDecision: 'Check the api_key=ABC123 before proceeding' });
355
- const result = validateArtifact(artifact);
356
- expect(result.passed).toBe(false);
357
- expect(result.failures.some(f => f.reason.includes('raw/private content'))).toBe(true);
358
- });
359
-
360
- it('accepts credential-like words without assignment (not raw content)', () => {
361
- // "api_key" as a word in natural decision text is not a credential leak
362
- const artifact = makeValidArtifact({ betterDecision: 'Check the api_key before proceeding' });
363
- const result = validateArtifact(artifact);
364
- expect(result.passed).toBe(true);
365
- });
366
-
367
- it('accepts text without raw content patterns', () => {
368
- const artifact = makeValidArtifact({
369
- badDecision: 'Proceeded with editing without reading the file first',
370
- betterDecision: 'Read the file to understand its current structure before making edits',
371
- });
372
- const result = validateArtifact(artifact);
373
- expect(result.passed).toBe(true);
374
- });
375
- });
376
-
377
- // -------------------------------------------------------------------------
378
- // Tests: validateArtifact — semantic rules
379
- // -------------------------------------------------------------------------
380
-
381
- describe('validateArtifact — semantic rules', () => {
382
- it('rejects identical badDecision and betterDecision', () => {
383
- const artifact = makeValidArtifact({
384
- badDecision: 'Read the file first',
385
- betterDecision: 'Read the file first',
386
- });
387
- const result = validateArtifact(artifact);
388
- expect(result.passed).toBe(false);
389
- expect(result.failures.some(f => f.reason.includes('identical'))).toBe(true);
390
- });
391
-
392
- it('accepts different badDecision and betterDecision', () => {
393
- const artifact = makeValidArtifact({
394
- badDecision: 'Edited without reading',
395
- betterDecision: 'Read the file before editing',
396
- });
397
- const result = validateArtifact(artifact);
398
- expect(result.passed).toBe(true);
399
- });
400
-
401
- it('rejects rationale that is too short', () => {
402
- const artifact = makeValidArtifact({ rationale: 'Because.' });
403
- const result = validateArtifact(artifact);
404
- expect(result.passed).toBe(false);
405
- expect(result.failures.some(f => f.reason.includes('too short'))).toBe(true);
406
- });
407
-
408
- it('accepts rationale at minimum length (20 chars)', () => {
409
- const artifact = makeValidArtifact({ rationale: '12345678901234567890' }); // exactly 20
410
- const result = validateArtifact(artifact);
411
- expect(result.passed).toBe(true);
412
- });
413
-
414
- it('rejects sourceSnapshotRef that is present but empty', () => {
415
- const artifact = makeValidArtifact({ sourceSnapshotRef: '' });
416
- const result = validateArtifact(artifact);
417
- expect(result.passed).toBe(false);
418
- expect(result.failures.some(f => f.field === 'sourceSnapshotRef')).toBe(true);
419
- });
420
- });
421
-
422
- // -------------------------------------------------------------------------
423
- // Tests: parseAndValidateArtifact
424
- // -------------------------------------------------------------------------
425
-
426
- describe('parseAndValidateArtifact', () => {
427
- it('parses a valid JSON string and validates successfully', () => {
428
- const json = JSON.stringify(makeValidArtifact());
429
- const result = parseAndValidateArtifact(json);
430
- expect(result.passed).toBe(true);
431
- expect(result.artifact).toBeDefined();
432
- expect(result.artifact?.principleId).toBe('T-08');
433
- });
434
-
435
- it('fails on invalid JSON', () => {
436
- const result = parseAndValidateArtifact('not valid json {');
437
- expect(result.passed).toBe(false);
438
- expect(result.failures[0].reason).toContain('Failed to parse JSON');
439
- });
440
-
441
- it('fails on empty string', () => {
442
- const result = parseAndValidateArtifact('');
443
- expect(result.passed).toBe(false);
444
- expect(result.failures[0].reason).toContain('Failed to parse JSON');
445
- });
446
-
447
- it('passes cross-validation from options', () => {
448
- const artifact = makeValidArtifact({ principleId: 'T-01', sessionId: 'session-xyz' });
449
- const json = JSON.stringify(artifact);
450
- const result = parseAndValidateArtifact(json, {
451
- expectedPrincipleId: 'T-01',
452
- expectedSessionId: 'session-xyz',
453
- });
454
- expect(result.passed).toBe(true);
455
- });
456
-
457
- it('fails cross-validation from options on mismatch', () => {
458
- const artifact = makeValidArtifact({ principleId: 'T-01' });
459
- const json = JSON.stringify(artifact);
460
- const result = parseAndValidateArtifact(json, { expectedPrincipleId: 'T-99' });
461
- expect(result.passed).toBe(false);
462
- });
463
- });
464
-
465
- // -------------------------------------------------------------------------
466
- // Tests: constructed artifact output shape
467
- // -------------------------------------------------------------------------
468
-
469
- describe('constructed artifact shape', () => {
470
- it('returns correct NocturnalArtifact shape when passed', () => {
471
- const artifact = makeValidArtifact();
472
- const result = validateArtifact(artifact);
473
- expect(result.passed).toBe(true);
474
- expect(result.artifact).toEqual({
475
- artifactId: 'a1b2c3d4-e5f6-7890-abcd-ef1234567890',
476
- sessionId: 'session-abc123',
477
- principleId: 'T-08',
478
- sourceSnapshotRef: 'snapshot-2026-03-27-001',
479
- badDecision: 'After bash command failed, immediately retried without diagnosing the root cause',
480
- betterDecision: 'Check the error message and verify preconditions before retrying a failed bash command',
481
- rationale: 'Treating each failure as a signal to diagnose rather than blindly retry prevents repeated failures',
482
- createdAt: '2026-03-27T12:00:00.000Z',
483
- });
484
- });
485
-
486
- it('converts all fields to strings even if passed as numbers', () => {
487
- // artifactId is normally string, but test robustness
488
- const artifact = makeValidArtifact() as Record<string, unknown>;
489
- const result = validateArtifact(artifact);
490
- expect(result.passed).toBe(true);
491
- expect(typeof result.artifact?.artifactId).toBe('string');
492
- });
493
-
494
- it('uses empty string for missing sourceSnapshotRef', () => {
495
- const artifact = makeValidArtifact();
496
- delete artifact.sourceSnapshotRef;
497
- const result = validateArtifact(artifact);
498
- expect(result.passed).toBe(true);
499
- expect(result.artifact?.sourceSnapshotRef).toBe('');
500
- });
501
- });
502
-
503
- // -------------------------------------------------------------------------
504
- // Tests: quality threshold gates (Rule 10/11)
505
- // -------------------------------------------------------------------------
506
-
507
- describe('quality threshold gates', () => {
508
- const defaultThresholds = { thinkingModelDeltaMin: 0.05, planningRatioGainMin: -0.5 };
509
-
510
- it('rejects when thinkingModelDelta is below threshold', () => {
511
- const artifact = makeValidArtifact({ thinkingModelDelta: 0.03 });
512
- const result = validateArtifact(artifact, { qualityThresholds: defaultThresholds });
513
- expect(result.passed).toBe(false);
514
- expect(result.failures).toHaveLength(1);
515
- expect(result.failures[0].field).toBe('thinkingModelDelta');
516
- });
517
-
518
- it('passes when thinkingModelDelta equals threshold exactly (boundary value)', () => {
519
- const artifact = makeValidArtifact({ thinkingModelDelta: 0.05 });
520
- const result = validateArtifact(artifact, { qualityThresholds: defaultThresholds });
521
- expect(result.passed).toBe(true);
522
- });
523
-
524
- it('passes when thinkingModelDelta exceeds threshold', () => {
525
- const artifact = makeValidArtifact({ thinkingModelDelta: 0.15 });
526
- const result = validateArtifact(artifact, { qualityThresholds: defaultThresholds });
527
- expect(result.passed).toBe(true);
528
- });
529
-
530
- it('passes when thinkingModelDelta is absent (optional field)', () => {
531
- const artifact = makeValidArtifact();
532
- delete artifact.thinkingModelDelta;
533
- const result = validateArtifact(artifact, { qualityThresholds: defaultThresholds });
534
- expect(result.passed).toBe(true);
535
- });
536
-
537
- it('rejects when planningRatioGain is below threshold', () => {
538
- const artifact = makeValidArtifact({ planningRatioGain: -0.6 });
539
- const result = validateArtifact(artifact, { qualityThresholds: defaultThresholds });
540
- expect(result.passed).toBe(false);
541
- expect(result.failures.some(f => f.field === 'planningRatioGain')).toBe(true);
542
- });
543
-
544
- it('passes when planningRatioGain equals threshold exactly (boundary value)', () => {
545
- const artifact = makeValidArtifact({ planningRatioGain: -0.5 });
546
- const result = validateArtifact(artifact, { qualityThresholds: defaultThresholds });
547
- expect(result.passed).toBe(true);
548
- });
549
-
550
- it('rejects both quality thresholds simultaneously', () => {
551
- const artifact = makeValidArtifact({ thinkingModelDelta: 0.01, planningRatioGain: -0.8 });
552
- const result = validateArtifact(artifact, { qualityThresholds: defaultThresholds });
553
- expect(result.passed).toBe(false);
554
- expect(result.failures.length).toBeGreaterThanOrEqual(2);
555
- expect(result.failures.some(f => f.field === 'thinkingModelDelta')).toBe(true);
556
- expect(result.failures.some(f => f.field === 'planningRatioGain')).toBe(true);
557
- });
558
- });
559
- });
@@ -1,53 +0,0 @@
1
- import { afterEach, beforeEach, describe, expect, it } from 'vitest';
2
- import * as fs from 'fs';
3
- import * as os from 'os';
4
- import * as path from 'path';
5
- import {
6
- appendCandidateArtifactLineageRecord,
7
- listArtifactLineageRecords,
8
- } from '../../src/core/nocturnal-artifact-lineage.js';
9
- import { safeRmDir } from '../test-utils.js';
10
-
11
- describe('nocturnal-artifact-lineage', () => {
12
- let workspaceDir: string;
13
-
14
- beforeEach(() => {
15
- workspaceDir = fs.mkdtempSync(path.join(os.tmpdir(), 'pd-nocturnal-lineage-'));
16
- });
17
-
18
- afterEach(() => {
19
- safeRmDir(workspaceDir);
20
- });
21
-
22
- it('appends a candidate lineage record with explicit pain and gate refs', () => {
23
- appendCandidateArtifactLineageRecord(workspaceDir, {
24
- artifactId: 'artifact-1',
25
- principleId: 'P-001',
26
- ruleId: 'R-001',
27
- sessionId: 'session-1',
28
- sourceSnapshotRef: 'snapshot-1',
29
- sourcePainIds: ['pain:gate:1', 'pain:tool:2'],
30
- sourceGateBlockIds: ['gate:write:1'],
31
- storagePath: path.join(workspaceDir, '.state', 'principles', 'implementations', 'IMPL-1'),
32
- implementationId: 'IMPL-1',
33
- createdAt: '2026-04-08T00:00:00.000Z',
34
- });
35
-
36
- const records = listArtifactLineageRecords(
37
- workspaceDir,
38
- 'rule-implementation-candidate'
39
- );
40
-
41
- expect(records).toHaveLength(1);
42
- expect(records[0]).toMatchObject({
43
- artifactKind: 'rule-implementation-candidate',
44
- artifactId: 'artifact-1',
45
- principleId: 'P-001',
46
- ruleId: 'R-001',
47
- sourceSnapshotRef: 'snapshot-1',
48
- sourcePainIds: ['pain:gate:1', 'pain:tool:2'],
49
- sourceGateBlockIds: ['gate:write:1'],
50
- implementationId: 'IMPL-1',
51
- });
52
- });
53
- });