principles-disciple 1.72.0 → 1.73.0

package/src/service/startup-reconciler.ts

@@ -1,112 +0,0 @@
-/**
- * Startup Reconciler — One-time validation and cleanup at pipeline startup
- * ===========================================================
- *
- * Runs before the first heartbeat cycle to ensure the nocturnal pipeline
- * enters a clean state. Three operations:
- * 1. Validate nocturnal-runtime.json integrity (reset if corrupted)
- * 2. Clear expired cooldown entries from taskFailureState
- * 3. Remove orphan .tmp files from the state directory
- *
- * All operations are non-destructive and idempotent.
- */
-
-import * as fs from 'fs';
-import * as path from 'path';
-import { writeState, readStateSync } from './nocturnal-runtime.js';
-
-export interface ReconciliationResult {
-    /** Number of expired cooldown entries cleared */
-    cooldownsCleared: number;
-    /** List of orphan .tmp files removed */
-    orphansRemoved: string[];
-    /** Whether the state file was reset due to corruption */
-    stateReset: boolean;
-}
-
-/**
- * Run startup reconciliation on the nocturnal pipeline state.
- *
- * 1. Validate state file — reset to defaults if corrupted
- * 2. Clear expired cooldowns from taskFailureState
- * 3. Remove orphan .tmp files from state directory
- *
- * @param stateDir - State directory containing nocturnal-runtime.json
- * @returns ReconciliationResult summary
- */
-export async function reconcileStartup(stateDir: string): Promise<ReconciliationResult> {
-    const result: ReconciliationResult = {
-        cooldownsCleared: 0,
-        orphansRemoved: [],
-        stateReset: false,
-    };
-
-    // Step 1: Validate state file integrity
-    // Check if the raw file is parseable; readStateSync silently returns defaults on corruption
-    let state;
-    const stateFilePath = path.join(stateDir, 'nocturnal-runtime.json');
-    if (fs.existsSync(stateFilePath)) {
-        try {
-            const raw = fs.readFileSync(stateFilePath, 'utf8');
-            JSON.parse(raw); // Validate JSON
-            state = readStateSync(stateDir);
-        } catch {
-            // Corrupted JSON — back up and reset to canonical defaults
-            try {
-                const backupPath = stateFilePath + '.corrupted.' + Date.now();
-                fs.renameSync(stateFilePath, backupPath);
-            } catch { /* best effort backup */ }
-            state = readStateSync(stateDir); // Returns canonical defaults
-            await writeState(stateDir, state);
-            result.stateReset = true;
-        }
-    } else {
-        state = readStateSync(stateDir);
-    }
-
-    // Step 2: Clear expired cooldowns from taskFailureState
-    if (state.taskFailureState) {
-        let changed = false;
-        for (const taskKind of Object.keys(state.taskFailureState)) {
-            const entry = state.taskFailureState[taskKind];
-            if (entry.cooldownUntil) {
-                const cooldownEnd = new Date(entry.cooldownUntil).getTime();
-                if (cooldownEnd < Date.now()) {
-                    // Remove cooldownUntil but preserve escalation history
-                    delete entry.cooldownUntil;
-                    result.cooldownsCleared++;
-                    changed = true;
-                }
-            }
-        }
-        if (changed) {
-            await writeState(stateDir, state);
-        }
-    }
-
-    // Step 3: Remove orphan .tmp files
-    let files: string[];
-    try {
-        files = fs.readdirSync(stateDir);
-    } catch {
-        // Directory read failure — non-blocking
-        return result;
-    }
-    for (const file of files) {
-        if (file.endsWith('.tmp')) {
-            const targetFile = file.slice(0, -4); // Remove .tmp suffix
-            const targetPath = path.join(stateDir, targetFile);
-            // Orphan = .tmp file whose target doesn't exist
-            if (!fs.existsSync(targetPath)) {
-                try {
-                    fs.unlinkSync(path.join(stateDir, file));
-                    result.orphansRemoved.push(file);
-                } catch {
-                    // Individual file deletion failure — continue cleaning others
-                }
-            }
-        }
-    }
-
-    return result;
-}

package/src/service/subagent-workflow/correction-observer-types.ts

@@ -1,82 +0,0 @@
-/**
- * Correction Observer Workflow - Type Definitions
- *
- * Types for the correction observer LLM optimization workflow.
- * This workflow dispatches an LLM subagent to analyze keyword performance
- * and recommend ADD/UPDATE/REMOVE actions for the correction keyword store.
- */
-
-import type { SubagentWorkflowSpec } from './types.js';
-
-/**
- * Input passed to the correction observer subagent.
- */
-export interface CorrectionObserverPayload {
-  /** Parent session that triggered the optimization */
-  parentSessionId: string;
-  /** Workspace directory */
-  workspaceDir: string;
-  /** Current keyword store summary for context */
-  keywordStoreSummary: {
-    totalKeywords: number;
-    terms: Array<{
-      term: string;
-      weight: number;
-      hitCount: number;
-      truePositiveCount: number;
-      falsePositiveCount: number;
-    }>;
-  };
-  /** Recent user messages for pattern analysis */
-  recentMessages: string[];
-
-  /**
-   * Trajectory history: user turns where correctionDetected=true (D-40-08).
-   * Includes term matched, timestamp, sessionId for FPR trend analysis.
-   */
-  trajectoryHistory: Array<{
-    sessionId: string;
-    timestamp: string;
-    term: string;
-    userMessage: string;
-  }>;
-}
-
-/**
- * Result from the correction observer subagent.
- */
-export interface CorrectionObserverResult {
-  /** Whether any changes were made */
-  updated: boolean;
-  /** The optimization decisions returned by the LLM (optional if updated=false) */
-  updates?: Record<string, {
-    action: 'add' | 'update' | 'remove';
-    weight?: number;
-    falsePositiveRate?: number;
-    reasoning: string;
-  }>;
-  /**
-   * Terms identified as false positives — user message didn't actually indicate
-   * frustration/correction despite correctionDetected firing for these terms.
-   * CORR-10 / H-1: Calling recordFalsePositive() decays weight by x0.8 per term.
-   * Only meaningful when fpAnalysisStatus='completed'.
-   */
-  fpTerms?: string[];
-  /**
-   * Whether FP analysis was performed. 'skipped' means the LLM did not run
-   * trajectory analysis (e.g., trajectory was empty). 'completed' means fpTerms
-   * contains the LLM's FP findings (may be empty if no FPs were found).
-   */
-  fpAnalysisStatus?: 'completed' | 'skipped';
-  /** Human-readable summary */
-  summary: string;
-}
-
-/**
- * Workflow spec for the correction observer optimization workflow.
- */
-export interface CorrectionObserverWorkflowSpec extends SubagentWorkflowSpec<CorrectionObserverResult> {
-  workflowType: 'correction_observer';
-  payload: CorrectionObserverPayload;
-  result?: CorrectionObserverResult;
-}

package/src/service/subagent-workflow/correction-observer-workflow-manager.ts

@@ -1,250 +0,0 @@
-/**
- * CorrectionObserverWorkflowManager
- *
- * Workflow manager that dispatches an LLM subagent to optimize correction
- * keywords based on recent match performance data and user feedback.
- *
- * Follows the established WorkflowManagerBase pattern from EmpathyObserverWorkflowManager.
- */
-
-import type { PluginLogger } from '../../openclaw-sdk.js';
-import type {
-    SubagentWorkflowSpec,
-    WorkflowMetadata,
-    WorkflowResultContext,
-    WorkflowPersistContext,
-    WorkflowHandle,
-} from './types.js';
-import type { RuntimeDirectDriver } from './runtime-direct-driver.js';
-import { WorkflowManagerBase } from './workflow-manager-base.js';
-import { isSubagentRuntimeAvailable } from '../../utils/subagent-probe.js';
-import type {
-    CorrectionObserverPayload,
-    CorrectionObserverResult,
-} from './correction-observer-types.js';
-
-const WORKFLOW_SESSION_PREFIX = 'agent:main:subagent:workflow-correction-';
-
-const DEFAULT_TIMEOUT_MS = 30_000;
-const DEFAULT_TTL_MS = 5 * 60 * 1000;
-
-// Prompt formatting constants
-const MAX_TRAJECTORY_MESSAGE_LENGTH = 80;
-
-// ── Options ─────────────────────────────────────────────────────────────────
-
-export interface CorrectionObserverWorkflowOptions {
-    workspaceDir: string;
-    logger: PluginLogger;
-    subagent: RuntimeDirectDriver['subagent'];
-    /** Pass api.runtime.agent.session to enable heartbeat-safe cleanup (#188) */
-    agentSession?: RuntimeDirectDriver['agentSession'];
-}
-
-// ── Helper Functions ─────────────────────────────────────────────────────────
-
-/**
- * Extract raw assistant text from messages or assistantTexts array.
- */
-function extractAssistantTextForSpec(messages: unknown[], assistantTexts?: string[]): string {
-    if (assistantTexts && assistantTexts.length > 0) {
-        return assistantTexts[assistantTexts.length - 1] || '';
-    }
-    for (let i = messages.length - 1; i >= 0; i--) {
-        const msg = messages[i] as { role?: string; content?: unknown };
-        if (msg?.role !== 'assistant') continue;
-        if (typeof msg.content === 'string') return msg.content;
-        if (Array.isArray(msg.content)) {
-            const txt = msg.content
-                .filter((part: unknown) => part && typeof part === 'object' && (part as { type?: string }).type === 'text' && typeof (part as { text?: unknown }).text === 'string')
-                .map((part: unknown) => (part as { text: string }).text)
-                .join('\n');
-            if (txt) return txt;
-        }
-    }
-    return '';
-}
-
-/**
- * Parse correction observer JSON payload from raw text.
- */
-function parseCorrectionObserverPayload(rawText: string): CorrectionObserverResult | null {
-    if (!rawText?.trim()) return null;
-    try {
-        return JSON.parse(rawText.trim()) as CorrectionObserverResult;
-    } catch {
-        const match = /\{[\s\S]*\}/.exec(rawText);
-        if (!match) return null;
-        try {
-            return JSON.parse(match[0]) as CorrectionObserverResult;
-        } catch {
-            return null;
-        }
-    }
-}
-
-// ── Workflow Spec ─────────────────────────────────────────────────────────────
-
-export const correctionObserverWorkflowSpec: SubagentWorkflowSpec<CorrectionObserverResult> = {
-    workflowType: 'correction_observer',
-    transport: 'runtime_direct',
-    timeoutMs: 30_000,
-    ttlMs: 300_000,
-    shouldDeleteSessionAfterFinalize: true,
-
-    buildPrompt(taskInput: unknown, _metadata: WorkflowMetadata): string {
-        const payload = taskInput as CorrectionObserverPayload;
-        const { keywordStoreSummary, recentMessages, trajectoryHistory } = payload;
-
-        const termsList = keywordStoreSummary.terms
-            .map(t => `  - term="${t.term}", weight=${t.weight}, hits=${t.hitCount}, TP=${t.truePositiveCount}, FP=${t.falsePositiveCount}`)
-            .join('\n');
-
-        const messages = recentMessages.length > 0
-            ? recentMessages.map(m => `  - ${JSON.stringify(m)}`).join('\n')
-            : '  (none)';
-
-        const trajectory = trajectoryHistory.length > 0
-            ? trajectoryHistory.map(t => `  - [${t.sessionId}] ${t.term} (${t.timestamp}): ${t.userMessage.substring(0, MAX_TRAJECTORY_MESSAGE_LENGTH)}`)
-              .join('\n')
-            : '  (none)';
-
-        return [
-            'You are a correction keyword optimizer.',
-            '',
-            '## TASK',
-            'Analyze the current correction keyword store and recent user messages.',
-            'Recommend ADD/UPDATE/REMOVE actions to improve correction cue accuracy.',
-            'Also identify terms that triggered false positives (correctionDetected fired but user message doesn\'t indicate actual frustration).',
-            '',
-            '## Current Keyword Store (' + keywordStoreSummary.totalKeywords + ' terms):',
-            termsList,
-            '',
-            '## Recent User Messages (' + recentMessages.length + ' messages):',
-            messages,
-            '',
-            '## Correction Trajectory (recent confirmed corrections, D-40-08):',
-            trajectory,
-            '',
-            '## Rules:',
-            '- ADD: If a correction pattern is detected in messages but not in store',
-            '- UPDATE: If a term\'s weight should change based on TP/FP ratio',
-            '- REMOVE: If a term has 0 hits after many uses AND high false positive rate (>0.3)',
-            '- FALSE POSITIVE: If a term appears in trajectory but the user message doesn\'t actually express frustration (e.g., user said "wrong" but in a factual context, not emotional)',
-            '- fpAnalysisStatus: set to "completed" if you performed trajectory analysis (even if no FPs found), or "skipped" if trajectory was empty/unavailable',
-            '- Keep reasoning concise (max 100 chars)',
-            '- Weight range: 0.1-0.9',
-            '',
-            'Return strict JSON (no markdown):',
-            '{"updated": boolean, "updates": {...}, "fpTerms": ["term1", ...], "fpAnalysisStatus": "completed" | "skipped", "summary": string}',
-            'Note: fpTerms is optional — only include if you identified clear false positives.',
-        ].join('\n');
-    },
-
-    async parseResult(ctx: WorkflowResultContext): Promise<CorrectionObserverResult | null> {
-        const rawText = extractAssistantTextForSpec(ctx.messages, ctx.assistantTexts);
-        return parseCorrectionObserverPayload(rawText);
-    },
-
-    async persistResult(_ctx: WorkflowPersistContext<CorrectionObserverResult>): Promise<void> {
-        // Result persistence is handled by the caller (evolution-worker.ts)
-        // which reads the result and applies keyword store updates.
-        // This spec handles only the LLM dispatch and result parsing.
-    },
-
-    shouldFinalizeOnWaitStatus(status: 'ok' | 'error' | 'timeout'): boolean {
-        return status === 'ok';
-    },
-};
-
-// ── Manager Class ─────────────────────────────────────────────────────────────
-
-export class CorrectionObserverWorkflowManager extends WorkflowManagerBase {
-    constructor(opts: CorrectionObserverWorkflowOptions) {
-        super({
-            workspaceDir: opts.workspaceDir,
-            logger: opts.logger,
-            subagent: opts.subagent,
-            agentSession: opts.agentSession,
-            workflowType: 'correction_observer',
-            sessionPrefix: WORKFLOW_SESSION_PREFIX,
-            defaultTimeoutMs: DEFAULT_TIMEOUT_MS,
-            defaultTtlMs: DEFAULT_TTL_MS,
-        });
-    }
-
-    async startWorkflow<TResult>(
-        spec: SubagentWorkflowSpec<TResult>,
-        options: {
-            parentSessionId: string;
-            workspaceDir?: string;
-            taskInput: unknown;
-            metadata?: Record<string, unknown>;
-        }
-    ): Promise<WorkflowHandle> {
-        // Surface degrade: skip boot sessions
-        if (options.parentSessionId.startsWith('boot-')) {
-            this.logger.info(`[PD:CorrectionObserver] Skipping workflow: boot session`);
-            throw new Error(`CorrectionObserverWorkflowManager: cannot start workflow for boot session`);
-        }
-
-        // Surface degrade: check subagent runtime availability
-        if (!isSubagentRuntimeAvailable(this.driver.getSubagent())) {
-            this.logger.info(`[PD:CorrectionObserver] Skipping workflow: subagent runtime unavailable`);
-            throw new Error(`CorrectionObserverWorkflowManager: subagent runtime unavailable`);
-        }
-
-        if (spec.transport !== 'runtime_direct') {
-            throw new Error(`CorrectionObserverWorkflowManager only supports runtime_direct transport`);
-        }
-
-        return super.startWorkflow(spec, options);
-    }
-
-    /**
-     * Get the parsed workflow result for a completed workflow.
-     * Used by callers (evolution-worker.ts) to retrieve LLM optimization results
-     * after the workflow completes, so mutations can be applied to the keyword store.
-     */
-    async getWorkflowResult(workflowId: string): Promise<CorrectionObserverResult | null> {
-        const workflow = this.store.getWorkflow(workflowId);
-        if (!workflow) return null;
-
-        const result = await this.driver.getResult({ sessionKey: workflow.child_session_key, limit: 20 });
-        return correctionObserverWorkflowSpec.parseResult({
-            messages: result.messages,
-            assistantTexts: result.assistantTexts,
-            metadata: JSON.parse(workflow.metadata_json) as WorkflowMetadata,
-            waitStatus: 'ok',
-        });
-    }
-
-     
-    protected override createWorkflowMetadata<TResult>(
-        spec: SubagentWorkflowSpec<TResult>,
-        options: {
-            parentSessionId: string;
-            workspaceDir?: string;
-            taskInput: unknown;
-            metadata?: Record<string, unknown>;
-        },
-        now: number
-    ): WorkflowMetadata {
-        return {
-            parentSessionId: options.parentSessionId,
-            workspaceDir: options.workspaceDir,
-            taskInput: options.taskInput,
-            startedAt: now,
-            workflowType: spec.workflowType,
-            ...options.metadata,
-        };
-    }
-}
-
-// ── Factory ─────────────────────────────────────────────────────────────────
-
-export function createCorrectionObserverWorkflowManager(
-    opts: CorrectionObserverWorkflowOptions
-): CorrectionObserverWorkflowManager {
-    return new CorrectionObserverWorkflowManager(opts);
-}

package/src/service/subagent-workflow/deep-reflect-workflow-manager.ts

@@ -1 +0,0 @@
-export {};

package/src/service/subagent-workflow/dynamic-timeout.ts

@@ -1,30 +0,0 @@
-/**
- * Dynamic Timeout Calculator for Subagent Workflows
- *
- * This module is now a thin re-export layer for backwards compatibility.
- * All functionality has been consolidated into utils/retry.ts.
- *
- * @module subagent-workflow/dynamic-timeout
- * @deprecated Use `../../utils/retry.js` directly instead
- */
-
-// Re-export everything from the unified retry module
-export {
-  // Constants
-  MIN_SAMPLES,
-  LOOKBACK_WINDOW,
-  SAFETY_MULTIPLIER,
-  MIN_TIMEOUT_MS,
-  MAX_TIMEOUT_MS,
-  MAX_TIMEOUT_RETRIES,
-  RETRY_BACKOFF_MULTIPLIER,
-
-  // Interfaces
-  DurationDataSource,
-
-  // Functions
-  percentile,
-  clampTimeout,
-  computeDynamicTimeout,
-  computeRetrySchedule,
-} from '../../utils/retry.js';