principles-disciple 1.42.0 → 1.44.0

package/src/service/health-query-service.ts

@@ -1,3 +1,4 @@
+ 
 import * as fs from 'fs';
 import * as path from 'path';
 import { readPainFlagData } from '../core/pain.js';
@@ -554,7 +555,7 @@ export class HealthQueryService {
     const streamPath = resolvePdPath(this.workspaceDir, 'EVOLUTION_STREAM');
     if (!fs.existsSync(streamPath)) return [];
 
-    // eslint-disable-next-line @typescript-eslint/init-declarations
+     
     let lines: string[];
     try {
       const raw = fs.readFileSync(streamPath, 'utf8').trim();
@@ -567,7 +568,7 @@ export class HealthQueryService {
     const records: RecentPrincipleChange[] = [];
     for (const line of lines) {
 
-      // eslint-disable-next-line @typescript-eslint/init-declarations
+       
       let event: EvolutionStreamRecord | null;
       try {
         event = JSON.parse(line) as EvolutionStreamRecord;
@@ -788,7 +789,7 @@ export class HealthQueryService {
 
    
    
-    // eslint-disable-next-line @typescript-eslint/class-methods-use-this -- complexity 15, refactor candidate
+     
   private getEventDedupKey(entry: EventLogEntry): string {
     const eventId = typeof entry.data?.eventId === 'string' ? entry.data.eventId : null;
     if (eventId) {
@@ -860,7 +861,7 @@ export class HealthQueryService {
 
    
      
-  // eslint-disable-next-line @typescript-eslint/class-methods-use-this
+   
   private resolveGateType(row: GateBlockRow): string {
     if (typeof row.gate_type === 'string' && row.gate_type.trim().length > 0) {
       return row.gate_type;
@@ -885,7 +886,7 @@ export class HealthQueryService {
   }
 
    
-  // eslint-disable-next-line @typescript-eslint/class-methods-use-this
+   
   private scoreToStatus(score: number): string {
     if (score >= 70) return 'healthy';
     if (score >= 40) return 'warning';
@@ -893,7 +894,7 @@ export class HealthQueryService {
   }
 
    
-  // eslint-disable-next-line @typescript-eslint/class-methods-use-this
+   
   private evolutionToStatus(tier: string, points: number): string {
     const lower = tier.toLowerCase();
     if (lower === 'forest' || lower === 'tree') return 'healthy';
@@ -902,7 +903,7 @@ export class HealthQueryService {
   }
 
    
-  // eslint-disable-next-line @typescript-eslint/class-methods-use-this
+   
   private safeListFiles(dirPath: string, predicate: (_name: string) => boolean): string[] {
     if (!fs.existsSync(dirPath)) return [];
     try {
@@ -915,7 +916,7 @@ export class HealthQueryService {
   }
 
    
-  // eslint-disable-next-line @typescript-eslint/class-methods-use-this
+   
   private readJsonFile<T>(filePath: string, fallback: T): T {
     if (!fs.existsSync(filePath)) return fallback;
     try {
@@ -926,13 +927,13 @@ export class HealthQueryService {
   }
 
    
-  // eslint-disable-next-line @typescript-eslint/class-methods-use-this
+   
   private asNumber(value: unknown, fallback: number): number {
     return Number.isFinite(value) ? Number(value) : fallback;
   }
 
    
-  // eslint-disable-next-line @typescript-eslint/class-methods-use-this
+   
   private asNullableNumber(value: unknown): number | null {
     if (Number.isFinite(value)) return Number(value);
     if (typeof value === 'string' && value.trim().length > 0) {

package/src/service/monitoring-query-service.ts

@@ -36,7 +36,7 @@ export class MonitoringQueryService {
     const now = Date.now();
     const workflowsWithStuckDetection = workflows.map(wf => {
       // Parse metadata for timeout configuration
-      // eslint-disable-next-line @typescript-eslint/no-use-before-define
+       
       const metadata = parseWorkflowMetadata(wf.metadata_json);
       const timeoutMs = metadata.timeoutMs ?? 15 * 60 * 1000; // Default 15 minutes
 
@@ -85,10 +85,10 @@ export class MonitoringQueryService {
 
       // Determine status
        
-      // eslint-disable-next-line @typescript-eslint/init-declarations
+       
       let status: 'pending' | 'running' | 'completed' | 'failed';
        
-      // eslint-disable-next-line @typescript-eslint/init-declarations
+       
       let reason: string | undefined;
 
       if (!startEvent) {
@@ -110,7 +110,7 @@ export class MonitoringQueryService {
 
       // Calculate duration if stage started and completed/failed
        
-      // eslint-disable-next-line @typescript-eslint/init-declarations
+       
       let duration: number | undefined;
       if (startEvent && (completeEvent || failedEvent)) {
         const endEvent = completeEvent || failedEvent;

package/src/service/nocturnal-runtime.ts

@@ -390,9 +390,6 @@ export function checkCooldown(
     } = {}
 ): CooldownCheckResult {
     const {
-         
-        globalCooldownMs: _globalCooldownMs = DEFAULT_GLOBAL_COOLDOWN_MS,
-        principleCooldownMs: _principleCooldownMs = DEFAULT_PRINCIPLE_COOLDOWN_MS,
         maxRunsPerWindow = DEFAULT_MAX_RUNS_PER_WINDOW,
         quotaWindowMs = DEFAULT_QUOTA_WINDOW_MS,
     } = options;

package/src/service/nocturnal-service.ts

@@ -116,7 +116,7 @@ function incrementGeneratedSampleCount(stateDir: string, principleId: string): v
     state.generatedSampleCount += 1;
     setPrincipleState(stateDir, state);
   } catch (err) {
-    // eslint-disable-next-line no-console -- Non-critical warning in helper function
+     
     console.warn(`[nocturnal-service] Failed to sync generatedSampleCount for ${principleId}:`, err instanceof Error ? err.stack : err);
   }
 }
@@ -522,7 +522,7 @@ function persistCodeCandidate(
     try {
       refreshPrincipleLifecycle(workspaceDir, stateDir);
     } catch (err) {
-      // eslint-disable-next-line no-console -- Non-critical warning in helper function
+       
       console.warn('[nocturnal-service] Lifecycle refresh failed after code candidate persistence:', err instanceof Error ? err.stack : err);
     }
     return {
@@ -702,7 +702,7 @@ export function executeNocturnalReflection(
 ): NocturnalRunResult {
   // Use provided logger or fallback to console
   const logger = options.logger;
-  // eslint-disable-next-line no-console -- Intentional console fallback when no logger provided
+   
   const warn = logger?.warn?.bind(logger) ?? console.warn.bind(console);
 
   const diagnostics: NocturnalRunDiagnostics = {
@@ -882,7 +882,7 @@ export function executeNocturnalReflection(
           diagnostics,
         };
       }
-      trinityArtifact = trinityResult.artifact!; // eslint-disable-line @typescript-eslint/no-non-null-assertion -- Reason: artifact is validated by validateTrinityDraft which returns valid: true when artifact exists
+      trinityArtifact = trinityResult.artifact!;  
       // Convert Trinity draft to arbiter-compatible artifact
       const artifactData = draftToArtifact(trinityArtifact);
       rawJson = JSON.stringify(artifactData);
@@ -933,7 +933,7 @@ export function executeNocturnalReflection(
             diagnostics,
           };
         }
-        trinityArtifact = trinityResult.artifact!; // eslint-disable-line @typescript-eslint/no-non-null-assertion -- Reason: artifact is validated by validateTrinityDraft which returns valid: true when artifact exists
+        trinityArtifact = trinityResult.artifact!;  
         // Convert Trinity draft to arbiter-compatible artifact
         const artifactData = draftToArtifact(trinityArtifact);
         rawJson = JSON.stringify(artifactData);
@@ -1187,7 +1187,7 @@ async function executeNocturnalReflectionWithAdapter(
 ): Promise<NocturnalRunResult> {
   // Use provided logger or fallback to console
   const logger = options.logger;
-  // eslint-disable-next-line no-console -- Intentional console fallback when no logger provided
+   
   const warn = logger?.warn?.bind(logger) ?? console.warn.bind(console);
 
   const diagnostics: NocturnalRunDiagnostics = {
@@ -1387,7 +1387,7 @@ async function executeNocturnalReflectionWithAdapter(
       adjustThresholdsFromSignals(stateDir, { malformedRate: 1.0, arbiterRejectRate: 0.0, executabilityRejectRate: 0.0, qualityDelta: 0.0 });
       return { success: false, noTargetSelected: false, validationFailed: true, validationFailures: [`Trinity override failed: ${failures.join('; ')}`], snapshot, diagnostics };
     }
-    trinityArtifact = trinityResult.artifact!; // eslint-disable-line @typescript-eslint/no-non-null-assertion -- Reason: artifact is validated by validateTrinityDraft which returns valid: true when artifact exists
+    trinityArtifact = trinityResult.artifact!;  
     const artifactData = draftToArtifact(trinityArtifact);
     rawJson = JSON.stringify(artifactData);
   } else {
@@ -1414,7 +1414,7 @@ async function executeNocturnalReflectionWithAdapter(
           adjustThresholdsFromSignals(stateDir, { malformedRate: 1.0, arbiterRejectRate: 0.0, executabilityRejectRate: 0.0, qualityDelta: 0.0 });
           return { success: false, noTargetSelected: false, validationFailed: true, validationFailures: failures, snapshot, diagnostics };
         }
-        trinityArtifact = trinityResult.artifact!; // eslint-disable-line @typescript-eslint/no-non-null-assertion -- Reason: artifact is validated by validateTrinityDraft which returns valid: true when artifact exists
+        trinityArtifact = trinityResult.artifact!;  
         const artifactData = draftToArtifact(trinityArtifact);
         rawJson = JSON.stringify(artifactData);
       } else {

package/src/service/nocturnal-target-selector.ts

@@ -288,7 +288,7 @@ export class NocturnalTargetSelector {
   };
 
    
-  // eslint-disable-next-line @typescript-eslint/max-params
+   
   constructor(
     workspaceDir: string,
     stateDir: string,
@@ -533,7 +533,7 @@ export class NocturnalTargetSelector {
  * This is a convenience wrapper for the common case.
  */
  
-// eslint-disable-next-line @typescript-eslint/max-params
+ 
 export function selectNocturnalTarget(
   workspaceDir: string,
   stateDir: string,

package/src/service/queue-io.ts

@@ -160,9 +160,9 @@ export function readRecentPainContext(wctx: WorkspaceContext): RecentPainContext
         }
     } catch (err) {
       // Best effort — non-fatal, but surface unexpected errors
-      /* eslint-disable no-console */
+       
       console.warn(`[queue-io] Failed to read pain context (non-fatal): ${String(err)}`);
-      /* eslint-enable no-console */
+       
     }
 
     return { mostRecent: null, recentPainCount: 0, recentMaxPainScore: 0 };
@@ -185,7 +185,7 @@ export function shouldSkipForDedup(
     const recentSimilarReflection = hasRecentSimilarReflection(queue, painSourceKey, now);
 
     if (recentSimilarReflection) {
-        const completedTime = new Date(recentSimilarReflection.completed_at!).getTime(); /* eslint-disable-line @typescript-eslint/no-non-null-assertion */
+        const completedTime = new Date(recentSimilarReflection.completed_at!).getTime();  
         logger?.debug?.(`[PD:EvolutionWorker] Skipping sleep_reflection — similar reflection completed ${Math.round((now - completedTime) / 60000)}min ago (same pain pattern: ${painSourceKey})`);
         return true;
     }
@@ -358,9 +358,9 @@ export function loadEvolutionQueue(queuePath: string): EvolutionQueueItem[] {
             rawQueue = [];
         } else {
             // Corrupted JSON or other read error — warn and recover with empty queue
-            /* eslint-disable no-console */
+             
             console.warn(`[queue-io] Failed to load evolution queue (recovering with empty): ${String(err)}`);
-            /* eslint-enable no-console */
+             
             rawQueue = [];
         }
     }

package/src/service/runtime-summary-service.ts

@@ -420,7 +420,7 @@ export class RuntimeSummaryService {
    * Queue is the only authoritative execution truth source.
    */
    
-  // eslint-disable-next-line @typescript-eslint/max-params
+   
   private static buildDirectiveSummary(
     queue: QueueItem[] | null,
     directive: DirectiveFile | null,

package/src/service/sleep-cycle.ts

@@ -71,7 +71,7 @@ export interface CycleOptions {
  * @param options.heartbeatCounterRef — mutable counter, incremented by runCycle
  */
 export async function runCycle(options: CycleOptions): Promise<WorkerStatusReport> {
-    const { wctx, logger, eventLog: _eventLog, api: _api, heartbeatCounterRef } = options;
+    const { wctx, logger, api: _api, heartbeatCounterRef } = options;
     const cycleStart = Date.now();
     heartbeatCounterRef.value++;
 

package/src/service/subagent-workflow/deep-reflect-workflow-manager.ts

@@ -130,7 +130,7 @@ export const deepReflectWorkflowSpec: SubagentWorkflowSpec<DeepReflectResult> =
             } else if (Array.isArray(lastMessage?.content)) {
                 insights = (lastMessage.content as { type?: string; text?: string }[])
                     .filter((c) => c?.type === 'text' && typeof c.text === 'string')
-                    // eslint-disable-next-line @typescript-eslint/no-non-null-assertion -- Reason: filter ensures c.text is a string
+                     
                     .map((c) => c.text!)
                     .join('\n');
             }

package/src/service/subagent-workflow/empathy-observer-workflow-manager.ts

@@ -1,3 +1,4 @@
+ 
 import type { PluginLogger } from '../../openclaw-sdk.js';
 import type {
     SubagentWorkflowSpec,

package/src/service/subagent-workflow/nocturnal-workflow-manager.ts

@@ -453,7 +453,7 @@ export class NocturnalWorkflowManager implements WorkflowManager {
 
     async sweepExpiredWorkflows(
         maxAgeMs = 30 * 60 * 1000,
-        // eslint-disable-next-line @typescript-eslint/no-explicit-any -- Reason: subagentRuntime param is intentionally any for backward compatibility with callers
+         
         subagentRuntime?: any,
          
         agentSession?: {

package/src/service/subagent-workflow/subagent-error-utils.ts

@@ -5,7 +5,7 @@
  *
  * Callers should suppress warnings for these errors — they are not real failures.
  */
-    // eslint-disable-next-line complexity -- complexity 13, refactor candidate
+     
 export function isExpectedSubagentError(err: unknown): boolean {
     const msg = String(err);
     return (

package/src/service/subagent-workflow/workflow-store.ts

@@ -1,3 +1,4 @@
+ 
 import Database from 'better-sqlite3';
 import * as fs from 'fs';
 import * as path from 'path';
@@ -233,7 +234,7 @@ export class WorkflowStore {
     }
     
      
-    // eslint-disable-next-line @typescript-eslint/max-params
+     
     recordEvent(
         workflowId: string,
         eventType: string,
@@ -270,7 +271,7 @@ export class WorkflowStore {
      * same idempotency_key already exists, this is a no-op (idempotent).
      */
      
-    // eslint-disable-next-line @typescript-eslint/max-params
+     
     recordStageOutput(
         workflowId: string,
         stage: 'dreamer' | 'philosopher',

package/src/service/workflow-watchdog.ts

@@ -30,7 +30,7 @@ export interface WatchdogResult {
   scanError?: string;
 }
 
-/* eslint-disable complexity */
+ 
 export async function runWorkflowWatchdog(
   wctx: WorkspaceContext,
   api: OpenClawPluginApi | null,

package/src/tools/critique-prompt.ts

@@ -17,7 +17,7 @@ const DEPTH_INSTRUCTIONS = {
  * 严格按照测试用例的调用习惯和断言要求进行重写。
  * 增加 OpenClaw 兼容性路径解析。
  */
-    // eslint-disable-next-line complexity -- complexity 12, refactor candidate
+     
 export function buildCritiquePromptV2(
     params: {
         context: string;

package/src/tools/model-index.ts

@@ -62,7 +62,7 @@ export function loadModelIndex(
         const customConfig = loadCustomConfig(wctx);
         
          
-        // eslint-disable-next-line @typescript-eslint/init-declarations
+         
         let modelsDir: string;
         if (customConfig?.modelsDir) {
             modelsDir = path.isAbsolute(customConfig.modelsDir) 

package/src/utils/file-lock.ts

@@ -352,7 +352,7 @@ export async function withAsyncLock<T>(
   try {
     return await fn();
   } finally {
-    // eslint-disable-next-line @typescript-eslint/no-non-null-assertion -- Reason: resolveRelease is assigned in Promise constructor before finally runs
+     
     resolveRelease!();
     // 清理已完成的队列
     if (asyncLockQueues.get(lockPath) === currentQueue) {

package/src/utils/io.ts

@@ -126,7 +126,7 @@ export function parseKvLines(text: string): Record<string, string> {
   return result;
 }
 
-// eslint-disable-next-line @typescript-eslint/no-explicit-any -- Reason: serializeKvLines handles arbitrary object shapes for kv line serialization
+ 
 export function serializeKvLines(data: Record<string, any>): string {
   const lines: string[] = [];
   const keys = Object.keys(data).sort();

package/src/utils/retry.ts

@@ -424,7 +424,7 @@ export function computeDynamicTimeout(
   if (history.length < MIN_SAMPLES) {
     // Not enough data — use the spec's static timeout
     const fallback = clampTimeout(defaultTimeout);
-    // eslint-disable-next-line no-console -- Monitoring output for fallback diagnostics
+     
     console.info(`[PD:DynamicTimeout] Insufficient samples (${history.length} < ${MIN_SAMPLES}) for '${workflowType}', falling back to static timeout: ${fallback}ms`);
     return fallback;
   }
@@ -432,7 +432,7 @@ export function computeDynamicTimeout(
   const p95 = percentile(history, 95);
   const adaptive = p95 * SAFETY_MULTIPLIER;
   const result = clampTimeout(adaptive);
-  // eslint-disable-next-line no-console -- Monitoring output for adaptive timeout diagnostics
+   
   console.info(`[PD:DynamicTimeout] Computed adaptive timeout for '${workflowType}': P95=${p95}ms (from ${history.length} samples) × ${SAFETY_MULTIPLIER} = ${result}ms`);
   return result;
 }