principles-disciple 1.42.0 → 1.44.0

package/src/core/promotion-gate.ts

@@ -323,8 +323,6 @@ export function evaluatePromotionGate(
 ): PromotionGateResult {
   const {
     checkpointId,
-     
-    targetProfile: _targetProfile,
     baselineMetrics,
     minDelta = DEFAULT_MIN_DELTA,
     allowedMargin = DEFAULT_ALLOWED_MARGIN,

package/src/core/replay-engine.ts

@@ -1,3 +1,4 @@
+ 
 import * as fs from 'fs';
 import * as path from 'path';
 import { withLock } from '../utils/file-lock.js';

package/src/core/risk-calculator.ts

@@ -1,3 +1,4 @@
+ 
 /* global NodeJS */
 import * as fs from 'fs';
 import { isRisky } from '../utils/io.js';
@@ -95,7 +96,7 @@ export function getTargetFileLineCount(absoluteFilePath: string): number | null
  * @returns Maximum allowed lines (at least minLines, at most maxLines if provided)
  */
  
-// eslint-disable-next-line @typescript-eslint/max-params
+ 
 export function calculatePercentageThreshold(
     targetLineCount: number,
     percentage: number,

package/src/core/rule-host.ts

@@ -71,7 +71,7 @@ export class RuleHost {
 
       // Merge decisions from all active implementations
        
-      // eslint-disable-next-line @typescript-eslint/init-declarations
+       
       let blocked: RuleHostResult | undefined;
       const approvals: RuleHostResult[] = [];
 

package/src/core/session-tracker.ts

@@ -1,3 +1,4 @@
+ 
 import * as path from 'path';
 import * as fs from 'fs';
 import { atomicWriteFileSync } from '../utils/io.js';

package/src/core/shadow-observation-registry.ts

@@ -534,4 +534,4 @@ export function cleanupExpiredObservations(
   });
 
   return removed;
-}
+}

package/src/core/thinking-models.ts

@@ -202,7 +202,7 @@ let _cachedWorkspace: string | null = null;
  *
  * @param workspaceDir Optional. If provided, loads from that workspace's THINKING_OS.md.
  */
-    // eslint-disable-next-line complexity -- complexity 14, refactor candidate
+     
 export function listThinkingModels(workspaceDir?: string): ThinkingModelDefinition[] {
   const cacheKey = workspaceDir ?? '__global__';
   if (_cachedDefinitions && _cachedWorkspace === cacheKey) {

package/src/core/thinking-os-parser.ts

@@ -45,7 +45,7 @@ export function parseThinkingOsMd(content: string): ThinkingOsDirective[] {
   // Match all <directive ...> ... </directive> blocks
   const directiveRegex = /<directive\s+([^>]*)>([\s\S]*?)<\/directive>/gi;
    
-  // eslint-disable-next-line no-useless-assignment
+   
   let _match: RegExpExecArray | null = null;
 
   while ((_match = directiveRegex.exec(content)) !== null) {

package/src/core/trajectory.ts

@@ -1,3 +1,5 @@
+ 
+ 
 import Database from 'better-sqlite3';
 import fs from 'fs';
 import path from 'path';
@@ -207,10 +209,6 @@ export class TrajectoryDatabase {
   recordToolCall(input: TrajectoryToolCallInput): number {
     this.recordSession({ sessionId: input.sessionId, startedAt: input.createdAt });
     const createdAt = input.createdAt ?? nowIso();
-    // Extract filePath from paramsJson if provided and is an object with filePath
-    const paramsObj = input.paramsJson as Record<string, unknown> | undefined;
-     
-    const _filePath = paramsObj && typeof paramsObj.filePath === 'string' ? paramsObj.filePath : null;
     const rowId = this.withWrite(() => {
       const result = this.db.prepare(`
         INSERT INTO tool_calls (

package/src/core/workspace-context.ts

@@ -173,7 +173,7 @@ export class WorkspaceContext {
      * Uses PathResolver to handle path normalization and fallback logic.
      * @throws Error if workspaceDir is missing and no fallback available.
      */
-    // eslint-disable-next-line @typescript-eslint/no-explicit-any -- Reason: OpenClaw plugin framework hook context has dynamic shape - type not available
+     
     static fromHookContext(ctx: any): WorkspaceContext {
         const {logger} = ctx;
         const log = (msg: string) => logger?.info?.(msg);

package/src/hooks/bash-risk.ts

@@ -39,7 +39,7 @@ export type BashRiskLevel = 'safe' | 'dangerous' | 'normal';
  * @returns The risk level: 'safe', 'dangerous', or 'normal'
  */
  
-// eslint-disable-next-line @typescript-eslint/max-params
+ 
 export function analyzeBashCommand(
   command: string,
   safePatterns: string[],
@@ -154,7 +154,7 @@ export interface DynamicThresholdConfig {
  * @param config - Configuration with large_change_lines and ep_tier_multipliers
  * @returns The adjusted threshold (minimum 0)
  */
-// eslint-disable-next-line @typescript-eslint/max-params
+ 
 export function calculateDynamicThreshold(
   baseThreshold: number,
   epTier: number,

package/src/hooks/edit-verification.ts

@@ -127,11 +127,11 @@ This is enforced by P-03 (精确匹配前验证原则).`;
  * This enforces P-03 at the tool layer
  */
  
-// eslint-disable-next-line @typescript-eslint/max-params
+ 
 export function handleEditVerification(
   event: PluginHookBeforeToolCallEvent,
   wctx: WorkspaceContext,
-  // eslint-disable-next-line @typescript-eslint/no-explicit-any -- Reason: logger is typed as any by plugin framework - type not available
+   
   ctx: { logger?: any; sessionId?: string },
   config: EditVerificationConfig = {}
 ): PluginHookBeforeToolCallResult | void {
@@ -157,7 +157,7 @@ export function handleEditVerification(
 
   // 2. Resolve and read file
    
-  // eslint-disable-next-line @typescript-eslint/init-declarations
+   
   let absolutePath: string;
   try {
     absolutePath = wctx.resolve(filePath);
@@ -225,7 +225,7 @@ export function handleEditVerification(
 
     // 3. Read current file content with improved error handling
      
-    // eslint-disable-next-line @typescript-eslint/init-declarations
+     
     let currentContent: string;
     try {
       currentContent = fs.readFileSync(absolutePath, 'utf-8');

package/src/hooks/gate.ts

@@ -135,7 +135,7 @@ export function handleBeforeToolCall(
 
     if (mutationMatch) {
        
-      // eslint-disable-next-line @typescript-eslint/prefer-destructuring
+       
       filePath = mutationMatch[1];
     } else {
       const hasRiskPath = profile.risk_paths.some(rp => command.includes(rp));
@@ -169,36 +169,36 @@ export function handleBeforeToolCall(
         toolName: event.toolName,
         normalizedPath: relPath,
          
-        // eslint-disable-next-line @typescript-eslint/no-use-before-define
+         
         paramsSummary: _extractParamsSummary(event.params),
       },
       workspace: {
         isRiskPath: risky,
          
-        // eslint-disable-next-line @typescript-eslint/no-use-before-define
+         
         planStatus: _getPlanStatus(ctx.workspaceDir),
          
-        // eslint-disable-next-line @typescript-eslint/no-use-before-define
+         
         hasPlanFile: _hasPlanFile(ctx.workspaceDir),
       },
       session: {
         sessionId: ctx.sessionId,
          
-        // eslint-disable-next-line @typescript-eslint/no-use-before-define
+         
         currentGfi: _getCurrentGfi(ctx.sessionId),
          
-        // eslint-disable-next-line @typescript-eslint/no-use-before-define
+         
         recentThinking: _hasRecentThinking(ctx.sessionId),
       },
       evolution: {
          
-        // eslint-disable-next-line @typescript-eslint/no-use-before-define
+         
         epTier: _getEpTier(wctx.workspaceDir),
       },
       derived: {
         estimatedLineChanges: estimateLineChanges({ toolName: event.toolName, params: event.params }),
          
-        // eslint-disable-next-line @typescript-eslint/no-use-before-define
+         
         bashRisk: _getBashRisk(event, profile),
       },
     };

package/src/hooks/gfi-gate.ts

@@ -48,7 +48,7 @@ export interface GfiGateConfig {
  * Internal helper to call the shared block helper with gfi-gate source tag.
  */
  
-// eslint-disable-next-line @typescript-eslint/max-params
+ 
 function block(
   wctx: WorkspaceContext,
   filePath: string,
@@ -70,7 +70,7 @@ function block(
 }
 
  
-// eslint-disable-next-line @typescript-eslint/max-params
+ 
 export function checkGfiGate(
   event: PluginHookBeforeToolCallEvent,
   wctx: WorkspaceContext,

package/src/hooks/lifecycle-routing.ts

@@ -66,7 +66,7 @@ export type LifecycleIntent = 'promote' | 'disable' | 'rollback' | null;
  * Detect implementation lifecycle intent from user message.
  * Returns the detected intent type or null.
  */
-    // eslint-disable-next-line complexity -- complexity 13, refactor candidate
+     
 export function detectLifecycleIntent(message: string): LifecycleIntent {
   // Check promote patterns
   for (const p of PROMOTE_PATTERNS_EN) {

package/src/hooks/pain.ts

@@ -131,7 +131,7 @@ export function handleAfterToolCall(
     
     // ── Trust Engine: Record failure ──
      
-    // eslint-disable-next-line @typescript-eslint/no-use-before-define
+     
     const errorType = extractErrorType(event.error || errorText);
     const filePath = params.file_path || params.path || params.file;
     const relPath = typeof filePath === 'string' ? normalizePath(filePath, effectiveWorkspaceDir) : 'unknown';
@@ -194,7 +194,7 @@ export function handleAfterToolCall(
     const session = getSession(sessionId);
     const toolFailureGfi = session?.gfiBySource?.tool_failure || 0;
     
-    // eslint-disable-next-line @typescript-eslint/init-declarations
+     
     let resetState: SessionState;
     if (toolFailureGfi > 0) {
       // Reduce tool_failure source by 50% (relief from successful tool execution)

package/src/hooks/progressive-trust-gate.ts

@@ -87,7 +87,7 @@ export function buildEvolutionGateReason(
  * Internal helper to call the shared block helper with progressive-trust-gate source tag.
  */
  
-// eslint-disable-next-line @typescript-eslint/max-params
+ 
 function block(
   filePath: string,
   reason: string,
@@ -121,7 +121,7 @@ function block(
  * @returns PluginHookBeforeToolCallResult to block, or undefined to allow
  */
  
-// eslint-disable-next-line @typescript-eslint/max-params
+ 
 export function checkProgressiveTrustGate(
   event: PluginHookBeforeToolCallEvent,
   wctx: WorkspaceContext,
@@ -154,7 +154,7 @@ export function checkProgressiveTrustGate(
 
   const currentTier = epDecision.currentTier ?? 1;
    
-  // eslint-disable-next-line @typescript-eslint/no-use-before-define
+   
   const tierName = getTierName(currentTier);
 
   logger.info?.(`[PD_GATE] EP Gate: Tier ${currentTier} (${tierName}), Tool: ${event.toolName}, Risk: ${risky}, Allowed: ${epDecision.allowed}`);

package/src/hooks/prompt.ts

@@ -1,3 +1,5 @@
+ 
+ 
 import * as fs from 'fs';
 import * as path from 'path';
 import type { PluginHookBeforePromptBuildEvent, PluginHookAgentContext, PluginHookBeforePromptBuildResult, PluginLogger, OpenClawPluginApi } from '../openclaw-sdk.js';
@@ -979,12 +981,8 @@ ${taskBlocks}${processingNote}
         const filePattern = /\b([a-zA-Z]:\\?[^\s,]+\.[a-z]{2,10}|[./][^\s,]+\.[a-z]{2,10})\b/gi;
         const toolMatches = toolPatterns.flatMap(({ pattern, tool }) => {
           const matches: string[] = [];
-           
-           
-          let _m;
           const r = new RegExp(pattern.source, pattern.flags);
-           
-          while ((_m = r.exec(latestUserText)) !== null) matches.push(tool);
+          while (r.exec(latestUserText) !== null) matches.push(tool);
           return matches;
         });
         const fileMatches = latestUserText.match(filePattern) ?? [];

package/src/hooks/thinking-checkpoint.ts

@@ -41,7 +41,7 @@ export interface ThinkingCheckpointConfig {
  * @returns Block result if thinking required, undefined otherwise
  */
  
-// eslint-disable-next-line @typescript-eslint/max-params
+ 
 export function checkThinkingCheckpoint(
   event: PluginHookBeforeToolCallEvent,
   config: ThinkingCheckpointConfig,

package/src/index.ts

@@ -283,7 +283,7 @@ const plugin = {
 
           if (shouldRecordShadow) {
             const observation = recordShadowRouting(workspaceDir, {
-              checkpointId: decision.activeCheckpointId!, // eslint-disable-line @typescript-eslint/no-non-null-assertion -- Reason: !!decision.activeCheckpointId guard above ensures truthiness
+              checkpointId: decision.activeCheckpointId!,  
               workerProfile: agentId as WorkerProfile,
               taskFingerprint: computeRuntimeShadowTaskFingerprint(event),
             });
@@ -362,7 +362,7 @@ const plugin = {
 
     // ── Slash Commands ──
     // Register command with optional short alias
-    // eslint-disable-next-line @typescript-eslint/no-explicit-any
+     
     const registerCommandWithAlias = (name: string, alias: string | null, desc: string, handler: any, opts?: { acceptsArgs?: boolean }) => {
       const base = {
         name,
@@ -380,17 +380,17 @@ const plugin = {
       }
     };
 
-    // eslint-disable-next-line @typescript-eslint/no-explicit-any
+     
     registerCommandWithAlias('pd-init', 'pdi', getCommandDescription('pd-init', language), (ctx: any) => handleInitStrategy(ctx));
-    // eslint-disable-next-line @typescript-eslint/no-explicit-any
+     
     registerCommandWithAlias('pd-okr', 'pdk', getCommandDescription('pd-okr', language), (ctx: any) => handleManageOkr(ctx));
-    // eslint-disable-next-line @typescript-eslint/no-explicit-any
+     
     registerCommandWithAlias('pd-bootstrap', 'pdb', getCommandDescription('pd-bootstrap', language), (ctx: any) => handleBootstrapTools(ctx));
-    // eslint-disable-next-line @typescript-eslint/no-explicit-any
+     
     registerCommandWithAlias('pd-research', 'pdr', getCommandDescription('pd-research', language), (ctx: any) => handleResearchTools(ctx));
-    // eslint-disable-next-line @typescript-eslint/no-explicit-any
+     
     registerCommandWithAlias('pd-thinking', 'pdt', getCommandDescription('pd-thinking', language), (ctx: any) => handleThinkingOs(ctx), { acceptsArgs: true });
-    // eslint-disable-next-line @typescript-eslint/no-explicit-any
+     
     registerCommandWithAlias('pd-reflect', 'pdrl', getCommandDescription('pd-reflect', language), (ctx: any) => {
       try {
         // Resolve agentId from sessionKey (if available), fallback to 'main'

package/src/service/central-database.ts

@@ -1,3 +1,4 @@
+ 
 import Database from 'better-sqlite3';
 import fs from 'fs';
 import path from 'path';
@@ -200,7 +201,7 @@ export class CentralDatabase {
   /**
    * Sync data from a single workspace into the central database
    */
-    // eslint-disable-next-line complexity -- complexity 12, refactor candidate
+     
   syncWorkspace(workspaceName: string): number {
     const workspace = this.workspaces.find(w => w.name === workspaceName);
     if (!workspace) {
@@ -714,7 +715,7 @@ export class CentralDatabase {
       syncEnabled: c.sync_enabled === 1,
     }));
   }
-    // eslint-disable-next-line complexity -- complexity 12, refactor candidate
+     
 
   updateWorkspaceConfig(
     workspaceName: string,

package/src/service/central-health-service.ts

@@ -1,3 +1,4 @@
+ 
 import { getCentralDatabase } from './central-database.js';
 import { HealthQueryService } from './health-query-service.js';
 
@@ -18,7 +19,7 @@ export interface CentralHealthResponse {
  */
 export class CentralHealthService {
    
-  // eslint-disable-next-line @typescript-eslint/class-methods-use-this
+   
   getAllWorkspaceHealth(): CentralHealthResponse {
     const centralDb = getCentralDatabase();
     const workspaces: WorkspaceHealthEntry[] = [];

package/src/service/central-overview-service.ts

@@ -1,3 +1,4 @@
+ 
 import { getCentralDatabase, type CentralDatabase } from './central-database.js';
 import { getThinkingModelDefinitions } from '../core/thinking-models.js';
 import type { OverviewResponse } from './control-ui-query-service.js';
@@ -24,7 +25,7 @@ export class CentralOverviewService {
   }
 
    
-  // eslint-disable-next-line @typescript-eslint/class-methods-use-this
+   
   dispose(): void {
     // Do NOT dispose centralDb — it's a singleton shared across all requests.
     // Individual services that open per-request connections (e.g. HealthQueryService)
@@ -62,7 +63,7 @@ export class CentralOverviewService {
 
     // D-06: sampleQueue.counters from aggregated_correction_samples GROUP BY review_status
      
-    // eslint-disable-next-line no-useless-assignment
+     
     let sampleCounters: Record<string, number> = {};
     try {
       sampleCounters = this.centralDb.getSampleCountersByStatus();

package/src/service/control-ui-query-service.ts

@@ -255,7 +255,7 @@ export class ControlUiQueryService {
     this.uiDb.dispose();
   }
 
-    // eslint-disable-next-line complexity -- complexity 14, refactor candidate
+     
   getOverview(days = 30): OverviewResponse {
     const stats = this.trajectory.getDataStats();
     const regressionRows = this.uiDb.all<{
@@ -400,7 +400,7 @@ export class ControlUiQueryService {
     };
   }
 
-    // eslint-disable-next-line complexity -- complexity 13, refactor candidate
+     
   listSamples(filters: SampleListFilters = {}): SamplesResponse {
     const page = Math.max(1, Number(filters.page ?? 1));
     const pageSize = clampPageSize(filters.pageSize);

package/src/service/event-log-auditor.ts

@@ -137,7 +137,7 @@ function countAllHooks(filePath: string): Record<string, number> {
  * @param openclawDir - Base OpenClaw directory (e.g., ~/.openclaw)
  * @param expectedToolHooks - Hook names that should appear in the primary workspace
  */
-    // eslint-disable-next-line complexity -- complexity 11, slightly over threshold
+     
 export async function auditEventLogs(
   openclawDir: string,
   expectedToolHooks: string[] = ['before_tool_call', 'after_tool_call'],
@@ -210,7 +210,7 @@ export async function auditEventLogs(
 /**
  * Format audit report for display.
  */
-    // eslint-disable-next-line complexity -- complexity 13, refactor candidate
+     
 export function formatAuditReport(report: AuditReport): string {
   const lines: string[] = [];
   

package/src/service/evolution-query-service.ts

@@ -155,7 +155,7 @@ export class EvolutionQueryService {
    * 注意：不关闭 trajectory，因为它是单例由 TrajectoryRegistry 管理
    */
    
-  // eslint-disable-next-line @typescript-eslint/class-methods-use-this
+   
   dispose(): void {
     // EvolutionQueryService 不拥有 trajectory，所以不关闭它
     // trajectory 是由 TrajectoryRegistry 管理的单例
@@ -349,13 +349,13 @@ export class EvolutionQueryService {
     for (const task of recentTasks) {
       const [createdDay] = task.createdAt.split('T');
       if (activityByDay.has(createdDay)) {
-        // eslint-disable-next-line @typescript-eslint/no-non-null-assertion -- Reason: has() check guarantees entry exists
+         
         activityByDay.get(createdDay)!.created++;
       }
       if (task.completedAt) {
         const [completedDay] = task.completedAt.split('T');
         if (activityByDay.has(completedDay)) {
-          // eslint-disable-next-line @typescript-eslint/no-non-null-assertion -- Reason: has() check guarantees entry exists
+           
           activityByDay.get(completedDay)!.completed++;
         }
       }

package/src/service/evolution-worker.ts

@@ -1,3 +1,5 @@
+ 
+ 
 /* global NodeJS */
  
 import * as fs from 'fs';
@@ -231,8 +233,6 @@ function buildFallbackNocturnalSnapshot(
     };
 }
 
-const PAIN_QUEUE_DEDUP_WINDOW_MS = 30 * 60 * 1000;
-
 // Queue lock constants and requireQueueLock are imported from queue-io.ts
 
 export function extractEvolutionTaskId(task: string): string | null {
@@ -282,13 +282,6 @@ export function purgeStaleFailedTasks(
     return { purged: purged.length, remaining: queue.length, byReason };
 }
 
-function normalizePainDedupKey(source: string, preview: string, reason?: string): string {
-    // Include reason in dedup key to match createEvolutionTaskId() behavior
-    // Different reasons for the same source/preview should create different tasks
-    const normalizedReason = (reason || '').trim().toLowerCase();
-    return `${source.trim().toLowerCase()}::${preview.trim().toLowerCase()}::${normalizedReason}`;
-}
-
  
  
 export function hasRecentDuplicateTask(queue: EvolutionQueueItem[], source: string, preview: string, now: number, reason?: string): boolean {
@@ -665,7 +658,7 @@ async function processEvolutionQueue(wctx: WorkspaceContext, logger: PluginLogge
                             workspaceDir: wctx.workspaceDir,
                             stateDir: wctx.stateDir,
                             logger: api?.logger || logger,
-                            // eslint-disable-next-line @typescript-eslint/no-non-null-assertion -- Reason: api is guaranteed non-null in this recovery path where runtimeAdapter is required
+                             
                             runtimeAdapter: new OpenClawTrinityRuntimeAdapter(api!),
                             subagent: api?.runtime?.subagent,
                         });
@@ -1183,7 +1176,7 @@ async function processEvolutionQueue(wctx: WorkspaceContext, logger: PluginLogge
                     let snapshotData: NocturnalSessionSnapshot | undefined;
 
                     if (isPollingTask) {
-                        // eslint-disable-next-line @typescript-eslint/no-non-null-assertion -- Reason: polling path requires existing resultRef
+                         
                         workflowId = sleepTask.resultRef!;
                     } else {
                         // Phase 1: Build trajectory snapshot for Nocturnal pipeline
@@ -1335,15 +1328,15 @@ async function processEvolutionQueue(wctx: WorkspaceContext, logger: PluginLogge
                              
                             try {
                                 payload = lastEvent?.payload ?? {};
-                                // eslint-disable-next-line @typescript-eslint/no-explicit-any
+                                 
                                 if ((payload as any).skipReason) {
-                                    // eslint-disable-next-line @typescript-eslint/no-explicit-any
+                                     
                                     detailedError += ` (skipReason: ${(payload as any).skipReason})`;
                                  
                                 }
-                                // eslint-disable-next-line @typescript-eslint/no-explicit-any
+                                 
                                 if ((payload as any).failures && Array.isArray((payload as any).failures) && (payload as any).failures.length > 0) {
-                                    // eslint-disable-next-line @typescript-eslint/no-explicit-any
+                                     
                                     detailedError += ` | failures: ${((payload as any).failures as string[]).slice(0, 3).join(', ')}`;
                                 }
                             } catch { /* ignore parse errors */ }
@@ -1359,7 +1352,7 @@ async function processEvolutionQueue(wctx: WorkspaceContext, logger: PluginLogge
                                 sleepOutcomes.push({ taskKind: 'sleep_reflection', succeeded: true });
 
                                 logger?.warn?.(`[PD:EvolutionWorker] sleep_reflection task ${sleepTask.id} background runtime unavailable, using stub fallback: ${errorReason}`);
-                            // eslint-disable-next-line @typescript-eslint/no-explicit-any
+                             
                             } else if ((payload as any).skipReason === 'no_violating_sessions') {
                                 // #244: No meaningful violations found (thin filter) → skip without failure
                                 sleepTask.status = 'completed';
@@ -1554,7 +1547,7 @@ async function processEvolutionQueue(wctx: WorkspaceContext, logger: PluginLogge
                     const manager = new CorrectionObserverWorkflowManager({
                         workspaceDir: wctx.workspaceDir,
                         logger,
-                        subagent: api?.runtime?.subagent!, /* eslint-disable-line @typescript-eslint/no-non-null-assertion */
+                        subagent: api?.runtime?.subagent!,  
                         agentSession: api?.runtime?.agent?.session,
                     });
 
@@ -1568,7 +1561,7 @@ async function processEvolutionQueue(wctx: WorkspaceContext, logger: PluginLogge
                         workflowId = handle.workflowId;
                         koTask.resultRef = workflowId;
                     } else {
-                        workflowId = koTask.resultRef!; /* eslint-disable-line @typescript-eslint/no-non-null-assertion */
+                        workflowId = koTask.resultRef!;  
                     }
 
                     // Poll workflow state