principles-disciple 1.34.1 → 1.35.0

package/src/core/nocturnal-trinity.ts

@@ -584,7 +584,7 @@ export class OpenClawTrinityRuntimeAdapter implements TrinityRuntimeAdapter {
     this.cleanupStaleTempDirs();
   }
 
-  // eslint-disable-next-line @typescript-eslint/class-methods-use-this
+   
   isRuntimeAvailable(): boolean {
     return true;
   }
@@ -682,7 +682,7 @@ export class OpenClawTrinityRuntimeAdapter implements TrinityRuntimeAdapter {
   /**
    * Extract text from runEmbeddedPiAgent result.
    */
-  // eslint-disable-next-line @typescript-eslint/class-methods-use-this
+   
   private extractPayloadText(result: { payloads?: { isError?: boolean; text?: string }[] }): string {
     return (result.payloads ?? [])
       .filter(p => !p.isError)
@@ -692,13 +692,13 @@ export class OpenClawTrinityRuntimeAdapter implements TrinityRuntimeAdapter {
   }
 
   /** Clamp a value to [0, 1] range — used for LLM-produced scores that may be out of range */
-  // eslint-disable-next-line @typescript-eslint/class-methods-use-this
+   
   private clamp01(val: unknown, fallback = 0): number {
     if (typeof val !== 'number' || !Number.isFinite(val)) return fallback;
     return Math.min(1, Math.max(0, val));
   }
 
-  // eslint-disable-next-line @typescript-eslint/class-methods-use-this
+   
   private classifyRuntimeError(error: unknown): TrinityRuntimeFailureCode {
     const detail = error instanceof Error ? error.message : String(error);
     return /timeout/i.test(detail) ? 'runtime_timeout' : 'runtime_run_failed';
@@ -797,7 +797,7 @@ export class OpenClawTrinityRuntimeAdapter implements TrinityRuntimeAdapter {
   }
 
 
-  // eslint-disable-next-line @typescript-eslint/max-params
+   
   async invokeScribe(
     dreamerOutput: DreamerOutput,
     philosopherOutput: PhilosopherOutput,
@@ -865,7 +865,7 @@ export class OpenClawTrinityRuntimeAdapter implements TrinityRuntimeAdapter {
   // ---------------------------------------------------------------------------
 
    
-  // eslint-disable-next-line @typescript-eslint/class-methods-use-this
+   
   private buildDreamerPrompt(
     snapshot: NocturnalSessionSnapshot,
     principleId: string,
@@ -962,7 +962,7 @@ export class OpenClawTrinityRuntimeAdapter implements TrinityRuntimeAdapter {
   }
 
    
-  // eslint-disable-next-line @typescript-eslint/class-methods-use-this
+   
   private buildPhilosopherPrompt(
     dreamerOutput: DreamerOutput,
     principleId: string,
@@ -1048,7 +1048,7 @@ export class OpenClawTrinityRuntimeAdapter implements TrinityRuntimeAdapter {
  
 
    
-  // eslint-disable-next-line @typescript-eslint/max-params, @typescript-eslint/class-methods-use-this
+   
   private buildScribePrompt(
     dreamerOutput: DreamerOutput,
     philosopherOutput: PhilosopherOutput,
@@ -1262,7 +1262,7 @@ export class OpenClawTrinityRuntimeAdapter implements TrinityRuntimeAdapter {
               implementationComplexity: (risks.implementationComplexity as string) ?? 'medium',
               breakingChangeRisk: Boolean(risks.breakingChangeRisk),
             };
-            // eslint-disable-next-line @typescript-eslint/no-unnecessary-type-assertion
+             
             if (hasFp) risksObj.falsePositiveEstimate = this.clamp01(fp as number);
             return { risks: risksObj };
           })() : {}),
@@ -1306,7 +1306,7 @@ export class OpenClawTrinityRuntimeAdapter implements TrinityRuntimeAdapter {
   }
 
    
-  // eslint-disable-next-line @typescript-eslint/max-params
+   
   private parseScribeOutput(
     text: string,
     snapshot: NocturnalSessionSnapshot,
@@ -1375,7 +1375,7 @@ export class OpenClawTrinityRuntimeAdapter implements TrinityRuntimeAdapter {
    * Extract JSON object from text that may contain markdown code blocks.
    */
    
-  // eslint-disable-next-line @typescript-eslint/class-methods-use-this
+   
   private extractJson(text: string): string | null {
     // Try direct parse first
     try {
@@ -1470,89 +1470,25 @@ export interface TrinityConfig {
 // Trinity Intermediate Contracts
 // ---------------------------------------------------------------------------
 
-/**
- * Dreamer output — multiple candidate corrections.
- * Each candidate represents an alternative "better decision" approach.
- */
-export interface DreamerCandidate {
-  /** Unique index for this candidate within the Dreamer output */
-  candidateIndex: number;
-  /** The bad decision this candidate addresses */
-  badDecision: string;
-  /** The alternative/better decision */
-  betterDecision: string;
-  /** Why this alternative is better (brief) */
-  rationale: string;
-  /** Confidence that this candidate is valid (0-1) */
-  confidence: number;
-  /** Risk level of this candidate's approach -- LLM-judged per D-02 */
-  riskLevel?: "low" | "medium" | "high";
-  /** Which strategic perspective this candidate embodies per D-01 */
-  strategicPerspective?: "conservative_fix" | "structural_improvement" | "paradigm_shift";
-}
-
-export interface DreamerOutput {
-  /** Whether Dreamer succeeded */
-  valid: boolean;
-  /** List of candidate corrections */
-  candidates: DreamerCandidate[];
-  /** Why Dreamer could not generate (if valid === false) */
-  reason?: string;
-  /** Timestamp of generation */
-  generatedAt: string;
-}
-
-/**
- * Philosopher output — principle-grounded critique and ranking.
- * Philosopher evaluates Dreamer's candidates and ranks them.
- */
-export interface PhilosopherRiskAssessment {
-  /** Estimated probability that this candidate is a false positive (0-1) */
-  falsePositiveEstimate: number;
-  /** How complex is this candidate to implement */
-  implementationComplexity: 'low' | 'medium' | 'high';
-  /** Whether implementing this candidate risks breaking existing functionality */
-  breakingChangeRisk: boolean;
-}
-
-export interface Philosopher6DScores {
-  principleAlignment: number;
-  specificity: number;
-  actionability: number;
-  executability: number;
-  safetyImpact: number;
-  uxImpact: number;
-}
-
-export interface PhilosopherJudgment {
-  /** Index of the judged candidate (references DreamerCandidate.candidateIndex) */
-  candidateIndex: number;
-  /** Principle-grounded critique of this candidate */
-  critique: string;
-  /** Whether this candidate aligns with the target principle */
-  principleAligned: boolean;
-  /** Ranking score (higher = better, 0-1) */
-  score: number;
-  /** Rank among all candidates (1 = best) */
-  rank: number;
-  /** Per-dimension scores (6D evaluation) — informational, not used for tournament ranking */
-  scores?: Philosopher6DScores;
-  /** Risk assessment for this candidate — informational, consumed by Scribe (Phase 37) */
-  risks?: PhilosopherRiskAssessment;
-}
-
-export interface PhilosopherOutput {
-  /** Whether Philosopher succeeded */
-  valid: boolean;
-  /** Judgments for each candidate */
-  judgments: PhilosopherJudgment[];
-  /** Overall assessment of the candidate set */
-  overallAssessment: string;
-  /** Why Philosopher could not judge (if valid === false) */
-  reason?: string;
-  /** Timestamp of generation */
-  generatedAt: string;
-}
+// Forward-exports from shared types module — single source of truth
+export type {
+  DreamerCandidate,
+  DreamerOutput,
+  PhilosopherRiskAssessment,
+  Philosopher6DScores,
+  PhilosopherJudgment,
+  PhilosopherOutput,
+} from './nocturnal-trinity-types.js';
+
+// Import all types for local use in this file
+import type {
+  DreamerCandidate,
+  DreamerOutput,
+  PhilosopherRiskAssessment,
+  Philosopher6DScores,
+  PhilosopherJudgment,
+  PhilosopherOutput,
+} from './nocturnal-trinity-types.js';
 
 /**
  * Analysis of a rejected candidate — why it lost the tournament.
@@ -1912,9 +1848,9 @@ export function invokeStubPhilosopher(
 
     // Deterministic 6D scores based on strategic perspective (Phase 35 D-07 mapping)
     const perspective = candidate.strategicPerspective;
-    // eslint-disable-next-line @typescript-eslint/init-declarations
+     
     let sixDScores: Philosopher6DScores;
-    // eslint-disable-next-line @typescript-eslint/init-declarations
+     
     let riskAssessment: PhilosopherRiskAssessment;
 
     if (perspective === 'conservative_fix') {
@@ -2014,7 +1950,7 @@ export function invokeStubPhilosopher(
  * The stub uses tournament selection (scoring + thresholds) to pick the winner.
  */
  
-// eslint-disable-next-line @typescript-eslint/max-params
+ 
 export function invokeStubScribe(
   dreamerOutput: DreamerOutput,
   philosopherOutput: PhilosopherOutput,
@@ -2093,7 +2029,7 @@ export function runTrinity(options: RunTrinityOptions): TrinityResult {
   // Stub path: use synchronous stub implementations
   if (config.useStubs) {
      
-    // eslint-disable-next-line @typescript-eslint/no-use-before-define
+     
     return runTrinityWithStubs(snapshot, principleId, config);
   }
 
@@ -2133,7 +2069,7 @@ export async function runTrinityAsync(options: RunTrinityOptions): Promise<Trini
   if (config.useStubs) {
     // Stub path: use synchronous stubs
      
-    // eslint-disable-next-line @typescript-eslint/no-use-before-define
+     
     return runTrinityWithStubs(snapshot, principleId, config);
   }
 

package/src/core/session-tracker.ts

@@ -2,6 +2,7 @@ import * as path from 'path';
 import * as fs from 'fs';
 import type { PainConfig } from './config.js';
 import { SystemLogger } from './system-logger.js';
+import { TWO_HOURS_MS } from '../config/defaults/runtime.js';
 
 export interface TokenUsage {
     input?: number;
@@ -84,7 +85,7 @@ export function initPersistence(stateDir: string): void {
     
     // Load all existing sessions
      
-    // eslint-disable-next-line @typescript-eslint/no-use-before-define
+     
     loadAllSessions();
 }
 
@@ -107,7 +108,7 @@ function loadAllSessions(): void {
     try {
         const files = fs.readdirSync(persistDir).filter(f => f.endsWith('.json'));
         const now = Date.now();
-        const twoHoursAgo = now - 2 * 60 * 60 * 1000;
+        const twoHoursAgo = now - TWO_HOURS_MS;
         
         for (const file of files) {
             try {
@@ -182,7 +183,7 @@ export function flushAllSessions(): void {
 }
 
  
-// eslint-disable-next-line @typescript-eslint/max-params
+ 
 function getOrCreateSession(sessionId: string, workspaceDir?: string, sessionKey?: string, trigger?: string): SessionState {
     let state = sessions.get(sessionId);
     if (!state) {
@@ -245,7 +246,7 @@ export function trackToolRead(sessionId: string, filePath: string, workspaceDir?
 }
 
  
-    // eslint-disable-next-line @typescript-eslint/max-params -- complexity 12, refactor candidate
+     
 export function trackLlmOutput(sessionId: string, usage: TokenUsage | undefined, config?: PainConfig, workspaceDir?: string, sessionKey?: string, trigger?: string): SessionState {
     const state = getOrCreateSession(sessionId, workspaceDir, sessionKey, trigger);
     state.llmTurns += 1;
@@ -285,7 +286,7 @@ export function trackLlmOutput(sessionId: string, usage: TokenUsage | undefined,
  * Tracks physical friction based on tool execution failures.
  */
  
-    // eslint-disable-next-line @typescript-eslint/max-params -- complexity 11, slightly over threshold
+     
 export function trackFriction(
     sessionId: string,
     deltaF: number,
@@ -552,7 +553,7 @@ export function decayGfi(sessionId: string, elapsedMinutes: number): SessionStat
     if (!state || state.currentGfi <= 0 || elapsedMinutes <= 0) return undefined;
     
     // Determine decay rate based on current GFI level (segmented)
-    // eslint-disable-next-line @typescript-eslint/init-declarations
+     
     let decayRate: number;
     if (state.currentGfi >= 70) {
       decayRate = 0.03;  // 3%/min for severe friction

package/src/core/system-logger.ts

@@ -1,35 +1,127 @@
 import * as fs from 'fs';
 import * as path from 'path';
-import { resolvePdPath } from './paths.js';
+import { resolvePdPath, PD_FILES } from './paths.js';
 
 /**
  * System Logger for Principles Disciple
- * Writes critical evolutionary events to the project's memory/logs/SYSTEM.log
+ *
+ * Writes critical evolutionary events to date-stamped log files:
+ *   memory/logs/SYSTEM_YYYY-MM-DD.log
+ *
  * Uses asynchronous writing to avoid blocking the Node.js event loop.
+ * Automatically rotates to a new file at midnight.
+ * Old log files are automatically cleaned up based on retention policy.
  */
+
+// Cache for current log file path, invalidated when date changes
+let cachedLogFile: string | undefined;
+let cachedLogDate: string | undefined;
+
+/**
+ * Log retention: delete SYSTEM logs older than this many days.
+ * Set to 0 to disable cleanup.
+ */
+const LOG_RETENTION_DAYS = 7;
+
+/**
+ * Get the system log file path for a given date.
+ * Format: memory/logs/SYSTEM_YYYY-MM-DD.log
+ */
+function getSystemLogPath(workspaceDir: string, date: Date): string {
+    const dateStr = date.toISOString().slice(0, 10); // YYYY-MM-DD
+    const logDir = path.dirname(resolvePdPath(workspaceDir, 'SYSTEM_LOG'));
+    const baseName = path.basename(PD_FILES.SYSTEM_LOG, '.log');
+    return path.join(logDir, `${baseName}_${dateStr}.log`);
+}
+
+/**
+ * Get today's date string (YYYY-MM-DD).
+ */
+function getTodayStr(): string {
+    return new Date().toISOString().slice(0, 10);
+}
+
+/**
+ * Clean up old SYSTEM log files, keeping only LOG_RETENTION_DAYS.
+ * Called automatically on first log write of each day.
+ */
+function cleanupOldLogs(workspaceDir: string): void {
+    if (LOG_RETENTION_DAYS <= 0) return;
+
+    try {
+        const logDir = path.dirname(resolvePdPath(workspaceDir, 'SYSTEM_LOG'));
+        const baseName = path.basename(PD_FILES.SYSTEM_LOG, '.log');
+        const prefix = `${baseName}_`;
+
+        if (!fs.existsSync(logDir)) return;
+
+        const cutoffMs = Date.now() - LOG_RETENTION_DAYS * 24 * 60 * 60 * 1000;
+        const files = fs.readdirSync(logDir);
+
+        for (const file of files) {
+            if (!file.startsWith(prefix) || !file.endsWith('.log')) continue;
+
+            const filePath = path.join(logDir, file);
+            const stat = fs.statSync(filePath);
+            if (stat.mtimeMs < cutoffMs) {
+                fs.unlinkSync(filePath);
+            }
+        }
+    } catch {
+        // Silently fail cleanup - don't crash logging for cleanup failures
+    }
+}
+
+// Track if cleanup has run today
+let lastCleanupDate: string | undefined;
+
 export const SystemLogger = {
     log(workspaceDir: string | undefined, eventType: string, message: string): void {
         if (!workspaceDir) return;
-        
+
         try {
-            const logFile = resolvePdPath(workspaceDir, 'SYSTEM_LOG');
-            const logDir = path.dirname(logFile);
-            
-            if (!fs.existsSync(logDir)) {
-                fs.mkdirSync(logDir, { recursive: true });
+            const today = getTodayStr();
+
+            // Check if date changed - invalidate cache and run cleanup
+            if (cachedLogDate !== today) {
+                cachedLogDate = today;
+                cachedLogFile = undefined;
+                // Run cleanup once per day when date changes
+                if (lastCleanupDate !== today) {
+                    lastCleanupDate = today;
+                    cleanupOldLogs(workspaceDir);
+                }
+            }
+
+            // Get or create log file path
+            if (!cachedLogFile) {
+                cachedLogFile = getSystemLogPath(workspaceDir, new Date());
+                const logDir = path.dirname(cachedLogFile);
+                if (!fs.existsSync(logDir)) {
+                    fs.mkdirSync(logDir, { recursive: true });
+                }
             }
-            
+
             const timestamp = new Date().toISOString();
-            
+
             // Format: [YYYY-MM-DDTHH:mm:ss.sssZ] [EVENT_TYPE] Message
             const logEntry = `[${timestamp}] [${eventType.padEnd(15)}] ${message}\n`;
-            
+
             // Use fire-and-forget async append to prevent blocking
-            fs.appendFile(logFile, logEntry, 'utf8', (_err) => {  
+            fs.appendFile(cachedLogFile, logEntry, 'utf8', (_err) => {
                 // Silently drop errors (e.g. disk full) to not crash the gateway
             });
         } catch (e) { // eslint-disable-line @typescript-eslint/no-unused-vars -- Reason: intentionally unused - silently fail if we can't setup the log
             // Silently fail if we can't setup the log
         }
+    },
+
+    /**
+     * Force refresh of the cached log file path.
+     * Call this at midnight or when the date changes to ensure proper rotation.
+     */
+    refreshCache(): void {
+        cachedLogDate = undefined;
+        cachedLogFile = undefined;
     }
 };

package/src/core/workspace-dir-service.ts

@@ -1,10 +1,5 @@
 import type { OpenClawPluginApi, PluginLogger } from '../openclaw-sdk.js';
-import { validateWorkspaceDir } from './workspace-dir-validation.js';
-
-export interface WorkspaceResolutionContext {
-  workspaceDir?: string;
-  agentId?: string;
-}
+import { validateWorkspaceDir, type WorkspaceResolutionContext } from './workspace-dir-validation.js';
 
 export interface WorkspaceResolutionOptions {
   source?: string;
@@ -83,3 +78,42 @@ export function resolveRequiredWorkspaceDir(
 ): string {
   return resolveWorkspaceDir(api, ctx, { ...options, required: true }) as string;
 }
+
+// Re-export helpers that live in workspace-dir-validation.ts for API compatibility
+export { validateWorkspaceDir } from './workspace-dir-validation.js';
+export type { WorkspaceResolutionContext } from './workspace-dir-validation.js';
+
+export function resolveValidWorkspaceDir(
+  ctx: WorkspaceResolutionContext,
+  api: {
+    runtime: { agent: { resolveAgentWorkspaceDir: (config: unknown, agentId: string) => string } };
+    config: unknown;
+    logger: PluginLogger;
+  },
+  options?: { source?: string; fallbackAgentId?: string },
+): string | undefined {
+  return resolveWorkspaceDir(api as never, ctx, {
+    source: options?.source,
+    fallbackAgentId: options?.fallbackAgentId,
+    logger: api.logger,
+  });
+}
+
+export function logWorkspaceDirHealth(
+  ctx: WorkspaceResolutionContext,
+  source: string,
+  api: {
+    runtime: { agent: { resolveAgentWorkspaceDir: (config: unknown, agentId: string) => string } };
+    config: unknown;
+    logger: PluginLogger;
+  },
+): void {
+  const resolved = resolveValidWorkspaceDir(ctx, api, { source, fallbackAgentId: 'main' });
+  const issue = validateWorkspaceDir(resolved);
+
+  if (issue) {
+    api.logger.error(`[PD:health] ${source}: workspaceDir="${resolved}" - ${issue}`);
+  } else {
+    api.logger.info(`[PD:health] ${source}: workspaceDir="${resolved}" OK`);
+  }
+}

package/src/core/workspace-dir-validation.ts

@@ -6,8 +6,11 @@
  */
 
 import * as os from 'os';
-import type { PluginLogger } from '../openclaw-sdk.js';
-import { resolveWorkspaceDir, type WorkspaceResolutionContext } from './workspace-dir-service.js';
+
+export interface WorkspaceResolutionContext {
+  workspaceDir?: string;
+  agentId?: string;
+}
 
 export function validateWorkspaceDir(dir: string | undefined): string | null {
   if (!dir) {
@@ -38,38 +41,3 @@ export function validateWorkspaceDir(dir: string | undefined): string | null {
 
   return null;
 }
-
-export function resolveValidWorkspaceDir(
-  ctx: WorkspaceResolutionContext,
-  api: {
-    runtime: { agent: { resolveAgentWorkspaceDir: (config: unknown, agentId: string) => string } };
-    config: unknown;
-    logger: PluginLogger;
-  },
-  options?: { source?: string; fallbackAgentId?: string },
-): string | undefined {
-  return resolveWorkspaceDir(api as never, ctx, {
-    source: options?.source,
-    fallbackAgentId: options?.fallbackAgentId,
-    logger: api.logger,
-  });
-}
-
-export function logWorkspaceDirHealth(
-  ctx: WorkspaceResolutionContext,
-  source: string,
-  api: {
-    runtime: { agent: { resolveAgentWorkspaceDir: (config: unknown, agentId: string) => string } };
-    config: unknown;
-    logger: PluginLogger;
-  },
-): void {
-  const resolved = resolveValidWorkspaceDir(ctx, api, { source, fallbackAgentId: 'main' });
-  const issue = validateWorkspaceDir(resolved);
-
-  if (issue) {
-    api.logger.error(`[PD:health] ${source}: workspaceDir="${resolved}" - ${issue}`);
-  } else {
-    api.logger.info(`[PD:health] ${source}: workspaceDir="${resolved}" OK`);
-  }
-}

package/src/hooks/trajectory-collector.ts

@@ -7,21 +7,21 @@
 
 import * as fs from 'fs';
 import * as path from 'path';
-import type { 
-  PluginHookAfterToolCallEvent, 
-  PluginHookToolContext, 
-  PluginHookLlmOutputEvent, 
+import type {
+  PluginHookAfterToolCallEvent,
+  PluginHookToolContext,
+  PluginHookLlmOutputEvent,
   PluginHookAgentContext,
   PluginHookBeforeMessageWriteEvent
 } from '../openclaw-sdk.js';
+import { MAX_STRING_LENGTH } from '../config/defaults/runtime.js';
 
 const TRAJECTORY_DIR = 'memory/trajectories/';
 
 // 敏感字段匹配正则
 const SENSITIVE_KEY_PATTERN = /password|token|authorization|secret|api[_-]?key|credential|cookie|session/i;
 
-// 最大字符串长度
-const MAX_STRING_LENGTH = 1000;
+// 最大结果长度（不同于 MAX_STRING_LENGTH）
 const MAX_RESULT_LENGTH = 500;
 
 /**
@@ -231,7 +231,7 @@ export function handleBeforeMessageWrite(
   if (typeof msg.content === 'string') {
      
     // Reason: msg.content is string | ContentPart[]; destructuring would require renaming in the else branch
-    // eslint-disable-next-line @typescript-eslint/prefer-destructuring
+     
     content = msg.content;
   } else if (Array.isArray(msg.content)) {
     content = msg.content