principles-disciple 1.34.1 → 1.35.0

package/.dependency-cruiser.json

@@ -0,0 +1,19 @@
+{
+  "forbidden": [
+    {
+      "name": "no-circular",
+      "severity": "error",
+      "comment": "Cycles hurt maintainability and testability.",
+      "from": {},
+      "to": {
+        "circular": true
+      }
+    }
+  ],
+  "options": {
+    "tsPreCompilationDeps": true,
+    "enhancedResolveOptions": {
+      "extensions": [".ts", ".tsx", ".js", ".jsx", ".json"]
+    }
+  }
+}

package/openclaw.plugin.json

@@ -2,7 +2,7 @@
   "id": "principles-disciple",
   "name": "Principles Disciple",
   "description": "Evolutionary programming agent framework with strategic guardrails and reflection loops.",
-  "version": "1.34.1",
+  "version": "1.35.0",
   "skills": [
     "./skills"
   ],

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "principles-disciple",
-  "version": "1.34.1",
+  "version": "1.35.0",
   "description": "Native OpenClaw plugin for Principles Disciple",
   "type": "module",
   "main": "./dist/bundle.js",
@@ -30,8 +30,11 @@
     "build:web": "node scripts/build-web.mjs",
     "build:bundle": "node esbuild.config.js && node scripts/build-web.mjs",
     "build:production": "node esbuild.config.js --production && node scripts/build-web.mjs --production && node scripts/verify-build.mjs",
-    "test": "vitest run",
-    "test:coverage": "vitest run --coverage",
+    "test": "vitest run --project=unit",
+    "test:unit": "vitest run --project=unit",
+    "test:integration": "vitest run --project=integration",
+    "test:coverage": "vitest run --project=unit --coverage",
+    "test:all": "vitest run",
     "lint": "eslint src/",
     "bootstrap-rules": "node scripts/bootstrap-rules.mjs",
     "validate-live-path": "tsx scripts/validate-live-path.ts"

package/src/config/defaults/runtime.ts

@@ -1,10 +1,52 @@
 /**
  * Centralized Runtime Defaults
- * 
+ *
  * All runtime-related constants that were previously scattered across modules.
  * Centralizing these makes it easier to tune behavior and understand limits.
  */
 
+// ── Time Constants ──────────────────────────────────────────────────────────────
+
+/** Milliseconds per second */
+export const MS_PER_SECOND = 1000;
+
+/** Seconds per minute */
+export const SECONDS_PER_MINUTE = 60;
+
+/** Minutes per hour */
+export const MINUTES_PER_HOUR = 60;
+
+/** Hours per day */
+export const HOURS_PER_DAY = 24;
+
+/** Days per week */
+export const DAYS_PER_WEEK = 7;
+
+/** One minute in milliseconds */
+export const ONE_MINUTE_MS = SECONDS_PER_MINUTE * MS_PER_SECOND;
+
+/** One hour in milliseconds */
+export const ONE_HOUR_MS = MINUTES_PER_HOUR * SECONDS_PER_MINUTE * MS_PER_SECOND;
+
+/** One day in milliseconds */
+export const ONE_DAY_MS = HOURS_PER_DAY * ONE_HOUR_MS;
+
+/** One week in milliseconds */
+export const ONE_WEEK_MS = DAYS_PER_WEEK * ONE_DAY_MS;
+
+// ── Workflow TTL & Timeouts ────────────────────────────────────────────────────
+
+/** Default TTL for helper workflows (5 minutes) */
+export const WORKFLOW_TTL_MS = 5 * ONE_MINUTE_MS;
+
+/** Default workflow timeout (15 minutes) */
+export const WORKFLOW_TIMEOUT_MS = 15 * ONE_MINUTE_MS;
+
+/** Default workflow sweep interval (30 minutes) */
+export const WORKFLOW_SWEEP_MS = 30 * ONE_MINUTE_MS;
+
+// ── Trajectory Gate Block Retry Settings ──────────────────────────────────────
+
 /**
  * Trajectory gate block retry settings
  * Used when trajectory recording fails and needs to retry
@@ -12,40 +54,74 @@
 export const TRAJECTORY_GATE_BLOCK_RETRY_DELAY_MS = 250;
 export const TRAJECTORY_GATE_BLOCK_MAX_RETRIES = 3;
 
-/**
- * Thinking checkpoint defaults (P-10)
- */
-export const THINKING_CHECKPOINT_WINDOW_MS = 5 * 60 * 1000; // 5 minutes
+// ── Thinking Checkpoint Defaults (P-10) ───────────────────────────────────────
+
+export const THINKING_CHECKPOINT_WINDOW_MS = 5 * ONE_MINUTE_MS;
 export const THINKING_CHECKPOINT_DEFAULT_HIGH_RISK_TOOLS = [
   'run_shell_command',
-  'delete_file', 
+  'delete_file',
   'move_file',
 ] as const;
 
-/**
- * Large change threshold for GFI gate adjustments
- */
+// ── GFI Gate Thresholds ───────────────────────────────────────────────────────
+
+/** Large change threshold for GFI gate adjustments */
 export const GFI_LARGE_CHANGE_LINES = 50;
 
-/**
- * Agent spawn GFI threshold (critically high = no spawn)
- */
+/** Agent spawn GFI threshold (critically high = no spawn) */
 export const AGENT_SPAWN_GFI_THRESHOLD = 90;
 
-/**
- * Evolution worker polling intervals
- */
-export const EVOLUTION_WORKER_POLL_INTERVAL_MS = 15 * 60 * 1000; // 15 minutes
+// ── Evolution Worker Settings ───────────────────────────────────────────────────
+
+/** Evolution worker polling interval (15 minutes) */
+export const EVOLUTION_WORKER_POLL_INTERVAL_MS = 15 * ONE_MINUTE_MS;
+
+/** Evolution queue batch size */
 export const EVOLUTION_QUEUE_BATCH_SIZE = 10;
 
-/**
- * Session tracker settings
- */
+/** Pain queue dedup window (30 minutes) */
+export const PAIN_QUEUE_DEDUP_WINDOW_MS = 30 * ONE_MINUTE_MS;
+
+// ── Session Tracker Settings ───────────────────────────────────────────────────
+
 export const SESSION_TOKEN_WARNING_THRESHOLD = 8000;
-export const SESSION_MAX_IDLE_MS = 30 * 60 * 1000; // 30 minutes
+export const SESSION_MAX_IDLE_MS = 30 * ONE_MINUTE_MS;
+
+// ── Event Log Buffer Settings ───────────────────────────────────────────────────
 
-/**
- * Event log buffer settings
- */
 export const EVENT_LOG_BUFFER_SIZE = 20;
-export const EVENT_LOG_FLUSH_INTERVAL_MS = 30 * 1000; // 30 seconds
+export const EVENT_LOG_FLUSH_INTERVAL_MS = 30 * ONE_MINUTE_MS;
+
+// ── Default Busy Timeout ───────────────────────────────────────────────────────
+
+/** Default busy timeout for SQLite operations (5 seconds) */
+export const DEFAULT_BUSY_TIMEOUT_MS = 5 * MS_PER_SECOND;
+
+// ── Nocturnal Runtime Settings ─────────────────────────────────────────────────
+
+/** Idle threshold (30 minutes) */
+export const DEFAULT_IDLE_THRESHOLD_MS = 30 * ONE_MINUTE_MS;
+
+/** Quota window (24 hours) */
+export const DEFAULT_QUOTA_WINDOW_MS = ONE_DAY_MS;
+
+/** Cool down period (30 minutes) */
+export const DEFAULT_COOLDOWN_MS = 30 * ONE_MINUTE_MS;
+
+// ── String & Size Limits ────────────────────────────────────────────────────────
+
+/** Max string length for trajectory/event logs */
+export const MAX_STRING_LENGTH = 1000;
+
+/** Default max file size (10MB) */
+export const MAX_FILE_SIZE_BYTES = 10 * 1024 * 1024;
+
+// ── Workflow TTL Settings ───────────────────────────────────────────────────────
+
+/** Deep-reflect workflow TTL (10 minutes) */
+export const DEEP_REFLECT_TTL_MS = 10 * ONE_MINUTE_MS;
+
+// ── Time Window Constants ───────────────────────────────────────────────────────
+
+/** Two hours in milliseconds */
+export const TWO_HOURS_MS = 2 * ONE_HOUR_MS;

package/src/core/event-log.ts

@@ -23,31 +23,96 @@ import type { PluginLogger } from '../openclaw-sdk.js';
 
 /**
  * EventLog - Structured event logging with daily statistics aggregation.
+ *
+ * Log files are date-stamped: events_YYYY-MM-DD.jsonl
+ * Old event files are automatically cleaned up based on retention policy.
  */
+
+/**
+ * Event log retention in days.
+ * Files older than this are deleted on cleanup.
+ */
+const EVENT_LOG_RETENTION_DAYS = 7;
+
 export class EventLog {
-  private readonly eventsFile: string;
+  private readonly logsDir: string;
   private readonly statsFile: string;
   private readonly logger?: PluginLogger;
-  
+
   private readonly statsCache: Map<string, DailyStats> = new Map();
   private eventBuffer: EventLogEntry[] = [];
   private readonly maxBufferSize = 20;
   private readonly flushIntervalMs = 30000;
   private flushTimer?: ReturnType<typeof setInterval>;
-  
+
+  // Cached event file path for current date
+  private currentEventsFile: string | undefined;
+  private currentDate: string | undefined;
+
   constructor(stateDir: string, logger?: PluginLogger) {
-    const logsDir = path.join(stateDir, 'logs');
-    if (!fs.existsSync(logsDir)) {
-      fs.mkdirSync(logsDir, { recursive: true });
+    this.logsDir = path.join(stateDir, 'logs');
+    if (!fs.existsSync(this.logsDir)) {
+      fs.mkdirSync(this.logsDir, { recursive: true });
     }
-    
-    this.eventsFile = path.join(logsDir, 'events.jsonl');
-    this.statsFile = path.join(logsDir, 'daily-stats.json');
+
+    this.statsFile = path.join(this.logsDir, 'daily-stats.json');
     this.logger = logger;
-    
+
     this.loadStats();
     this.startFlushTimer();
   }
+
+  /**
+   * Get the event file path for a given date.
+   */
+  private getEventsFile(date: string): string {
+    return path.join(this.logsDir, `events_${date}.jsonl`);
+  }
+
+  /**
+   * Get today's date string (YYYY-MM-DD).
+   */
+  private getTodayStr(): string {
+    return new Date().toISOString().split('T')[0];
+  }
+
+  /**
+   * Ensure we have the correct events file for today's date.
+   */
+  private ensureEventsFile(): string {
+    const today = this.getTodayStr();
+    if (this.currentDate !== today || !this.currentEventsFile) {
+      this.currentDate = today;
+      this.currentEventsFile = this.getEventsFile(today);
+      // Run cleanup if date changed
+      this.cleanupOldEventFiles(today);
+    }
+    return this.currentEventsFile;
+  }
+
+  /**
+   * Clean up event files older than EVENT_LOG_RETENTION_DAYS.
+   */
+  private cleanupOldEventFiles(today: string): void {
+    if (EVENT_LOG_RETENTION_DAYS <= 0) return;
+
+    try {
+      const cutoffMs = Date.now() - EVENT_LOG_RETENTION_DAYS * 24 * 60 * 60 * 1000;
+      const files = fs.readdirSync(this.logsDir);
+
+      for (const file of files) {
+        if (!file.startsWith('events_') || !file.endsWith('.jsonl')) continue;
+
+        const filePath = path.join(this.logsDir, file);
+        const stat = fs.statSync(filePath);
+        if (stat.mtimeMs < cutoffMs) {
+          fs.unlinkSync(filePath);
+        }
+      }
+    } catch {
+      // Silently fail cleanup
+    }
+  }
   
   recordToolCall(sessionId: string | undefined, data: ToolCallEventData): void {
     const category = data.error ? 'failure' : 'success';
@@ -108,7 +173,7 @@ export class EventLog {
   }
   
    
-  // eslint-disable-next-line @typescript-eslint/max-params
+   
   private record(
     type: EventType, 
     category: EventCategory, 
@@ -136,7 +201,7 @@ export class EventLog {
   }
 
    
-  // eslint-disable-next-line @typescript-eslint/class-methods-use-this
+   
   private formatDate(date: Date): string {
     return date.toISOString().split('T')[0];
   }
@@ -246,7 +311,7 @@ export class EventLog {
   }
 
    
-    // eslint-disable-next-line @typescript-eslint/class-methods-use-this -- complexity 13, refactor candidate
+     
   private getEventDedupKey(entry: EventLogEntry): string {
     const eventId = typeof (entry.data as { eventId?: unknown } | undefined)?.eventId === 'string'
       ? String((entry.data as { eventId?: string }).eventId)
@@ -268,10 +333,11 @@ export class EventLog {
   }
 
   private readPersistedEvents(): EventLogEntry[] {
-    if (!fs.existsSync(this.eventsFile)) return [];
+    const eventsFile = this.ensureEventsFile();
+    if (!fs.existsSync(eventsFile)) return [];
 
     try {
-      const content = fs.readFileSync(this.eventsFile, 'utf-8');
+      const content = fs.readFileSync(eventsFile, 'utf-8');
       return content
         .trim()
         .split('\n')
@@ -285,7 +351,7 @@ export class EventLog {
         })
         .filter((entry): entry is EventLogEntry => entry !== null);
     } catch (e) {
-      if (this.logger) this.logger.error(`[PD] Failed to read events.jsonl: ${String(e)}`);
+      if (this.logger) this.logger.error(`[PD] Failed to read events file: ${String(e)}`);
       return [];
     }
   }
@@ -300,13 +366,14 @@ export class EventLog {
 
   private flushEvents(): void {
     if (this.eventBuffer.length === 0) return;
-    
+
+    const eventsFile = this.ensureEventsFile();
     const lines = this.eventBuffer.map(e => JSON.stringify(e)).join('\n') + '\n';
     try {
-      fs.appendFileSync(this.eventsFile, lines, 'utf-8');
+      fs.appendFileSync(eventsFile, lines, 'utf-8');
       this.eventBuffer = [];
     } catch (e) {
-      if (this.logger) this.logger.error(`[PD] Failed to flush events.jsonl: ${String(e)}`);
+      if (this.logger) this.logger.error(`[PD] Failed to flush events: ${String(e)}`);
     }
   }
 
@@ -464,7 +531,7 @@ export class EventLog {
    * Returns the rolled back score, or 0 if event not found.
    */
    
-  // eslint-disable-next-line @typescript-eslint/max-params
+   
   rollbackEmpathyEvent(eventId: string, sessionId: string | undefined, reason: string, triggeredBy: 'user_command' | 'natural_language' | 'system'): number {
     const allEvents = this.getMergedEvents();
     let foundEvent: { entry: EventLogEntry; data: PainSignalEventData } | null = null;

package/src/core/nocturnal-candidate-scoring.ts

@@ -23,7 +23,7 @@
  * PHASE 6 ONLY — No real training, no automatic deployment
  */
 
-import type { DreamerCandidate, PhilosopherJudgment } from './nocturnal-trinity.js';
+import type { DreamerCandidate, PhilosopherJudgment } from './nocturnal-trinity-types.js';
 import type { ThresholdValues } from './adaptive-thresholds.js';
 
 // ---------------------------------------------------------------------------
@@ -293,7 +293,7 @@ export function validateCandidateDiversity(
 
   for (let i = 0; i < candidates.length; i++) {
     for (let j = i + 1; j < candidates.length; j++) {
-      // eslint-disable-next-line @typescript-eslint/no-use-before-define
+       
       const overlap = computeKeywordOverlap(
         candidates[i].betterDecision ?? '',
         candidates[j].betterDecision ?? '',
@@ -335,9 +335,9 @@ export function validateCandidateDiversity(
  * Returns value between 0 and 1.
  */
 function computeKeywordOverlap(textA: string, textB: string): number {
-  // eslint-disable-next-line @typescript-eslint/no-use-before-define
+   
   const wordsA = extractKeywords(textA);
-  // eslint-disable-next-line @typescript-eslint/no-use-before-define
+   
   const wordsB = extractKeywords(textB);
 
   if (wordsA.length === 0 && wordsB.length === 0) return 0;
@@ -376,7 +376,7 @@ function extractKeywords(text: string): string[] {
  * @returns All scored and ranked candidates
  */
  
-// eslint-disable-next-line @typescript-eslint/max-params
+ 
 export function rankCandidates(
   candidates: DreamerCandidate[],
   judgments: PhilosopherJudgment[],
@@ -464,7 +464,7 @@ export function rankCandidates(
  * @returns Tournament result with winner
  */
  
-// eslint-disable-next-line @typescript-eslint/max-params
+ 
 export function runTournament(
   candidates: DreamerCandidate[],
   judgments: PhilosopherJudgment[],

package/src/core/nocturnal-trinity-types.ts

@@ -0,0 +1,94 @@
+/**
+ * Nocturnal Trinity Shared Types
+ *
+ * Types shared between nocturnal-trinity.ts and nocturnal-candidate-scoring.ts.
+ * Extracted to break circular dependency.
+ */
+
+// ---------------------------------------------------------------------------
+// Dreamer Types
+// ---------------------------------------------------------------------------
+
+/**
+ * Individual candidate from Dreamer (alternative decision).
+ * Each candidate represents an alternative "better decision" approach.
+ */
+export interface DreamerCandidate {
+  /** Unique index for this candidate within the Dreamer output */
+  candidateIndex: number;
+  /** The bad decision this candidate addresses */
+  badDecision: string;
+  /** The alternative/better decision */
+  betterDecision: string;
+  /** Why this alternative is better (brief) */
+  rationale: string;
+  /** Confidence that this candidate is valid (0-1) */
+  confidence: number;
+  /** Risk level of this candidate's approach -- LLM-judged per D-02 */
+  riskLevel?: "low" | "medium" | "high";
+  /** Which strategic perspective this candidate embodies per D-01 */
+  strategicPerspective?: "conservative_fix" | "structural_improvement" | "paradigm_shift";
+}
+
+export interface DreamerOutput {
+  /** Whether Dreamer succeeded */
+  valid: boolean;
+  /** List of candidate corrections */
+  candidates: DreamerCandidate[];
+  /** Why Dreamer could not generate (if valid === false) */
+  reason?: string;
+  /** Timestamp of generation */
+  generatedAt: string;
+}
+
+// ---------------------------------------------------------------------------
+// Philosopher Types
+// ---------------------------------------------------------------------------
+
+export interface PhilosopherRiskAssessment {
+  /** Estimated probability that this candidate is a false positive (0-1) */
+  falsePositiveEstimate: number;
+  /** How complex is this candidate to implement */
+  implementationComplexity: 'low' | 'medium' | 'high';
+  /** Whether implementing this candidate risks breaking existing functionality */
+  breakingChangeRisk: boolean;
+}
+
+export interface Philosopher6DScores {
+  principleAlignment: number;
+  specificity: number;
+  actionability: number;
+  executability: number;
+  safetyImpact: number;
+  uxImpact: number;
+}
+
+export interface PhilosopherJudgment {
+  /** Index of the judged candidate (references DreamerCandidate.candidateIndex) */
+  candidateIndex: number;
+  /** Principle-grounded critique of this candidate */
+  critique: string;
+  /** Whether this candidate aligns with the target principle */
+  principleAligned: boolean;
+  /** Ranking score (higher = better, 0-1) */
+  score: number;
+  /** Rank among all candidates (1 = best) */
+  rank: number;
+  /** Per-dimension scores (6D evaluation) — informational, not used for tournament ranking */
+  scores?: Philosopher6DScores;
+  /** Risk assessment for this candidate — informational, consumed by Scribe (Phase 37) */
+  risks?: PhilosopherRiskAssessment;
+}
+
+export interface PhilosopherOutput {
+  /** Whether Philosopher succeeded */
+  valid: boolean;
+  /** Judgments for each candidate */
+  judgments: PhilosopherJudgment[];
+  /** Overall assessment of the candidate set */
+  overallAssessment: string;
+  /** Why Philosopher could not judge (if valid === false) */
+  reason?: string;
+  /** Timestamp of generation */
+  generatedAt: string;
+}