principles-disciple 1.16.0 → 1.17.0

package/src/service/health-query-service.ts

@@ -156,7 +156,8 @@ export class HealthQueryService {
     const queue = this.readQueueStats();
     const painFlag = this.readPainFlag();
 
-    // GFI: always read from SQLite (synced from session JSON at construction time)
+    // GFI: Re-sync from session JSON on every request for real-time data
+    this.syncGfiFromSession();
     const gfiData = this.readGfiFromDb();
     const {currentGfi} = gfiData;
     const peakToday = gfiData.dailyGfiPeak;
@@ -277,7 +278,8 @@ export class HealthQueryService {
       ORDER BY total DESC
     `, today);
 
-    // GFI: read from SQLite (synced from session JSON at construction time)
+    // GFI: Re-sync from session JSON for real-time data
+    this.syncGfiFromSession();
     const gfiData = this.readGfiFromDb();
 
     return {
@@ -551,7 +553,7 @@ export class HealthQueryService {
     const streamPath = resolvePdPath(this.workspaceDir, 'EVOLUTION_STREAM');
     if (!fs.existsSync(streamPath)) return [];
 
-    // eslint-disable-next-line no-useless-assignment -- Reason: initial value unused due to immediate reassignment
+     
     let lines: string[] = [];
     try {
       const raw = fs.readFileSync(streamPath, 'utf8').trim();
@@ -563,7 +565,7 @@ export class HealthQueryService {
 
     const records: RecentPrincipleChange[] = [];
     for (const line of lines) {
-      // eslint-disable-next-line no-useless-assignment -- Reason: initial value unused due to immediate reassignment in try/catch
+       
       let event: EvolutionStreamRecord | null = null;
       try {
         event = JSON.parse(line) as EvolutionStreamRecord;
@@ -781,7 +783,7 @@ export class HealthQueryService {
     return [];
   }
 
-  // eslint-disable-next-line @typescript-eslint/class-methods-use-this -- Reason: Private helper doesn't use instance state
+   
   private getEventDedupKey(entry: EventLogEntry): string {
     const eventId = typeof entry.data?.eventId === 'string' ? entry.data.eventId : null;
     if (eventId) {
@@ -851,7 +853,7 @@ export class HealthQueryService {
     return fallbackStage;
   }
 
-  // eslint-disable-next-line @typescript-eslint/class-methods-use-this -- Reason: Private helper doesn't use instance state
+   
   private resolveGateType(row: GateBlockRow): string {
     if (typeof row.gate_type === 'string' && row.gate_type.trim().length > 0) {
       return row.gate_type;
@@ -875,14 +877,14 @@ export class HealthQueryService {
     return cached.has(columnName);
   }
 
-  // eslint-disable-next-line @typescript-eslint/class-methods-use-this -- Reason: Private helper doesn't use instance state
+   
   private scoreToStatus(score: number): string {
     if (score >= 70) return 'healthy';
     if (score >= 40) return 'warning';
     return 'critical';
   }
 
-  // eslint-disable-next-line @typescript-eslint/class-methods-use-this -- Reason: Private helper doesn't use instance state
+   
   private evolutionToStatus(tier: string, points: number): string {
     const lower = tier.toLowerCase();
     if (lower === 'forest' || lower === 'tree') return 'healthy';
@@ -890,7 +892,7 @@ export class HealthQueryService {
     return 'critical';
   }
 
-  // eslint-disable-next-line @typescript-eslint/class-methods-use-this, no-unused-vars -- Reason: Private helper doesn't use instance state
+   
   private safeListFiles(dirPath: string, predicate: (_name: string) => boolean): string[] {
     if (!fs.existsSync(dirPath)) return [];
     try {
@@ -902,7 +904,7 @@ export class HealthQueryService {
     }
   }
 
-  // eslint-disable-next-line @typescript-eslint/class-methods-use-this -- Reason: Private helper doesn't use instance state
+   
   private readJsonFile<T>(filePath: string, fallback: T): T {
     if (!fs.existsSync(filePath)) return fallback;
     try {
@@ -912,12 +914,12 @@ export class HealthQueryService {
     }
   }
 
-  // eslint-disable-next-line @typescript-eslint/class-methods-use-this -- Reason: Private helper doesn't use instance state
+   
   private asNumber(value: unknown, fallback: number): number {
     return Number.isFinite(value) ? Number(value) : fallback;
   }
 
-  // eslint-disable-next-line @typescript-eslint/class-methods-use-this -- Reason: Private helper doesn't use instance state
+   
   private asNullableNumber(value: unknown): number | null {
     if (Number.isFinite(value)) return Number(value);
     if (typeof value === 'string' && value.trim().length > 0) {
@@ -953,7 +955,7 @@ export class HealthQueryService {
         today,
       );
     } catch (err) {
-      console.warn('[HealthQueryService] Failed to sync GFI from session:', err);
+      // Non-critical: GFI sync failure should not block queries
     }
   }
 
@@ -981,11 +983,15 @@ export class HealthQueryService {
    */
   private readLatestSessionFromFile(): SessionState | null {
     const sessionsDir = path.join(this.stateDir, 'sessions');
-    if (!fs.existsSync(sessionsDir)) return null;
+    if (!fs.existsSync(sessionsDir)) {
+      return null;
+    }
 
     try {
       const files = fs.readdirSync(sessionsDir).filter(f => f.endsWith('.json'));
-      if (files.length === 0) return null;
+      if (files.length === 0) {
+        return null;
+      }
 
       let latest: SessionState | null = null;
       let latestTs = 0;
@@ -994,7 +1000,10 @@ export class HealthQueryService {
         try {
           const content = fs.readFileSync(path.join(sessionsDir, file), 'utf-8');
           const state = JSON.parse(content) as SessionState;
-          if (state.workspaceDir && state.workspaceDir !== this.workspaceDir) continue;
+          // Skip sessions from different workspaces
+          if (state.workspaceDir && state.workspaceDir !== this.workspaceDir) {
+            continue;
+          }
           const ts = Number(state.lastControlActivityAt ?? state.lastActivityAt ?? 0);
           if (ts > latestTs) {
             latestTs = ts;
@@ -1006,7 +1015,8 @@ export class HealthQueryService {
       }
 
       return latest;
-    } catch {
+    } catch (err) {
+      // Non-critical: failure to read session files should not crash the service
       return null;
     }
   }

package/src/service/monitoring-query-service.ts

@@ -83,9 +83,9 @@ export class MonitoringQueryService {
       const failedEvent = events.find(e => e.event_type === `trinity_${stage}_failed`);
 
       // Determine status
-      // eslint-disable-next-line @typescript-eslint/init-declarations
+       
       let status: 'pending' | 'running' | 'completed' | 'failed';
-      // eslint-disable-next-line @typescript-eslint/init-declarations
+       
       let reason: string | undefined;
 
       if (!startEvent) {
@@ -106,7 +106,7 @@ export class MonitoringQueryService {
       const outputCount = stageOutputs.filter(so => so.stage === stage).length;
 
       // Calculate duration if stage started and completed/failed
-      // eslint-disable-next-line @typescript-eslint/init-declarations
+       
       let duration: number | undefined;
       if (startEvent && (completeEvent || failedEvent)) {
         const endEvent = completeEvent || failedEvent;

package/src/service/nocturnal-runtime.ts

@@ -304,7 +304,7 @@ export function checkWorkspaceIdle(
         trajectoryGuardrailConfirmsIdle = trajectoryIdleFor > idleThresholdMs * 0.8;
     }
 
-    // eslint-disable-next-line @typescript-eslint/init-declarations -- assigned in all if/else branches
+     
     let reason: string;
     if (mostRecentActivityAt === 0) {
         reason = 'No active sessions found — workspace is idle';
@@ -352,7 +352,7 @@ export function checkCooldown(
     } = {}
 ): CooldownCheckResult {
     const {
-        /* eslint-disable @typescript-eslint/no-unused-vars, no-unused-vars -- Reason: Cooldown parameters reserved for future quota enforcement */
+        /* eslint-disable @typescript-eslint/no-unused-vars -- Reason: Cooldown parameters reserved for future quota enforcement */
         globalCooldownMs: _globalCooldownMs = DEFAULT_GLOBAL_COOLDOWN_MS,
         principleCooldownMs: _principleCooldownMs = DEFAULT_PRINCIPLE_COOLDOWN_MS,
         maxRunsPerWindow = DEFAULT_MAX_RUNS_PER_WINDOW,
@@ -372,7 +372,7 @@ export function checkCooldown(
         if (cooldownEnd > now) {
             globalCooldownActive = true;
             globalCooldownRemainingMs = cooldownEnd - now;
-            globalCooldownUntil = state.globalCooldownUntil; // eslint-disable-line @typescript-eslint/prefer-destructuring -- Reason: globalCooldownUntil is reassignable outer let - destructuring would shadow
+            globalCooldownUntil = state.globalCooldownUntil;  
         }
     }
 
@@ -540,7 +540,7 @@ export interface PreflightCheckResult {
  * @param trajectoryLastActivityAt - Optional trajectory timestamp as secondary guardrail
  * @param idleCheckOverride - Optional override for idle check result (for testing)
  */
-/* eslint-disable @typescript-eslint/max-params -- Reason: Preflight check requires workspace, state, principleId, trajectory timestamp, and idle override */
+ 
 export function checkPreflight(
     workspaceDir: string,
     stateDir: string,

package/src/service/nocturnal-service.ts

@@ -99,6 +99,7 @@ import {
 import { NocturnalPathResolver } from '../core/nocturnal-paths.js';
 import { registerSample } from '../core/nocturnal-dataset.js';
 import type { Implementation } from '../types/principle-tree-schema.js';
+import { validateNocturnalSnapshotIngress } from '../core/nocturnal-snapshot-contract.js';
 
 // ---------------------------------------------------------------------------
 // Types
@@ -266,16 +267,16 @@ function invokeStubReflector(
 
   // Build a plausible bad/better decision pair based on available snapshot data.
   // This is synthetic — real reflection would come from subagent analysis.
-  const hasFailures = snapshot.stats.failureCount > 0;
+  const hasFailures = (snapshot.stats.failureCount ?? 0) > 0;
   const hasPain = snapshot.stats.totalPainEvents > 0;
-  const hasGateBlocks = snapshot.stats.totalGateBlocks > 0;
+  const hasGateBlocks = (snapshot.stats.totalGateBlocks ?? 0) > 0;
 
   // Detect what kind of signal is available and craft appropriate artifact
-  // eslint-disable-next-line @typescript-eslint/init-declarations -- assigned in all if/else branches
+   
   let badDecision: string;
-  // eslint-disable-next-line @typescript-eslint/init-declarations -- assigned in all if/else branches
+   
   let betterDecision: string;
-  // eslint-disable-next-line @typescript-eslint/init-declarations -- assigned in all if/else branches
+   
   let rationale: string;
 
   if (hasGateBlocks) {
@@ -362,7 +363,7 @@ function buildGateBlockRefs(snapshot: NocturnalSessionSnapshot): string[] {
   );
 }
 
-/* eslint-disable @typescript-eslint/max-params -- Reason: Function signature requires all parameters for type-safe artifact construction */
+ 
 function buildDefaultArtificerOutput(
   ruleId: string,
   artifact: NocturnalArtifact,
@@ -411,7 +412,7 @@ function buildDefaultArtificerOutput(
   };
 }
 
-/* eslint-disable @typescript-eslint/max-params -- Reason: Function signature requires all parameters for type-safe candidate persistence */
+ 
 function persistCodeCandidate(
   workspaceDir: string,
   stateDir: string,
@@ -503,7 +504,7 @@ function persistCodeCandidate(
   }
 }
 
-/* eslint-disable @typescript-eslint/max-params -- Reason: Function signature requires all parameters for type-safe candidate persistence */
+ 
 function maybePersistArtificerCandidate(
   workspaceDir: string,
   stateDir: string,
@@ -743,10 +744,10 @@ export function executeNocturnalReflection(
   // -------------------------------------------------------------------------
   // Step 5: Artifact generation (Trinity or single-reflector)
   // -------------------------------------------------------------------------
-  // eslint-disable-next-line no-useless-assignment -- Reason: initial value unused due to immediate reassignment in all branches
+   
   let trinityArtifact: TrinityDraftArtifact | null = null;
   let trinityResult: TrinityResult | null = null;
-  // eslint-disable-next-line @typescript-eslint/init-declarations -- assigned in all branches before use at line 884
+   
   let rawJson: string;
 
   if (options.skipReflector) {
@@ -966,7 +967,7 @@ export function executeNocturnalReflection(
     boundedAction: execResult.boundedAction,
   };
 
-  // eslint-disable-next-line @typescript-eslint/init-declarations -- assigned in try, catch has early return
+   
   let persistedPath: string;
   try {
     persistedPath = persistArtifact(workspaceDir, artifactWithBoundedAction);
@@ -1090,7 +1091,7 @@ export async function executeNocturnalReflectionAsync(
 
   // If runtime adapter is provided, use async Trinity path
   if (options.runtimeAdapter) {
-    // eslint-disable-next-line @typescript-eslint/no-use-before-define -- Reason: mutual recursion between helper functions - reordering would break logical grouping
+     
     return executeNocturnalReflectionWithAdapter(workspaceDir, stateDir, options);
   }
 
@@ -1139,20 +1140,36 @@ async function executeNocturnalReflectionWithAdapter(
   }
 
   // Step 2: Target selection (or use override to skip)
-  // eslint-disable-next-line @typescript-eslint/init-declarations -- Reason: assigned immediately in all branches before use
+   
   let selectedPrincipleId: string | undefined;
-  // eslint-disable-next-line @typescript-eslint/init-declarations -- Reason: assigned immediately in all branches before use
+   
   let selectedSessionId: string | undefined;
-  // eslint-disable-next-line no-useless-assignment -- Reason: initial value unused due to immediate reassignment in all branches
+   
   let snapshot: NocturnalSessionSnapshot | null = null;
 
   if (options.principleIdOverride && options.snapshotOverride) {
+    const snapshotValidation = validateNocturnalSnapshotIngress(options.snapshotOverride);
+    if (snapshotValidation.status !== 'valid' || !snapshotValidation.snapshot) {
+      return {
+        success: false,
+        skipReason: 'insufficient_snapshot_data',
+        noTargetSelected: true,
+        validationFailed: true,
+        validationFailures: snapshotValidation.reasons.length > 0
+          ? snapshotValidation.reasons
+          : ['invalid snapshot override'],
+        snapshot: undefined,
+        diagnostics,
+        trinityTelemetry: undefined,
+      };
+    }
+
     // Skip Selector: use provided principleId and snapshot directly
     selectedPrincipleId = options.principleIdOverride;
-    selectedSessionId = options.snapshotOverride.sessionId;
-    snapshot = options.snapshotOverride;
+    selectedSessionId = snapshotValidation.snapshot.sessionId;
+    snapshot = snapshotValidation.snapshot;
     // Calculate violation density from snapshot stats for meaningful diagnostics
-    const snapStats = options.snapshotOverride.stats;
+    const snapStats = snapshotValidation.snapshot.stats;
     const totalToolCalls = snapStats?.totalToolCalls ?? 0;
     const failureCount = snapStats?.failureCount ?? 0;
     const violationDensity = totalToolCalls > 0 ? failureCount / totalToolCalls : 0;
@@ -1205,9 +1222,9 @@ async function executeNocturnalReflectionWithAdapter(
       };
     }
 
-    // eslint-disable-next-line @typescript-eslint/prefer-destructuring -- Reason: selectedPrincipleId/selectedSessionId are reassignable outer lets - destructuring would shadow
+     
     selectedPrincipleId = selection.selectedPrincipleId;
-    // eslint-disable-next-line @typescript-eslint/prefer-destructuring -- Reason: selectedPrincipleId/selectedSessionId are reassignable outer lets - destructuring would shadow
+     
     selectedSessionId = selection.selectedSessionId;
 
     if (!selectedPrincipleId || !selectedSessionId) {
@@ -1240,10 +1257,10 @@ async function executeNocturnalReflectionWithAdapter(
   });
 
   // Step 4: Trinity execution via adapter (async)
-  // eslint-disable-next-line no-useless-assignment -- Reason: initial value unused due to immediate reassignment in all branches
+   
   let trinityArtifact: TrinityDraftArtifact | null = null;
   let trinityResult: TrinityResult | null = null;
-  // eslint-disable-next-line @typescript-eslint/init-declarations -- assigned in all branches before use
+   
   let rawJson: string;
 
   if (options.skipReflector) {
@@ -1348,7 +1365,7 @@ async function executeNocturnalReflectionWithAdapter(
 
   // Step 7: Persist artifact
   const artifactWithBoundedAction = { ...arbiterResult.artifact, boundedAction: execResult.boundedAction };
-  // eslint-disable-next-line @typescript-eslint/init-declarations -- assigned in try, catch has early return
+   
   let persistedPath: string;
   try {
     persistedPath = persistArtifact(workspaceDir, artifactWithBoundedAction);

package/src/service/nocturnal-target-selector.ts

@@ -286,7 +286,7 @@ export class NocturnalTargetSelector {
     recentMaxPainScore: number;
   };
 
-  /* eslint-disable @typescript-eslint/max-params -- Reason: Constructor requires all parameters for proper initialization */
+   
   constructor(
     workspaceDir: string,
     stateDir: string,
@@ -518,7 +518,7 @@ export class NocturnalTargetSelector {
  *
  * This is a convenience wrapper for the common case.
  */
-/* eslint-disable @typescript-eslint/max-params -- Reason: Function signature requires all parameters for type-safe selection */
+ 
 export function selectNocturnalTarget(
   workspaceDir: string,
   stateDir: string,

package/src/service/runtime-summary-service.ts

@@ -418,7 +418,7 @@ export class RuntimeSummaryService {
    * NOT a truth source for Phase 3 eligibility or decisions.
    * Queue is the only authoritative execution truth source.
    */
-  /* eslint-disable @typescript-eslint/max-params -- Reason: Directive summary requires queue, directive, timestamp, and warnings */
+   
   private static buildDirectiveSummary(
     queue: QueueItem[] | null,
     directive: DirectiveFile | null,

package/src/service/subagent-workflow/deep-reflect-workflow-manager.ts

@@ -69,7 +69,7 @@ export class DeepReflectWorkflowManager extends WorkflowManagerBase {
         return super.startWorkflow(spec, options);
     }
 
-    /* eslint-disable @typescript-eslint/class-methods-use-this -- Reason: Subclass overrides id generation pattern */
+     
     protected override generateWorkflowId(): string {
         return `wf_dr_${Date.now()}_${Math.random().toString(36).substring(2, 10)}`;
     }

package/src/service/subagent-workflow/empathy-observer-workflow-manager.ts

@@ -70,7 +70,7 @@ export class EmpathyObserverWorkflowManager extends WorkflowManagerBase {
         return super.startWorkflow(spec, options);
     }
 
-    /* eslint-disable @typescript-eslint/class-methods-use-this -- Reason: Subclass stores metadata via spec, not class fields */
+     
     protected override createWorkflowMetadata<TResult>(
         spec: SubagentWorkflowSpec<TResult>,
         options: {
@@ -103,7 +103,7 @@ export class EmpathyObserverWorkflowManager extends WorkflowManagerBase {
         ].join('\n');
     }
 
-    /* eslint-disable @typescript-eslint/class-methods-use-this -- Reason: Subclass overrides id generation pattern */
+     
     protected override generateWorkflowId(): string {
         return `wf_${Date.now()}_${Math.random().toString(36).substring(2, 10)}`;
     }
@@ -185,7 +185,7 @@ export const empathyObserverWorkflowSpec: SubagentWorkflowSpec<EmpathyResult> =
     ttlMs: 300_000,
     shouldDeleteSessionAfterFinalize: true,
 
-    /* eslint-disable @typescript-eslint/no-unused-vars, no-unused-vars -- Reason: interface method signature, unused parameter for spec compliance */
+     
     buildPrompt(taskInput: unknown, _metadata: WorkflowMetadata): string {
         const userMessage = String(taskInput).trim();
         return [

package/src/service/subagent-workflow/nocturnal-workflow-manager.ts

@@ -41,6 +41,7 @@ import type { RecentPainContext } from '../evolution-worker.js';
 import * as fs from 'fs';
 import * as path from 'path';
 import { isSubagentRuntimeAvailable } from '../../utils/subagent-probe.js';
+import { validateNocturnalSnapshotIngress } from '../../core/nocturnal-snapshot-contract.js';
 
 // ─────────────────────────────────────────────────────────────────────────────
 // NocturnalResult Type Alias
@@ -82,7 +83,7 @@ export interface NocturnalWorkflowOptions {
  * - timeoutMs: 15 minutes (900000ms)
  * - ttlMs: 30 minutes (1800000ms)
  */
-/* eslint-disable no-unused-vars, @typescript-eslint/no-unused-vars -- Reason: spec methods intentionally receive unused params per interface contract */
+ 
 export const nocturnalWorkflowSpec: SubagentWorkflowSpec<NocturnalResult> = {
     workflowType: 'nocturnal',
     transport: 'runtime_direct',
@@ -115,7 +116,7 @@ export const nocturnalWorkflowSpec: SubagentWorkflowSpec<NocturnalResult> = {
         return status === 'ok';
     },
 };
-/* eslint-enable no-unused-vars */
+ 
 
 // ─────────────────────────────────────────────────────────────────────────────
 // NocturnalWorkflowManager
@@ -212,15 +213,17 @@ export class NocturnalWorkflowManager implements WorkflowManager {
         this.store.recordEvent(workflowId, 'nocturnal_started', null, 'active', 'TrinityRuntimeAdapter invoked', { workflowType: 'nocturnal' });
 
         // Extract snapshot and principleId from taskInput.metadata (NOC-07: Trinity async path)
-        const snapshot = options.metadata?.snapshot as NocturnalSessionSnapshot | undefined;
+        const snapshotValidation = validateNocturnalSnapshotIngress(options.metadata?.snapshot);
+        const snapshot = snapshotValidation.snapshot;
         const principleId = options.metadata?.principleId as string | undefined;
         // Extract painContext for Selector ranking bias
         const painContext = options.metadata?.painContext as RecentPainContext | undefined;
 
-        // Validate required metadata (prevent runtime crashes from undefined snapshot)
-        if (!snapshot?.sessionId) {
-            this.logger.warn(`[PD:NocturnalWorkflow] Missing snapshot.sessionId in metadata for workflow=${workflowId}, terminating`);
-            this.store.recordEvent(workflowId, 'nocturnal_failed', null, 'terminal_error', 'Missing required metadata: snapshot.sessionId', { workflowId });
+        if (snapshotValidation.status !== 'valid' || !snapshot) {
+            const reason = `Invalid snapshot ingress: ${snapshotValidation.reasons.join('; ') || 'missing snapshot'}`;
+            this.logger.warn(`[PD:NocturnalWorkflow] ${reason} workflow=${workflowId}`);
+            this.store.updateWorkflowState(workflowId, 'terminal_error');
+            this.store.recordEvent(workflowId, 'nocturnal_failed', null, 'terminal_error', reason, { workflowId });
             return {
                 workflowId,
                 childSessionKey: `nocturnal:internal:${workflowId}`,
@@ -350,13 +353,13 @@ export class NocturnalWorkflowManager implements WorkflowManager {
         this.markCompleted(workflowId);
     }
 
-    // eslint-disable-next-line @typescript-eslint/class-methods-use-this -- Reason: interface contract requires this method signature, implementation is a no-op per D-10
+     
     async notifyLifecycleEvent(
-        // eslint-disable-next-line no-unused-vars -- Reason: interface contract requires these params but NocturnalWorkflowManager is a no-op per D-10
+         
         _workflowId: string,
-        // eslint-disable-next-line no-unused-vars -- Reason: interface contract requires these params but NocturnalWorkflowManager is a no-op per D-10
+         
         _event: 'subagent_spawned' | 'subagent_ended',
-        // eslint-disable-next-line no-unused-vars -- Reason: interface contract requires these params but NocturnalWorkflowManager is a no-op per D-10
+         
         _data?: Record<string, unknown>
     ): Promise<void> {
         // D-10: No-op. NocturnalWorkflowManager does not use the wait-on-run pattern.
@@ -411,13 +414,13 @@ export class NocturnalWorkflowManager implements WorkflowManager {
         maxAgeMs = 30 * 60 * 1000,
         // eslint-disable-next-line @typescript-eslint/no-explicit-any -- Reason: subagentRuntime param is intentionally any for backward compatibility with callers
         subagentRuntime?: any,
-        /* eslint-disable no-unused-vars -- Reason: type parameter names are documentation, not actual variables */
+         
         agentSession?: {
             resolveStorePath: () => string;
             loadSessionStore: (storePath: string, opts?: { skipCache?: boolean }) => Record<string, unknown>;
             saveSessionStore: (storePath: string, store: Record<string, unknown>) => Promise<void>;
         },
-        /* eslint-enable no-unused-vars */
+         
     ): Promise<number> {
         const expired = this.store.getExpiredWorkflows(maxAgeMs);
 

package/src/service/subagent-workflow/runtime-direct-driver.ts

@@ -8,12 +8,12 @@ import type {
 import { isExpectedSubagentError } from './subagent-error-utils.js';
 
 export interface TransportDriver {
-    /* eslint-disable no-unused-vars -- Reason: interface method params are type signatures, implementations use actual values */
+     
     run(params: RunParams): Promise<RunResult>;
     wait(params: WaitParams): Promise<WaitResult>;
     getResult(params: GetResultParams): Promise<GetResultResult>;
     cleanup(params: CleanupParams): Promise<void>;
-    /* eslint-enable no-unused-vars */
+     
 }
 
 export interface RunParams {
@@ -55,7 +55,7 @@ export interface CleanupParams {
     deleteTranscript?: boolean;
 }
 
-/* eslint-disable no-unused-vars -- Reason: type method params are type signatures, implementations use actual values */
+ 
 type PluginRuntimeSubagent = {
     run: (params: {
         sessionKey: string;
@@ -79,21 +79,21 @@ type PluginRuntimeSubagent = {
         deleteTranscript?: boolean;
     }) => Promise<void>;
 };
-/* eslint-enable no-unused-vars */
+ 
 
 /**
  * OpenClaw plugin SDK's agent.session namespace — always available (not gateway-scoped).
  * These functions are imported directly from OpenClaw's session store module.
  */
 export type AgentSessionAPI = {
-    /* eslint-disable no-unused-vars -- Reason: type method params are type signatures, implementations use actual values */
+     
     resolveStorePath: () => string;
     loadSessionStore: (storePath: string, opts?: { skipCache?: boolean }) => Record<string, unknown>;
     saveSessionStore: (storePath: string, store: Record<string, unknown>) => Promise<void>;
     resolveSessionFilePath: (sessionKey: string) => string;
     /** Optional: OpenClaw config object needed for session path resolution */
     config?: unknown;
-    /* eslint-enable no-unused-vars */
+     
 };
 
 export class RuntimeDirectDriver implements TransportDriver {
@@ -206,6 +206,10 @@ export class RuntimeDirectDriver implements TransportDriver {
                 this.logger.info(`[PD:RuntimeDirectDriver] Gateway-scoped cleanup unavailable (${errMsg.split(':')[0]}), falling back to agent.session`);
                 await this.cleanupViaAgentSession(params.sessionKey);
                 this.logger.info(`[PD:RuntimeDirectDriver] Fallback cleanup succeeded`);
+            } else if (isNonGatewayContext && !this.agentSession) {
+                // #232: Both cleanup paths unavailable — this is an OpenClaw environment limitation,
+                // not a PD bug. Session will be cleaned up on next gateway request or TTL expiry.
+                this.logger.warn(`[PD:RuntimeDirectDriver] Session cleanup skipped (${errMsg.split(':')[0]}): no gateway context and agentSession unavailable — session will expire naturally`);
             } else {
                 this.logger.error(`[PD:RuntimeDirectDriver] Cleanup failed: ${errMsg}`);
                 throw error;

package/src/service/subagent-workflow/types.ts

@@ -145,7 +145,7 @@ export interface WorkflowHandle {
  * ```
  */
 export interface SubagentWorkflowSpec<TResult> {
-    /* eslint-disable no-unused-vars -- Reason: interface method params are type signatures, implementations use actual values */
+     
     /** Unique identifier for this workflow type */
     workflowType: string;
     /** Which transport mechanism to use */
@@ -172,7 +172,7 @@ export interface SubagentWorkflowSpec<TResult> {
      * For runtime_direct: typically finalize only on 'ok', skip on 'timeout'/'error'.
      */
     shouldFinalizeOnWaitStatus: (status: 'ok' | 'error' | 'timeout') => boolean;
-    /* eslint-enable no-unused-vars */
+     
 }
 
 // ── Empathy Observer Specific Types ──────────────────────────────────────────
@@ -229,7 +229,7 @@ export interface EmpathyObserverWorkflowSpec extends SubagentWorkflowSpec<Empath
  * This is what the helper exposes to business modules.
  */
 export interface WorkflowManager {
-    /* eslint-disable no-unused-vars -- Reason: interface method params are type signatures, implementations use actual values */
+     
     /**
      * Start a new workflow.
      * Creates workflow state, spawns subagent, and returns handle.
@@ -289,7 +289,7 @@ export interface WorkflowManager {
      * Release resources (DB connections, timers).
      */
     dispose: () => void;
-    /* eslint-enable no-unused-vars */
+     
 }
 
 // ── Workflow Store (for SQLite persistence) ──────────────────────────────────

package/src/service/subagent-workflow/workflow-manager-base.ts

@@ -155,7 +155,7 @@ export abstract class WorkflowManagerBase implements WorkflowManager {
      * Create workflow metadata for store.createWorkflow().
      * Subclasses override to add type-specific fields.
      */
-    /* eslint-disable @typescript-eslint/class-methods-use-this -- Reason: Subclass hook that returns value via spec, not class state */
+     
     protected createWorkflowMetadata<TResult>(
         spec: SubagentWorkflowSpec<TResult>,
         options: {
@@ -181,7 +181,7 @@ export abstract class WorkflowManagerBase implements WorkflowManager {
      * Called after driver.run() succeeds.
      * Subclasses override to call store.createWorkflow() with type-specific metadata.
      */
-    /* eslint-disable @typescript-eslint/max-params -- Reason: Interface hook requires all params from caller context */
+     
     protected async createWorkflowRecord<TResult>(
         workflowId: string,
         childSessionKey: string,
@@ -213,7 +213,7 @@ export abstract class WorkflowManagerBase implements WorkflowManager {
 
     // ── Protected Helpers ────────────────────────────────────────────────────
 
-    /* eslint-disable @typescript-eslint/class-methods-use-this -- Reason: Helper method that delegates to spec.buildPrompt and driver.run */
+     
     protected buildRunParams<TResult>(
         spec: SubagentWorkflowSpec<TResult>,
         options: {
@@ -311,11 +311,11 @@ export abstract class WorkflowManagerBase implements WorkflowManager {
         status: 'ok' | 'error' | 'timeout',
         error?: string
     ): Promise<void> {
-        // eslint-disable-next-line @typescript-eslint/init-declarations -- assigned in try, catch has early returns
+         
         let workflow;
         try {
             workflow = this.store.getWorkflow(workflowId);
-        /* eslint-disable @typescript-eslint/no-unused-vars, no-unused-vars -- Reason: Error is handled via early returns based on status, not error value */
+        /* eslint-disable @typescript-eslint/no-unused-vars -- Reason: Error is handled via early returns based on status, not error value */
         } catch (_dbError) {
             // Database connection closed (e.g., by lifecycle notification dispose).
             // If subagent succeeded, this is a known race condition — the workflow