principles-disciple 1.16.0 → 1.17.0

package/src/core/nocturnal-trinity.ts

@@ -45,9 +45,8 @@ import {
 // ---------------------------------------------------------------------------
 // Embedded Role Prompts
 // ---------------------------------------------------------------------------
-// These prompts are embedded at build time to eliminate file system dependency.
-// Previously loaded from src/agents/*.md at runtime — fragile because esbuild
-// did not copy the agents/ directory into the bundle.
+// These prompts are embedded at build time. The agents/ directory was removed
+// to eliminate fragile runtime file dependencies on the file system.
 
 const NOCTURNAL_DREAMER_PROMPT = `# Nocturnal Dreamer — Candidate Generation
 
@@ -276,7 +275,7 @@ If you cannot synthesize an artifact:
  * Interface for Trinity stage invocation.
  * Implementations can use real subagent runtimes or stubs.
  */
-/* eslint-disable no-unused-vars -- Reason: interface method params are type signatures, not implementations */
+ 
 export interface TrinityRuntimeAdapter {
   /**
    * Invoke the Dreamer stage.
@@ -327,7 +326,7 @@ export interface TrinityRuntimeAdapter {
    */
   close?(): Promise<void>;
 }
-/* eslint-enable no-unused-vars */
+ 
 
 // ---------------------------------------------------------------------------
 // OpenClaw Runtime Adapter
@@ -339,7 +338,7 @@ export interface TrinityRuntimeAdapter {
  * Does NOT depend on OpenClaw internals.
  */
 export class OpenClawTrinityRuntimeAdapter implements TrinityRuntimeAdapter {
-  /* eslint-disable no-unused-vars -- Reason: type-level function parameter names are documentation */
+   
   private readonly api: {
     runtime: {
       subagent: {
@@ -366,7 +365,7 @@ export class OpenClawTrinityRuntimeAdapter implements TrinityRuntimeAdapter {
       };
     };
   };
-  /* eslint-enable no-unused-vars */
+   
 
   private readonly stageTimeoutMs: number;
 
@@ -472,14 +471,14 @@ export class OpenClawTrinityRuntimeAdapter implements TrinityRuntimeAdapter {
     }
   }
 
-  // eslint-disable-next-line @typescript-eslint/max-params -- Reason: scribe invocation requires all context parameters - refactoring would break API
+   
   async invokeScribe(
     dreamerOutput: DreamerOutput,
     philosopherOutput: PhilosopherOutput,
     snapshot: NocturnalSessionSnapshot,
     principleId: string,
     telemetry: TrinityTelemetry,
-    // eslint-disable-next-line no-unused-vars, @typescript-eslint/no-unused-vars -- Reason: interface requires this param but implementation doesn't use it
+     
     _config: TrinityConfig
   ): Promise<TrinityDraftArtifact | null> {
     const sessionKey = `agent:main:subagent:ne-scribe-${randomUUID()}`;
@@ -519,7 +518,7 @@ export class OpenClawTrinityRuntimeAdapter implements TrinityRuntimeAdapter {
     }
   }
 
-  // eslint-disable-next-line @typescript-eslint/class-methods-use-this -- Reason: interface-required close() with no-op implementation
+   
   async close(): Promise<void> {
     // Nothing to clean up in this implementation
   }
@@ -528,7 +527,7 @@ export class OpenClawTrinityRuntimeAdapter implements TrinityRuntimeAdapter {
   // Private Helper Methods
   // ---------------------------------------------------------------------------
 
-  // eslint-disable-next-line @typescript-eslint/class-methods-use-this -- Reason: pure utility function that doesn't need instance state
+   
   private extractAssistantText(
     messages: { role: string; text?: string; content?: string }[]
   ): string {
@@ -541,7 +540,7 @@ export class OpenClawTrinityRuntimeAdapter implements TrinityRuntimeAdapter {
     return '';
   }
 
-  // eslint-disable-next-line @typescript-eslint/class-methods-use-this -- Reason: pure utility function that doesn't need instance state
+   
   private buildDreamerPrompt(
     snapshot: NocturnalSessionSnapshot,
     principleId: string,
@@ -551,18 +550,18 @@ export class OpenClawTrinityRuntimeAdapter implements TrinityRuntimeAdapter {
 
 Session Snapshot:
 - Session ID: ${snapshot.sessionId}
-- Assistant Turns: ${snapshot.stats.totalAssistantTurns}
-- Tool Calls: ${snapshot.stats.totalToolCalls}
-- Failures: ${snapshot.stats.failureCount}
+- Assistant Turns: ${snapshot.stats.totalAssistantTurns ?? 'N/A (data unavailable)'}
+- Tool Calls: ${snapshot.stats.totalToolCalls ?? 'N/A (data unavailable)'}
+- Failures: ${snapshot.stats.failureCount ?? 'N/A (data unavailable)'}
 - Pain Events: ${snapshot.stats.totalPainEvents}
-- Gate Blocks: ${snapshot.stats.totalGateBlocks}
+- Gate Blocks: ${snapshot.stats.totalGateBlocks ?? 'N/A (data unavailable)'}
 
 Please analyze this session and generate ${maxCandidates} candidate corrections. Each candidate should identify a bad decision and propose a better alternative grounded in the target principle.
 
 Respond with ONLY a valid JSON object matching the DreamerOutput contract.`;
   }
 
-  // eslint-disable-next-line @typescript-eslint/class-methods-use-this -- Reason: utility method doesn't require this - pure prompt building function
+   
   private buildPhilosopherPrompt(
     dreamerOutput: DreamerOutput,
     principleId: string
@@ -576,7 +575,7 @@ ${candidatesJson}
 Please evaluate each candidate and rank them by principle alignment, specificity, and actionability. Respond with ONLY a valid JSON object matching the PhilosopherOutput contract.`;
   }
 
-  /* eslint-disable @typescript-eslint/class-methods-use-this, @typescript-eslint/max-params -- Reason: helper function needs all 4 context params and doesn't use instance state */
+   
   private buildScribePrompt(
     dreamerOutput: DreamerOutput,
     philosopherOutput: PhilosopherOutput,
@@ -596,7 +595,7 @@ ${judgmentsJson}
 
 Select the best candidate (Philosopher's rank 1) and synthesize it into a final TrinityDraftArtifact. Respond with ONLY a valid JSON object.`;
   }
-  /* eslint-enable @typescript-eslint/class-methods-use-this, @typescript-eslint/max-params */
+   
 
   private parseDreamerOutput(text: string): DreamerOutput {
     const json = this.extractJson(text);
@@ -694,12 +693,12 @@ Select the best candidate (Philosopher's rank 1) and synthesize it into a final
     }
   }
 
-  // eslint-disable-next-line @typescript-eslint/max-params -- Reason: output parsing requires text + snapshot + principleId + telemetry - refactoring would break API
+   
   private parseScribeOutput(
     text: string,
     snapshot: NocturnalSessionSnapshot,
     principleId: string,
-    // eslint-disable-next-line no-unused-vars, @typescript-eslint/no-unused-vars -- Reason: interface requires this param but implementation doesn't use it
+     
     _telemetry: TrinityTelemetry
   ): TrinityDraftArtifact | null {
     const json = this.extractJson(text);
@@ -740,7 +739,7 @@ Select the best candidate (Philosopher's rank 1) and synthesize it into a final
   /**
    * Extract JSON object from text that may contain markdown code blocks.
    */
-  // eslint-disable-next-line @typescript-eslint/class-methods-use-this -- Reason: pure utility function that doesn't need instance state
+   
   private extractJson(text: string): string | null {
     // Try direct parse first
     try {
@@ -996,9 +995,9 @@ export function invokeStubDreamer(
   principleId: string,
   maxCandidates: number
 ): DreamerOutput {
-  const hasFailures = snapshot.stats.failureCount > 0;
+  const hasFailures = (snapshot.stats.failureCount ?? 0) > 0;
   const hasPain = snapshot.stats.totalPainEvents > 0;
-  const hasGateBlocks = snapshot.stats.totalGateBlocks > 0;
+  const hasGateBlocks = (snapshot.stats.totalGateBlocks ?? 0) > 0;
 
   // #219: Detect fallback data source - stats may be incomplete
   const isFallback = snapshot._dataSource === 'pain_context_fallback';
@@ -1126,7 +1125,7 @@ export function invokeStubDreamer(
  */
 export function invokeStubPhilosopher(
   dreamerOutput: DreamerOutput,
-  // eslint-disable-next-line no-unused-vars, @typescript-eslint/no-unused-vars -- Reason: interface requires this param but stub implementation doesn't use it
+   
   _principleId: string
 ): PhilosopherOutput {
   if (!dreamerOutput.valid || dreamerOutput.candidates.length === 0) {
@@ -1201,7 +1200,7 @@ export function invokeStubPhilosopher(
  * In production, this would call the actual Scribe subagent.
  * The stub uses tournament selection (scoring + thresholds) to pick the winner.
  */
-// eslint-disable-next-line @typescript-eslint/max-params -- Reason: stub scribe requires all context parameters - refactoring would break API
+ 
 export function invokeStubScribe(
   dreamerOutput: DreamerOutput,
   philosopherOutput: PhilosopherOutput,
@@ -1279,7 +1278,7 @@ export function runTrinity(options: RunTrinityOptions): TrinityResult {
 
   // Stub path: use synchronous stub implementations
   if (config.useStubs) {
-    // eslint-disable-next-line @typescript-eslint/no-use-before-define -- Reason: function is defined later in file but callback order makes this necessary
+     
     return runTrinityWithStubs(snapshot, principleId, config);
   }
 
@@ -1318,7 +1317,7 @@ export async function runTrinityAsync(options: RunTrinityOptions): Promise<Trini
 
   if (config.useStubs) {
     // Stub path: use synchronous stubs
-    // eslint-disable-next-line @typescript-eslint/no-use-before-define -- Reason: function is defined later in file but callback order makes this necessary
+     
     return runTrinityWithStubs(snapshot, principleId, config);
   }
 

package/src/core/pain-context-extractor.ts

@@ -53,7 +53,7 @@ function getAgentsDir(): string {
 async function safeTail(filePath: string): Promise<string[]> {
   try {
     // Check existence and stats asynchronously
-    // eslint-disable-next-line @typescript-eslint/init-declarations -- assigned in try, catch has early return
+     
     let stat: fs.Stats;
     try {
       stat = await fsPromises.stat(filePath);
@@ -235,8 +235,8 @@ export async function extractRecentConversation(
 /**
  * Extracts failed tool call context with argument correlation.
  */
-/* eslint-disable @typescript-eslint/default-param-last */ // Reason: breaking API change - default param must precede required params for type inference compatibility
-// eslint-disable-next-line @typescript-eslint/max-params -- Reason: context extraction requires session + agent + tool + path - refactoring would break API
+  // Reason: breaking API change - default param must precede required params for type inference compatibility
+ 
 export async function extractFailedToolContext(
   sessionId: string,
   agentId = 'main',

package/src/core/pain.ts

@@ -3,6 +3,7 @@ import * as path from 'path';
 import { serializeKvLines, parseKvLines } from '../utils/io.js';
 import { resolvePdPath } from './paths.js';
 import { ConfigService } from './config-service.js';
+import { SystemLogger } from './system-logger.js';
 
 // =========================================================================
 // Pain Flag Contract (Single Source of Truth)
@@ -36,6 +37,13 @@ export interface PainFlagData {
   trigger_text_preview?: string;
 }
 
+export interface PainFlagContractResult {
+  status: 'missing' | 'valid' | 'invalid';
+  format: 'missing' | 'empty' | 'kv' | 'json' | 'invalid_json';
+  data: Record<string, string>;
+  missingFields: string[];
+}
+
 /**
  * Factory function — the ONLY way to construct pain flag data.
  *
@@ -58,16 +66,18 @@ export function buildPainFlag(input: {
   trace_id?: string;
   trigger_text_preview?: string;
 }): PainFlagData {
+  // Omit optional fields when not provided — prevents writing empty lines to disk
+  // which causes agent confusion (SKILL.md vs reality drift)
   return {
     source: input.source,
     score: input.score,
     time: input.time || new Date().toISOString(),
     reason: input.reason,
-    session_id: input.session_id || '',
-    agent_id: input.agent_id || '',
+    session_id: input.session_id ?? '',
+    agent_id: input.agent_id ?? '',
     is_risky: input.is_risky ? 'true' : 'false',
-    trace_id: input.trace_id || '',
-    trigger_text_preview: input.trigger_text_preview || '',
+    trace_id: input.trace_id ?? '',
+    trigger_text_preview: input.trigger_text_preview ?? '',
   };
 }
 
@@ -77,7 +87,9 @@ export function buildPainFlag(input: {
  */
 export function validatePainFlag(data: Record<string, string>): string[] {
   const missing: string[] = [];
-  const required = ['source', 'score', 'time', 'reason', 'session_id', 'agent_id'] as const;
+  // Only source/score/time/reason are truly required — session_id/agent_id
+  // may be empty in automated contexts (heartbeat, background workers)
+  const required = ['source', 'score', 'time', 'reason'] as const;
   for (const field of required) {
     if (!data[field] || data[field].trim() === '') {
       missing.push(field);
@@ -86,7 +98,6 @@ export function validatePainFlag(data: Record<string, string>): string[] {
   return missing;
 }
 
-// eslint-disable-next-line @typescript-eslint/max-params -- Reason: Score computation requires all 5 parameters - refactoring to options object would be breaking API change
 export function computePainScore(rc: number, isSpiral: boolean, missingTestCommand: boolean, softScore: number, projectDir?: string): number {
   let score = Math.max(0, softScore || 0);
   
@@ -146,26 +157,128 @@ export function writePainFlag(projectDir: string, painData: PainFlagData): void
   fs.writeFileSync(painFlagPath, serializeKvLines(painData), "utf-8");
 }
 
+/**
+ * Converts a JSON pain flag object to KV format.
+ */
+function convertJsonToKv(json: Record<string, unknown>): Record<string, string> {
+  const kvData: Record<string, string> = {};
+  const fieldMap: Record<string, string> = {
+    source: 'source',
+    score: 'score',
+    time: 'time',
+    timestamp: 'time',
+    reason: 'reason',
+    session_id: 'session_id',
+    sessionId: 'session_id',
+    agent_id: 'agent_id',
+    agentId: 'agent_id',
+    is_risky: 'is_risky',
+    isRisky: 'is_risky',
+    severity: 'severity',
+    painId: 'pain_id',
+  };
+  for (const [jsonKey, kvKey] of Object.entries(fieldMap)) {
+    if (json[jsonKey] !== undefined) {
+      kvData[kvKey] = String(json[jsonKey]);
+    }
+  }
+  for (const [key, value] of Object.entries(json)) {
+    if (fieldMap[key] === undefined && value !== undefined && value !== null) {
+      kvData[key] = String(value);
+    }
+  }
+  return kvData;
+}
+
+/**
+ * Reads and validates the pain flag file with auto-repair.
+ *
+ * - If file doesn't exist → returns {}
+ * - If file is JSON format (wrong) → converts to KV, logs warning, rewrites file
+ * - If file is KV format → validates required fields, logs warning if missing
+ * - If file has unknown fields → silently ignores them (forward-compatible)
+ */
 export function readPainFlagData(projectDir: string): Record<string, string> {
   const painFlagPath = resolvePdPath(projectDir, 'PAIN_FLAG');
   try {
     if (!fs.existsSync(painFlagPath)) {
       return {};
     }
-    const content = fs.readFileSync(painFlagPath, "utf-8");
-    return parseKvLines(content);
-  } catch (e) { // eslint-disable-line @typescript-eslint/no-unused-vars, no-unused-vars -- Reason: intentionally unused - returning empty object on error
+    const content = fs.readFileSync(painFlagPath, "utf-8").trim();
+    if (!content) {
+      return {};
+    }
+
+    // Detect JSON format (wrong — should be KV)
+    if (content.startsWith('{')) {
+      let json: Record<string, unknown>;
+      try {
+        json = JSON.parse(content);
+      } catch {
+        SystemLogger.log(projectDir, 'PAIN_FLAG_CORRUPT', 'Pain flag file contains invalid JSON');
+        return {};
+      }
+
+      // Auto-repair: convert JSON to KV format
+      const kvData = convertJsonToKv(json);
+
+      const repaired = serializeKvLines(kvData);
+      fs.writeFileSync(painFlagPath, repaired, 'utf-8');
+      SystemLogger.log(projectDir, 'PAIN_FLAG_AUTO_REPAIRED', `Auto-repaired pain flag from JSON to KV format (${Object.keys(json).length} fields)`);
+      return kvData;
+    }
+
+    // KV format — parse and validate
+    const data = parseKvLines(content);
+    const missing = validatePainFlag(data);
+    if (missing.length > 0) {
+      SystemLogger.log(projectDir, 'PAIN_FLAG_INCOMPLETE', `Pain flag missing required fields: ${missing.join(', ')}`);
+    }
+    return data;
+  } catch (e) {
+    SystemLogger.log(projectDir, 'PAIN_FLAG_READ_ERROR', `Failed to read pain flag: ${String(e)}`);
     return {};
   }
 }
 
+export function readPainFlagContract(projectDir: string): PainFlagContractResult {
+  const data = readPainFlagData(projectDir);
+
+  if (Object.keys(data).length === 0) {
+    const painFlagPath = resolvePdPath(projectDir, 'PAIN_FLAG');
+    if (!fs.existsSync(painFlagPath)) {
+      return { status: 'missing', format: 'missing', data: {}, missingFields: [] };
+    }
+
+    const raw = fs.readFileSync(painFlagPath, 'utf-8').trim();
+    if (!raw) {
+      return { status: 'missing', format: 'empty', data: {}, missingFields: [] };
+    }
+
+    return {
+      status: 'invalid',
+      format: raw.startsWith('{') ? 'invalid_json' : 'kv',
+      data: {},
+      missingFields: ['unparseable'],
+    };
+  }
+
+  const missing = validatePainFlag(data);
+  return {
+    status: missing.length > 0 ? 'invalid' : 'valid',
+    format: 'kv',
+    data,
+    missingFields: missing,
+  };
+}
+
 /**
  * Track principle value metrics when a pain signal is written.
  * This is observation-only — it does NOT affect the pain flag write flow.
  * If any principle matches the pain signal, its painPreventedCount is incremented.
  * Errors are silently ignored to avoid disrupting the pain pipeline.
  */
-// eslint-disable-next-line @typescript-eslint/max-params -- Reason: principle value tracking requires workspace + data + getters + updaters - refactoring would break API
+ 
 export function trackPrincipleValue(
   workspaceDir: string,
   painData: { reason?: string; source?: string; score?: string },
@@ -174,7 +287,7 @@ export function trackPrincipleValue(
     trigger: string;
     valueMetrics?: { painPreventedCount: number; lastPainPreventedAt?: string; calculatedAt: string };
   }[],
-  updatePrincipleMetrics: (_id: string, _metrics: { painPreventedCount: number; lastPainPreventedAt: string; calculatedAt: string }) => void, // eslint-disable-line no-unused-vars -- Reason: callback params required by interface, actual values accessed via principle.id and principle.valueMetrics
+  updatePrincipleMetrics: (_id: string, _metrics: { painPreventedCount: number; lastPainPreventedAt: string; calculatedAt: string }) => void,  
 ): void {
   try {
     const activePrinciples = getActivePrinciples();

package/src/core/path-resolver.ts

@@ -8,12 +8,12 @@ export interface PathResolverOptions {
     workspaceDir?: string;
     normalizeWorkspace?: boolean;
     logger?: {
-        /* eslint-disable no-unused-vars -- Reason: logger callback param names intentionally unused - callbacks only invoked for side effects */
+         
         debug?: (_msg: string) => void;
         info?: (_msg: string) => void;
         warn?: (_msg: string) => void;
         error?: (_msg: string) => void;
-        /* eslint-enable no-unused-vars */
+         
     };
 }
 
@@ -420,9 +420,9 @@ export function resolveWorkspaceDirFromApi(
     if (!api) return undefined;
 
     // 1. Official API: api.runtime.agent.resolveAgentWorkspaceDir
-    /* eslint-disable no-unused-vars -- Reason: type callback params cfg/id unused - actual values passed are api.config and agentId */
+     
     const officialAgent = (api.runtime as { agent?: { resolveAgentWorkspaceDir?: (cfg: unknown, id: string) => string } }).agent;
-    /* eslint-enable no-unused-vars */
+     
     if (officialAgent?.resolveAgentWorkspaceDir) {
         try {
             return officialAgent.resolveAgentWorkspaceDir(api.config, agentId ?? 'main');

package/src/core/pd-task-reconciler.ts

@@ -72,14 +72,14 @@ export interface ReconcileResult {
 export interface ReconcileOptions {
   dryRun?: boolean;
   workspaceDir: string;
-  /* eslint-disable no-unused-vars -- Reason: logger callback param names intentionally unused - callbacks only invoked for side effects */
+   
   logger?: { info?: (_: string) => void; warn?: (_: string) => void };
-  /* eslint-enable no-unused-vars */
+   
 }
 
-/* eslint-disable no-unused-vars -- Reason: logger callbacks have unused param names in type */
+ 
 async function readCronStore(logger?: { info?: (_: string) => void; warn?: (_: string) => void }): Promise<CronStoreFile> {
-/* eslint-enable no-unused-vars */
+ 
   if (!fs.existsSync(CRON_STORE_PATH)) {
     logger?.info?.(`[PD:Reconciler] cron/jobs.json not found, starting with empty store`);
     return { version: 1, jobs: [] };
@@ -143,7 +143,7 @@ function diff(declared: PDTaskSpec[], actual: CronJob[]): DiffAction[] {
 function buildCronJob(
   task: PDTaskSpec,
   nowMs: number,
-  // eslint-disable-next-line no-unused-vars -- logger callback param unused in type
+   
   logger?: { info?: (_: string) => void },
 ): CronJob {
   logger?.info?.(`[PD:Reconciler] Building cron job: ${task.name} (id=${task.id}, interval=${task.schedule.everyMs}ms)`);
@@ -158,7 +158,7 @@ function buildCronJob(
     wakeMode: 'now',
     payload: {
       kind: 'agentTurn',
-      // eslint-disable-next-line @typescript-eslint/no-use-before-define -- Reason: buildTaskPrompt is defined later in this file, called here for organizational reasons
+       
       message: buildTaskPrompt(task, logger),
       lightContext: task.execution.lightContext ?? true,
       timeoutSeconds: task.execution.timeoutSeconds ?? 120,
@@ -177,7 +177,7 @@ function buildCronJob(
   };
 }
 
-// eslint-disable-next-line no-unused-vars -- logger callback param unused in type
+ 
 function buildTaskPrompt(task: PDTaskSpec, logger?: { info?: (_: string) => void }): string {
   if (task.id === 'empathy-optimizer') {
     logger?.info?.(`[PD:Reconciler] Building empathy optimizer prompt`);
@@ -292,7 +292,7 @@ export async function reconcilePDTasks(
   });
 
   const cronStore = await readCronStore(logger);
-  // eslint-disable-next-line @typescript-eslint/no-use-before-define -- Reason: healthCheck is defined later in this file, called here for organizational reasons
+   
   const healthUpdated = healthCheck(declared, cronStore, logger);
   const actions = diff(healthUpdated, cronStore.jobs);
 
@@ -369,9 +369,9 @@ export async function reconcilePDTasks(
 function healthCheck(
   tasks: PDTaskSpec[],
   cronStore: CronStoreFile,
-  /* eslint-disable no-unused-vars -- Reason: callback type signature parameters */
+   
   logger: { info?: (_msg: string) => void; warn?: (_msg: string) => void },
-  /* eslint-enable no-unused-vars */
+   
 ): PDTaskSpec[] {
   const jobByName = new Map(cronStore.jobs.map((j) => [j.name, j]));
 

package/src/core/pd-task-service.ts

@@ -35,7 +35,7 @@ export const PDTaskService: OpenClawPluginService = {
     }
   },
 
-  // eslint-disable-next-line @typescript-eslint/no-unused-vars, no-unused-vars -- Reason: stop method required by service interface but no cleanup needed
+   
   stop(_ctx: OpenClawPluginServiceContext): void {
     /* intentionally empty - no cleanup required for this service */
   },

package/src/core/pd-task-store.ts

@@ -55,7 +55,7 @@ export function initTaskMeta(task: PDTaskSpec): PDTaskSpec {
   return task;
 }
 
-// eslint-disable-next-line @typescript-eslint/max-params -- Reason: sync meta update requires task + status + optional jobId + error - refactoring would break API
+ 
 export function updateSyncMeta(
   task: PDTaskSpec,
   status: 'ok' | 'error',

package/src/core/principle-internalization/deprecated-readiness.ts

@@ -63,7 +63,7 @@ export function assessDeprecatedReadiness(
       adherence.repeatedErrorReductionScore * 0.15,
   );
 
-  // eslint-disable-next-line @typescript-eslint/init-declarations -- assigned in all if/else branches
+   
   let status: DeprecatedReadinessStatus;
   if (blockingReasons.length === 0 && stableCoverageRatio === 1) {
     status = 'ready';

package/src/core/principle-training-state.ts

@@ -62,7 +62,7 @@ export function createDefaultPrincipleState(principleId: string): PrincipleTrain
 }
 
 export function loadStore(stateDir: string): PrincipleTrainingStore {
-  // eslint-disable-next-line @typescript-eslint/no-use-before-define -- Reason: ledgerTrainingStore is defined later in this file, called here for organizational reasons
+   
   return ledgerTrainingStore(stateDir);
 }
 
@@ -75,7 +75,7 @@ export function saveStore(stateDir: string, store: PrincipleTrainingStore): void
 }
 
 export async function loadStoreAsync(stateDir: string): Promise<PrincipleTrainingStore> {
-  // eslint-disable-next-line @typescript-eslint/no-use-before-define -- Reason: ledgerTrainingStore is defined later in this file, called here for organizational reasons
+   
   return ledgerTrainingStore(stateDir);
 }
 

package/src/core/principle-tree-ledger.ts

@@ -77,7 +77,7 @@ function isRecord(value: unknown): value is Record<string, unknown> {
   return typeof value === 'object' && value !== null && !Array.isArray(value);
 }
 
-/* eslint-disable @typescript-eslint/max-params -- Reason: Clamp function requires all parameters for safe numeric conversion */
+ 
 function clampFloat(value: unknown, min: number, max: number, fallback: number): number {
   if (typeof value !== 'number' || !Number.isFinite(value)) {
     return fallback;
@@ -85,7 +85,7 @@ function clampFloat(value: unknown, min: number, max: number, fallback: number):
   return Math.max(min, Math.min(max, value));
 }
 
-/* eslint-disable @typescript-eslint/max-params -- Reason: Clamp function requires all parameters for safe numeric conversion */
+ 
 function clampInt(value: unknown, min: number, max: number, fallback: number): number {
   if (typeof value !== 'number' || !Number.isFinite(value)) {
     return fallback;
@@ -315,9 +315,9 @@ function writeLedgerUnlocked(filePath: string, store: HybridLedgerStore): void {
   fs.writeFileSync(filePath, serializeLedger(store), 'utf-8');
 }
 
-/* eslint-disable no-unused-vars -- Reason: callback parameter used via closure in inner function */
+ 
 function mutateLedger<T>(stateDir: string, mutate: (store: HybridLedgerStore) => T): T {
-  // eslint-disable-next-line @typescript-eslint/no-use-before-define -- Reason: function is defined later but called in this helper for consistency
+   
   const filePath = getLedgerFilePath(stateDir);
   return withLock(filePath, () => {
     const store = readLedgerFromFile(filePath);
@@ -327,9 +327,9 @@ function mutateLedger<T>(stateDir: string, mutate: (store: HybridLedgerStore) =>
   });
 }
 
-/* eslint-disable no-unused-vars -- Reason: callback parameter used via closure in inner function */
+ 
 async function mutateLedgerAsync<T>(stateDir: string, mutate: (store: HybridLedgerStore) => Promise<T>): Promise<T> {
-  // eslint-disable-next-line @typescript-eslint/no-use-before-define -- Reason: function is defined later but called in this helper for consistency
+   
   const filePath = getLedgerFilePath(stateDir);
   return withLockAsync(filePath, async () => {
     const store = readLedgerFromFile(filePath);
@@ -363,7 +363,7 @@ export async function saveLedgerAsync(stateDir: string, store: HybridLedgerStore
 
 export function updateTrainingStore(
   stateDir: string,
-  /* eslint-disable no-unused-vars -- Reason: callback parameter is forwarded to mutateLedger callback */
+   
   mutate: (store: LegacyPrincipleTrainingStore) => void,
 ): void {
   mutateLedger(stateDir, (store) => {