principles-disciple 1.139.0 → 1.141.0

package/dist/hooks/raw-observation-adapter.js

@@ -1,170 +1,15 @@
 /**
- * Raw Observation Adapter — PRI-362
+ * Raw Observation Adapter — PRI-362 / PRI-446
  *
- * Unified source-kind resolution from RawObservation.
+ * The source-kind resolution logic and RawObservation builders have been
+ * migrated to principles-core (runtime-v2/evidence-triage/observation-resolver.ts).
  *
- * Replaces scattered resolveSourceKindFrom* functions with a single
- * field-driven adapter that maps observation fields to SourceKind.
- *
- * Field precedence (highest to lowest):
- * 1. isManualEntry → owner_reported
- * 2. isGateBlock → rulehost_block
- * 3. isSubagentError → subagent_error
- * 4. isRateLimit → rate_limit (if true)
- * 5. toolName === 'pain' / 'skill:pain' → agent_on_owner_request (with openclaw_context_bound) / owner_reported
- * 6. failureSource → tool_failure / dispatch_error
- * 7. isGfiTriggered → gfi_threshold
- * 8. detectionSource → llm_paralysis / semantic / empathy_inferred / unknown
- * 9. Fallback → unknown
+ * This file is now a thin re-export adapter. It preserves the original export
+ * names (resolveSourceKind, buildToolFailureObservation, buildLlmDetectionObservation,
+ * RawObservation) so all existing import sites and the source-string
+ * characterization tests keep working without changes.
  *
  * ERR checklist:
- * - ERR-001: Source kind resolved from runtime values, no `as` casts.
- * - ERR-002: Every path returns a valid SourceKind (fallback to 'unknown').
- * - EP-01: Runtime values validated before use.
- */
-/**
- * Resolve SourceKind from a unified RawObservation.
- *
- * This function replaces the scattered resolveSourceKindFrom* functions
- * and provides a single entry point for source-kind classification.
- *
- * Field precedence is explicitly defined in the function body to ensure
- * deterministic behavior and make the logic easy to understand and test.
- */
-export function resolveSourceKind(observation) {
-    const { isManualEntry, isGateBlock, isSubagentError, isRateLimit, toolName, failureSource, isGfiTriggered, detectionSource, nonZeroExit, timedOut, toolNotFound, } = observation;
-    // Priority 1: Manual entry (CLI, owner-reported)
-    if (isManualEntry) {
-        return 'owner_reported';
-    }
-    // Priority 2: Gate block
-    if (isGateBlock) {
-        return 'rulehost_block';
-    }
-    // Priority 3: Subagent error
-    if (isSubagentError) {
-        return 'subagent_error';
-    }
-    // Priority 4: Provider rate limit (explicit true/false)
-    if (isRateLimit === true) {
-        return 'rate_limit';
-    }
-    if (isRateLimit === false) {
-        return 'provider_failure';
-    }
-    // Priority 5: Manual pain tool
-    if (toolName === 'pain' || toolName === 'skill:pain') {
-        // Match resolveSourceKindFromToolFailure behavior:
-        // openclaw_context_bound → agent_on_owner_request
-        // other provenance or undefined → owner_reported
-        if (observation.provenance === 'openclaw_context_bound') {
-            return 'agent_on_owner_request';
-        }
-        return 'owner_reported';
-    }
-    // Priority 6: GFI threshold (must check before failure source for LLM detection path)
-    if (isGfiTriggered) {
-        return 'gfi_threshold';
-    }
-    // Priority 7: Tool failure / dispatch error
-    if (failureSource) {
-        // Match resolveSourceKindFromToolFailure behavior:
-        // dispatch_error → dispatch_error, anything else → tool_failure
-        if (failureSource === 'dispatch_error') {
-            return 'dispatch_error';
-        }
-        return 'tool_failure';
-    }
-    // Infer failureSource from tool failure indicators if not explicitly set
-    if (toolNotFound) {
-        return 'dispatch_error';
-    }
-    // Match classifyToolFailureSource behavior: unknown tool name → dispatch_error
-    // BUT only if this looks like a tool failure context (has other tool fields)
-    // Otherwise, this is likely a non-tool observation (e.g., LLM detection)
-    const hasToolContext = toolName !== undefined || nonZeroExit || timedOut || toolNotFound;
-    if (hasToolContext && (!toolName || toolName.trim() === '')) {
-        return 'dispatch_error';
-    }
-    // Exit code-based detection: non-zero exit or timeout → tool_failure
-    if (nonZeroExit || timedOut) {
-        return 'tool_failure';
-    }
-    // Priority 8: LLM detection source
-    if (detectionSource) {
-        // Match resolveSourceKindFromLlmDetection behavior:
-        if (detectionSource === 'llm_paralysis') {
-            return 'llm_paralysis';
-        }
-        if (detectionSource.startsWith('llm_')) {
-            return 'semantic';
-        }
-        if (detectionSource === 'user_empathy') {
-            return 'empathy_inferred';
-        }
-    }
-    // Fallback: unknown
-    return 'unknown';
-}
-// ── Builder Functions ──────────────────────────────────────────────────────
-//
-// PRI-360 S1: These builders construct RawObservation from specific contexts,
-// centralizing source classification rules in the adapter layer.
-// Hooks should NOT hold source classification logic — use these builders.
-/**
- * Classify error message as dispatch_error vs tool_failure.
- *
- * This centralizes the regex-based classification that was previously
- * scattered in classifyToolFailureSource and after-tool-call-helpers.
- * Now hooks call this builder + resolveSourceKind instead of holding rules.
- */
-function classifyErrorForDispatch(error) {
-    if (!error)
-        return 'tool_failure';
-    const msg = String(error);
-    if (/\btool\s+(?:\S+\s+)?not\s+found\b/i.test(msg) || /\bunknown\s+tool\b/i.test(msg)) {
-        return 'dispatch_error';
-    }
-    return 'tool_failure';
-}
-/**
- * Build a RawObservation for a tool failure context.
- *
- * This replaces classifyToolFailureSource and the inline classification
- * in after-tool-call-helpers. All tool error → dispatch/tool_failure
- * classification is centralized here.
- */
-export function buildToolFailureObservation(options) {
-    const { toolName, error, provenance } = options;
-    const nonZeroExit = typeof options.exitCode === 'number' && options.exitCode !== 0;
-    // Classify dispatch vs tool_failure centrally
-    let failureSource;
-    if (!toolName || toolName.trim() === '') {
-        // Empty/whitespace tool name → dispatch error
-        failureSource = 'dispatch_error';
-    }
-    else {
-        failureSource = classifyErrorForDispatch(error);
-    }
-    // If neither error nor non-zero exit, this is not a failure context
-    if (!error && !nonZeroExit) {
-        failureSource = undefined;
-    }
-    return {
-        observedAt: new Date().toISOString(),
-        toolName,
-        failureSource,
-        nonZeroExit,
-        provenance,
-    };
-}
-/**
- * Build a RawObservation for an LLM detection context.
+ * - ERR-011: re-export adapter, not a local re-definition of migrated logic.
  */
-export function buildLlmDetectionObservation(options) {
-    return {
-        observedAt: new Date().toISOString(),
-        detectionSource: options.detectionSource,
-        isGfiTriggered: options.isGfiTriggered,
-    };
-}
+export { resolveSourceKind, buildToolFailureObservation, buildLlmDetectionObservation, } from '@principles/core/runtime-v2';

package/dist/hooks/raw-observation-types.d.ts

@@ -1,62 +1,11 @@
 /**
- * Raw Observation Types — PRI-362
+ * Raw Observation Types — PRI-362 / PRI-446
  *
- * Source adapter layer that normalizes diverse hook contexts into a unified
- * observation model before mapping to SourceKind.
- *
- * This replaces scattered resolveSourceKindFrom* functions with a single
- * field-driven adapter.
+ * The RawObservation type has been migrated to principles-core
+ * (runtime-v2/evidence-triage/observation-resolver.ts). This file re-exports it
+ * so existing plugin import sites keep working unchanged.
  *
  * ERR checklist:
- * - ERR-001: No `as` casts; validate unknown payload field-by-field.
- * - ERR-002: Every decision carries reason + nextAction.
- * - EP-01: Source adapter validates before use.
- */
-/**
- * Raw observation from a source adapter.
- *
- * This is the input to resolveSourceKind. It contains all possible
- * context fields that different sources may provide. The adapter
- * reads only the fields it needs based on the observation source.
+ * - ERR-011: this is a re-export adapter, not a local re-definition.
  */
-export interface RawObservation {
-    /** When the observation was made (ISO timestamp) */
-    readonly observedAt: string;
-    /** Workspace identifier */
-    readonly workspaceId?: string;
-    /** Session identifier */
-    readonly sessionId?: string;
-    /** Trace identifier for correlation */
-    readonly traceId?: string;
-    /** Tool name (for after_tool_call hook) */
-    readonly toolName?: string;
-    /** Failure source classification */
-    readonly failureSource?: 'tool_failure' | 'dispatch_error';
-    /** Whether the tool call exited with non-zero code */
-    readonly nonZeroExit?: boolean;
-    /** Whether the tool call timed out */
-    readonly timedOut?: boolean;
-    /** Whether the tool does not exist */
-    readonly toolNotFound?: boolean;
-    /** Detection source identifier */
-    readonly detectionSource?: string;
-    /** Whether GFI threshold was crossed */
-    readonly isGfiTriggered?: boolean;
-    /** Whether the failure was a rate limit (429) */
-    readonly isRateLimit?: boolean;
-    /** Whether this observation came from a gate block */
-    readonly isGateBlock?: boolean;
-    /** Whether this was a manual CLI entry */
-    readonly isManualEntry?: boolean;
-    /** Provenance: how trustworthy and context-bound is the observation */
-    readonly provenance?: 'openclaw_context_bound' | 'owner_reported_no_host_trace' | 'automatic_hook';
-    /** Whether this observation came from a subagent error */
-    readonly isSubagentError?: boolean;
-    /**
-     * Raw payload from the source.
-     *
-     * This is always `unknown` (ERR-005). Source adapters validate only
-     * enough to identify the source and capture bounded context.
-     */
-    readonly payload?: unknown;
-}
+export type { RawObservation } from '@principles/core/runtime-v2';

package/dist/hooks/raw-observation-types.js

@@ -1,15 +1,11 @@
 /**
- * Raw Observation Types — PRI-362
+ * Raw Observation Types — PRI-362 / PRI-446
  *
- * Source adapter layer that normalizes diverse hook contexts into a unified
- * observation model before mapping to SourceKind.
- *
- * This replaces scattered resolveSourceKindFrom* functions with a single
- * field-driven adapter.
+ * The RawObservation type has been migrated to principles-core
+ * (runtime-v2/evidence-triage/observation-resolver.ts). This file re-exports it
+ * so existing plugin import sites keep working unchanged.
  *
  * ERR checklist:
- * - ERR-001: No `as` casts; validate unknown payload field-by-field.
- * - ERR-002: Every decision carries reason + nextAction.
- * - EP-01: Source adapter validates before use.
+ * - ERR-011: this is a re-export adapter, not a local re-definition.
  */
 export {};

package/dist/hooks/triage-adapter.js

@@ -42,38 +42,18 @@ export { resolveSourceKind, buildToolFailureObservation, buildLlmDetectionObserv
  * - Falling back to existing behavior when the flag is off
  */
 export function evaluateEvidenceTriage(sourceKind, score, options) {
+    // PRI-446: the risky high-score and repeated-failure upgrade rules now live
+    // in core triage-policy.ts (single source of truth). The adapter passes the
+    // context flags straight through; core decides whether to upgrade.
     const input = {
         sourceKind,
         score,
         isUnsafeHighConfidence: options?.isUnsafeHighConfidence,
         provenance: options?.provenance,
+        isRisky: options?.isRisky,
+        consecutiveErrors: options?.consecutiveErrors,
     };
-    let result = evaluateTriage(input);
-    // PEAT-B1 upgrade logic: risky high-score overrides evidence_only
-    // Matches PainDiagnosticGate.risky_high_score: isRisky && score >= 70 → admit
-    if (result.decision === 'evidence_only' &&
-        options?.isRisky === true &&
-        score >= 70) {
-        result = {
-            ...result,
-            decision: 'admit',
-            reason: 'Risky high-score operation overrides evidence-only decision. Immediate diagnosis required.',
-            nextAction: 'create_diagnostic_task',
-        };
-    }
-    // PEAT-B1 upgrade logic: repeated failures override evidence_only
-    // Threshold: 4 consecutive failures (matches PainDiagnosticGate.repeatedFailure)
-    if (result.decision === 'evidence_only' &&
-        options?.consecutiveErrors !== undefined &&
-        options.consecutiveErrors >= 4) {
-        result = {
-            ...result,
-            decision: 'admit',
-            reason: 'Repeated failures override evidence-only decision. Pattern suggests systemic issue requiring diagnosis.',
-            nextAction: 'create_diagnostic_task',
-        };
-    }
-    return result;
+    return evaluateTriage(input);
 }
 // ── High-Confidence Unsafe Action Detection ──────────────────────────────────
 /**

package/openclaw.plugin.json

@@ -2,7 +2,7 @@
   "id": "principles-disciple",
   "name": "Principles Disciple",
   "description": "Evolutionary programming agent framework with strategic guardrails and reflection loops.",
-  "version": "1.139.0",
+  "version": "1.141.0",
   "activation": {
     "onCapabilities": [
       "hook"

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "principles-disciple",
-  "version": "1.139.0",
+  "version": "1.141.0",
   "description": "Native OpenClaw plugin for Principles Disciple",
   "type": "module",
   "main": "./dist/bundle.js",

package/dist/hooks/subagent.d.ts

@@ -1,9 +0,0 @@
-import type { PluginHookSubagentEndedEvent, PluginHookSubagentContext, OpenClawPluginApi } from '../openclaw-sdk.js';
-type SubagentEndedHookContext = PluginHookSubagentContext & {
-    api?: OpenClawPluginApi;
-    workspaceDir?: string;
-    sessionId?: string;
-    agentId?: string;
-};
-export declare function handleSubagentEnded(event: PluginHookSubagentEndedEvent, ctx: SubagentEndedHookContext): Promise<void>;
-export {};

package/dist/hooks/subagent.js

@@ -1,122 +0,0 @@
-import { WorkspaceContext } from '../core/workspace-context.js';
-import { extractAgentIdFromSessionKey } from '../utils/session-key.js';
-import { recordEvolutionSuccess } from '../core/evolution-engine.js';
-import { WorkflowStore } from '../service/subagent-workflow/workflow-store.js';
-/**
- * Factory to create the appropriate WorkflowManager by workflow_type string.
- * Used by the subagent_ended hook to dispatch lifecycle recovery to the right manager.
- */
-function createWorkflowManagerForType(workflowType) {
-    switch (workflowType) {
-        default:
-            return null;
-    }
-}
-const HELPER_WORKFLOW_SESSION_PREFIX = 'agent:main:subagent:workflow-';
-// Cleanup expired retry entries periodically
-function emitSubagentPainEvent(wctx, payload, logger) {
-    try {
-        wctx.evolutionReducer.emitSync({
-            ts: new Date().toISOString(),
-            type: 'pain_detected',
-            data: {
-                painId: `pain_${Date.now()}_${Math.random().toString(36).slice(2, 10)}`,
-                painType: 'subagent_error',
-                source: payload.source,
-                reason: payload.reason,
-                score: payload.score,
-                sessionId: payload.sessionId,
-                agentId: payload.agentId,
-            },
-        });
-    }
-    catch (e) {
-        logger.warn(`[PD:Subagent] failed to emit evolution event: ${String(e)}`);
-    }
-}
-export async function handleSubagentEnded(event, ctx) {
-    const { outcome, targetSessionKey } = event;
-    const { workspaceDir } = ctx;
-    if (!workspaceDir)
-        return;
-    const wctx = WorkspaceContext.fromHookContext(ctx);
-    const logger = ctx.api?.logger ?? console;
-    // ── Helper Workflow Lifecycle Notification ──
-    // When a helper workflow's subagent ends, notify the workflow manager
-    // so that it can trigger fallback recovery (notifyWaitResult → finalizeOnce)
-    if (targetSessionKey?.startsWith(HELPER_WORKFLOW_SESSION_PREFIX)) {
-        try {
-            const store = new WorkflowStore({ workspaceDir });
-            const workflow = store.getWorkflowByChildSession(targetSessionKey);
-            if (workflow && workflow.state !== 'completed' && workflow.state !== 'terminal_error' && workflow.state !== 'expired') {
-                logger.info(`[PD:Subagent] Helper workflow lifecycle event: workflowId=${workflow.workflow_id}, workflowType=${workflow.workflow_type}, outcome=${outcome}`);
-                const mappedOutcome = outcome === 'deleted' ? 'deleted' :
-                    outcome === 'killed' ? 'killed' :
-                        outcome === 'reset' ? 'reset' :
-                            outcome === 'error' ? 'error' :
-                                outcome === 'timeout' ? 'timeout' : 'ok';
-                // Call notifyLifecycleEvent on the appropriate manager so it
-                // triggers notifyWaitResult → finalizeOnce / terminal transition.
-                const subagentRuntime = ctx.api?.runtime?.subagent;
-                if (subagentRuntime) {
-                    const mgr = createWorkflowManagerForType(workflow.workflow_type);
-                    if (mgr) {
-                        await mgr.notifyLifecycleEvent(workflow.workflow_id, 'subagent_ended', { outcome: mappedOutcome });
-                        mgr.dispose();
-                    }
-                    else {
-                        logger.warn(`[PD:Subagent] Unknown workflow type ${workflow.workflow_type} — falling back to store-only event`);
-                        store.recordEvent(workflow.workflow_id, 'subagent_ended', workflow.state, workflow.state, `subagent ended with outcome: ${outcome}`, { outcome: mappedOutcome });
-                    }
-                }
-                else {
-                    logger.warn(`[PD:Subagent] Subagent runtime not available — cannot notify manager, falling back to store event`);
-                    store.recordEvent(workflow.workflow_id, 'subagent_ended', workflow.state, workflow.state, `subagent ended with outcome: ${outcome}`, { outcome: mappedOutcome });
-                }
-                store.dispose();
-                return;
-            }
-            store.dispose();
-        }
-        catch (e) {
-            logger.warn(`[PD:Subagent] Failed to notify helper workflow lifecycle: ${String(e)}`);
-        }
-    }
-    const { config } = wctx;
-    // ── Outcome-based EP and Pain Signal handling ──
-    // OpenClaw v2026.3.23 fixes: timeout may be false positive (fast-finishing workers)
-    // Only penalize actual errors, not timeout/killed/reset
-    if (outcome === 'error') {
-        // Only actual errors trigger penalty
-        const scoreSettings = config.get('scores');
-        const score = scoreSettings.subagent_error_penalty;
-        const reason = `Subagent session ${targetSessionKey} ended with error`;
-        // Emit pain via Runtime v2 chain (M8: no .pain_flag file)
-        emitSubagentPainEvent(wctx, {
-            source: `subagent_error`,
-            reason,
-            score,
-            sessionId: ctx.sessionId,
-            agentId: ctx.agentId || extractAgentIdFromSessionKey(targetSessionKey),
-        }, logger);
-    }
-    if (outcome === 'timeout') {
-        // OpenClaw v2026.3.23 fix: timeout may be false positive
-        // Fast-finishing workers are no longer incorrectly reported as timed out
-        // Do not penalize - the task may have actually succeeded
-        logger.warn(`[PD:Subagent] Session ${targetSessionKey} timed out - not penalizing (OpenClaw fix applied)`);
-    }
-    if (outcome === 'killed' || outcome === 'reset') {
-        // User-initiated termination or system reset - not an agent failure
-        logger.info(`[PD:Subagent] Session ${targetSessionKey} ended with ${outcome} - no penalty (user/system action)`);
-    }
-    if (outcome === 'ok' || outcome === 'deleted') {
-        recordEvolutionSuccess(workspaceDir, 'subagent', {
-            sessionId: ctx.sessionId,
-            reason: 'subagent_success',
-        });
-    }
-    // ── End of subagent_ended handling ──
-    // Note: Diagnostician runs via HEARTBEAT (main session LLM), not as a subagent.
-    // Principle creation happens in evolution-worker.ts marker detection path.
-}