principles-disciple 1.139.0 → 1.141.0

package/dist/core/detection-funnel.d.ts

@@ -1,24 +1,38 @@
+/**
+ * Detection Funnel — PRI-446 thin adapter
+ *
+ * The pure three-layer funnel logic (LRU cache, async queue, layer dispatch)
+ * now lives in principles-core
+ * (runtime-v2/detection/detection-funnel-policy.ts). This file is a thin shell
+ * that wires DetectionFunnelCore with the two environment-coupled dependencies
+ * the plugin owns:
+ *   - crypto.createHash (the L2 cache key hasher)
+ *   - PainDictionary.match (the L1 exact matcher)
+ *   - shouldIgnorePainProtocolText (the protocol-token gate)
+ *
+ * It re-exports DetectionFunnel (same class name + constructor signature) and
+ * DetectionResult so DetectionService, llm.ts, and evolution-worker keep working
+ * unchanged.
+ *
+ * ERR checklist:
+ * - ERR-011: this is a thin adapter delegating to core pure logic.
+ */
 import { type PainDictionary } from './dictionary.js';
-export interface DetectionResult {
-    detected: boolean;
-    severity?: number;
-    ruleId?: string;
-    source: 'l1_exact' | 'l2_cache' | 'l3_async_queued' | 'l3_semantic_hit';
-}
+import { type DetectionResult } from '@principles/core/runtime-v2';
+export type { DetectionResult };
 /**
  * Orchestrates the three-layer detection funnel for pain signals.
+ *
+ * Delegates to the core DetectionFunnelCore, injecting the crypto hasher,
+ * the dictionary matcher, and the protocol-token gate.
  */
 export declare class DetectionFunnel {
-    private readonly cache;
-    private asyncQueue;
-    private readonly dictionary;
+    private readonly core;
     constructor(dictionary: PainDictionary);
     /**
      * Detects pain in the given text using L1 (Exact), L2 (Cache), and L3 (Async).
      */
     detect(text: string): DetectionResult;
-    private static computeHash;
-    private enqueueAsync;
     /**
      * Internal method for the worker to update the cache after a semantic hit.
      */

package/dist/core/detection-funnel.js

@@ -1,104 +1,56 @@
-import { createHash } from 'crypto';
-import { shouldIgnorePainProtocolText } from './dictionary.js';
 /**
- * A simple LRU Cache implementation using Map.
+ * Detection Funnel — PRI-446 thin adapter
+ *
+ * The pure three-layer funnel logic (LRU cache, async queue, layer dispatch)
+ * now lives in principles-core
+ * (runtime-v2/detection/detection-funnel-policy.ts). This file is a thin shell
+ * that wires DetectionFunnelCore with the two environment-coupled dependencies
+ * the plugin owns:
+ *   - crypto.createHash (the L2 cache key hasher)
+ *   - PainDictionary.match (the L1 exact matcher)
+ *   - shouldIgnorePainProtocolText (the protocol-token gate)
+ *
+ * It re-exports DetectionFunnel (same class name + constructor signature) and
+ * DetectionResult so DetectionService, llm.ts, and evolution-worker keep working
+ * unchanged.
+ *
+ * ERR checklist:
+ * - ERR-011: this is a thin adapter delegating to core pure logic.
  */
-class SimpleLRU {
-    cache;
-    maxSize;
-    constructor(maxSize = 100) {
-        this.cache = new Map();
-        this.maxSize = maxSize;
-    }
-    get(key) {
-        const item = this.cache.get(key);
-        if (item !== undefined) {
-            // Refresh: delete and re-insert
-            this.cache.delete(key);
-            this.cache.set(key, item);
-        }
-        return item;
-    }
-    set(key, value) {
-        if (this.cache.has(key)) {
-            this.cache.delete(key);
-        }
-        else if (this.cache.size >= this.maxSize) {
-            // Remove the oldest (first) item
-            const firstKey = this.cache.keys().next().value;
-            if (firstKey !== undefined) {
-                this.cache.delete(firstKey);
-            }
-        }
-        this.cache.set(key, value);
-    }
-}
+import { createHash } from 'crypto';
+import { shouldIgnorePainProtocolText } from './dictionary.js';
+import { DetectionFunnelCore, } from '@principles/core/runtime-v2';
 /**
  * Orchestrates the three-layer detection funnel for pain signals.
+ *
+ * Delegates to the core DetectionFunnelCore, injecting the crypto hasher,
+ * the dictionary matcher, and the protocol-token gate.
  */
 export class DetectionFunnel {
-    cache = new SimpleLRU(100);
-    asyncQueue = [];
-    dictionary;
+    core;
     constructor(dictionary) {
-        this.dictionary = dictionary;
+        this.core = new DetectionFunnelCore({
+            match: (text) => dictionary.match(text),
+            hash: (text) => createHash('sha256').update(text).digest('hex'),
+            shouldIgnoreProtocol: shouldIgnorePainProtocolText,
+        });
     }
     /**
      * Detects pain in the given text using L1 (Exact), L2 (Cache), and L3 (Async).
      */
     detect(text) {
-        if (shouldIgnorePainProtocolText(text)) {
-            return { detected: false, source: 'l1_exact' };
-        }
-        // --- Layer 1: Exact Match (Sync) ---
-        const exactMatch = this.dictionary.match(text);
-        if (exactMatch) {
-            return {
-                detected: true,
-                severity: exactMatch.severity,
-                ruleId: exactMatch.ruleId,
-                source: 'l1_exact'
-            };
-        }
-        // --- Layer 2: LRU Cache (Sync) ---
-        const hash = DetectionFunnel.computeHash(text);
-        const cached = this.cache.get(hash);
-        if (cached) {
-            return {
-                detected: cached.detected,
-                severity: cached.severity,
-                source: 'l2_cache'
-            };
-        }
-        // --- Layer 3: Async Semantic Queue ---
-        this.enqueueAsync(text);
-        return {
-            detected: false,
-            source: 'l3_async_queued'
-        };
-    }
-    static computeHash(text) {
-        return createHash('sha256').update(text).digest('hex');
-    }
-    enqueueAsync(text) {
-        if (this.asyncQueue.length < 1000) {
-            this.asyncQueue.push(text);
-        }
-        // Worker will pick this up and perform semantic search via createMemorySearchTool
+        return this.core.detect(text);
     }
     /**
      * Internal method for the worker to update the cache after a semantic hit.
      */
     updateCache(text, result) {
-        const hash = DetectionFunnel.computeHash(text);
-        this.cache.set(hash, result);
+        this.core.updateCache(text, result);
     }
     /**
      * Retrieves and clears the current asynchronous queue.
      */
     flushQueue() {
-        const queue = [...this.asyncQueue];
-        this.asyncQueue = [];
-        return queue;
+        return this.core.flushQueue();
     }
 }

package/dist/core/pain-diagnostic-gate.d.ts

@@ -1,30 +1,24 @@
-declare const PAIN_DIAGNOSTIC_SOURCES: readonly ["manual", "tool_failure", "dispatch_error", "gate_blocked", "user_empathy", "llm_paralysis", "semantic", "subagent_error"];
-export type PainDiagnosticSource = typeof PAIN_DIAGNOSTIC_SOURCES[number];
-export type PainDiagnosticGateReason = 'manual' | 'high_gfi' | 'repeated_failure' | 'semantic_pain' | 'llm_paralysis' | 'risky_high_score' | 'subagent_error' | 'gate_blocked' | 'cooldown' | 'below_gate';
-export interface PainDiagnosticGateInput {
-    source: PainDiagnosticSource | string;
-    score: number;
-    currentGfi: number;
-    consecutiveErrors?: number;
-    isRisky?: boolean;
-    errorHash?: string;
-    sessionId?: string;
-    nowMs?: number;
-    cooldownMs?: number;
-    thresholds?: {
-        painTrigger?: number;
-        highSeverity?: number;
-        highGfi?: number;
-        repeatedFailure?: number;
-        semanticPain?: number;
-    };
-}
-export interface PainDiagnosticGateDecision {
-    shouldDiagnose: boolean;
-    reason: PainDiagnosticGateReason;
-    episodeKey: string;
-    detail: string;
-}
+/**
+ * Pain Diagnostic Gate — PRI-446 thin adapter
+ *
+ * The pure decision logic (threshold tree, cooldown comparison, episode-key
+ * construction) now lives in principles-core
+ * (runtime-v2/pain-gate/pain-diagnostic-gate-policy.ts). This file is the
+ * stateful adapter that owns:
+ *   - the cooldown Map (lastDiagnosedAtByEpisode)
+ *   - Date.now() injection
+ *   - SystemLogger for unknown-source telemetry
+ *
+ * It preserves the original export names (evaluatePainDiagnosticGate,
+ * isCooldownActiveForEpisode, resetPainDiagnosticGateForTest) so all 5 callers
+ * (gate-block-helper, llm, pain, prompt x2) and the characterization test keep
+ * working unchanged.
+ *
+ * ERR checklist:
+ * - ERR-011: this is a stateful adapter delegating to core pure logic.
+ */
+import { type PainDiagnosticSource, type PainDiagnosticGateReason, type PainDiagnosticGateInput, type PainDiagnosticGateDecision } from '@principles/core/runtime-v2';
+export type { PainDiagnosticSource, PainDiagnosticGateReason, PainDiagnosticGateInput, PainDiagnosticGateDecision, };
 export declare function resetPainDiagnosticGateForTest(): void;
 /**
  * Check whether cooldown is currently active for a given episode.
@@ -32,5 +26,9 @@ export declare function resetPainDiagnosticGateForTest(): void;
  * with the PainDiagnosticGate's cooldown state.
  */
 export declare function isCooldownActiveForEpisode(source: string, sessionId: string | undefined, errorHash: string | undefined, cooldownMs?: number): boolean;
+/**
+ * Evaluate the pain diagnostic gate. Delegates the pure decision to core and,
+ * when the decision is to diagnose, records the current time against the
+ * episode so subsequent calls within the cooldown window are suppressed.
+ */
 export declare function evaluatePainDiagnosticGate(input: PainDiagnosticGateInput): PainDiagnosticGateDecision;
-export {};

package/dist/core/pain-diagnostic-gate.js

@@ -1,42 +1,26 @@
+/**
+ * Pain Diagnostic Gate — PRI-446 thin adapter
+ *
+ * The pure decision logic (threshold tree, cooldown comparison, episode-key
+ * construction) now lives in principles-core
+ * (runtime-v2/pain-gate/pain-diagnostic-gate-policy.ts). This file is the
+ * stateful adapter that owns:
+ *   - the cooldown Map (lastDiagnosedAtByEpisode)
+ *   - Date.now() injection
+ *   - SystemLogger for unknown-source telemetry
+ *
+ * It preserves the original export names (evaluatePainDiagnosticGate,
+ * isCooldownActiveForEpisode, resetPainDiagnosticGateForTest) so all 5 callers
+ * (gate-block-helper, llm, pain, prompt x2) and the characterization test keep
+ * working unchanged.
+ *
+ * ERR checklist:
+ * - ERR-011: this is a stateful adapter delegating to core pure logic.
+ */
 import { SystemLogger } from './system-logger.js';
-const PAIN_DIAGNOSTIC_SOURCES = [
-    'manual',
-    'tool_failure',
-    'dispatch_error',
-    'gate_blocked',
-    'user_empathy',
-    'llm_paralysis',
-    'semantic',
-    'subagent_error',
-];
-const DEFAULT_COOLDOWN_MS = 15 * 60 * 1000;
+import { evaluatePainDiagnosticGateDecision, normalizedSource, buildEpisodeKey, isCooldownActive as isCooldownActiveCore, } from '@principles/core/runtime-v2';
+// Module-level cooldown state — owned by this adapter (core is stateless).
 const lastDiagnosedAtByEpisode = new Map();
-function normalizedSource(source) {
-    if (source.startsWith('llm_') && source !== 'llm_paralysis') {
-        return 'semantic';
-    }
-    if (!PAIN_DIAGNOSTIC_SOURCES.includes(source)) {
-        SystemLogger.log('', 'GATE_UNKNOWN_SOURCE', `Unknown pain source: "${source}"`);
-    }
-    return source;
-}
-function buildEpisodeKey(input) {
-    const source = normalizedSource(input.source);
-    const sessionId = input.sessionId || 'unknown';
-    const hash = input.errorHash || 'no-hash';
-    return `${sessionId}:${source}:${hash}`;
-}
-function withinCooldown(input, episodeKey) {
-    const cooldownMs = input.cooldownMs ?? DEFAULT_COOLDOWN_MS;
-    if (cooldownMs <= 0)
-        return false;
-    const nowMs = input.nowMs ?? Date.now();
-    const last = lastDiagnosedAtByEpisode.get(episodeKey);
-    return last !== undefined && nowMs - last < cooldownMs;
-}
-function markDiagnosed(input, episodeKey) {
-    lastDiagnosedAtByEpisode.set(episodeKey, input.nowMs ?? Date.now());
-}
 export function resetPainDiagnosticGateForTest() {
     lastDiagnosedAtByEpisode.clear();
 }
@@ -46,60 +30,29 @@ export function resetPainDiagnosticGateForTest() {
  * with the PainDiagnosticGate's cooldown state.
  */
 export function isCooldownActiveForEpisode(source, sessionId, errorHash, cooldownMs) {
-    const episodeKey = buildEpisodeKey({ source, sessionId, errorHash });
-    return withinCooldown({ source, sessionId, errorHash, cooldownMs }, episodeKey);
+    const episodeKey = buildEpisodeKey({ source, sessionId, errorHash, score: 0, currentGfi: 0 });
+    const last = lastDiagnosedAtByEpisode.get(episodeKey);
+    const nowMs = Date.now();
+    return isCooldownActiveCore({ source, sessionId, errorHash, cooldownMs, nowMs, lastDiagnosedAtMs: last });
 }
+/**
+ * Evaluate the pain diagnostic gate. Delegates the pure decision to core and,
+ * when the decision is to diagnose, records the current time against the
+ * episode so subsequent calls within the cooldown window are suppressed.
+ */
 export function evaluatePainDiagnosticGate(input) {
-    const source = normalizedSource(input.source);
-    const episodeKey = buildEpisodeKey(input);
-    const painTrigger = input.thresholds?.painTrigger ?? 40;
-    const highSeverity = input.thresholds?.highSeverity ?? 70;
-    const highGfi = input.thresholds?.highGfi ?? Math.max(highSeverity, painTrigger + 30);
-    const repeatedFailure = input.thresholds?.repeatedFailure ?? 4;
-    const semanticPain = input.thresholds?.semanticPain ?? Math.max(painTrigger, 60);
-    const score = Number.isFinite(input.score) ? input.score : 0;
-    const currentGfi = Number.isFinite(input.currentGfi) ? input.currentGfi : 0;
-    const consecutiveErrors = Number.isFinite(input.consecutiveErrors) ? input.consecutiveErrors : 0;
-    const approve = (reason, detail) => {
-        if (withinCooldown(input, episodeKey)) {
-            return {
-                shouldDiagnose: false,
-                reason: 'cooldown',
-                episodeKey,
-                detail: `recently diagnosed; ${detail}`,
-            };
-        }
-        markDiagnosed(input, episodeKey);
-        return { shouldDiagnose: true, reason, episodeKey, detail };
-    };
-    if (source === 'manual') {
-        return approve('manual', 'manual pain signal bypasses automatic gate');
-    }
-    if (source === 'subagent_error' && score >= painTrigger) {
-        return approve('subagent_error', `subagent error score ${score} >= ${painTrigger}`);
-    }
-    if (source === 'llm_paralysis' && score >= painTrigger) {
-        return approve('llm_paralysis', `llm paralysis score ${score} >= ${painTrigger}`);
-    }
-    if (source === 'gate_blocked' && score >= painTrigger) {
-        return approve('gate_blocked', `gate blocked score ${score} >= ${painTrigger}`);
-    }
-    if ((source === 'user_empathy' || source === 'semantic') && score >= semanticPain) {
-        return approve('semantic_pain', `semantic pain score ${score} >= ${semanticPain}`);
+    // Surface unknown sources via telemetry (core cannot log).
+    const { unknown } = normalizedSource(input.source);
+    if (unknown) {
+        SystemLogger.log('', 'GATE_UNKNOWN_SOURCE', `Unknown pain source: "${input.source}"`);
     }
-    if (input.isRisky === true && score >= highSeverity) {
-        return approve('risky_high_score', `risky operation score ${score} >= ${highSeverity}`);
-    }
-    if (consecutiveErrors >= repeatedFailure) {
-        return approve('repeated_failure', `consecutive errors ${consecutiveErrors} >= ${repeatedFailure}`);
-    }
-    if (currentGfi >= highGfi) {
-        return approve('high_gfi', `GFI ${currentGfi.toFixed(1)} >= ${highGfi}`);
+    const episodeKey = buildEpisodeKey(input);
+    const last = lastDiagnosedAtByEpisode.get(episodeKey);
+    const nowMs = input.nowMs ?? Date.now();
+    const decision = evaluatePainDiagnosticGateDecision({ ...input, nowMs }, last);
+    // Record the diagnosis time when approved (matches prior markDiagnosed behavior).
+    if (decision.shouldDiagnose) {
+        lastDiagnosedAtByEpisode.set(episodeKey, nowMs);
     }
-    return {
-        shouldDiagnose: false,
-        reason: 'below_gate',
-        episodeKey,
-        detail: `score=${score}; gfi=${currentGfi.toFixed(1)}; consecutive=${consecutiveErrors}`,
-    };
+    return decision;
 }

package/dist/hooks/prompt-helpers.d.ts

@@ -0,0 +1,87 @@
+/**
+ * Pure-logic helpers for prompt assembly.
+ *
+ * Extracted from hooks/prompt.ts per PRI-444. These functions contain NO I/O
+ * and NO side effects — they are independently unit-testable.
+ *
+ * I/O helpers (cachedReadFile, loadContextInjectionConfig, resolveEmpathyObserver)
+ * remain in prompt.ts because they depend on module-level cache state and fs.
+ *
+ * Pattern follows after-tool-call-helpers.ts (PRI-326): plugin-internal
+ * decomposition + core pure-function reuse.
+ *
+ * ERR checklist:
+ * EP-01: All unknown inputs use typeof/Object.hasOwn guards, never `as`
+ * EP-03: Pure functions never swallow errors; invalid input returns empty string
+ * EP-09: Pure functions are independently unit-testable without mocks
+ */
+import type { ExtractedUserMessage, CorePrincipleEntry, EvolutionPrincipleEntry, AppendSystemContextParts } from './prompt-types.js';
+/**
+ * Extract the actual user message from the raw prompt text.
+ *
+ * The prompt may contain:
+ * - Boot check messages (system-generated, return empty)
+ * - Feishu wrapper format 1: "Sender (untrusted metadata): ```json {...}```  text"
+ * - Feishu wrapper format 2: "Conversation info (untrusted metadata): ```json {...}```  text"
+ * - Clean user message text
+ *
+ * Also detects empathy observer output (to prevent recursive spawn) and
+ * agent-to-agent messages (to skip empathy evaluation).
+ *
+ * Pure logic — no I/O, no side effects.
+ */
+export declare function extractUserMessageFromPrompt(prompt: string, sessionId: string | undefined): ExtractedUserMessage;
+/**
+ * Build the minimal Agent Identity section for prependSystemContext.
+ *
+ * EvolutionWorker-era INTERNAL SYSTEM LAYOUT removed per PRI-294.
+ * The EVOLUTION_WORKER PathResolver key and system layout reference are
+ * not MVP-Core; agents discover what they need via tool calls.
+ *
+ * Pure logic — returns a constant string.
+ */
+export declare function buildAgentIdentity(): string;
+/**
+ * Build the empathy output restriction constraint text.
+ *
+ * Pure logic — returns a constant string.
+ */
+export declare function buildEmpathySilenceConstraint(): string;
+/**
+ * Wrap heartbeat checklist content in XML tags.
+ *
+ * Pure logic — no I/O, no side effects.
+ */
+export declare function assembleHeartbeatChecklist(content: string): string;
+/**
+ * Format core principles into prompt-ready text.
+ *
+ * Pure logic — uses escapeXml for safe XML embedding.
+ *
+ * @param principles Active principles from evolution reducer
+ * @returns Formatted lines (empty string if no principles)
+ */
+export declare function formatCorePrinciples(principles: CorePrincipleEntry[]): string;
+/**
+ * Format evolution principles (active + probation) into prompt-ready text.
+ *
+ * Pure logic — uses escapeXml for safe XML embedding.
+ *
+ * @param active Active principles (high priority)
+ * @param probation Probation principles (contextual, caution)
+ * @returns Formatted lines (empty string if no principles)
+ */
+export declare function formatEvolutionPrinciples(active: EvolutionPrincipleEntry[], probation: EvolutionPrincipleEntry[]): string;
+/**
+ * Assemble appendSystemContext from ordered parts.
+ *
+ * Content order (most important last):
+ * behavioral_constraints → project_context → working_memory →
+ * thinking_os → evolution_principles → core_principles
+ *
+ * Pure logic — string assembly only, no I/O.
+ *
+ * @param parts Ordered content parts (empty/undefined parts are skipped)
+ * @returns Assembled appendSystemContext (empty string if no parts)
+ */
+export declare function assembleAppendSystemContext(parts: AppendSystemContextParts): string;