prebid.js 9.52.0 → 9.53.2

package/test/spec/modules/raynRtdProvider_spec.js

@@ -222,10 +222,15 @@ describe('rayn RTD Submodule', function () {
   });
 
   describe('Alter Bid Requests', function () {
+    let logMessageSpy;
+    beforeEach(() => {
+      logMessageSpy = sinon.spy(utils, 'logMessage');
+    })
+    afterEach(() => {
+      logMessageSpy.restore();
+    })
     it('should update reqBidsConfigObj and execute callback', function () {
       const callbackSpy = sinon.spy();
-      const logMessageSpy = sinon.spy(utils, 'logMessage');
-
       getDataFromLocalStorageStub
         .withArgs(raynRTD.RAYN_LOCAL_STORAGE_KEY)
         .returns(JSON.stringify(TEST_SEGMENTS));
@@ -235,14 +240,11 @@ describe('rayn RTD Submodule', function () {
       raynRTD.raynSubmodule.getBidRequestData(reqBidsConfigObj, callbackSpy, RTD_CONFIG);
 
       expect(callbackSpy.calledOnce).to.be.true;
-      expect(logMessageSpy.lastCall.lastArg).to.equal(`Segtax data from localStorage: ${JSON.stringify(TEST_SEGMENTS)}`);
-
-      logMessageSpy.restore();
+      sinon.assert.calledWith(logMessageSpy, sinon.match.any, `Segtax data from localStorage: ${JSON.stringify(TEST_SEGMENTS)}`)
     });
 
     it('should update reqBidsConfigObj and execute callback using user segments from localStorage', function () {
       const callbackSpy = sinon.spy();
-      const logMessageSpy = sinon.spy(utils, 'logMessage');
       const testSegments = {
         4: {
           3: ['4', '17', '72', '612']
@@ -267,14 +269,11 @@ describe('rayn RTD Submodule', function () {
       raynRTD.raynSubmodule.getBidRequestData(reqBidsConfigObj, callbackSpy, RTD_CONFIG.dataProviders[0]);
 
       expect(callbackSpy.calledOnce).to.be.true;
-      expect(logMessageSpy.lastCall.lastArg).to.equal(`Segtax data from localStorage: ${JSON.stringify(testSegments)}`);
-
-      logMessageSpy.restore();
+      sinon.assert.calledWith(logMessageSpy, sinon.match.any, `Segtax data from localStorage: ${JSON.stringify(testSegments)}`)
     });
 
     it('should update reqBidsConfigObj and execute callback using persona segment from localStorage', function () {
       const callbackSpy = sinon.spy();
-      const logMessageSpy = sinon.spy(utils, 'logMessage');
       const testSegments = {
         103015: ['agdv23', 'avscg3']
       };
@@ -288,14 +287,11 @@ describe('rayn RTD Submodule', function () {
       raynRTD.raynSubmodule.getBidRequestData(reqBidsConfigObj, callbackSpy, RTD_CONFIG.dataProviders[0]);
 
       expect(callbackSpy.calledOnce).to.be.true;
-      expect(logMessageSpy.lastCall.lastArg).to.equal(`Segtax data from localStorage: ${JSON.stringify(testSegments)}`);
-
-      logMessageSpy.restore();
+      sinon.assert.calledWith(logMessageSpy, sinon.match.any, `Segtax data from localStorage: ${JSON.stringify(testSegments)}`)
     });
 
     it('should update reqBidsConfigObj and execute callback using segments from raynJS', function () {
       const callbackSpy = sinon.spy();
-      const logMessageSpy = sinon.spy(utils, 'logMessage');
 
       getDataFromLocalStorageStub
         .withArgs(raynRTD.RAYN_LOCAL_STORAGE_KEY)
@@ -306,14 +302,11 @@ describe('rayn RTD Submodule', function () {
       raynRTD.raynSubmodule.getBidRequestData(reqBidsConfigObj, callbackSpy, RTD_CONFIG.dataProviders[0]);
 
       expect(callbackSpy.calledOnce).to.be.true;
-      expect(logMessageSpy.lastCall.lastArg).to.equal(`No segtax data`);
-
-      logMessageSpy.restore();
+      sinon.assert.calledWith(logMessageSpy, sinon.match.any, `No segtax data`)
     });
 
     it('should update reqBidsConfigObj and execute callback using audience from localStorage', function (done) {
       const callbackSpy = sinon.spy();
-      const logMessageSpy = sinon.spy(utils, 'logMessage');
       const testSegments = {
         6: {
           4: ['3', '27', '177']
@@ -363,10 +356,13 @@ describe('rayn RTD Submodule', function () {
       raynRTD.raynSubmodule.getBidRequestData(reqBidsConfigObj, callbackSpy, RTD_CONFIG.dataProviders[0]);
 
       setTimeout(() => {
-        expect(callbackSpy.calledOnce).to.be.true;
-        expect(logErrorSpy.lastCall.lastArg).to.equal(rejectError);
-        logErrorSpy.restore();
-        done();
+        try {
+          expect(callbackSpy.calledOnce).to.be.true;
+          expect(logErrorSpy.calledWith('RaynJS: ', rejectError)).to.be.true;
+        } finally {
+          logErrorSpy.restore();
+          done();
+        }
       }, 0)
     });
   });

package/test/spec/modules/relevatehealthBidAdapter_spec.js

@@ -22,7 +22,6 @@ describe('relevatehealth adapter', function() {
       },
       params: {
         placement_id: 110011,
-        user_id: '11211',
         width: 160,
         height: 600,
         domain: '',
@@ -82,18 +81,17 @@ describe('relevatehealth adapter', function() {
   });
 
   describe('validations', function() {
-    it('isBidValid : placement_id and user_id are passed', function() {
+    it('isBidValid : placement_id is passed', function() {
       let bid = {
           bidder: 'relevatehealth',
           params: {
-            placement_id: 110011,
-            user_id: '11211'
+            placement_id: 110011
           }
         },
         isValid = spec.isBidRequestValid(bid);
       expect(isValid).to.equals(true);
     });
-    it('isBidValid : placement_id and user_id are not passed', function() {
+    it('isBidValid : placement_id is not passed', function() {
       let bid = {
           bidder: 'relevatehealth',
           params: {
@@ -106,34 +104,6 @@ describe('relevatehealth adapter', function() {
         isValid = spec.isBidRequestValid(bid);
       expect(isValid).to.equals(false);
     });
-    it('isBidValid : placement_id is passed but user_id is not passed', function() {
-      let bid = {
-          bidder: 'relevatehealth',
-          params: {
-            placement_id: 110011,
-            width: 160,
-            height: 600,
-            domain: '',
-            bid_floor: 0.5
-          }
-        },
-        isValid = spec.isBidRequestValid(bid);
-      expect(isValid).to.equals(false);
-    });
-    it('isBidValid : user_id is passed but placement_id is not passed', function() {
-      let bid = {
-          bidder: 'relevatehealth',
-          params: {
-            width: 160,
-            height: 600,
-            domain: '',
-            bid_floor: 0.5,
-            user_id: '11211'
-          }
-        },
-        isValid = spec.isBidRequestValid(bid);
-      expect(isValid).to.equals(false);
-    });
   });
   describe('Validate Request', function() {
     it('Immutable bid request validate', function() {
@@ -172,7 +142,7 @@ describe('relevatehealth adapter', function() {
       };
       let _Request = spec.buildRequests(request, bidRequest);
       let data = JSON.parse(_Request.data);
-      expect(data[0].us_privacy).to.equal('1NYN');
+      expect(data[0].regs.ext.us_privacy).to.equal('1NYN');
     });
   });
   describe('Validate response ', function() {
@@ -206,8 +176,8 @@ describe('relevatehealth adapter', function() {
       };
       let _Request = spec.buildRequests(request, bidderReq);
       let data = JSON.parse(_Request.data);
-      expect(data[0].gpp).to.equal('gpp-string-test');
-      expect(data[0].gpp_sid[0]).to.equal(5);
+      expect(data[0].regs.gpp).to.equal('gpp-string-test');
+      expect(data[0].regs.gpp_sid[0]).to.equal(5);
     });
     it('Request params check with GPP Consent read from ortb2', function() {
       let bidderReq = {
@@ -220,8 +190,8 @@ describe('relevatehealth adapter', function() {
       };
       let _Request = spec.buildRequests(request, bidderReq);
       let data = JSON.parse(_Request.data);
-      expect(data[0].gpp).to.equal('gpp-test-string');
-      expect(data[0].gpp_sid[0]).to.equal(5);
+      expect(data[0].regs.gpp).to.equal('gpp-test-string');
+      expect(data[0].regs.gpp_sid[0]).to.equal(5);
     });
     it(' Bid request should have coppa flag if its true', () => {
       let bidderReq = {
@@ -233,7 +203,7 @@ describe('relevatehealth adapter', function() {
       };
       let _Request = spec.buildRequests(request, bidderReq);
       let data = JSON.parse(_Request.data);
-      expect(data[0].coppa).to.equal(1);
+      expect(data[0].regs.coppa).to.equal(1);
     });
   });
 });

package/test/spec/modules/sharedIdSystem_spec.js

@@ -1,10 +1,10 @@
-import {sharedIdSystemSubmodule, storage} from 'modules/sharedIdSystem.js';
+import {sharedIdSystemSubmodule} from 'modules/sharedIdSystem.js';
 import {config} from 'src/config.js';
 
 import sinon from 'sinon';
 import * as utils from 'src/utils.js';
 import {createEidsArray} from '../../../modules/userId/eids.js';
-import {attachIdSystem, init} from '../../../modules/userId/index.js';
+import {attachIdSystem} from '../../../modules/userId/index.js';
 import {getGlobal} from '../../../src/prebidGlobal.js';
 
 let expect = require('chai').expect;
@@ -117,7 +117,7 @@ describe('SharedId System', function () {
           }]
         }
       });
-      await getGlobal().getUserIdsAsync();
+      await getGlobal().refreshUserIds();
       const eids = getGlobal().getUserIdsAsEids();
       sinon.assert.match(eids[0], {
         source: 'pubcid.org',

package/test/spec/modules/sovrnBidAdapter_spec.js

@@ -763,7 +763,8 @@ describe('sovrnBidAdapter', function() {
       nurl: '',
       adm: '<VAST version="4.2" xmlns:xs="http://www.w3.org/2001/XMLSchema" xmlns="http://www.iab.com/VAST">key%3Dvalue</VAST>',
       h: 480,
-      w: 640
+      w: 640,
+      mtype: 2
     }
     const bannerBid = {
       id: 'a_403370_332fdb9b064040ddbec05891bd13ab28',
@@ -773,7 +774,8 @@ describe('sovrnBidAdapter', function() {
       nurl: '<!-- NURL -->',
       adm: '<!-- Creative -->',
       h: 90,
-      w: 728
+      w: 728,
+      mtype: 1
     }
 
     beforeEach(function () {
@@ -789,6 +791,71 @@ describe('sovrnBidAdapter', function() {
       }
     })
 
+    it('Should return the bid response of correct type when nurl is missing', function () {
+      const expectedResponse = {
+        requestId: '263c448586f5a1',
+        cpm: 0.45882675,
+        width: 728,
+        height: 90,
+        creativeId: 'creativelycreatedcreativecreative',
+        dealId: null,
+        currency: 'USD',
+        netRevenue: true,
+        mediaType: 'banner',
+        ttl: 60000,
+        meta: { advertiserDomains: [] },
+        ad: decodeURIComponent(`<!-- Creative -->`)
+      }
+
+      response = {
+        body: {
+          id: '37386aade21a71',
+          seatbid: [{
+            bid: [{
+              ...bannerBid,
+              nurl: ''
+            }]
+          }]
+        }
+      }
+
+      const result = spec.interpretResponse(response)
+
+      expect(Object.keys(result[0])).to.deep.equal(Object.keys(expectedResponse))
+    })
+
+    it('Should return the bid response of correct type when nurl is present', function () {
+      const expectedResponse = {
+        requestId: '263c448586f5a1',
+        cpm: 0.45882675,
+        width: 728,
+        height: 90,
+        creativeId: 'creativelycreatedcreativecreative',
+        dealId: null,
+        currency: 'USD',
+        netRevenue: true,
+        mediaType: 'banner',
+        ttl: 60000,
+        meta: { advertiserDomains: [] },
+        ad: decodeURIComponent(`<!-- Creative --><img src=<!-- NURL -->>`)
+      }
+
+      response = {
+        body: {
+          id: '37386aade21a71',
+          seatbid: [{
+            bid: [{
+              ...bannerBid
+            }]
+          }]
+        }
+      }
+
+      const result = spec.interpretResponse(response)
+
+      expect(Object.keys(result[0])).to.deep.equal(Object.keys(expectedResponse))
+    })
+
     it('should get the correct bid response', function () {
       const expectedResponse = {
         requestId: '263c448586f5a1',
@@ -1072,7 +1139,8 @@ describe('sovrnBidAdapter', function() {
               nurl: '',
               adm: bidAdm,
               h: 480,
-              w: 640
+              w: 640,
+              mtype: 2
             }]
           }]
         }

package/test/spec/modules/teadsBidAdapter_spec.js

@@ -921,6 +921,7 @@ describe('teadsBidAdapter', () => {
           for (const userId in userIdModules) {
             expect(payload, userId).not.to.have.property(userId);
           }
+          expect(payload['eids']).to.deep.equal([])
         });
 
         it(`should not add param to payload if user id field is absent`, function () {
@@ -930,15 +931,17 @@ describe('teadsBidAdapter', () => {
           for (const userId in userIdModules) {
             expect(payload, userId).not.to.have.property(userId);
           }
+          expect(payload['eids']).to.deep.equal([])
         });
 
         it(`should not add param to payload if user id is enabled but there is no value`, function () {
+          const userIdAsEids = [
+            toEid('idl_env', ''),
+            toEid('pubcid.org', 'publisherFirstPartyViewerId-id')
+          ]
           const bidRequest = {
             ...baseBidRequest,
-            userIdAsEids: [
-              toEid('idl_env', ''),
-              toEid('pubcid.org', 'publisherFirstPartyViewerId-id')
-            ]
+            userIdAsEids
           };
 
           const request = spec.buildRequests([bidRequest], bidderRequestDefault);
@@ -946,6 +949,7 @@ describe('teadsBidAdapter', () => {
 
           expect(payload).not.to.have.property('liveRampId');
           expect(payload['publisherFirstPartyViewerId']).to.equal('publisherFirstPartyViewerId-id');
+          expect(payload['eids']).to.deep.equal(userIdAsEids)
         });
 
         it(`should add userId param to payload for each enabled user id system`, function () {
@@ -970,6 +974,7 @@ describe('teadsBidAdapter', () => {
           expect(payload['publisherFirstPartyViewerId']).to.equal('publisherFirstPartyViewerId-id');
           expect(payload['merkleId']).to.equal('merkleId-id');
           expect(payload['kinessoId']).to.equal('kinessoId-id');
+          expect(payload['eids']).to.deep.equal(Object.values(userIdModules))
         });
       })
 

package/test/spec/modules/ttdBidAdapter_spec.js

@@ -559,7 +559,7 @@ describe('ttdBidAdapter', function () {
       expect(requestBody.source.ext.schain).to.deep.equal(schain);
     });
 
-    it('adds unified ID info to the request', function () {
+    it('no longer uses userId', function () {
       const TDID = '00000000-0000-0000-0000-000000000000';
       let clonedBannerRequests = deepClone(baseBannerBidRequests);
       clonedBannerRequests[0].userId = {
@@ -567,7 +567,7 @@ describe('ttdBidAdapter', function () {
       };
 
       const requestBody = testBuildRequests(clonedBannerRequests, baseBidderRequest).data;
-      expect(requestBody.user.buyeruid).to.equal(TDID);
+      expect(requestBody.user.buyeruid).to.be.undefined;
     });
 
     it('adds unified ID and UID2 info to user.ext.eids in the request', function () {
@@ -601,6 +601,28 @@ describe('ttdBidAdapter', function () {
 
       const requestBody = testBuildRequests(clonedBannerRequests, baseBidderRequest).data;
       expect(requestBody.user.ext.eids).to.deep.equal(expectedEids);
+      expect(requestBody.user.buyeruid).to.equal(TDID);
+    });
+
+    it('has an empty buyeruid if tdid not found in userIdAsEids', function () {
+      const UID2 = '99999999-9999-9999-9999-999999999999';
+      let clonedBannerRequests = deepClone(baseBannerBidRequests);
+      clonedBannerRequests[0].userIdAsEids = [
+        {
+          source: 'uidapi.com',
+          uids: [
+            {
+              atype: 3,
+              id: UID2
+            }
+          ]
+        }
+      ];
+      const expectedEids = clonedBannerRequests[0].userIdAsEids;
+
+      const requestBody = testBuildRequests(clonedBannerRequests, baseBidderRequest).data;
+      expect(requestBody.user.ext.eids).to.deep.equal(expectedEids);
+      expect(requestBody.user.buyeruid).to.be.undefined;
     });
 
     it('adds first party site data to the request', function () {

package/test/spec/modules/uid2IdSystem_helpers.js

@@ -18,10 +18,13 @@ export const runAuction = async () => {
     sizes: [[300, 200], [300, 600]],
     bids: [{bidder: 'sampleBidder', params: {placementId: 'banner-only-bidder'}}]
   }];
+  const ortb2Fragments = {global: {}, bidder: {}};
   return new Promise(function(resolve) {
     startAuctionHook(function() {
-      resolve(adUnits[0].bids[0]);
-    }, {adUnits});
+      const bid = Object.assign({}, adUnits[0].bids[0]);
+      bid.userIdAsEids = (ortb2Fragments.global.user?.ext?.eids ?? []).concat(ortb2Fragments.bidder[bid.bidder]?.user?.ext?.eids ?? []);
+      resolve(bid);
+    }, {adUnits, ortb2Fragments});
   });
 }