prebid.js 9.52.0 → 9.53.2

package/test/spec/modules/id5IdSystem_spec.js

@@ -929,7 +929,7 @@ describe('ID5 ID System', function () {
   });
 
   describe('Request Bids Hook', function () {
-    let adUnits;
+    let adUnits, ortb2Fragments;
     let sandbox;
 
     beforeEach(function () {
@@ -940,6 +940,9 @@ describe('ID5 ID System', function () {
       coreStorage.removeDataFromLocalStorage(`${id5System.ID5_STORAGE_NAME}_last`);
       coreStorage.setDataInLocalStorage(id5System.ID5_STORAGE_NAME + '_cst', getConsentHash());
       adUnits = [getAdUnitMock()];
+      ortb2Fragments = {
+        global: {}
+      }
     });
     afterEach(function () {
       events.getEvents.restore();
@@ -958,24 +961,18 @@ describe('ID5 ID System', function () {
         config.setConfig(getFetchLocalStorageConfig());
 
         startAuctionHook(wrapAsyncExpects(done, () => {
-          adUnits.forEach(unit => {
-            unit.bids.forEach(bid => {
-              expect(bid).to.have.deep.nested.property(`userId.${ID5_EIDS_NAME}`);
-              expect(bid.userId.id5id.uid).is.equal(ID5_STORED_ID);
-              expect(bid.userIdAsEids[0]).is.eql({
-                source: ID5_SOURCE,
-                uids: [{
-                  id: ID5_STORED_ID,
-                  atype: 1,
-                  ext: {
-                    linkType: ID5_STORED_LINK_TYPE
-                  }
-                }]
-              });
-            });
+          expect(ortb2Fragments.global.user.ext.eids[0]).is.eql({
+            source: ID5_SOURCE,
+            uids: [{
+              id: ID5_STORED_ID,
+              atype: 1,
+              ext: {
+                linkType: ID5_STORED_LINK_TYPE
+              }
+            }]
           });
           done();
-        }), {adUnits});
+        }), {ortb2Fragments});
       });
 
       it('should add stored EUID from cache to bids', function (done) {
@@ -986,25 +983,19 @@ describe('ID5 ID System', function () {
         config.setConfig(getFetchLocalStorageConfig());
 
         startAuctionHook(function () {
-          adUnits.forEach(unit => {
-            unit.bids.forEach(bid => {
-              expect(bid).to.have.deep.nested.property(`userId.euid`);
-              expect(bid.userId.euid.uid).is.equal(EUID_STORED_ID);
-              expect(bid.userIdAsEids[0].uids[0].id).is.equal(ID5_STORED_ID);
-              expect(bid.userIdAsEids[1]).is.eql({
-                source: EUID_SOURCE,
-                uids: [{
-                  id: EUID_STORED_ID,
-                  atype: 3,
-                  ext: {
-                    provider: ID5_SOURCE
-                  }
-                }]
-              });
-            });
+          expect(ortb2Fragments.global.user.ext.eids[0].uids[0].id).is.equal(ID5_STORED_ID);
+          expect(ortb2Fragments.global.user.ext.eids[1]).is.eql({
+            source: EUID_SOURCE,
+            uids: [{
+              id: EUID_STORED_ID,
+              atype: 3,
+              ext: {
+                provider: ID5_SOURCE
+              }
+            }]
           });
           done();
-        }, {adUnits});
+        }, {ortb2Fragments});
       });
 
       it('should add stored TRUE_LINK_ID from cache to bids', function (done) {
@@ -1015,21 +1006,15 @@ describe('ID5 ID System', function () {
         config.setConfig(getFetchLocalStorageConfig());
 
         startAuctionHook(wrapAsyncExpects(done, function () {
-          adUnits.forEach(unit => {
-            unit.bids.forEach(bid => {
-              expect(bid).to.have.deep.nested.property(`userId.trueLinkId`);
-              expect(bid.userId.trueLinkId.uid).is.equal(TRUE_LINK_STORED_ID);
-              expect(bid.userIdAsEids[1]).is.eql({
-                source: TRUE_LINK_SOURCE,
-                uids: [{
-                  id: TRUE_LINK_STORED_ID,
-                  atype: 1
-                }]
-              });
-            });
+          expect(ortb2Fragments.global.user.ext.eids[1]).is.eql({
+            source: TRUE_LINK_SOURCE,
+            uids: [{
+              id: TRUE_LINK_STORED_ID,
+              atype: 1
+            }]
           });
           done();
-        }), {adUnits});
+        }), {ortb2Fragments});
       });
     });
 
@@ -1072,25 +1057,16 @@ describe('ID5 ID System', function () {
         config.setConfig(getFetchLocalStorageConfig());
         const id5IdEidUid = IDS_ID5ID.eid.uids[0];
         startAuctionHook(wrapAsyncExpects(done, () => {
-          adUnits.forEach(unit => {
-            unit.bids.forEach(bid => {
-              expect(bid).to.have.deep.nested.property(`userId.${ID5_EIDS_NAME}`);
-              expect(bid.userId.id5id).is.eql({
-                uid: id5IdEidUid.id,
-                ext: id5IdEidUid.ext
-              });
-              expect(bid.userIdAsEids[0]).is.eql({
-                source: IDS_ID5ID.eid.source,
-                uids: [{
-                  id: id5IdEidUid.id,
-                  atype: id5IdEidUid.atype,
-                  ext: id5IdEidUid.ext
-                }]
-              });
-            });
+          expect(ortb2Fragments.global.user.ext.eids[0]).is.eql({
+            source: IDS_ID5ID.eid.source,
+            uids: [{
+              id: id5IdEidUid.id,
+              atype: id5IdEidUid.atype,
+              ext: id5IdEidUid.ext
+            }]
           });
           done();
-        }), {adUnits});
+        }), {ortb2Fragments});
       });
       it('should add stored EUID from cache to bids - from ids', function (done) {
         storeInStorage(id5System.ID5_STORAGE_NAME, JSON.stringify({
@@ -1106,19 +1082,11 @@ describe('ID5 ID System', function () {
         config.setConfig(getFetchLocalStorageConfig());
 
         startAuctionHook(wrapAsyncExpects(done, () => {
-          adUnits.forEach(unit => {
-            unit.bids.forEach(bid => {
-              expect(bid).to.have.deep.nested.property(`userId.euid`);
-              expect(bid.userId.euid).is.eql({
-                uid: IDS_EUID.eid.uids[0].id,
-                ext: IDS_EUID.eid.uids[0].ext
-              });
-              expect(bid.userIdAsEids[0]).is.eql(IDS_ID5ID.eid);
-              expect(bid.userIdAsEids[1]).is.eql(IDS_EUID.eid);
-            });
-          });
+          const eids = ortb2Fragments.global.user.ext.eids;
+          expect(eids[0]).is.eql(IDS_ID5ID.eid);
+          expect(eids[1]).is.eql(IDS_EUID.eid);
           done();
-        }), {adUnits});
+        }), {ortb2Fragments});
       });
 
       it('should add stored TRUE_LINK_ID from cache to bids - from ids', function (done) {
@@ -1135,15 +1103,9 @@ describe('ID5 ID System', function () {
         config.setConfig(getFetchLocalStorageConfig());
 
         startAuctionHook(wrapAsyncExpects(done, function () {
-          adUnits.forEach(unit => {
-            unit.bids.forEach(bid => {
-              expect(bid).to.have.deep.nested.property(`userId.trueLinkId`);
-              expect(bid.userId.trueLinkId.uid).is.eql(IDS_TRUE_LINK_ID.eid.uids[0].id);
-              expect(bid.userIdAsEids[1]).is.eql(IDS_TRUE_LINK_ID.eid);
-            });
-          });
+          expect(ortb2Fragments.global.user.ext.eids[1]).is.eql(IDS_TRUE_LINK_ID.eid);
           done();
-        }), {adUnits});
+        }), {ortb2Fragments});
       });
 
       it('should add other id from cache to bids', function (done) {
@@ -1176,25 +1138,19 @@ describe('ID5 ID System', function () {
         config.setConfig(getFetchLocalStorageConfig());
 
         startAuctionHook(wrapAsyncExpects(done, function () {
-          adUnits.forEach(unit => {
-            unit.bids.forEach(bid => {
-              expect(bid).to.have.deep.nested.property(`userId.otherId`);
-              expect(bid.userId.otherId.uid).is.eql('other-id-value');
-              expect(bid.userIdAsEids[1]).is.eql({
-                source: 'other-id.com',
-                inserter: 'id5-sync.com',
-                uids: [{
-                  id: 'other-id-value',
-                  atype: 2,
-                  ext: {
-                    provider: 'id5-sync.com'
-                  }
-                }]
-              });
-            });
+          expect(ortb2Fragments.global.user.ext.eids[1]).is.eql({
+            source: 'other-id.com',
+            inserter: 'id5-sync.com',
+            uids: [{
+              id: 'other-id-value',
+              atype: 2,
+              ext: {
+                provider: 'id5-sync.com'
+              }
+            }]
           });
           done();
-        }), {adUnits});
+        }), {ortb2Fragments});
       });
     });
   });

package/test/spec/modules/identityLinkIdSystem_spec.js

@@ -31,6 +31,7 @@ describe('IdentityLinkId tests', function () {
     // remove _lr_retry_request cookie before test
     storage.setCookie('_lr_retry_request', 'true', 'Thu, 01 Jan 1970 00:00:01 GMT');
     storage.setCookie('_lr_env', testEnvelope, 'Thu, 01 Jan 1970 00:00:01 GMT');
+    storage.removeDataFromLocalStorage('_lr_env');
   });
 
   afterEach(function () {

package/test/spec/modules/idxIdSystem_spec.js

@@ -1,8 +1,5 @@
-import { expect } from 'chai';
-import { config } from 'src/config.js';
-import { init, startAuctionHook, setSubmoduleRegistry } from 'modules/userId/index.js';
-import { storage, idxIdSubmodule } from 'modules/idxIdSystem.js';
-import {mockGdprConsent} from '../../helpers/consentData.js';
+import {expect} from 'chai';
+import {idxIdSubmodule, storage} from 'modules/idxIdSystem.js';
 import 'src/prebid.js';
 
 const IDX_COOKIE_NAME = '_idx';
@@ -11,32 +8,6 @@ const IDX_COOKIE_STORED = '{ "idx": "' + IDX_DUMMY_VALUE + '" }';
 const ID_COOKIE_OBJECT = { id: IDX_DUMMY_VALUE };
 const IDX_COOKIE_OBJECT = { idx: IDX_DUMMY_VALUE };
 
-function getConfigMock() {
-  return {
-    userSync: {
-      syncDelay: 0,
-      userIds: [{
-        name: 'idx'
-      }]
-    }
-  }
-}
-
-function getAdUnitMock(code = 'adUnit-code') {
-  return {
-    code,
-    mediaTypes: {banner: {}, native: {}},
-    sizes: [
-      [300, 200],
-      [300, 600]
-    ],
-    bids: [{
-      bidder: 'sampleBidder',
-      params: { placementId: 'banner-only-bidder' }
-    }]
-  };
-}
-
 describe('IDx ID System', () => {
   let getDataFromLocalStorageStub, localStorageIsEnabledStub;
   let getCookieStub, cookiesAreEnabledStub;
@@ -83,48 +54,4 @@ describe('IDx ID System', () => {
       expect(idxIdSubmodule.decode(IDX_DUMMY_VALUE)).to.deep.equal(IDX_COOKIE_OBJECT);
     });
   });
-
-  describe('requestBids hook', () => {
-    let adUnits;
-    let sandbox;
-
-    beforeEach(() => {
-      sandbox = sinon.createSandbox();
-      mockGdprConsent(sandbox);
-      adUnits = [getAdUnitMock()];
-      init(config);
-      setSubmoduleRegistry([idxIdSubmodule]);
-      getCookieStub.withArgs(IDX_COOKIE_NAME).returns(IDX_COOKIE_STORED);
-      config.setConfig(getConfigMock());
-    });
-
-    afterEach(() => {
-      sandbox.restore();
-      config.resetConfig();
-    })
-
-    after(() => {
-      init(config);
-    })
-
-    it('when a stored IDx exists it is added to bids', (done) => {
-      startAuctionHook(() => {
-        adUnits.forEach(unit => {
-          unit.bids.forEach(bid => {
-            expect(bid).to.have.deep.nested.property('userId.idx');
-            expect(bid.userId.idx).to.equal(IDX_DUMMY_VALUE);
-            const idxIdAsEid = bid.userIdAsEids.find(e => e.source == 'idx.lat');
-            expect(idxIdAsEid).to.deep.equal({
-              source: 'idx.lat',
-              uids: [{
-                id: IDX_DUMMY_VALUE,
-                atype: 1,
-              }]
-            });
-          });
-        });
-        done();
-      }, { adUnits });
-    });
-  });
 });

package/test/spec/modules/instreamTracking_spec.js

@@ -11,6 +11,7 @@ const VIDEO_CACHE_KEY = '4cf395af-8fee-4960-af0e-88d44e399f14';
 
 let sandbox;
 
+let clock;
 function enableInstreamTracking(regex) {
   let configStub = sandbox.stub(config, 'getConfig');
   configStub.withArgs('instreamTracking').returns(Object.assign(
@@ -147,10 +148,12 @@ function getMockInput(mediaType) {
 describe('Instream Tracking', function () {
   beforeEach(function () {
     sandbox = sinon.createSandbox();
+    clock = sandbox.useFakeTimers();
   });
 
   afterEach(function () {
     sandbox.restore();
+    clock.restore();
   });
 
   describe('gaurd checks', function () {
@@ -168,13 +171,13 @@ describe('Instream Tracking', function () {
       assert.isNotOk(trackInstreamDeliveredImpressions({adUnits: [], bidsReceived: [], bidderRequests: []}));
     });
 
-    it('checks for instream bids', function (done) {
+    it('checks for instream bids', function () {
       enableInstreamTracking();
       assert.isNotOk(trackInstreamDeliveredImpressions(getMockInput('banner')), 'should not start tracking when banner bids are present')
       assert.isNotOk(trackInstreamDeliveredImpressions(getMockInput(OUTSTREAM)), 'should not start tracking when outstream bids are present')
       mockPerformanceApi({});
       assert.isOk(trackInstreamDeliveredImpressions(getMockInput(INSTREAM)), 'should start tracking when instream bids are present')
-      setTimeout(done, 10);
+      clock.tick(10);
     });
   });
 
@@ -185,37 +188,31 @@ describe('Instream Tracking', function () {
       spyEventsOn = sandbox.spy(events, 'emit');
     });
 
-    it('BID WON event is not emitted when no video cache key entries are present', function (done) {
+    it('BID WON event is not emitted when no video cache key entries are present', function () {
       enableInstreamTracking();
       trackInstreamDeliveredImpressions(getMockInput(INSTREAM));
       mockPerformanceApi({});
-      setTimeout(function () {
-        assert.isNotOk(spyEventsOn.calledWith('bidWon'))
-        done()
-      }, 10);
+      clock.tick(10);
+      assert.isNotOk(spyEventsOn.calledWith('bidWon'));
     });
 
-    it('BID WON event is not emitted when ad server call is sent', function (done) {
+    it('BID WON event is not emitted when ad server call is sent', function () {
       enableInstreamTracking();
       mockPerformanceApi({adServerCallSent: true});
-      setTimeout(function () {
-        assert.isNotOk(spyEventsOn.calledWith('bidWon'))
-        done()
-      }, 10);
+      clock.tick(10);
+      assert.isNotOk(spyEventsOn.calledWith('bidWon'));
     });
 
-    it('BID WON event is emitted when video cache key is present', function (done) {
+    it('BID WON event is emitted when video cache key is present', function () {
       enableInstreamTracking(/cache/);
       const bidWonSpy = sandbox.spy();
       events.on('bidWon', bidWonSpy);
       mockPerformanceApi({adServerCallSent: true, videoPresent: true});
 
       trackInstreamDeliveredImpressions(getMockInput(INSTREAM));
-      setTimeout(function () {
-        assert.isOk(spyEventsOn.calledWith('bidWon'))
-        assert(bidWonSpy.args[0][0].videoCacheKey, VIDEO_CACHE_KEY, 'Video cache key in bid won should be equal to video cache call');
-        done()
-      }, 10);
+      clock.tick(10);
+      assert.isOk(spyEventsOn.calledWith('bidWon'));
+      assert(bidWonSpy.args[0][0].videoCacheKey, VIDEO_CACHE_KEY, 'Video cache key in bid won should be equal to video cache call');
     });
   });
 });

package/test/spec/modules/ixBidAdapter_spec.js

@@ -5432,6 +5432,32 @@ describe('IndexexchangeAdapter', function () {
       expect(payload.device.ip).to.be.undefined;
       expect(payload.device.ip6).to.be.undefined;
     });
+
+    it('should add device.geo if available in fpd', () => {
+      const ortb2 = {
+        device: {
+          geo: {
+            lat: 1,
+            lon: 2,
+            lastfix: 1,
+            type: 1
+          }
+        }
+      };
+      const request = spec.buildRequests(DEFAULT_BANNER_VALID_BID, { ortb2 })[0];
+      const payload = extractPayload(request);
+      expect(payload.device.geo.lat).to.equal(1);
+      expect(payload.device.geo.lon).to.equal(2);
+      expect(payload.device.geo.lastfix).to.equal(1);
+      expect(payload.device.geo.type).to.equal(1);
+    });
+
+    it('should not add device.geo if it does not exist', () => {
+      const ortb2 = {device: {}};
+      const request = spec.buildRequests(DEFAULT_BANNER_VALID_BID, { ortb2 })[0];
+      const payload = extractPayload(request);
+      expect(payload.device.geo).to.be.undefined;
+    });
   });
 
   describe('fetch requests', function () {