prebid.js 9.46.0 → 9.48.0

package/test/spec/modules/videoModule/submodules/videojsVideoProvider_spec.js

@@ -175,7 +175,7 @@ describe('videojsProvider', function () {
       expect(video.mimes).to.include(VPAID_MIME_TYPE);
     });
     //
-    // We can't determine what type of outstream play is occuring
+    // We can't determine what type of outstream play is occurring
     // if the src is absent so we should not set placement
     it('should not set placement when src is absent', function() {
       document.body.innerHTML = `<video preload id='test' width="${200}" height="${100}"></video>`

package/test/spec/modules/yieldmoBidAdapter_spec.js

@@ -332,7 +332,7 @@ describe('YieldmoAdapter', function () {
       });
 
       it('should not exceed max url length', () => {
-        const longString = new Array(8000).join('a');
+        const longString = Array(8000).join('a');
         const localWindow = utils.getWindowTop();
 
         const originalTitle = localWindow.document.title;
@@ -356,7 +356,7 @@ describe('YieldmoAdapter', function () {
       });
 
       it('should only shortcut properties rather then completely remove it', () => {
-        const longString = new Array(8000).join('a');
+        const longString = Array(8000).join('a');
         const localWindow = utils.getWindowTop();
 
         const originalTitle = localWindow.document.title;

package/test/spec/modules/zeotapIdPlusIdSystem_spec.js

@@ -1,5 +1,4 @@
 import { expect } from 'chai';
-import {find} from 'src/polyfill.js';
 import { config } from 'src/config.js';
 import {attachIdSystem, init, startAuctionHook, setSubmoduleRegistry} from 'modules/userId/index.js';
 import { storage, getStorage, zeotapIdPlusSubmodule } from 'modules/zeotapIdPlusIdSystem.js';
@@ -181,7 +180,7 @@ describe('Zeotap ID System', function() {
           unit.bids.forEach(bid => {
             expect(bid).to.have.deep.nested.property('userId.IDP');
             expect(bid.userId.IDP).to.equal(ZEOTAP_COOKIE);
-            const zeotapIdAsEid = find(bid.userIdAsEids, e => e.source == 'zeotap.com');
+            const zeotapIdAsEid = bid.userIdAsEids.find(e => e.source == 'zeotap.com');
             expect(zeotapIdAsEid).to.deep.equal({
               source: 'zeotap.com',
               uids: [{

package/test/spec/unit/core/adapterManager_spec.js

@@ -18,7 +18,6 @@ import * as utils from 'src/utils.js';
 import { config } from 'src/config.js';
 import { registerBidder } from 'src/adapters/bidderFactory.js';
 import { setSizeConfig } from 'modules/sizeMapping.js';
-import {find, includes} from 'src/polyfill.js';
 import s2sTesting from 'modules/s2sTesting.js';
 import {hook} from '../../../../src/hook.js';
 import {auctionManager} from '../../../../src/auctionManager.js';
@@ -227,7 +226,7 @@ describe('adapterManager tests', function () {
 
     it('should give bidders access to bidder-specific config', function(done) {
       let mockBidders = ['rubicon', 'appnexus', 'pubmatic'];
-      let bidderRequest = getBidRequests().filter(bidRequest => includes(mockBidders, bidRequest.bidderCode));
+      let bidderRequest = getBidRequests().filter(bidRequest => mockBidders.includes(bidRequest.bidderCode));
       let adUnits = getAdUnits();
 
       let bidders = {};
@@ -517,7 +516,7 @@ describe('adapterManager tests', function () {
 
     it('should call spec\'s onBidderError callback when callBidderError is called', function () {
       const bidRequests = getBidRequests();
-      const bidderRequest = find(bidRequests, bidRequest => bidRequest.bidderCode === bidder);
+      const bidderRequest = bidRequests.find(bidRequest => bidRequest.bidderCode === bidder);
       const xhrErrorMock = {
         status: 500,
         statusText: 'Internal Server Error'
@@ -729,7 +728,7 @@ describe('adapterManager tests', function () {
 
       it('should fire for s2s requests', function () {
         let adUnits = utils.deepClone(getAdUnits()).map(adUnit => {
-          adUnit.bids = adUnit.bids.filter(bid => includes(['appnexus'], bid.bidder));
+          adUnit.bids = adUnit.bids.filter(bid => ['appnexus'].includes(bid.bidder));
           return adUnit;
         })
         let bidRequests = adapterManager.makeBidRequests(adUnits, 1111, 2222, 1000);
@@ -741,7 +740,7 @@ describe('adapterManager tests', function () {
       it('should fire for simultaneous s2s and client requests', function () {
         adapterManager.bidderRegistry['adequant'] = adequantAdapterMock;
         let adUnits = utils.deepClone(getAdUnits()).map(adUnit => {
-          adUnit.bids = adUnit.bids.filter(bid => includes(['adequant', 'appnexus'], bid.bidder));
+          adUnit.bids = adUnit.bids.filter(bid => ['adequant', 'appnexus'].includes(bid.bidder));
           return adUnit;
         })
         let bidRequests = adapterManager.makeBidRequests(adUnits, 1111, 2222, 1000);
@@ -1119,7 +1118,7 @@ describe('adapterManager tests', function () {
 
       it('should fire for s2s requests', function () {
         let adUnits = utils.deepClone(getAdUnits()).map(adUnit => {
-          adUnit.bids = adUnit.bids.filter(bid => includes(['appnexus', 'pubmatic'], bid.bidder));
+          adUnit.bids = adUnit.bids.filter(bid => ['appnexus', 'pubmatic'].includes(bid.bidder));
           return adUnit;
         })
         let bidRequests = adapterManager.makeBidRequests(adUnits, 1111, 2222, 1000);
@@ -1130,7 +1129,7 @@ describe('adapterManager tests', function () {
 
       it('should have one tid for ALL s2s bidRequests', function () {
         let adUnits = utils.deepClone(getAdUnits()).map(adUnit => {
-          adUnit.bids = adUnit.bids.filter(bid => includes(['appnexus', 'pubmatic'], bid.bidder));
+          adUnit.bids = adUnit.bids.filter(bid => ['appnexus', 'pubmatic'].includes(bid.bidder));
           return adUnit;
         })
         let bidRequests = adapterManager.makeBidRequests(adUnits, 1111, 2222, 1000);
@@ -1146,7 +1145,7 @@ describe('adapterManager tests', function () {
       it('should fire for simultaneous s2s and client requests', function () {
         adapterManager.bidderRegistry['adequant'] = adequantAdapterMock;
         let adUnits = utils.deepClone(getAdUnits()).map(adUnit => {
-          adUnit.bids = adUnit.bids.filter(bid => includes(['adequant', 'appnexus', 'pubmatic'], bid.bidder));
+          adUnit.bids = adUnit.bids.filter(bid => ['adequant', 'appnexus', 'pubmatic'].includes(bid.bidder));
           return adUnit;
         })
         let bidRequests = adapterManager.makeBidRequests(adUnits, 1111, 2222, 1000);
@@ -1168,7 +1167,7 @@ describe('adapterManager tests', function () {
       // copy adUnits
       // return JSON.parse(JSON.stringify(getAdUnits()));
       return utils.deepClone(getAdUnits()).map(adUnit => {
-        adUnit.bids = adUnit.bids.filter(bid => includes(['adequant', 'appnexus', 'rubicon'], bid.bidder));
+        adUnit.bids = adUnit.bids.filter(bid => ['adequant', 'appnexus', 'rubicon'].includes(bid.bidder));
         return adUnit;
       })
     }
@@ -1351,8 +1350,7 @@ describe('adapterManager tests', function () {
       // copy adUnits
       return utils.deepClone(getAdUnits()).map(adUnit => {
         adUnit.bids = adUnit.bids.filter(bid => {
-          return includes(['adequant', 'appnexus', 'pubmatic', 'rubicon'],
-            bid.bidder);
+          return ['adequant', 'appnexus', 'pubmatic', 'rubicon'].includes(bid.bidder);
         });
         return adUnit;
       })
@@ -1768,7 +1766,7 @@ describe('adapterManager tests', function () {
     beforeEach(function () {
       resetAdUnitCounters();
       adUnits = utils.deepClone(getAdUnits()).map(adUnit => {
-        adUnit.bids = adUnit.bids.filter(bid => includes(['appnexus', 'rubicon'], bid.bidder));
+        adUnit.bids = adUnit.bids.filter(bid => ['appnexus', 'rubicon'].includes(bid.bidder));
         return adUnit;
       })
       twinAdUnits = getTwinAdUnits();
@@ -2086,6 +2084,20 @@ describe('adapterManager tests', function () {
       requests.appnexus.bids.forEach((bid) => expect(bid.ortb2).to.eql(requests.appnexus.ortb2));
     });
 
+    it('should move user.eids into user.ext.eids', () => {
+      const global = {
+        user: {
+          eids: [{source: 'idA'}],
+          ext: {eids: [{source: 'idB'}]}
+        }
+      };
+      const reqs = adapterManager.makeBidRequests(adUnits, 123, 'auction-id', 123, [], {global});
+      reqs.forEach(req => {
+        expect(req.ortb2.user.ext.eids).to.deep.equal([{source: 'idB'}, {source: 'idA'}]);
+        expect(req.ortb2.user.eids).to.not.exist;
+      });
+    });
+
     describe('source.tid', () => {
       beforeEach(() => {
         sinon.stub(dep, 'redact').returns({
@@ -2333,14 +2345,14 @@ describe('adapterManager tests', function () {
         );
 
         expect(bidRequests.length).to.equal(2);
-        let rubiconBidRequests = find(bidRequests, bidRequest => bidRequest.bidderCode === 'rubicon');
+        let rubiconBidRequests = bidRequests.find(bidRequest => bidRequest.bidderCode === 'rubicon');
         expect(rubiconBidRequests.bids.length).to.equal(1);
-        expect(rubiconBidRequests.bids[0].mediaTypes).to.deep.equal(find(adUnits, adUnit => adUnit.code === rubiconBidRequests.bids[0].adUnitCode).mediaTypes);
+        expect(rubiconBidRequests.bids[0].mediaTypes).to.deep.equal(adUnits.find(adUnit => adUnit.code === rubiconBidRequests.bids[0].adUnitCode).mediaTypes);
 
-        let appnexusBidRequests = find(bidRequests, bidRequest => bidRequest.bidderCode === 'appnexus');
+        let appnexusBidRequests = bidRequests.find(bidRequest => bidRequest.bidderCode === 'appnexus');
         expect(appnexusBidRequests.bids.length).to.equal(2);
-        expect(appnexusBidRequests.bids[0].mediaTypes).to.deep.equal(find(adUnits, adUnit => adUnit.code === appnexusBidRequests.bids[0].adUnitCode).mediaTypes);
-        expect(appnexusBidRequests.bids[1].mediaTypes).to.deep.equal(find(adUnits, adUnit => adUnit.code === appnexusBidRequests.bids[1].adUnitCode).mediaTypes);
+        expect(appnexusBidRequests.bids[0].mediaTypes).to.deep.equal(adUnits.find(adUnit => adUnit.code === appnexusBidRequests.bids[0].adUnitCode).mediaTypes);
+        expect(appnexusBidRequests.bids[1].mediaTypes).to.deep.equal(adUnits.find(adUnit => adUnit.code === appnexusBidRequests.bids[1].adUnitCode).mediaTypes);
       });
 
       it('should not filter native bids', function () {

package/test/spec/unit/core/targeting_spec.js

@@ -661,7 +661,7 @@ describe('targeting tests', function () {
           .filter((bid) => bid.adserverTargeting[key] != null)
           .map((bid) => bid.bidderCode)
           .forEach((code) => keys.add(`${key}_${code}`.substr(0, 20)));
-        return new Array(...keys);
+        return [...keys];
       }
 
       const targetingResult = function () {

package/test/spec/unit/pbjs_api_spec.js

@@ -15,7 +15,6 @@ import * as ajaxLib from 'src/ajax.js';
 import * as auctionModule from 'src/auction.js';
 import {resetAuctionState} from 'src/auction.js';
 import {registerBidder} from 'src/adapters/bidderFactory.js';
-import {find} from 'src/polyfill.js';
 import * as pbjsModule from 'src/prebid.js';
 import $$PREBID_GLOBAL$$, {startAuction} from 'src/prebid.js';
 import {hook} from '../../../src/hook.js';
@@ -1006,7 +1005,7 @@ describe('Unit: Prebid Module', function () {
 
   describe('setTargetingForGPTAsync', function () {
     let logErrorSpy;
-    let targeting; 
+    let targeting;
 
     beforeEach(function () {
       logErrorSpy = sinon.spy(utils, 'logError');
@@ -1023,7 +1022,7 @@ describe('Unit: Prebid Module', function () {
       window.googletag.pubads().setSlots(slots);
       $$PREBID_GLOBAL$$.setTargetingForGPTAsync([config.adUnitCodes[0]]);
 
-      
+
       slots.forEach(function(slot) {
         targeting = {};
         slot.getTargetingKeys().map(function (key) {
@@ -3704,7 +3703,7 @@ describe('Unit: Prebid Module', function () {
         winningBid = targeting.getWinningBids(adUnitCode)[0];
         auction.getAuctionId = function() { return winningBid.auctionId };
         sandbox.stub(events, 'emit');
-        markedBid = find($$PREBID_GLOBAL$$.getBidResponsesForAdUnitCode(adUnitCode).bids,
+        markedBid = $$PREBID_GLOBAL$$.getBidResponsesForAdUnitCode(adUnitCode).bids.find(
           bid => bid.adId === winningBid.adId);
       })
 
@@ -3756,7 +3755,7 @@ describe('Unit: Prebid Module', function () {
 
       it('try and mark the bid object, but fail because we supplied the wrong adId', function () {
         $$PREBID_GLOBAL$$.markWinningBidAsUsed({ adUnitCode, adId: 'miss' });
-        const markedBid = find($$PREBID_GLOBAL$$.getBidResponsesForAdUnitCode(adUnitCode).bids,
+        const markedBid = $$PREBID_GLOBAL$$.getBidResponsesForAdUnitCode(adUnitCode).bids.find(
           bid => bid.adId === winningBid.adId);
 
         expect(markedBid.status).to.not.equal(BID_STATUS.RENDERED);

package/test/spec/utils_spec.js

@@ -882,22 +882,30 @@ describe('Utils', function () {
   });
 
   describe('insertElement', function () {
+    let doc;
+
+    beforeEach(function () {
+      doc = document.implementation.createHTMLDocument('insertElementTest');
+    });
+
     it('returns a node at the top of the target by default', function () {
-      const toInsert = document.createElement('div');
-      const target = document.getElementsByTagName('body')[0];
-      const inserted = utils.insertElement(toInsert, document, 'body');
+      const toInsert = doc.createElement('div');
+      const target = doc.getElementsByTagName('body')[0];
+      const inserted = utils.insertElement(toInsert, doc, 'body');
       expect(inserted).to.equal(target.firstChild);
     });
+
     it('returns a node at bottom of target if 4th argument is true', function () {
-      const toInsert = document.createElement('div');
-      const target = document.getElementsByTagName('html')[0];
-      const inserted = utils.insertElement(toInsert, document, 'html', true);
+      const toInsert = doc.createElement('div');
+      const target = doc.getElementsByTagName('html')[0];
+      const inserted = utils.insertElement(toInsert, doc, 'html', true);
       expect(inserted).to.equal(target.lastChild);
     });
+
     it('returns a node at top of the head if no target is given', function () {
-      const toInsert = document.createElement('div');
-      const target = document.getElementsByTagName('head')[0];
-      const inserted = utils.insertElement(toInsert);
+      const toInsert = doc.createElement('div');
+      const target = doc.getElementsByTagName('head')[0];
+      const inserted = utils.insertElement(toInsert, doc);
       expect(inserted).to.equal(target.firstChild);
     });
   });
@@ -1325,16 +1333,16 @@ describe('Utils', function () {
     it('should compress data correctly when CompressionStream is available', async () => {
       const data = JSON.stringify({ test: 'data' });
       const compressedData = await utils.compressDataWithGZip(data);
-  
+
       expect(compressedData).to.be.instanceOf(Uint8Array);
       expect(compressedData.length).to.be.greaterThan(0);
       expect(compressedData).to.deep.equal(new Uint8Array([1, 2, 3, 4]));
     });
-  
+
     it('should handle non-string input by stringifying it', async () => {
       const nonStringData = { test: 'data' };
       const compressedData = await utils.compressDataWithGZip(nonStringData);
-  
+
       expect(compressedData).to.be.instanceOf(Uint8Array);
       expect(compressedData.length).to.be.greaterThan(0);
       expect(compressedData).to.deep.equal(new Uint8Array([1, 2, 3, 4]));

package/test/test_deps.js

@@ -21,7 +21,7 @@ window.addEventListener('error', function (ev) {
 })
 
 window.addEventListener('unhandledrejection', function (ev) {
-  // this message is used for counting intentional failures created in the tests 
+  // this message is used for counting intentional failures created in the tests
   if (ev.reason === 'pending failure') return;
   // eslint-disable-next-line no-console
   console.error('Unhandled rejection:', ev.reason);

package/nightwatch.browserstack.json

@@ -1,46 +0,0 @@
-{
-  "src_folders": ["./test/spec/e2e"],
-  "output_folder": "./build/coverage/e2e/reports",
-  "custom_commands_path": "",
-  "custom_assertions_path": "",
-  "page_objects_path": "",
-  "globals_path": "",
-
-  "selenium" : {
-    "start_process" : false,
-    "host" : "hub.browserstack.com",
-    "port" : 80
-  },
-
-  "test_settings": {
-    "default": {
-      "launch_url" : "http://hub.browserstack.com",
-      "selenium_port"  : 80,
-      "selenium_host"  : "hub.browserstack.com",
-      "silent": true,
-      "exclude":["custom-assertions","custom-commands","common","custom-reporter"],
-      "screenshots" : {
-        "enabled" : false,
-        "path" : ""
-      },
-      "desiredCapabilities": {
-        "browserName": "chrome",
-        "browser_version" : "51.0",
-        "platform" : "WINDOWS",
-
-        "javascriptEnabled": true,
-        "acceptSslCerts": true,
-
-        "os" : "WINDOWS",
-        "os_version" : "7",
-        "browser" : "Chrome",
-        "browser_version" : "51.0",
-        "browserstack.local": true,
-        "browserstack.debug": true,
-        "browserstack.selenium_version" : "2.53.0",
-        "browserstack.user": "${BROWSERSTACK_USERNAME}",
-        "browserstack.key": "${BROWSERSTACK_KEY}"
-      }
-    }
-  }
-}

package/nightwatch.conf.js

@@ -1,36 +0,0 @@
-module.exports = (function(settings) {
-  var browsers = require('./browsers.json');
-  delete browsers['bs_ie_9_windows_7'];
-
-  for (var browser in browsers) {
-    if (browsers[browser].browser === 'iphone') continue;
-
-    var desiredCapabilities = {
-      'browserName': browsers[browser].browser,
-      'version': browsers[browser].browser_version,
-      'platform': browsers[browser].os,
-      'os': browsers[browser].os,
-      'os_version': browsers[browser].os_version,
-      'browser': browsers[browser].browser,
-      'browser_version': browsers[browser].browser_version,
-    };
-
-    settings.test_settings[browser] = {
-      'silent': true,
-      'exclude': ['custom-assertions', 'custom-commands', 'common', 'custom-reporter'],
-      'screenshots': {
-        'enabled': false,
-        'path': ''
-      },
-      'javascriptEnabled': true,
-      'acceptSslCerts': true,
-      'browserstack.local': true,
-      'browserstack.debug': true,
-      'browserstack.selenium_version': '2.53.0',
-      'browserstack.user': `${BROWSERSTACK_USERNAME}`,
-      'browserstack.key': `${BROWSERSTACK_KEY}`
-    };
-    settings.test_settings[browser]['desiredCapabilities'] = desiredCapabilities;
-  }
-  return settings;
-})(require('./nightwatch.browserstack.json'));

package/nightwatch.json

@@ -1,40 +0,0 @@
-{
-  "src_folders": ["./test/spec/e2e"],
-  "output_folder": "./build/coverage/e2e/reports",
-  "custom_commands_path" : "",
-  "custom_assertions_path" : "./test/spec/e2e/custom-assertions",
-  "page_objects_path" : "",
-  "globals_path" : "",
-  "end_session_on_fail" : true,
-  "skip_testcases_on_fail" : false,
-
-  "selenium" : {
-    "start_process" : true,
-    "server_path" : "${SELENIUM_JAR_PATH}",
-    "log_path" : "",
-    "host" : "127.0.0.1",
-    "port" : 4444,
-    "cli_args" : {
-      "webdriver.ie.driver" : ""
-    }
-  },
-
-  "test_settings" : {
-    "default" : {
-      "launch_url" : "http://localhost",
-      "selenium_port"  : 4444,
-      "selenium_host"  : "localhost",
-      "silent": true,
-      "exclude":["custom-assertions","custom-commands","common","custom-reporter"],
-      "screenshots" : {
-        "enabled" : false,
-        "path" : ""
-      },
-      "desiredCapabilities": {
-        "browserName": "firefox",
-        "javascriptEnabled": true,
-        "acceptSslCerts": true
-      }
-    }
-  }
-}