prebid.js 9.46.0 → 9.48.0

package/test/spec/modules/conversantBidAdapter_spec.js

@@ -1,7 +1,6 @@
 import {expect} from 'chai';
-import {spec, storage} from 'modules/conversantBidAdapter.js';
+import {spec} from 'modules/conversantBidAdapter.js';
 import * as utils from 'src/utils.js';
-import {createEidsArray} from 'modules/userId/eids.js';
 import {deepAccess} from 'src/utils';
 // load modules that register ORTB processors
 import 'src/prebid.js'
@@ -592,35 +591,6 @@ describe('Conversant adapter tests', function() {
     }
   })
 
-  it('Verify publisher commond id support', function() {
-    // clone bidRequests
-    let requests = utils.deepClone(bidRequests);
-
-    // add pubcid to every entry
-    requests.forEach((unit) => {
-      Object.assign(unit, {crumbs: {pubcid: 12345}});
-    });
-    //  construct http post payload
-    const payload = spec.buildRequests(requests, {}).data;
-    expect(payload).to.have.deep.nested.property('user.ext.fpc', 12345);
-    expect(payload).to.not.have.nested.property('user.ext.eids');
-  });
-
-  it('Verify User ID publisher commond id support', function() {
-    // clone bidRequests
-    let requests = utils.deepClone(bidRequests);
-
-    // add pubcid to every entry
-    requests.forEach((unit) => {
-      Object.assign(unit, {userId: {pubcid: 67890}});
-      Object.assign(unit, {userIdAsEids: createEidsArray(unit.userId)});
-    });
-    //  construct http post payload
-    const payload = spec.buildRequests(requests, {}).data;
-    expect(payload).to.have.deep.nested.property('user.ext.fpc', 67890);
-    expect(payload).to.not.have.nested.property('user.ext.eids');
-  });
-
   describe('Extended ID', function() {
     it('Verify unifiedid and liveramp', function() {
       // clone bidRequests
@@ -637,114 +607,6 @@ describe('Conversant adapter tests', function() {
     });
   });
 
-  describe('direct reading pubcid', function() {
-    const ID_NAME = '_pubcid';
-    const CUSTOM_ID_NAME = 'myid';
-    const EXP = '_exp';
-    const TIMEOUT = 2000;
-
-    function cleanUp(key) {
-      window.document.cookie = key + '=; expires=Thu, 01 Jan 1970 00:00:01 GMT;';
-      localStorage.removeItem(key);
-      localStorage.removeItem(key + EXP);
-    }
-
-    function expStr(timeout) {
-      return (new Date(Date.now() + timeout * 60 * 60 * 24 * 1000)).toUTCString();
-    }
-
-    beforeEach(() => {
-      $$PREBID_GLOBAL$$.bidderSettings = {
-        conversant: {
-          storageAllowed: true
-        }
-      };
-    });
-    afterEach(() => {
-      $$PREBID_GLOBAL$$.bidderSettings = {};
-      cleanUp(ID_NAME);
-      cleanUp(CUSTOM_ID_NAME);
-    });
-
-    it('reading cookie', function() {
-      // clone bidRequests
-      const requests = utils.deepClone(bidRequests);
-
-      // add a pubcid cookie
-      storage.setCookie(ID_NAME, '12345', expStr(TIMEOUT));
-
-      //  construct http post payload
-      const payload = spec.buildRequests(requests, {}).data;
-      expect(payload).to.have.deep.nested.property('user.ext.fpc', '12345');
-    });
-
-    it('reading custom cookie', function() {
-      // clone bidRequests
-      const requests = utils.deepClone(bidRequests);
-      requests[0].params.pubcid_name = CUSTOM_ID_NAME;
-
-      // add a pubcid cookie
-      storage.setCookie(CUSTOM_ID_NAME, '12345', expStr(TIMEOUT));
-
-      //  construct http post payload
-      const payload = spec.buildRequests(requests, {}).data;
-      expect(payload).to.have.deep.nested.property('user.ext.fpc', '12345');
-    });
-
-    it('reading local storage with empty exp time', function() {
-      // clone bidRequests
-      const requests = utils.deepClone(bidRequests);
-
-      // add a pubcid in local storage
-      storage.setDataInLocalStorage(ID_NAME + EXP, '');
-      storage.setDataInLocalStorage(ID_NAME, 'abcde');
-
-      //  construct http post payload
-      const payload = spec.buildRequests(requests, {}).data;
-      expect(payload).to.have.deep.nested.property('user.ext.fpc', 'abcde');
-    });
-
-    it('reading local storage with valid exp time', function() {
-      // clone bidRequests
-      const requests = utils.deepClone(bidRequests);
-
-      // add a pubcid in local storage
-      storage.setDataInLocalStorage(ID_NAME + EXP, expStr(TIMEOUT));
-      storage.setDataInLocalStorage(ID_NAME, 'fghijk');
-
-      //  construct http post payload
-      const payload = spec.buildRequests(requests, {}).data;
-      expect(payload).to.have.deep.nested.property('user.ext.fpc', 'fghijk');
-    });
-
-    it('reading expired local storage', function() {
-      // clone bidRequests
-      const requests = utils.deepClone(bidRequests);
-
-      // add a pubcid in local storage
-      storage.setDataInLocalStorage(ID_NAME + EXP, expStr(-TIMEOUT));
-      storage.setDataInLocalStorage(ID_NAME, 'lmnopq');
-
-      //  construct http post payload
-      const payload = spec.buildRequests(requests, {}).data;
-      expect(payload).to.not.have.deep.nested.property('user.ext.fpc');
-    });
-
-    it('reading local storage with custom name', function() {
-      // clone bidRequests
-      const requests = utils.deepClone(bidRequests);
-      requests[0].params.pubcid_name = CUSTOM_ID_NAME;
-
-      // add a pubcid in local storage
-      storage.setDataInLocalStorage(CUSTOM_ID_NAME + EXP, expStr(TIMEOUT));
-      storage.setDataInLocalStorage(CUSTOM_ID_NAME, 'fghijk');
-
-      //  construct http post payload
-      const payload = spec.buildRequests(requests, {}).data;
-      expect(payload).to.have.deep.nested.property('user.ext.fpc', 'fghijk');
-    });
-  });
-
   describe('price floor module', function() {
     let bidRequest;
     beforeEach(function() {

package/test/spec/modules/cwireBidAdapter_spec.js

@@ -333,7 +333,7 @@ describe('C-WIRE bid adapter', () => {
       const userSyncs = spec.getUserSyncs(synOptions, {}, gdprConsent, {});
 
       expect(userSyncs[0].type).to.equal('image');
-      expect(userSyncs[0].url).to.equal('https://ib.adnxs.com/getuid?https://prebid.cwi.re/v1/cookiesync?xandrId=$UID&gdpr=0&gdpr_consent=testConsentString');    
+      expect(userSyncs[0].url).to.equal('https://ib.adnxs.com/getuid?https://prebid.cwi.re/v1/cookiesync?xandrId=$UID&gdpr=0&gdpr_consent=testConsentString');
     })
 
     it('user-syncs with enabled iframe option', function () {
@@ -352,7 +352,7 @@ describe('C-WIRE bid adapter', () => {
       const userSyncs = spec.getUserSyncs(synOptions, {}, gdprConsent, {});
 
       expect(userSyncs[0].type).to.equal('iframe');
-      expect(userSyncs[0].url).to.equal('https://ib.adnxs.com/getuid?https://prebid.cwi.re/v1/cookiesync?xandrId=$UID&gdpr=1&gdpr_consent=abc123');    
+      expect(userSyncs[0].url).to.equal('https://ib.adnxs.com/getuid?https://prebid.cwi.re/v1/cookiesync?xandrId=$UID&gdpr=1&gdpr_consent=abc123');
     })
   })
 });

package/test/spec/modules/czechAdIdSystem_spec.js

@@ -19,9 +19,9 @@ describe('czechAdId module', function () {
 
   describe('getId()', function () {
     it('should return the uid when it exists in cookie', function () {
-      getCookieStub.withArgs('czaid').returns('czechAdIdTest');
+      getCookieStub.withArgs('czaid').returns('00000000-0000-4000-8000-000000000000');
       const id = czechAdIdSubmodule.getId();
-      expect(id).to.be.deep.equal({id: 'czechAdIdTest'});
+      expect(id).to.be.deep.equal({id: '00000000-0000-4000-8000-000000000000'});
     });
 
     cookieTestCasesForEmpty.forEach(testCase => it('should not return the uid when it doesnt exist in cookie', function () {
@@ -33,9 +33,9 @@ describe('czechAdId module', function () {
 
   describe('decode()', function () {
     it('should return the uid when it exists in cookie', function () {
-      getCookieStub.withArgs('czaid').returns('czechAdIdTest');
+      getCookieStub.withArgs('czaid').returns('00000000-0000-4000-8000-000000000000');
       const decoded = czechAdIdSubmodule.decode();
-      expect(decoded).to.be.deep.equal({czechAdId: 'czechAdIdTest'});
+      expect(decoded).to.be.deep.equal({czechAdId: '00000000-0000-4000-8000-000000000000'});
     });
   });
   describe('eid', () => {

package/test/spec/modules/displayioBidAdapter_spec.js

@@ -1,5 +1,5 @@
 import {spec} from 'modules/displayioBidAdapter.js'
-import {BANNER} from '/src/mediaTypes'
+import {BANNER} from '../../../src/mediaTypes.js'
 
 describe('Displayio adapter', function () {
   const BIDDER = 'displayio'

package/test/spec/modules/dynamicAdBoostRtdProvider_spec.js

@@ -1,48 +1,6 @@
 import { subModuleObj as rtdProvider } from 'modules/dynamicAdBoostRtdProvider.js';
-import { loadExternalScript } from '../../../src/adloader.js';
 import { expect } from 'chai';
 
-const configWithParams = {
-  params: {
-    keyId: 'dynamic',
-    adUnits: ['gpt-123'],
-    threshold: 1
-  }
-};
-
-const configWithoutRequiredParams = {
-  params: {
-    keyId: ''
-  }
-};
-
-describe('dynamicAdBoost', function() {
-  let clock;
-  let sandbox;
-  beforeEach(function () {
-    sandbox = sinon.sandbox.create();
-    clock = sandbox.useFakeTimers(Date.now());
-  });
-  afterEach(function () {
-    sandbox.restore();
-  });
-  describe('init', function() {
-    describe('initialize without expected params', function() {
-      it('fails initalize when keyId is not present', function() {
-        expect(rtdProvider.init(configWithoutRequiredParams)).to.be.false;
-      })
-    })
-
-    describe('initialize with expected params', function() {
-      it('successfully initialize with load script', function() {
-        expect(rtdProvider.init(configWithParams)).to.be.true;
-        clock.tick(1000);
-        expect(loadExternalScript.called).to.be.true;
-      })
-    });
-  });
-})
-
 describe('markViewed tests', function() {
   let sandbox;
   const mockObserver = {

package/test/spec/modules/enrichmentLiftMeasurement_spec.js

@@ -19,7 +19,7 @@ describe('enrichmentLiftMeasurement', () => {
     config.resetConfig();
     reset();
   })
-  
+
   it('should properly split traffic basing on percentage', () => {
     const TEST_SAMPLE_SIZE = 1000;
     const MARGIN_OF_ERROR = 0.05;
@@ -56,13 +56,13 @@ describe('enrichmentLiftMeasurement', () => {
 
     mathRandomStub.restore();
   });
-  
+
   describe('should register activity based on suppression param', () => {
     Object.entries({
       [suppressionMethod.EIDS]: false,
       [suppressionMethod.SUBMODULES]: true
     }).forEach(([method, value]) => {
-      it(method, () => {					
+      it(method, () => {
         config.setConfig({ enrichmentLiftMeasurement: {
           suppression: method,
           modules: [
@@ -123,7 +123,7 @@ describe('enrichmentLiftMeasurement', () => {
         sessionStorageIsEnabled: () => true,
         getDataFromSessionStorage: sinon.stub().returns(null),
         setDataInSessionStorage: sinon.stub()
-      };			
+      };
       init(fakeStorageManager);
       sinon.assert.calledOnce(fakeStorageManager.setDataInSessionStorage);
       sinon.assert.calledOnce(getCalculatedSubmodulesStub);
@@ -148,7 +148,7 @@ describe('enrichmentLiftMeasurement', () => {
         storeSplits: storeSplitsMethod.SESSION_STORAGE,
         modules: mockConfig.map(module => ({...module, percentage: 0.1}))
       }});
-      
+
       init(fakeStorageManager);
 
       sinon.assert.calledOnce(fakeStorageManager.setDataInSessionStorage);
@@ -168,7 +168,7 @@ describe('enrichmentLiftMeasurement', () => {
         testRun: TEST_RUN_ID,
         storeSplits: storeSplitsMethod.PAGE
       }});
-      
+
       init();
 
       const eventType = EVENTS.BID_WON;
@@ -189,7 +189,7 @@ describe('enrichmentLiftMeasurement', () => {
       };
       const stringifiedConfig = JSON.stringify(expectedResult);
 
-      Object.entries({ 
+      Object.entries({
         [LOCAL_STORAGE]: localStorage,
         [SESSION_STORAGE]: sessionStorage,
       }).forEach(([method, storage]) => {
@@ -206,7 +206,7 @@ describe('enrichmentLiftMeasurement', () => {
       const { LOCAL_STORAGE, SESSION_STORAGE } = storeSplitsMethod;
       const TEST_RUN_ID = 'ExperimentA';
 
-      Object.entries({ 
+      Object.entries({
         [LOCAL_STORAGE]: localStorage,
         [SESSION_STORAGE]: sessionStorage,
       }).forEach(([method, storage]) => {

package/test/spec/modules/hypelabBidAdapter_spec.js

@@ -114,11 +114,11 @@ const mockBidRequest = {
 
 describe('hypelabBidAdapter', function () {
   describe('mediaSize', function () {
-    describe('when given an invalid media object', function () {
+    it('when given an invalid media object', function () {
       expect(mediaSize({})).to.eql({ width: 0, height: 0 });
     });
 
-    describe('when given a valid media object', function () {
+    it('when given a valid media object', function () {
       expect(
         mediaSize({ creative_set: { image: { width: 728, height: 90 } } })
       ).to.eql({ width: 728, height: 90 });
@@ -126,29 +126,35 @@ describe('hypelabBidAdapter', function () {
   });
 
   describe('isBidRequestValid', function () {
-    describe('when given an invalid bid request', function () {
+    it('when given an invalid bid request', function () {
       expect(spec.isBidRequestValid({})).to.equal(false);
     });
 
-    describe('when given a valid bid request', function () {
+    it('when given a valid bid request', function () {
       expect(spec.isBidRequestValid(mockValidBidRequest)).to.equal(true);
     });
   });
 
   describe('Bidder code valid', function () {
-    expect(spec.code).to.equal(BIDDER_CODE);
+    it('should match BIDDER_CODE', function () {
+      expect(spec.code).to.equal(BIDDER_CODE);
+    });
   });
 
   describe('Media types valid', function () {
-    expect(spec.supportedMediaTypes).to.contain(BANNER);
+    it('should contain BANNER', function () {
+      expect(spec.supportedMediaTypes).to.contain(BANNER);
+    });
   });
 
   describe('Bid request valid', function () {
-    expect(spec.isBidRequestValid(mockValidBidRequest)).to.equal(true);
+    it('should validate correctly', function () {
+      expect(spec.isBidRequestValid(mockValidBidRequest)).to.equal(true);
+    });
   });
 
   describe('buildRequests', () => {
-    describe('returns a valid request', function () {
+    it('returns a valid request', function () {
       const result = spec.buildRequests(
         mockValidBidRequests,
         mockBidderRequest
@@ -200,7 +206,7 @@ describe('hypelabBidAdapter', function () {
       expect(data.pp).to.deep.equal(null);
     });
 
-    describe('should set uuid to the first id in userIdAsEids', () => {
+    it('should set uuid to the first id in userIdAsEids', () => {
       mockValidBidRequests[0].userIdAsEids = [
         {
           source: 'pubcid.org',
@@ -231,7 +237,7 @@ describe('hypelabBidAdapter', function () {
   });
 
   describe('interpretResponse', () => {
-    describe('successfully interpret a valid response', function () {
+    it('successfully interpret a valid response', function () {
       const result = spec.interpretResponse(mockServerResponse, mockBidRequest);
 
       expect(result).to.be.an('array');
@@ -252,7 +258,7 @@ describe('hypelabBidAdapter', function () {
       expect(data.meta.advertiserDomains[0]).to.be.a('string');
     });
 
-    describe('should return a blank array if cpm is not set', () => {
+    it('should return a blank array if cpm is not set', () => {
       mockServerResponse.body.data.cpm = undefined;
       const result = spec.interpretResponse(mockServerResponse, mockBidRequest);
       expect(result).to.eql([]);

package/test/spec/modules/iasRtdProvider_spec.js

@@ -181,7 +181,7 @@ describe('iasRtdProvider is a RTD provider that', function () {
       });
       it('it merges response data', function () {
         const callback = sinon.spy();
-        
+
         iasSubModule.getBidRequestData({
           adUnits: [
             {code: 'adunit-1'},
@@ -201,7 +201,7 @@ describe('iasRtdProvider is a RTD provider that', function () {
         expect(targeting1['adunit-2']['adt']).to.be.eq('veryLow');
         expect(targeting1['adunit-2']['fr']).to.be.eq('false');
         expect(targeting1['adunit-2']['ias_id']).to.be.eq('id2');
-        
+
         iasSubModule.getBidRequestData({
           adUnits: [
             {code: 'adunit-2'},

package/test/spec/modules/id5IdSystem_spec.js

@@ -26,7 +26,7 @@ describe('ID5 ID System', function () {
   });
   after(function () {
     logInfoStub.restore();
-  });  
+  });
   const ID5_MODULE_NAME = 'id5Id';
   const ID5_EIDS_NAME = ID5_MODULE_NAME.toLowerCase();
   const ID5_SOURCE = 'id5-sync.com';

package/test/spec/modules/idxIdSystem_spec.js

@@ -1,5 +1,4 @@
 import { expect } from 'chai';
-import {find} from 'src/polyfill.js';
 import { config } from 'src/config.js';
 import { init, startAuctionHook, setSubmoduleRegistry } from 'modules/userId/index.js';
 import { storage, idxIdSubmodule } from 'modules/idxIdSystem.js';
@@ -114,7 +113,7 @@ describe('IDx ID System', () => {
           unit.bids.forEach(bid => {
             expect(bid).to.have.deep.nested.property('userId.idx');
             expect(bid.userId.idx).to.equal(IDX_DUMMY_VALUE);
-            const idxIdAsEid = find(bid.userIdAsEids, e => e.source == 'idx.lat');
+            const idxIdAsEid = bid.userIdAsEids.find(e => e.source == 'idx.lat');
             expect(idxIdAsEid).to.deep.equal({
               source: 'idx.lat',
               uids: [{

package/test/spec/modules/intentIqAnalyticsAdapter_spec.js

@@ -141,19 +141,19 @@ describe('IntentIQ tests all', function () {
   it('should send POST request with payload in request body if reportMethod is POST', function () {
     const [userConfig] = getUserConfig();
     userConfig.params.reportMethod = 'POST';
-  
+
     config.getConfig.restore();
     sinon.stub(config, 'getConfig').withArgs('userSync.userIds').returns([userConfig]);
-  
+
     localStorage.setItem(FIRST_PARTY_KEY, defaultData);
-  
+
     events.emit(EVENTS.BID_WON, wonRequest);
-  
+
     const request = server.requests[0];
-  
+
     const expectedData = preparePayload(wonRequest);
     const expectedPayload = `["${btoa(JSON.stringify(expectedData))}"]`;
-  
+
     expect(request.method).to.equal('POST');
     expect(request.requestBody).to.equal(expectedPayload);
   });
@@ -162,25 +162,25 @@ describe('IntentIQ tests all', function () {
     const [userConfig] = getUserConfig();
     config.getConfig.restore();
     sinon.stub(config, 'getConfig').withArgs('userSync.userIds').returns([userConfig]);
-  
+
     localStorage.setItem(FIRST_PARTY_KEY, defaultData);
     events.emit(EVENTS.BID_WON, wonRequest);
-  
+
     const request = server.requests[0];
-  
+
     expect(request.method).to.equal('GET');
-  
+
     const url = new URL(request.url);
     const payloadEncoded = url.searchParams.get('payload');
     const decoded = JSON.parse(atob(JSON.parse(payloadEncoded)[0]));
-  
+
     const expected = preparePayload(wonRequest);
-  
+
     expect(decoded.partnerId).to.equal(expected.partnerId);
     expect(decoded.adType).to.equal(expected.adType);
     expect(decoded.prebidAuctionId).to.equal(expected.prebidAuctionId);
   });
-  
+
   it('IIQ Analytical Adapter bid win report', function () {
     localStorage.setItem(FIRST_PARTY_KEY, defaultData);
     getWindowLocationStub = sinon.stub(utils, 'getWindowLocation').returns({href: 'http://localhost:9876'});
@@ -430,8 +430,8 @@ describe('IntentIQ tests all', function () {
   });
 
   it('should include source parameter in report URL', function () {
-    localStorage.setItem(FIRST_PARTY_KEY, JSON.stringify(defaultData));  
-    
+    localStorage.setItem(FIRST_PARTY_KEY, JSON.stringify(defaultData));
+
     events.emit(EVENTS.BID_WON, wonRequest);
     const request = server.requests[0];
 
@@ -462,17 +462,17 @@ describe('IntentIQ tests all', function () {
       parameterValue: 'Lee',
       destination: [0, 0, 1]
     }];
-  
+
     config.getConfig.restore();
     sinon.stub(config, 'getConfig').withArgs('userSync.userIds').returns(userConfig);
-  
+
     localStorage.setItem(FIRST_PARTY_KEY, defaultData);
     events.emit(EVENTS.BID_WON, wonRequest);
-  
+
     const request = server.requests[0];
     expect(request.url).to.include('general=Lee');
   });
-  
+
   it('should not send additionalParams in report if value is too large', function () {
     const longVal = 'x'.repeat(5000000);
     const userConfig = getUserConfig();
@@ -481,21 +481,21 @@ describe('IntentIQ tests all', function () {
       parameterValue: longVal,
       destination: [0, 0, 1]
     }];
-  
+
     config.getConfig.restore();
     sinon.stub(config, 'getConfig').withArgs('userSync.userIds').returns(userConfig);
-  
+
     localStorage.setItem(FIRST_PARTY_KEY, defaultData);
     events.emit(EVENTS.BID_WON, wonRequest);
-  
+
     const request = server.requests[0];
     expect(request.url).not.to.include('general');
-  });  
+  });
   it('should include spd parameter from LS in report URL', function () {
     const spdObject = { foo: 'bar', value: 42 };
     const expectedSpdEncoded = encodeURIComponent(JSON.stringify(spdObject));
 
-    localStorage.setItem(FIRST_PARTY_KEY, JSON.stringify({...defaultData, spd: spdObject}));  
+    localStorage.setItem(FIRST_PARTY_KEY, JSON.stringify({...defaultData, spd: spdObject}));
     getWindowLocationStub = sinon.stub(utils, 'getWindowLocation').returns({ href: 'http://localhost:9876/' });
 
     events.emit(EVENTS.BID_WON, wonRequest);
@@ -510,7 +510,7 @@ describe('IntentIQ tests all', function () {
     const spdObject = 'server provided data';
     const expectedSpdEncoded = encodeURIComponent(spdObject);
 
-    localStorage.setItem(FIRST_PARTY_KEY, JSON.stringify({...defaultData, spd: spdObject}));  
+    localStorage.setItem(FIRST_PARTY_KEY, JSON.stringify({...defaultData, spd: spdObject}));
     getWindowLocationStub = sinon.stub(utils, 'getWindowLocation').returns({ href: 'http://localhost:9876/' });
 
     events.emit(EVENTS.BID_WON, wonRequest);