prebid.js 8.7.0 → 8.9.0

package/test/spec/modules/priceFloors_spec.js

@@ -22,6 +22,7 @@ import {auctionManager} from '../../../src/auctionManager.js';
 import {stubAuctionIndex} from '../../helpers/indexStub.js';
 import {guardTids} from '../../../src/adapters/bidderFactory.js';
 import * as activities from '../../../src/activities/rules.js';
+import {server} from '../../mocks/xhr.js';
 
 describe('the price floors module', function () {
   let logErrorSpy;
@@ -593,16 +594,11 @@ describe('the price floors module', function () {
         adUnits,
       });
     };
-    let fakeFloorProvider;
     let actualAllowedFields = allowedFields;
     let actualFieldMatchingFunctions = fieldMatchingFunctions;
     const defaultAllowedFields = [...allowedFields];
     const defaultMatchingFunctions = {...fieldMatchingFunctions};
-    beforeEach(function() {
-      fakeFloorProvider = sinon.fakeServer.create();
-    });
     afterEach(function() {
-      fakeFloorProvider.restore();
       exposedAdUnits = undefined;
       actualAllowedFields = [...defaultAllowedFields];
       actualFieldMatchingFunctions = {...defaultMatchingFunctions};
@@ -986,7 +982,7 @@ describe('the price floors module', function () {
       });
     });
     it('Should continue auction of delay is hit without a response from floor provider', function () {
-      handleSetFloorsConfig({...basicFloorConfig, auctionDelay: 250, endpoint: {url: 'http://www.fakeFloorProvider.json'}});
+      handleSetFloorsConfig({...basicFloorConfig, auctionDelay: 250, endpoint: {url: 'http://www.fakefloorprovider.json//'}});
 
       // start the auction it should delay and not immediately call `continueAuction`
       runStandardAuction();
@@ -1013,7 +1009,7 @@ describe('the price floors module', function () {
         fetchStatus: 'timeout',
         floorProvider: undefined
       });
-      fakeFloorProvider.respond();
+      server.respond();
     });
     it('It should fetch if config has url and bidRequests have fetch level flooring meta data', function () {
       // init the fake server with response stuff
@@ -1021,14 +1017,14 @@ describe('the price floors module', function () {
         ...basicFloorData,
         modelVersion: 'fetch model name', // change the model name
       };
-      fakeFloorProvider.respondWith(JSON.stringify(fetchFloorData));
+      server.respondWith(JSON.stringify(fetchFloorData));
 
       // run setConfig indicating fetch
-      handleSetFloorsConfig({...basicFloorConfig, floorProvider: 'floorprovider', auctionDelay: 250, endpoint: {url: 'http://www.fakeFloorProvider.json'}});
+      handleSetFloorsConfig({...basicFloorConfig, floorProvider: 'floorprovider', auctionDelay: 250, endpoint: {url: 'http://www.fakefloorprovider.json/'}});
 
       // floor provider should be called
-      expect(fakeFloorProvider.requests.length).to.equal(1);
-      expect(fakeFloorProvider.requests[0].url).to.equal('http://www.fakeFloorProvider.json');
+      expect(server.requests.length).to.equal(1);
+      expect(server.requests[0].url).to.equal('http://www.fakefloorprovider.json/');
 
       // start the auction it should delay and not immediately call `continueAuction`
       runStandardAuction();
@@ -1037,7 +1033,7 @@ describe('the price floors module', function () {
       expect(exposedAdUnits).to.be.undefined;
 
       // make the fetch respond
-      fakeFloorProvider.respond();
+      server.respond();
       expect(exposedAdUnits).to.not.be.undefined;
 
       // the exposedAdUnits should be from the fetch not setConfig level data
@@ -1061,14 +1057,14 @@ describe('the price floors module', function () {
         floorProvider: 'floorProviderD', // change the floor provider
         modelVersion: 'fetch model name', // change the model name
       };
-      fakeFloorProvider.respondWith(JSON.stringify(fetchFloorData));
+      server.respondWith(JSON.stringify(fetchFloorData));
 
       // run setConfig indicating fetch
-      handleSetFloorsConfig({...basicFloorConfig, floorProvider: 'floorproviderC', auctionDelay: 250, endpoint: {url: 'http://www.fakeFloorProvider.json'}});
+      handleSetFloorsConfig({...basicFloorConfig, floorProvider: 'floorproviderC', auctionDelay: 250, endpoint: {url: 'http://www.fakefloorprovider.json/'}});
 
       // floor provider should be called
-      expect(fakeFloorProvider.requests.length).to.equal(1);
-      expect(fakeFloorProvider.requests[0].url).to.equal('http://www.fakeFloorProvider.json');
+      expect(server.requests.length).to.equal(1);
+      expect(server.requests[0].url).to.equal('http://www.fakefloorprovider.json/');
 
       // start the auction it should delay and not immediately call `continueAuction`
       runStandardAuction();
@@ -1077,7 +1073,7 @@ describe('the price floors module', function () {
       expect(exposedAdUnits).to.be.undefined;
 
       // make the fetch respond
-      fakeFloorProvider.respond();
+      server.respond();
 
       // the exposedAdUnits should be from the fetch not setConfig level data
       // and fetchStatus is success since fetch worked
@@ -1102,14 +1098,14 @@ describe('the price floors module', function () {
         modelVersion: 'fetch model name', // change the model name
       };
       fetchFloorData.skipRate = 95;
-      fakeFloorProvider.respondWith(JSON.stringify(fetchFloorData));
+      server.respondWith(JSON.stringify(fetchFloorData));
 
       // run setConfig indicating fetch
-      handleSetFloorsConfig({...basicFloorConfig, floorProvider: 'floorprovider', auctionDelay: 250, endpoint: {url: 'http://www.fakeFloorProvider.json'}});
+      handleSetFloorsConfig({...basicFloorConfig, floorProvider: 'floorprovider', auctionDelay: 250, endpoint: {url: 'http://www.fakefloorprovider.json/'}});
 
       // floor provider should be called
-      expect(fakeFloorProvider.requests.length).to.equal(1);
-      expect(fakeFloorProvider.requests[0].url).to.equal('http://www.fakeFloorProvider.json');
+      expect(server.requests.length).to.equal(1);
+      expect(server.requests[0].url).to.equal('http://www.fakefloorprovider.json/');
 
       // start the auction it should delay and not immediately call `continueAuction`
       runStandardAuction();
@@ -1118,7 +1114,7 @@ describe('the price floors module', function () {
       expect(exposedAdUnits).to.be.undefined;
 
       // make the fetch respond
-      fakeFloorProvider.respond();
+      server.respond();
       expect(exposedAdUnits).to.not.be.undefined;
 
       // the exposedAdUnits should be from the fetch not setConfig level data
@@ -1137,10 +1133,10 @@ describe('the price floors module', function () {
     });
     it('Should not break if floor provider returns 404', function () {
       // run setConfig indicating fetch
-      handleSetFloorsConfig({...basicFloorConfig, auctionDelay: 250, endpoint: {url: 'http://www.fakeFloorProvider.json'}});
+      handleSetFloorsConfig({...basicFloorConfig, auctionDelay: 250, endpoint: {url: 'http://www.fakefloorprovider.json/'}});
 
       // run the auction and make server respond with 404
-      fakeFloorProvider.respond();
+      server.respond();
       runStandardAuction();
 
       // error should have been called for fetch error
@@ -1160,13 +1156,13 @@ describe('the price floors module', function () {
       });
     });
     it('Should not break if floor provider returns non json', function () {
-      fakeFloorProvider.respondWith('Not valid response');
+      server.respondWith('Not valid response');
 
       // run setConfig indicating fetch
-      handleSetFloorsConfig({...basicFloorConfig, auctionDelay: 250, endpoint: {url: 'http://www.fakeFloorProvider.json'}});
+      handleSetFloorsConfig({...basicFloorConfig, auctionDelay: 250, endpoint: {url: 'http://www.fakefloorprovider.json/'}});
 
       // run the auction and make server respond
-      fakeFloorProvider.respond();
+      server.respond();
       runStandardAuction();
 
       // error should have been called for response floor data not being valid
@@ -1187,27 +1183,27 @@ describe('the price floors module', function () {
     });
     it('should handle not using fetch correctly', function () {
       // run setConfig twice indicating fetch
-      fakeFloorProvider.respondWith(JSON.stringify(basicFloorData));
-      handleSetFloorsConfig({...basicFloorConfig, auctionDelay: 250, endpoint: {url: 'http://www.fakeFloorProvider.json'}});
-      handleSetFloorsConfig({...basicFloorConfig, auctionDelay: 250, endpoint: {url: 'http://www.fakeFloorProvider.json'}});
+      server.respondWith(JSON.stringify(basicFloorData));
+      handleSetFloorsConfig({...basicFloorConfig, auctionDelay: 250, endpoint: {url: 'http://www.fakefloorprovider.json/'}});
+      handleSetFloorsConfig({...basicFloorConfig, auctionDelay: 250, endpoint: {url: 'http://www.fakefloorprovider.json/'}});
 
       // log warn should be called and server only should have one request
       expect(logWarnSpy.calledOnce).to.equal(true);
-      expect(fakeFloorProvider.requests.length).to.equal(1);
-      expect(fakeFloorProvider.requests[0].url).to.equal('http://www.fakeFloorProvider.json');
+      expect(server.requests.length).to.equal(1);
+      expect(server.requests[0].url).to.equal('http://www.fakefloorprovider.json/');
 
       // now we respond and then run again it should work and make another request
-      fakeFloorProvider.respond();
-      handleSetFloorsConfig({...basicFloorConfig, auctionDelay: 250, endpoint: {url: 'http://www.fakeFloorProvider.json'}});
-      fakeFloorProvider.respond();
+      server.respond();
+      handleSetFloorsConfig({...basicFloorConfig, auctionDelay: 250, endpoint: {url: 'http://www.fakefloorprovider.json/'}});
+      server.respond();
 
       // now warn still only called once and server called twice
       expect(logWarnSpy.calledOnce).to.equal(true);
-      expect(fakeFloorProvider.requests.length).to.equal(2);
+      expect(server.requests.length).to.equal(2);
 
       // should log error if method is not GET for now
       expect(logErrorSpy.calledOnce).to.equal(false);
-      handleSetFloorsConfig({...basicFloorConfig, endpoint: {url: 'http://www.fakeFloorProvider.json', method: 'POST'}});
+      handleSetFloorsConfig({...basicFloorConfig, endpoint: {url: 'http://www.fakefloorprovider.json/', method: 'POST'}});
       expect(logErrorSpy.calledOnce).to.equal(true);
     });
     describe('isFloorsDataValid', function () {

package/test/spec/modules/publinkIdSystem_spec.js

@@ -120,7 +120,7 @@ describe('PublinkIdSystem', () => {
         expect(parsed.search.mpn).to.equal('Prebid.js');
         expect(parsed.search.mpv).to.equal('$prebid.version$');
 
-        request.respond(204, {}, JSON.stringify(serverResponse));
+        request.respond(204);
         expect(callbackSpy.called).to.be.false;
       });
 

package/test/spec/modules/pubmaticAnalyticsAdapter_spec.js

@@ -1,11 +1,10 @@
-import pubmaticAnalyticsAdapter, { getMetadata } from 'modules/pubmaticAnalyticsAdapter.js';
+import pubmaticAnalyticsAdapter, {getMetadata} from 'modules/pubmaticAnalyticsAdapter.js';
 import adapterManager from 'src/adapterManager.js';
 import CONSTANTS from 'src/constants.json';
-import { config } from 'src/config.js';
-import {
-  setConfig,
-  addBidResponseHook,
-} from 'modules/currency.js';
+import {config} from 'src/config.js';
+import {setConfig} from 'modules/currency.js';
+import {server} from '../../mocks/xhr.js';
+import 'src/prebid.js';
 
 let events = require('src/events');
 let ajax = require('src/ajax');
@@ -273,7 +272,6 @@ function getLoggerJsonFromRequest(requestBody) {
 
 describe('pubmatic analytics adapter', function () {
   let sandbox;
-  let xhr;
   let requests;
   let oldScreen;
   let clock;
@@ -282,9 +280,7 @@ describe('pubmatic analytics adapter', function () {
     setUADefault();
     sandbox = sinon.sandbox.create();
 
-    xhr = sandbox.useFakeXMLHttpRequest();
-    requests = [];
-    xhr.onCreate = request => requests.push(request);
+    requests = server.requests;
 
     sandbox.stub(events, 'getEvents').returns([]);
 
@@ -393,7 +389,7 @@ describe('pubmatic analytics adapter', function () {
       expect(data.s[0].ps[0].af).to.equal('video');
       expect(data.s[0].ps[0].ocpm).to.equal(1.23);
       expect(data.s[0].ps[0].ocry).to.equal('USD');
-      expect(data.s[0].ps[0].frv).to.equal(undefined);
+      expect(data.s[0].ps[0].frv).to.equal(1.1);
       // slot 2
       expect(data.s[1].sn).to.equal('/19968336/header-bid-tag-1');
       expect(data.s[1].fskp).to.equal(0);
@@ -422,7 +418,7 @@ describe('pubmatic analytics adapter', function () {
       expect(data.s[1].ps[0].af).to.equal('banner');
       expect(data.s[1].ps[0].ocpm).to.equal(1.52);
       expect(data.s[1].ps[0].ocry).to.equal('USD');
-      expect(data.s[1].ps[0].frv).to.equal(undefined);
+      expect(data.s[1].ps[0].frv).to.equal(1.1);
 
       // tracker slot1
       let firstTracker = requests[0].url;
@@ -452,6 +448,94 @@ describe('pubmatic analytics adapter', function () {
       expect(data.af).to.equal('video');
     });
 
+    it('Logger: do not log floor fields when prebids floor shows noData in location property', function() {
+      const BID_REQUESTED_COPY = utils.deepClone(MOCK.BID_REQUESTED);
+      BID_REQUESTED_COPY['bids'][1]['floorData']['location'] = 'noData';
+
+      this.timeout(5000)
+
+      sandbox.stub($$PREBID_GLOBAL$$, 'getHighestCpmBids').callsFake((key) => {
+        return [MOCK.BID_RESPONSE[0], MOCK.BID_RESPONSE[1]]
+      });
+
+      config.setConfig({
+        testGroupId: 15
+      });
+
+      events.emit(AUCTION_INIT, MOCK.AUCTION_INIT);
+      events.emit(BID_REQUESTED, BID_REQUESTED_COPY);
+      events.emit(BID_RESPONSE, MOCK.BID_RESPONSE[0]);
+      events.emit(BID_RESPONSE, MOCK.BID_RESPONSE[1]);
+      events.emit(BIDDER_DONE, MOCK.BIDDER_DONE);
+      events.emit(AUCTION_END, MOCK.AUCTION_END);
+      events.emit(SET_TARGETING, MOCK.SET_TARGETING);
+      events.emit(BID_WON, MOCK.BID_WON[0]);
+      events.emit(BID_WON, MOCK.BID_WON[1]);
+
+      clock.tick(2000 + 1000);
+      expect(requests.length).to.equal(3); // 1 logger and 2 win-tracker
+      let request = requests[2]; // logger is executed late, trackers execute first
+      expect(request.url).to.equal('https://t.pubmatic.com/wl?pubid=9999');
+
+      let data = getLoggerJsonFromRequest(request.requestBody);
+
+      expect(data.pubid).to.equal('9999');
+      expect(data.fmv).to.equal(undefined);
+
+      // slot 1
+      expect(data.s[0].sn).to.equal('/19968336/header-bid-tag-0');
+      expect(data.s[0].au).to.equal('/19968336/header-bid-tag-0');
+
+      // slot 2
+      expect(data.s[1].sn).to.equal('/19968336/header-bid-tag-1');
+      expect(data.s[1].au).to.equal('/19968336/header-bid-tag-1');
+      expect(data.s[1].fskp).to.equal(undefined);
+    });
+
+    it('Logger: log floor fields when prebids floor shows setConfig in location property', function() {
+      const BID_REQUESTED_COPY = utils.deepClone(MOCK.BID_REQUESTED);
+      BID_REQUESTED_COPY['bids'][1]['floorData']['location'] = 'setConfig';
+
+      this.timeout(5000)
+
+      sandbox.stub($$PREBID_GLOBAL$$, 'getHighestCpmBids').callsFake((key) => {
+        return [MOCK.BID_RESPONSE[0], MOCK.BID_RESPONSE[1]]
+      });
+
+      config.setConfig({
+        testGroupId: 15
+      });
+
+      events.emit(AUCTION_INIT, MOCK.AUCTION_INIT);
+      events.emit(BID_REQUESTED, BID_REQUESTED_COPY);
+      events.emit(BID_RESPONSE, MOCK.BID_RESPONSE[0]);
+      events.emit(BID_RESPONSE, MOCK.BID_RESPONSE[1]);
+      events.emit(BIDDER_DONE, MOCK.BIDDER_DONE);
+      events.emit(AUCTION_END, MOCK.AUCTION_END);
+      events.emit(SET_TARGETING, MOCK.SET_TARGETING);
+      events.emit(BID_WON, MOCK.BID_WON[0]);
+      events.emit(BID_WON, MOCK.BID_WON[1]);
+
+      clock.tick(2000 + 1000);
+      expect(requests.length).to.equal(3); // 1 logger and 2 win-tracker
+      let request = requests[2]; // logger is executed late, trackers execute first
+      expect(request.url).to.equal('https://t.pubmatic.com/wl?pubid=9999');
+
+      let data = getLoggerJsonFromRequest(request.requestBody);
+
+      expect(data.pubid).to.equal('9999');
+      expect(data.fmv).to.equal('floorModelTest');
+
+      // slot 1
+      expect(data.s[0].sn).to.equal('/19968336/header-bid-tag-0');
+      expect(data.s[0].au).to.equal('/19968336/header-bid-tag-0');
+
+      // slot 2
+      expect(data.s[1].sn).to.equal('/19968336/header-bid-tag-1');
+      expect(data.s[1].au).to.equal('/19968336/header-bid-tag-1');
+      expect(data.s[1].fskp).to.equal(0);
+    });
+
     it('bidCpmAdjustment: USD: Logger: best case + win tracker', function() {
       const bidCopy = utils.deepClone(BID);
       bidCopy.cpm = bidCopy.originalCpm * 2; //  bidCpmAdjustment => bidCpm * 2
@@ -501,7 +585,7 @@ describe('pubmatic analytics adapter', function () {
       expect(data.s[0].ps[0].af).to.equal('video');
       expect(data.s[0].ps[0].ocpm).to.equal(1.23);
       expect(data.s[0].ps[0].ocry).to.equal('USD');
-      expect(data.s[1].ps[0].frv).to.equal(undefined);
+      expect(data.s[1].ps[0].frv).to.equal(1.1);
       // tracker slot1
       let firstTracker = requests[0].url;
       expect(firstTracker.split('?')[0]).to.equal('https://t.pubmatic.com/wt');
@@ -711,7 +795,7 @@ describe('pubmatic analytics adapter', function () {
       expect(data.s[1].ps[0].af).to.equal('banner');
       expect(data.s[1].ps[0].ocpm).to.equal(1.52);
       expect(data.s[1].ps[0].ocry).to.equal('USD');
-      expect(data.s[1].ps[0].frv).to.equal(undefined);
+      expect(data.s[1].ps[0].frv).to.equal(1.1);
     });
 
     it('Logger: currency conversion check', function() {
@@ -818,7 +902,7 @@ describe('pubmatic analytics adapter', function () {
       expect(data.s[1].ps[0].af).to.equal('banner');
       expect(data.s[1].ps[0].ocpm).to.equal(1.52);
       expect(data.s[1].ps[0].ocry).to.equal('USD');
-      expect(data.s[1].ps[0].frv).to.equal(undefined);
+      expect(data.s[1].ps[0].frv).to.equal(1.1);
       expect(data.dvc).to.deep.equal({'plt': 2});
       // respective tracker slot
       let firstTracker = requests[1].url;
@@ -876,7 +960,7 @@ describe('pubmatic analytics adapter', function () {
       expect(data.s[1].ps[0].ocpm).to.equal(1.52);
       expect(data.s[1].ps[0].ocry).to.equal('USD');
       expect(data.dvc).to.deep.equal({'plt': 1});
-      expect(data.s[1].ps[0].frv).to.equal(undefined);
+      expect(data.s[1].ps[0].frv).to.equal(1.1);
       // respective tracker slot
       let firstTracker = requests[1].url;
       expect(firstTracker.split('?')[0]).to.equal('https://t.pubmatic.com/wt');
@@ -929,7 +1013,7 @@ describe('pubmatic analytics adapter', function () {
       expect(data.s[1].ps[0].af).to.equal('banner');
       expect(data.s[1].ps[0].ocpm).to.equal(1.52);
       expect(data.s[1].ps[0].ocry).to.equal('USD');
-      expect(data.s[1].ps[0].frv).to.equal(undefined);
+      expect(data.s[1].ps[0].frv).to.equal(1.1);
       // respective tracker slot
       let firstTracker = requests[1].url;
       expect(firstTracker.split('?')[0]).to.equal('https://t.pubmatic.com/wt');
@@ -1091,7 +1175,7 @@ describe('pubmatic analytics adapter', function () {
       expect(data.s[1].ps[0].af).to.equal('banner');
       expect(data.s[1].ps[0].ocpm).to.equal(1.52);
       expect(data.s[1].ps[0].ocry).to.equal('USD');
-      expect(data.s[1].ps[0].frv).to.equal(undefined);
+      expect(data.s[1].ps[0].frv).to.equal(1.1);
 
       // tracker slot1
       let firstTracker = requests[0].url;

package/test/spec/modules/pubwiseAnalyticsAdapter_spec.js

@@ -1,6 +1,7 @@
 import {expect} from 'chai';
 import pubwiseAnalytics from 'modules/pubwiseAnalyticsAdapter.js';
 import {expectEvents} from '../../helpers/analytics.js';
+import {server} from '../../mocks/xhr.js';
 
 let events = require('src/events');
 let adapterManager = require('src/adapterManager').default;
@@ -9,7 +10,6 @@ let constants = require('src/constants.json');
 describe('PubWise Prebid Analytics', function () {
   let requests;
   let sandbox;
-  let xhr;
   let clock;
   let mock = {};
 
@@ -38,9 +38,7 @@ describe('PubWise Prebid Analytics', function () {
     clock = sandbox.useFakeTimers();
     sandbox.stub(events, 'getEvents').returns([]);
 
-    xhr = sandbox.useFakeXMLHttpRequest();
-    requests = [];
-    xhr.onCreate = request => requests.push(request);
+    requests = server.requests;
   });
 
   afterEach(function () {
@@ -50,10 +48,6 @@ describe('PubWise Prebid Analytics', function () {
   });
 
   describe('enableAnalytics', function () {
-    beforeEach(function () {
-      requests = [];
-    });
-
     it('should catch all events', function () {
       pubwiseAnalytics.enableAnalytics(mock.DEFAULT_PW_CONFIG);
 

package/test/spec/modules/rubiconBidAdapter_spec.js

@@ -1229,6 +1229,30 @@ describe('the rubicon adapter', function () {
             });
           });
 
+          it('should still use single request if other rubicon configs are set after', function () {
+            // set single request to true
+            config.setConfig({ rubicon: { singleRequest: true } });
+
+            // execute some other rubicon setConfig
+            config.setConfig({ rubicon: { netRevenue: true } });
+
+            const bidCopy = utils.deepClone(bidderRequest.bids[0]);
+            bidderRequest.bids.push(bidCopy);
+            bidderRequest.bids.push(bidCopy);
+            bidderRequest.bids.push(bidCopy);
+
+            let serverRequests = spec.buildRequests(bidderRequest.bids, bidderRequest);
+
+            // should have 1 request only
+            expect(serverRequests).that.is.an('array').of.length(1);
+
+            // get the built query
+            let data = parseQuery(serverRequests[0].data);
+
+            // num slots should be 4
+            expect(data.slots).to.equal('4');
+          });
+
           it('should not group bid requests if singleRequest does not equal true', function () {
             config.setConfig({rubicon: {singleRequest: false}});
 

package/test/spec/modules/smartyadsBidAdapter_spec.js

@@ -1,6 +1,7 @@
 import {expect} from 'chai';
 import {spec} from '../../../modules/smartyadsBidAdapter.js';
 import { config } from '../../../src/config.js';
+import {server} from '../../mocks/xhr';
 
 describe('SmartyadsAdapter', function () {
   let bid = {
@@ -14,6 +15,21 @@ describe('SmartyadsAdapter', function () {
     }
   };
 
+  let bidResponse = {
+    width: 300,
+    height: 250,
+    mediaType: 'banner',
+    ad: `<img src='https://dummyimage.com/300x250&text=Test+Mode' width=300 height=250 alt='test mode'>`,
+    requestId: '23fhj33i987f',
+    cpm: 0.1,
+    ttl: 120,
+    creativeId: '123',
+    netRevenue: true,
+    currency: 'USD',
+    dealId: 'HASH',
+    sid: 1234
+  };
+
   describe('isBidRequestValid', function () {
     it('Should return true if there are bidId, params and sourceid parameters present', function () {
       expect(spec.isBidRequestValid(bid)).to.be.true;
@@ -257,4 +273,37 @@ describe('SmartyadsAdapter', function () {
       ]);
     });
   });
+
+  describe('onBidWon', function () {
+    it('should exists', function () {
+      expect(spec.onBidWon).to.exist.and.to.be.a('function');
+    });
+
+    it('should send a valid bid won notice', function () {
+      spec.onBidWon(bidResponse);
+      expect(server.requests.length).to.equal(1);
+    });
+  });
+
+  describe('onTimeout', function () {
+    it('should exists', function () {
+      expect(spec.onTimeout).to.exist.and.to.be.a('function');
+    });
+
+    it('should send a valid bid timeout notice', function () {
+      spec.onTimeout({});
+      expect(server.requests.length).to.equal(1);
+    });
+  });
+
+  describe('onBidderError', function () {
+    it('should exists', function () {
+      expect(spec.onBidderError).to.exist.and.to.be.a('function');
+    });
+
+    it('should send a valid bidder error notice', function () {
+      spec.onBidderError({});
+      expect(server.requests.length).to.equal(1);
+    });
+  });
 });

package/test/spec/modules/snigelBidAdapter_spec.js

@@ -20,6 +20,7 @@ const makeBidRequest = function (overrides) {
 };
 
 const BASE_BIDDER_REQUEST = {
+  auctionId: 'test',
   bidderRequestId: 'test',
   refererInfo: {
     canonicalUrl: 'https://localhost',
@@ -53,8 +54,8 @@ describe('snigelBidAdapter', function () {
     it('should build a single request for every impression and its placement', function () {
       const bidderRequest = Object.assign({}, BASE_BIDDER_REQUEST);
       const bidRequests = [
-        makeBidRequest({bidId: 'a', params: {placement: 'top_leaderboard'}}),
-        makeBidRequest({bidId: 'b', params: {placement: 'bottom_leaderboard'}}),
+        makeBidRequest({bidId: 'a', adUnitCode: 'au_a', params: {placement: 'top_leaderboard'}}),
+        makeBidRequest({bidId: 'b', adUnitCode: 'au_b', params: {placement: 'bottom_leaderboard'}}),
       ];
 
       const request = spec.buildRequests(bidRequests, bidderRequest);
@@ -70,9 +71,9 @@ describe('snigelBidAdapter', function () {
       expect(data).to.have.property('page').and.to.equal('https://localhost');
       expect(data).to.have.property('placements');
       expect(data.placements.length).to.equal(2);
-      expect(data.placements[0].uuid).to.equal('a');
+      expect(data.placements[0].id).to.equal('au_a');
       expect(data.placements[0].name).to.equal('top_leaderboard');
-      expect(data.placements[1].uuid).to.equal('b');
+      expect(data.placements[1].id).to.equal('au_b');
       expect(data.placements[1].name).to.equal('bottom_leaderboard');
     });
 
@@ -127,6 +128,56 @@ describe('snigelBidAdapter', function () {
       const data = JSON.parse(request.data);
       expect(data).to.have.property('coppa').and.to.equal(true);
     });
+
+    it('should forward refresh information', function () {
+      const bidderRequest = Object.assign({}, BASE_BIDDER_REQUEST);
+      const topLeaderboard = makeBidRequest({adUnitCode: 'top_leaderboard'});
+      const bottomLeaderboard = makeBidRequest({adUnitCode: 'bottom_leaderboard'});
+      const sidebar = makeBidRequest({adUnitCode: 'sidebar'});
+
+      // first auction, no refresh
+      let request = spec.buildRequests([topLeaderboard, bottomLeaderboard], bidderRequest);
+      expect(request).to.have.property('data');
+      let data = JSON.parse(request.data);
+      expect(data).to.have.property('placements');
+      expect(data.placements.length).to.equal(2);
+      expect(data.placements[0].id).to.equal('top_leaderboard');
+      expect(data.placements[0].refresh).to.be.undefined;
+      expect(data.placements[1].id).to.equal('bottom_leaderboard');
+      expect(data.placements[1].refresh).to.be.undefined;
+
+      // second auction for top leaderboard, was refreshed
+      request = spec.buildRequests([topLeaderboard, sidebar], bidderRequest);
+      expect(request).to.have.property('data');
+      data = JSON.parse(request.data);
+      expect(data).to.have.property('placements');
+      expect(data.placements.length).to.equal(2);
+      expect(data.placements[0].id).to.equal('top_leaderboard');
+      expect(data.placements[0].refresh).to.not.be.undefined;
+      expect(data.placements[0].refresh.count).to.equal(1);
+      expect(data.placements[0].refresh.time).to.be.greaterThanOrEqual(0);
+      expect(data.placements[1].id).to.equal('sidebar');
+      expect(data.placements[1].refresh).to.be.undefined;
+
+      // third auction, all units refreshed at some point
+      request = spec.buildRequests([topLeaderboard, bottomLeaderboard, sidebar], bidderRequest);
+      expect(request).to.have.property('data');
+      data = JSON.parse(request.data);
+      expect(data).to.have.property('placements');
+      expect(data.placements.length).to.equal(3);
+      expect(data.placements[0].id).to.equal('top_leaderboard');
+      expect(data.placements[0].refresh).to.not.be.undefined;
+      expect(data.placements[0].refresh.count).to.equal(2);
+      expect(data.placements[0].refresh.time).to.be.greaterThanOrEqual(0);
+      expect(data.placements[1].id).to.equal('bottom_leaderboard');
+      expect(data.placements[1].refresh).to.not.be.undefined;
+      expect(data.placements[1].refresh.count).to.equal(1);
+      expect(data.placements[1].refresh.time).to.be.greaterThanOrEqual(0);
+      expect(data.placements[2].id).to.equal('sidebar');
+      expect(data.placements[2].refresh).to.not.be.undefined;
+      expect(data.placements[2].refresh.count).to.equal(1);
+      expect(data.placements[2].refresh.time).to.be.greaterThanOrEqual(0);
+    });
   });
 
   describe('interpretResponse', function () {
@@ -146,7 +197,7 @@ describe('snigelBidAdapter', function () {
           cur: 'USD',
           bids: [
             {
-              uuid: BASE_BID_REQUEST.bidId,
+              id: BASE_BID_REQUEST.adUnitCode,
               price: 0.0575,
               ad: '<html><body><h1>Test Ad</h1></body></html>',
               width: 728,
@@ -160,7 +211,7 @@ describe('snigelBidAdapter', function () {
         },
       };
 
-      const bids = spec.interpretResponse(serverResponse, {});
+      const bids = spec.interpretResponse(serverResponse, {bidderRequest: {bids: [BASE_BID_REQUEST]}});
       expect(bids.length).to.equal(1);
       const bid = bids[0];
       expect(isValid(BASE_BID_REQUEST.adUnitCode, bid)).to.be.true;

package/test/spec/modules/teadsIdSystem_spec.js

@@ -218,7 +218,7 @@ describe('TeadsIdSystem', function () {
       callback(callbackSpy);
       const request = server.requests[0];
       expect(request.url).to.include(teadsUrl);
-      request.respond(204, null, 'Unavailable');
+      request.respond(204);
       expect(logInfoStub.calledOnce).to.be.true;
     });