prebid.js 8.7.0 → 8.9.0

package/test/spec/modules/categoryTranslation_spec.js

@@ -2,18 +2,16 @@ import { getAdserverCategoryHook, initTranslation, storage } from 'modules/categ
 import { config } from 'src/config.js';
 import * as utils from 'src/utils.js';
 import { expect } from 'chai';
+import {server} from '../../mocks/xhr.js';
 
 describe('category translation', function () {
-  let fakeTranslationServer;
   let getLocalStorageStub;
 
   beforeEach(function () {
-    fakeTranslationServer = sinon.fakeServer.create();
     getLocalStorageStub = sinon.stub(storage, 'getDataFromLocalStorage');
   });
 
   afterEach(function() {
-    fakeTranslationServer.reset();
     getLocalStorageStub.restore();
     config.resetConfig();
   });
@@ -73,7 +71,7 @@ describe('category translation', function () {
       }
     }));
     initTranslation();
-    expect(fakeTranslationServer.requests.length).to.equal(0);
+    expect(server.requests.length).to.equal(0);
     clock.restore();
   });
 
@@ -86,15 +84,15 @@ describe('category translation', function () {
       }
     }));
     initTranslation();
-    expect(fakeTranslationServer.requests.length).to.equal(1);
+    expect(server.requests.length).to.equal(1);
     clock.restore();
   });
 
   it('should use default mapping file if publisher has not defined in config', function () {
     getLocalStorageStub.returns(null);
     initTranslation('http://sample.com', 'somekey');
-    expect(fakeTranslationServer.requests.length).to.equal(1);
-    expect(fakeTranslationServer.requests[0].url).to.equal('http://sample.com');
+    expect(server.requests.length).to.equal(1);
+    expect(server.requests[0].url).to.equal('http://sample.com/');
   });
 
   it('should use publisher defined mapping file', function () {
@@ -105,7 +103,7 @@ describe('category translation', function () {
     });
     getLocalStorageStub.returns(null);
     initTranslation('http://sample.com', 'somekey');
-    expect(fakeTranslationServer.requests.length).to.equal(2);
-    expect(fakeTranslationServer.requests[0].url).to.equal('http://sample.com');
+    expect(server.requests.length).to.equal(2);
+    expect(server.requests[0].url).to.equal('http://sample.com/');
   });
 });

package/test/spec/modules/concertBidAdapter_spec.js

@@ -116,7 +116,7 @@ describe('ConcertAdapter', function () {
       expect(payload).to.have.property('meta');
       expect(payload).to.have.property('slots');
 
-      const metaRequiredFields = ['prebidVersion', 'pageUrl', 'screen', 'debug', 'uid', 'optedOut', 'adapterVersion', 'uspConsent', 'gdprConsent', 'gppConsent'];
+      const metaRequiredFields = ['prebidVersion', 'pageUrl', 'screen', 'debug', 'uid', 'optedOut', 'adapterVersion', 'uspConsent', 'gdprConsent', 'gppConsent', 'browserLanguage'];
       const slotsRequiredFields = ['name', 'bidId', 'transactionId', 'sizes', 'partnerId', 'slotType'];
 
       metaRequiredFields.forEach(function(field) {

package/test/spec/modules/conversantAnalyticsAdapter_spec.js

@@ -3,6 +3,7 @@ import {expect} from 'chai';
 import {default as conversantAnalytics, CNVR_CONSTANTS, cnvrHelper} from 'modules/conversantAnalyticsAdapter';
 import * as utils from 'src/utils.js';
 import * as prebidGlobal from 'src/prebidGlobal';
+import {server} from '../../mocks/xhr.js';
 
 import constants from 'src/constants.json'
 
@@ -10,14 +11,13 @@ let events = require('src/events');
 
 describe('Conversant analytics adapter tests', function() {
   let sandbox; // sinon sandbox to make restoring all stubbed objects easier
-  let xhr; // xhr stub from sinon for capturing data sent via ajax
   let clock; // clock stub from sinon to mock our cache cleanup interval
   let logInfoStub;
 
   const PREBID_VERSION = '1.2';
   const SITE_ID = 108060;
 
-  let requests = [];
+  let requests;
   const DATESTAMP = Date.now();
 
   const VALID_CONFIGURATION = {
@@ -36,10 +36,9 @@ describe('Conversant analytics adapter tests', function() {
   };
 
   beforeEach(function () {
+    requests = server.requests;
     sandbox = sinon.sandbox.create();
     sandbox.stub(events, 'getEvents').returns([]); // need to stub this otherwise unwanted events seem to get fired during testing
-    xhr = sandbox.useFakeXMLHttpRequest(); // allows us to capture ajax requests
-    xhr.onCreate = function (req) { requests.push(req); }; // save ajax requests in a private array for testing purposes
     let getGlobalStub = {
       version: PREBID_VERSION,
       getUserIds: function() { // userIdTargeting.js init() gets called on AUCTION_END so we need to mock this function.
@@ -60,7 +59,6 @@ describe('Conversant analytics adapter tests', function() {
 
   afterEach(function () {
     sandbox.restore();
-    requests = []; // clean up any requests in our ajax request capture array.
     conversantAnalytics.disableAnalytics();
   });
 

package/test/spec/modules/criteoBidAdapter_spec.js

@@ -703,6 +703,33 @@ describe('The Criteo bidding adapter', function () {
       expect(ortbRequest.source.tid).to.equal('abc');
     });
 
+    it('should properly transmit bidId if available', function () {
+      const bidderRequest = {
+        ortb2: {
+          source: {
+            tid: 'abc'
+          }
+        }
+      };
+      const bidRequests = [
+        {
+          bidId: 'bidId',
+          bidder: 'criteo',
+          adUnitCode: 'bid-123',
+          transactionId: 'transaction-123',
+          mediaTypes: {
+            banner: {
+              sizes: [[728, 90]]
+            }
+          },
+          params: {}
+        },
+      ];
+      const request = spec.buildRequests(bidRequests, bidderRequest);
+      const ortbRequest = request.data;
+      expect(ortbRequest.slots[0].slotid).to.equal('bidId');
+    });
+
     it('should properly build a request if refererInfo is not provided', function () {
       const bidderRequest = {};
       const bidRequests = [
@@ -1886,6 +1913,11 @@ describe('The Criteo bidding adapter', function () {
         bidRequests: [{
           adUnitCode: 'test-requestId',
           bidId: 'test-bidId',
+          mediaTypes: {
+            banner: {
+              sizes: [[728, 90]]
+            }
+          },
           params: {
             networkId: 456,
           }
@@ -1904,6 +1936,202 @@ describe('The Criteo bidding adapter', function () {
       expect(bids[0].meta.networkName).to.equal('Criteo');
     });
 
+    it('should properly parse a bid response with a networkId with twin ad unit banner win', function () {
+      const response = {
+        body: {
+          slots: [{
+            impid: 'test-requestId',
+            cpm: 1.23,
+            creative: 'test-ad',
+            creativecode: 'test-crId',
+            width: 728,
+            height: 90,
+            deal: 'myDealCode',
+            adomain: ['criteo.com'],
+            ext: {
+              meta: {
+                networkName: 'Criteo'
+              }
+            }
+          }],
+        },
+      };
+      const request = {
+        bidRequests: [{
+          adUnitCode: 'test-requestId',
+          bidId: 'test-bidId',
+          mediaTypes: {
+            video: {
+              context: 'instream',
+              mimes: ['video/mpeg'],
+              playerSize: [640, 480],
+              protocols: [5, 6],
+              maxduration: 30,
+              api: [1, 2]
+            }
+          },
+          params: {
+            networkId: 456,
+          },
+        }, {
+          adUnitCode: 'test-requestId',
+          bidId: 'test-bidId2',
+          mediaTypes: {
+            banner: {
+              sizes: [[728, 90]]
+            }
+          },
+          params: {
+            networkId: 456,
+          }
+        }]
+      };
+      const bids = spec.interpretResponse(response, request);
+      expect(bids).to.have.lengthOf(1);
+      expect(bids[0].requestId).to.equal('test-bidId2');
+      expect(bids[0].cpm).to.equal(1.23);
+      expect(bids[0].ad).to.equal('test-ad');
+      expect(bids[0].creativeId).to.equal('test-crId');
+      expect(bids[0].width).to.equal(728);
+      expect(bids[0].height).to.equal(90);
+      expect(bids[0].dealId).to.equal('myDealCode');
+      expect(bids[0].meta.advertiserDomains[0]).to.equal('criteo.com');
+      expect(bids[0].meta.networkName).to.equal('Criteo');
+    });
+
+    it('should properly parse a bid response with a networkId with twin ad unit video win', function () {
+      const response = {
+        body: {
+          slots: [{
+            impid: 'test-requestId',
+            bidId: 'abc123',
+            cpm: 1.23,
+            displayurl: 'http://test-ad',
+            width: 728,
+            height: 90,
+            zoneid: 123,
+            video: true,
+            ext: {
+              meta: {
+                networkName: 'Criteo'
+              }
+            }
+          }],
+        },
+      };
+      const request = {
+        bidRequests: [{
+          adUnitCode: 'test-requestId',
+          bidId: 'test-bidId',
+          mediaTypes: {
+            video: {
+              context: 'instream',
+              mimes: ['video/mpeg'],
+              playerSize: [728, 90],
+              protocols: [5, 6],
+              maxduration: 30,
+              api: [1, 2]
+            }
+          },
+          params: {
+            networkId: 456,
+          },
+        }, {
+          adUnitCode: 'test-requestId',
+          bidId: 'test-bidId2',
+          mediaTypes: {
+            banner: {
+              sizes: [[728, 90]]
+            }
+          },
+          params: {
+            networkId: 456,
+          }
+        }]
+      };
+      const bids = spec.interpretResponse(response, request);
+      expect(bids).to.have.lengthOf(1);
+      expect(bids[0].requestId).to.equal('test-bidId');
+      expect(bids[0].cpm).to.equal(1.23);
+      expect(bids[0].vastUrl).to.equal('http://test-ad');
+      expect(bids[0].mediaType).to.equal(VIDEO);
+    });
+
+    it('should properly parse a bid response with a networkId with twin ad unit native win', function () {
+      const response = {
+        body: {
+          slots: [{
+            impid: 'test-requestId',
+            cpm: 1.23,
+            creative: 'test-ad',
+            creativecode: 'test-crId',
+            width: 728,
+            height: 90,
+            deal: 'myDealCode',
+            adomain: ['criteo.com'],
+            native: {
+              'products': [{
+                'sendTargetingKeys': false,
+                'title': 'Product title',
+                'description': 'Product desc',
+                'price': '100',
+                'click_url': 'https://product.click',
+                'image': {
+                  'url': 'https://publisherdirect.criteo.com/publishertag/preprodtest/creative.png',
+                  'height': 300,
+                  'width': 300
+                },
+                'call_to_action': 'Try it now!'
+              }],
+              'advertiser': {
+                'description': 'sponsor',
+                'domain': 'criteo.com',
+                'logo': { 'url': 'https://www.criteo.com/images/criteo-logo.svg', 'height': 300, 'width': 300 }
+              },
+              'privacy': {
+                'optout_click_url': 'https://info.criteo.com/privacy/informations',
+                'optout_image_url': 'https://static.criteo.net/flash/icon/nai_small.png',
+              },
+              'impression_pixels': [{ 'url': 'https://my-impression-pixel/test/impression' }, { 'url': 'https://cas.com/lg.com' }]
+            },
+            ext: {
+              meta: {
+                networkName: 'Criteo'
+              }
+            }
+          }],
+        },
+      };
+      const request = {
+        bidRequests: [{
+          adUnitCode: 'test-requestId',
+          bidId: 'test-bidId',
+          mediaTypes: {
+            native: {}
+          },
+          params: {
+            networkId: 456,
+          },
+        }, {
+          adUnitCode: 'test-requestId',
+          bidId: 'test-bidId2',
+          mediaTypes: {
+            banner: {
+              sizes: [[728, 90]]
+            }
+          },
+          params: {
+            networkId: 456,
+          }
+        }]
+      };
+      const bids = spec.interpretResponse(response, request);
+      expect(bids).to.have.lengthOf(1);
+      expect(bids[0].requestId).to.equal('test-bidId');
+      expect(bids[0].cpm).to.equal(1.23);
+      expect(bids[0].mediaType).to.equal(NATIVE);
+    });
+
     it('should properly parse a bid response with a zoneId', function () {
       const response = {
         body: {

package/test/spec/modules/currency_spec.js

@@ -14,6 +14,7 @@ import {
 } from 'modules/currency.js';
 import {createBid} from '../../../src/bidfactory.js';
 import CONSTANTS from '../../../src/constants.json';
+import {server} from '../../mocks/xhr.js';
 
 var assert = require('chai').assert;
 var expect = require('chai').expect;
@@ -30,12 +31,11 @@ describe('currency', function () {
   }
 
   beforeEach(function () {
-    fakeCurrencyFileServer = sinon.fakeServer.create();
+    fakeCurrencyFileServer = server;
     ready.reset();
   });
 
   afterEach(function () {
-    fakeCurrencyFileServer.restore();
     setConfig({});
   });
 

package/test/spec/modules/dmdIdSystem_spec.js

@@ -60,7 +60,7 @@ describe('Dmd ID System', function () {
 
   it('Should invoke callback with response from API call', function () {
     const callbackSpy = sinon.spy();
-    const domain = utils.getWindowLocation()
+    const domain = utils.getWindowLocation().href;
     const callback = dmdIdSubmodule.getId(config).callback;
     callback(callbackSpy);
     const request = server.requests[0];
@@ -73,7 +73,7 @@ describe('Dmd ID System', function () {
 
   it('Should log error if API response is not valid', function () {
     const callbackSpy = sinon.spy();
-    const domain = utils.getWindowLocation()
+    const domain = utils.getWindowLocation().href;
     const callback = dmdIdSubmodule.getId(config).callback;
     callback(callbackSpy);
     const request = server.requests[0];

package/test/spec/modules/eids_spec.js

@@ -271,6 +271,39 @@ describe('eids array generation for known sub-modules', function() {
     });
   });
 
+  it('index', function() {
+    const userId = {
+      index: {'id': 'sample_id'}
+    };
+    const newEids = createEidsArray(userId);
+    expect(newEids.length).to.equal(1);
+    expect(newEids[0]).to.deep.equal({
+      source: 'liveintent.indexexchange.com',
+      uids: [{
+        id: 'sample_id',
+        atype: 3
+      }]
+    });
+  });
+
+  it('index with ext', function() {
+    const userId = {
+      index: {'id': 'sample_id', 'ext': {'provider': 'some.provider.com'}}
+    };
+    const newEids = createEidsArray(userId);
+    expect(newEids.length).to.equal(1);
+    expect(newEids[0]).to.deep.equal({
+      source: 'liveintent.indexexchange.com',
+      uids: [{
+        id: 'sample_id',
+        atype: 3,
+        ext: {
+          provider: 'some.provider.com'
+        }
+      }]
+    });
+  });
+
   it('liveIntentId; getValue call and NO ext', function() {
     const userId = {
       lipb: {
@@ -547,6 +580,21 @@ describe('eids array generation for known sub-modules', function() {
     });
   });
 
+  it('operaId', function() {
+    const userId = {
+      operaId: 'some-random-id-value'
+    };
+    const newEids = createEidsArray(userId);
+    expect(newEids.length).to.equal(1);
+    expect(newEids[0]).to.deep.equal({
+      source: 't.adx.opera.com',
+      uids: [{
+        id: 'some-random-id-value',
+        atype: 1
+      }]
+    });
+  });
+
   it('33acrossId', function() {
     const userId = {
       '33acrossId': {

package/test/spec/modules/euidIdSystem_spec.js

@@ -1,13 +1,9 @@
-import {coreStorage, init, setSubmoduleRegistry, requestBidsHook} from 'modules/userId/index.js';
+import {coreStorage, init, setSubmoduleRegistry} from 'modules/userId/index.js';
 import {config} from 'src/config.js';
-import * as utils from 'src/utils.js';
-import { euidIdSubmodule } from 'modules/euidIdSystem.js';
+import {euidIdSubmodule} from 'modules/euidIdSystem.js';
 import 'modules/consentManagement.js';
 import 'src/prebid.js';
-import { getGlobal } from 'src/prebidGlobal.js';
-import { server } from 'test/mocks/xhr.js';
-import { configureTimerInterceptors } from 'test/mocks/timers.js';
-import { cookieHelpers, runAuction, apiHelpers, setGdprApplies } from './uid2IdSystem_helpers.js';
+import {apiHelpers, cookieHelpers, runAuction, setGdprApplies} from './uid2IdSystem_helpers.js';
 import {hook} from 'src/hook.js';
 import {uninstall as uninstallGdprEnforcement} from 'modules/gdprEnforcement.js';
 
@@ -32,12 +28,15 @@ const makePrebidConfig = (params = null, extraSettings = {}, debug = false) => (
 const apiUrl = 'https://prod.euid.eu/v2/token/refresh';
 const headers = { 'Content-Type': 'application/json' };
 const makeSuccessResponseBody = () => btoa(JSON.stringify({ status: 'success', body: { ...apiHelpers.makeTokenResponse(initialToken), advertising_token: refreshedToken } }));
-const configureEuidResponse = (httpStatus, response) => server.respondWith('POST', apiUrl, (xhr) => xhr.respond(httpStatus, headers, response));
 const expectToken = (bid, token) => expect(bid?.userId ?? {}).to.deep.include(makeEuidIdentityContainer(token));
 const expectNoIdentity = (bid) => expect(bid).to.not.haveOwnProperty('userId');
 
 describe('EUID module', function() {
   let suiteSandbox, testSandbox, timerSpy, fullTestTitle, restoreSubtleToUndefined = false;
+  let server;
+
+  const configureEuidResponse = (httpStatus, response) => server.respondWith('POST', apiUrl, (xhr) => xhr.respond(httpStatus, headers, response));
+
   before(function() {
     uninstallGdprEnforcement();
     hook.ready();
@@ -54,10 +53,12 @@ describe('EUID module', function() {
     if (restoreSubtleToUndefined) window.crypto.subtle = undefined;
   });
   beforeEach(function() {
+    server = sinon.createFakeServer();
     init(config);
     setSubmoduleRegistry([euidIdSubmodule]);
   });
   afterEach(function() {
+    server.restore();
     $$PREBID_GLOBAL$$.requestBids.removeAll();
     config.resetConfig();
     cookieHelpers.clearCookies(moduleCookieName, publisherCookieName);
@@ -116,7 +117,7 @@ describe('EUID module', function() {
     const euidToken = apiHelpers.makeTokenResponse(initialToken, true, true);
     configureEuidResponse(200, makeSuccessResponseBody());
     config.setConfig(makePrebidConfig({euidToken}));
-    apiHelpers.respondAfterDelay(1);
+    apiHelpers.respondAfterDelay(1, server);
     const bid = await runAuction();
     expectToken(bid, refreshedToken);
   });

package/test/spec/modules/feedadBidAdapter_spec.js

@@ -621,7 +621,7 @@ describe('FeedAdAdapter', function () {
           expect(call.url).to.equal('https://api.feedad.com/1/prebid/web/events');
           expect(JSON.parse(call.requestBody)).to.deep.equal(expectedData);
           expect(call.method).to.equal('POST');
-          expect(call.requestHeaders).to.include({'Content-Type': 'application/json;charset=utf-8'});
+          expect(call.requestHeaders).to.include({'Content-Type': 'application/json'});
         })
       });
     });