prebid.js 8.44.0 → 8.45.0

package/test/spec/unit/core/adapterManager_spec.js

@@ -12,7 +12,7 @@ import {
   getServerTestingsAds,
   getBidRequests
 } from 'test/fixtures/fixtures.js';
-import CONSTANTS from 'src/constants.json';
+import { EVENTS, S2S } from 'src/constants.js';
 import * as utils from 'src/utils.js';
 import { config } from 'src/config.js';
 import { registerBidder } from 'src/adapters/bidderFactory.js';
@@ -24,11 +24,13 @@ import {auctionManager} from '../../../../src/auctionManager.js';
 import {GDPR_GVLIDS} from '../../../../src/consentHandler.js';
 import {MODULE_TYPE_ANALYTICS, MODULE_TYPE_BIDDER} from '../../../../src/activities/modules.js';
 import {ACTIVITY_FETCH_BIDS, ACTIVITY_REPORT_ANALYTICS} from '../../../../src/activities/activities.js';
+import {reset as resetAdUnitCounters} from '../../../../src/adUnits.js';
+import {deepClone} from 'src/utils.js';
 var events = require('../../../../src/events');
 
 const CONFIG = {
   enabled: true,
-  endpoint: CONSTANTS.S2S.DEFAULT_ENDPOINT,
+  endpoint: S2S.DEFAULT_ENDPOINT,
   timeout: 1000,
   maxBids: 1,
   adapter: 'prebidServer',
@@ -172,7 +174,7 @@ describe('adapterManager tests', function () {
       // function to count BID_REQUESTED events
       let cnt = 0;
       let count = () => cnt++;
-      events.on(CONSTANTS.EVENTS.BID_REQUESTED, count);
+      events.on(EVENTS.BID_REQUESTED, count);
       let bidRequests = [{
         'bidderCode': 'appnexus',
         'auctionId': '1863e370099523',
@@ -207,7 +209,7 @@ describe('adapterManager tests', function () {
       adapterManager.callBids(adUnits, bidRequests, () => {}, () => {});
       expect(cnt).to.equal(1);
       sinon.assert.calledOnce(appnexusAdapterMock.callBids);
-      events.off(CONSTANTS.EVENTS.BID_REQUESTED, count);
+      events.off(EVENTS.BID_REQUESTED, count);
     });
 
     it('should give bidders access to bidder-specific config', function(done) {
@@ -390,7 +392,7 @@ describe('adapterManager tests', function () {
       });
 
       it('should NOT call onBidWon when the bid is S2S', () => {
-        bids[0].src = CONSTANTS.S2S.SRC
+        bids[0].src = S2S.SRC
         adapterManager.callBidWonBidder(bids[0].bidder, bids[0], adUnits);
         sinon.assert.notCalled(criteoSpec.onBidWon);
       })
@@ -407,7 +409,7 @@ describe('adapterManager tests', function () {
       });
 
       it('should NOT call onSetTargeting when bid is S2S', () => {
-        bids[0].src = CONSTANTS.S2S.SRC;
+        bids[0].src = S2S.SRC;
         adapterManager.callSetTargetingBidder(bids[0].bidder, bids[0], adUnits);
         sinon.assert.notCalled(criteoSpec.onSetTargeting);
       })
@@ -421,7 +423,7 @@ describe('adapterManager tests', function () {
         sinon.assert.called(criteoSpec.onBidViewable);
       });
       it('should NOT call onBidViewable when bid is S2S', () => {
-        bids[0].src = CONSTANTS.S2S.SRC;
+        bids[0].src = S2S.SRC;
         adapterManager.callBidViewableBidder(bids[0].bidder, bids[0]);
         sinon.assert.notCalled(criteoSpec.onBidViewable);
       })
@@ -649,11 +651,11 @@ describe('adapterManager tests', function () {
       beforeEach(function () {
         prebidServerAdapterMock.callBids.reset();
         cnt = 0;
-        events.on(CONSTANTS.EVENTS.BID_REQUESTED, count);
+        events.on(EVENTS.BID_REQUESTED, count);
       });
 
       afterEach(function () {
-        events.off(CONSTANTS.EVENTS.BID_REQUESTED, count);
+        events.off(EVENTS.BID_REQUESTED, count);
       });
 
       it('should fire for s2s requests', function () {
@@ -1037,11 +1039,11 @@ describe('adapterManager tests', function () {
       beforeEach(function () {
         prebidServerAdapterMock.callBids.reset();
         cnt = 0;
-        events.on(CONSTANTS.EVENTS.BID_REQUESTED, count);
+        events.on(EVENTS.BID_REQUESTED, count);
       });
 
       afterEach(function () {
-        events.off(CONSTANTS.EVENTS.BID_REQUESTED, count);
+        events.off(EVENTS.BID_REQUESTED, count);
       });
 
       it('should fire for s2s requests', function () {
@@ -1675,12 +1677,24 @@ describe('adapterManager tests', function () {
   describe('makeBidRequests', function () {
     let adUnits;
     beforeEach(function () {
+      resetAdUnitCounters();
       adUnits = utils.deepClone(getAdUnits()).map(adUnit => {
         adUnit.bids = adUnit.bids.filter(bid => includes(['appnexus', 'rubicon'], bid.bidder));
         return adUnit;
       })
     });
 
+    function makeBidRequests(au = adUnits) {
+      return adapterManager.makeBidRequests(
+        au,
+        Date.now(),
+        utils.getUniqueIdentifierStr(),
+        function callback() {
+        },
+        []
+      );
+    }
+
     if (FEATURES.NATIVE) {
       it('should add nativeParams to adUnits after BEFORE_REQUEST_BIDS', () => {
         function beforeReqBids(adUnits) {
@@ -1691,16 +1705,9 @@ describe('adapterManager tests', function () {
           })
         }
 
-        events.on(CONSTANTS.EVENTS.BEFORE_REQUEST_BIDS, beforeReqBids);
-        adapterManager.makeBidRequests(
-          adUnits,
-          Date.now(),
-          utils.getUniqueIdentifierStr(),
-          function callback() {
-          },
-          []
-        );
-        events.off(CONSTANTS.EVENTS.BEFORE_REQUEST_BIDS, beforeReqBids);
+        events.on(EVENTS.BEFORE_REQUEST_BIDS, beforeReqBids);
+        makeBidRequests();
+        events.off(EVENTS.BEFORE_REQUEST_BIDS, beforeReqBids);
         expect(adUnits.map((u) => u.nativeParams).some(i => i == null)).to.be.false;
       });
     }
@@ -1708,13 +1715,7 @@ describe('adapterManager tests', function () {
     it('should make separate bidder request objects for each bidder', () => {
       adUnits = [utils.deepClone(getAdUnits()[0])];
 
-      let bidRequests = adapterManager.makeBidRequests(
-        adUnits,
-        Date.now(),
-        utils.getUniqueIdentifierStr(),
-        function callback() {},
-        []
-      );
+      let bidRequests = makeBidRequests();
 
       let sizes1 = bidRequests[1].bids[0].sizes;
       let sizes2 = bidRequests[0].bids[0].sizes;
@@ -1725,6 +1726,70 @@ describe('adapterManager tests', function () {
       expect(sizes1).not.to.deep.equal(sizes2);
     });
 
+    it('should set and increment bidRequestsCounter', () => {
+      const [au1, au2] = adUnits;
+      makeBidRequests([au1, au2]).flatMap(br => br.bids).forEach(bid => {
+        expect(bid.bidRequestsCount).to.eql(1);
+      })
+      makeBidRequests([au1]);
+      makeBidRequests([au1, au2]).flatMap(br => br.bids).forEach(bid => {
+        expect(bid.bidRequestsCount).to.eql(bid.adUnitCode === au1.code ? 3 : 2);
+      });
+    })
+
+    describe('bidderRequestsCounter', () => {
+      it('should be set and incremented', () => {
+        const [au1, au2] = adUnits;
+        makeBidRequests([au1, au2]).flatMap(br => br.bids).forEach(bid => {
+          expect(bid.bidderRequestsCount).to.eql(1);
+        });
+        const au3 = {
+          ...au2,
+          bids: [
+            au2.bids[0]
+          ]
+        }
+        makeBidRequests([au3]);
+        const counts = Object.fromEntries(
+          makeBidRequests([au1, au2])
+            .map(br => [br.bidderCode, Object.fromEntries(br.bids.map(bid => [bid.adUnitCode, bid.bidderRequestsCount]))])
+        );
+        expect(counts).to.eql({
+          rubicon: {
+            [au2.code]: 2
+          },
+          appnexus: {
+            [au1.code]: 2,
+            [au2.code]: 3
+          },
+        });
+      });
+
+      it('should NOT be incremented for s2s bids', () => {
+        config.setConfig({
+          s2sConfig: {
+            enabled: true,
+            adapter: 'rubicon',
+            bidders: ['appnexus']
+          }
+        });
+        function expectBidderCounts(bidders) {
+          makeBidRequests().forEach(br => {
+            br.bids.forEach(bid => expect(bid.bidderRequestsCount).to.exist.and.eql(bidders[br.bidderCode]));
+          })
+        }
+        expectBidderCounts({
+          appnexus: 0,
+          rubicon: 1
+        });
+        config.resetConfig();
+        expectBidderCounts({
+          appnexus: 1,
+          rubicon: 2
+        })
+      })
+    });
+
     describe('and activity controls', () => {
       let redactOrtb2;
       let redactBidRequest;
@@ -1757,13 +1822,7 @@ describe('adapterManager tests', function () {
             componentType === MODULE_TYPE_BIDDER &&
             allowed.includes(componentName);
         });
-        let reqs = adapterManager.makeBidRequests(
-          adUnits,
-          Date.now(),
-          utils.getUniqueIdentifierStr(),
-          function callback() {},
-          []
-        );
+        let reqs = makeBidRequests();
         const bidders = Array.from(new Set(reqs.flatMap(br => br.bids).map(bid => bid.bidder)).keys());
         expect(bidders).to.have.members(allowed);
       });
@@ -1773,13 +1832,7 @@ describe('adapterManager tests', function () {
         adUnits = [
           {code: 'one', bids: [{bidder: 'mockBidder1'}]}
         ];
-        let reqs = adapterManager.makeBidRequests(
-          adUnits,
-          Date.now(),
-          utils.getUniqueIdentifierStr(),
-          function callback() {},
-          []
-        );
+        let reqs = makeBidRequests();
         sinon.assert.calledWith(redactBidRequest, reqs[0].bids[0]);
         sinon.assert.calledWith(redactOrtb2, reqs[0].ortb2);
       })
@@ -1812,13 +1865,7 @@ describe('adapterManager tests', function () {
             {code: 'two', bids: [{module: 'pbsBidAdapter', params: {configName: 'mock1'}}, {module: 'pbsBidAdapter', params: {configName: 'mock2'}}]}
           ]
           dep.isAllowed.callsFake(({componentType}) => componentType !== 'bidder');
-          let bidRequests = adapterManager.makeBidRequests(
-            adUnits,
-            Date.now(),
-            utils.getUniqueIdentifierStr(),
-            function callback() {},
-            []
-          );
+          let bidRequests = makeBidRequests();
           expect(new Set(bidRequests.map(br => br.uniquePbsTid)).size).to.equal(3);
         });
 
@@ -1835,14 +1882,7 @@ describe('adapterManager tests', function () {
             }
           ];
           dep.isAllowed.callsFake((_, {configName, componentName}) => !(componentName === 'pbsBidAdapter' && configName === 'mock1'));
-          let bidRequests = adapterManager.makeBidRequests(
-            adUnits,
-            Date.now(),
-            utils.getUniqueIdentifierStr(),
-            function callback() {
-            },
-            []
-          );
+          let bidRequests = makeBidRequests();
           expect(new Set(bidRequests.map(br => br.uniquePbsTid)).size).to.eql(2)
         });
       });
@@ -2075,11 +2115,11 @@ describe('adapterManager tests', function () {
         const ortb2Fragments = {};
         const req = {
           bidderCode: 'appnexus',
-          src: CONSTANTS.S2S.SRC,
+          src: S2S.SRC,
           adUnitsS2SCopy: adUnits,
           bids: [{
             bidder: 'appnexus',
-            src: CONSTANTS.S2S.SRC
+            src: S2S.SRC
           }]
         };
         adapterManager.callBids(adUnits, [req], sinon.stub(), sinon.stub(), {request: sinon.stub(), done: sinon.stub()}, 1000, sinon.stub(), ortb2Fragments);

package/test/spec/unit/core/bidderFactory_spec.js

@@ -5,7 +5,7 @@ import {expect} from 'chai';
 import {userSync} from 'src/userSync.js';
 import * as utils from 'src/utils.js';
 import {config} from 'src/config.js';
-import CONSTANTS from 'src/constants.json';
+import { EVENTS } from 'src/constants.js';
 import * as events from 'src/events.js';
 import {hook} from '../../../../src/hook.js';
 import {auctionManager} from '../../../../src/auctionManager.js';
@@ -552,7 +552,7 @@ describe('bidderFactory', () => {
 
         expect(ajaxStub.calledTwice).to.equal(true);
         expect(eventEmitterSpy.getCalls()
-          .filter(call => call.args[0] === CONSTANTS.EVENTS.BEFORE_BIDDER_HTTP)
+          .filter(call => call.args[0] === EVENTS.BEFORE_BIDDER_HTTP)
         ).to.length(2);
 
         eventEmitterSpy.restore();
@@ -863,7 +863,7 @@ describe('bidderFactory', () => {
         expect(callBidderErrorStub.firstCall.args[0]).to.equal(CODE);
         expect(callBidderErrorStub.firstCall.args[1]).to.equal(xhrErrorMock);
         expect(callBidderErrorStub.firstCall.args[2]).to.equal(MOCK_BIDS_REQUEST);
-        sinon.assert.calledWith(eventEmitterStub, CONSTANTS.EVENTS.BIDDER_ERROR, {
+        sinon.assert.calledWith(eventEmitterStub, EVENTS.BIDDER_ERROR, {
           error: xhrErrorMock,
           bidderRequest: MOCK_BIDS_REQUEST
         });
@@ -889,7 +889,7 @@ describe('bidderFactory', () => {
         expect(callBidderErrorStub.firstCall.args[0]).to.equal(CODE);
         expect(callBidderErrorStub.firstCall.args[1]).to.equal(xhrErrorMock);
         expect(callBidderErrorStub.firstCall.args[2]).to.equal(MOCK_BIDS_REQUEST);
-        sinon.assert.calledWith(eventEmitterStub, CONSTANTS.EVENTS.BIDDER_ERROR, {
+        sinon.assert.calledWith(eventEmitterStub, EVENTS.BIDDER_ERROR, {
           error: xhrErrorMock,
           bidderRequest: MOCK_BIDS_REQUEST
         });
@@ -915,7 +915,7 @@ describe('bidderFactory', () => {
         expect(callBidderErrorStub.firstCall.args[0]).to.equal(CODE);
         expect(callBidderErrorStub.firstCall.args[1]).to.equal(xhrErrorMock);
         expect(callBidderErrorStub.firstCall.args[2]).to.equal(MOCK_BIDS_REQUEST);
-        sinon.assert.calledWith(eventEmitterStub, CONSTANTS.EVENTS.BIDDER_ERROR, {
+        sinon.assert.calledWith(eventEmitterStub, EVENTS.BIDDER_ERROR, {
           error: xhrErrorMock,
           bidderRequest: MOCK_BIDS_REQUEST
         });
@@ -941,7 +941,7 @@ describe('bidderFactory', () => {
         expect(callBidderErrorStub.firstCall.args[0]).to.equal(CODE);
         expect(callBidderErrorStub.firstCall.args[1]).to.equal(xhrErrorMock);
         expect(callBidderErrorStub.firstCall.args[2]).to.equal(MOCK_BIDS_REQUEST);
-        sinon.assert.calledWith(eventEmitterStub, CONSTANTS.EVENTS.BIDDER_ERROR, {
+        sinon.assert.calledWith(eventEmitterStub, EVENTS.BIDDER_ERROR, {
           error: xhrErrorMock,
           bidderRequest: MOCK_BIDS_REQUEST
         });

package/test/spec/unit/core/targeting_spec.js

@@ -7,7 +7,7 @@ import {
 } from 'src/targeting.js';
 import {config} from 'src/config.js';
 import {createBidReceived} from 'test/fixtures/fixtures.js';
-import CONSTANTS from 'src/constants.json';
+import { DEFAULT_TARGETING_KEYS, JSON_MAPPING, NATIVE_KEYS, STATUS, TARGETING_KEYS } from 'src/constants.js';
 import {auctionManager} from 'src/auctionManager.js';
 import * as utils from 'src/utils.js';
 import {deepClone} from 'src/utils.js';
@@ -15,7 +15,7 @@ import {createBid} from '../../../../src/bidfactory.js';
 import {hook} from '../../../../src/hook.js';
 import {getHighestCpm} from '../../../../src/utils/reducers.js';
 
-function mkBid(bid, status = CONSTANTS.STATUS.GOOD) {
+function mkBid(bid, status = STATUS.GOOD) {
   return Object.assign(createBid(status), bid);
 }
 
@@ -40,10 +40,10 @@ const sampleBid = {
   'size': '300x250',
   'adserverTargeting': {
     'foobar': '300x250',
-    [CONSTANTS.TARGETING_KEYS.BIDDER]: 'rubicon',
-    [CONSTANTS.TARGETING_KEYS.AD_ID]: '148018fe5e',
-    [CONSTANTS.TARGETING_KEYS.PRICE_BUCKET]: '0.53',
-    [CONSTANTS.TARGETING_KEYS.DEAL]: '1234'
+    [TARGETING_KEYS.BIDDER]: 'rubicon',
+    [TARGETING_KEYS.AD_ID]: '148018fe5e',
+    [TARGETING_KEYS.PRICE_BUCKET]: '0.53',
+    [TARGETING_KEYS.DEAL]: '1234'
   },
   'dealId': '1234',
   'netRevenue': true,
@@ -74,9 +74,9 @@ const bid2 = mkBid({
   'size': '300x250',
   'adserverTargeting': {
     'foobar': '300x250',
-    [CONSTANTS.TARGETING_KEYS.BIDDER]: 'rubicon',
-    [CONSTANTS.TARGETING_KEYS.AD_ID]: '5454545',
-    [CONSTANTS.TARGETING_KEYS.PRICE_BUCKET]: '0.25'
+    [TARGETING_KEYS.BIDDER]: 'rubicon',
+    [TARGETING_KEYS.AD_ID]: '5454545',
+    [TARGETING_KEYS.PRICE_BUCKET]: '0.25'
   },
   'netRevenue': true,
   'currency': 'USD',
@@ -104,9 +104,9 @@ const bid3 = mkBid({
   'size': '300x600',
   'adserverTargeting': {
     'foobar': '300x600',
-    [CONSTANTS.TARGETING_KEYS.BIDDER]: 'rubicon',
-    [CONSTANTS.TARGETING_KEYS.AD_ID]: '48747745',
-    [CONSTANTS.TARGETING_KEYS.PRICE_BUCKET]: '0.75'
+    [TARGETING_KEYS.BIDDER]: 'rubicon',
+    [TARGETING_KEYS.AD_ID]: '48747745',
+    [TARGETING_KEYS.PRICE_BUCKET]: '0.75'
   },
   'netRevenue': true,
   'currency': 'USD',
@@ -166,18 +166,18 @@ const nativeBid1 = mkBid({
   'pbCg': '',
   'size': '0x0',
   'adserverTargeting': {
-    [CONSTANTS.TARGETING_KEYS.BIDDER]: 'appnexus',
-    [CONSTANTS.TARGETING_KEYS.AD_ID]: '591e7c9354b633',
-    [CONSTANTS.TARGETING_KEYS.PRICE_BUCKET]: '10.00',
-    [CONSTANTS.TARGETING_KEYS.SIZE]: '0x0',
-    [CONSTANTS.TARGETING_KEYS.SOURCE]: 'client',
-    [CONSTANTS.TARGETING_KEYS.FORMAT]: 'native',
-    [CONSTANTS.NATIVE_KEYS.title]: 'This is a Prebid Native Creative',
-    [CONSTANTS.NATIVE_KEYS.body]: 'This is a Prebid Native Creative. There are many like it, but this one is mine.',
-    [CONSTANTS.NATIVE_KEYS.sponsoredBy]: 'Prebid.org',
-    [CONSTANTS.NATIVE_KEYS.clickUrl]: 'http://prebid.org/dev-docs/show-native-ads.html',
-    [CONSTANTS.NATIVE_KEYS.image]: 'http://vcdn.adnxs.com/p/creative-image/94/22/cd/0f/9422cd0f-f400-45d3-80f5-2b92629d9257.jpg',
-    [CONSTANTS.NATIVE_KEYS.icon]: 'http://vcdn.adnxs.com/p/creative-image/bd/59/a6/c6/bd59a6c6-0851-411d-a16d-031475a51312.png'
+    [TARGETING_KEYS.BIDDER]: 'appnexus',
+    [TARGETING_KEYS.AD_ID]: '591e7c9354b633',
+    [TARGETING_KEYS.PRICE_BUCKET]: '10.00',
+    [TARGETING_KEYS.SIZE]: '0x0',
+    [TARGETING_KEYS.SOURCE]: 'client',
+    [TARGETING_KEYS.FORMAT]: 'native',
+    [NATIVE_KEYS.title]: 'This is a Prebid Native Creative',
+    [NATIVE_KEYS.body]: 'This is a Prebid Native Creative. There are many like it, but this one is mine.',
+    [NATIVE_KEYS.sponsoredBy]: 'Prebid.org',
+    [NATIVE_KEYS.clickUrl]: 'http://prebid.org/dev-docs/show-native-ads.html',
+    [NATIVE_KEYS.image]: 'http://vcdn.adnxs.com/p/creative-image/94/22/cd/0f/9422cd0f-f400-45d3-80f5-2b92629d9257.jpg',
+    [NATIVE_KEYS.icon]: 'http://vcdn.adnxs.com/p/creative-image/bd/59/a6/c6/bd59a6c6-0851-411d-a16d-031475a51312.png'
   }
 });
 
@@ -225,17 +225,17 @@ const nativeBid2 = mkBid({
   'pbCg': '',
   'size': '0x0',
   'adserverTargeting': {
-    [CONSTANTS.TARGETING_KEYS.BIDDER]: 'dgads',
-    [CONSTANTS.TARGETING_KEYS.AD_ID]: '6e0aba55ed54e5',
-    [CONSTANTS.TARGETING_KEYS.PRICE_BUCKET]: '1.90',
-    [CONSTANTS.TARGETING_KEYS.SIZE]: '0x0',
-    [CONSTANTS.TARGETING_KEYS.SOURCE]: 'client',
-    [CONSTANTS.TARGETING_KEYS.FORMAT]: 'native',
-    [CONSTANTS.NATIVE_KEYS.image]: 'https://ads-tr.bigmining.com/img/300x250.png',
-    [CONSTANTS.NATIVE_KEYS.title]: 'Test Title',
-    [CONSTANTS.NATIVE_KEYS.body]: 'Test Description',
-    [CONSTANTS.NATIVE_KEYS.sponsoredBy]: 'test.com',
-    [CONSTANTS.NATIVE_KEYS.clickUrl]: 'http://prebid.org/'
+    [TARGETING_KEYS.BIDDER]: 'dgads',
+    [TARGETING_KEYS.AD_ID]: '6e0aba55ed54e5',
+    [TARGETING_KEYS.PRICE_BUCKET]: '1.90',
+    [TARGETING_KEYS.SIZE]: '0x0',
+    [TARGETING_KEYS.SOURCE]: 'client',
+    [TARGETING_KEYS.FORMAT]: 'native',
+    [NATIVE_KEYS.image]: 'https://ads-tr.bigmining.com/img/300x250.png',
+    [NATIVE_KEYS.title]: 'Test Title',
+    [NATIVE_KEYS.body]: 'Test Description',
+    [NATIVE_KEYS.sponsoredBy]: 'test.com',
+    [NATIVE_KEYS.clickUrl]: 'http://prebid.org/'
   }
 });
 
@@ -351,7 +351,7 @@ describe('targeting tests', function () {
           return [
             {
               'code': adUnitCode,
-              [CONSTANTS.JSON_MAPPING.ADSERVER_TARGETING]: adServerTargeting
+              [JSON_MAPPING.ADSERVER_TARGETING]: adServerTargeting
             }
           ];
         });
@@ -489,7 +489,7 @@ describe('targeting tests', function () {
         });
 
         const targeting = targetingInstance.getAllTargeting(['/123456/header-bid-tag-0']);
-        let limitedBids = Object.keys(targeting['/123456/header-bid-tag-0']).filter(key => key.indexOf(CONSTANTS.TARGETING_KEYS.PRICE_BUCKET + '_') != -1)
+        let limitedBids = Object.keys(targeting['/123456/header-bid-tag-0']).filter(key => key.indexOf(TARGETING_KEYS.PRICE_BUCKET + '_') != -1)
 
         expect(limitedBids.length).to.equal(1);
       });
@@ -502,7 +502,7 @@ describe('targeting tests', function () {
         });
 
         const targeting = targetingInstance.getAllTargeting(['/123456/header-bid-tag-0']);
-        let limitedBids = Object.keys(targeting['/123456/header-bid-tag-0']).filter(key => key.indexOf(CONSTANTS.TARGETING_KEYS.PRICE_BUCKET + '_') != -1)
+        let limitedBids = Object.keys(targeting['/123456/header-bid-tag-0']).filter(key => key.indexOf(TARGETING_KEYS.PRICE_BUCKET + '_') != -1)
 
         expect(limitedBids.length).to.equal(2);
       });
@@ -515,7 +515,7 @@ describe('targeting tests', function () {
         });
 
         const targeting = targetingInstance.getAllTargeting(['/123456/header-bid-tag-0']);
-        let limitedBids = Object.keys(targeting['/123456/header-bid-tag-0']).filter(key => key.indexOf(CONSTANTS.TARGETING_KEYS.PRICE_BUCKET + '_') != -1)
+        let limitedBids = Object.keys(targeting['/123456/header-bid-tag-0']).filter(key => key.indexOf(TARGETING_KEYS.PRICE_BUCKET + '_') != -1)
 
         expect(limitedBids.length).to.equal(2);
       });
@@ -611,7 +611,7 @@ describe('targeting tests', function () {
       beforeEach(function () {
         bidsReceived = [bid1, bid2, nativeBid1, nativeBid2].map(deepClone);
         bidsReceived.forEach((bid) => {
-          bid.adserverTargeting[CONSTANTS.TARGETING_KEYS.SOURCE] = 'test-source';
+          bid.adserverTargeting[TARGETING_KEYS.SOURCE] = 'test-source';
           bid.adUnitCode = 'adunit';
           if (winningBid == null || bid.cpm > winningBid.cpm) {
             winningBid = bid;
@@ -642,7 +642,7 @@ describe('targeting tests', function () {
             addTargetingKeys: ['SOURCE']
           }
         });
-        expect(targetingResult()).to.include.all.keys(...expandKey(CONSTANTS.TARGETING_KEYS.SOURCE));
+        expect(targetingResult()).to.include.all.keys(...expandKey(TARGETING_KEYS.SOURCE));
       });
 
       it('should keep default and native keys', function() {
@@ -651,9 +651,9 @@ describe('targeting tests', function () {
             addTargetingKeys: ['SOURCE']
           }
         });
-        const defaultKeys = new Set(Object.values(CONSTANTS.DEFAULT_TARGETING_KEYS));
+        const defaultKeys = new Set(Object.values(DEFAULT_TARGETING_KEYS));
         if (FEATURES.NATIVE) {
-          Object.values(CONSTANTS.NATIVE_KEYS).forEach((k) => defaultKeys.add(k));
+          Object.values(NATIVE_KEYS).forEach((k) => defaultKeys.add(k));
         }
 
         const expectedKeys = new Set();
@@ -670,8 +670,8 @@ describe('targeting tests', function () {
       it('should not be allowed together with allowTargetingKeys', function () {
         config.setConfig({
           targetingControls: {
-            allowTargetingKeys: [CONSTANTS.TARGETING_KEYS.BIDDER],
-            addTargetingKeys: [CONSTANTS.TARGETING_KEYS.SOURCE]
+            allowTargetingKeys: [TARGETING_KEYS.BIDDER],
+            addTargetingKeys: [TARGETING_KEYS.SOURCE]
           }
         });
         expect(targetingResult).to.throw();
@@ -849,12 +849,12 @@ describe('targeting tests', function () {
       // we should only get the targeting data for the one requested adunit
       expect(Object.keys(targeting).length).to.equal(1);
 
-      let sendAllBidCpm = Object.keys(targeting['/123456/header-bid-tag-0']).filter(key => key.indexOf(CONSTANTS.TARGETING_KEYS.PRICE_BUCKET + '_') != -1)
+      let sendAllBidCpm = Object.keys(targeting['/123456/header-bid-tag-0']).filter(key => key.indexOf(TARGETING_KEYS.PRICE_BUCKET + '_') != -1)
       // we shouldn't get more than 1 key for hb_pb_${bidder}
       expect(sendAllBidCpm.length).to.equal(1);
 
       // expect the winning CPM to be equal to the sendAllBidCPM
-      expect(targeting['/123456/header-bid-tag-0'][CONSTANTS.TARGETING_KEYS.PRICE_BUCKET + '_rubicon']).to.deep.equal(targeting['/123456/header-bid-tag-0'][CONSTANTS.TARGETING_KEYS.PRICE_BUCKET]);
+      expect(targeting['/123456/header-bid-tag-0'][TARGETING_KEYS.PRICE_BUCKET + '_rubicon']).to.deep.equal(targeting['/123456/header-bid-tag-0'][TARGETING_KEYS.PRICE_BUCKET]);
     });
 
     if (FEATURES.NATIVE) {