prebid.js 8.44.0 → 8.45.0

package/test/spec/auctionmanager_spec.js

@@ -7,7 +7,7 @@ import {
   getPriceByGranularity,
   addBidResponse, resetAuctionState, responsesReady
 } from 'src/auction.js';
-import CONSTANTS from 'src/constants.json';
+import { EVENTS, TARGETING_KEYS, S2S } from 'src/constants.js';
 import * as auctionModule from 'src/auction.js';
 import { registerBidder } from 'src/adapters/bidderFactory.js';
 import { createBid } from 'src/bidfactory.js';
@@ -110,8 +110,8 @@ function mockBidRequest(bid, opts) {
     'auctionId': opts && opts.auctionId,
     'bidderRequestId': requestId,
     src: bid?._ctx?.src,
-    adUnitsS2SCopy: bid?._ctx?.src === CONSTANTS.S2S.SRC ? bid?._ctx?.adUnits : undefined,
-    uniquePbsTid: bid?._ctx?.src === CONSTANTS.S2S.SRC ? bid?._ctx?.uniquePbsTid : undefined,
+    adUnitsS2SCopy: bid?._ctx?.src === S2S.SRC ? bid?._ctx?.adUnits : undefined,
+    uniquePbsTid: bid?._ctx?.src === S2S.SRC ? bid?._ctx?.uniquePbsTid : undefined,
     'bids': [
       {
         'bidder': bidderCode || bid.bidderCode,
@@ -215,20 +215,20 @@ describe('auctionmanager.js', function () {
     /* return the expected response for a given bid, filter by keys if given */
     function getDefaultExpected(bid, keys) {
       var expected = {};
-      expected[ CONSTANTS.TARGETING_KEYS.BIDDER ] = bid.bidderCode;
-      expected[ CONSTANTS.TARGETING_KEYS.AD_ID ] = bid.adId;
-      expected[ CONSTANTS.TARGETING_KEYS.PRICE_BUCKET ] = bid.pbMg;
-      expected[ CONSTANTS.TARGETING_KEYS.SIZE ] = bid.getSize();
-      expected[ CONSTANTS.TARGETING_KEYS.SOURCE ] = bid.source;
-      expected[ CONSTANTS.TARGETING_KEYS.FORMAT ] = bid.mediaType;
-      expected[ CONSTANTS.TARGETING_KEYS.ADOMAIN ] = bid.meta.advertiserDomains[0];
-      expected[ CONSTANTS.TARGETING_KEYS.ACAT ] = bid.meta.primaryCatId;
-      expected[ CONSTANTS.TARGETING_KEYS.DSP ] = bid.meta.networkId;
-      expected[ CONSTANTS.TARGETING_KEYS.CRID ] = bid.creativeId;
+      expected[TARGETING_KEYS.BIDDER] = bid.bidderCode;
+      expected[TARGETING_KEYS.AD_ID] = bid.adId;
+      expected[TARGETING_KEYS.PRICE_BUCKET] = bid.pbMg;
+      expected[TARGETING_KEYS.SIZE] = bid.getSize();
+      expected[TARGETING_KEYS.SOURCE] = bid.source;
+      expected[TARGETING_KEYS.FORMAT] = bid.mediaType;
+      expected[TARGETING_KEYS.ADOMAIN] = bid.meta.advertiserDomains[0];
+      expected[TARGETING_KEYS.ACAT] = bid.meta.primaryCatId;
+      expected[TARGETING_KEYS.DSP] = bid.meta.networkId;
+      expected[TARGETING_KEYS.CRID] = bid.creativeId;
       if (bid.mediaType === 'video') {
-        expected[ CONSTANTS.TARGETING_KEYS.UUID ] = bid.videoCacheKey;
-        expected[ CONSTANTS.TARGETING_KEYS.CACHE_ID ] = bid.videoCacheKey;
-        expected[ CONSTANTS.TARGETING_KEYS.CACHE_HOST ] = 'prebid.adnxs.com';
+        expected[TARGETING_KEYS.UUID] = bid.videoCacheKey;
+        expected[TARGETING_KEYS.CACHE_ID] = bid.videoCacheKey;
+        expected[TARGETING_KEYS.CACHE_HOST] = 'prebid.adnxs.com';
       }
       if (!keys) {
         return expected;
@@ -288,59 +288,59 @@ describe('auctionmanager.js', function () {
         standard: {
           adserverTargeting: [
             {
-              key: CONSTANTS.TARGETING_KEYS.BIDDER,
+              key: TARGETING_KEYS.BIDDER,
               val: function (bidResponse) {
                 return bidResponse.bidderCode;
               }
             }, {
-              key: CONSTANTS.TARGETING_KEYS.AD_ID,
+              key: TARGETING_KEYS.AD_ID,
               val: function (bidResponse) {
                 return bidResponse.adId;
               }
             }, {
-              key: CONSTANTS.TARGETING_KEYS.PRICE_BUCKET,
+              key: TARGETING_KEYS.PRICE_BUCKET,
               val: function (bidResponse) {
                 // change default here
                 return bidResponse.pbHg;
               }
             }, {
-              key: CONSTANTS.TARGETING_KEYS.SIZE,
+              key: TARGETING_KEYS.SIZE,
               val: function (bidResponse) {
                 return bidResponse.size;
               }
             },
             {
-              key: CONSTANTS.TARGETING_KEYS.SOURCE,
+              key: TARGETING_KEYS.SOURCE,
               val: function (bidResponse) {
                 return bidResponse.source;
               }
             },
             {
-              key: CONSTANTS.TARGETING_KEYS.FORMAT,
+              key: TARGETING_KEYS.FORMAT,
               val: function (bidResponse) {
                 return bidResponse.mediaType;
               }
             },
             {
-              key: CONSTANTS.TARGETING_KEYS.ADOMAIN,
+              key: TARGETING_KEYS.ADOMAIN,
               val: function (bidResponse) {
                 return bidResponse.meta.advertiserDomains[0];
               }
             },
             {
-              key: CONSTANTS.TARGETING_KEYS.CRID,
+              key: TARGETING_KEYS.CRID,
               val: function (bidResponse) {
                 return bidResponse.creativeId;
               }
             },
             {
-              key: CONSTANTS.TARGETING_KEYS.DSP,
+              key: TARGETING_KEYS.DSP,
               val: function (bidResponse) {
                 return bidResponse.meta.networkId;
               }
             },
             {
-              key: CONSTANTS.TARGETING_KEYS.ACAT,
+              key: TARGETING_KEYS.ACAT,
               val: function (bidResponse) {
                 return bidResponse.meta.primaryCatId;
               }
@@ -351,7 +351,7 @@ describe('auctionmanager.js', function () {
       };
 
       var expected = getDefaultExpected(bid);
-      expected[CONSTANTS.TARGETING_KEYS.PRICE_BUCKET] = bid.pbHg;
+      expected[TARGETING_KEYS.PRICE_BUCKET] = bid.pbHg;
 
       var response = getKeyValueTargetingPairs(bid.bidderCode, bid);
       assert.deepEqual(response, expected);
@@ -373,70 +373,70 @@ describe('auctionmanager.js', function () {
         standard: {
           adserverTargeting: [
             {
-              key: CONSTANTS.TARGETING_KEYS.BIDDER,
+              key: TARGETING_KEYS.BIDDER,
               val: function (bidResponse) {
                 return bidResponse.bidderCode;
               }
             }, {
-              key: CONSTANTS.TARGETING_KEYS.AD_ID,
+              key: TARGETING_KEYS.AD_ID,
               val: function (bidResponse) {
                 return bidResponse.adId;
               }
             }, {
-              key: CONSTANTS.TARGETING_KEYS.PRICE_BUCKET,
+              key: TARGETING_KEYS.PRICE_BUCKET,
               val: function (bidResponse) {
                 return bidResponse.pbMg;
               }
             }, {
-              key: CONSTANTS.TARGETING_KEYS.SIZE,
+              key: TARGETING_KEYS.SIZE,
               val: function (bidResponse) {
                 return bidResponse.size;
               }
             },
             {
-              key: CONSTANTS.TARGETING_KEYS.SOURCE,
+              key: TARGETING_KEYS.SOURCE,
               val: function (bidResponse) {
                 return bidResponse.source;
               }
             },
             {
-              key: CONSTANTS.TARGETING_KEYS.FORMAT,
+              key: TARGETING_KEYS.FORMAT,
               val: function (bidResponse) {
                 return bidResponse.mediaType;
               }
             },
             {
-              key: CONSTANTS.TARGETING_KEYS.UUID,
+              key: TARGETING_KEYS.UUID,
               val: function (bidResponse) {
                 return bidResponse.videoCacheKey;
               }
             },
             {
-              key: CONSTANTS.TARGETING_KEYS.CACHE_ID,
+              key: TARGETING_KEYS.CACHE_ID,
               val: function (bidResponse) {
                 return bidResponse.videoCacheKey;
               }
             },
             {
-              key: CONSTANTS.TARGETING_KEYS.ADOMAIN,
+              key: TARGETING_KEYS.ADOMAIN,
               val: function (bidResponse) {
                 return bidResponse.meta.advertiserDomains[0];
               }
             },
             {
-              key: CONSTANTS.TARGETING_KEYS.CRID,
+              key: TARGETING_KEYS.CRID,
               val: function (bidResponse) {
                 return bidResponse.creativeId;
               }
             },
             {
-              key: CONSTANTS.TARGETING_KEYS.DSP,
+              key: TARGETING_KEYS.DSP,
               val: function (bidResponse) {
                 return bidResponse.meta.networkId;
               }
             },
             {
-              key: CONSTANTS.TARGETING_KEYS.ACAT,
+              key: TARGETING_KEYS.ACAT,
               val: function (bidResponse) {
                 return bidResponse.meta.primaryCatId;
               }
@@ -459,23 +459,23 @@ describe('auctionmanager.js', function () {
         appnexus: {
           adserverTargeting: [
             {
-              key: CONSTANTS.TARGETING_KEYS.BIDDER,
+              key: TARGETING_KEYS.BIDDER,
               val: function (bidResponse) {
                 return bidResponse.bidderCode;
               }
             }, {
-              key: CONSTANTS.TARGETING_KEYS.AD_ID,
+              key: TARGETING_KEYS.AD_ID,
               val: function (bidResponse) {
                 return bidResponse.adId;
               }
             }, {
-              key: CONSTANTS.TARGETING_KEYS.PRICE_BUCKET,
+              key: TARGETING_KEYS.PRICE_BUCKET,
               val: function (bidResponse) {
                 // change default here
                 return bidResponse.pbHg;
               }
             }, {
-              key: CONSTANTS.TARGETING_KEYS.SIZE,
+              key: TARGETING_KEYS.SIZE,
               val: function (bidResponse) {
                 return bidResponse.size;
               }
@@ -486,7 +486,7 @@ describe('auctionmanager.js', function () {
       };
 
       var expected = getDefaultExpected(bid);
-      expected[CONSTANTS.TARGETING_KEYS.PRICE_BUCKET] = bid.pbHg;
+      expected[TARGETING_KEYS.PRICE_BUCKET] = bid.pbHg;
 
       var response = getKeyValueTargetingPairs(bid.bidderCode, bid);
       assert.deepEqual(response, expected);
@@ -498,23 +498,23 @@ describe('auctionmanager.js', function () {
         nonExistentBidder: {
           adserverTargeting: [
             {
-              key: CONSTANTS.TARGETING_KEYS.BIDDER,
+              key: TARGETING_KEYS.BIDDER,
               val: function (bidResponse) {
                 return bidResponse.bidderCode;
               }
             }, {
-              key: CONSTANTS.TARGETING_KEYS.AD_ID,
+              key: TARGETING_KEYS.AD_ID,
               val: function (bidResponse) {
                 return bidResponse.adId;
               }
             }, {
-              key: CONSTANTS.TARGETING_KEYS.PRICE_BUCKET,
+              key: TARGETING_KEYS.PRICE_BUCKET,
               val: function (bidResponse) {
                 // change default here
                 return bidResponse.pbHg;
               }
             }, {
-              key: CONSTANTS.TARGETING_KEYS.SIZE,
+              key: TARGETING_KEYS.SIZE,
               val: function (bidResponse) {
                 return bidResponse.size;
               }
@@ -561,17 +561,17 @@ describe('auctionmanager.js', function () {
           },
           adserverTargeting: [
             {
-              key: CONSTANTS.TARGETING_KEYS.BIDDER,
+              key: TARGETING_KEYS.BIDDER,
               val: function (bidResponse) {
                 return bidResponse.bidderCode;
               }
             }, {
-              key: CONSTANTS.TARGETING_KEYS.AD_ID,
+              key: TARGETING_KEYS.AD_ID,
               val: function (bidResponse) {
                 return bidResponse.adId;
               }
             }, {
-              key: CONSTANTS.TARGETING_KEYS.PRICE_BUCKET,
+              key: TARGETING_KEYS.PRICE_BUCKET,
               val: function (bidResponse) {
                 // change default here
                 return 10.00;
@@ -581,8 +581,8 @@ describe('auctionmanager.js', function () {
 
         }
       };
-      var expected = getDefaultExpected(bid, [CONSTANTS.TARGETING_KEYS.BIDDER, CONSTANTS.TARGETING_KEYS.AD_ID]);
-      expected[CONSTANTS.TARGETING_KEYS.PRICE_BUCKET] = 10.0;
+      var expected = getDefaultExpected(bid, [TARGETING_KEYS.BIDDER, TARGETING_KEYS.AD_ID]);
+      expected[TARGETING_KEYS.PRICE_BUCKET] = 10.0;
 
       var response = getKeyValueTargetingPairs(bid.bidderCode, bid);
       assert.deepEqual(response, expected);
@@ -618,17 +618,17 @@ describe('auctionmanager.js', function () {
           },
           adserverTargeting: [
             {
-              key: CONSTANTS.TARGETING_KEYS.BIDDER,
+              key: TARGETING_KEYS.BIDDER,
               val: function (bidResponse) {
                 return bidResponse.bidderCode;
               }
             }, {
-              key: CONSTANTS.TARGETING_KEYS.AD_ID,
+              key: TARGETING_KEYS.AD_ID,
               val: function (bidResponse) {
                 return bidResponse.adId;
               }
             }, {
-              key: CONSTANTS.TARGETING_KEYS.PRICE_BUCKET,
+              key: TARGETING_KEYS.PRICE_BUCKET,
               val: function (bidResponse) {
                 // change default here
                 return 15.00;
@@ -639,24 +639,24 @@ describe('auctionmanager.js', function () {
         standard: {
           adserverTargeting: [
             {
-              key: CONSTANTS.TARGETING_KEYS.BIDDER,
+              key: TARGETING_KEYS.BIDDER,
               val: function (bidResponse) {
                 return bidResponse.bidderCode;
               }
             }, {
-              key: CONSTANTS.TARGETING_KEYS.AD_ID,
+              key: TARGETING_KEYS.AD_ID,
               val: function (bidResponse) {
                 return bidResponse.adId;
               }
             }, {
-              key: CONSTANTS.TARGETING_KEYS.PRICE_BUCKET,
+              key: TARGETING_KEYS.PRICE_BUCKET,
               val: function (bidResponse) {
                 // change default here
                 return 10.00;
               },
             },
             {
-              key: CONSTANTS.TARGETING_KEYS.SIZE,
+              key: TARGETING_KEYS.SIZE,
               val: function (bidResponse) {
                 return bidResponse.size;
               }
@@ -665,8 +665,8 @@ describe('auctionmanager.js', function () {
 
         }
       };
-      var expected = getDefaultExpected(bid, [CONSTANTS.TARGETING_KEYS.BIDDER, CONSTANTS.TARGETING_KEYS.AD_ID, CONSTANTS.TARGETING_KEYS.SIZE]);
-      expected[CONSTANTS.TARGETING_KEYS.PRICE_BUCKET] = 15.0;
+      var expected = getDefaultExpected(bid, [TARGETING_KEYS.BIDDER, TARGETING_KEYS.AD_ID, TARGETING_KEYS.SIZE]);
+      expected[TARGETING_KEYS.PRICE_BUCKET] = 15.0;
 
       var response = getKeyValueTargetingPairs(bid.bidderCode, bid);
       assert.deepEqual(response, expected);
@@ -679,17 +679,17 @@ describe('auctionmanager.js', function () {
           sendStandardTargeting: false,
           adserverTargeting: [
             {
-              key: CONSTANTS.TARGETING_KEYS.BIDDER,
+              key: TARGETING_KEYS.BIDDER,
               val: function (bidResponse) {
                 return bidResponse.bidderCode;
               }
             }, {
-              key: CONSTANTS.TARGETING_KEYS.AD_ID,
+              key: TARGETING_KEYS.AD_ID,
               val: function (bidResponse) {
                 return bidResponse.adId;
               }
             }, {
-              key: CONSTANTS.TARGETING_KEYS.PRICE_BUCKET,
+              key: TARGETING_KEYS.PRICE_BUCKET,
               val: function (bidResponse) {
                 return bidResponse.pbHg;
               }
@@ -698,7 +698,7 @@ describe('auctionmanager.js', function () {
         }
       };
       var expected = getDefaultExpected(bid);
-      expected[CONSTANTS.TARGETING_KEYS.PRICE_BUCKET] = 5.57;
+      expected[TARGETING_KEYS.PRICE_BUCKET] = 5.57;
 
       var response = getKeyValueTargetingPairs(bid.bidderCode, bid);
       assert.deepEqual(response, expected);
@@ -830,7 +830,7 @@ describe('auctionmanager.js', function () {
       }
       const auction = auctionManager.createAuction({adUnits, ortb2Fragments});
       expect(auction.getNonBids()[0]).to.equal(undefined);
-      events.emit(CONSTANTS.EVENTS.SEAT_NON_BID, {
+      events.emit(EVENTS.SEAT_NON_BID, {
         auctionId: auction.getAuctionId(),
         seatnonbid: ['test']
       });
@@ -990,7 +990,7 @@ describe('auctionmanager.js', function () {
         auction.callBids();
 
         let registeredBid = auction.getBidsReceived().pop();
-        assert.equal(registeredBid.adserverTargeting[CONSTANTS.TARGETING_KEYS.DEAL], 'test deal', 'dealId placed in adserverTargeting');
+        assert.equal(registeredBid.adserverTargeting[TARGETING_KEYS.DEAL], 'test deal', 'dealId placed in adserverTargeting');
       });
 
       it('should pass through default adserverTargeting sent from adapter', function () {
@@ -999,7 +999,7 @@ describe('auctionmanager.js', function () {
         auction.callBids();
 
         let registeredBid = auction.getBidsReceived().pop();
-        assert.equal(registeredBid.adserverTargeting[CONSTANTS.TARGETING_KEYS.BIDDER], BIDDER_CODE);
+        assert.equal(registeredBid.adserverTargeting[TARGETING_KEYS.BIDDER], BIDDER_CODE);
         assert.equal(registeredBid.adserverTargeting.extra, 'stuff');
       });
       it('should add the bidResponse to the collection before calling BID_RESPONSE', function () {
@@ -1008,9 +1008,9 @@ describe('auctionmanager.js', function () {
           const storedBid = auction.getBidsReceived().pop();
           hasBid = storedBid === bid;
         }
-        events.on(CONSTANTS.EVENTS.BID_RESPONSE, eventHandler);
+        events.on(EVENTS.BID_RESPONSE, eventHandler);
         auction.callBids();
-        events.off(CONSTANTS.EVENTS.BID_RESPONSE, eventHandler);
+        events.off(EVENTS.BID_RESPONSE, eventHandler);
         assert.ok(hasBid, 'Bid not available');
       });
 
@@ -1231,10 +1231,10 @@ describe('auctionmanager.js', function () {
         let handler;
         beforeEach(() => {
           handler = sinon.spy();
-          events.on(CONSTANTS.EVENTS.AUCTION_TIMEOUT, handler);
+          events.on(EVENTS.AUCTION_TIMEOUT, handler);
         })
         afterEach(() => {
-          events.off(CONSTANTS.EVENTS.AUCTION_TIMEOUT, handler);
+          events.off(EVENTS.AUCTION_TIMEOUT, handler);
         });
 
         Object.entries({
@@ -1257,14 +1257,14 @@ describe('auctionmanager.js', function () {
 
       it('should emit BID_TIMEOUT and AUCTION_END for timed out bids', function () {
         const pm = runAuction().then(() => {
-          const bidTimeoutCall = eventsEmitSpy.withArgs(CONSTANTS.EVENTS.BID_TIMEOUT).getCalls()[0];
+          const bidTimeoutCall = eventsEmitSpy.withArgs(EVENTS.BID_TIMEOUT).getCalls()[0];
           const timedOutBids = bidTimeoutCall.args[1];
           assert.equal(timedOutBids.length, 1);
           assert.equal(timedOutBids[0].bidder, BIDDER_CODE1);
           // Check that additional properties are available
           assert.equal(timedOutBids[0].params[0].placementId, 'id');
 
-          const auctionEndCall = eventsEmitSpy.withArgs(CONSTANTS.EVENTS.AUCTION_END).getCalls()[0];
+          const auctionEndCall = eventsEmitSpy.withArgs(EVENTS.AUCTION_END).getCalls()[0];
           const auctionProps = auctionEndCall.args[1];
           assert.equal(auctionProps.adUnits, adUnits);
           assert.equal(auctionProps.timeout, 20);
@@ -1276,7 +1276,7 @@ describe('auctionmanager.js', function () {
 
       it('should NOT emit BID_TIMEOUT when all bidders responded in time', function () {
         const pm = runAuction().then(() => {
-          assert.ok(eventsEmitSpy.withArgs(CONSTANTS.EVENTS.BID_TIMEOUT).notCalled, 'did not emit event BID_TIMEOUT');
+          assert.ok(eventsEmitSpy.withArgs(EVENTS.BID_TIMEOUT).notCalled, 'did not emit event BID_TIMEOUT');
         });
         respondToRequest(0);
         respondToRequest(1);
@@ -1285,7 +1285,7 @@ describe('auctionmanager.js', function () {
 
       it('should NOT emit BID_TIMEOUT for bidders which responded in time but with an empty bid', function () {
         const pm = runAuction().then(() => {
-          const bidTimeoutCall = eventsEmitSpy.withArgs(CONSTANTS.EVENTS.BID_TIMEOUT).getCalls()[0];
+          const bidTimeoutCall = eventsEmitSpy.withArgs(EVENTS.BID_TIMEOUT).getCalls()[0];
           const timedOutBids = bidTimeoutCall.args[1];
           assert.equal(timedOutBids.length, 1);
           assert.equal(timedOutBids[0].bidder, BIDDER_CODE1);
@@ -1314,8 +1314,8 @@ describe('auctionmanager.js', function () {
         adUnits[0].bids.push({bidder: 'mock-s2s-1'}, {bidder: 'mock-s2s-2'})
         const s2sAdUnits = deepClone(adUnits);
         bids.unshift(
-          mockBid({bidderCode: 'mock-s2s-1', src: CONSTANTS.S2S.SRC, adUnits: s2sAdUnits, uniquePbsTid: '1'}),
-          mockBid({bidderCode: 'mock-s2s-2', src: CONSTANTS.S2S.SRC, adUnits: s2sAdUnits, uniquePbsTid: '2'})
+          mockBid({ bidderCode: 'mock-s2s-1', src: S2S.SRC, adUnits: s2sAdUnits, uniquePbsTid: '1' }),
+          mockBid({ bidderCode: 'mock-s2s-2', src: S2S.SRC, adUnits: s2sAdUnits, uniquePbsTid: '2' })
         );
         Object.assign(s2sAdUnits[0], {
           mediaTypes: {
@@ -1336,7 +1336,7 @@ describe('auctionmanager.js', function () {
         })
 
         const pm = runAuction().then(() => {
-          const toBids = eventsEmitSpy.withArgs(CONSTANTS.EVENTS.BID_TIMEOUT).getCalls()[0].args[1]
+          const toBids = eventsEmitSpy.withArgs(EVENTS.BID_TIMEOUT).getCalls()[0].args[1]
           expect(toBids.map(bid => bid.bidder)).to.eql([
             'mock-s2s-2',
             BIDDER_CODE,
@@ -1906,12 +1906,12 @@ describe('auctionmanager.js', function () {
 
       before(() => {
         addBidResponse.before(rejectHook, 999);
-        events.on(CONSTANTS.EVENTS.BID_REJECTED, onBidRejected);
+        events.on(EVENTS.BID_REJECTED, onBidRejected);
       });
 
       after(() => {
         addBidResponse.getHooks({hook: rejectHook}).remove();
-        events.off(CONSTANTS.EVENTS.BID_REJECTED, onBidRejected);
+        events.off(EVENTS.BID_REJECTED, onBidRejected);
       });
 
       beforeEach(() => {

package/test/spec/modules/33acrossAnalyticsAdapter_spec.js

@@ -4,10 +4,9 @@ import { log } from 'modules/33acrossAnalyticsAdapter.js';
 import * as mockGpt from 'test/spec/integration/faker/googletag.js';
 import * as events from 'src/events.js';
 import * as faker from 'faker';
-import CONSTANTS from 'src/constants.json';
+import { EVENTS } from 'src/constants.js';
 import { gdprDataHandler, gppDataHandler, uspDataHandler } from '../../../src/adapterManager';
 import { DEFAULT_ENDPOINT, POST_GAM_TIMEOUT, locals } from '../../../modules/33acrossAnalyticsAdapter';
-const { EVENTS, BID_STATUS } = CONSTANTS;
 
 describe('33acrossAnalyticsAdapter:', function () {
   let sandbox;

package/test/spec/modules/33acrossIdSystem_spec.js

@@ -493,7 +493,7 @@ describe('33acrossIdSystem', () => {
     });
 
     context('when a first-party ID is present in local storage', () => {
-      it('should call endpoint with the first-party ID included', () => {
+      it('should call endpoint with the encoded first-party ID included', () => {
         const completeCallback = () => {};
         const { callback } = thirthyThreeAcrossIdSubmodule.getId({
           params: {
@@ -506,13 +506,13 @@ describe('33acrossIdSystem', () => {
 
         sinon.stub(storage, 'getDataFromLocalStorage')
           .withArgs('33acrossIdFp')
-          .returns('33acrossIdFpValue');
+          .returns('33acrossIdFpValue+');
 
         callback(completeCallback);
 
         const [request] = server.requests;
 
-        expect(request.url).to.contain('fp=33acrossIdFpValue');
+        expect(request.url).to.contain('fp=33acrossIdFpValue%2B');
 
         storage.getDataFromLocalStorage.restore();
       });

package/test/spec/modules/adWMGAnalyticsAdapter_spec.js

@@ -2,9 +2,9 @@ import adWMGAnalyticsAdapter from 'modules/adWMGAnalyticsAdapter.js';
 import { expect } from 'chai';
 import { server } from 'test/mocks/xhr.js';
 import {expectEvents} from '../../helpers/analytics.js';
+import {EVENTS} from 'src/constants.js';
 let adapterManager = require('src/adapterManager').default;
 let events = require('src/events');
-let constants = require('src/constants.json');
 
 describe('adWMG Analytics', function () {
   let timestamp = new Date() - 256;
@@ -142,31 +142,31 @@ describe('adWMG Analytics', function () {
       });
 
       expectEvents([
-        [constants.EVENTS.AUCTION_INIT, {timestamp, auctionId, timeout, adUnits}],
-        [constants.EVENTS.BID_REQUESTED, {}],
-        [constants.EVENTS.BID_RESPONSE, bidResponse],
-        [constants.EVENTS.NO_BID, {}],
-        [constants.EVENTS.BID_TIMEOUT, bidTimeoutArgs],
-        [constants.EVENTS.AUCTION_END, {}],
-        [constants.EVENTS.BID_WON, wonRequest],
+        [EVENTS.AUCTION_INIT, {timestamp, auctionId, timeout, adUnits}],
+        [EVENTS.BID_REQUESTED, {}],
+        [EVENTS.BID_RESPONSE, bidResponse],
+        [EVENTS.NO_BID, {}],
+        [EVENTS.BID_TIMEOUT, bidTimeoutArgs],
+        [EVENTS.AUCTION_END, {}],
+        [EVENTS.BID_WON, wonRequest],
       ]).to.beTrackedBy(adWMGAnalyticsAdapter.track);
     });
 
     it('should be two xhr requests', function () {
-      events.emit(constants.EVENTS.AUCTION_END, {});
-      events.emit(constants.EVENTS.BID_WON, wonRequest);
+      events.emit(EVENTS.AUCTION_END, {});
+      events.emit(EVENTS.BID_WON, wonRequest);
       expect(server.requests.length).to.equal(2);
     });
 
     it('second request should be bidWon', function () {
-      events.emit(constants.EVENTS.AUCTION_END, {});
-      events.emit(constants.EVENTS.BID_WON, wonRequest);
+      events.emit(EVENTS.AUCTION_END, {});
+      events.emit(EVENTS.BID_WON, wonRequest);
       expect(JSON.parse(server.requests[1].requestBody).events[0].status).to.equal(expectedBidWonData.events[0].status);
     });
 
     it('check bidWon data', function () {
-      events.emit(constants.EVENTS.AUCTION_END, {});
-      events.emit(constants.EVENTS.BID_WON, wonRequest);
+      events.emit(EVENTS.AUCTION_END, {});
+      events.emit(EVENTS.BID_WON, wonRequest);
       let realBidWonData = JSON.parse(server.requests[1].requestBody);
       expect(realBidWonData.publisher_id).to.equal(expectedBidWonData.publisher_id);
       expect(realBidWonData.site).to.equal(expectedBidWonData.site);