prebid.js 7.44.0 → 7.45.0

package/test/spec/modules/openxOrtbBidAdapter_spec.js

@@ -300,6 +300,18 @@ describe('OpenxRtbAdapter', function () {
     });
 
     context('common requests checks', function() {
+      it('should be able to handle multiformat requests', () => {
+        const multiformat = utils.deepClone(bidRequestsWithMediaTypes[0]);
+        multiformat.mediaTypes.video = {
+          context: 'outstream',
+          playerSize: [640, 480]
+        }
+        const requests = spec.buildRequests([multiformat], mockBidderRequest);
+        const outgoingFormats = requests.flatMap(rq => rq.data.imp.flatMap(imp => ['banner', 'video'].filter(k => imp[k] != null)));
+        const expected = FEATURES.VIDEO ? ['banner', 'video'] : ['banner']
+        expect(outgoingFormats).to.have.members(expected);
+      })
+
       it('should send bid request to openx url via POST', function () {
         const request = spec.buildRequests(bidRequestsWithMediaTypes, mockBidderRequest);
         expect(request[0].url).to.equal(REQUEST_URL);
@@ -1084,45 +1096,6 @@ describe('OpenxRtbAdapter', function () {
         });
       });
     }
-
-    it.skip('should send ad unit ids when any are defined', function () {
-      const bidRequestsWithUnitIds = [{
-        bidder: 'openx',
-        params: {
-          delDomain: 'test-del-domain'
-        },
-        adUnitCode: 'adunit-code',
-        mediaTypes: {
-          banner: {
-            sizes: [[300, 250], [300, 600]]
-          }
-        },
-        bidId: 'test-bid-id-1',
-        bidderRequestId: 'test-bid-request-1',
-        auctionId: 'test-auction-1',
-        transactionId: 'test-transaction-id-1'
-      }, {
-        bidder: 'openx',
-        params: {
-          unit: '22',
-          delDomain: 'test-del-domain'
-        },
-        adUnitCode: 'adunit-code',
-        mediaTypes: {
-          banner: {
-            sizes: [[728, 90]]
-          }
-        },
-        bidId: 'test-bid-id-2',
-        bidderRequestId: 'test-bid-request-2',
-        auctionId: 'test-auction-2',
-        transactionId: 'test-transaction-id-2'
-      }];
-      mockBidderRequest.bids = bidRequestsWithUnitIds;
-      const request = spec.buildRequests(bidRequestsWithUnitIds, mockBidderRequest);
-      expect(request[0].data.imp[1].tagid).to.equal(bidRequestsWithUnitIds[1].params.unit);
-      expect(request[0].data.imp[1].ext.divid).to.equal(bidRequestsWithUnitIds[1].params.adUnitCode);
-    });
   });
 
   describe('interpretResponse()', function () {

package/test/spec/modules/pubxBidAdapter_spec.js

@@ -39,14 +39,22 @@ describe('pubxAdapter', function () {
         id: '26c1ee0038ac11',
         params: {
           sid: '12345abc'
+        },
+        ortb2: {
+          site: {
+            page: `${location.href}?test=1`
+          }
         }
       }
     ];
 
     const data = {
       banner: {
-        sid: '12345abc'
-      }
+        sid: '12345abc',
+        pu: encodeURIComponent(
+          utils.deepAccess(bidRequests[0], 'ortb2.site.page').replace(/\?.*$/, '')
+        ),
+      },
     };
 
     it('sends bid request to ENDPOINT via GET', function () {

package/test/spec/modules/sharedIdSystem_spec.js

@@ -91,50 +91,4 @@ describe('SharedId System', function () {
       expect(result).to.be.undefined;
     });
   });
-
-  describe('SharedID System domainOverride', () => {
-    let sandbox, domain, cookies, rejectCookiesFor;
-
-    beforeEach(() => {
-      sandbox = sinon.createSandbox();
-      sandbox.stub(document, 'domain').get(() => domain);
-      cookies = {};
-      sandbox.stub(storage, 'getCookie').callsFake((key) => cookies[key]);
-      rejectCookiesFor = null;
-      sandbox.stub(storage, 'setCookie').callsFake((key, value, expires, sameSite, domain) => {
-        if (domain !== rejectCookiesFor) {
-          if (expires != null) {
-            expires = new Date(expires);
-          }
-          if (expires == null || expires > Date.now()) {
-            cookies[key] = value;
-          } else {
-            delete cookies[key];
-          }
-        }
-      });
-    });
-
-    afterEach(() => {
-      sandbox.restore();
-    });
-
-    it('should return TLD if cookies can be set there', () => {
-      domain = 'sub.domain.com';
-      rejectCookiesFor = 'com';
-      expect(sharedIdSystemSubmodule.domainOverride()).to.equal('domain.com');
-    });
-
-    it('should return undefined when cookies cannot be set', () => {
-      domain = 'sub.domain.com';
-      rejectCookiesFor = 'sub.domain.com';
-      expect(sharedIdSystemSubmodule.domainOverride()).to.be.undefined;
-    });
-
-    it('should return half-way domain if parent domain rejects cookies', () => {
-      domain = 'inner.outer.domain.com';
-      rejectCookiesFor = 'domain.com';
-      expect(sharedIdSystemSubmodule.domainOverride()).to.equal('outer.domain.com');
-    });
-  });
 });

package/test/spec/modules/sharethroughBidAdapter_spec.js

@@ -248,7 +248,8 @@ describe('sharethrough adapter spec', function () {
         refererInfo: {
           ref: 'https://referer.com',
         },
-        auctionId: 'auction-id'
+        auctionId: 'auction-id',
+        timeout: 242
       };
     });
 

package/test/spec/modules/smarthubBidAdapter_spec.js

@@ -91,7 +91,8 @@ describe('SmartHubBidAdapter', function () {
     gdprConsent: 'COvFyGBOvFyGBAbAAAENAPCAAOAAAAAAAAAAAEEUACCKAAA.IFoEUQQgAIQwgIwQABAEAAAAOIAACAIAAAAQAIAgEAACEAAAAAgAQBAAAAAAAGBAAgAAAAAAAFAAECAAAgAAQARAEQAAAAAJAAIAAgAAAYQEAAAQmAgBC3ZAYzUw',
     refererInfo: {
       page: 'https://test.com'
-    }
+    },
+    timeout: 500
   };
 
   describe('isBidRequestValid', function () {

package/test/spec/modules/synacormediaBidAdapter_spec.js

@@ -313,32 +313,6 @@ describe('synacormediaBidAdapter ', function () {
       expect(req.data.tmax).to.eql(bidderRequestWithTimeout.timeout);
     });
 
-    it('should return tmax equal to smaller global timeout', function () {
-      let sandbox = sinon.sandbox.create();
-      sandbox.stub(config, 'getConfig').callsFake(key => {
-        const config = {
-          'bidderTimeout': bidderRequestWithTimeout.timeout - 100
-        };
-        return config[key];
-      });
-      let req = spec.buildRequests([validBidRequest], bidderRequestWithTimeout);
-      sandbox.restore();
-      expect(req.data.tmax).to.eql(bidderRequestWithTimeout.timeout - 100);
-    });
-
-    it('should return tmax equal to smaller callback timeout', function () {
-      let sandbox = sinon.sandbox.create();
-      sandbox.stub(config, 'getConfig').callsFake(key => {
-        const config = {
-          'bidderTimeout': bidderRequestWithTimeout.timeout + 100
-        };
-        return config[key];
-      });
-      let req = spec.buildRequests([validBidRequest], bidderRequestWithTimeout);
-      sandbox.restore();
-      expect(req.data.tmax).to.eql(bidderRequestWithTimeout.timeout);
-    });
-
     it('should return multiple bids when multiple valid requests with the same seatId are used', function () {
       let secondBidRequest = {
         bidId: 'foobar',

package/test/spec/modules/videoModule/submodules/jwplayerVideoProvider_spec.js

@@ -19,7 +19,7 @@ import { PLAYBACK_MODE } from 'libraries/video/constants/constants.js';
 function getPlayerMock() {
   return makePlayerFactoryMock({
     getState: function () {},
-    setup: function () {},
+    setup: function () { return this; },
     getViewable: function () {},
     getPercentViewable: function () {},
     getMute: function () {},
@@ -30,8 +30,8 @@ function getPlayerMock() {
     getFullscreen: function () {},
     getPlaylistItem: function () {},
     playAd: function () {},
-    on: function () {},
-    off: function () {},
+    on: function () { return this; },
+    off: function () { return this; },
     remove: function () {},
     getAudioTracks: function () {},
     getCurrentAudioTrack: function () {},
@@ -142,7 +142,7 @@ describe('JWPlayerProvider', function () {
     it('should instantiate the player when uninstantiated', function () {
       const player = getPlayerMock();
       config.playerConfig = {};
-      const setupSpy = player.setup = sinon.spy();
+      const setupSpy = player.setup = sinon.spy(player.setup);
       const provider = JWPlayerProvider(config, makePlayerFactoryMock(player), adState, timeState, callbackStorage, utilsMock, sharedUtils);
       provider.init();
       expect(setupSpy.calledOnce).to.be.true;
@@ -158,6 +158,19 @@ describe('JWPlayerProvider', function () {
       expect(setupComplete.calledOnce).to.be.true;
     });
 
+    it('should support multiple setup complete event handlers', function () {
+      const player = getPlayerMock();
+      player.getState = () => 'idle';
+      const provider = JWPlayerProvider(config, makePlayerFactoryMock(player), adState, timeState, callbackStorage, utilsMock, sharedUtils);
+      const setupComplete = sinon.spy();
+      const setupComplete2 = sinon.spy();
+      provider.onEvent(SETUP_COMPLETE, setupComplete, {});
+      provider.onEvent(SETUP_COMPLETE, setupComplete2, {});
+      provider.init();
+      expect(setupComplete.calledOnce).to.be.true;
+      expect(setupComplete2.calledOnce).to.be.true;
+    });
+
     it('should not reinstantiate player', function () {
       const player = getPlayerMock();
       player.getState = () => 'idle';

package/test/spec/modules/vidoomyBidAdapter_spec.js

@@ -161,6 +161,41 @@ describe('vidoomyBidAdapter', function() {
       expect(request[0].data).to.include.any.keys('schain');
       expect(request[0].data.schain).to.eq(serializedForm);
     });
+
+    it('should set the bidfloor if getFloor module is undefined but static bidfloor is present', function () {
+      const request = { ...bidRequests[0], params: { bidfloor: 2.5 } }
+      const req = spec.buildRequests([request], bidderRequest)[0];
+      expect(req.data).to.include.any.keys('bidfloor');
+      expect(req.data.bidfloor).to.equal(2.5);
+    });
+
+    describe('floorModule', function () {
+      const getFloordata = {
+        'currency': 'USD',
+        'floor': 1.60
+      };
+      bidRequests[0].getFloor = _ => {
+        return getFloordata;
+      };
+      it('should return getFloor.floor if present', function () {
+        const request = spec.buildRequests(bidRequests, bidderRequest)[0];
+        expect(request.data.bidfloor).to.equal(getFloordata.floor);
+      });
+      it('should return the getFloor.floor if it is greater than static bidfloor', function () {
+        const bidfloor = 1.40;
+        const request = { ...bidRequests[0] };
+        request.params.bidfloor = bidfloor;
+        const bidRequest = spec.buildRequests([request], bidderRequest)[0];
+        expect(bidRequest.data.bidfloor).to.equal(getFloordata.floor);
+      });
+      it('should return the static bidfloor if it is greater than getFloor.floor', function () {
+        const bidfloor = 1.90;
+        const request = { ...bidRequests[0] };
+        request.params.bidfloor = bidfloor;
+        const bidRequest = spec.buildRequests([request], bidderRequest)[0];
+        expect(bidRequest.data.bidfloor).to.equal(bidfloor);
+      });
+    });
   });
 
   describe('interpretResponse', function () {

package/test/spec/modules/visiblemeasuresBidAdapter_spec.js

@@ -78,7 +78,8 @@ describe('VisibleMeasuresBidAdapter', function () {
     gdprConsent: 'COvFyGBOvFyGBAbAAAENAPCAAOAAAAAAAAAAAEEUACCKAAA.IFoEUQQgAIQwgIwQABAEAAAAOIAACAIAAAAQAIAgEAACEAAAAAgAQBAAAAAAAGBAAgAAAAAAAFAAECAAAgAAQARAEQAAAAAJAAIAAgAAAYQEAAAQmAgBC3ZAYzUw',
     refererInfo: {
       referer: 'https://test.com'
-    }
+    },
+    timeout: 500
   };
 
   describe('isBidRequestValid', function () {

package/test/spec/modules/vrtcalBidAdapter_spec.js

@@ -28,7 +28,8 @@ describe('vrtcalBidAdapter', function () {
         'bidId': 'bidID0001',
         'bidderRequestId': 'br0001',
         'auctionId': 'auction0001',
-        'userIdAsEids': {}
+        'userIdAsEids': {},
+        timeout: 435
       }
     ];
 
@@ -95,7 +96,7 @@ describe('vrtcalBidAdapter', function () {
               w: 300,
               h: 250,
               crid: 'v2_1064_vrt_vrtcaltestdisplay2_300_250',
-              adomain: ['vrtcal.com']
+              adomain: ['vrtcal.com'],
             }],
             seat: '16'
           }],

package/test/spec/renderer_spec.js

@@ -52,7 +52,7 @@ describe('Renderer', function () {
       expect(testRenderer2.getConfig()).to.deep.equal({ test: 'config2' });
     });
 
-    it('sets a render function with setRender method', function () {
+    it('sets a render function with the setRender method', function () {
       testRenderer1.setRender(spyRenderFn);
       expect(typeof testRenderer1.render).to.equal('function');
       testRenderer1.render();
@@ -110,7 +110,6 @@ describe('Renderer', function () {
 
     it('renders immediately when requested', function () {
       const testRenderer3 = Renderer.install({
-        url: 'https://httpbin.org/post',
         config: { test: 'config2' },
         id: 2,
         renderNow: true