prebid.js 7.44.0 → 7.45.0

package/modules/openxBidAdapter.md

@@ -9,30 +9,31 @@ Maintainer: team-openx@openx.com
 # Description
 
 Module that connects to OpenX's demand sources.
-Note there is an updated version of the OpenX bid adapter called openxOrtbBidAdapter.
-Publishers are welcome to test the other adapter and give feedback. Please note you should only include either openxBidAdapter or openxOrtbBidAdapter in your build.
+Note that this adapter mirrors openxOrtbBidAdapter and any updates must be
+completed in both adapters.
+openxOrtbBidAdapter will be removed in a future release and should not be used.
+Please note you should only include either openxBidAdapter or openxOrtbBidAdapter in your build.
 
 # Bid Parameters
 ## Banner
 
-| Name                            | Scope    | Type    | Description                                                                                                                                                                                                                                                                                                                                                                                                                   | Example                           |
-|---------------------------------|----------|---------|-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|-----------------------------------|
-| `delDomain` ~~or `platform`~~** | required | String  | OpenX delivery domain provided by your OpenX representative.                                                                                                                                                                                                                                                                                                                                                                  | "PUBLISHER-d.openx.net"           |
-| `unit`                          | required | String  | OpenX ad unit ID provided by your OpenX representative.                                                                                                                                                                                                                                                                                                                                                                       | "1611023122"                      |
-| `customParams`                  | optional | Object  | User-defined targeting key-value pairs. customParams applies to a specific unit.                                                                                                                                                                                                                                                                                                                                              | `{key1: "v1", key2: ["v2","v3"]}` |
-| `customFloor`                   | optional | Number  | Minimum price in USD. customFloor applies to a specific unit. For example, use the following value to set a $1.50 floor: 1.50 <br/><br/> **WARNING:**<br/> Misuse of this parameter can impact revenue<br/><br/>Note: OpenX suggests using the [Price Floor Module](https://docs.prebid.org/dev-docs/modules/floors.html) instead of customFloor. The Price Floor Module is prioritized over customFloor if both are present. | 1.50                              |
-| `doNotTrack`                    | optional | Boolean | Prevents advertiser from using data for this user. <br/><br/> **WARNING:**<br/> Request-level setting.  May impact revenue.                                                                                                                                                                                                                                                                                                   | true                              |
-| `coppa`                         | optional | Boolean | Enables Child's Online Privacy Protection Act (COPPA) regulations.                                                                                                                                                                                                                                                                                                                                                            | true                              |
-
-** platform is deprecated. Please use delDomain instead. If you have any questions please contact your representative. 
+| Name | Scope | Type | Description | Example
+| ---- | ----- | ---- | ----------- | -------
+| `delDomain` or `platform` | required | String | OpenX delivery domain or platform id provided by your OpenX representative.  | "PUBLISHER-d.openx.net" or "555not5a-real-plat-form-id0123456789"
+| `unit` | required | String | OpenX ad unit ID provided by your OpenX representative. | "1611023122"
+| `customParams` | optional | Object | User-defined targeting key-value pairs. customParams applies to a specific unit. | `{key1: "v1", key2: ["v2","v3"]}`
+| `customFloor` | optional | Number | Minimum price in USD. customFloor applies to a specific unit. For example, use the following value to set a $1.50 floor: 1.50 <br/><br/> **WARNING:**<br/> Misuse of this parameter can impact revenue | 1.50
+| `doNotTrack` | optional | Boolean | Prevents advertiser from using data for this user. <br/><br/> **WARNING:**<br/> Request-level setting.  May impact revenue. | true
+| `coppa` | optional | Boolean | Enables Child's Online Privacy Protection Act (COPPA) regulations. Use of `pbjs.setConfig({coppa: true});` is now preferred. | true
 
 ## Video
 
-| Name        | Scope    | Type               | Description                                                  | Example                                                        |
-|-------------|----------|--------------------|--------------------------------------------------------------|----------------------------------------------------------------|
-| `unit`      | required | String             | OpenX ad unit ID provided by your OpenX representative.      | "1611023122"                                                   |
-| `delDomain` | required | String             | OpenX delivery domain provided by your OpenX representative. | "PUBLISHER-d.openx.net"                                        |
-| `openrtb`   | optional | OpenRTB Impression | An OpenRtb Impression with Video subtype properties          | `{ imp: [{ video: {mimes: ['video/x-ms-wmv, video/mp4']} }] }` |
+| Name | Scope | Type | Description | Example
+| ---- | ----- | ---- | ----------- | -------
+| `unit` | required | String | OpenX ad unit ID provided by your OpenX representative. | "1611023122"
+| `delDomain` | required | String |  OpenX delivery domain provided by your OpenX representative.  | "PUBLISHER-d.openx.net"
+| `video` | optional | OpenRTB video subtypes | Use of adUnit.mediaTypes.video is now preferred. | `{ video: {mimes: ['video/mp4']}`
+
 
 # Example
 ```javascript
@@ -70,7 +71,8 @@ var adUnits = [
     mediaTypes: {
       video: {
         playerSize: [640, 480],
-        context: 'instream'
+        context: 'instream',
+        mimes: ['video/x-ms-wmv, video/mp4']
       }
     },
     bids: [{
@@ -79,10 +81,10 @@ var adUnits = [
         unit: '1611023124',
         delDomain: 'PUBLISHER-d.openx.net',
         video: {
-          mimes: ['video/x-ms-wmv, video/mp4']
+          mimes: ['video/x-ms-wmv, video/mp4'] // mediaTypes.video preferred
         }
       }
-    }]
+    }]p
   }
 ];
 ```

package/modules/openxOrtbBidAdapter.js

@@ -29,9 +29,6 @@ const converter = ortbConverter({
   },
   imp(buildImp, bidRequest, context) {
     const imp = buildImp(bidRequest, context);
-    if (bidRequest.mediaTypes[VIDEO]?.context === 'outstream') {
-      imp.video.placement = imp.video.placement || 4;
-    }
     mergeDeep(imp, {
       tagid: bidRequest.params.unit,
       ext: {
@@ -132,15 +129,20 @@ const converter = ortbConverter({
         }
       },
       video(orig, imp, bidRequest, context) {
-        // `orig` is the video imp processor, which looks at bidRequest.mediaTypes[VIDEO]
-        // to populate imp.video
-        // alter its input `bidRequest` to also pick up parameters from `bidRequest.params`
-        let videoParams = bidRequest.mediaTypes[VIDEO];
-        if (videoParams) {
-          videoParams = Object.assign({}, videoParams, bidRequest.params.video);
-          bidRequest = {...bidRequest, mediaTypes: {[VIDEO]: videoParams}}
+        if (FEATURES.VIDEO) {
+          // `orig` is the video imp processor, which looks at bidRequest.mediaTypes[VIDEO]
+          // to populate imp.video
+          // alter its input `bidRequest` to also pick up parameters from `bidRequest.params`
+          let videoParams = bidRequest.mediaTypes[VIDEO];
+          if (videoParams) {
+            videoParams = Object.assign({}, videoParams, bidRequest.params.video);
+            bidRequest = {...bidRequest, mediaTypes: {[VIDEO]: videoParams}}
+          }
+          orig(imp, bidRequest, context);
+          if (imp.video && videoParams?.context === 'outstream') {
+            imp.video.placement = imp.video.placement || 4;
+          }
         }
-        orig(imp, bidRequest, context);
       }
     }
   }

package/modules/openxOrtbBidAdapter.md

@@ -1,15 +1,17 @@
 # Overview
 
 ```
-Module Name: OpenX OpenRTB Bidder Adapter
+Module Name: OpenX Bidder Adapter
 Module Type: Bidder Adapter
 Maintainer: team-openx@openx.com
 ```
 
 # Description
+DEPRECATED. Use openxBidAdapter.
 
-This is an updated version of the OpenX bid adapter which calls our new serving architecture.
-Publishers are welcome to test this adapter and give feedback. Please note you should only include either openxBidAdapter or openxOrtbBidAdapter in your build.
+This adapter was originally an adapter used to test OpenX serving architecture changes.
+This adapter now mirrors openxBidAdapter and this adapter will be removed in a future release. Please use openxBidAdapter.
+Please note you should only include either openxBidAdapter or openxOrtbBidAdapter in your build.
 
 # Bid Parameters
 ## Banner

package/modules/operaadsBidAdapter.js

@@ -228,7 +228,7 @@ function buildOpenRtbBidRequest(bidRequest, bidderRequest) {
   // build OpenRTB request body
   const payload = {
     id: bidderRequest.auctionId,
-    tmax: bidderRequest.timeout || config.getConfig('bidderTimeout'),
+    tmax: bidderRequest.timeout,
     test: config.getConfig('debug') ? 1 : 0,
     imp: createImp(bidRequest),
     device: getDevice(),

package/modules/pubmaticBidAdapter.js

@@ -1211,7 +1211,7 @@ export const spec = {
     // bidderRequest has timeout property if publisher sets during calling requestBids function from page
     // if not bidderRequest contains global value set by Prebid
     if (bidderRequest?.timeout) {
-      payload.tmax = bidderRequest.timeout || config.getConfig('bidderTimeout');
+      payload.tmax = bidderRequest.timeout;
     } else {
       payload.tmax = window?.PWT?.versionDetails?.timeout;
     }

package/modules/pubxBidAdapter.js

@@ -1,4 +1,4 @@
-import { deepSetValue } from '../src/utils.js';
+import { deepSetValue, deepAccess } from '../src/utils.js';
 import { registerBidder } from '../src/adapters/bidderFactory.js';
 
 const BIDDER_CODE = 'pubx';
@@ -16,8 +16,11 @@ export const spec = {
       const bidId = bidRequest.bidId;
       const params = bidRequest.params;
       const sid = params.sid;
+      const pageUrl = deepAccess(bidRequest, 'ortb2.site.page').replace(/\?.*$/, '');
+      const pageEnc = encodeURIComponent(pageUrl);
       const payload = {
-        sid: sid
+        sid: sid,
+        pu: pageEnc,
       };
       return {
         id: bidId,

package/modules/riseBidAdapter.js

@@ -384,7 +384,7 @@ function generateGeneralParams(generalObject, bidderRequest) {
   const {syncEnabled, filterSettings} = config.getConfig('userSync') || {};
   const {bidderCode} = bidderRequest;
   const generalBidParams = generalObject.params;
-  const timeout = config.getConfig('bidderTimeout');
+  const timeout = bidderRequest.timeout;
 
   // these params are snake_case instead of camelCase to allow backwards compatability on the server.
   // in the future, these will be converted to camelCase to match our convention.

package/modules/sharedIdSystem.js

@@ -5,12 +5,13 @@
  * @requires module:modules/userId
  */
 
-import { parseUrl, buildUrl, triggerPixel, logInfo, hasDeviceAccess, generateUUID } from '../src/utils.js';
+import {parseUrl, buildUrl, triggerPixel, logInfo, hasDeviceAccess, generateUUID} from '../src/utils.js';
 import {submodule} from '../src/hook.js';
-import { coppaDataHandler } from '../src/adapterManager.js';
+import {coppaDataHandler} from '../src/adapterManager.js';
 import {getStorageManager} from '../src/storageManager.js';
 import {VENDORLESS_GVLID} from '../src/consentHandler.js';
 import {MODULE_TYPE_UID} from '../src/activities/modules.js';
+import {domainOverrideToRootDomain} from '../libraries/domainOverrideToRootDomain/index.js';
 
 export const storage = getStorageManager({moduleType: MODULE_TYPE_UID, moduleName: 'pubCommonId'});
 const COOKIE = 'cookie';
@@ -172,31 +173,7 @@ export const sharedIdSystemSubmodule = {
     }
   },
 
-  domainOverride: function () {
-    const domainElements = document.domain.split('.');
-    const cookieName = `_gd${Date.now()}`;
-    for (let i = 0, topDomain, testCookie; i < domainElements.length; i++) {
-      const nextDomain = domainElements.slice(i).join('.');
-
-      // write test cookie
-      storage.setCookie(cookieName, '1', undefined, undefined, nextDomain);
-
-      // read test cookie to verify domain was valid
-      testCookie = storage.getCookie(cookieName);
-
-      // delete test cookie
-      storage.setCookie(cookieName, '', 'Thu, 01 Jan 1970 00:00:01 GMT', undefined, nextDomain);
-
-      if (testCookie === '1') {
-        // cookie was written successfully using test domain so the topDomain is updated
-        topDomain = nextDomain;
-      } else {
-        // cookie failed to write using test domain so exit by returning the topDomain
-        return topDomain;
-      }
-    }
-  }
-
+  domainOverride: domainOverrideToRootDomain(storage, 'sharedId'),
 };
 
 submodule('userId', sharedIdSystemSubmodule);

package/modules/sharethroughBidAdapter.js

@@ -21,7 +21,7 @@ export const sharethroughAdapterSpec = {
   isBidRequestValid: bid => !!bid.params.pkey && bid.bidder === BIDDER_CODE,
 
   buildRequests: (bidRequests, bidderRequest) => {
-    const timeout = config.getConfig('bidderTimeout');
+    const timeout = bidderRequest.timeout;
     const firstPartyData = bidderRequest.ortb2 || {};
 
     const nonHttp = sharethroughInternal.getProtocol().indexOf('http') < 0;

package/modules/shinezBidAdapter.js

@@ -364,7 +364,7 @@ function generateGeneralParams(generalObject, bidderRequest) {
   const {syncEnabled, filterSettings} = config.getConfig('userSync') || {};
   const {bidderCode} = bidderRequest;
   const generalBidParams = generalObject.params;
-  const timeout = config.getConfig('bidderTimeout');
+  const timeout = bidderRequest.timeout;
 
   // these params are snake_case instead of camelCase to allow backwards compatability on the server.
   // in the future, these will be converted to camelCase to match our convention.

package/modules/smarthubBidAdapter.js

@@ -125,7 +125,7 @@ function buildRequestParams(bidderRequest = {}, placements = []) {
     coppa: config.getConfig('coppa') === true ? 1 : 0,
     ccpa: bidderRequest.uspConsent || undefined,
     gdpr: bidderRequest.gdprConsent || undefined,
-    tmax: config.getConfig('bidderTimeout')
+    tmax: bidderRequest.timeout
   };
 }
 

package/modules/synacormediaBidAdapter.js

@@ -49,9 +49,7 @@ export const spec = {
       imp: []
     };
 
-    const callbackTimeout = bidderRequest.timeout;
-    const globalTimeout = config.getConfig('bidderTimeout');
-    const tmax = globalTimeout ? Math.min(globalTimeout, callbackTimeout) : callbackTimeout;
+    const tmax = bidderRequest.timeout;
     if (tmax) {
       openRtbBidRequest.tmax = tmax;
     }

package/modules/truereachBidAdapter.js

@@ -1,6 +1,5 @@
 import { deepAccess, getUniqueIdentifierStr } from '../src/utils.js';
 import { registerBidder } from '../src/adapters/bidderFactory.js';
-import { config } from '../src/config.js';
 import { BANNER } from '../src/mediaTypes.js';
 
 const SUPPORTED_AD_TYPES = [BANNER];
@@ -140,7 +139,7 @@ function buildCommonQueryParamsFromBids(validBidRequests, bidderRequest) {
     device: {
       ua: window.navigator.userAgent
     },
-    tmax: config.getConfig('bidderTimeout')
+    tmax: bidderRequest.timeout
   };
 
   return defaultParams;

package/modules/userId/eids.js

@@ -146,6 +146,24 @@ export const USER_IDS_CONFIG = {
     }
   },
 
+  // bidswitchId
+  'bidswitch': {
+    source: 'bidswitch.net',
+    atype: 3,
+    getValue: function(data) {
+      return data.id;
+    }
+  },
+
+  // medianetId
+  'medianet': {
+    source: 'media.net',
+    atype: 3,
+    getValue: function(data) {
+      return data.id;
+    }
+  },
+
   // britepoolId
   'britepoolid': {
     source: 'britepool.com',

package/modules/userId/eids.md

@@ -105,6 +105,22 @@ userIdAsEids = [
             segments: ['s1', 's2']
         }
     },
+    
+    {
+        source: 'bidswitch.net',
+        uids: [{
+            id: 'some-random-id-value',
+            atype: 3
+        }]
+    },
+    
+    {
+        source: 'media.net',
+        uids: [{
+            id: 'some-random-id-value',
+            atype: 3
+        }]
+    },
 
     {
         source: 'merkleinc.com',

package/modules/videoheroesBidAdapter.js

@@ -80,7 +80,7 @@ export const spec = {
         domain: parseUrl(page).hostname,
         page: page,
       },
-      tmax: bidderRequest.timeout || config.getConfig('bidderTimeout') || 500,
+      tmax: bidderRequest.timeout,
       imp
     };
 

package/modules/vidoomyBidAdapter.js

@@ -74,6 +74,26 @@ function serializeSupplyChainObj(schainObj) {
   return serializedSchain;
 }
 
+/**
+ * Gets highest floor between getFloor.floor and params.bidfloor
+ * @param {Object} bid
+ * @param {Object} mediaType
+ * @param {Array} sizes
+ * @param {Number} bidfloor
+ * @returns {Number} floor
+ */
+function getBidFloor(bid, mediaType, sizes, bidfloor) {
+  let floor = bidfloor;
+  var size = sizes && sizes.length > 0 ? sizes[0] : '*';
+  if (typeof bid.getFloor === 'function') {
+    const floorInfo = bid.getFloor({currency: 'USD', mediaType, size});
+    if (typeof floorInfo === 'object' && floorInfo.currency === 'USD' && !isNaN(parseFloat(floorInfo.floor))) {
+      floor = Math.max(bidfloor, parseFloat(floorInfo.floor));
+    }
+  }
+  return floor;
+}
+
 const isBidResponseValid = bid => {
   if (!bid || !bid.requestId || !bid.cpm || !bid.ttl || !bid.currency) {
     return false;
@@ -106,6 +126,7 @@ const buildRequests = (validBidRequests, bidderRequest) => {
 
     const videoContext = deepAccess(bid, 'mediaTypes.video.context');
     const bidfloor = deepAccess(bid, `params.bidfloor`, 0);
+    const floor = getBidFloor(bid, adType, sizes, bidfloor);
 
     const queryParams = {
       id: bid.params.id,
@@ -120,7 +141,7 @@ const buildRequests = (validBidRequests, bidderRequest) => {
       pid: bid.params.pid,
       requestId: bid.bidId,
       schain: serializeSupplyChainObj(bid.schain) || '',
-      bidfloor,
+      bidfloor: floor,
       d: getDomainWithoutSubdomain(hostname), // 'vidoomy.com',
       // TODO: does the fallback make sense here?
       sp: encodeURIComponent(bidderRequest.refererInfo.page || bidderRequest.refererInfo.topmostLocation),

package/modules/visiblemeasuresBidAdapter.js

@@ -155,7 +155,7 @@ export const spec = {
       coppa: config.getConfig('coppa') === true ? 1 : 0,
       ccpa: bidderRequest.uspConsent || undefined,
       gdpr: bidderRequest.gdprConsent || undefined,
-      tmax: config.getConfig('bidderTimeout')
+      tmax: bidderRequest.timeout
     };
 
     const len = validBidRequests.length;

package/modules/vrtcalBidAdapter.js

@@ -46,7 +46,7 @@ export const spec = {
         coppa = 1;
       }
 
-      tmax = config.getConfig('bidderTimeout');
+      tmax = bid.timeout;
 
       const params = {
         prebidJS: 1,

package/modules/yieldoneBidAdapter.js

@@ -53,7 +53,7 @@ export const spec = {
       const bidId = bidRequest.bidId;
       const transactionId = bidRequest.transactionId;
       const unitCode = bidRequest.adUnitCode;
-      const timeout = config.getConfig('bidderTimeout');
+      const timeout = bidderRequest.timeout;
       const language = window.navigator.language;
       const screenSize = window.screen.width + 'x' + window.screen.height;
       const payload = {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "prebid.js",
-  "version": "7.44.0",
+  "version": "7.45.0",
   "description": "Header Bidding Management Library",
   "main": "src/prebid.js",
   "scripts": {

package/src/Renderer.js

@@ -22,6 +22,7 @@ export function Renderer(options) {
   this.config = config;
   this.handlers = {};
   this.id = id;
+  this.renderNow = renderNow;
 
   // a renderer may push to the command queue to delay rendering until the
   // render function is loaded by loadExternalScript, at which point the the command
@@ -110,7 +111,7 @@ Renderer.prototype.process = function() {
  * @returns {Boolean}
  */
 export function isRendererRequired(renderer) {
-  return !!(renderer && renderer.url);
+  return !!(renderer && (renderer.url || renderer.renderNow));
 }
 
 /**

package/src/native.js

@@ -750,7 +750,11 @@ export function toLegacyResponse(ortbResponse, ortbRequest) {
     if (asset.title) {
       legacyResponse.title = asset.title.text;
     } else if (asset.img) {
-      legacyResponse[requestAsset.img.type === NATIVE_IMAGE_TYPES.MAIN ? 'image' : 'icon'] = asset.img.url;
+      legacyResponse[requestAsset.img.type === NATIVE_IMAGE_TYPES.MAIN ? 'image' : 'icon'] = {
+        url: asset.img.url,
+        width: asset.img.w,
+        height: asset.img.h
+      };
     } else if (asset.data) {
       legacyResponse[PREBID_NATIVE_DATA_KEYS_TO_ORTB_INVERSE[NATIVE_ASSET_TYPES_INVERSE[requestAsset.data.type]]] = asset.data.value;
     }

package/test/spec/auctionmanager_spec.js

@@ -1403,8 +1403,8 @@ describe('auctionmanager.js', function () {
         assert.equal(addedBid.native.title, 'Sample title')
         assert.equal(addedBid.native.sponsoredBy, 'Sample sponsoredBy')
         assert.equal(addedBid.native.clickUrl, 'http://www.click.com')
-        assert.equal(addedBid.native.image, 'https://www.example.com/image.png')
-        assert.equal(addedBid.native.icon, 'https://www.example.com/icon.png')
+        assert.equal(addedBid.native.image.url, 'https://www.example.com/image.png')
+        assert.equal(addedBid.native.icon.url, 'https://www.example.com/icon.png')
         assert.equal(addedBid.native.impressionTrackers[0], 'http://www.imptracker.com')
         assert.equal(addedBid.native.javascriptTrackers, '<script async src="http://www.jstracker.com/file.js"></script>')
       });

package/test/spec/libraries/domainOverrideToRootDomain/index_spec.js

@@ -0,0 +1,77 @@
+import {domainOverrideToRootDomain} from 'libraries/domainOverrideToRootDomain/index.js';
+import {getStorageManager} from 'src/storageManager.js';
+import {MODULE_TYPE_UID} from '../../../../src/activities/modules';
+
+const storage = getStorageManager({ moduleName: 'test', moduleType: MODULE_TYPE_UID });
+const domainOverride = domainOverrideToRootDomain(storage, 'test');
+
+describe('domainOverride', () => {
+  let sandbox, domain, cookies, rejectCookiesFor;
+  let setCookieStub;
+
+  beforeEach(() => {
+    sandbox = sinon.createSandbox();
+    sandbox.stub(document, 'domain').get(() => domain);
+    cookies = {};
+    sandbox.stub(storage, 'getCookie').callsFake((key) => cookies[key]);
+    rejectCookiesFor = null;
+    setCookieStub = sandbox.stub(storage, 'setCookie').callsFake((key, value, expires, sameSite, domain) => {
+      if (domain !== rejectCookiesFor) {
+        if (expires != null) {
+          expires = new Date(expires);
+        }
+        if (expires == null || expires > Date.now()) {
+          cookies[key] = value;
+        } else {
+          delete cookies[key];
+        }
+      }
+    });
+  });
+
+  afterEach(() => sandbox.restore())
+
+  it('test cookies include the module name', () => {
+    domain = 'greatpublisher.com'
+    rejectCookiesFor = 'greatpublisher.com'
+
+    // stub Date.now() to return a constant value
+    sandbox.stub(Date, 'now').returns(1234567890)
+
+    const randomName = `adapterV${(Math.random() * 1e8).toString(16)}`
+    const localDomainOverride = domainOverrideToRootDomain(storage, randomName)
+
+    const time = Date.now();
+    localDomainOverride();
+
+    sandbox.assert.callCount(setCookieStub, 2)
+    sandbox.assert.calledWith(setCookieStub, `_gd${time}_${randomName}`, '1', undefined, undefined, 'greatpublisher.com')
+  });
+
+  it('will return the root domain when given a subdomain', () => {
+    const test_domains = [
+      'deeply.nested.subdomain.for.greatpublisher.com',
+      'greatpublisher.com',
+      'subdomain.greatpublisher.com',
+      'a-subdomain.greatpublisher.com',
+    ];
+
+    test_domains.forEach((testDomain) => {
+      domain = testDomain
+      rejectCookiesFor = 'com'
+      expect(domainOverride()).to.equal('greatpublisher.com');
+    });
+  });
+
+  it(`If we can't set cookies on the root domain, we'll return the subdomain`, () => {
+    domain = 'subdomain.greatpublisher.com'
+    rejectCookiesFor = 'greatpublisher.com'
+    expect(domainOverride()).to.equal('subdomain.greatpublisher.com');
+  });
+
+  it('Will return undefined if we can\'t set cookies on the root domain or the subdomain', () => {
+    domain = 'subdomain.greatpublisher.com'
+    rejectCookiesFor = 'subdomain.greatpublisher.com'
+    expect(domainOverride()).to.equal(undefined);
+  });
+});

package/test/spec/modules/acuityAdsBidAdapter_spec.js

@@ -76,7 +76,8 @@ describe('AcuityAdsBidAdapter', function () {
     gdprConsent: 'COvFyGBOvFyGBAbAAAENAPCAAOAAAAAAAAAAAEEUACCKAAA.IFoEUQQgAIQwgIwQABAEAAAAOIAACAIAAAAQAIAgEAACEAAAAAgAQBAAAAAAAGBAAgAAAAAAAFAAECAAAgAAQARAEQAAAAAJAAIAAgAAAYQEAAAQmAgBC3ZAYzUw',
     refererInfo: {
       referer: 'https://test.com'
-    }
+    },
+    timeout: 500
   };
 
   describe('isBidRequestValid', function () {

package/test/spec/modules/amxIdSystem_spec.js

@@ -1,4 +1,4 @@
-import { amxIdSubmodule } from 'modules/amxIdSystem.js';
+import { amxIdSubmodule, storage } from 'modules/amxIdSystem.js';
 import { server } from 'test/mocks/xhr.js';
 import * as utils from 'src/utils.js';
 
@@ -48,38 +48,17 @@ describe('validateConfig', () => {
     logErrorSpy.restore();
   });
 
-  it('should return undefined if config.storage is not present', () => {
+  it('should allow configuration with no storage', () => {
     expect(
       amxIdSubmodule.getId(
         {
           ...config,
-          storage: null,
+          storage: undefined
         },
         null,
         null
       )
-    ).to.equal(undefined);
-
-    expect(logErrorSpy.calledOnce).to.be.true;
-    expect(logErrorSpy.lastCall.lastArg).to.contain('storage is required');
-  });
-
-  it('should return undefined if config.storage.type !== "html5"', () => {
-    expect(
-      amxIdSubmodule.getId(
-        {
-          ...config,
-          storage: {
-            type: 'cookie',
-          },
-        },
-        null,
-        null
-      )
-    ).to.equal(undefined);
-
-    expect(logErrorSpy.calledOnce).to.be.true;
-    expect(logErrorSpy.lastCall.lastArg).to.contain('cookie');
+    ).to.not.equal(undefined);
   });
 
   it('should return undefined if expires > 30', () => {
@@ -111,10 +90,18 @@ describe('getId', () => {
   });
 
   it('should call the sync endpoint and accept a valid response', () => {
+    storage.setDataInLocalStorage('__amuidpb', TEST_ID);
+
     const { callback } = amxIdSubmodule.getId(config, null, null);
     callback(spy);
 
     const [request] = server.requests;
+    expect(request.withCredentials).to.be.true
+    expect(request.requestHeaders['Content-Type']).to.match(/text\/plain/)
+
+    const { search } = utils.parseUrl(request.url);
+    expect(search.av).to.equal(amxIdSubmodule.version);
+    expect(search.am).to.equal(TEST_ID);
     expect(request.method).to.equal('GET');
 
     request.respond(
@@ -187,7 +174,7 @@ describe('getId', () => {
     );
 
     const [, secondRequest] = server.requests;
-    expect(secondRequest.url).to.be.equal(intermediateValue);
+    expect(secondRequest.url).to.match(new RegExp(`^${intermediateValue}\?`));
     secondRequest.respond(
       200,
       {},