prebid.js 6.28.0 → 6.29.2

package/test/spec/modules/merkleIdSystem_spec.js

@@ -7,9 +7,8 @@ import sinon from 'sinon';
 let expect = require('chai').expect;
 
 const CONFIG_PARAMS = {
-  endpoint: 'https://test/id',
-  vendor: 'idsv2',
-  sv_cid: '5344_04531',
+  endpoint: undefined,
+  ssp_ids: ['ssp-1'],
   sv_pubid: '11314',
   sv_domain: 'www.testDomain.com',
   sv_session: 'testsession'
@@ -38,6 +37,42 @@ function mockResponse(
 }
 
 describe('Merkle System', function () {
+  describe('merkleIdSystem.decode()', function() {
+    it('provides multiple Merkle IDs (EID) from a stored object', function() {
+      let storage = {
+        merkleId: [{
+          id: 'some-random-id-value', ext: { enc: 1, keyID: 16, idName: 'pamId', ssp: 'ssp1' }
+        }, {
+          id: 'another-random-id-value',
+          ext: {
+            enc: 1,
+            idName: 'pamId',
+            third: 4,
+            ssp: 'ssp2'
+          }
+        }],
+        _svsid: 'some-identifier'
+      };
+
+      expect(merkleIdSubmodule.decode(storage)).to.deep.equal({
+        merkleId: storage.merkleId
+      });
+    });
+
+    it('can decode legacy stored object', function() {
+      let merkleId = {'pam_id': {'id': 'testmerkleId', 'keyID': 1}};
+
+      expect(merkleIdSubmodule.decode(merkleId)).to.deep.equal({
+        merkleId: {'id': 'testmerkleId', 'keyID': 1}
+      });
+    })
+
+    it('returns undefined', function() {
+      let merkleId = {};
+      expect(merkleIdSubmodule.decode(merkleId)).to.be.undefined;
+    })
+  });
+
   describe('Merkle System getId()', function () {
     const callbackSpy = sinon.spy();
     let sandbox;
@@ -59,60 +94,32 @@ describe('Merkle System', function () {
       ajaxStub.restore();
     });
 
-    it('getId() should fail on missing vendor', function () {
-      let config = {
-        params: {
-          ...CONFIG_PARAMS,
-          vendor: undefined
-        },
-        storage: STORAGE_PARAMS
-      };
-
-      let submoduleCallback = merkleIdSubmodule.getId(config, undefined);
-      expect(submoduleCallback).to.be.undefined;
-      expect(utils.logError.args[0][0]).to.exist.and.to.equal('User ID - merkleId submodule requires a valid vendor to be defined');
-    });
-
-    it('getId() should fail on missing vendor', function () {
-      let config = {
-        params: {
-          ...CONFIG_PARAMS,
-          vendor: undefined
-        },
-        storage: STORAGE_PARAMS
-      };
-
-      let submoduleCallback = merkleIdSubmodule.getId(config, undefined);
-      expect(submoduleCallback).to.be.undefined;
-      expect(utils.logError.args[0][0]).to.exist.and.to.equal('User ID - merkleId submodule requires a valid vendor to be defined');
-    });
-
-    it('getId() should fail on missing sv_cid', function () {
+    it('getId() should fail on missing sv_pubid', function () {
       let config = {
         params: {
           ...CONFIG_PARAMS,
-          sv_cid: undefined
+          sv_pubid: undefined
         },
         storage: STORAGE_PARAMS
       };
 
       let submoduleCallback = merkleIdSubmodule.getId(config, undefined);
       expect(submoduleCallback).to.be.undefined;
-      expect(utils.logError.args[0][0]).to.exist.and.to.equal('User ID - merkleId submodule requires a valid sv_cid string to be defined');
+      expect(utils.logError.args[0][0]).to.exist.and.to.equal('User ID - merkleId submodule requires a valid sv_pubid string to be defined');
     });
 
-    it('getId() should fail on missing sv_pubid', function () {
+    it('getId() should fail on missing ssp_ids', function () {
       let config = {
         params: {
           ...CONFIG_PARAMS,
-          sv_pubid: undefined
+          ssp_ids: undefined
         },
         storage: STORAGE_PARAMS
       };
 
       let submoduleCallback = merkleIdSubmodule.getId(config, undefined);
       expect(submoduleCallback).to.be.undefined;
-      expect(utils.logError.args[0][0]).to.exist.and.to.equal('User ID - merkleId submodule requires a valid sv_pubid string to be defined');
+      expect(utils.logError.args[0][0]).to.exist.and.to.equal('User ID - merkleId submodule requires a valid ssp_ids array to be defined');
     });
 
     it('getId() should warn on missing endpoint', function () {
@@ -140,6 +147,20 @@ describe('Merkle System', function () {
       submoduleCallback(callbackSpy);
       expect(callbackSpy.calledOnce).to.be.true;
     });
+
+    it('getId() does not handle consent strings', function () {
+      let config = {
+        params: {
+          ...CONFIG_PARAMS,
+          ssp_ids: []
+        },
+        storage: STORAGE_PARAMS
+      };
+
+      let submoduleCallback = merkleIdSubmodule.getId(config, { gdprApplies: true });
+      expect(submoduleCallback).to.be.undefined;
+      expect(utils.logError.args[0][0]).to.exist.and.to.equal('User ID - merkleId submodule does not currently handle consent strings');
+    });
   });
 
   describe('Merkle System extendId()', function () {

package/test/spec/modules/parrableIdSystem_spec.js

@@ -649,7 +649,6 @@ describe('Parrable ID System', function() {
       writeParrableCookie({ eid: P_COOKIE_EID, ibaOptout: true });
       init(config);
       setSubmoduleRegistry([parrableIdSubmodule]);
-      config.setConfig(getConfigMock());
     });
 
     afterEach(function() {
@@ -659,6 +658,7 @@ describe('Parrable ID System', function() {
     });
 
     it('when a stored Parrable ID exists it is added to bids', function(done) {
+      config.setConfig(getConfigMock());
       requestBidsHook(function() {
         adUnits.forEach(unit => {
           unit.bids.forEach(bid => {
@@ -685,6 +685,7 @@ describe('Parrable ID System', function() {
     it('supplies an optout reason when the EID is missing due to CCPA non-consent', function(done) {
       // the ID system itself will not write a cookie with an EID when CCPA=true
       writeParrableCookie({ ccpaOptout: true });
+      config.setConfig(getConfigMock());
 
       requestBidsHook(function() {
         adUnits.forEach(unit => {

package/test/spec/modules/pubmaticAnalyticsAdapter_spec.js

@@ -164,6 +164,8 @@ const MOCK = {
     'bids': [
       {
         'bidder': 'pubmatic',
+        'adapterCode': 'pubmatic',
+        'bidderCode': 'pubmatic',
         'params': {
           'publisherId': '1001',
           'video': {
@@ -181,6 +183,8 @@ const MOCK = {
       },
       {
         'bidder': 'pubmatic',
+        'adapterCode': 'pubmatic',
+        'bidderCode': 'pubmatic',
         'params': {
           'publisherId': '1001',
           'kgpv': 'this-is-a-kgpv'
@@ -940,6 +944,7 @@ describe('pubmatic analytics adapter', function () {
 
     it('Logger: best case + win tracker in case of Bidder Aliases', function() {
       MOCK.BID_REQUESTED['bids'][0]['bidder'] = 'pubmatic_alias';
+      MOCK.BID_REQUESTED['bids'][0]['bidderCode'] = 'pubmatic_alias';
       adapterManager.aliasRegistry['pubmatic_alias'] = 'pubmatic';
 
       sandbox.stub($$PREBID_GLOBAL$$, 'getHighestCpmBids').callsFake((key) => {
@@ -1051,5 +1056,117 @@ describe('pubmatic analytics adapter', function () {
       expect(data.en).to.equal('1.23');
       expect(data.piid).to.equal('partnerImpressionID-1');
     });
+
+    it('Logger: best case + win tracker in case of GroupM as alternate bidder', function() {
+      MOCK.BID_REQUESTED['bids'][0]['bidderCode'] = 'groupm';
+      sandbox.stub($$PREBID_GLOBAL$$, 'getHighestCpmBids').callsFake((key) => {
+        return [MOCK.BID_RESPONSE[0], MOCK.BID_RESPONSE[1]]
+      });
+
+      config.setConfig({
+        testGroupId: 15
+      });
+
+      events.emit(AUCTION_INIT, MOCK.AUCTION_INIT);
+      events.emit(BID_REQUESTED, MOCK.BID_REQUESTED);
+      events.emit(BID_RESPONSE, MOCK.BID_RESPONSE[0]);
+      events.emit(BID_RESPONSE, MOCK.BID_RESPONSE[1]);
+      events.emit(BIDDER_DONE, MOCK.BIDDER_DONE);
+      events.emit(AUCTION_END, MOCK.AUCTION_END);
+      events.emit(SET_TARGETING, MOCK.SET_TARGETING);
+      events.emit(BID_WON, MOCK.BID_WON[0]);
+      events.emit(BID_WON, MOCK.BID_WON[1]);
+
+      clock.tick(2000 + 1000);
+      expect(requests.length).to.equal(3); // 1 logger and 2 win-tracker
+      let request = requests[2]; // logger is executed late, trackers execute first
+      expect(request.url).to.equal('https://t.pubmatic.com/wl?pubid=9999');
+      let data = getLoggerJsonFromRequest(request.requestBody);
+      expect(data.pubid).to.equal('9999');
+      expect(data.pid).to.equal('1111');
+      expect(data.pdvid).to.equal('20');
+      expect(data.iid).to.equal('25c6d7f5-699a-4bfc-87c9-996f915341fa');
+      expect(data.to).to.equal('3000');
+      expect(data.purl).to.equal('http://www.test.com/page.html');
+      expect(data.orig).to.equal('www.test.com');
+      expect(data.tst).to.equal(1519767016);
+      expect(data.tgid).to.equal(15);
+      expect(data.s).to.be.an('array');
+      expect(data.s.length).to.equal(2);
+
+      // slot 1
+      expect(data.s[0].sn).to.equal('/19968336/header-bid-tag-0');
+      expect(data.s[0].sz).to.deep.equal(['640x480']);
+      expect(data.s[0].ps).to.be.an('array');
+      expect(data.s[0].ps.length).to.equal(1);
+      expect(data.s[0].ps[0].pn).to.equal('pubmatic');
+      expect(data.s[0].ps[0].bc).to.equal('groupm');
+      expect(data.s[0].ps[0].bidid).to.equal('2ecff0db240757');
+      expect(data.s[0].ps[0].piid).to.equal('partnerImpressionID-1');
+      expect(data.s[0].ps[0].db).to.equal(0);
+      expect(data.s[0].ps[0].kgpv).to.equal('/19968336/header-bid-tag-0');
+      expect(data.s[0].ps[0].kgpsv).to.equal('/19968336/header-bid-tag-0');
+      expect(data.s[0].ps[0].psz).to.equal('640x480');
+      expect(data.s[0].ps[0].eg).to.equal(1.23);
+      expect(data.s[0].ps[0].en).to.equal(1.23);
+      expect(data.s[0].ps[0].di).to.equal('');
+      expect(data.s[0].ps[0].dc).to.equal('');
+      expect(data.s[0].ps[0].l1).to.equal(3214);
+      expect(data.s[0].ps[0].l2).to.equal(0);
+      expect(data.s[0].ps[0].ss).to.equal(0);
+      expect(data.s[0].ps[0].t).to.equal(0);
+      expect(data.s[0].ps[0].wb).to.equal(1);
+      expect(data.s[0].ps[0].af).to.equal('video');
+      expect(data.s[0].ps[0].ocpm).to.equal(1.23);
+      expect(data.s[0].ps[0].ocry).to.equal('USD');
+
+      // slot 2
+      expect(data.s[1].sn).to.equal('/19968336/header-bid-tag-1');
+      expect(data.s[1].sz).to.deep.equal(['1000x300', '970x250', '728x90']);
+      expect(data.s[1].ps).to.be.an('array');
+      expect(data.s[1].ps.length).to.equal(1);
+      expect(data.s[1].ps[0].pn).to.equal('pubmatic');
+      expect(data.s[1].ps[0].bc).to.equal('pubmatic');
+      expect(data.s[1].ps[0].bidid).to.equal('3bd4ebb1c900e2');
+      expect(data.s[1].ps[0].piid).to.equal('partnerImpressionID-2');
+      expect(data.s[1].ps[0].db).to.equal(0);
+      expect(data.s[1].ps[0].kgpv).to.equal('this-is-a-kgpv');
+      expect(data.s[1].ps[0].kgpsv).to.equal('this-is-a-kgpv');
+      expect(data.s[1].ps[0].psz).to.equal('728x90');
+      expect(data.s[1].ps[0].eg).to.equal(1.52);
+      expect(data.s[1].ps[0].en).to.equal(1.52);
+      expect(data.s[1].ps[0].di).to.equal('the-deal-id');
+      expect(data.s[1].ps[0].dc).to.equal('PMP');
+      expect(data.s[1].ps[0].mi).to.equal('matched-impression');
+      expect(data.s[1].ps[0].adv).to.equal('example.com');
+      expect(data.s[1].ps[0].l1).to.equal(3214);
+      expect(data.s[1].ps[0].l2).to.equal(0);
+      expect(data.s[1].ps[0].ss).to.equal(1);
+      expect(data.s[1].ps[0].t).to.equal(0);
+      expect(data.s[1].ps[0].wb).to.equal(1);
+      expect(data.s[1].ps[0].af).to.equal('banner');
+      expect(data.s[1].ps[0].ocpm).to.equal(1.52);
+      expect(data.s[1].ps[0].ocry).to.equal('USD');
+
+      // tracker slot1
+      let firstTracker = requests[0].url;
+      expect(firstTracker.split('?')[0]).to.equal('https://t.pubmatic.com/wt');
+      data = {};
+      firstTracker.split('?')[1].split('&').map(e => e.split('=')).forEach(e => data[e[0]] = e[1]);
+      expect(data.pubid).to.equal('9999');
+      expect(decodeURIComponent(data.purl)).to.equal('http://www.test.com/page.html');
+      expect(data.tst).to.equal('1519767014');
+      expect(data.iid).to.equal('25c6d7f5-699a-4bfc-87c9-996f915341fa');
+      expect(data.bidid).to.equal('2ecff0db240757');
+      expect(data.pid).to.equal('1111');
+      expect(data.pdvid).to.equal('20');
+      expect(decodeURIComponent(data.slot)).to.equal('/19968336/header-bid-tag-0');
+      expect(decodeURIComponent(data.kgpv)).to.equal('/19968336/header-bid-tag-0');
+      expect(data.pn).to.equal('pubmatic');
+      expect(data.bc).to.equal('groupm');
+      expect(data.eg).to.equal('1.23');
+      expect(data.en).to.equal('1.23');
+      expect(data.piid).to.equal('partnerImpressionID-1');
+    });
   });
 });

package/test/spec/modules/synacormediaBidAdapter_spec.js

@@ -1362,4 +1362,78 @@ describe('synacormediaBidAdapter ', function () {
       expect(videoRequest.data.imp[0].bidfloor).to.equal(priceModuleFloor);
     });
   });
+
+  describe('Bid Requests with gpid or anything in bid.ext should use if available', function () {
+    let validVideoBidRequest = {
+      bidder: 'synacormedia',
+      params: {
+        seatId: 'prebid',
+        placementId: 'demo1',
+        pos: 1,
+        video: {}
+      },
+      renderer: {
+        url: '../syncOutstreamPlayer.js'
+      },
+      ortb2Imp: {
+        ext: {
+          gpid: '/1111/homepage-video',
+	          data: {
+            pbadslot: '/1111/homepage-video'
+          }
+        }
+      },
+      mediaTypes: {
+        video: {
+          playerSize: [[300, 250]],
+          context: 'outstream'
+        }
+      },
+      adUnitCode: 'div-1',
+      transactionId: '0869f34e-090b-4b20-84ee-46ff41405a39',
+      sizes: [[300, 250]],
+      bidId: '22b3a2268d9f0e',
+      bidderRequestId: '1d195910597e13',
+      auctionId: '3375d336-2aea-4ee7-804c-6d26b621ad20',
+      src: 'client',
+      bidRequestsCount: 1,
+      bidderRequestsCount: 1,
+      bidderWinsCount: 0
+    };
+
+    let validBannerBidRequest = {
+      bidId: '9876abcd',
+      sizes: [[300, 250]],
+      params: {
+        seatId: 'prebid',
+        placementId: '1234',
+      },
+      ortb2Imp: {
+        ext: {
+          gpid: '/1111/homepage-banner',
+	          data: {
+            pbadslot: '/1111/homepage-banner'
+          }
+        }
+      }
+    };
+
+    let bidderRequest = {
+      refererInfo: {
+        referer: 'http://localhost:9999/'
+      },
+      bidderCode: 'synacormedia',
+      auctionId: 'f8a75621-d672-4cbb-9275-3db7d74fb110'
+    };
+
+    it('should return valid gpid and pbadslot', function () {
+      let videoRequest = spec.buildRequests([validVideoBidRequest], bidderRequest);
+      let bannerRequest = spec.buildRequests([validBannerBidRequest], bidderRequest);
+
+      expect(videoRequest.data.imp[0].ext.gpid).to.equal('/1111/homepage-video');
+      expect(videoRequest.data.imp[0].ext.data.pbadslot).to.equal('/1111/homepage-video');
+      expect(bannerRequest.data.imp[0].ext.gpid).to.equal('/1111/homepage-banner');
+      expect(bannerRequest.data.imp[0].ext.data.pbadslot).to.equal('/1111/homepage-banner');
+    });
+  });
 });

package/test/spec/modules/userId_spec.js

@@ -466,6 +466,7 @@ describe('User ID', function () {
     describe('refreshing before init is complete', () => {
       const MOCK_ID = {'MOCKID': '1111'};
       let mockIdCallback;
+      let startInit;
 
       beforeEach(() => {
         mockIdCallback = sinon.stub();
@@ -480,7 +481,7 @@ describe('User ID', function () {
         };
         init(config);
         setSubmoduleRegistry([mockIdSystem]);
-        config.setConfig({
+        startInit = () => config.setConfig({
           userSync: {
             auctionDelay: 10,
             userIds: [{
@@ -492,6 +493,7 @@ describe('User ID', function () {
       });
 
       it('should still resolve promises returned by getUserIdsAsync', () => {
+        startInit();
         let result = null;
         getGlobal().getUserIdsAsync().then((val) => { result = val; });
         return clearStack().then(() => {
@@ -506,6 +508,7 @@ describe('User ID', function () {
       it('should not stop auctions', (done) => {
         // simulate an infinite `auctionDelay`; refreshing should still allow the auction to continue
         // as soon as ID submodules have completed init
+        startInit();
         requestBidsHook(() => {
           done();
         }, {adUnits: [getAdUnitMock()]}, {delay: delay()});
@@ -519,6 +522,7 @@ describe('User ID', function () {
       it('should not get stuck when init fails', () => {
         const err = new Error();
         mockIdCallback.callsFake(() => { throw err; });
+        startInit();
         return getGlobal().getUserIdsAsync().catch((e) =>
           expect(e).to.equal(err)
         );
@@ -1821,7 +1825,7 @@ describe('User ID', function () {
         }, {adUnits});
       });
 
-      it('test hook from merkleId cookies', function (done) {
+      it('test hook from merkleId cookies - legacy', function (done) {
         // simulate existing browser local storage values
         coreStorage.setCookie('merkleId', JSON.stringify({'pam_id': {'id': 'testmerkleId', 'keyID': 1}}), (new Date(Date.now() + 5000).toUTCString()));
 
@@ -1845,6 +1849,32 @@ describe('User ID', function () {
         }, {adUnits});
       });
 
+      it('test hook from merkleId cookies', function (done) {
+        // simulate existing browser local storage values
+        coreStorage.setCookie('merkleId', JSON.stringify({
+          'merkleId': [{id: 'testmerkleId', ext: { keyID: 1, ssp: 'ssp1' }}, {id: 'another-random-id-value', ext: { ssp: 'ssp2' }}],
+          '_svsid': 'svs-id-1'
+        }), (new Date(Date.now() + 5000).toUTCString()));
+
+        init(config);
+        setSubmoduleRegistry([merkleIdSubmodule]);
+        config.setConfig(getConfigMock(['merkleId', 'merkleId', 'cookie']));
+
+        requestBidsHook(function () {
+          adUnits.forEach(unit => {
+            unit.bids.forEach(bid => {
+              expect(bid).to.have.deep.nested.property('userId.merkleId');
+              expect(bid.userId.merkleId.length).to.equal(2);
+              expect(bid.userIdAsEids.length).to.equal(2);
+              expect(bid.userIdAsEids[0]).to.deep.equal({ source: 'ssp1.merkleinc.com', uids: [{id: 'testmerkleId', atype: 3, ext: { keyID: 1, ssp: 'ssp1' }}] });
+              expect(bid.userIdAsEids[1]).to.deep.equal({ source: 'ssp2.merkleinc.com', uids: [{id: 'another-random-id-value', atype: 3, ext: { ssp: 'ssp2' }}] });
+            });
+          });
+          coreStorage.setCookie('merkleId', '', EXPIRED_COOKIE_DATE);
+          done();
+        }, {adUnits});
+      });
+
       it('test hook from zeotapIdPlus cookies', function (done) {
         // simulate existing browser local storage values
         coreStorage.setCookie('IDP', btoa(JSON.stringify('abcdefghijk')), (new Date(Date.now() + 5000).toUTCString()));
@@ -2509,7 +2539,6 @@ describe('User ID', function () {
 
         // init id system
         attachIdSystem(mockIdSystem);
-        config.setConfig(userIdConfig);
       });
 
       afterEach(function () {
@@ -2520,6 +2549,8 @@ describe('User ID', function () {
         coreStorage.setCookie(mockIdCookieName, JSON.stringify({id: '1234'}), expStr);
         coreStorage.setCookie(`${mockIdCookieName}_last`, (new Date(Date.now() - 1 * 1000).toUTCString()), expStr);
 
+        config.setConfig(userIdConfig);
+
         let innerAdUnits;
         return runBidsHook((config) => {
           innerAdUnits = config.adUnits
@@ -2534,6 +2565,8 @@ describe('User ID', function () {
         coreStorage.setCookie(mockIdCookieName, JSON.stringify({id: '1234'}), expStr);
         coreStorage.setCookie(`${mockIdCookieName}_last`, (new Date(Date.now() - 60 * 1000).toUTCString()), expStr);
 
+        config.setConfig(userIdConfig);
+
         let innerAdUnits;
         return runBidsHook((config) => {
           innerAdUnits = config.adUnits
@@ -2550,6 +2583,8 @@ describe('User ID', function () {
 
         setStoredConsentData();
 
+        config.setConfig(userIdConfig);
+
         let innerAdUnits;
         return runBidsHook((config) => {
           innerAdUnits = config.adUnits
@@ -2566,6 +2601,8 @@ describe('User ID', function () {
 
         setStoredConsentData({...consentData, consentString: 'different'});
 
+        config.setConfig(userIdConfig);
+
         let innerAdUnits;
         return runBidsHook((config) => {
           innerAdUnits = config.adUnits
@@ -2582,6 +2619,8 @@ describe('User ID', function () {
 
         setStoredConsentData({...consentData});
 
+        config.setConfig(userIdConfig);
+
         let innerAdUnits;
         return runBidsHook((config) => {
           innerAdUnits = config.adUnits

package/test/spec/modules/vidazooBidAdapter_spec.js

@@ -322,7 +322,9 @@ describe('VidazooBidAdapter', function () {
   describe('unique deal id', function () {
     const key = 'myKey';
     let uniqueDealId;
-    uniqueDealId = getUniqueDealId(key);
+    beforeEach(() => {
+      uniqueDealId = getUniqueDealId(key, 0);
+    })
 
     it('should get current unique deal id', function (done) {
       // waiting some time so `now` will become past
@@ -333,9 +335,12 @@ describe('VidazooBidAdapter', function () {
       }, 200);
     });
 
-    it('should get new unique deal id on expiration', function () {
-      const current = getUniqueDealId(key, 100);
-      expect(current).to.not.be.equal(uniqueDealId);
+    it('should get new unique deal id on expiration', function (done) {
+      setTimeout(() => {
+        const current = getUniqueDealId(key, 100);
+        expect(current).to.not.be.equal(uniqueDealId);
+        done();
+      }, 200)
     });
   });
 

package/test/spec/unit/pbjs_api_spec.js

@@ -16,8 +16,7 @@ import * as auctionModule from 'src/auction.js';
 import { registerBidder } from 'src/adapters/bidderFactory.js';
 import { _sendAdToCreative } from 'src/secureCreatives.js';
 import {find} from 'src/polyfill.js';
-import {synchronizePromise} from '../../helpers/syncPromise.js';
-import 'src/prebid.js';
+import * as pbjsModule from 'src/prebid.js';
 import {hook} from '../../../src/hook.js';
 
 var assert = require('chai').assert;
@@ -193,7 +192,7 @@ window.apntag = {
 }
 
 describe('Unit: Prebid Module', function () {
-  let bidExpiryStub, promiseSandbox;
+  let bidExpiryStub
 
   before(() => {
     hook.ready();
@@ -201,14 +200,11 @@ describe('Unit: Prebid Module', function () {
   });
 
   beforeEach(function () {
-    promiseSandbox = sinon.createSandbox();
-    synchronizePromise(promiseSandbox);
     bidExpiryStub = sinon.stub(filters, 'isBidNotExpired').callsFake(() => true);
     configObj.setConfig({ useBidCache: true });
   });
 
   afterEach(function() {
-    promiseSandbox.restore();
     $$PREBID_GLOBAL$$.adUnits = [];
     bidExpiryStub.restore();
     configObj.setConfig({ useBidCache: false });