prebid.js 6.28.0 → 6.29.2

package/test/spec/modules/gdprEnforcement_spec.js

@@ -1,21 +1,21 @@
 import {
   deviceAccessHook,
-  setEnforcementConfig,
-  userSyncHook,
-  userIdHook,
-  makeBidRequestsHook,
-  validateRules,
+  enableAnalyticsHook,
   enforcementRules,
+  getGvlid,
+  internal,
+  makeBidRequestsHook,
   purpose1Rule,
   purpose2Rule,
-  enableAnalyticsHook,
-  getGvlid,
-  internal
+  setEnforcementConfig,
+  userIdHook,
+  userSyncHook,
+  validateRules
 } from 'modules/gdprEnforcement.js';
-import { config } from 'src/config.js';
-import adapterManager, { gdprDataHandler } from 'src/adapterManager.js';
+import {config} from 'src/config.js';
+import adapterManager, {gdprDataHandler} from 'src/adapterManager.js';
 import * as utils from 'src/utils.js';
-import { validateStorageEnforcement } from 'src/storageManager.js';
+import {validateStorageEnforcement} from 'src/storageManager.js';
 import * as events from 'src/events.js';
 
 describe('gdpr enforcement', function () {
@@ -98,9 +98,9 @@ describe('gdpr enforcement', function () {
   };
 
   after(function () {
-    validateStorageEnforcement.getHooks({ hook: deviceAccessHook }).remove();
+    validateStorageEnforcement.getHooks({hook: deviceAccessHook}).remove();
     $$PREBID_GLOBAL$$.requestBids.getHooks().remove();
-    adapterManager.makeBidRequests.getHooks({ hook: makeBidRequestsHook }).remove();
+    adapterManager.makeBidRequests.getHooks({hook: makeBidRequestsHook}).remove();
   })
 
   describe('deviceAccessHook', function () {
@@ -149,7 +149,7 @@ describe('gdpr enforcement', function () {
         hasEnforcementHook: true,
         valid: false
       }
-      sinon.assert.calledWith(nextFnSpy, undefined, undefined, result);
+      sinon.assert.calledWith(nextFnSpy, undefined, undefined, undefined, result);
     });
 
     it('should only check for consent for vendor exceptions when enforcePurpose and enforceVendor are false', function () {
@@ -199,6 +199,53 @@ describe('gdpr enforcement', function () {
       expect(logWarnSpy.callCount).to.equal(1);
     });
 
+    it('should allow device access when enforce vendor but module is vendorless ', function () {
+      adapterManagerStub.withArgs('pubCommonId').returns(getBidderSpec(1));
+      setEnforcementConfig({
+        gdpr: {
+          rules: [{
+            purpose: 'storage',
+            enforcePurpose: true,
+            enforceVendor: true,
+          }]
+        }
+      });
+      let consentData = {}
+      consentData.vendorData = staticConfig.consentData.getTCData;
+      consentData.gdprApplies = true;
+      consentData.apiVersion = 2;
+      gdprDataHandlerStub.returns(consentData);
+
+      deviceAccessHook(nextFnSpy, 1, 'pubCommonId', 'fpid-module');
+      expect(logWarnSpy.callCount).to.equal(0);
+    });
+
+    it('should not allow device access if enforce vendor, module is vendorless, but there is no consent for purpose 1', function () {
+      adapterManagerStub.withArgs('pubCommonId').returns(getBidderSpec(1));
+      setEnforcementConfig({
+        gdpr: {
+          rules: [{
+            purpose: 'storage',
+            enforcePurpose: true,
+            enforceVendor: true,
+          }]
+        }
+      });
+
+      let consentData = {}
+      // set consent for purpose 1 to false
+      const newConsentData = utils.deepClone(staticConfig);
+      newConsentData.consentData.getTCData.purpose.consents['1'] = false;
+      consentData.vendorData = newConsentData.consentData.getTCData;
+      consentData.apiVersion = 2;
+      consentData.gdprApplies = true;
+
+      gdprDataHandlerStub.returns(consentData);
+
+      deviceAccessHook(nextFnSpy, 1, 'pubCommonId', 'fpid-module');
+      expect(logWarnSpy.callCount).to.equal(1);
+    });
+
     it('should allow device access when gdprApplies is false and hasDeviceAccess flag is true', function () {
       adapterManagerStub.withArgs('appnexus').returns(getBidderSpec(1));
       setEnforcementConfig({
@@ -223,10 +270,10 @@ describe('gdpr enforcement', function () {
         hasEnforcementHook: true,
         valid: true
       }
-      sinon.assert.calledWith(nextFnSpy, 1, 'appnexus', result);
+      sinon.assert.calledWith(nextFnSpy, 1, 'appnexus', undefined, result);
     });
 
-    it('should use gvlMapping set by publisher', function() {
+    it('should use gvlMapping set by publisher', function () {
       config.setConfig({
         'gvlMapping': {
           'appnexus': 4
@@ -254,11 +301,11 @@ describe('gdpr enforcement', function () {
         hasEnforcementHook: true,
         valid: true
       }
-      sinon.assert.calledWith(nextFnSpy, 4, 'appnexus', result);
+      sinon.assert.calledWith(nextFnSpy, 4, 'appnexus', undefined, result);
       config.resetConfig();
     });
 
-    it('should use gvl id of alias and not of parent', function() {
+    it('should use gvl id of alias and not of parent', function () {
       let curBidderStub = sinon.stub(config, 'getCurrentBidder');
       curBidderStub.returns('appnexus-alias');
       adapterManager.aliasBidAdapter('appnexus', 'appnexus-alias');
@@ -289,7 +336,7 @@ describe('gdpr enforcement', function () {
         hasEnforcementHook: true,
         valid: true
       }
-      sinon.assert.calledWith(nextFnSpy, 4, 'appnexus', result);
+      sinon.assert.calledWith(nextFnSpy, 4, 'appnexus', undefined, result);
       config.resetConfig();
       curBidderStub.restore();
     });
@@ -470,7 +517,7 @@ describe('gdpr enforcement', function () {
       const args = nextFnSpy.getCalls()[0].args;
       expect(args[1].hasValidated).to.be.true;
       expect(nextFnSpy.calledOnce).to.equal(true);
-      sinon.assert.calledWith(nextFnSpy, submodules, { ...consentData, hasValidated: true });
+      sinon.assert.calledWith(nextFnSpy, submodules, {...consentData, hasValidated: true});
     });
 
     it('should allow userId module if gdpr not in scope', function () {
@@ -524,7 +571,7 @@ describe('gdpr enforcement', function () {
           name: 'sampleUserId'
         }
       }]
-      sinon.assert.calledWith(nextFnSpy, expectedSubmodules, { ...consentData, hasValidated: true });
+      sinon.assert.calledWith(nextFnSpy, expectedSubmodules, {...consentData, hasValidated: true});
     });
   });
 
@@ -583,17 +630,17 @@ describe('gdpr enforcement', function () {
       gdprDataHandlerStub.returns(consentData);
       adapterManagerStub.withArgs('bidder_1').returns({
         getSpec: function () {
-          return { 'gvlid': 4 }
+          return {'gvlid': 4}
         }
       });
       adapterManagerStub.withArgs('bidder_2').returns({
         getSpec: function () {
-          return { 'gvlid': 5 }
+          return {'gvlid': 5}
         }
       });
       adapterManagerStub.withArgs('bidder_3').returns({
         getSpec: function () {
-          return { 'gvlid': undefined }
+          return {'gvlid': undefined}
         }
       });
       makeBidRequestsHook(nextFnSpy, MOCK_AD_UNITS, []);
@@ -604,20 +651,20 @@ describe('gdpr enforcement', function () {
         code: 'ad-unit-1',
         mediaTypes: {},
         bids: [
-          sinon.match({ bidder: 'bidder_1' }),
-          sinon.match({ bidder: 'bidder_2' })
+          sinon.match({bidder: 'bidder_1'}),
+          sinon.match({bidder: 'bidder_2'})
         ]
       }, {
         code: 'ad-unit-2',
         mediaTypes: {},
         bids: [
-          sinon.match({ bidder: 'bidder_2' }),
-          sinon.match({ bidder: 'bidder_3' }) // should be allowed even though it's doesn't have a gvlId because liTransparency is established.
+          sinon.match({bidder: 'bidder_2'}),
+          sinon.match({bidder: 'bidder_3'}) // should be allowed even though it's doesn't have a gvlId because liTransparency is established.
         ]
       }], []);
     });
 
-    it('should block bidder which does not have consent and allow bidder which has consent (liTransparency is NOT established)', function() {
+    it('should block bidder which does not have consent and allow bidder which has consent (liTransparency is NOT established)', function () {
       setEnforcementConfig({
         gdpr: {
           rules: [{
@@ -641,17 +688,17 @@ describe('gdpr enforcement', function () {
       gdprDataHandlerStub.returns(consentData);
       adapterManagerStub.withArgs('bidder_1').returns({
         getSpec: function () {
-          return { 'gvlid': 4 }
+          return {'gvlid': 4}
         }
       });
       adapterManagerStub.withArgs('bidder_2').returns({
         getSpec: function () {
-          return { 'gvlid': 5 }
+          return {'gvlid': 5}
         }
       });
       adapterManagerStub.withArgs('bidder_3').returns({
         getSpec: function () {
-          return { 'gvlid': undefined }
+          return {'gvlid': undefined}
         }
       });
 
@@ -663,13 +710,13 @@ describe('gdpr enforcement', function () {
         code: 'ad-unit-1',
         mediaTypes: {},
         bids: [
-          sinon.match({ bidder: 'bidder_1' }), // 'bidder_2' is not present because it doesn't have vendorConsent
+          sinon.match({bidder: 'bidder_1'}), // 'bidder_2' is not present because it doesn't have vendorConsent
         ]
       }, {
         code: 'ad-unit-2',
         mediaTypes: {},
         bids: [
-          sinon.match({ bidder: 'bidder_3' }), // 'bidder_3' is allowed despite gvlId being undefined because it's part of vendorExceptions
+          sinon.match({bidder: 'bidder_3'}), // 'bidder_3' is allowed despite gvlId being undefined because it's part of vendorExceptions
         ]
       }], []);
 
@@ -727,12 +774,12 @@ describe('gdpr enforcement', function () {
       nextFnSpy = sandbox.spy();
     });
 
-    afterEach(function() {
+    afterEach(function () {
       config.resetConfig();
       sandbox.restore();
     });
 
-    it('should block analytics adapter which does not have consent and allow the one(s) which have consent', function() {
+    it('should block analytics adapter which does not have consent and allow the one(s) which have consent', function () {
       setEnforcementConfig({
         gdpr: {
           rules: [{
@@ -750,9 +797,9 @@ describe('gdpr enforcement', function () {
       consentData.gdprApplies = true;
 
       gdprDataHandlerStub.returns(consentData);
-      adapterManagerStub.withArgs('analyticsAdapter_A').returns({ gvlid: 3 });
-      adapterManagerStub.withArgs('analyticsAdapter_B').returns({ gvlid: 5 });
-      adapterManagerStub.withArgs('analyticsAdapter_C').returns({ gvlid: 1 });
+      adapterManagerStub.withArgs('analyticsAdapter_A').returns({gvlid: 3});
+      adapterManagerStub.withArgs('analyticsAdapter_B').returns({gvlid: 5});
+      adapterManagerStub.withArgs('analyticsAdapter_C').returns({gvlid: 1});
 
       enableAnalyticsHook(nextFnSpy, MOCK_ANALYTICS_ADAPTER_CONFIG);
 
@@ -1025,7 +1072,7 @@ describe('gdpr enforcement', function () {
       expect(purpose2Rule).to.deep.equal(purpose2RuleDefinedInConfig);
     });
 
-    it('should use the "rules" defined in config if a definition found', function() {
+    it('should use the "rules" defined in config if a definition found', function () {
       const rules = [{
         purpose: 'storage',
         enforcePurpose: false,
@@ -1035,23 +1082,23 @@ describe('gdpr enforcement', function () {
         enforcePurpose: false,
         enforceVendor: false
       }]
-      setEnforcementConfig({gdpr: { rules }});
+      setEnforcementConfig({gdpr: {rules}});
 
       expect(enforcementRules).to.deep.equal(rules);
     });
   });
 
-  describe('TCF2FinalResults', function() {
+  describe('TCF2FinalResults', function () {
     let sandbox;
-    beforeEach(function() {
+    beforeEach(function () {
       sandbox = sinon.createSandbox();
       sandbox.spy(events, 'emit');
     });
-    afterEach(function() {
+    afterEach(function () {
       config.resetConfig();
       sandbox.restore();
     });
-    it('should emit TCF2 enforcement data on auction end', function() {
+    it('should emit TCF2 enforcement data on auction end', function () {
       const rules = [{
         purpose: 'storage',
         enforcePurpose: false,
@@ -1061,7 +1108,7 @@ describe('gdpr enforcement', function () {
         enforcePurpose: false,
         enforceVendor: false
       }]
-      setEnforcementConfig({gdpr: { rules }});
+      setEnforcementConfig({gdpr: {rules}});
 
       events.emit('auctionEnd', {})
 
@@ -1070,28 +1117,28 @@ describe('gdpr enforcement', function () {
     })
   });
 
-  describe('getGvlid', function() {
+  describe('getGvlid', function () {
     let sandbox;
     let getGvlidForBidAdapterStub;
     let getGvlidForUserIdModuleStub;
     let getGvlidForAnalyticsAdapterStub;
-    beforeEach(function() {
+    beforeEach(function () {
       sandbox = sinon.createSandbox();
       getGvlidForBidAdapterStub = sandbox.stub(internal, 'getGvlidForBidAdapter');
       getGvlidForUserIdModuleStub = sandbox.stub(internal, 'getGvlidForUserIdModule');
       getGvlidForAnalyticsAdapterStub = sandbox.stub(internal, 'getGvlidForAnalyticsAdapter');
     });
-    afterEach(function() {
+    afterEach(function () {
       sandbox.restore();
       config.resetConfig();
     });
 
-    it('should return "null" if called without passing any argument', function() {
+    it('should return "null" if called without passing any argument', function () {
       const gvlid = getGvlid();
       expect(gvlid).to.equal(null);
     });
 
-    it('should return "null" if GVL ID is not defined for any of these modules: Bid adapter, UserId submodule and Analytics adapter', function() {
+    it('should return "null" if GVL ID is not defined for any of these modules: Bid adapter, UserId submodule and Analytics adapter', function () {
       getGvlidForBidAdapterStub.withArgs('moduleA').returns(null);
       getGvlidForUserIdModuleStub.withArgs('moduleA').returns(null);
       getGvlidForAnalyticsAdapterStub.withArgs('moduleA').returns(null);
@@ -1100,7 +1147,7 @@ describe('gdpr enforcement', function () {
       expect(gvlid).to.equal(null);
     });
 
-    it('should return the GVL ID from gvlMapping if it is defined in setConfig', function() {
+    it('should return the GVL ID from gvlMapping if it is defined in setConfig', function () {
       config.setConfig({
         gvlMapping: {
           moduleA: 1
@@ -1114,7 +1161,7 @@ describe('gdpr enforcement', function () {
       expect(gvlid).to.equal(1);
     });
 
-    it('should return the GVL ID by calling getGvlidForBidAdapter -> getGvlidForUserIdModule -> getGvlidForAnalyticsAdapter in sequence', function() {
+    it('should return the GVL ID by calling getGvlidForBidAdapter -> getGvlidForUserIdModule -> getGvlidForAnalyticsAdapter in sequence', function () {
       getGvlidForBidAdapterStub.withArgs('moduleA').returns(null);
       getGvlidForUserIdModuleStub.withArgs('moduleA').returns(null);
       getGvlidForAnalyticsAdapterStub.withArgs('moduleA').returns(7);

package/test/spec/modules/idxIdSystem_spec.js

@@ -94,8 +94,8 @@ describe('IDx ID System', () => {
       adUnits = [getAdUnitMock()];
       init(config);
       setSubmoduleRegistry([idxIdSubmodule]);
-      config.setConfig(getConfigMock());
       getCookieStub.withArgs(IDX_COOKIE_NAME).returns(IDX_COOKIE_STORED);
+      config.setConfig(getConfigMock());
     });
 
     afterEach(() => {

package/test/spec/modules/insticatorBidAdapter_spec.js

@@ -27,7 +27,15 @@ describe('InsticatorBidAdapter', function () {
       banner: {
         sizes: [[300, 250], [300, 600]],
         pos: 4,
-      }
+      },
+      video: {
+        mimes: [
+          'video/mp4',
+          'video/mpeg',
+        ],
+        w: 250,
+        h: 300,
+      },
     },
     bidId: '30b31c1838de1e',
     ortb2Imp: {
@@ -116,6 +124,35 @@ describe('InsticatorBidAdapter', function () {
       bidRequest.mediaTypes.banner.sizes = [[300, 250], [300, 600]];
       expect(spec.isBidRequestValid({ ...bidRequest, ...{ sizes: {} } })).to.be.true;
     });
+
+    it('should return true if there is video and video sizes', () => {
+      expect(spec.isBidRequestValid({
+        ...bidRequest,
+        ...{
+          mediaTypes: {
+            video: {
+              mimes: [
+                'video/mp4',
+                'video/mpeg',
+              ],
+              w: 250,
+              h: 300,
+            },
+          }
+        }
+      })).to.be.true;
+    });
+
+    it('should return false if there is no video sizes', () => {
+      expect(spec.isBidRequestValid({
+        ...bidRequest,
+        ...{
+          mediaTypes: {
+            video: {},
+          }
+        }
+      })).to.be.false;
+    });
   });
 
   describe('buildRequests', function () {
@@ -240,6 +277,14 @@ describe('InsticatorBidAdapter', function () {
             { w: 300, h: 600 },
           ]
         },
+        video: {
+          mimes: [
+            'video/mp4',
+            'video/mpeg',
+          ],
+          h: 300,
+          w: 250,
+        },
         ext: {
           gpid: bidRequest.ortb2Imp.ext.gpid,
           insticator: {

package/test/spec/modules/ixBidAdapter_spec.js

@@ -7,7 +7,7 @@ import { createEidsArray } from 'modules/userId/eids.js';
 import { deepAccess } from '../../../src/utils.js';
 
 describe('IndexexchangeAdapter', function () {
-  const IX_SECURE_ENDPOINT = 'https://htlb.casalemedia.com/cygnus';
+  const IX_SECURE_ENDPOINT = 'https://htlb.casalemedia.com/openrtb/pbjs';
   const VIDEO_ENDPOINT_VERSION = 8.1;
   const BANNER_ENDPOINT_VERSION = 7.2;
 

package/test/spec/modules/lassoBidAdapter_spec.js

@@ -0,0 +1,177 @@
+import { expect } from 'chai';
+import { spec } from 'modules/lassoBidAdapter.js';
+import { server } from '../../mocks/xhr';
+
+const ENDPOINT_URL = 'https://trc.lhmos.com/prebid';
+
+const bid = {
+  bidder: 'lasso',
+  params: {
+    adUnitId: 123456
+  },
+  auctionStart: Date.now(),
+  adUnitCode: 'adunit-code',
+  auctionId: 'cfa6f46d-4584-46e1-9c00-54769abb51e3',
+  bidderRequestId: 'a123b456c789d',
+  bidId: '123a456b789',
+  mediaTypes: {
+    banner: {
+      sizes: [[300, 250]]
+    }
+  },
+  sizes: [[300, 250]],
+  src: 'client',
+  transactionId: '26740296-0111-4b7a-80df-7196823026f4'
+};
+
+const bidderRequest = {
+  auctionId: 'cfa6f46d-4584-46e1-9c00-54769abb51e3',
+  auctionStart: Date.now(),
+  start: Date.now(),
+  biddeCode: 'lasso',
+  bidderRequestId: 'a123b456c789d',
+  bids: [bid],
+  timeout: 10000
+};
+
+describe('lassoBidAdapter', function () {
+  describe('All needed functions are available', function() {
+    it(`isBidRequestValid is present and type function`, function () {
+      expect(spec.isBidRequestValid).to.exist.and.to.be.a('function')
+    });
+
+    it(`buildRequests is present and type function`, function () {
+      expect(spec.buildRequests).to.exist.and.to.be.a('function')
+    });
+
+    it(`interpretResponse is present and type function`, function () {
+      expect(spec.interpretResponse).to.exist.and.to.be.a('function')
+    });
+
+    it(`onTimeout is present and type function`, function () {
+      expect(spec.onTimeout).to.exist.and.to.be.a('function')
+    });
+
+    it(`onBidWon is present and type function`, function () {
+      expect(spec.onBidWon).to.exist.and.to.be.a('function')
+    });
+  });
+
+  describe('isBidRequestValid', function () {
+    it('should return true when required params found', function () {
+      expect(spec.isBidRequestValid(bid)).to.equal(true);
+    });
+    it('should return true when there are extra params', function () {
+      const bid = Object.assign({}, bid, {
+        params: {
+          adUnitId: 123456,
+          zone: 1,
+          publisher: 'test'
+        }
+      })
+      expect(spec.isBidRequestValid(bid)).to.equal(true);
+    });
+    it('should return false when there are no params', function () {
+      const invalidBid = { ...bid };
+      delete invalidBid.params;
+      expect(spec.isBidRequestValid(invalidBid)).to.equal(false);
+    });
+  });
+
+  describe('buildRequests', function () {
+    const validBidRequests = spec.buildRequests([bid], bidderRequest);
+    expect(validBidRequests).to.be.an('array').that.is.not.empty;
+
+    const bidRequest = validBidRequests[0];
+
+    it('Returns valid bidRequest', function () {
+      expect(bidRequest).to.exist;
+      expect(bidRequest.method).to.exist;
+      expect(bidRequest.url).to.exist;
+      expect(bidRequest.data).to.exist;
+    });
+
+    it('Returns GET method', function() {
+      expect(bidRequest.method).to.exist;
+      expect(bidRequest.method).to.equal('GET');
+    });
+  });
+
+  describe('interpretResponse', function () {
+    let serverResponse = {
+      body: {
+        bidid: '123456789',
+        id: '33302780340222111',
+        bid: {
+          price: 1,
+          w: 728,
+          h: 90,
+          crid: 123456,
+          ad: '<script>console.log("ad");</script>',
+          mediaType: 'banner'
+        },
+        meta: {
+          cat: ['1', '2', '3', '4'],
+          advertiserDomains: ['lassomarketing.io'],
+          advertiserName: 'Lasso'
+        },
+        cur: 'USD',
+        netRevenue: false,
+        ttl: 300,
+      }
+    };
+
+    it('should get the correct bid response', function () {
+      let expectedResponse = {
+        requestId: '123456789',
+        cpm: 1,
+        currency: 'USD',
+        width: 728,
+        height: 90,
+        creativeId: 123456,
+        netRevenue: false,
+        ttl: 300,
+        ad: '<script>console.log("ad");</script>',
+        mediaType: 'banner',
+        meta: {
+          secondaryCatIds: ['1', '2', '3', '4'],
+          advertiserDomains: ['lassomarketing.io'],
+          advertiserName: 'Lasso',
+          mediaType: 'banner'
+        }
+      };
+      let result = spec.interpretResponse(serverResponse);
+      expect(Object.keys(result[0])).to.deep.equal(Object.keys(expectedResponse));
+    });
+  });
+
+  describe('onTimeout', () => {
+    it('should send timeout', () => {
+      const timeoutData = {
+        bidder: 'lasso',
+        auctionId: 'cfa6f46d-4584-46e1-9c00-54769abb51e3',
+        dUnitCode: 'adunit-code',
+        bidId: '123a456b789',
+        params: {
+          adUnitId: 123456,
+        },
+        timeout: 3000
+      };
+      spec.onTimeout(timeoutData);
+
+      expect(server.requests[0].method).to.equal('POST');
+      expect(server.requests[0].url).to.equal(ENDPOINT_URL + '/timeout');
+      expect(JSON.parse(server.requests[0].requestBody)).to.deep.equal(timeoutData);
+    });
+  });
+
+  describe('onBidWon', () => {
+    it('should send bid won request', () => {
+      spec.onBidWon(bid);
+
+      expect(server.requests[0].method).to.equal('POST');
+      expect(server.requests[0].url).to.equal(ENDPOINT_URL + '/won');
+      expect(JSON.parse(server.requests[0].requestBody)).to.deep.equal(bid);
+    });
+  });
+});