prebid.js 5.14.0 → 5.18.0

package/test/spec/modules/yieldlabBidAdapter_spec.js

@@ -1,3 +1,4 @@
+import { config } from 'src/config.js';
 import { expect } from 'chai'
 import { spec } from 'modules/yieldlabBidAdapter.js'
 import { newBidder } from 'src/adapters/bidderFactory.js'
@@ -16,7 +17,22 @@ const REQUEST = {
       'extraParam': true,
       'foo': 'bar'
     },
-    'extId': 'abc'
+    'extId': 'abc',
+    'iabContent': {
+      'id': 'foo_id',
+      'episode': '99',
+      'title': 'foo_title,bar_title',
+      'series': 'foo_series',
+      'season': 's1',
+      'artist': 'foo bar',
+      'genre': 'baz',
+      'isrc': 'CC-XXX-YY-NNNNN',
+      'url': 'http://foo_url.de',
+      'cat': ['cat1', 'cat2,ppp', 'cat3|||//'],
+      'context': '7',
+      'keywords': ['k1,', 'k2..'],
+      'live': '0'
+    }
   },
   'bidderRequestId': '143346cf0f1731',
   'auctionId': '2e41f65424c87c',
@@ -86,6 +102,10 @@ const REQPARAMS_GDPR = Object.assign({}, REQPARAMS, {
   consent: 'BN5lERiOMYEdiAKAWXEND1AAAAE6DABACMA'
 })
 
+const REQPARAMS_IAB_CONTENT = Object.assign({}, REQPARAMS, {
+  iab_content: 'id%3Afoo_id%2Cepisode%3A99%2Ctitle%3Afoo_title%252Cbar_title%2Cseries%3Afoo_series%2Cseason%3As1%2Cartist%3Afoo%2520bar%2Cgenre%3Abaz%2Cisrc%3ACC-XXX-YY-NNNNN%2Curl%3Ahttp%253A%252F%252Ffoo_url.de%2Ccat%3Acat1%7Ccat2%252Cppp%7Ccat3%257C%257C%257C%252F%252F%2Ccontext%3A7%2Ckeywords%3Ak1%252C%7Ck2..%2Clive%3A0'
+})
+
 describe('yieldlabBidAdapter', function () {
   const adapter = newBidder(spec)
 
@@ -139,6 +159,40 @@ describe('yieldlabBidAdapter', function () {
       expect(request.url).to.include('schain=1.0,1!indirectseller.com,1,1,,,,!indirectseller2.com,2,1,,indirectseller2%20name%20with%20comma%20%2C%20and%20bang%20%21,,')
     })
 
+    it('passes iab_content string to bid request', function () {
+      expect(request.url).to.include('iab_content=id%3Afoo_id%2Cepisode%3A99%2Ctitle%3Afoo_title%252Cbar_title%2Cseries%3Afoo_series%2Cseason%3As1%2Cartist%3Afoo%2520bar%2Cgenre%3Abaz%2Cisrc%3ACC-XXX-YY-NNNNN%2Curl%3Ahttp%253A%252F%252Ffoo_url.de%2Ccat%3Acat1%7Ccat2%252Cppp%7Ccat3%257C%257C%257C%252F%252F%2Ccontext%3A7%2Ckeywords%3Ak1%252C%7Ck2..%2Clive%3A0')
+    })
+
+    const siteConfig = {
+      'ortb2': {
+        'site': {
+          'content': {
+            'id': 'id_from_config'
+          }
+        }
+      }
+    }
+
+    it('generates iab_content string from bidder params', function () {
+      config.setConfig(siteConfig);
+      const request = spec.buildRequests([REQUEST])
+      expect(request.url).to.include('iab_content=id%3Afoo_id%2Cepisode%3A99%2Ctitle%3Afoo_title%252Cbar_title%2Cseries%3Afoo_series%2Cseason%3As1%2Cartist%3Afoo%2520bar%2Cgenre%3Abaz%2Cisrc%3ACC-XXX-YY-NNNNN%2Curl%3Ahttp%253A%252F%252Ffoo_url.de%2Ccat%3Acat1%7Ccat2%252Cppp%7Ccat3%257C%257C%257C%252F%252F%2Ccontext%3A7%2Ckeywords%3Ak1%252C%7Ck2..%2Clive%3A0')
+      config.resetConfig();
+    })
+
+    it('generates iab_content string from first party data if not provided in bidder params', function () {
+      const requestWithoutIabContent = {
+        'params': {
+          'adslotId': '1111',
+          'supplyId': '2222'
+        }
+      }
+      config.setConfig(siteConfig);
+      const request = spec.buildRequests([requestWithoutIabContent])
+      expect(request.url).to.include('iab_content=id%3Aid_from_config')
+      config.resetConfig();
+    })
+
     const refererRequest = spec.buildRequests(bidRequests, {
       refererInfo: {
         canonicalUrl: undefined,
@@ -203,6 +257,11 @@ describe('yieldlabBidAdapter', function () {
       expect(result[0].ad).to.include('&consent=BN5lERiOMYEdiAKAWXEND1AAAAE6DABACMA')
     })
 
+    it('should append iab_content to adtag', function () {
+      const result = spec.interpretResponse({body: [RESPONSE]}, {validBidRequests: [REQUEST], queryParams: REQPARAMS_IAB_CONTENT})
+      expect(result[0].ad).to.include('&iab_content=id%3Afoo_id%2Cepisode%3A99%2Ctitle%3Afoo_title%252Cbar_title%2Cseries%3Afoo_series%2Cseason%3As1%2Cartist%3Afoo%2520bar%2Cgenre%3Abaz%2Cisrc%3ACC-XXX-YY-NNNNN%2Curl%3Ahttp%253A%252F%252Ffoo_url.de%2Ccat%3Acat1%7Ccat2%252Cppp%7Ccat3%257C%257C%257C%252F%252F%2Ccontext%3A7%2Ckeywords%3Ak1%252C%7Ck2..%2Clive%3A0')
+    })
+
     it('should get correct bid response when passing more than one size', function () {
       const REQUEST2 = Object.assign({}, REQUEST, {
         'sizes': [
@@ -268,5 +327,10 @@ describe('yieldlabBidAdapter', function () {
       expect(result[0].ad).to.include('&pvid=43513f11-55a0-4a83-94e5-0ebc08f54a2c')
       expect(result[0].vastUrl).to.include('&pvid=43513f11-55a0-4a83-94e5-0ebc08f54a2c')
     })
+
+    it('should append iab_content to vastUrl', function () {
+      const result = spec.interpretResponse({body: [VIDEO_RESPONSE]}, {validBidRequests: [VIDEO_REQUEST], queryParams: REQPARAMS_IAB_CONTENT})
+      expect(result[0].vastUrl).to.include('&iab_content=id%3Afoo_id%2Cepisode%3A99%2Ctitle%3Afoo_title%252Cbar_title%2Cseries%3Afoo_series%2Cseason%3As1%2Cartist%3Afoo%2520bar%2Cgenre%3Abaz%2Cisrc%3ACC-XXX-YY-NNNNN%2Curl%3Ahttp%253A%252F%252Ffoo_url.de%2Ccat%3Acat1%7Ccat2%252Cppp%7Ccat3%257C%257C%257C%252F%252F%2Ccontext%3A7%2Ckeywords%3Ak1%252C%7Ck2..%2Clive%3A0')
+    })
   })
 })

package/test/spec/modules/yieldmoBidAdapter_spec.js

@@ -307,7 +307,7 @@ describe('YieldmoAdapter', function () {
       });
 
       it('should only shortcut properties rather then completely remove it', () => {
-        const longString = new Array(7516).join('a');
+        const longString = new Array(8000).join('a');
         const localWindow = utils.getWindowTop();
 
         const originalTitle = localWindow.document.title;
@@ -319,7 +319,7 @@ describe('YieldmoAdapter', function () {
             refererInfo: {
               numIframes: 1,
               reachedTop: true,
-              referer: longString,
+              title: longString,
             },
           })
         )[0];
@@ -345,6 +345,20 @@ describe('YieldmoAdapter', function () {
         let placementInfo = buildAndGetPlacementInfo(bidArray);
         expect(placementInfo).to.include('"gpid":"/6355419/Travel/Europe/France/Paris"');
       });
+
+      it('should add eids to the banner bid request', function () {
+        const params = {
+          userId: {pubcid: 'fake_pubcid'},
+          fakeUserIdAsEids: [{
+            source: 'pubcid.org',
+            uids: [{
+              id: 'fake_pubcid',
+              atype: 1
+            }]
+          }]
+        };
+        expect(buildAndGetData([mockBannerBid({...params})]).eids).equal(JSON.stringify(params.fakeUserIdAsEids));
+      });
     });
 
     describe('Instream video:', function () {
@@ -469,19 +483,26 @@ describe('YieldmoAdapter', function () {
         expect(buildAndGetData([mockVideoBid({schain})]).schain).to.deep.equal(schain);
       });
 
-      it('should add ip to the video bidRequest', () => {
-        const device = {
-          ip: '111.222.333.444'
-        };
-        expect(buildAndGetData([mockVideoBid(null, {device})]).device.ip).to.be.equal(device.ip);
-      });
-
       it('should add gpid to the video request', function () {
         const ortb2Imp = {
           ext: { data: { pbadslot: '/6355419/Travel/Europe/France/Paris' } },
         };
         expect(buildAndGetData([mockVideoBid({ortb2Imp})]).imp[0].ext.gpid).to.be.equal(ortb2Imp.ext.data.pbadslot);
       });
+
+      it('should add eids to the video bid request', function () {
+        const params = {
+          userId: {pubcid: 'fake_pubcid'},
+          fakeUserIdAsEids: [{
+            source: 'pubcid.org',
+            uids: [{
+              id: 'fake_pubcid',
+              atype: 1
+            }]
+          }]
+        };
+        expect(buildAndGetData([mockVideoBid({...params})]).user.eids).to.eql(params.fakeUserIdAsEids);
+      });
     });
   });
 

package/test/spec/unit/pbjs_api_spec.js

@@ -75,6 +75,10 @@ var Slot = function Slot(elementId, pathId) {
     clearTargeting: function clearTargeting() {
       this.targeting = {};
       return this;
+    },
+
+    updateTargetingFromMap: function updateTargetingFromMap(targetingMap) {
+      Object.keys(targetingMap).forEach(key => this.setTargeting(key, targetingMap[key]))
     }
   };
   slot.spySetTargeting = sinon.spy(slot, 'setTargeting');

package/test/spec/userSync_spec.js

@@ -401,6 +401,33 @@ describe('user sync', function () {
     expect(insertUserSyncIframeStub.getCall(0).args[0]).to.equal('http://example.com/iframe');
   });
 
+  it('should not fire image pixel for a bidder if iframe pixel is fired for same bidder', function() {
+    const userSync = newUserSync({
+      config: config.getConfig('userSync'),
+      browserSupportsCookies: true
+    });
+
+    config.setConfig({
+      userSync: {
+        filterSettings: {
+          iframe: {
+            bidders: ['bidderXYZ'],
+            filter: 'include'
+          }
+        }
+      }
+    });
+    // we are registering iframe and image sync for bidderXYZ and we expect image sync not to execute.
+    userSync.registerSync('image', 'testBidder', 'http://testBidder.example.com/image');
+    userSync.registerSync('iframe', 'bidderXYZ', 'http://bidderXYZ.example.com/iframe');
+    userSync.registerSync('image', 'bidderXYZ', 'http://bidderXYZ.example.com/image');
+    userSync.syncUsers();
+    expect(triggerPixelStub.getCall(0)).to.not.be.null;
+    expect(triggerPixelStub.getCall(0).args[0]).to.exist.and.to.equal('http://testBidder.example.com/image');
+    expect(triggerPixelStub.callCount).to.equal(1); // should not be 2 for 2 registered image syncs
+    expect(insertUserSyncIframeStub.getCall(0).args[0]).to.equal('http://bidderXYZ.example.com/iframe');
+  });
+
   it('should override default image syncs if setConfig used image filter', function () {
     const userSync = newUserSync({
       config: config.getConfig('userSync'),
@@ -448,8 +475,9 @@ describe('user sync', function () {
     userSync.registerSync('iframe', 'testBidder', 'http://example.com/iframe');
     userSync.registerSync('iframe', 'bidderXYZ', 'http://example.com/iframe-blocked');
     userSync.syncUsers();
-    expect(triggerPixelStub.getCall(0)).to.not.be.null;
-    expect(triggerPixelStub.getCall(0).args[0]).to.exist.and.to.equal('http://example.com');
+    // expect(triggerPixelStub.getCall(0)).to.not.be.null;
+    expect(triggerPixelStub.getCall(0)).to.be.null;// image sync will not execute as iframe sync has executed for same bidder
+    // expect(triggerPixelStub.getCall(0).args[0]).to.exist.and.to.equal('http://example.com');
     expect(triggerPixelStub.getCall(1)).to.be.null;
     expect(insertUserSyncIframeStub.getCall(0).args[0]).to.equal('http://example.com/iframe');
     expect(insertUserSyncIframeStub.getCall(1)).to.be.null;

package/modules/turktelekomBidAdapter.md

@@ -1,49 +0,0 @@
-# Overview
-
-Module Name: Türk Telekom Bidder Adapter
-Module Type: Bidder Adapter
-Maintainer: turktelssp@gmail.com
-
-# Description
-
-Module that connects to Türk Telekom demand source to fetch bids.
-Türk Telekom Bid Adapter supports Banner and Video (instream and outstream).
-
-# Test Parameters
-```
-    var adUnits = [
-           {
-               code: 'test-div',
-               mediaTypes: {
-                   banner: {
-                       sizes: [[300, 250], [300,600]]
-                   }
-               },
-               bids: [
-                   {
-                       bidder: "turktelekom",
-                       params: {
-                           uid: 17,
-                           priceType: 'gross' // by default is 'net'
-                       }
-                   }
-               ]
-           },{
-               code: 'test-div',
-               mediaTypes: {
-                   video: {
-                       playerSize: [[640, 360]],
-                       context: 'instream'
-                   }
-               },
-               bids: [
-                   {
-                       bidder: "turktelekom",
-                       params: {
-                           uid: 19
-                       }
-                   }
-               ]
-           }
-       ];
-```