prebid.js 5.14.0 → 5.18.0

package/test/spec/modules/medianetAnalyticsAdapter_spec.js

@@ -11,10 +11,12 @@ const {
 const MOCK = {
   Ad_Units: [{'code': 'div-gpt-ad-1460505748561-0', 'mediaTypes': {'banner': {'sizes': [[300, 250]]}}, 'bids': [], 'ext': {'prop1': 'value1'}}],
   MULTI_FORMAT_TWIN_AD_UNITS: [{'code': 'div-gpt-ad-1460505748561-0', 'mediaTypes': {'banner': {'sizes': [[300, 250]]}, 'native': {'image': {'required': true, 'sizes': [150, 50]}}}, 'bids': [], 'ext': {'prop1': 'value1'}}, {'code': 'div-gpt-ad-1460505748561-0', 'mediaTypes': {'video': {'playerSize': [640, 480], 'context': 'instream'}}, 'bids': [], 'ext': {'prop1': 'value1'}}],
+  TWIN_AD_UNITS: [{'code': 'div-gpt-ad-1460505748561-0', 'mediaTypes': {'banner': {'sizes': [[300, 100]]}}, 'ask': '300x100', 'bids': [{'bidder': 'bidder1', 'params': {'siteId': '451465'}}]}, {'code': 'div-gpt-ad-1460505748561-0', 'mediaTypes': {'banner': {'sizes': [[300, 250], [300, 100]]}}, 'bids': [{'bidder': 'medianet', 'params': {'cid': 'TEST_CID', 'crid': '451466393'}}]}, {'code': 'div-gpt-ad-1460505748561-0', 'mediaTypes': {'banner': {'sizes': [[300, 250]]}}, 'bids': [{'bidder': 'bidder1', 'params': {'siteId': '451466'}}]}],
   AUCTION_INIT: {'auctionId': '8e0d5245-deb3-406c-96ca-9b609e077ff7', 'timestamp': 1584563605739, 'timeout': 6000},
   AUCTION_INIT_WITH_FLOOR: {'auctionId': '8e0d5245-deb3-406c-96ca-9b609e077ff7', 'timestamp': 1584563605739, 'timeout': 6000, 'bidderRequests': [{'bids': [{ 'floorData': {'enforcements': {'enforceJS': true}} }]}]},
   BID_REQUESTED: {'bidderCode': 'medianet', 'auctionId': '8e0d5245-deb3-406c-96ca-9b609e077ff7', 'bids': [{'bidder': 'medianet', 'params': {'cid': 'TEST_CID', 'crid': '451466393'}, 'mediaTypes': {'banner': {'sizes': [[300, 250]], 'ext': ['asdads']}}, 'adUnitCode': 'div-gpt-ad-1460505748561-0', 'sizes': [[300, 250]], 'bidId': '28248b0e6aece2', 'auctionId': '8e0d5245-deb3-406c-96ca-9b609e077ff7', 'src': 'client'}], 'auctionStart': 1584563605739, 'timeout': 6000, 'uspConsent': '1YY', 'start': 1584563605743},
   MULTI_FORMAT_BID_REQUESTED: {'bidderCode': 'medianet', 'auctionId': '8e0d5245-deb3-406c-96ca-9b609e077ff7', 'bids': [{'bidder': 'medianet', 'params': {'cid': 'TEST_CID', 'crid': '451466393'}, 'mediaTypes': {'banner': {'sizes': [[300, 250]]}, 'video': {'playerSize': [640, 480], 'context': 'instream'}, 'native': {'image': {'required': true, 'sizes': [150, 50]}, 'title': {'required': true, 'len': 80}}}, 'adUnitCode': 'div-gpt-ad-1460505748561-0', 'sizes': [[300, 250]], 'bidId': '28248b0e6aece2', 'auctionId': '8e0d5245-deb3-406c-96ca-9b609e077ff7', 'src': 'client'}], 'auctionStart': 1584563605739, 'timeout': 6000, 'uspConsent': '1YY', 'start': 1584563605743},
+  TWIN_AD_UNITS_BID_REQUESTED: [{'bidderCode': 'bidder1', 'auctionId': '8e0d5245-deb3-406c-96ca-9b609e077ff7', 'bidderRequestId': '16f0746ff657b5', 'bids': [{'bidder': 'bidder1', 'params': {'siteId': '451465'}, 'mediaTypes': {'banner': {'sizes': [[300, 100]]}}, 'adUnitCode': 'div-gpt-ad-1460505748561-0', 'transactionId': '9615b5d1-7a4f-4c65-9464-4178b91da9e3', 'sizes': [[300, 100]], 'bidId': '2984d18e18bdfe', 'bidderRequestId': '16f0746ff657b5', 'auctionId': '8e0d5245-deb3-406c-96ca-9b609e077ff7', 'src': 'client', 'bidRequestsCount': 3, 'bidderRequestsCount': 2, 'bidderWinsCount': 0}, {'bidder': 'bidder1', 'params': {'siteId': '451466'}, 'mediaTypes': {'banner': {'sizes': [[300, 250]]}}, 'adUnitCode': 'div-gpt-ad-1460505748561-0', 'transactionId': '8bd7c9f2-0fe6-4ac5-8f2a-7f4a88af1b71', 'sizes': [[300, 250]], 'bidId': '3dced609066035', 'bidderRequestId': '16f0746ff657b5', 'auctionId': '8e0d5245-deb3-406c-96ca-9b609e077ff7', 'src': 'client', 'bidRequestsCount': 3, 'bidderRequestsCount': 2, 'bidderWinsCount': 0}], 'auctionStart': 1584563605739, 'timeout': 3000, 'start': 1584563605743}, {'bidderCode': 'medianet', 'auctionId': '8e0d5245-deb3-406c-96ca-9b609e077ff7', 'bidderRequestId': '4b45d1de1fa8fe', 'bids': [{'bidder': 'medianet', 'params': {'cid': 'TEST_CID', 'crid': '451466393'}, 'mediaTypes': {'banner': {'sizes': [[300, 250], [300, 100]]}}, 'adUnitCode': 'div-gpt-ad-1460505748561-0', 'transactionId': '215c038e-3b6a-465b-8937-d32e2ad8de45', 'sizes': [[300, 250], [300, 100]], 'bidId': '58d34adcb09c99', 'bidderRequestId': '4b45d1de1fa8fe', 'auctionId': '8e0d5245-deb3-406c-96ca-9b609e077ff7', 'src': 'client', 'bidRequestsCount': 3, 'bidderRequestsCount': 1, 'bidderWinsCount': 0}], 'auctionStart': 1584563605739, 'timeout': 3000, 'start': 1584563605743}],
   BID_RESPONSE: {'bidderCode': 'medianet', 'width': 300, 'height': 250, 'adId': '3e6e4bce5c8fb3', 'requestId': '28248b0e6aece2', 'mediaType': 'banner', 'source': 'client', 'ext': {'pvid': 123, 'crid': '321'}, 'no_bid': false, 'cpm': 2.299, 'ad': 'AD_CODE', 'ttl': 180, 'creativeId': 'Test1', 'netRevenue': true, 'currency': 'USD', 'dfp_id': 'div-gpt-ad-1460505748561-0', 'originalCpm': 1.1495, 'originalCurrency': 'USD', 'floorData': {'floorValue': 1.10, 'floorRule': 'banner'}, 'auctionId': '8e0d5245-deb3-406c-96ca-9b609e077ff7', 'responseTimestamp': 1584563606009, 'requestTimestamp': 1584563605743, 'bidder': 'medianet', 'adUnitCode': 'div-gpt-ad-1460505748561-0', 'timeToRespond': 266, 'pbLg': '2.00', 'pbMg': '2.20', 'pbHg': '2.29', 'pbAg': '2.25', 'pbDg': '2.29', 'pbCg': '2.00', 'size': '300x250', 'adserverTargeting': {'hb_bidder': 'medianet', 'hb_adid': '3e6e4bce5c8fb3', 'hb_pb': '2.00', 'hb_size': '300x250', 'hb_source': 'client', 'hb_format': 'banner', 'prebid_test': 1}, 'status': 'rendered', 'params': [{'cid': 'test123', 'crid': '451466393'}]},
   AUCTION_END: {'auctionId': '8e0d5245-deb3-406c-96ca-9b609e077ff7', 'auctionEnd': 1584563605739},
   SET_TARGETING: {'div-gpt-ad-1460505748561-0': {'prebid_test': '1', 'hb_format': 'banner', 'hb_source': 'client', 'hb_size': '300x250', 'hb_pb': '2.00', 'hb_adid': '3e6e4bce5c8fb3', 'hb_bidder': 'medianet', 'hb_format_medianet': 'banner', 'hb_source_medianet': 'client', 'hb_size_medianet': '300x250', 'hb_pb_medianet': '2.00', 'hb_adid_medianet': '3e6e4bce5c8fb3', 'hb_bidder_medianet': 'medianet'}},
@@ -25,7 +27,7 @@ const MOCK = {
 }
 
 function performAuctionWithFloorConfig() {
-  events.emit(AUCTION_INIT, {...MOCK.AUCTION_INIT_WITH_FLOOR, adUnits: MOCK.Ad_Units});
+  events.emit(AUCTION_INIT, Object.assign({}, MOCK.AUCTION_INIT_WITH_FLOOR, {adUnits: MOCK.Ad_Units}));
   events.emit(BID_REQUESTED, MOCK.BID_REQUESTED);
   events.emit(BID_RESPONSE, MOCK.BID_RESPONSE);
   events.emit(AUCTION_END, MOCK.AUCTION_END);
@@ -34,7 +36,7 @@ function performAuctionWithFloorConfig() {
 }
 
 function performStandardAuctionWithWinner() {
-  events.emit(AUCTION_INIT, {...MOCK.AUCTION_INIT, adUnits: MOCK.Ad_Units});
+  events.emit(AUCTION_INIT, Object.assign({}, MOCK.AUCTION_INIT, {adUnits: MOCK.Ad_Units}));
   events.emit(BID_REQUESTED, MOCK.BID_REQUESTED);
   events.emit(BID_RESPONSE, MOCK.BID_RESPONSE);
   events.emit(AUCTION_END, MOCK.AUCTION_END);
@@ -43,15 +45,23 @@ function performStandardAuctionWithWinner() {
 }
 
 function performMultiFormatAuctionWithNoBid() {
-  events.emit(AUCTION_INIT, {...MOCK.AUCTION_INIT, adUnits: MOCK.MULTI_FORMAT_TWIN_AD_UNITS});
+  events.emit(AUCTION_INIT, Object.assign({}, MOCK.AUCTION_INIT, {adUnits: MOCK.MULTI_FORMAT_TWIN_AD_UNITS}));
   events.emit(BID_REQUESTED, MOCK.MULTI_FORMAT_BID_REQUESTED);
   events.emit(NO_BID, MOCK.NO_BID);
   events.emit(AUCTION_END, MOCK.AUCTION_END);
   events.emit(SET_TARGETING, MOCK.NO_BID_SET_TARGETING);
 }
 
+function performTwinAdUnitAuctionWithNoBid() {
+  events.emit(AUCTION_INIT, Object.assign({}, MOCK.AUCTION_INIT, {adUnits: MOCK.TWIN_AD_UNITS}));
+  MOCK.TWIN_AD_UNITS_BID_REQUESTED.forEach(bidRequested => events.emit(BID_REQUESTED, bidRequested));
+  MOCK.TWIN_AD_UNITS_BID_REQUESTED.forEach(bidRequested => bidRequested.bids.forEach(noBid => events.emit(NO_BID, noBid)));
+  events.emit(AUCTION_END, MOCK.AUCTION_END);
+  events.emit(SET_TARGETING, MOCK.NO_BID_SET_TARGETING);
+}
+
 function performStandardAuctionWithNoBid() {
-  events.emit(AUCTION_INIT, {...MOCK.AUCTION_INIT, adUnits: MOCK.Ad_Units});
+  events.emit(AUCTION_INIT, Object.assign({}, MOCK.AUCTION_INIT, {adUnits: MOCK.Ad_Units}));
   events.emit(BID_REQUESTED, MOCK.BID_REQUESTED);
   events.emit(NO_BID, MOCK.NO_BID);
   events.emit(AUCTION_END, MOCK.AUCTION_END);
@@ -59,17 +69,20 @@ function performStandardAuctionWithNoBid() {
 }
 
 function performStandardAuctionWithTimeout() {
-  events.emit(AUCTION_INIT, {...MOCK.AUCTION_INIT, adUnits: MOCK.Ad_Units});
+  events.emit(AUCTION_INIT, Object.assign({}, MOCK.AUCTION_INIT, {adUnits: MOCK.Ad_Units}));
   events.emit(BID_REQUESTED, MOCK.BID_REQUESTED);
   events.emit(BID_TIMEOUT, MOCK.BID_TIMEOUT);
   events.emit(AUCTION_END, MOCK.AUCTION_END);
   events.emit(SET_TARGETING, MOCK.NO_BID_SET_TARGETING);
 }
 
-function getQueryData(url) {
+function getQueryData(url, decode = false) {
   const queryArgs = url.split('?')[1].split('&');
   return queryArgs.reduce((data, arg) => {
-    const [key, val] = arg.split('=');
+    let [key, val] = arg.split('=');
+    if (decode) {
+      val = decodeURIComponent(val);
+    }
     if (data[key] !== undefined) {
       if (!Array.isArray(data[key])) {
         data[key] = [data[key]];
@@ -149,6 +162,25 @@ describe('Media.net Analytics Adapter', function() {
       expect(noBidLog.vplcmtt).to.equal('instream');
     });
 
+    it('twin ad units should have correct sizes', function() {
+      performTwinAdUnitAuctionWithNoBid();
+      const noBidLog = medianetAnalytics.getlogsQueue().map((log) => getQueryData(log, true))[0];
+      const banner = 'banner';
+      expect(noBidLog.pvnm).to.have.ordered.members(['-2', 'bidder1', 'bidder1', 'medianet']);
+      expect(noBidLog.mtype).to.have.ordered.members([banner, banner, banner, banner]);
+      expect(noBidLog.status).to.have.ordered.members(['1', '2', '2', '2']);
+      expect(noBidLog.size).to.have.ordered.members(['', '', '', '']);
+      expect(noBidLog.szs).to.have.ordered.members(['300x100|300x250', '300x100', '300x250', '300x250|300x100']);
+    });
+
+    it('AP log should fire only once', function() {
+      performStandardAuctionWithNoBid();
+      events.emit(SET_TARGETING, MOCK.NO_BID_SET_TARGETING);
+      const logs = medianetAnalytics.getlogsQueue().map((log) => getQueryData(log, true));
+      expect(logs.length).to.equal(1);
+      expect(logs[0].lgtp).to.equal('APPR');
+    });
+
     it('should have winner log in standard auction', function() {
       medianetAnalytics.clearlogsQueue();
       performStandardAuctionWithWinner();

package/test/spec/modules/medianetBidAdapter_spec.js

@@ -1,4 +1,4 @@
-import {expect} from 'chai';
+import {expect, assert} from 'chai';
 import {spec} from 'modules/medianetBidAdapter.js';
 import { makeSlot } from '../integration/faker/googletag.js';
 import { config } from 'src/config.js';
@@ -99,6 +99,56 @@ let VALID_BID_REQUEST = [{
     'auctionId': 'aafabfd0-28c0-4ac0-aa09-99689e88b81d',
     'bidRequestsCount': 1
   }],
+  VALID_BID_REQUEST_WITH_ORTB2 = [{
+    'bidder': 'medianet',
+    'params': {
+      'crid': 'crid',
+      'cid': 'customer_id',
+      'site': {
+        'page': 'http://media.net/prebidtest',
+        'domain': 'media.net',
+        'ref': 'http://media.net/prebidtest',
+        'isTop': true
+      }
+    },
+    'adUnitCode': 'div-gpt-ad-1460505748561-0',
+    'transactionId': '277b631f-92f5-4844-8b19-ea13c095d3f1',
+    'mediaTypes': {
+      'banner': {
+        'sizes': [[300, 250]],
+      }
+    },
+    'bidId': '28f8f8130a583e',
+    'bidderRequestId': '1e9b1f07797c1c',
+    'auctionId': 'aafabfd0-28c0-4ac0-aa09-99689e88b81d',
+    'ortb2Imp': { 'ext': { 'data': { 'pbadslot': '/12345/my-gpt-tag-0' } } },
+    'bidRequestsCount': 1
+  }, {
+    'bidder': 'medianet',
+    'params': {
+      'crid': 'crid',
+      'cid': 'customer_id',
+      'site': {
+        'page': 'http://media.net/prebidtest',
+        'domain': 'media.net',
+        'ref': 'http://media.net/prebidtest',
+        'isTop': true
+      }
+    },
+    'adUnitCode': 'div-gpt-ad-1460505748561-123',
+    'transactionId': 'c52a5c62-3c2b-4b90-9ff8-ec1487754822',
+    'mediaTypes': {
+      'banner': {
+        'sizes': [[300, 251]],
+      }
+    },
+    'sizes': [[300, 251]],
+    'bidId': '3f97ca71b1e5c2',
+    'bidderRequestId': '1e9b1f07797c1c',
+    'auctionId': 'aafabfd0-28c0-4ac0-aa09-99689e88b81d',
+    'ortb2Imp': { 'ext': { 'data': { 'pbadslot': '/12345/my-gpt-tag-0' } } },
+    'bidRequestsCount': 1
+  }],
   VALID_BID_REQUEST_WITH_USERID = [{
     'bidder': 'medianet',
     'params': {
@@ -1247,6 +1297,17 @@ describe('Media.net bid adapter', function () {
       expect(JSON.parse(bidreq.data)).to.deep.equal(VALID_PAYLOAD_WITH_CRID);
     });
 
+    it('should have valid ortb2Imp param present in bid request', function() {
+      let bidreq = spec.buildRequests(VALID_BID_REQUEST_WITH_ORTB2, VALID_AUCTIONDATA);
+      let actual = JSON.parse(bidreq.data).imp[0].ortb2Imp;
+      const expected = VALID_BID_REQUEST_WITH_ORTB2[0].ortb2Imp
+      assert.equal(JSON.stringify(actual), JSON.stringify(expected))
+
+      bidreq = spec.buildRequests(VALID_BID_REQUEST, VALID_AUCTIONDATA);
+      actual = JSON.parse(bidreq.data).imp[0].ortb2Imp;
+      assert.equal(actual, undefined)
+    });
+
     it('should have userid in bid request', function () {
       let bidReq = spec.buildRequests(VALID_BID_REQUEST_WITH_USERID, VALID_AUCTIONDATA);
       expect(JSON.parse(bidReq.data)).to.deep.equal(VALID_PAYLOAD_WITH_USERID);

package/test/spec/modules/mytargetBidAdapter_spec.js

@@ -0,0 +1,199 @@
+import { expect } from 'chai';
+import { spec } from 'modules/mytargetBidAdapter';
+
+describe('MyTarget Adapter', function() {
+  describe('isBidRequestValid', function () {
+    it('should return true when required params found', function () {
+      let validBid = {
+        bidder: 'mytarget',
+        params: {
+          placementId: '1'
+        }
+      };
+
+      expect(spec.isBidRequestValid(validBid)).to.equal(true);
+    });
+
+    it('should return false for when required params are not passed', function () {
+      let invalidBid = {
+        bidder: 'mytarget',
+        params: {}
+      };
+
+      expect(spec.isBidRequestValid(invalidBid)).to.equal(false);
+    });
+  });
+
+  describe('buildRequests', function () {
+    let bidRequests = [
+      {
+        bidId: 'bid1',
+        bidder: 'mytarget',
+        params: {
+          placementId: '1'
+        }
+      },
+      {
+        bidId: 'bid2',
+        bidder: 'mytarget',
+        params: {
+          placementId: '2',
+          position: 1,
+          response: 1,
+          bidfloor: 10000
+        }
+      }
+    ];
+    let bidderRequest = {
+      refererInfo: {
+        referer: 'https://example.com?param=value'
+      }
+    };
+
+    let bidRequest = spec.buildRequests(bidRequests, bidderRequest);
+
+    it('should build single POST request for multiple bids', function() {
+      expect(bidRequest.method).to.equal('POST');
+      expect(bidRequest.url).to.equal('//ad.mail.ru/hbid_prebid/');
+      expect(bidRequest.data).to.be.an('object');
+      expect(bidRequest.data.places).to.be.an('array');
+      expect(bidRequest.data.places).to.have.lengthOf(2);
+    });
+
+    it('should pass bid parameters', function() {
+      let place1 = bidRequest.data.places[0];
+      let place2 = bidRequest.data.places[1];
+
+      expect(place1.placementId).to.equal('1');
+      expect(place2.placementId).to.equal('2');
+      expect(place1.id).to.equal('bid1');
+      expect(place2.id).to.equal('bid2');
+    });
+
+    it('should pass default position and response type', function() {
+      let place = bidRequest.data.places[0];
+
+      expect(place.position).to.equal(0);
+      expect(place.response).to.equal(0);
+    });
+
+    it('should pass provided position and response type', function() {
+      let place = bidRequest.data.places[1];
+
+      expect(place.position).to.equal(1);
+      expect(place.response).to.equal(1);
+    });
+
+    it('should not pass default bidfloor', function() {
+      let place = bidRequest.data.places[0];
+
+      expect(place.bidfloor).not.to.exist;
+    });
+
+    it('should not pass provided bidfloor', function() {
+      let place = bidRequest.data.places[1];
+
+      expect(place.bidfloor).to.exist;
+      expect(place.bidfloor).to.equal(10000);
+    });
+
+    it('should pass site parameters', function() {
+      let site = bidRequest.data.site;
+
+      expect(site).to.be.an('object');
+      expect(site.sitename).to.equal('example.com');
+      expect(site.page).to.equal('https://example.com?param=value');
+    });
+
+    it('should pass settings', function() {
+      let settings = bidRequest.data.settings;
+
+      expect(settings).to.be.an('object');
+      expect(settings.currency).to.equal('RUB');
+      expect(settings.windowSize).to.be.an('object');
+      expect(settings.windowSize.width).to.equal(window.screen.width);
+      expect(settings.windowSize.height).to.equal(window.screen.height);
+    });
+  });
+
+  describe('interpretResponse', function () {
+    let serverResponse = {
+      body: {
+        'bidder_status':
+          [
+            {
+              'bidder': 'mail.ru',
+              'response_time_ms': 100,
+              'num_bids': 2
+            }
+          ],
+        'bids':
+          [
+            {
+              'displayUrl': 'https://ad.mail.ru/hbid_imp/12345',
+              'size':
+                {
+                  'height': '400',
+                  'width': '240'
+                },
+              'id': '1',
+              'currency': 'RUB',
+              'price': 100,
+              'ttl': 360,
+              'creativeId': '123456'
+            },
+            {
+              'adm': '<p>Ad</p>',
+              'size':
+                {
+                  'height': '250',
+                  'width': '300'
+                },
+              'id': '2',
+              'price': 200
+            }
+          ]
+      }
+    };
+
+    let bids = spec.interpretResponse(serverResponse);
+
+    it('should return empty array for response with no bids', function() {
+      let emptyBids = spec.interpretResponse({ body: {} });
+
+      expect(emptyBids).to.have.lengthOf(0);
+    });
+
+    it('should parse all bids from response', function() {
+      expect(bids).to.have.lengthOf(2);
+    });
+
+    it('should parse bid with ad url', function() {
+      expect(bids[0].requestId).to.equal('1');
+      expect(bids[0].cpm).to.equal(100);
+      expect(bids[0].width).to.equal('240');
+      expect(bids[0].height).to.equal('400');
+      expect(bids[0].ttl).to.equal(360);
+      expect(bids[0].currency).to.equal('RUB');
+      expect(bids[0]).to.have.property('creativeId');
+      expect(bids[0].creativeId).to.equal('123456');
+      expect(bids[0].netRevenue).to.equal(true);
+      expect(bids[0].adUrl).to.equal('https://ad.mail.ru/hbid_imp/12345');
+      expect(bids[0]).to.not.have.property('ad');
+    });
+
+    it('should parse bid with ad markup', function() {
+      expect(bids[1].requestId).to.equal('2');
+      expect(bids[1].cpm).to.equal(200);
+      expect(bids[1].width).to.equal('300');
+      expect(bids[1].height).to.equal('250');
+      expect(bids[1].ttl).to.equal(180);
+      expect(bids[1].currency).to.equal('RUB');
+      expect(bids[1]).to.have.property('creativeId');
+      expect(bids[1].creativeId).not.to.equal('123456');
+      expect(bids[1].netRevenue).to.equal(true);
+      expect(bids[1].ad).to.equal('<p>Ad</p>');
+      expect(bids[1]).to.not.have.property('adUrl');
+    });
+  });
+});

package/test/spec/modules/nativoBidAdapter_spec.js

@@ -26,11 +26,11 @@ describe('nativoBidAdapterTests', function () {
       expect(spec.isBidRequestValid(bid)).to.equal(true)
     })
 
-    it('should return false when required params are not passed', function () {
+    it('should return true when params are not passed', function () {
       let bid2 = Object.assign({}, bid)
       delete bid2.params
       bid2.params = {}
-      expect(spec.isBidRequestValid(bid2)).to.equal(false)
+      expect(spec.isBidRequestValid(bid2)).to.equal(true)
     })
   })
 
@@ -129,7 +129,12 @@ describe('interpretResponse', function () {
     }
 
     // mock
-    spec.getRequestId = () => 123456
+    spec.getAdUnitData = () => {
+      return {
+        bidId: 123456,
+        sizes: [300, 250],
+      }
+    }
 
     let result = spec.interpretResponse({ body: response }, { bidderRequest })
     expect(Object.keys(result[0])).to.have.deep.members(
@@ -232,3 +237,45 @@ describe('getUserSyncs', function () {
     )
   })
 })
+
+describe('getAdUnitData', () => {
+  afterEach(() => {
+    if (window.bidRequestMap) delete window.bidRequestMap
+  })
+
+  it('Matches placementId value', () => {
+    const adUnitData = {
+      bidId: 123456,
+      sizes: [300, 250],
+    }
+
+    window.bidRequestMap = {
+      9876543: {
+        12345: adUnitData,
+      },
+    }
+
+    const data = spec.getAdUnitData(9876543, { impid: 12345 })
+    expect(Object.keys(data)).to.have.deep.members(
+      Object.keys(adUnitData)
+    )
+  })
+
+  it('Falls back to ad unit code value', () => {
+    const adUnitData = {
+      bidId: 123456,
+      sizes: [300, 250],
+    }
+
+    window.bidRequestMap = {
+      9876543: {
+        '#test-code': adUnitData,
+      },
+    }
+
+    const data = spec.getAdUnitData(9876543, { impid: 12345, ext: { ad_unit_code: '#test-code' } })
+    expect(Object.keys(data)).to.have.deep.members(
+      Object.keys(adUnitData)
+    )
+  })
+})