prebid.js 10.2.0 → 10.4.0

package/test/spec/modules/yandexBidAdapter_spec.js

@@ -495,6 +495,18 @@ describe('Yandex adapter', function () {
           },
         });
       });
+
+      it('should include eventtrackers in the native request', () => {
+        const nativeParams = buildRequestAndGetNativeParams({
+          mediaTypes: {
+            native: {
+              title: { required: true },
+            },
+          },
+        });
+
+        expect(nativeParams.eventtrackers).to.deep.equal([{ event: 1, methods: [1] }]);
+      });
     });
   });
 
@@ -510,6 +522,7 @@ describe('Yandex adapter', function () {
               price: 0.3,
               crid: 321,
               adm: '<!-- HTML/JS -->',
+              mtype: 1,
               w: 300,
               h: 250,
               adomain: [
@@ -517,6 +530,7 @@ describe('Yandex adapter', function () {
               ],
               adid: 'yabs.123=',
               nurl: 'https://example.com/nurl/?price=${AUCTION_PRICE}&cur=${AUCTION_CURRENCY}',
+              lurl: 'https://example.com/nurl/?reason=${AUCTION_LOSS}',
             }
           ]
         }],
@@ -543,6 +557,7 @@ describe('Yandex adapter', function () {
       expect(rtbBid.netRevenue).to.equal(true);
       expect(rtbBid.ttl).to.equal(180);
       expect(rtbBid.nurl).to.equal('https://example.com/nurl/?price=0.3&cur=USD');
+      expect(rtbBid.lurl).to.exist;
 
       expect(rtbBid.meta.advertiserDomains).to.deep.equal(['example.com']);
     });
@@ -563,6 +578,7 @@ describe('Yandex adapter', function () {
               impid: 'videoBid1',
               price: 1.50,
               adm: '<VAST version="3.0"></VAST>',
+              mtype: 2,
               w: 640,
               h: 480,
               adomain: ['advertiser.com'],
@@ -668,6 +684,7 @@ describe('Yandex adapter', function () {
                   ],
                   adid: 'yabs.123=',
                   adm: JSON.stringify(nativeAdmResponce),
+                  mtype: 4,
                 },
               ],
             }],
@@ -699,6 +716,117 @@ describe('Yandex adapter', function () {
           },
         });
       });
+
+      it('should add eventtrackers urls to impressionTrackers', function () {
+        bannerRequest.bidRequest = {
+          mediaType: NATIVE,
+          bidId: 'bidid-1',
+        };
+
+        const nativeAdmResponse = getNativeAdmResponse();
+        nativeAdmResponse.native.eventtrackers = [
+          {
+            event: 1, // TRACKER_EVENTS.impression
+            method: 1, // TRACKER_METHODS.img
+            url: 'https://example.com/imp-event-tracker',
+          },
+          {
+            event: 2,
+            method: 2,
+            url: 'https://example.com/skip-me',
+          },
+        ];
+
+        const bannerResponse = {
+          body: {
+            seatbid: [
+              {
+                bid: [
+                  {
+                    impid: 1,
+                    price: 0.3,
+                    adm: JSON.stringify(nativeAdmResponse),
+                    mtype: 4,
+                  },
+                ],
+              },
+            ],
+          },
+        };
+
+        const result = spec.interpretResponse(bannerResponse, bannerRequest);
+        const bid = result[0];
+
+        expect(bid.native.impressionTrackers).to.include(
+          'https://example.com/imptracker'
+        );
+        expect(bid.native.impressionTrackers).to.include(
+          'https://example.com/imp-event-tracker'
+        );
+        expect(bid.native.impressionTrackers).to.not.include('https://example.com/skip-me');
+      });
+
+      it('should handle missing imptrackers', function () {
+        bannerRequest.bidRequest = {
+          mediaType: NATIVE,
+          bidId: 'bidid-1',
+        };
+
+        const nativeAdmResponse = getNativeAdmResponse();
+        delete nativeAdmResponse.native.imptrackers;
+        nativeAdmResponse.native.eventtrackers = [{
+          event: 1,
+          method: 1,
+          url: 'https://example.com/fallback-tracker'
+        }];
+
+        const bannerResponse = {
+          body: {
+            seatbid: [{
+              bid: [{
+                impid: 1,
+                price: 0.3,
+                adm: JSON.stringify(nativeAdmResponse),
+                mtype: 4,
+              }]
+            }]
+          }
+        };
+
+        const result = spec.interpretResponse(bannerResponse, bannerRequest);
+        const bid = result[0];
+
+        expect(bid.native.impressionTrackers)
+          .to.deep.equal(['https://example.com/fallback-tracker']);
+      });
+
+      it('should handle missing eventtrackers', function () {
+        bannerRequest.bidRequest = {
+          mediaType: NATIVE,
+          bidId: 'bidid-1',
+        };
+
+        const nativeAdmResponse = getNativeAdmResponse();
+
+        const bannerResponse = {
+          body: {
+            seatbid: [{
+              bid: [{
+                impid: 1,
+                price: 0.3,
+                adm: JSON.stringify(nativeAdmResponse),
+                mtype: 4,
+              }]
+            }]
+          }
+        };
+
+        const result = spec.interpretResponse(bannerResponse, bannerRequest);
+        const bid = result[0];
+
+        expect(bid.native.impressionTrackers)
+          .to.deep.equal(['https://example.com/imptracker']);
+      });
     });
   });
 

package/test/spec/refererDetection_spec.js

@@ -13,7 +13,7 @@ describe('Referer detection', () => {
     describe('No iframes', () => {
       it('Should return the current window location and no canonical URL', () => {
         const testWindow = buildWindowTree(['https://example.com/some/page'], 'https://othersite.com/');
-          const result = detectReferer(testWindow)();
+        const result = detectReferer(testWindow)();
 
         sinon.assert.match(result, {
           topmostLocation: 'https://example.com/some/page',
@@ -31,7 +31,7 @@ describe('Referer detection', () => {
 
       it('Should return the current window location and a canonical URL', () => {
         const testWindow = buildWindowTree(['https://example.com/some/page'], 'https://othersite.com/', 'https://example.com/canonical/page');
-          const result = detectReferer(testWindow)();
+        const result = detectReferer(testWindow)();
 
         sinon.assert.match(result, {
           topmostLocation: 'https://example.com/some/page',
@@ -50,7 +50,7 @@ describe('Referer detection', () => {
       it('Should set page and canonical to pageUrl value set in config if present, even if canonical url is also present in head', () => {
         config.setConfig({'pageUrl': 'https://www.set-from-config.com/path'});
         const testWindow = buildWindowTree(['https://example.com/some/page'], 'https://othersite.com/', 'https://example.com/canonical/page');
-          const result = detectReferer(testWindow)();
+        const result = detectReferer(testWindow)();
 
         sinon.assert.match(result, {
           topmostLocation: 'https://example.com/some/page',
@@ -69,7 +69,7 @@ describe('Referer detection', () => {
       it('Should set page with query params if canonical url is present without query params but the current page does have them', () => {
         config.setConfig({'pageUrl': 'https://www.set-from-config.com/path'});
         const testWindow = buildWindowTree(['https://example.com/some/page?query1=123&query2=456'], 'https://othersite.com/', 'https://example.com/canonical/page');
-          const result = detectReferer(testWindow)();
+        const result = detectReferer(testWindow)();
 
         sinon.assert.match(result, {
           topmostLocation: 'https://example.com/some/page?query1=123&query2=456',
@@ -89,7 +89,7 @@ describe('Referer detection', () => {
     describe('Friendly iframes', () => {
       it('Should return the top window location and no canonical URL', () => {
         const testWindow = buildWindowTree(['https://example.com/some/page', 'https://example.com/other/page', 'https://example.com/third/page'], 'https://othersite.com/');
-          const result = detectReferer(testWindow)();
+        const result = detectReferer(testWindow)();
 
         sinon.assert.match(result, {
           topmostLocation: 'https://example.com/some/page',
@@ -111,7 +111,7 @@ describe('Referer detection', () => {
 
       it('Should return the top window location and a canonical URL', () => {
         const testWindow = buildWindowTree(['https://example.com/some/page', 'https://example.com/other/page', 'https://example.com/third/page'], 'https://othersite.com/', 'https://example.com/canonical/page');
-          const result = detectReferer(testWindow)();
+        const result = detectReferer(testWindow)();
 
         sinon.assert.match(result, {
           topmostLocation: 'https://example.com/some/page',
@@ -135,7 +135,7 @@ describe('Referer detection', () => {
         config.setConfig({'pageUrl': 'https://testurl.com'});
 
         const testWindow = buildWindowTree(['https://example.com/some/page', 'https://example.com/other/page', 'https://example.com/third/page'], 'https://othersite.com/', 'https://example.com/canonical/page');
-          const result = detectReferer(testWindow)();
+        const result = detectReferer(testWindow)();
 
         sinon.assert.match(result, {
           topmostLocation: 'https://example.com/some/page',
@@ -160,7 +160,7 @@ describe('Referer detection', () => {
   describe('Cross-origin scenarios', () => {
     it('Should return the top URL and no canonical URL with one cross-origin iframe', () => {
       const testWindow = buildWindowTree(['https://example.com/some/page', 'https://safe.frame/ad'], 'https://othersite.com/', 'https://canonical.example.com/');
-        const result = detectReferer(testWindow)();
+      const result = detectReferer(testWindow)();
 
       sinon.assert.match(result, {
         location: 'https://example.com/some/page',
@@ -181,7 +181,7 @@ describe('Referer detection', () => {
 
     it('Should return the top URL and no canonical URL with one cross-origin iframe and one friendly iframe', () => {
       const testWindow = buildWindowTree(['https://example.com/some/page', 'https://safe.frame/ad', 'https://safe.frame/ad'], 'https://othersite.com/', 'https://canonical.example.com/');
-        const result = detectReferer(testWindow)();
+      const result = detectReferer(testWindow)();
 
       sinon.assert.match(result, {
         topmostLocation: 'https://example.com/some/page',
@@ -203,7 +203,7 @@ describe('Referer detection', () => {
 
     it('Should return the second iframe location with three cross-origin windows and no ancestorOrigins', () => {
       const testWindow = buildWindowTree(['https://example.com/some/page', 'https://safe.frame/ad', 'https://otherfr.ame/ad'], 'https://othersite.com/', 'https://canonical.example.com/');
-        const result = detectReferer(testWindow)();
+      const result = detectReferer(testWindow)();
 
       sinon.assert.match(result, {
         topmostLocation: 'https://safe.frame/ad',
@@ -225,7 +225,7 @@ describe('Referer detection', () => {
 
     it('Should return the top window origin with three cross-origin windows with ancestorOrigins', () => {
       const testWindow = buildWindowTree(['https://example.com/some/page', 'https://safe.frame/ad', 'https://otherfr.ame/ad'], 'https://othersite.com/', 'https://canonical.example.com/', true);
-        const result = detectReferer(testWindow)();
+      const result = detectReferer(testWindow)();
 
       sinon.assert.match(result, {
         topmostLocation: 'https://example.com/',

package/test/spec/unit/core/storageManager_spec.js

@@ -16,7 +16,7 @@ import {MODULE_TYPE_BIDDER, MODULE_TYPE_PREBID} from '../../../../src/activities
 import {ACTIVITY_ACCESS_DEVICE} from '../../../../src/activities/activities.js';
 import {
   ACTIVITY_PARAM_COMPONENT_NAME,
-  ACTIVITY_PARAM_COMPONENT_TYPE, ACTIVITY_PARAM_STORAGE_KEY,
+  ACTIVITY_PARAM_COMPONENT_TYPE, ACTIVITY_PARAM_STORAGE_WRITE, ACTIVITY_PARAM_STORAGE_KEY,
   ACTIVITY_PARAM_STORAGE_TYPE
 } from '../../../../src/activities/params.js';
 import {activityParams} from '../../../../src/activities/activityParams.js';
@@ -99,6 +99,25 @@ describe('storage manager', function() {
       }));
     });
 
+    it('should pass write = false on reads', () => {
+      mkManager(MODULE_TYPE_PREBID, 'mockMod').getCookie('foo');
+      sinon.assert.calledWith(isAllowed, ACTIVITY_ACCESS_DEVICE, sinon.match({
+        [ACTIVITY_PARAM_STORAGE_WRITE]: false
+      }));
+    })
+
+    it('should pass write = true on writes', () => {
+      const mgr = mkManager(MODULE_TYPE_PREBID, 'mockMod');
+      mgr.setDataInLocalStorage('foo', 'bar')
+      try {
+        sinon.assert.calledWith(isAllowed, ACTIVITY_ACCESS_DEVICE, sinon.match({
+          [ACTIVITY_PARAM_STORAGE_WRITE]: true
+        }));
+      } finally {
+        mgr.removeDataFromLocalStorage('foo');
+      }
+    })
+
     it('should NOT pass storage key if advertiseKeys = false', () => {
       newStorageManager({
         moduleType: MODULE_TYPE_PREBID,

package/test/spec/unit/core/targeting_spec.js

@@ -1565,15 +1565,15 @@ describe('targeting tests', function () {
       ]
     });
 
-      it('can find slots by ad unit path', () => {
-        const paths = ['slot/1', 'slot/2']
-        expect(getGPTSlotsForAdUnits(paths, null, () => slots)).to.eql({[paths[0]]: [slots[0], slots[2]], [paths[1]]: [slots[1]]});
-      })
+    it('can find slots by ad unit path', () => {
+      const paths = ['slot/1', 'slot/2']
+      expect(getGPTSlotsForAdUnits(paths, null, () => slots)).to.eql({[paths[0]]: [slots[0], slots[2]], [paths[1]]: [slots[1]]});
+    })
 
-      it('can find slots by ad element ID', () => {
-        const elementIds = ['div-1', 'div-2']
-        expect(getGPTSlotsForAdUnits(elementIds, null, () => slots)).to.eql({[elementIds[0]]: [slots[0]], [elementIds[1]]: [slots[1]]});
-      })
+    it('can find slots by ad element ID', () => {
+      const elementIds = ['div-1', 'div-2']
+      expect(getGPTSlotsForAdUnits(elementIds, null, () => slots)).to.eql({[elementIds[0]]: [slots[0]], [elementIds[1]]: [slots[1]]});
+    })
 
     it('returns empty list on no match', () => {
       expect(getGPTSlotsForAdUnits(['missing', 'slot/2'], null, () => slots)).to.eql({

package/test/spec/utils_spec.js

@@ -10,16 +10,16 @@ var assert = require('assert');
 
 describe('Utils', function () {
   var obj_string = 's';
-    var obj_number = 1;
-    var obj_object = {};
-    var obj_array = [];
-    var obj_function = function () {};
+  var obj_number = 1;
+  var obj_object = {};
+  var obj_array = [];
+  var obj_function = function () {};
 
   var type_string = 'String';
-    var type_number = 'Number';
-    var type_object = 'Object';
-    var type_array = 'Array';
-    var type_function = 'Function';
+  var type_number = 'Number';
+  var type_object = 'Object';
+  var type_array = 'Array';
+  var type_function = 'Function';
 
   describe('canAccessWindowTop', function () {
     let sandbox;
@@ -505,15 +505,15 @@ describe('Utils', function () {
   });
 
   describe('contains', function () {
-      it('should return true if the input string contains in the input obj', function () {
+    it('should return true if the input string contains in the input obj', function () {
       var output = utils.contains('123', '1');
       assert.deepEqual(output, true);
-      });
+    });
 
-      it('should return false if the input string do not contain in the input obj', function () {
+    it('should return false if the input string do not contain in the input obj', function () {
       var output = utils.contains('234', '1');
       assert.deepEqual(output, false);
-      });
+    });
 
     it('should return false if the input string is empty', function () {
       var output = utils.contains();
@@ -522,37 +522,37 @@ describe('Utils', function () {
   });
 
   describe('_map', function () {
-      it('return empty array when input object is empty', function () {
+    it('return empty array when input object is empty', function () {
       var input = {};
       var callback = function () {};
 
       var output = utils._map(input, callback);
       assert.deepEqual(output, []);
-      });
+    });
 
-      it('return value array with vaild input object', function () {
+    it('return value array with vaild input object', function () {
       var input = { a: 'A', b: 'B' };
       var callback = function (v) { return v; };
 
       var output = utils._map(input, callback);
       assert.deepEqual(output, ['A', 'B']);
-      });
+    });
 
-      it('return value array with vaild input object_callback func changed 1', function () {
+    it('return value array with vaild input object_callback func changed 1', function () {
       var input = { a: 'A', b: 'B' };
       var callback = function (v, k) { return v + k; };
 
       var output = utils._map(input, callback);
       assert.deepEqual(output, ['Aa', 'Bb']);
-      });
+    });
 
-      it('return value array with vaild input object_callback func changed 2', function () {
+    it('return value array with vaild input object_callback func changed 2', function () {
       var input = { a: 'A', b: 'B' };
       var callback = function (v, k, o) { return o; };
 
       var output = utils._map(input, callback);
       assert.deepEqual(output, [input, input]);
-      });
+    });
   });
 
   describe('createInvisibleIframe', function () {
@@ -1219,11 +1219,11 @@ describe('Utils', function () {
   describe('setScriptAttributes', () => {
     it('correctly adds attributes from an object', () => {
       const script = document.createElement('script');
-        const attrs = {
-          'data-first_prop': '1',
-          'data-second_prop': 'b',
-          'id': 'newId'
-        };
+      const attrs = {
+        'data-first_prop': '1',
+        'data-second_prop': 'b',
+        'id': 'newId'
+      };
       script.id = 'oldId';
       utils.setScriptAttributes(script, attrs);
       expect(script.dataset['first_prop']).to.equal('1');