prebid.js 10.2.0 → 10.4.0

package/test/spec/modules/stvBidAdapter_spec.js

@@ -81,55 +81,55 @@ describe('stvAdapter', function() {
         'userIdAsEids': [
           {
             'source': 'id5-sync.com',
-        'uids': [{
+            'uids': [{
               'id': '1234',
               'ext': {
                 'linkType': 'abc'
               }
             }]
-      },
+          },
           {
             'source': 'netid.de',
-        'uids': [{
+            'uids': [{
               'id': '2345'
             }]
-      },
+          },
           {
             'source': 'uidapi.com',
-        'uids': [{
+            'uids': [{
               'id': '3456'
             }]
-      },
+          },
           {
             'source': 'pubcid.org',
-        'uids': [{
+            'uids': [{
               'id': '4567'
             }]
-      },
+          },
           {
             'source': 'liveramp.com',
-        'uids': [{
+            'uids': [{
               'id': '5678'
             }]
-      },
+          },
           {
             'source': 'criteo.com',
-        'uids': [{
+            'uids': [{
               'id': '6789'
             }]
-      },
+          },
           {
             'source': 'utiq.com',
-        'uids': [{
+            'uids': [{
               'id': '7890'
             }]
-      },
+          },
           {
             'source': 'euid.eu',
-        'uids': [{
+            'uids': [{
               'id': '8901'
             }]
-      }
+          }
         ]
       },
       {
@@ -147,55 +147,55 @@ describe('stvAdapter', function() {
         'userIdAsEids': [
           {
             'source': 'id5-sync.com',
-        'uids': [{
+            'uids': [{
               'id': '1234',
               'ext': {
                 'linkType': 'abc'
               }
             }]
-      },
+          },
           {
             'source': 'netid.de',
-        'uids': [{
+            'uids': [{
               'id': '2345'
             }]
-      },
+          },
           {
             'source': 'uidapi.com',
-        'uids': [{
+            'uids': [{
               'id': '3456'
             }]
-      },
+          },
           {
             'source': 'pubcid.org',
-        'uids': [{
+            'uids': [{
               'id': '4567'
             }]
-      },
+          },
           {
             'source': 'liveramp.com',
-        'uids': [{
+            'uids': [{
               'id': '5678'
             }]
-      },
+          },
           {
             'source': 'criteo.com',
-        'uids': [{
+            'uids': [{
               'id': '6789'
             }]
-      },
+          },
           {
             'source': 'utiq.com',
-        'uids': [{
+            'uids': [{
               'id': '7890'
             }]
-      },
+          },
           {
             'source': 'euid.eu',
-        'uids': [{
+            'uids': [{
               'id': '8901'
             }]
-      }
+          }
         ]
       }, {
         'bidder': 'stv',

package/test/spec/modules/tapnativeBidAdapter_spec.js

@@ -142,32 +142,32 @@ describe('tapnative adapter', function () {
   describe('validations', function () {
     it('isBidValid : placement_id is passed', function () {
       const bid = {
-          bidder: 'tapnative',
-          params: {
-            placement_id: 111520
-          }
-        };
-        const isValid = spec.isBidRequestValid(bid);
+        bidder: 'tapnative',
+        params: {
+          placement_id: 111520
+        }
+      };
+      const isValid = spec.isBidRequestValid(bid);
       expect(isValid).to.equals(true);
     });
     it('isBidValid : placement_id is not passed', function () {
       const bid = {
-          bidder: 'tapnative',
-          params: {
-            width: 300,
-            height: 250,
-            domain: '',
-            bid_floor: 0.5
-          }
-        };
-        const isValid = spec.isBidRequestValid(bid);
+        bidder: 'tapnative',
+        params: {
+          width: 300,
+          height: 250,
+          domain: '',
+          bid_floor: 0.5
+        }
+      };
+      const isValid = spec.isBidRequestValid(bid);
       expect(isValid).to.equals(false);
     });
   });
   describe('Validate Banner Request', function () {
     it('Immutable bid request validate', function () {
       const _Request = utils.deepClone(bannerRequest);
-        const bidRequest = spec.buildRequests(bannerRequest);
+      const bidRequest = spec.buildRequests(bannerRequest);
       expect(bannerRequest).to.deep.equal(_Request);
     });
     it('Validate bidder connection', function () {
@@ -234,7 +234,7 @@ describe('tapnative adapter', function () {
   describe('Validate Native Request', function () {
     it('Immutable bid request validate', function () {
       const _Request = utils.deepClone(nativeRequest);
-        const bidRequest = spec.buildRequests(nativeRequest);
+      const bidRequest = spec.buildRequests(nativeRequest);
       expect(nativeRequest).to.deep.equal(_Request);
     });
     it('Validate bidder connection', function () {

package/test/spec/modules/themoneytizerBidAdapter_spec.js

@@ -102,12 +102,6 @@ describe('The Moneytizer Bidder Adapter', function () {
     });
   });
 
-  describe('gvlid', function () {
-    it('should expose gvlid', function () {
-      expect(spec.gvlid).to.equal(1265)
-    });
-  });
-
   describe('isBidRequestValid', function () {
     it('should return true for a bid with all required fields', function () {
       const validBid = spec.isBidRequestValid(VALID_BID_BANNER);

package/test/spec/modules/ttdBidAdapter_spec.js

@@ -99,6 +99,24 @@ describe('ttdBidAdapter', function () {
         bid.params.bidfloor = 3.01;
         expect(spec.isBidRequestValid(bid)).to.equal(true);
       });
+
+      it('should return false if customBidderEndpoint is provided and does not start with https://', function () {
+        const bid = makeBid();
+        bid.params.customBidderEndpoint = 'customBidderEndpoint/bid/bidder/';
+        expect(spec.isBidRequestValid(bid)).to.equal(false);
+      });
+
+      it('should return false if customBidderEndpoint is provided and does not end with /bid/bidder/', function () {
+        const bid = makeBid();
+        bid.params.customBidderEndpoint = 'https://customBidderEndpoint/bid/bidder';
+        expect(spec.isBidRequestValid(bid)).to.equal(false);
+      });
+
+      it('should return true if customBidderEndpoint is provided that starts with https:// and ends with /bid/bidder/', function () {
+        const bid = makeBid();
+        bid.params.customBidderEndpoint = 'https://customBidderEndpoint/bid/bidder/';
+        expect(spec.isBidRequestValid(bid)).to.equal(true);
+      });
     });
 
     describe('banner', function () {
@@ -306,11 +324,18 @@ describe('ttdBidAdapter', function () {
       expect(url).to.equal('https://direct.adsrvr.org/bid/bidder/supplier');
     });
 
+    it('sends bid requests to the correct http2 endpoint', function () {
+      const bannerBidRequestsWithHttp2Endpoint = deepClone(baseBannerBidRequests);
+      bannerBidRequestsWithHttp2Endpoint[0].params.useHttp2 = true;
+      const url = testBuildRequests(bannerBidRequestsWithHttp2Endpoint, baseBidderRequest).url;
+      expect(url).to.equal('https://d2.adsrvr.org/bid/bidder/supplier');
+    });
+
     it('sends bid requests to the correct custom endpoint', function () {
       const bannerBidRequestsWithCustomEndpoint = deepClone(baseBannerBidRequests);
-      bannerBidRequestsWithCustomEndpoint[0].params.useHttp2 = true;
+      bannerBidRequestsWithCustomEndpoint[0].params.customBidderEndpoint = 'https://customBidderEndpoint/bid/bidder/';
       const url = testBuildRequests(bannerBidRequestsWithCustomEndpoint, baseBidderRequest).url;
-      expect(url).to.equal('https://d2.adsrvr.org/bid/bidder/supplier');
+      expect(url).to.equal('https://customBidderEndpoint/bid/bidder/supplier');
     });
 
     it('sends publisher id', function () {

package/test/spec/modules/uid2IdSystem_spec.js

@@ -253,9 +253,9 @@ describe(`UID2 module`, function () {
       config.setConfig(makePrebidConfig(legacyConfigParams));
       const bid2 = await runAuction();
 
-        const first = findUid2(bid);
-        const second = findUid2(bid2);
-        expect(first && second && first.uids[0].id).to.equal(second.uids[0].id);
+      const first = findUid2(bid);
+      const second = findUid2(bid2);
+      expect(first && second && first.uids[0].id).to.equal(second.uids[0].id);
     });
   });
 

package/test/spec/modules/userId_spec.js

@@ -37,8 +37,13 @@ import {ACTIVITY_PARAM_COMPONENT_NAME, ACTIVITY_PARAM_COMPONENT_TYPE} from '../.
 import {extractEids} from '../../../modules/prebidServerBidAdapter/bidderConfig.js';
 import {generateSubmoduleContainers, addIdData } from '../../../modules/userId/index.js';
 import { registerActivityControl } from '../../../src/activities/rules.js';
-
-import { discloseStorageUse, STORAGE_TYPE_COOKIES, STORAGE_TYPE_LOCALSTORAGE, getStorageManager } from '../../../src/storageManager.js';
+import {
+  discloseStorageUse,
+  STORAGE_TYPE_COOKIES,
+  STORAGE_TYPE_LOCALSTORAGE,
+  getStorageManager,
+  getCoreStorageManager
+} from '../../../src/storageManager.js';
 
 const assert = require('chai').assert;
 const expect = require('chai').expect;
@@ -2450,6 +2455,27 @@ describe('User ID', function () {
       it('pbjs.registerSignalSources should be defined', () => {
         expect(typeof (getGlobal()).registerSignalSources).to.equal('function');
       });
+
+      it('does not add duplicate secureSignalProviders', function () {
+        const clock = sinon.useFakeTimers();
+        mockGpt.reset();
+        window.googletag.secureSignalProviders = [];
+        init(config);
+        config.setConfig({
+          userSync: {
+            encryptedSignalSources: {
+              registerDelay: 0,
+              sources: [{source: ['pubcid.org'], encrypt: false}]
+            }
+          }
+        });
+        getGlobal().registerSignalSources();
+        clock.tick(0);
+        getGlobal().registerSignalSources();
+        clock.tick(0);
+        expect(window.googletag.secureSignalProviders.length).to.equal(1);
+        clock.restore();
+      });
     })
 
     describe('Call getEncryptedEidsForSource to get encrypted Eids for source', function() {
@@ -3139,6 +3165,7 @@ describe('User ID', function () {
   describe('user id modules - enforceStorageType', () => {
     let warnLogSpy;
     const UID_MODULE_NAME = 'userIdModule';
+    const cookieName = 'testCookie';
     const userSync = {
       userIds: [
         {
@@ -3163,15 +3190,22 @@ describe('User ID', function () {
 
     afterEach(() => {
       warnLogSpy.restore();
-      document.cookie = ''
+      getCoreStorageManager('test').setCookie(cookieName, '', EXPIRED_COOKIE_DATE)
     });
 
+    it('should not warn when reading', () => {
+      config.setConfig({userSync});
+      const storage = getStorageManager({moduleType: MODULE_TYPE_UID, moduleName: UID_MODULE_NAME});
+      storage.cookiesAreEnabled();
+      sinon.assert.notCalled(warnLogSpy);
+    })
+
     it('should warn and allow userId module to store data for enforceStorageType unset', () => {
       config.setConfig({userSync});
       const storage = getStorageManager({moduleType: MODULE_TYPE_UID, moduleName: UID_MODULE_NAME});
-      storage.setCookie('cookieName', 'value', 20000);
+      storage.setCookie(cookieName, 'value', 20000);
       sinon.assert.calledWith(warnLogSpy, `${UID_MODULE_NAME} attempts to store data in ${STORAGE_TYPE_COOKIES} while configuration allows ${STORAGE_TYPE_LOCALSTORAGE}.`);
-      expect(storage.getCookie('cookieName')).to.eql('value');
+      expect(storage.getCookie(cookieName)).to.eql('value');
     });
 
     it('should not allow userId module to store data for enforceStorageType set to true', () => {
@@ -3182,8 +3216,8 @@ describe('User ID', function () {
         }
       })
       const storage = getStorageManager({moduleType: MODULE_TYPE_UID, moduleName: UID_MODULE_NAME});
-      storage.setCookie('data', 'value', 20000);
-      expect(storage.getCookie('data')).to.not.exist;
+      storage.setCookie(cookieName, 'value', 20000);
+      expect(storage.getCookie(cookieName)).to.not.exist;
     });
   });
 });