prebid-universal-creative 1.17.2 → 1.18.0

package/test/spec/nativeTrackerManager_spec.js

@@ -27,11 +27,6 @@ describe('nativeTrackerManager', function () {
       pubUrl: 'http://example.com'
     };
 
-    let tagDataAlt = {
-      pubUrl: 'http://example.com',
-      adId: 'ad123',
-      assetsToReplace: ['image','hb_native_linkurl','body','title'],
-    };
 
     beforeEach(function () {
       mockWin = merge(mocks.createFakeWindow(tagData.pubUrl), renderingMocks.getWindowObject());
@@ -49,7 +44,7 @@ describe('nativeTrackerManager', function () {
             value: 'ad123'
           }
         },
-        addEventListener: (type, listener, capture) => {
+        addEventListener: () => {
         },
       }];
 
@@ -74,7 +69,7 @@ describe('nativeTrackerManager', function () {
             value: 'ad123'
           }
         },
-        addEventListener: ((type, listener, capture) => {
+        addEventListener: ((type, listener) => {
           listener({
           })
         })
@@ -97,7 +92,7 @@ describe('nativeTrackerManager', function () {
 
     it('should verify 2 warning messages (one for impression, one for click) was executed', function() {
       mockWin.document.getElementsByClassName = () => [{
-        addEventListener: ((type, listener, capture) => {
+        addEventListener: ((type, listener) => {
           listener({
           })
         })

package/test/spec/renderingManager_spec.js

@@ -24,7 +24,7 @@ function renderingMocks() {
           renderAd: sinon.spy()
         }
       },
-      postMessage: (message, domain) => {
+      postMessage: (message) => {
         this.messages[0](message);
       },
       top: null,
@@ -34,7 +34,7 @@ function renderingMocks() {
           expand: sinon.spy()
         }
       },
-      addEventListener: (type, listener, capture) => {
+      addEventListener: (type, listener) => {
         this.messages.push(listener);
       },
       innerWidth: 300,
@@ -56,39 +56,21 @@ function createMockIframe() {
 }
 
 describe('renderingManager', function() {
-  let xhr;
-  let requests;
-
-  before(function() {
-    xhr = sinon.useFakeXMLHttpRequest();
-    xhr.onCreate = (request) => requests.push(request);
-  });
-
-  beforeEach(function() {
-    requests = [];
-  });
-
-  after(function(){
-    xhr.restore();
-  });
-
   describe('cross domain creative', function() {
     const ORIGIN = 'http://example.com';
     let sandbox;
     let parseStub;
     let iframeStub;
-    let triggerPixelSpy;
     let mockWin;
     let ucTagData;
     let mockIframe;
-    let eventSource;
 
     beforeEach(function(){
       sandbox = sinon.createSandbox();
       mockIframe = createMockIframe();
       parseStub = sandbox.stub(utils, 'parseUrl');
       iframeStub = sandbox.stub(domHelper, 'getEmptyIframe').returns(mockIframe);
-      triggerPixelSpy = sandbox.stub(utils, 'triggerPixel');
+      sandbox.stub(utils, 'triggerPixel');
       parseStub.returns({
         protocol: 'http',
         host: 'example.com'
@@ -99,8 +81,6 @@ describe('renderingManager', function() {
         adServerDomain: 'mypub.com',
         pubUrl: ORIGIN,
       };
-      eventSource = null;
-
       renderCrossDomain(mockWin, ucTagData.adId, ucTagData.adServerDomain, ucTagData.pubUrl);
 
     });
@@ -126,7 +106,7 @@ describe('renderingManager', function() {
       };
       mockPrebidResponse(data);
       sinon.assert.calledWith(dynamic.runDynamicRenderer, data.adId, sinon.match(data))
-    })
+    });
 
     it("should render cross domain creative", function () {
       mockPrebidResponse({

package/test/spec/uid_spec.js

@@ -3,42 +3,27 @@ import * as commons from 'src/ssp-userids/commons';
 import { expect } from 'chai';
 
 describe('uid module', function() {
-  let xhr;
-  let requests;
+  let sandbox;
   let saveStorageStub;
   let getStorageStub;
-
-  before(function() {
-    xhr = sinon.useFakeXMLHttpRequest();
-    xhr.onCreate = function(xhr) {
-      requests.push(xhr);
-    }
-  });
-
-  after(function(){
-    xhr.restore();
-  });
+  let ajaxStub;
 
   beforeEach(function() {
-    requests = [];
-    saveStorageStub = sinon.stub(commons, 'setDataInLocalStorage');
-    getStorageStub = sinon.stub(commons, 'getDataFromLocalStorage');
+    sandbox = sinon.createSandbox();
+    saveStorageStub = sandbox.stub(commons, 'setDataInLocalStorage');
+    getStorageStub = sandbox.stub(commons, 'getDataFromLocalStorage');
+    ajaxStub = sandbox.stub(commons, 'ajax');
   });
 
   afterEach(function() {
-    saveStorageStub.restore();
-    getStorageStub.restore();
+    sandbox.restore();
   });
 
   it('should save data in local storage when script is loaded', function() {
     getStorageStub.returns(null);
     let response = '{"buyeruids": {"appnexus":"12345"}}';
     loadData(sinon.spy());
-    requests[0].respond(
-      200, 
-      { "Content-Type": "text/plain" },
-      response
-    );
+    ajaxStub.firstCall.args[1](response);
     expect(JSON.parse(saveStorageStub.args[0][1])).to.have.all.keys(['buyeruids', 'lastUpdated'])
     expect(saveStorageStub.callCount).to.equal(1);
   });
@@ -52,7 +37,7 @@ describe('uid module', function() {
       "buyeruids": {"appnexus":"12345"}
     }
     expect(callbackSpy.calledWith(null, expectedResponse)).to.be.true;
-    expect(requests.length).to.equal(0);
+    expect(ajaxStub.callCount).to.equal(0);
   });
 
   it('should get buyer ids from endpoint when local storage not supported', function() {
@@ -60,11 +45,7 @@ describe('uid module', function() {
     getStorageStub.returns(undefined);
     let callbackSpy = sinon.spy();
     getBuyerUids(callbackSpy);
-    requests[0].respond(
-      200, 
-      { "Content-Type": "text/plain" },
-      response
-    );
+    ajaxStub.firstCall.args[1](response);
     expect(callbackSpy.calledWith(null, JSON.parse(response))).to.be.true;
     expect(saveStorageStub.callCount).to.equal(1);
   });

package/test/test_index.js

@@ -1,2 +1,2 @@
 var testsContext = require.context('.', true, /_spec$/);
-testsContext.keys().forEach(testsContext);
+testsContext.keys().forEach(testsContext);

package/webpack.conf.js

@@ -1,9 +1,9 @@
 var creative = require('./package.json');
-var StringReplacePlugin = require('string-replace-webpack-plugin');
 var path = require('path');
-const ShakePlugin = require('webpack-common-shake').Plugin;
 
 module.exports = {
+  mode: 'none',
+  target: ['web', 'es5'],
   devtool: 'source-map',
   resolve: {
     modules: [
@@ -13,6 +13,9 @@ module.exports = {
   },
   output: {
   },
+  optimization: {
+    usedExports: true
+  },
   module: {
     rules: [
       {
@@ -22,7 +25,7 @@ module.exports = {
           {
             loader: 'babel-loader',
             options: {
-              presets: ['@babel/preset-env']
+              presets: [['@babel/preset-env', { modules: 'commonjs' }]]
             }
           }
         ]
@@ -30,18 +33,12 @@ module.exports = {
       {
         test: /\.js$/,
         include: /(src|test|testpages)/,
-        loader: StringReplacePlugin.replace({
-          replacements: [
-            {
-              pattern: /\$\$PREBID_GLOBAL\$\$/g,
-              replacement: function (match, p1, offset, string) {
-                return creative.globalVarName;
-              }
-            }
-          ]
-        })
+        loader: 'string-replace-loader',
+        options: {
+          search: /\$\$PREBID_GLOBAL\$\$/g,
+          replace: creative.globalVarName
+        }
       }
     ]
-  },
-  plugins: [new ShakePlugin()],
+  }
 };