prebid-universal-creative 1.17.2 → 1.18.0

package/karma.conf.maker.js

@@ -4,6 +4,16 @@ const karmaConstants = require('karma').constants;
 const path = require('path');
 
 function setBrowsers(karmaConf, browserstack) {
+  if (typeof process.getuid === 'function' && process.getuid() === 0) {
+    karmaConf.customLaunchers = Object.assign({}, karmaConf.customLaunchers, {
+      ChromeHeadlessNoSandbox: {
+        base: 'ChromeHeadless',
+        flags: ['--no-sandbox']
+      }
+    });
+    karmaConf.browsers = ['ChromeHeadlessNoSandbox'];
+  }
+
   if (browserstack) {
     karmaConf.browserStack = {
       username: process.env.BROWSERSTACK_USERNAME,
@@ -46,17 +56,19 @@ function setReporters(karmaConf, codeCoverage, browserstack) {
 function newWebpackConfig(codeCoverage) {
   const webpackConfig = _.cloneDeep(webpackConf);
   webpackConfig.devtool = 'inline-source-map';
+  delete webpackConfig.optimization;
 
   if (codeCoverage) {
-    webpackConfig.module.rules.push({
-      test: /\.js$/,
-      enforce: 'post',
-      use: {
-        loader: 'istanbul-instrumenter-loader',
-        options: { esModules: true }
-      },
-      exclude: /(node_modules)|(test)|(resources)|(template)|(testpages)/
+    const babelRule = webpackConfig.module.rules.find(rule => {
+      const loaders = Array.isArray(rule.use) ? rule.use : [rule.use];
+      return loaders.some(loader => loader && loader.loader === 'babel-loader');
     });
+    const babelLoader = babelRule.use.find(loader => loader.loader === 'babel-loader');
+    babelLoader.options.plugins = (babelLoader.options.plugins || []).concat([
+      ['istanbul', {
+        exclude: ['test/**/*.js', 'resources/**/*.js', 'template/**/*.js', 'testpages/**/*.js']
+      }]
+    ]);
   }
   return webpackConfig;
 }
@@ -88,12 +100,12 @@ module.exports = function(codeCoverage, browserstack, watchMode) {
     ],
     webpack: webpackConfig,
     webpackMiddleware: {
-      logLevel: 'error'
+      stats: 'errors-only'
     },
 
     // frameworks to use
     // available frameworks: https://npmjs.org/browse/keyword/karma-adapter
-    frameworks: ['mocha', 'chai', 'sinon'],
+    frameworks: ['mocha', 'chai', 'sinon', 'webpack'],
 
     // list of files / patterns to load in the browser
     files: files,

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "prebid-universal-creative",
-    "version": "1.17.2",
+    "version": "1.18.0",
     "description": "Universal creative for Prebid apps",
     "main": "dist/creative.js",
     "scripts": {
@@ -28,50 +28,49 @@
         "@babel/register": "^7.6.2",
         "@playwright/test": "^1.50.1",
         "babel-loader": "^8.0.5",
+        "babel-plugin-istanbul": "^8.0.0",
         "babel-plugin-transform-es3-member-expression-literals": "^6.22.0",
         "babel-plugin-transform-es3-property-literals": "^6.22.0",
         "chai": "^4.1.2",
-        "core-js": "^3.13.0",
-        "core-js-pure": "^3.13.0",
+        "core-js": "^3.49.0",
+        "core-js-pure": "^3.49.0",
         "del": "^5.0.0",
         "execa": "^1.0.0",
         "gulp": "^5.0.0",
         "gulp-clean": "^0.4.0",
         "gulp-connect": "^5.7.0",
-        "gulp-eslint": "^4.0.2",
+        "gulp-eslint": "^6.0.0",
         "gulp-header": "^2.0.1",
         "gulp-inject": "^5.0.2",
         "gulp-rename": "^1.2.2",
         "gulp-replace": "^0.6.1",
         "gulp-uglify": "^3.0.0",
         "istanbul": "^0.4.5",
-        "istanbul-instrumenter-loader": "^3.0.0",
         "karma": "^6.4.0",
         "karma-browserstack-launcher": "^1.3.0",
         "karma-chai": "^0.1.0",
         "karma-chrome-launcher": "^2.2.0",
-        "karma-coverage": "^1.1.2",
-        "karma-coverage-istanbul-reporter": "^1.4.3",
+        "karma-coverage": "^2.2.1",
+        "karma-coverage-istanbul-reporter": "^3.0.3",
         "karma-mocha": "^2.0.1",
         "karma-mocha-reporter": "^2.2.5",
         "karma-sinon": "^1.0.5",
         "karma-sourcemap-loader": "^0.3.7",
         "karma-spec-reporter": "^0.0.31",
-        "karma-webpack": "^3.0.5",
+        "karma-webpack": "^5.0.1",
         "lodash": "^4.17.14",
-        "mocha": "^10.2.0",
+        "mocha": "^11.7.6",
         "opn": "^6.0.0",
-        "sinon": "^6.3.4",
-        "string-replace-webpack-plugin": "^0.1.3",
+        "sinon": "^22.0.0",
+        "string-replace-loader": "^3.3.0",
         "webdriverio": "^9.10.0",
-        "webpack": "^3.12.0",
-        "webpack-common-shake": "^1.0.0",
-        "webpack-stream": "^4.0.0",
+        "webpack": "^5.107.2",
+        "webpack-stream": "^7.0.0",
         "yargs": "^11.0.0"
     },
     "dependencies": {
         "babel-plugin-transform-object-assign": "^6.22.0",
-        "postscribe": "^2.0.8",
-        "gulp-cli": "^3.0.0"
+        "gulp-cli": "^3.0.0",
+        "postscribe": "^2.0.8"
     }
 }

package/src/cookieSync.js

@@ -24,6 +24,7 @@ const coopSyncParam = parseQueryParam('coop_sync', window.location.search);
 const COOP_SYNC = !coopSyncParam || coopSyncParam === 'true' || !!parseInt(coopSyncParam);
 const GDPR = sanitizeGdpr(parseInt(parseQueryParam('gdpr', window.location.search), 10));
 const GDPR_CONSENT = sanitizeGdprConsent(parseQueryParam('gdpr_consent', window.location.search));
+const ACCOUNT = parseQueryParam('account', window.location.search);
 
 /**
  * checks to make sure URL is valid. Regex from https://validatejs.org/#validators-url, https://gist.github.com/dperini/729294
@@ -267,6 +268,7 @@ function getStringifiedData(endPointArgs) {
     }
   };
   if(BIDDER_ARGS) data.bidders = BIDDER_ARGS;
+  if(ACCOUNT) data.account = ACCOUNT;
 
   return JSON.stringify(data);
 }

package/src/cookieSyncWithConsent.js

@@ -24,6 +24,7 @@ const coopSyncParam = parseQueryParam('coop_sync', window.location.search);
 const COOP_SYNC = !coopSyncParam || coopSyncParam === 'true' || !!parseInt(coopSyncParam);
 const TIMEOUT = sanitizeTimeout(parseInt(parseQueryParam('timeout', window.location.search), 10));
 const DEFAULT_GDPR_SCOPE = sanitizeScope(parseInt(parseQueryParam('defaultGdprScope', window.location.search), 10));
+const ACCOUNT = parseQueryParam('account', window.location.search);
 
 let consent = {};
 let syncRan = false;
@@ -284,6 +285,7 @@ function getStringifiedData(endPointArgs) {
         }
     };
     if(BIDDER_ARGS) data.bidders = BIDDER_ARGS;
+    if(ACCOUNT) data.account = ACCOUNT;
 
     data = attachConsent(data);
 

package/src/mobileAndAmpRender.js

@@ -66,7 +66,7 @@ function resizeIframe(width, height) {
   const iframeHeight = window.innerHeight;
   if (iframeWidth !== width || iframeHeight !== height) {
     if (isSafeFrame(window)) {
-      function resize(status) {
+      function resize() {
         let newWidth = width - iframeWidth;
         let newHeight = height - iframeHeight;
         window.$sf.ext.expand({r: newWidth, b: newHeight, push: true});
@@ -131,7 +131,7 @@ function responseCallback(isMobileApp, hbPb) {
       if (bidObject.burl) {
         let triggerBurl = function () { triggerPixel(bidObject.burl); };
         if (isMobileApp) {
-          let mraidScript = loadScript(window, 'mraid.js',
+          loadScript(window, 'mraid.js',
             function () { // Success loading MRAID
               let result = registerMRAIDViewableEvent(triggerBurl);
               if (!result) {

package/src/nativeAssetManager.js

@@ -430,7 +430,7 @@ export function newNativeAssetManager(win, nativeTag, mkMessenger = prebidMessen
     stopListening();
     const resize = () => requestHeightResize(
         bid.adId,
-        (document.body.clientHeight || document.body.offsetHeight),
+        (document.body.clientHeight || document.body.offsetHeight || document.documentElement.scrollHeight),
         document.body.clientWidth > 1 ? document.body.clientWidth : undefined
     );
     document.readyState === 'complete' ? resize() : window.onload = resize;

package/src/nativeORTBTrackerManager.js

@@ -1,5 +1,3 @@
-import { loadScript, triggerPixel } from "./utils";
-
 const AD_ANCHOR_CLASS_NAME = 'pb-click';
 const ASSET_ID_ELEMENT_ATTRIBUTE = 'hb_native_asset_id';
 

package/src/nativeTrackerManager.js

@@ -1,7 +1,7 @@
 /*
  * Script to handle firing impression and click trackers from native teamplates
  */
-import { parseUrl, triggerPixel, transformAuctionTargetingData } from './utils';
+import { triggerPixel, transformAuctionTargetingData } from './utils';
 import { newNativeAssetManager } from './nativeAssetManager';
 import {prebidMessenger} from './messaging.js';
 

package/src/postscribeRender.js

@@ -3,8 +3,69 @@ import postscribe from 'postscribe';
 export function writeAdHtml(markup, ps = postscribe) {
     // remove <?xml> and <!doctype> tags
     // https://github.com/prebid/prebid-universal-creative/issues/134
-    markup = markup.replace(/\<(\?xml|(\!DOCTYPE[^\>\[]+(\[[^\]]+)?))+[^>]+\>/gi, '');
-    ps(document.body, markup, {
+    markup = markup
+        .replace(/<\?xml\b[^>]*(?:\?>|>)/gi, '')
+        .replace(/<!doctype\b[^>\[]*(?:\[[^\]]*\][^>]*)?>/gi, '');
+
+    let finalMarkup;
+
+    try {
+        finalMarkup = normalizeMarkup(markup);
+    } catch (error) {
+        console.error("Error normalizing markup:", error.message);
+        finalMarkup = markup;
+    }
+
+    ps(document.body, finalMarkup, {
         error: console.error
     });
 }
+
+/**
+ * Normalizes an HTML string by parsing and re-serializing it,
+ * returning the content between custom PUC_START and PUC_END markers.
+ *
+ * This function is specifically aimed at addressing an issue with `postscribe` where double quotes inside single-quoted
+ * HTML attributes are not correctly escaped.
+ */
+function normalizeMarkup(markup) {
+    const timestamp = Date.now();
+    const startMarkerId = `PUC_START_${timestamp}`;
+    const endMarkerId = `PUC_END_${timestamp}`;
+    const startMarker = `<div id="${startMarkerId}"></div>`;
+    const endMarker = `<div id="${endMarkerId}"></div>`;
+    const doc = new DOMParser().parseFromString(`${startMarker}${markup}${endMarker}`, "text/html");
+
+    const textMap = new Map();
+    let textId = 0;
+
+    const replaceTextNodes = (node) => {
+        if (node.nodeType === Node.TEXT_NODE && node.textContent.trim()) {
+            const id = `PUC_NODE_TEXT_${textId++}_${timestamp}`;
+            textMap.set(id, node.textContent);
+            const span = doc.createElement("span");
+            span.dataset.textId = id;
+            node.parentNode.replaceChild(span, node);
+        } else {
+            [...node.childNodes].forEach(replaceTextNodes);
+        }
+    };
+
+    let current = doc.querySelector(`#${startMarkerId}`).nextSibling;
+    const end = doc.querySelector(`#${endMarkerId}`);
+    while (current && current !== end) {
+        replaceTextNodes(current);
+        current = current.nextSibling;
+    }
+
+    const serialized = new XMLSerializer().serializeToString(doc);
+    const snippet = serialized
+        .split(startMarker)[1]
+        .split(endMarker)[0]
+        .replace(
+            /<span data-text-id="(PUC_NODE_TEXT_\d+_\d+)"[^>]*><\/span>/g,
+            (_, id) => textMap.get(id) || ""
+        );
+
+    return snippet.trim();
+}

package/src/renderingManager.js

@@ -1,4 +1,4 @@
-import { parseUrl, transformAuctionTargetingData } from './utils';
+import { transformAuctionTargetingData } from './utils';
 import { canLocatePrebid } from './environment';
 import { insertElement, getEmptyIframe } from './domHelper';
 import {prebidMessenger, renderEventMessage} from './messaging.js';

package/test/spec/mobileAndAmpRender_spec.js

@@ -2,91 +2,28 @@ import { renderAmpOrMobileAd } from 'src/mobileAndAmpRender';
 import * as postscribeRender from 'src/postscribeRender'
 import * as utils from 'src/utils';
 import { expect } from 'chai';
-import { mocks } from 'test/helpers/mocks';
-import { merge } from 'lodash';
-import {writeAdHtml} from 'src/postscribeRender';
-
-
-function renderingMocks() {
-  return {
-    messages: [],
-    getWindowObject: function () {
-      return {
-        document: {
-          body: {
-            appendChild: sinon.spy(),
-          },
-          createComment: () => true,
-        },
-        parent: {
-          postMessage: sinon.spy(),
-          $$PREBID_GLOBAL$$: {
-            renderAd: sinon.spy(),
-          },
-        },
-        postMessage: (message, domain) => {
-          this.messages[0](message);
-        },
-        top: null,
-        $sf: {
-          ext: {
-            register: sinon.spy(),
-            expand: sinon.spy(),
-          },
-        },
-        addEventListener: (type, listener, capture) => {
-          this.messages.push(listener);
-        },
-        innerWidth: 300,
-        innerHeight: 250,
-      };
-    },
-  };
-}
-
-describe("renderingManager", function () {
-  let xhr;
-  let requests;
-
-  before(function () {
-    xhr = sinon.useFakeXMLHttpRequest();
-    xhr.onCreate = (request) => requests.push(request);
-  });
-
-  beforeEach(function () {
-    requests = [];
-  });
+import { writeAdHtml } from 'src/postscribeRender';
 
-  after(function () {
-    xhr.restore();
-  });
 
+describe("renderingManager", function () {
   describe("mobile creative", function () {
+    let sandbox;
     let writeHtmlSpy;
-    let sendRequestSpy;
-    let triggerPixelSpy;
-    let mockWin;
-
-    before(function () {
-      writeHtmlSpy = sinon.spy(postscribeRender, "writeAdHtml");
-      sendRequestSpy = sinon.spy(utils, "sendRequest");
-      triggerPixelSpy = sinon.spy(utils, "triggerPixel");
-      mockWin = merge(
-        mocks.createFakeWindow("http://example.com"),
-        renderingMocks().getWindowObject()
-      );
-    });
+    let sendRequestStub;
+    let requestCallbacks;
 
-    afterEach(function () {
-      writeHtmlSpy.resetHistory();
-      sendRequestSpy.resetHistory();
-      triggerPixelSpy.resetHistory();
+    beforeEach(function () {
+      sandbox = sinon.createSandbox();
+      requestCallbacks = [];
+      writeHtmlSpy = sandbox.spy(postscribeRender, "writeAdHtml");
+      sendRequestStub = sandbox.stub(utils, "sendRequest").callsFake((url, callback) => {
+        requestCallbacks.push(callback);
+      });
+      sandbox.spy(utils, "triggerPixel");
     });
 
-    after(function () {
-      writeHtmlSpy.restore();
-      sendRequestSpy.restore();
-      triggerPixelSpy.restore();
+    afterEach(function () {
+      sandbox.restore();
     });
 
     it("should render mobile app creative", function () {
@@ -106,9 +43,9 @@ describe("renderingManager", function () {
         adm: "ad-markup",
         wurl: "https://test.prebidcache.wurl",
       };
-      requests[0].respond(200, {}, JSON.stringify(response));
+      requestCallbacks[0](JSON.stringify(response));
       expect(writeHtmlSpy.callCount).to.equal(1);
-      expect(sendRequestSpy.args[0][0]).to.equal(
+      expect(sendRequestStub.args[0][0]).to.equal(
         "https://example.com/path?uuid=123"
       );
     });
@@ -129,9 +66,9 @@ describe("renderingManager", function () {
         crid: 123,
         adm: "ad-markup",
       };
-      requests[0].respond(200, {}, JSON.stringify(response));
+      requestCallbacks[0](JSON.stringify(response));
       expect(writeHtmlSpy.callCount).to.equal(1);
-      expect(sendRequestSpy.args[0][0]).to.equal(
+      expect(sendRequestStub.args[0][0]).to.equal(
         "https://example.com/path?uuid=123"
       );
     });
@@ -149,9 +86,9 @@ describe("renderingManager", function () {
         crid: 123,
         adm: "ad-markup",
       };
-      requests[0].respond(200, {}, JSON.stringify(response));
+      requestCallbacks[0](JSON.stringify(response));
       expect(writeHtmlSpy.callCount).to.equal(1);
-      expect(sendRequestSpy.args[0][0]).to.equal(
+      expect(sendRequestStub.args[0][0]).to.equal(
         "https://prebid.adnxs.com/pbc/v1/cache?uuid=123"
       );
     });
@@ -178,7 +115,7 @@ describe("renderingManager", function () {
   //       crid: 123,
   //       adm: '<script src="notExistingScript.js"></script>'
   //     };
-  //     requests[0].respond(200, {}, JSON.stringify(response));
+  //     requestCallbacks[0](JSON.stringify(response));
 
   //     setTimeout(() => {
   //       expect(consoleErrorSpy.callCount).to.equal(1);
@@ -192,14 +129,17 @@ describe("renderingManager", function () {
     let writeHtmlSpy;
     let sendRequestSpy;
     let triggerPixelSpy;
-    let mockWin;
     let ucTagData;
     let response;
+    let requestCallbacks;
 
     beforeEach(function () {
-      sandbox = sinon.sandbox.create();
+      sandbox = sinon.createSandbox();
+      requestCallbacks = [];
       writeHtmlSpy = sandbox.spy(postscribeRender, "writeAdHtml");
-      sendRequestSpy = sandbox.spy(utils, "sendRequest");
+      sendRequestSpy = sandbox.stub(utils, "sendRequest").callsFake((url, callback) => {
+        requestCallbacks.push(callback);
+      });
       triggerPixelSpy = sandbox.spy(utils, "triggerPixel");
       ucTagData = {
         cacheHost: "example.com",
@@ -226,21 +166,21 @@ describe("renderingManager", function () {
       sandbox.spy(window.parent, 'postMessage');
       ucTagData.size = '400x500'
       renderAmpOrMobileAd(ucTagData);
-      requests[0].respond(200, {}, JSON.stringify(response));
+      requestCallbacks[0](JSON.stringify(response));
       sinon.assert.calledWith(window.parent.postMessage, {
         sentinel: "amp",
         type: "embed-size",
         width: 400,
         height: 500,
       });
-    })
+    });
 
     it("should render amp creative", function () {
       ucTagData.hbPb = "10.00";
       renderAmpOrMobileAd(ucTagData);
 
 
-      requests[0].respond(200, {}, JSON.stringify(response));
+      requestCallbacks[0](JSON.stringify(response));
       expect(writeHtmlSpy.args[0][0]).to.equal(
         "<!--Creative 123 served by Prebid.js Header Bidding-->ad-markup10.00"
       );
@@ -255,7 +195,7 @@ describe("renderingManager", function () {
     it("should replace AUCTION_PRICE with response.price over hbPb", function () {
       renderAmpOrMobileAd(ucTagData);
       response.price = 12.5;
-      requests[0].respond(200, {}, JSON.stringify(response));
+      requestCallbacks[0](JSON.stringify(response));
       expect(writeHtmlSpy.args[0][0]).to.equal(
         "<!--Creative 123 served by Prebid.js Header Bidding-->ad-markup12.5"
       );
@@ -269,7 +209,7 @@ describe("renderingManager", function () {
 
     it("should replace AUCTION_PRICE with with empty value when neither price nor hbPb exist", function () {
       renderAmpOrMobileAd(ucTagData);
-      requests[0].respond(200, {}, JSON.stringify(response));
+      requestCallbacks[0](JSON.stringify(response));
       expect(writeHtmlSpy.args[0][0]).to.equal(
         "<!--Creative 123 served by Prebid.js Header Bidding-->ad-markup"
       );
@@ -301,9 +241,62 @@ describe('writeAdHtml', () => {
     sinon.assert.calledWith(ps, sinon.match.any, '<div>mock-ad</div>')
   });
 
+  it('removes XML declarations from markup', () => {
+    const ps = sinon.stub();
+    writeAdHtml('<?xml version="1.0" encoding="UTF-8"?><div>mock-ad</div>', ps);
+    sinon.assert.calledWith(ps, sinon.match.any, '<div>mock-ad</div>')
+  });
+
+  it('removes malformed XML declarations from markup', () => {
+    const ps = sinon.stub();
+    writeAdHtml('<?xml version="1.0"><div>mock-ad</div>', ps);
+    sinon.assert.calledWith(ps, sinon.match.any, '<div>mock-ad</div>')
+  });
+
+  it('removes doctype declarations with internal subsets from markup for postscribe compatibility (see postscribe issue 358)', () => {
+    const ps = sinon.stub();
+    writeAdHtml('<!DOCTYPE html [<!ENTITY nbsp "&#160;">]><div>mock-ad</div>', ps);
+    sinon.assert.calledWith(ps, sinon.match.any, '<div>mock-ad</div>')
+  });
+
   it('should execute script tag inserted into the body', () => {
     const markup = '<script>window.testScriptExecuted=true;</script>'
     writeAdHtml(markup);
     expect(window.testScriptExecuted).to.equal(true);
   });
+
+  it('should handle single quotes with inner double quotes', () => {
+    const input = `<img title='uh "oh" > this should all be inside the title attribute'>`;
+    console.log('Input: ', input);
+
+    writeAdHtml(input);
+
+    const img = document.querySelector('img:last-of-type');
+    if (img) {
+      console.log('Output:', img.outerHTML);
+      console.log('Title: ', img.getAttribute('title'));
+
+      const expected = 'uh "oh" > this should all be inside the title attribute';
+      expect(img.getAttribute('title')).to.equal(expected);
+    }
+  });
+
+  it('should handle JSON in data attributes with single quotes', () => {
+    const input = `<div data-json='{"key": "value"}'>Test</div>`;
+    console.log('Input: ', input);
+
+    writeAdHtml(input);
+
+    const div = document.querySelector('div[data-json]:last-of-type');
+    if (div) {
+      console.log('Output:', div.outerHTML);
+      console.log('Data:  ', div.getAttribute('data-json'));
+
+      const dataJson = div.getAttribute('data-json');
+      expect(dataJson).to.equal('{"key": "value"}');
+
+      const parsed = JSON.parse(dataJson);
+      expect(parsed.key).to.equal('value');
+    }
+  });
 })

package/test/spec/nativeAssetManager_spec.js

@@ -43,7 +43,7 @@ const mockDocument = {
 };
 
 // creates mock postmessage response from prebid's native.js:getAssetMessage
-function createResponder(assets,url,template, clickUrlUnesc = '') {
+function createResponder(assets,url,template) {
   return function(type, listener) {
     if (type !== 'message') { return; }
 
@@ -443,7 +443,7 @@ describe('nativeAssetManager', () => {
       expect(win.document.body.innerHTML).to.not.include(`##hb_native_asset_id_4##`);
 
       // test that we are replacing ALL asset occurrences
-      expect(([...win.document.body.innerHTML.match(/new value/g)] || []).length, "expected 2 occurrences of \"new value\"").to.equal(2);
+      expect((win.document.body.innerHTML.match(/new value/g) || []).length, "expected 2 occurrences of \"new value\"").to.equal(2);
     });
 
     it('no placeholders found but requests all assets flag set - adTemplate', () => {
@@ -522,7 +522,7 @@ describe('nativeAssetManager', () => {
       let cb = sinon.spy();
       let targetingData = {
         uuid: '123'
-      }
+      };
 
       sinon.stub(utils, 'sendRequest').callsFake(function(arg1, cb) {
         let response = JSON.stringify({
@@ -560,7 +560,7 @@ describe('nativeAssetManager', () => {
       // cta was not in the response so it should default to an empty string
       expect(win.document.body.innerHTML).to.include('<h1></h1>');
       expect(cb.getCall(0).args[0]).to.haveOwnProperty('eventtrackers');
-    })
+    });
   })
 
   describe('safe frame disabled', () => {
@@ -620,14 +620,26 @@ describe('nativeAssetManager', () => {
         expect(win.document.body.innerHTML).to.include(`<a href="http://www.example.com" target="_blank" class="pb-click">new value</a>`);
       });
 
+      function getResizeRequest() {
+        return win.parent.postMessage.args
+          .map(([msg]) => JSON.parse(msg))
+          .find((msg) => msg.action === 'resizeNativeHeight')
+      }
+
       it('should not request width resize if width is 1', () => {
         sandbox.stub(document.body, 'clientWidth').get(() => 1);
         const nativeAssetManager = makeManager();
         nativeAssetManager.loadAssets(AD_ID);
-        const resizeRequest = win.parent.postMessage.args
-            .map(([msg]) => JSON.parse(msg))
-            .find((msg) => msg.action === 'resizeNativeHeight')
-        expect(resizeRequest.width).to.not.exist;
+        expect(getResizeRequest().width).to.not.exist;
+      });
+
+      it('should use scrollHeight if offsetHeight & clientHeight are 0', () => {
+        sandbox.stub(document.body, 'clientHeight').get(() => 0);
+        sandbox.stub(document.body, 'offsetHeight').get(() => 0);
+        sandbox.stub(document.documentElement, 'scrollHeight').get(() => 123);
+        const nativeAssetManager = makeManager();
+        nativeAssetManager.loadAssets(AD_ID);
+        expect(getResizeRequest().height).to.eql(123);
       })
 
       it('should set the iframe to the width of the container', () => {

package/test/spec/nativeORTBTrackerManager_spec.js

@@ -14,11 +14,11 @@ describe('test firing native trackers', function () {
 
     getElementsByClassName = sinon.stub(document, 'getElementsByClassName').callsFake(() => {
       return [{
-        addEventListener: (event, callback, capture) => {
+        addEventListener: (event, callback) => {
           // immediately call the callback to test the click
           callback({
             target: {
-              getAttribute: (name) => {
+              getAttribute: () => {
                 return 1;
               }
             }