popeye-cli 2.1.0 → 2.7.0

package/src/pipeline/phases/audit.ts

@@ -13,7 +13,7 @@ import type { AuditFinding, ArtifactEntry, ChangeRequest } from '../types.js';
 import type { ArtifactManager } from '../artifact-manager.js';
 
 export async function runAudit(context: PhaseContext): Promise<PhaseResult> {
-  const { pipeline, artifactManager, skillLoader, projectDir } = context;
+  const { pipeline, artifactManager, skillLoader, skillUsageRegistry, projectDir } = context;
   const artifacts = [];
 
   try {
@@ -23,8 +23,8 @@ export async function runAudit(context: PhaseContext): Promise<PhaseResult> {
     artifacts.push(snapshotEntry);
     pipeline.latestRepoSnapshot = artifactManager.toArtifactRef(snapshotEntry);
 
-    // 2. Load auditor skill
-    const auditorSkill = skillLoader.loadSkill('AUDITOR');
+    // 2. Load auditor skill with metadata
+    const { definition: auditorSkill, meta: auditorMeta } = skillLoader.loadSkillWithMeta('AUDITOR');
 
     // 3. Run audit checks via Claude
     const { executePrompt } = await import('../../adapters/claude.js');
@@ -53,6 +53,9 @@ export async function runAudit(context: PhaseContext): Promise<PhaseResult> {
     const auditResult = await executePrompt(auditPrompt);
     const auditResponse = auditResult.response;
 
+    // Record skill usage — auditor skill injected into audit prompt
+    skillUsageRegistry.record('AUDITOR', 'AUDIT', 'system_prompt', auditorMeta.source, auditorMeta.version);
+
     // 4. Parse findings from audit response (simplified extraction)
     const findings = parseAuditFindings(auditResponse);
 

package/src/pipeline/phases/consensus-architecture.ts

@@ -44,6 +44,7 @@ export async function runConsensusArchitecture(context: PhaseContext): Promise<P
     const masterPlanArtifact = pipeline.artifacts.find((a) => a.type === 'master_plan');
 
     // 3. Build plan packet
+    // v2.4.4: version tracks plan revision count for recovery loop convergence
     const planPacket = buildPlanPacket({
       phase: 'CONSENSUS_ARCHITECTURE',
       submittedBy: 'ARCHITECT',
@@ -61,11 +62,18 @@ export async function runConsensusArchitecture(context: PhaseContext): Promise<P
       ],
       dependencies: [],
       constraints: [],
+      version: pipeline.recoveryCount + 1,
     });
 
     // 4. Run consensus
+    // v2.4.4: pass revisionDirective from sessionGuidance so reviewers see prior feedback
     const gateDef = gateEngine.getGateDefinition('CONSENSUS_ARCHITECTURE');
-    const consensusPacket = await consensusRunner.runStructuredConsensus(planPacket, gateDef);
+    const revisionDirective = pipeline.recoveryCount > 0 && pipeline.sessionGuidance?.trim()
+      ? pipeline.sessionGuidance
+      : undefined;
+    const consensusPacket = await consensusRunner.runStructuredConsensus(planPacket, gateDef, {
+      revisionDirective,
+    });
 
     // 5. Store consensus artifact
     const consensusEntry = artifactManager.createAndStoreJson(
@@ -85,6 +93,7 @@ export async function runConsensusArchitecture(context: PhaseContext): Promise<P
       missingArtifacts: [],
       failedChecks: [],
       consensusScore: consensusPacket.consensus_result.score,
+      finalStatus: consensusPacket.final_status,  // v2.4.3: propagate for gate engine
       timestamp: new Date().toISOString(),
     };
 

package/src/pipeline/phases/consensus-master-plan.ts

@@ -35,13 +35,14 @@ export async function runConsensusMasterPlan(context: PhaseContext): Promise<Pha
     artifacts.push(snapshotEntry);
     pipeline.latestRepoSnapshot = artifactManager.toArtifactRef(snapshotEntry);
 
-    // 2. Find master plan artifact
-    const masterPlanArtifact = pipeline.artifacts.find((a) => a.type === 'master_plan');
+    // 2. Find latest master plan artifact (v2.4.3: reverse to get latest revision, not stale v1)
+    const masterPlanArtifact = [...pipeline.artifacts].reverse().find((a) => a.type === 'master_plan');
     if (!masterPlanArtifact) {
       return failureResult('CONSENSUS_MASTER_PLAN', 'No master plan artifact found');
     }
 
     // 3. Build plan packet
+    // v2.4.2: version tracks plan revision count for recovery loop convergence
     const planPacket = buildPlanPacket({
       phase: 'CONSENSUS_MASTER_PLAN',
       submittedBy: 'DISPATCHER',
@@ -57,11 +58,16 @@ export async function runConsensusMasterPlan(context: PhaseContext): Promise<Pha
       ],
       dependencies: [],
       constraints: [],
+      version: pipeline.recoveryCount + 1,
     });
 
     // 4. Run structured consensus
+    // v2.4.2: pass revisionDirective from sessionGuidance so reviewers see prior feedback
     const gateDef = gateEngine.getGateDefinition('CONSENSUS_MASTER_PLAN');
-    const consensusPacket = await consensusRunner.runStructuredConsensus(planPacket, gateDef);
+    const revisionDirective = pipeline.recoveryCount > 0 ? pipeline.sessionGuidance : undefined;
+    const consensusPacket = await consensusRunner.runStructuredConsensus(planPacket, gateDef, {
+      revisionDirective,
+    });
 
     // 5. Store consensus artifact
     const consensusEntry = artifactManager.createAndStoreJson(
@@ -81,6 +87,7 @@ export async function runConsensusMasterPlan(context: PhaseContext): Promise<Pha
       missingArtifacts: [],
       failedChecks: [],
       consensusScore: consensusPacket.consensus_result.score,
+      finalStatus: consensusPacket.final_status,  // v2.4.3: propagate for gate engine
       timestamp: new Date().toISOString(),
     };
 

package/src/pipeline/phases/consensus-role-plans.ts

@@ -44,6 +44,7 @@ export async function runConsensusRolePlans(context: PhaseContext): Promise<Phas
     const masterPlanArtifact = pipeline.artifacts.find((a) => a.type === 'master_plan');
 
     // 3. Build plan packet referencing all role plans
+    // v2.4.4: version tracks plan revision count for recovery loop convergence
     const planPacket = buildPlanPacket({
       phase: 'CONSENSUS_ROLE_PLANS',
       submittedBy: 'DISPATCHER',
@@ -62,11 +63,18 @@ export async function runConsensusRolePlans(context: PhaseContext): Promise<Phas
       ],
       dependencies: [],
       constraints: [],
+      version: pipeline.recoveryCount + 1,
     });
 
     // 4. Run consensus
+    // v2.4.4: pass revisionDirective from sessionGuidance so reviewers see prior feedback
     const gateDef = gateEngine.getGateDefinition('CONSENSUS_ROLE_PLANS');
-    const consensusPacket = await consensusRunner.runStructuredConsensus(planPacket, gateDef);
+    const revisionDirective = pipeline.recoveryCount > 0 && pipeline.sessionGuidance?.trim()
+      ? pipeline.sessionGuidance
+      : undefined;
+    const consensusPacket = await consensusRunner.runStructuredConsensus(planPacket, gateDef, {
+      revisionDirective,
+    });
 
     // 5. Store consensus artifact
     const consensusEntry = artifactManager.createAndStoreJson(
@@ -86,6 +94,7 @@ export async function runConsensusRolePlans(context: PhaseContext): Promise<Phas
       missingArtifacts: [],
       failedChecks: [],
       consensusScore: consensusPacket.consensus_result.score,
+      finalStatus: consensusPacket.final_status,  // v2.4.3: propagate for gate engine
       timestamp: new Date().toISOString(),
     };
 

package/src/pipeline/phases/done.ts

@@ -7,12 +7,12 @@ import type { PhaseContext, PhaseResult } from './phase-context.js';
 import { successResult, failureResult } from './phase-context.js';
 
 export async function runDone(context: PhaseContext): Promise<PhaseResult> {
-  const { pipeline, artifactManager, skillLoader } = context;
+  const { pipeline, artifactManager, skillLoader, skillUsageRegistry } = context;
   const artifacts = [];
 
   try {
-    // 1. Load release manager skill
-    const rmSkill = skillLoader.loadSkill('RELEASE_MANAGER');
+    // 1. Load release manager skill with metadata
+    const { definition: rmSkill, meta: rmMeta } = skillLoader.loadSkillWithMeta('RELEASE_MANAGER');
 
     // 2. Generate release notes
     const { executePrompt } = await import('../../adapters/claude.js');
@@ -31,6 +31,9 @@ export async function runDone(context: PhaseContext): Promise<PhaseResult> {
     const releaseResult = await executePrompt(releasePrompt);
     const releaseResponse = releaseResult.response;
 
+    // Record skill usage — release manager skill injected into prompt
+    skillUsageRegistry.record('RELEASE_MANAGER', 'DONE', 'system_prompt', rmMeta.source, rmMeta.version);
+
     // 3. Create release notes artifact
     const releaseEntry = artifactManager.createAndStoreText(
       'release_notes',
@@ -55,9 +58,17 @@ export async function runDone(context: PhaseContext): Promise<PhaseResult> {
     );
     artifacts.push(rollbackEntry);
 
+    // 6. Store skill usage log artifact
+    const usageLogEntry = artifactManager.createAndStoreJson(
+      'skill_usage_log',
+      pipeline.skillUsageEvents ?? [],
+      'DONE',
+    );
+    artifacts.push(usageLogEntry);
+
     pipeline.artifacts.push(...artifacts);
 
-    // 6. Final INDEX.md update
+    // 7. Final INDEX.md update
     artifactManager.updateIndex(pipeline.artifacts);
 
     return successResult('DONE', artifacts, 'Pipeline complete. Release artifacts created.');

package/src/pipeline/phases/intake.ts

@@ -2,12 +2,19 @@
  * INTAKE phase — normalize user prompt into structured Master Plan v1.
  * Reuses expandIdea() and createPlan() from workflow.
  * v1.1: Creates constitution artifact and stores hash.
+ * v1.2: Generates project-specific skills and constitution.
  */
 
+import { join } from 'node:path';
+
 import type { PhaseContext, PhaseResult } from './phase-context.js';
 import { successResult, failureResult } from './phase-context.js';
 import { generateRepoSnapshot, createSnapshotArtifact } from '../repo-snapshot.js';
 import { createConstitutionArtifact, computeConstitutionHash } from '../constitution.js';
+import { getActiveRoles, inferTechStack } from '../skills/role-map.js';
+import { generateProjectSkills } from '../skills/generator.js';
+import { generateConstitution } from '../skills/constitution-generator.js';
+import type { OutputLanguage } from '../../types/project.js';
 
 export async function runIntake(context: PhaseContext): Promise<PhaseResult> {
   const { projectDir, pipeline, artifactManager } = context;
@@ -20,14 +27,7 @@ export async function runIntake(context: PhaseContext): Promise<PhaseResult> {
     artifacts.push(snapshotEntry);
     pipeline.latestRepoSnapshot = artifactManager.toArtifactRef(snapshotEntry);
 
-    // 2. Create constitution artifact and store hash
-    const constitutionEntry = createConstitutionArtifact(projectDir, artifactManager);
-    if (constitutionEntry) {
-      artifacts.push(constitutionEntry);
-    }
-    pipeline.constitutionHash = computeConstitutionHash(projectDir);
-
-    // 3. Store additional_context artifact if session guidance provided
+    // 2. Store additional_context artifact if session guidance provided
     const guidance = pipeline.sessionGuidance ?? '';
     if (guidance) {
       const ctxEntry = artifactManager.createAndStoreText(
@@ -38,6 +38,9 @@ export async function runIntake(context: PhaseContext): Promise<PhaseResult> {
       artifacts.push(ctxEntry);
     }
 
+    // 3. Push pre-AI artifacts to pipeline state now (survives if AI calls fail below)
+    pipeline.artifacts.push(...artifacts);
+
     // 4. Expand idea using existing workflow
     const { expandIdea, createPlan } = await import('../../workflow/plan-mode.js');
     const expandedIdea = await expandIdea(
@@ -45,20 +48,70 @@ export async function runIntake(context: PhaseContext): Promise<PhaseResult> {
       context.state.language,
     );
 
-    // 5. Create master plan — prepend guidance so planner sees constraints first
-    const planInput = guidance
-      ? `${guidance}\n\n---\n\n${expandedIdea}`
-      : expandedIdea;
+    // 5. Determine active roles
+    const language = context.state.language as OutputLanguage;
+    pipeline.activeRoles = getActiveRoles(language);
+
+    // 6-8. Generate project-specific skills and constitution (non-fatal)
+    const skillsDir = join(projectDir, 'skills');
+    try {
+      const projectName = context.state.name ?? 'Project';
+
+      await generateProjectSkills(
+        {
+          language,
+          expandedSpec: expandedIdea,
+          snapshot,
+          sessionGuidance: guidance || undefined,
+          activeRoles: pipeline.activeRoles,
+          skillsDir,
+          projectName,
+        },
+        artifactManager,
+      );
+
+      const techStack = inferTechStack(language, snapshot, expandedIdea);
+      generateConstitution({
+        language,
+        projectName,
+        techStack,
+        expandedSpec: expandedIdea,
+        sessionGuidance: guidance || undefined,
+        skillsDir,
+      });
+
+      // Clear skill loader cache so it picks up new .md files
+      context.skillLoader.clearCache();
+    } catch {
+      // Skill/constitution generation is non-fatal — pipeline continues with defaults
+    }
+
+    // 9. Create constitution artifact and store hash (AFTER generation)
+    const constitutionEntry = createConstitutionArtifact(projectDir, artifactManager);
+    if (constitutionEntry) {
+      artifacts.push(constitutionEntry);
+      pipeline.artifacts.push(constitutionEntry);
+    }
+    pipeline.constitutionHash = computeConstitutionHash(projectDir);
+
+    // 10. Create master plan — prepend guidance so planner sees constraints first
+    // Detect revision directive and instruct plan to include "Addressed Reviewer Feedback" section
+    const isRevision = guidance.includes('--- REVISION DIRECTIVE ---');
+    const planInput = isRevision
+      ? `${guidance}\n\nIMPORTANT: Include a "## Addressed Reviewer Feedback" section mapping each Required Change to the concrete revision made.\n\n${expandedIdea}`
+      : guidance
+        ? `${guidance}\n\n---\n\n${expandedIdea}`
+        : expandedIdea;
     const plan = await createPlan(planInput, '', context.state.language);
 
-    // 6. Store master plan as artifact
+    // 11. Store master plan as artifact
     const planEntry = artifactManager.createAndStoreText(
       'master_plan',
       plan,
       'INTAKE',
     );
     artifacts.push(planEntry);
-    pipeline.artifacts.push(...artifacts);
+    pipeline.artifacts.push(planEntry);
 
     return successResult('INTAKE', artifacts, 'Master Plan v1 created');
   } catch (err) {

package/src/pipeline/phases/phase-context.ts

@@ -8,6 +8,7 @@ import type { GateEngine } from '../gate-engine.js';
 import type { SkillLoader } from '../skill-loader.js';
 import type { ConsensusRunner } from '../consensus/consensus-runner.js';
 import type { ProjectState } from '../../types/workflow.js';
+import type { SkillUsageRegistry } from '../skills/usage-registry.js';
 
 // ─── PhaseContext ────────────────────────────────────────
 
@@ -19,6 +20,7 @@ export interface PhaseContext {
   artifactManager: ArtifactManager;
   gateEngine: GateEngine;
   consensusRunner: ConsensusRunner;
+  skillUsageRegistry: SkillUsageRegistry;
 }
 
 // ─── PhaseResult ─────────────────────────────────────────
@@ -39,7 +41,7 @@ export async function triggerJournalist(
   artifacts: ArtifactEntry[],
   context: PhaseContext,
 ): Promise<ArtifactEntry | null> {
-  const skill = context.skillLoader.loadSkill('JOURNALIST');
+  const { definition: skill, meta } = context.skillLoader.loadSkillWithMeta('JOURNALIST');
 
   const traceContent = [
     `# Journalist Trace — ${phase}`,
@@ -55,6 +57,9 @@ export async function triggerJournalist(
     `${skill.systemPrompt.slice(0, 200)}...`,
   ].join('\n');
 
+  // Record skill usage — journalist skill injected into trace context
+  context.skillUsageRegistry.record('JOURNALIST', phase, 'other', meta.source, meta.version);
+
   const entry = context.artifactManager.createAndStoreText(
     'journalist_trace',
     traceContent,

package/src/pipeline/phases/production-gate.ts

@@ -4,10 +4,22 @@
  * v1.1: Adds start check and env check.
  */
 
+import { join } from 'node:path';
+import { existsSync } from 'node:fs';
+
 import type { PhaseContext, PhaseResult } from './phase-context.js';
 import { successResult, failureResult, triggerJournalist } from './phase-context.js';
 import { resolveCommands } from '../command-resolver.js';
-import { runAllChecks, runPlaceholderScan, runStartCheck, runEnvCheck, storeCheckResults } from '../check-runner.js';
+import {
+  runAllChecks,
+  runPlaceholderScan,
+  runStartCheck,
+  runEnvCheck,
+  runCheck,
+  storeCheckResults,
+  shouldSkipInstall,
+  writeInstallMarker,
+} from '../check-runner.js';
 import { generateRepoSnapshot } from '../repo-snapshot.js';
 
 export async function runProductionGate(context: PhaseContext): Promise<PhaseResult> {
@@ -20,6 +32,25 @@ export async function runProductionGate(context: PhaseContext): Promise<PhaseRes
     const commands = resolveCommands(snapshot);
     pipeline.resolvedCommands = commands;
 
+    // 1.5. Install dependencies if needed (skips if unchanged since QA_VALIDATION)
+    if (commands.install) {
+      const installCwd = commands.install_cwd
+        ? join(projectDir, commands.install_cwd)
+        : projectDir;
+      const skipInstall = shouldSkipInstall(projectDir, snapshot);
+      if (!skipInstall) {
+        const installResult = await runCheck('install', commands.install, installCwd);
+        if (installResult.status === 'fail') {
+          const stored = storeCheckResults([installResult], artifactManager, 'PRODUCTION_GATE');
+          artifacts.push(...stored);
+          pipeline.artifacts.push(...artifacts);
+          pipeline.gateChecks['PRODUCTION_GATE'] = [installResult];
+          return failureResult('PRODUCTION_GATE', 'Dependency installation failed', installResult.stderr_summary ?? '');
+        }
+        writeInstallMarker(projectDir, snapshot);
+      }
+    }
+
     // 2. Run all checks
     const checkResults = await runAllChecks(commands, projectDir);
 
@@ -52,7 +83,14 @@ export async function runProductionGate(context: PhaseContext): Promise<PhaseRes
     );
     const hasPlaceholders = placeholderResult.status === 'fail';
     const auditPassed = pipeline.artifacts.some((a) => a.type === 'audit_report');
-    const passed = failedChecks.length === 0 && auditPassed;
+
+    // Detect website projects — placeholder_scan blocks for these
+    const isWebsiteProject =
+      existsSync(join(projectDir, 'next.config.mjs')) ||
+      existsSync(join(projectDir, 'next.config.js')) ||
+      existsSync(join(projectDir, 'src', 'app', 'layout.tsx'));
+    const placeholderBlocking = hasPlaceholders && isWebsiteProject;
+    const passed = failedChecks.length === 0 && auditPassed && !placeholderBlocking;
 
     // 9. Create production readiness report
     const report = [
@@ -77,7 +115,7 @@ export async function runProductionGate(context: PhaseContext): Promise<PhaseRes
       `- Env: ${findCheckStatus(checkResults, 'env_check')}`,
       `- Start: ${findCheckStatus(checkResults, 'start')}`,
       `- Audit: ${auditPassed ? 'PASS' : 'MISSING'}`,
-      `- Placeholders: ${hasPlaceholders ? 'WARNING' : 'CLEAN'}`,
+      `- Placeholders: ${hasPlaceholders ? (placeholderBlocking ? 'FAIL (blocking for website)' : 'WARNING') : 'CLEAN'}`,
     ].join('\n');
 
     const reportEntry = artifactManager.createAndStoreText(

package/src/pipeline/phases/qa-validation.ts

@@ -3,23 +3,60 @@
  * Runs tests via checkRunner. Creates qa_validation artifact.
  */
 
+import { join } from 'node:path';
+
 import type { PhaseContext, PhaseResult } from './phase-context.js';
 import { successResult, failureResult } from './phase-context.js';
 import { resolveCommands } from '../command-resolver.js';
-import { runCheck, storeCheckResults } from '../check-runner.js';
+import {
+  runCheck,
+  storeCheckResults,
+  shouldSkipInstall,
+  writeInstallMarker,
+  invalidateInstallMarker,
+} from '../check-runner.js';
 import { generateRepoSnapshot } from '../repo-snapshot.js';
 
 export async function runQaValidation(context: PhaseContext): Promise<PhaseResult> {
-  const { pipeline, artifactManager, projectDir } = context;
+  const { pipeline, artifactManager, skillLoader, skillUsageRegistry, projectDir } = context;
   const artifacts = [];
 
   try {
-    // 1. Resolve test command
+    // 1. Load QA_TESTER skill and record usage
+    const { definition: _qaSkill, meta: qaMeta } = skillLoader.loadSkillWithMeta('QA_TESTER');
+    skillUsageRegistry.record('QA_TESTER', 'QA_VALIDATION', 'system_prompt', qaMeta.source, qaMeta.version);
+
+    // 2. Resolve test command
     const snapshot = await generateRepoSnapshot(projectDir);
     const commands = resolveCommands(snapshot);
     pipeline.resolvedCommands = commands;
 
-    // 2. Run test command
+    // 2.5. Install dependencies if needed
+    if (commands.install) {
+      const installCwd = commands.install_cwd
+        ? join(projectDir, commands.install_cwd)
+        : projectDir;
+      const skipInstall = shouldSkipInstall(projectDir, snapshot);
+      if (!skipInstall) {
+        const installResult = await runCheck('install', commands.install, installCwd);
+        const stored = storeCheckResults([installResult], artifactManager, 'QA_VALIDATION');
+        artifacts.push(...stored);
+
+        if (!pipeline.gateChecks['QA_VALIDATION']) {
+          pipeline.gateChecks['QA_VALIDATION'] = [];
+        }
+        pipeline.gateChecks['QA_VALIDATION'].push(installResult);
+
+        if (installResult.status === 'fail') {
+          pipeline.artifacts.push(...artifacts);
+          return failureResult('QA_VALIDATION', 'Dependency installation failed', installResult.stderr_summary ?? '');
+        }
+
+        writeInstallMarker(projectDir, snapshot);
+      }
+    }
+
+    // 3. Run test command
     if (commands.test) {
       const testResult = await runCheck('test', commands.test, projectDir);
       const stored = storeCheckResults([testResult], artifactManager, 'QA_VALIDATION');
@@ -30,9 +67,18 @@ export async function runQaValidation(context: PhaseContext): Promise<PhaseResul
         pipeline.gateChecks['QA_VALIDATION'] = [];
       }
       pipeline.gateChecks['QA_VALIDATION'].push(testResult);
+
+      // Invalidate install marker on missing-module errors
+      if (testResult.status === 'fail' && testResult.stderr_summary) {
+        const missingModule = /Cannot find module|ModuleNotFoundError|Failed to resolve import/
+          .test(testResult.stderr_summary);
+        if (missingModule) {
+          invalidateInstallMarker(projectDir);
+        }
+      }
     }
 
-    // 3. Create QA validation summary artifact
+    // 4. Create QA validation summary artifact
     const qaReport = [
       '# QA Validation Report',
       '',