popeye-cli 2.1.0 → 2.7.0

package/dist/pipeline/phases/production-gate.js

@@ -3,9 +3,11 @@
  * Uses commandResolver + checkRunner. Runs placeholder scan (P2-2).
  * v1.1: Adds start check and env check.
  */
+import { join } from 'node:path';
+import { existsSync } from 'node:fs';
 import { successResult, failureResult, triggerJournalist } from './phase-context.js';
 import { resolveCommands } from '../command-resolver.js';
-import { runAllChecks, runPlaceholderScan, runStartCheck, runEnvCheck, storeCheckResults } from '../check-runner.js';
+import { runAllChecks, runPlaceholderScan, runStartCheck, runEnvCheck, runCheck, storeCheckResults, shouldSkipInstall, writeInstallMarker, } from '../check-runner.js';
 import { generateRepoSnapshot } from '../repo-snapshot.js';
 export async function runProductionGate(context) {
     const { pipeline, artifactManager, projectDir } = context;
@@ -15,6 +17,24 @@ export async function runProductionGate(context) {
         const snapshot = await generateRepoSnapshot(projectDir);
         const commands = resolveCommands(snapshot);
         pipeline.resolvedCommands = commands;
+        // 1.5. Install dependencies if needed (skips if unchanged since QA_VALIDATION)
+        if (commands.install) {
+            const installCwd = commands.install_cwd
+                ? join(projectDir, commands.install_cwd)
+                : projectDir;
+            const skipInstall = shouldSkipInstall(projectDir, snapshot);
+            if (!skipInstall) {
+                const installResult = await runCheck('install', commands.install, installCwd);
+                if (installResult.status === 'fail') {
+                    const stored = storeCheckResults([installResult], artifactManager, 'PRODUCTION_GATE');
+                    artifacts.push(...stored);
+                    pipeline.artifacts.push(...artifacts);
+                    pipeline.gateChecks['PRODUCTION_GATE'] = [installResult];
+                    return failureResult('PRODUCTION_GATE', 'Dependency installation failed', installResult.stderr_summary ?? '');
+                }
+                writeInstallMarker(projectDir, snapshot);
+            }
+        }
         // 2. Run all checks
         const checkResults = await runAllChecks(commands, projectDir);
         // 3. Run placeholder scan (P2-2)
@@ -39,7 +59,12 @@ export async function runProductionGate(context) {
         const failedChecks = checkResults.filter((r) => r.status === 'fail' && r.check_type !== 'placeholder_scan');
         const hasPlaceholders = placeholderResult.status === 'fail';
         const auditPassed = pipeline.artifacts.some((a) => a.type === 'audit_report');
-        const passed = failedChecks.length === 0 && auditPassed;
+        // Detect website projects — placeholder_scan blocks for these
+        const isWebsiteProject = existsSync(join(projectDir, 'next.config.mjs')) ||
+            existsSync(join(projectDir, 'next.config.js')) ||
+            existsSync(join(projectDir, 'src', 'app', 'layout.tsx'));
+        const placeholderBlocking = hasPlaceholders && isWebsiteProject;
+        const passed = failedChecks.length === 0 && auditPassed && !placeholderBlocking;
         // 9. Create production readiness report
         const report = [
             '# Production Readiness Report',
@@ -61,7 +86,7 @@ export async function runProductionGate(context) {
             `- Env: ${findCheckStatus(checkResults, 'env_check')}`,
             `- Start: ${findCheckStatus(checkResults, 'start')}`,
             `- Audit: ${auditPassed ? 'PASS' : 'MISSING'}`,
-            `- Placeholders: ${hasPlaceholders ? 'WARNING' : 'CLEAN'}`,
+            `- Placeholders: ${hasPlaceholders ? (placeholderBlocking ? 'FAIL (blocking for website)' : 'WARNING') : 'CLEAN'}`,
         ].join('\n');
         const reportEntry = artifactManager.createAndStoreText('production_readiness', report, 'PRODUCTION_GATE');
         artifacts.push(reportEntry);

package/dist/pipeline/phases/production-gate.js.map

@@ -1 +1 @@
-{"version":3,"file":"production-gate.js","sourceRoot":"","sources":["../../../src/pipeline/phases/production-gate.ts"],"names":[],"mappings":"AAAA;;;;GAIG;AAGH,OAAO,EAAE,aAAa,EAAE,aAAa,EAAE,iBAAiB,EAAE,MAAM,oBAAoB,CAAC;AACrF,OAAO,EAAE,eAAe,EAAE,MAAM,wBAAwB,CAAC;AACzD,OAAO,EAAE,YAAY,EAAE,kBAAkB,EAAE,aAAa,EAAE,WAAW,EAAE,iBAAiB,EAAE,MAAM,oBAAoB,CAAC;AACrH,OAAO,EAAE,oBAAoB,EAAE,MAAM,qBAAqB,CAAC;AAE3D,MAAM,CAAC,KAAK,UAAU,iBAAiB,CAAC,OAAqB;IAC3D,MAAM,EAAE,QAAQ,EAAE,eAAe,EAAE,UAAU,EAAE,GAAG,OAAO,CAAC;IAC1D,MAAM,SAAS,GAAG,EAAE,CAAC;IAErB,IAAI,CAAC;QACH,oCAAoC;QACpC,MAAM,QAAQ,GAAG,MAAM,oBAAoB,CAAC,UAAU,CAAC,CAAC;QACxD,MAAM,QAAQ,GAAG,eAAe,CAAC,QAAQ,CAAC,CAAC;QAC3C,QAAQ,CAAC,gBAAgB,GAAG,QAAQ,CAAC;QAErC,oBAAoB;QACpB,MAAM,YAAY,GAAG,MAAM,YAAY,CAAC,QAAQ,EAAE,UAAU,CAAC,CAAC;QAE9D,iCAAiC;QACjC,MAAM,iBAAiB,GAAG,kBAAkB,CAAC,UAAU,CAAC,CAAC;QACzD,YAAY,CAAC,IAAI,CAAC,iBAAiB,CAAC,CAAC;QAErC,0BAA0B;QAC1B,MAAM,SAAS,GAAG,WAAW,CAAC,UAAU,EAAE,QAAQ,CAAC,CAAC;QACpD,YAAY,CAAC,IAAI,CAAC,SAAS,CAAC,CAAC;QAE7B,oDAAoD;QACpD,IAAI,QAAQ,CAAC,KAAK,EAAE,CAAC;YACnB,MAAM,WAAW,GAAG,MAAM,aAAa,CAAC,QAAQ,CAAC,KAAK,EAAE,UAAU,EAAE;gBAClE,IAAI,EAAE,QAAQ,CAAC,iBAAiB,CAAC,CAAC,CAAC,EAAE,IAAI;aAC1C,CAAC,CAAC;YACH,YAAY,CAAC,IAAI,CAAC,WAAW,CAAC,CAAC;QACjC,CAAC;QAED,sCAAsC;QACtC,MAAM,cAAc,GAAG,iBAAiB,CAAC,YAAY,EAAE,eAAe,EAAE,iBAAiB,CAAC,CAAC;QAC3F,SAAS,CAAC,IAAI,CAAC,GAAG,cAAc,CAAC,CAAC;QAElC,mCAAmC;QACnC,QAAQ,CAAC,UAAU,CAAC,iBAAiB,CAAC,GAAG,YAAY,CAAC;QAEtD,yBAAyB;QACzB,MAAM,YAAY,GAAG,YAAY,CAAC,MAAM,CACtC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,MAAM,KAAK,MAAM,IAAI,CAAC,CAAC,UAAU,KAAK,kBAAkB,CAClE,CAAC;QACF,MAAM,eAAe,GAAG,iBAAiB,CAAC,MAAM,KAAK,MAAM,CAAC;QAC5D,MAAM,WAAW,GAAG,QAAQ,CAAC,SAAS,CAAC,IAAI,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,IAAI,KAAK,cAAc,CAAC,CAAC;QAC9E,MAAM,MAAM,GAAG,YAAY,CAAC,MAAM,KAAK,CAAC,IAAI,WAAW,CAAC;QAExD,wCAAwC;QACxC,MAAM,MAAM,GAAG;YACb,+BAA+B;YAC/B,EAAE;YACF,kBAAkB,IAAI,IAAI,EAAE,CAAC,WAAW,EAAE,EAAE;YAC5C,gBAAgB,MAAM,CAAC,CAAC,CAAC,MAAM,CAAC,CAAC,CAAC,MAAM,EAAE;YAC1C,EAAE;YACF,kBAAkB;YAClB,EAAE;YACF,GAAG,YAAY,CAAC,GAAG,CAAC,CAAC,CAAC,EAAE,EAAE,CACxB,OAAO,CAAC,CAAC,UAAU,OAAO,CAAC,CAAC,MAAM,IAAI,CAAC,CAAC,WAAW,GAAG,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC,CAAC,WAAW,KAAK,CAAC,CAAC,CAAC,EAAE,EAAE,CACxF;YACD,EAAE;YACF,eAAe,CAAC,CAAC,CAAC,4CAA4C,GAAG,CAAC,iBAAiB,CAAC,cAAc,IAAI,EAAE,CAAC,CAAC,CAAC,CAAC,EAAE;YAC9G,EAAE;YACF,gBAAgB;YAChB,YAAY,eAAe,CAAC,YAAY,EAAE,OAAO,CAAC,EAAE;YACpD,YAAY,eAAe,CAAC,YAAY,EAAE,MAAM,CAAC,EAAE;YACnD,WAAW,eAAe,CAAC,YAAY,EAAE,MAAM,CAAC,EAAE;YAClD,gBAAgB,eAAe,CAAC,YAAY,EAAE,WAAW,CAAC,EAAE;YAC5D,UAAU,eAAe,CAAC,YAAY,EAAE,WAAW,CAAC,EAAE;YACtD,YAAY,eAAe,CAAC,YAAY,EAAE,OAAO,CAAC,EAAE;YACpD,YAAY,WAAW,CAAC,CAAC,CAAC,MAAM,CAAC,CAAC,CAAC,SAAS,EAAE;YAC9C,mBAAmB,eAAe,CAAC,CAAC,CAAC,SAAS,CAAC,CAAC,CAAC,OAAO,EAAE;SAC3D,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;QAEb,MAAM,WAAW,GAAG,eAAe,CAAC,kBAAkB,CACpD,sBAAsB,EACtB,MAAM,EACN,iBAAiB,CAClB,CAAC;QACF,SAAS,CAAC,IAAI,CAAC,WAAW,CAAC,CAAC;QAE5B,QAAQ,CAAC,SAAS,CAAC,IAAI,CAAC,GAAG,SAAS,CAAC,CAAC;QAEtC,yBAAyB;QACzB,MAAM,iBAAiB,CAAC,iBAAiB,EAAE,SAAS,EAAE,OAAO,CAAC,CAAC;QAE/D,OAAO,aAAa,CAClB,iBAAiB,EACjB,SAAS,EACT,MAAM,CAAC,CAAC,CAAC,sBAAsB,CAAC,CAAC,CAAC,yBAAyB,YAAY,CAAC,MAAM,gBAAgB,CAC/F,CAAC;IACJ,CAAC;IAAC,OAAO,GAAG,EAAE,CAAC;QACb,MAAM,OAAO,GAAG,GAAG,YAAY,KAAK,CAAC,CAAC,CAAC,GAAG,CAAC,OAAO,CAAC,CAAC,CAAC,eAAe,CAAC;QACrE,OAAO,aAAa,CAAC,iBAAiB,EAAE,wBAAwB,EAAE,OAAO,CAAC,CAAC;IAC7E,CAAC;AACH,CAAC;AAED,SAAS,eAAe,CACtB,OAAiD,EACjD,IAAY;IAEZ,MAAM,CAAC,GAAG,OAAO,CAAC,IAAI,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,UAAU,KAAK,IAAI,CAAC,CAAC;IACrD,IAAI,CAAC,CAAC;QAAE,OAAO,MAAM,CAAC;IACtB,OAAO,CAAC,CAAC,MAAM,CAAC,WAAW,EAAE,CAAC;AAChC,CAAC"}
+{"version":3,"file":"production-gate.js","sourceRoot":"","sources":["../../../src/pipeline/phases/production-gate.ts"],"names":[],"mappings":"AAAA;;;;GAIG;AAEH,OAAO,EAAE,IAAI,EAAE,MAAM,WAAW,CAAC;AACjC,OAAO,EAAE,UAAU,EAAE,MAAM,SAAS,CAAC;AAGrC,OAAO,EAAE,aAAa,EAAE,aAAa,EAAE,iBAAiB,EAAE,MAAM,oBAAoB,CAAC;AACrF,OAAO,EAAE,eAAe,EAAE,MAAM,wBAAwB,CAAC;AACzD,OAAO,EACL,YAAY,EACZ,kBAAkB,EAClB,aAAa,EACb,WAAW,EACX,QAAQ,EACR,iBAAiB,EACjB,iBAAiB,EACjB,kBAAkB,GACnB,MAAM,oBAAoB,CAAC;AAC5B,OAAO,EAAE,oBAAoB,EAAE,MAAM,qBAAqB,CAAC;AAE3D,MAAM,CAAC,KAAK,UAAU,iBAAiB,CAAC,OAAqB;IAC3D,MAAM,EAAE,QAAQ,EAAE,eAAe,EAAE,UAAU,EAAE,GAAG,OAAO,CAAC;IAC1D,MAAM,SAAS,GAAG,EAAE,CAAC;IAErB,IAAI,CAAC;QACH,oCAAoC;QACpC,MAAM,QAAQ,GAAG,MAAM,oBAAoB,CAAC,UAAU,CAAC,CAAC;QACxD,MAAM,QAAQ,GAAG,eAAe,CAAC,QAAQ,CAAC,CAAC;QAC3C,QAAQ,CAAC,gBAAgB,GAAG,QAAQ,CAAC;QAErC,+EAA+E;QAC/E,IAAI,QAAQ,CAAC,OAAO,EAAE,CAAC;YACrB,MAAM,UAAU,GAAG,QAAQ,CAAC,WAAW;gBACrC,CAAC,CAAC,IAAI,CAAC,UAAU,EAAE,QAAQ,CAAC,WAAW,CAAC;gBACxC,CAAC,CAAC,UAAU,CAAC;YACf,MAAM,WAAW,GAAG,iBAAiB,CAAC,UAAU,EAAE,QAAQ,CAAC,CAAC;YAC5D,IAAI,CAAC,WAAW,EAAE,CAAC;gBACjB,MAAM,aAAa,GAAG,MAAM,QAAQ,CAAC,SAAS,EAAE,QAAQ,CAAC,OAAO,EAAE,UAAU,CAAC,CAAC;gBAC9E,IAAI,aAAa,CAAC,MAAM,KAAK,MAAM,EAAE,CAAC;oBACpC,MAAM,MAAM,GAAG,iBAAiB,CAAC,CAAC,aAAa,CAAC,EAAE,eAAe,EAAE,iBAAiB,CAAC,CAAC;oBACtF,SAAS,CAAC,IAAI,CAAC,GAAG,MAAM,CAAC,CAAC;oBAC1B,QAAQ,CAAC,SAAS,CAAC,IAAI,CAAC,GAAG,SAAS,CAAC,CAAC;oBACtC,QAAQ,CAAC,UAAU,CAAC,iBAAiB,CAAC,GAAG,CAAC,aAAa,CAAC,CAAC;oBACzD,OAAO,aAAa,CAAC,iBAAiB,EAAE,gCAAgC,EAAE,aAAa,CAAC,cAAc,IAAI,EAAE,CAAC,CAAC;gBAChH,CAAC;gBACD,kBAAkB,CAAC,UAAU,EAAE,QAAQ,CAAC,CAAC;YAC3C,CAAC;QACH,CAAC;QAED,oBAAoB;QACpB,MAAM,YAAY,GAAG,MAAM,YAAY,CAAC,QAAQ,EAAE,UAAU,CAAC,CAAC;QAE9D,iCAAiC;QACjC,MAAM,iBAAiB,GAAG,kBAAkB,CAAC,UAAU,CAAC,CAAC;QACzD,YAAY,CAAC,IAAI,CAAC,iBAAiB,CAAC,CAAC;QAErC,0BAA0B;QAC1B,MAAM,SAAS,GAAG,WAAW,CAAC,UAAU,EAAE,QAAQ,CAAC,CAAC;QACpD,YAAY,CAAC,IAAI,CAAC,SAAS,CAAC,CAAC;QAE7B,oDAAoD;QACpD,IAAI,QAAQ,CAAC,KAAK,EAAE,CAAC;YACnB,MAAM,WAAW,GAAG,MAAM,aAAa,CAAC,QAAQ,CAAC,KAAK,EAAE,UAAU,EAAE;gBAClE,IAAI,EAAE,QAAQ,CAAC,iBAAiB,CAAC,CAAC,CAAC,EAAE,IAAI;aAC1C,CAAC,CAAC;YACH,YAAY,CAAC,IAAI,CAAC,WAAW,CAAC,CAAC;QACjC,CAAC;QAED,sCAAsC;QACtC,MAAM,cAAc,GAAG,iBAAiB,CAAC,YAAY,EAAE,eAAe,EAAE,iBAAiB,CAAC,CAAC;QAC3F,SAAS,CAAC,IAAI,CAAC,GAAG,cAAc,CAAC,CAAC;QAElC,mCAAmC;QACnC,QAAQ,CAAC,UAAU,CAAC,iBAAiB,CAAC,GAAG,YAAY,CAAC;QAEtD,yBAAyB;QACzB,MAAM,YAAY,GAAG,YAAY,CAAC,MAAM,CACtC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,MAAM,KAAK,MAAM,IAAI,CAAC,CAAC,UAAU,KAAK,kBAAkB,CAClE,CAAC;QACF,MAAM,eAAe,GAAG,iBAAiB,CAAC,MAAM,KAAK,MAAM,CAAC;QAC5D,MAAM,WAAW,GAAG,QAAQ,CAAC,SAAS,CAAC,IAAI,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,IAAI,KAAK,cAAc,CAAC,CAAC;QAE9E,8DAA8D;QAC9D,MAAM,gBAAgB,GACpB,UAAU,CAAC,IAAI,CAAC,UAAU,EAAE,iBAAiB,CAAC,CAAC;YAC/C,UAAU,CAAC,IAAI,CAAC,UAAU,EAAE,gBAAgB,CAAC,CAAC;YAC9C,UAAU,CAAC,IAAI,CAAC,UAAU,EAAE,KAAK,EAAE,KAAK,EAAE,YAAY,CAAC,CAAC,CAAC;QAC3D,MAAM,mBAAmB,GAAG,eAAe,IAAI,gBAAgB,CAAC;QAChE,MAAM,MAAM,GAAG,YAAY,CAAC,MAAM,KAAK,CAAC,IAAI,WAAW,IAAI,CAAC,mBAAmB,CAAC;QAEhF,wCAAwC;QACxC,MAAM,MAAM,GAAG;YACb,+BAA+B;YAC/B,EAAE;YACF,kBAAkB,IAAI,IAAI,EAAE,CAAC,WAAW,EAAE,EAAE;YAC5C,gBAAgB,MAAM,CAAC,CAAC,CAAC,MAAM,CAAC,CAAC,CAAC,MAAM,EAAE;YAC1C,EAAE;YACF,kBAAkB;YAClB,EAAE;YACF,GAAG,YAAY,CAAC,GAAG,CAAC,CAAC,CAAC,EAAE,EAAE,CACxB,OAAO,CAAC,CAAC,UAAU,OAAO,CAAC,CAAC,MAAM,IAAI,CAAC,CAAC,WAAW,GAAG,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC,CAAC,WAAW,KAAK,CAAC,CAAC,CAAC,EAAE,EAAE,CACxF;YACD,EAAE;YACF,eAAe,CAAC,CAAC,CAAC,4CAA4C,GAAG,CAAC,iBAAiB,CAAC,cAAc,IAAI,EAAE,CAAC,CAAC,CAAC,CAAC,EAAE;YAC9G,EAAE;YACF,gBAAgB;YAChB,YAAY,eAAe,CAAC,YAAY,EAAE,OAAO,CAAC,EAAE;YACpD,YAAY,eAAe,CAAC,YAAY,EAAE,MAAM,CAAC,EAAE;YACnD,WAAW,eAAe,CAAC,YAAY,EAAE,MAAM,CAAC,EAAE;YAClD,gBAAgB,eAAe,CAAC,YAAY,EAAE,WAAW,CAAC,EAAE;YAC5D,UAAU,eAAe,CAAC,YAAY,EAAE,WAAW,CAAC,EAAE;YACtD,YAAY,eAAe,CAAC,YAAY,EAAE,OAAO,CAAC,EAAE;YACpD,YAAY,WAAW,CAAC,CAAC,CAAC,MAAM,CAAC,CAAC,CAAC,SAAS,EAAE;YAC9C,mBAAmB,eAAe,CAAC,CAAC,CAAC,CAAC,mBAAmB,CAAC,CAAC,CAAC,6BAA6B,CAAC,CAAC,CAAC,SAAS,CAAC,CAAC,CAAC,CAAC,OAAO,EAAE;SACnH,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;QAEb,MAAM,WAAW,GAAG,eAAe,CAAC,kBAAkB,CACpD,sBAAsB,EACtB,MAAM,EACN,iBAAiB,CAClB,CAAC;QACF,SAAS,CAAC,IAAI,CAAC,WAAW,CAAC,CAAC;QAE5B,QAAQ,CAAC,SAAS,CAAC,IAAI,CAAC,GAAG,SAAS,CAAC,CAAC;QAEtC,yBAAyB;QACzB,MAAM,iBAAiB,CAAC,iBAAiB,EAAE,SAAS,EAAE,OAAO,CAAC,CAAC;QAE/D,OAAO,aAAa,CAClB,iBAAiB,EACjB,SAAS,EACT,MAAM,CAAC,CAAC,CAAC,sBAAsB,CAAC,CAAC,CAAC,yBAAyB,YAAY,CAAC,MAAM,gBAAgB,CAC/F,CAAC;IACJ,CAAC;IAAC,OAAO,GAAG,EAAE,CAAC;QACb,MAAM,OAAO,GAAG,GAAG,YAAY,KAAK,CAAC,CAAC,CAAC,GAAG,CAAC,OAAO,CAAC,CAAC,CAAC,eAAe,CAAC;QACrE,OAAO,aAAa,CAAC,iBAAiB,EAAE,wBAAwB,EAAE,OAAO,CAAC,CAAC;IAC7E,CAAC;AACH,CAAC;AAED,SAAS,eAAe,CACtB,OAAiD,EACjD,IAAY;IAEZ,MAAM,CAAC,GAAG,OAAO,CAAC,IAAI,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,UAAU,KAAK,IAAI,CAAC,CAAC;IACrD,IAAI,CAAC,CAAC;QAAE,OAAO,MAAM,CAAC;IACtB,OAAO,CAAC,CAAC,MAAM,CAAC,WAAW,EAAE,CAAC;AAChC,CAAC"}

package/dist/pipeline/phases/qa-validation.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"qa-validation.d.ts","sourceRoot":"","sources":["../../../src/pipeline/phases/qa-validation.ts"],"names":[],"mappings":"AAAA;;;GAGG;AAEH,OAAO,KAAK,EAAE,YAAY,EAAE,WAAW,EAAE,MAAM,oBAAoB,CAAC;AAMpE,wBAAsB,eAAe,CAAC,OAAO,EAAE,YAAY,GAAG,OAAO,CAAC,WAAW,CAAC,CAmDjF"}
+{"version":3,"file":"qa-validation.d.ts","sourceRoot":"","sources":["../../../src/pipeline/phases/qa-validation.ts"],"names":[],"mappings":"AAAA;;;GAGG;AAIH,OAAO,KAAK,EAAE,YAAY,EAAE,WAAW,EAAE,MAAM,oBAAoB,CAAC;AAYpE,wBAAsB,eAAe,CAAC,OAAO,EAAE,YAAY,GAAG,OAAO,CAAC,WAAW,CAAC,CAyFjF"}

package/dist/pipeline/phases/qa-validation.js

@@ -2,19 +2,44 @@
  * QA_VALIDATION phase — execute QA plan and validate critical paths.
  * Runs tests via checkRunner. Creates qa_validation artifact.
  */
+import { join } from 'node:path';
 import { successResult, failureResult } from './phase-context.js';
 import { resolveCommands } from '../command-resolver.js';
-import { runCheck, storeCheckResults } from '../check-runner.js';
+import { runCheck, storeCheckResults, shouldSkipInstall, writeInstallMarker, invalidateInstallMarker, } from '../check-runner.js';
 import { generateRepoSnapshot } from '../repo-snapshot.js';
 export async function runQaValidation(context) {
-    const { pipeline, artifactManager, projectDir } = context;
+    const { pipeline, artifactManager, skillLoader, skillUsageRegistry, projectDir } = context;
     const artifacts = [];
     try {
-        // 1. Resolve test command
+        // 1. Load QA_TESTER skill and record usage
+        const { definition: _qaSkill, meta: qaMeta } = skillLoader.loadSkillWithMeta('QA_TESTER');
+        skillUsageRegistry.record('QA_TESTER', 'QA_VALIDATION', 'system_prompt', qaMeta.source, qaMeta.version);
+        // 2. Resolve test command
         const snapshot = await generateRepoSnapshot(projectDir);
         const commands = resolveCommands(snapshot);
         pipeline.resolvedCommands = commands;
-        // 2. Run test command
+        // 2.5. Install dependencies if needed
+        if (commands.install) {
+            const installCwd = commands.install_cwd
+                ? join(projectDir, commands.install_cwd)
+                : projectDir;
+            const skipInstall = shouldSkipInstall(projectDir, snapshot);
+            if (!skipInstall) {
+                const installResult = await runCheck('install', commands.install, installCwd);
+                const stored = storeCheckResults([installResult], artifactManager, 'QA_VALIDATION');
+                artifacts.push(...stored);
+                if (!pipeline.gateChecks['QA_VALIDATION']) {
+                    pipeline.gateChecks['QA_VALIDATION'] = [];
+                }
+                pipeline.gateChecks['QA_VALIDATION'].push(installResult);
+                if (installResult.status === 'fail') {
+                    pipeline.artifacts.push(...artifacts);
+                    return failureResult('QA_VALIDATION', 'Dependency installation failed', installResult.stderr_summary ?? '');
+                }
+                writeInstallMarker(projectDir, snapshot);
+            }
+        }
+        // 3. Run test command
         if (commands.test) {
             const testResult = await runCheck('test', commands.test, projectDir);
             const stored = storeCheckResults([testResult], artifactManager, 'QA_VALIDATION');
@@ -24,8 +49,16 @@ export async function runQaValidation(context) {
                 pipeline.gateChecks['QA_VALIDATION'] = [];
             }
             pipeline.gateChecks['QA_VALIDATION'].push(testResult);
+            // Invalidate install marker on missing-module errors
+            if (testResult.status === 'fail' && testResult.stderr_summary) {
+                const missingModule = /Cannot find module|ModuleNotFoundError|Failed to resolve import/
+                    .test(testResult.stderr_summary);
+                if (missingModule) {
+                    invalidateInstallMarker(projectDir);
+                }
+            }
         }
-        // 3. Create QA validation summary artifact
+        // 4. Create QA validation summary artifact
         const qaReport = [
             '# QA Validation Report',
             '',

package/dist/pipeline/phases/qa-validation.js.map

@@ -1 +1 @@
-{"version":3,"file":"qa-validation.js","sourceRoot":"","sources":["../../../src/pipeline/phases/qa-validation.ts"],"names":[],"mappings":"AAAA;;;GAGG;AAGH,OAAO,EAAE,aAAa,EAAE,aAAa,EAAE,MAAM,oBAAoB,CAAC;AAClE,OAAO,EAAE,eAAe,EAAE,MAAM,wBAAwB,CAAC;AACzD,OAAO,EAAE,QAAQ,EAAE,iBAAiB,EAAE,MAAM,oBAAoB,CAAC;AACjE,OAAO,EAAE,oBAAoB,EAAE,MAAM,qBAAqB,CAAC;AAE3D,MAAM,CAAC,KAAK,UAAU,eAAe,CAAC,OAAqB;IACzD,MAAM,EAAE,QAAQ,EAAE,eAAe,EAAE,UAAU,EAAE,GAAG,OAAO,CAAC;IAC1D,MAAM,SAAS,GAAG,EAAE,CAAC;IAErB,IAAI,CAAC;QACH,0BAA0B;QAC1B,MAAM,QAAQ,GAAG,MAAM,oBAAoB,CAAC,UAAU,CAAC,CAAC;QACxD,MAAM,QAAQ,GAAG,eAAe,CAAC,QAAQ,CAAC,CAAC;QAC3C,QAAQ,CAAC,gBAAgB,GAAG,QAAQ,CAAC;QAErC,sBAAsB;QACtB,IAAI,QAAQ,CAAC,IAAI,EAAE,CAAC;YAClB,MAAM,UAAU,GAAG,MAAM,QAAQ,CAAC,MAAM,EAAE,QAAQ,CAAC,IAAI,EAAE,UAAU,CAAC,CAAC;YACrE,MAAM,MAAM,GAAG,iBAAiB,CAAC,CAAC,UAAU,CAAC,EAAE,eAAe,EAAE,eAAe,CAAC,CAAC;YACjF,SAAS,CAAC,IAAI,CAAC,GAAG,MAAM,CAAC,CAAC;YAE1B,gCAAgC;YAChC,IAAI,CAAC,QAAQ,CAAC,UAAU,CAAC,eAAe,CAAC,EAAE,CAAC;gBAC1C,QAAQ,CAAC,UAAU,CAAC,eAAe,CAAC,GAAG,EAAE,CAAC;YAC5C,CAAC;YACD,QAAQ,CAAC,UAAU,CAAC,eAAe,CAAC,CAAC,IAAI,CAAC,UAAU,CAAC,CAAC;QACxD,CAAC;QAED,2CAA2C;QAC3C,MAAM,QAAQ,GAAG;YACf,wBAAwB;YACxB,EAAE;YACF,kBAAkB,IAAI,IAAI,EAAE,CAAC,WAAW,EAAE,EAAE;YAC5C,qBAAqB,QAAQ,CAAC,IAAI,IAAI,MAAM,EAAE;YAC9C,oBAAoB,QAAQ,CAAC,UAAU,CAAC,eAAe,CAAC,EAAE,CAAC,CAAC,CAAC,EAAE,MAAM,IAAI,MAAM,EAAE;YACjF,EAAE;YACF,YAAY;YACZ,EAAE;YACF,QAAQ,CAAC,UAAU,CAAC,eAAe,CAAC,EAAE,GAAG,CAAC,CAAC,CAAC,EAAE,EAAE,CAC9C,KAAK,CAAC,CAAC,UAAU,KAAK,CAAC,CAAC,MAAM,KAAK,CAAC,CAAC,WAAW,KAAK,CACtD,CAAC,IAAI,CAAC,IAAI,CAAC,IAAI,eAAe;SAChC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;QAEb,MAAM,OAAO,GAAG,eAAe,CAAC,kBAAkB,CAChD,eAAe,EACf,QAAQ,EACR,eAAe,CAChB,CAAC;QACF,SAAS,CAAC,IAAI,CAAC,OAAO,CAAC,CAAC;QAExB,QAAQ,CAAC,SAAS,CAAC,IAAI,CAAC,GAAG,SAAS,CAAC,CAAC;QACtC,OAAO,aAAa,CAAC,eAAe,EAAE,SAAS,EAAE,wBAAwB,CAAC,CAAC;IAC7E,CAAC;IAAC,OAAO,GAAG,EAAE,CAAC;QACb,MAAM,OAAO,GAAG,GAAG,YAAY,KAAK,CAAC,CAAC,CAAC,GAAG,CAAC,OAAO,CAAC,CAAC,CAAC,eAAe,CAAC;QACrE,OAAO,aAAa,CAAC,eAAe,EAAE,sBAAsB,EAAE,OAAO,CAAC,CAAC;IACzE,CAAC;AACH,CAAC"}
+{"version":3,"file":"qa-validation.js","sourceRoot":"","sources":["../../../src/pipeline/phases/qa-validation.ts"],"names":[],"mappings":"AAAA;;;GAGG;AAEH,OAAO,EAAE,IAAI,EAAE,MAAM,WAAW,CAAC;AAGjC,OAAO,EAAE,aAAa,EAAE,aAAa,EAAE,MAAM,oBAAoB,CAAC;AAClE,OAAO,EAAE,eAAe,EAAE,MAAM,wBAAwB,CAAC;AACzD,OAAO,EACL,QAAQ,EACR,iBAAiB,EACjB,iBAAiB,EACjB,kBAAkB,EAClB,uBAAuB,GACxB,MAAM,oBAAoB,CAAC;AAC5B,OAAO,EAAE,oBAAoB,EAAE,MAAM,qBAAqB,CAAC;AAE3D,MAAM,CAAC,KAAK,UAAU,eAAe,CAAC,OAAqB;IACzD,MAAM,EAAE,QAAQ,EAAE,eAAe,EAAE,WAAW,EAAE,kBAAkB,EAAE,UAAU,EAAE,GAAG,OAAO,CAAC;IAC3F,MAAM,SAAS,GAAG,EAAE,CAAC;IAErB,IAAI,CAAC;QACH,2CAA2C;QAC3C,MAAM,EAAE,UAAU,EAAE,QAAQ,EAAE,IAAI,EAAE,MAAM,EAAE,GAAG,WAAW,CAAC,iBAAiB,CAAC,WAAW,CAAC,CAAC;QAC1F,kBAAkB,CAAC,MAAM,CAAC,WAAW,EAAE,eAAe,EAAE,eAAe,EAAE,MAAM,CAAC,MAAM,EAAE,MAAM,CAAC,OAAO,CAAC,CAAC;QAExG,0BAA0B;QAC1B,MAAM,QAAQ,GAAG,MAAM,oBAAoB,CAAC,UAAU,CAAC,CAAC;QACxD,MAAM,QAAQ,GAAG,eAAe,CAAC,QAAQ,CAAC,CAAC;QAC3C,QAAQ,CAAC,gBAAgB,GAAG,QAAQ,CAAC;QAErC,sCAAsC;QACtC,IAAI,QAAQ,CAAC,OAAO,EAAE,CAAC;YACrB,MAAM,UAAU,GAAG,QAAQ,CAAC,WAAW;gBACrC,CAAC,CAAC,IAAI,CAAC,UAAU,EAAE,QAAQ,CAAC,WAAW,CAAC;gBACxC,CAAC,CAAC,UAAU,CAAC;YACf,MAAM,WAAW,GAAG,iBAAiB,CAAC,UAAU,EAAE,QAAQ,CAAC,CAAC;YAC5D,IAAI,CAAC,WAAW,EAAE,CAAC;gBACjB,MAAM,aAAa,GAAG,MAAM,QAAQ,CAAC,SAAS,EAAE,QAAQ,CAAC,OAAO,EAAE,UAAU,CAAC,CAAC;gBAC9E,MAAM,MAAM,GAAG,iBAAiB,CAAC,CAAC,aAAa,CAAC,EAAE,eAAe,EAAE,eAAe,CAAC,CAAC;gBACpF,SAAS,CAAC,IAAI,CAAC,GAAG,MAAM,CAAC,CAAC;gBAE1B,IAAI,CAAC,QAAQ,CAAC,UAAU,CAAC,eAAe,CAAC,EAAE,CAAC;oBAC1C,QAAQ,CAAC,UAAU,CAAC,eAAe,CAAC,GAAG,EAAE,CAAC;gBAC5C,CAAC;gBACD,QAAQ,CAAC,UAAU,CAAC,eAAe,CAAC,CAAC,IAAI,CAAC,aAAa,CAAC,CAAC;gBAEzD,IAAI,aAAa,CAAC,MAAM,KAAK,MAAM,EAAE,CAAC;oBACpC,QAAQ,CAAC,SAAS,CAAC,IAAI,CAAC,GAAG,SAAS,CAAC,CAAC;oBACtC,OAAO,aAAa,CAAC,eAAe,EAAE,gCAAgC,EAAE,aAAa,CAAC,cAAc,IAAI,EAAE,CAAC,CAAC;gBAC9G,CAAC;gBAED,kBAAkB,CAAC,UAAU,EAAE,QAAQ,CAAC,CAAC;YAC3C,CAAC;QACH,CAAC;QAED,sBAAsB;QACtB,IAAI,QAAQ,CAAC,IAAI,EAAE,CAAC;YAClB,MAAM,UAAU,GAAG,MAAM,QAAQ,CAAC,MAAM,EAAE,QAAQ,CAAC,IAAI,EAAE,UAAU,CAAC,CAAC;YACrE,MAAM,MAAM,GAAG,iBAAiB,CAAC,CAAC,UAAU,CAAC,EAAE,eAAe,EAAE,eAAe,CAAC,CAAC;YACjF,SAAS,CAAC,IAAI,CAAC,GAAG,MAAM,CAAC,CAAC;YAE1B,gCAAgC;YAChC,IAAI,CAAC,QAAQ,CAAC,UAAU,CAAC,eAAe,CAAC,EAAE,CAAC;gBAC1C,QAAQ,CAAC,UAAU,CAAC,eAAe,CAAC,GAAG,EAAE,CAAC;YAC5C,CAAC;YACD,QAAQ,CAAC,UAAU,CAAC,eAAe,CAAC,CAAC,IAAI,CAAC,UAAU,CAAC,CAAC;YAEtD,qDAAqD;YACrD,IAAI,UAAU,CAAC,MAAM,KAAK,MAAM,IAAI,UAAU,CAAC,cAAc,EAAE,CAAC;gBAC9D,MAAM,aAAa,GAAG,iEAAiE;qBACpF,IAAI,CAAC,UAAU,CAAC,cAAc,CAAC,CAAC;gBACnC,IAAI,aAAa,EAAE,CAAC;oBAClB,uBAAuB,CAAC,UAAU,CAAC,CAAC;gBACtC,CAAC;YACH,CAAC;QACH,CAAC;QAED,2CAA2C;QAC3C,MAAM,QAAQ,GAAG;YACf,wBAAwB;YACxB,EAAE;YACF,kBAAkB,IAAI,IAAI,EAAE,CAAC,WAAW,EAAE,EAAE;YAC5C,qBAAqB,QAAQ,CAAC,IAAI,IAAI,MAAM,EAAE;YAC9C,oBAAoB,QAAQ,CAAC,UAAU,CAAC,eAAe,CAAC,EAAE,CAAC,CAAC,CAAC,EAAE,MAAM,IAAI,MAAM,EAAE;YACjF,EAAE;YACF,YAAY;YACZ,EAAE;YACF,QAAQ,CAAC,UAAU,CAAC,eAAe,CAAC,EAAE,GAAG,CAAC,CAAC,CAAC,EAAE,EAAE,CAC9C,KAAK,CAAC,CAAC,UAAU,KAAK,CAAC,CAAC,MAAM,KAAK,CAAC,CAAC,WAAW,KAAK,CACtD,CAAC,IAAI,CAAC,IAAI,CAAC,IAAI,eAAe;SAChC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;QAEb,MAAM,OAAO,GAAG,eAAe,CAAC,kBAAkB,CAChD,eAAe,EACf,QAAQ,EACR,eAAe,CAChB,CAAC;QACF,SAAS,CAAC,IAAI,CAAC,OAAO,CAAC,CAAC;QAExB,QAAQ,CAAC,SAAS,CAAC,IAAI,CAAC,GAAG,SAAS,CAAC,CAAC;QACtC,OAAO,aAAa,CAAC,eAAe,EAAE,SAAS,EAAE,wBAAwB,CAAC,CAAC;IAC7E,CAAC;IAAC,OAAO,GAAG,EAAE,CAAC;QACb,MAAM,OAAO,GAAG,GAAG,YAAY,KAAK,CAAC,CAAC,CAAC,GAAG,CAAC,OAAO,CAAC,CAAC,CAAC,eAAe,CAAC;QACrE,OAAO,aAAa,CAAC,eAAe,EAAE,sBAAsB,EAAE,OAAO,CAAC,CAAC;IACzE,CAAC;AACH,CAAC"}

package/dist/pipeline/phases/recovery-loop.d.ts

@@ -1,6 +1,8 @@
 /**
  * RECOVERY_LOOP phase — self-heal using RCA, not guesswork.
  * Routes via requires_phase_rewind_to (P1-3). Max 5 iterations.
+ * v2.1: Extracts reviewer feedback from consensus failures and
+ *       builds structured revision directive for sessionGuidance.
  */
 import type { PhaseContext, PhaseResult } from './phase-context.js';
 export declare function runRecoveryLoop(context: PhaseContext): Promise<PhaseResult>;

package/dist/pipeline/phases/recovery-loop.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"recovery-loop.d.ts","sourceRoot":"","sources":["../../../src/pipeline/phases/recovery-loop.ts"],"names":[],"mappings":"AAAA;;;GAGG;AAGH,OAAO,KAAK,EAAE,YAAY,EAAE,WAAW,EAAE,MAAM,oBAAoB,CAAC;AAIpE,wBAAsB,eAAe,CAAC,OAAO,EAAE,YAAY,GAAG,OAAO,CAAC,WAAW,CAAC,CAwFjF"}
+{"version":3,"file":"recovery-loop.d.ts","sourceRoot":"","sources":["../../../src/pipeline/phases/recovery-loop.ts"],"names":[],"mappings":"AAAA;;;;;GAKG;AAMH,OAAO,KAAK,EAAE,YAAY,EAAE,WAAW,EAAE,MAAM,oBAAoB,CAAC;AAIpE,wBAAsB,eAAe,CAAC,OAAO,EAAE,YAAY,GAAG,OAAO,CAAC,WAAW,CAAC,CA6KjF"}

package/dist/pipeline/phases/recovery-loop.js

@@ -1,19 +1,38 @@
 /**
  * RECOVERY_LOOP phase — self-heal using RCA, not guesswork.
  * Routes via requires_phase_rewind_to (P1-3). Max 5 iterations.
+ * v2.1: Extracts reviewer feedback from consensus failures and
+ *       builds structured revision directive for sessionGuidance.
  */
+import { existsSync, unlinkSync } from 'node:fs';
+import { join } from 'node:path';
 import { successResult, failureResult, triggerJournalist } from './phase-context.js';
 import { buildRCAPacket } from '../packets/rca-packet-builder.js';
 export async function runRecoveryLoop(context) {
-    const { pipeline, artifactManager, skillLoader } = context;
+    const { pipeline, artifactManager, skillLoader, skillUsageRegistry } = context;
     const artifacts = [];
     try {
-        // 1. Load debugger skill
-        const debuggerSkill = skillLoader.loadSkill('DEBUGGER');
+        // 1. Load debugger skill with metadata
+        const { definition: debuggerSkill, meta: debuggerMeta } = skillLoader.loadSkillWithMeta('DEBUGGER');
         // 2. Gather failure evidence
         const failedPhase = pipeline.failedPhase;
         const failedGateResult = failedPhase ? pipeline.gateResults[failedPhase] : undefined;
         const failedChecks = failedPhase ? pipeline.gateChecks[failedPhase] ?? [] : [];
+        // 2a. Detect missing module errors in stderr — invalidate install marker
+        const combinedStderr = failedChecks
+            .filter((c) => c.status === 'fail')
+            .map((c) => c.stderr_summary ?? '')
+            .join('\n');
+        const missingModule = /Cannot find module|ModuleNotFoundError|Failed to resolve import/
+            .test(combinedStderr);
+        if (missingModule) {
+            try {
+                const markerPath = join(context.projectDir, '.popeye', 'install-marker.json');
+                if (existsSync(markerPath))
+                    unlinkSync(markerPath);
+            }
+            catch { /* non-fatal */ }
+        }
         const failureEvidence = [
             `Failed phase: ${failedPhase ?? 'unknown'}`,
             failedGateResult
@@ -23,6 +42,47 @@ export async function runRecoveryLoop(context) {
                 ? `Failed checks: ${failedChecks.filter((c) => c.status === 'fail').map((c) => `${c.check_type}: ${c.stderr_summary?.slice(0, 200) ?? 'no details'}`).join('; ')}`
                 : 'No check failures',
         ].join('\n');
+        // 2b. For consensus failures, build revision directive from reviewer feedback
+        if (failedPhase?.startsWith('CONSENSUS_')) {
+            const directive = buildRevisionDirective(pipeline, failedPhase);
+            if (directive) {
+                const existing = pipeline.sessionGuidance ?? '';
+                const marker = '--- REVISION DIRECTIVE ---';
+                const base = existing.includes(marker)
+                    ? existing.slice(0, existing.indexOf(marker)).trim()
+                    : existing;
+                pipeline.sessionGuidance = [base, '', marker, directive.slice(0, 3000)].join('\n').trim();
+            }
+        }
+        // 2c. For QA/build failures, build a targeted fix directive from test stderr
+        // so the implementation phase knows exactly what to fix on rewind.
+        if (failedPhase === 'QA_VALIDATION' || failedPhase === 'PRODUCTION_GATE'
+            || failedPhase === 'IMPLEMENTATION') {
+            const failedCheckDetails = failedChecks
+                .filter((c) => c.status === 'fail')
+                .map((c) => [
+                `**${c.check_type}** (exit code ${c.exit_code}):`,
+                `Command: \`${c.command}\``,
+                c.stderr_summary ? c.stderr_summary.slice(0, 500) : 'No stderr captured',
+            ].join('\n'))
+                .join('\n\n');
+            if (failedCheckDetails) {
+                const existing = pipeline.sessionGuidance ?? '';
+                const marker = '--- QA FIX DIRECTIVE ---';
+                const base = existing.includes(marker)
+                    ? existing.slice(0, existing.indexOf(marker)).trim()
+                    : existing;
+                const directive = [
+                    `Fix the following failures (recovery iteration ${pipeline.recoveryCount}):`,
+                    '',
+                    failedCheckDetails,
+                    '',
+                    'Apply targeted fixes only. Do not rewrite code that already works.',
+                ].join('\n');
+                pipeline.sessionGuidance = [base, '', marker, directive.slice(0, 3000)]
+                    .join('\n').trim();
+            }
+        }
         // 3. Generate RCA via Claude with Debugger skill
         const { executePrompt } = await import('../../adapters/claude.js');
         const guidance = pipeline.sessionGuidance;
@@ -44,6 +104,26 @@ export async function runRecoveryLoop(context) {
         ].join('\n');
         const rcaResult = await executePrompt(rcaPrompt);
         const rcaResponse = rcaResult.response;
+        // Record skill usage — debugger skill injected into RCA prompt
+        skillUsageRegistry.record('DEBUGGER', 'RECOVERY_LOOP', 'system_prompt', debuggerMeta.source, debuggerMeta.version);
+        // 3b. Build recovery micro-plan from RCA + stderr
+        const microPlan = buildRecoveryMicroPlan(rcaResponse, failedChecks, pipeline.recoveryCount);
+        // 3c. Store micro-plan as artifact for traceability
+        const microPlanEntry = artifactManager.createAndStoreText('recovery_fix_plan', microPlan.plan, 'RECOVERY_LOOP');
+        artifacts.push(microPlanEntry);
+        // 3d. Inject micro-plan into sessionGuidance (replaces any prior fix directive)
+        {
+            const existing = pipeline.sessionGuidance ?? '';
+            const markers = ['--- QA FIX DIRECTIVE ---', '--- RECOVERY FIX PLAN ---'];
+            let base = existing;
+            for (const m of markers) {
+                if (base.includes(m))
+                    base = base.slice(0, base.indexOf(m)).trim();
+            }
+            pipeline.sessionGuidance = [
+                base, '', '--- RECOVERY FIX PLAN ---', microPlan.plan.slice(0, 3000),
+            ].join('\n').trim();
+        }
         // 4. Build RCA packet
         const rcaPacket = buildRCAPacket({
             incidentSummary: `Gate failure at ${failedPhase ?? 'unknown'} (recovery iteration ${pipeline.recoveryCount})`,
@@ -73,15 +153,12 @@ export async function runRecoveryLoop(context) {
 }
 /** Determine rewind target from RCA response */
 function determineRewindTarget(_rcaResponse, failedPhase) {
-    // If the failure was in production gate or audit, rewind to implementation
     if (failedPhase === 'PRODUCTION_GATE' || failedPhase === 'AUDIT') {
         return 'IMPLEMENTATION';
     }
-    // If in QA, rewind to implementation
     if (failedPhase === 'QA_VALIDATION') {
         return 'IMPLEMENTATION';
     }
-    // For consensus failures, rewind to the phase being validated
     if (failedPhase === 'CONSENSUS_MASTER_PLAN')
         return 'INTAKE';
     if (failedPhase === 'CONSENSUS_ARCHITECTURE')
@@ -90,4 +167,121 @@ function determineRewindTarget(_rcaResponse, failedPhase) {
         return 'ROLE_PLANNING';
     return undefined;
 }
+/**
+ * Extract reviewer feedback from the latest consensus artifact and
+ * build a structured revision directive for the planner.
+ *
+ * Uses Set<string> for dedup. Output is capped at 3000 chars by caller.
+ */
+function buildRevisionDirective(pipeline, failedPhase) {
+    // Find the latest consensus artifact for this phase
+    const consensusArtifacts = pipeline.artifacts.filter((a) => a.type === 'consensus' && a.content);
+    if (consensusArtifacts.length === 0)
+        return null;
+    const latest = consensusArtifacts[consensusArtifacts.length - 1];
+    const packet = latest.content;
+    if (!packet?.reviewer_votes)
+        return null;
+    const blockers = new Set();
+    const required = new Set();
+    const suggestions = new Set();
+    for (const vote of packet.reviewer_votes) {
+        for (const issue of vote.blocking_issues) {
+            const trimmed = issue.trim();
+            if (trimmed)
+                blockers.add(trimmed);
+        }
+        for (const change of (vote.required_changes ?? [])) {
+            const trimmed = change.trim();
+            if (trimmed)
+                required.add(trimmed);
+        }
+        for (const suggestion of vote.suggestions) {
+            const trimmed = suggestion.trim();
+            if (trimmed)
+                suggestions.add(trimmed);
+        }
+    }
+    if (blockers.size === 0 && required.size === 0 && suggestions.size === 0)
+        return null;
+    const lines = [
+        `Revise the plan to address reviewer feedback from ${failedPhase}:`,
+        '',
+    ];
+    if (blockers.size > 0) {
+        lines.push('BLOCKING (must fix):');
+        for (const b of blockers)
+            lines.push(`- ${b}`);
+        lines.push('');
+    }
+    if (required.size > 0) {
+        lines.push('REQUIRED CHANGES:');
+        for (const r of required)
+            lines.push(`- ${r}`);
+        lines.push('');
+    }
+    if (suggestions.size > 0) {
+        lines.push('SUGGESTIONS:');
+        for (const s of suggestions)
+            lines.push(`- ${s}`);
+        lines.push('');
+    }
+    lines.push('Keep existing plan structure. Apply targeted revisions only.');
+    return lines.join('\n');
+}
+/**
+ * Build a structured micro-fix plan from RCA + test failures.
+ * Returns the plan text and a risk assessment for consensus gating.
+ *
+ * Heuristics:
+ *   - Low risk (skip consensus): <=3 files, no schema/dep/config changes
+ *   - Medium risk (consensus): schema, dependency, or build config changes
+ *   - High risk (consensus): API changes, >5 files
+ */
+function buildRecoveryMicroPlan(rcaResponse, failedChecks, recoveryCount) {
+    const stderrLines = failedChecks
+        .filter((c) => c.status === 'fail')
+        .map((c) => c.stderr_summary ?? '')
+        .join('\n');
+    // Combine RCA + stderr for signal extraction
+    const combined = rcaResponse + '\n' + stderrLines;
+    const combinedLower = combined.toLowerCase();
+    const touchesSchema = /schema|migration|prisma|drizzle|typeorm|knex/.test(combinedLower);
+    const touchesDeps = /package\.json|requirements\.txt|dependency|npm install|pip install/
+        .test(combinedLower);
+    const touchesConfig = /tsconfig\.json|vite\.config|jest\.config|vitest\.config|docker-compose|\.github\/workflows/
+        .test(combinedLower);
+    const touchesApi = /api route|endpoint|public api|breaking change/.test(combinedLower);
+    // Extract file paths from BOTH RCA and stderr
+    const mentionedFiles = combined.match(/[\w/.-]+\.(ts|tsx|js|jsx|py|sql|prisma)/gi) ?? [];
+    const uniqueFiles = [...new Set(mentionedFiles)];
+    let riskLevel = 'low';
+    if (touchesApi || uniqueFiles.length > 5)
+        riskLevel = 'high';
+    else if (touchesSchema || touchesDeps || touchesConfig)
+        riskLevel = 'medium';
+    // Only require consensus for medium+ risk on second+ attempt
+    const needsConsensus = riskLevel !== 'low' && recoveryCount >= 2;
+    const plan = [
+        `# Recovery Fix Plan (iteration ${recoveryCount})`,
+        '',
+        `**Risk level:** ${riskLevel}`,
+        `**Files likely affected:** ${uniqueFiles.length > 0 ? uniqueFiles.join(', ') : 'unknown'}`,
+        `**Consensus required:** ${needsConsensus ? 'yes' : 'no'}`,
+        '',
+        '## Root Cause Summary',
+        rcaResponse.slice(0, 800),
+        '',
+        '## Test Failures',
+        stderrLines.slice(0, 1000) || 'No stderr captured',
+        '',
+        '## Fix Checklist',
+        '- [ ] Address root cause identified above',
+        '- [ ] Fix failing test assertions',
+        '- [ ] Verify no regressions in passing tests',
+        touchesSchema ? '- [ ] Review schema/migration changes for correctness' : '',
+        touchesDeps ? '- [ ] Verify dependency changes are necessary and compatible' : '',
+    ].filter(Boolean).join('\n');
+    return { plan, needsConsensus, riskLevel };
+}
 //# sourceMappingURL=recovery-loop.js.map

package/dist/pipeline/phases/recovery-loop.js.map

@@ -1 +1 @@
-{"version":3,"file":"recovery-loop.js","sourceRoot":"","sources":["../../../src/pipeline/phases/recovery-loop.ts"],"names":[],"mappings":"AAAA;;;GAGG;AAIH,OAAO,EAAE,aAAa,EAAE,aAAa,EAAE,iBAAiB,EAAE,MAAM,oBAAoB,CAAC;AACrF,OAAO,EAAE,cAAc,EAAE,MAAM,kCAAkC,CAAC;AAElE,MAAM,CAAC,KAAK,UAAU,eAAe,CAAC,OAAqB;IACzD,MAAM,EAAE,QAAQ,EAAE,eAAe,EAAE,WAAW,EAAE,GAAG,OAAO,CAAC;IAC3D,MAAM,SAAS,GAAG,EAAE,CAAC;IAErB,IAAI,CAAC;QACH,yBAAyB;QACzB,MAAM,aAAa,GAAG,WAAW,CAAC,SAAS,CAAC,UAAU,CAAC,CAAC;QAExD,6BAA6B;QAC7B,MAAM,WAAW,GAAG,QAAQ,CAAC,WAAW,CAAC;QACzC,MAAM,gBAAgB,GAAG,WAAW,CAAC,CAAC,CAAC,QAAQ,CAAC,WAAW,CAAC,WAAW,CAAC,CAAC,CAAC,CAAC,SAAS,CAAC;QACrF,MAAM,YAAY,GAAG,WAAW,CAAC,CAAC,CAAC,QAAQ,CAAC,UAAU,CAAC,WAAW,CAAC,IAAI,EAAE,CAAC,CAAC,CAAC,EAAE,CAAC;QAE/E,MAAM,eAAe,GAAG;YACtB,iBAAiB,WAAW,IAAI,SAAS,EAAE;YAC3C,gBAAgB;gBACd,CAAC,CAAC,kBAAkB,gBAAgB,CAAC,QAAQ,CAAC,IAAI,CAAC,IAAI,CAAC,EAAE;gBAC1D,CAAC,CAAC,0BAA0B;YAC9B,YAAY,CAAC,MAAM,GAAG,CAAC;gBACrB,CAAC,CAAC,kBAAkB,YAAY,CAAC,MAAM,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,MAAM,KAAK,MAAM,CAAC,CAAC,GAAG,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,GAAG,CAAC,CAAC,UAAU,KAAK,CAAC,CAAC,cAAc,EAAE,KAAK,CAAC,CAAC,EAAE,GAAG,CAAC,IAAI,YAAY,EAAE,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,EAAE;gBAClK,CAAC,CAAC,mBAAmB;SACxB,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;QAEb,iDAAiD;QACjD,MAAM,EAAE,aAAa,EAAE,GAAG,MAAM,MAAM,CAAC,0BAA0B,CAAC,CAAC;QACnE,MAAM,QAAQ,GAAG,QAAQ,CAAC,eAAe,CAAC;QAC1C,MAAM,SAAS,GAAG;YAChB,aAAa,CAAC,YAAY;YAC1B,EAAE;YACF,GAAG,CAAC,QAAQ,CAAC,CAAC,CAAC,CAAC,kBAAkB,EAAE,QAAQ,EAAE,EAAE,CAAC,CAAC,CAAC,CAAC,EAAE,CAAC;YACvD,qBAAqB;YACrB,eAAe;YACf,EAAE;YACF,iBAAiB;YACjB,gCAAgC;YAChC,uBAAuB;YACvB,iBAAiB;YACjB,qBAAqB;YACrB,uBAAuB;YACvB,wDAAwD;YACxD,8BAA8B;SAC/B,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;QAEb,MAAM,SAAS,GAAG,MAAM,aAAa,CAAC,SAAS,CAAC,CAAC;QACjD,MAAM,WAAW,GAAG,SAAS,CAAC,QAAQ,CAAC;QAEvC,sBAAsB;QACtB,MAAM,SAAS,GAAG,cAAc,CAAC;YAC/B,eAAe,EAAE,mBAAmB,WAAW,IAAI,SAAS,wBAAwB,QAAQ,CAAC,aAAa,GAAG;YAC7G,QAAQ,EAAE,gBAAgB,EAAE,QAAQ,IAAI,CAAC,aAAa,CAAC;YACvD,SAAS,EAAE,WAAW,CAAC,KAAK,CAAC,CAAC,EAAE,GAAG,CAAC;YACpC,gBAAgB,EAAE,WAAW,IAAI,gBAAgB;YACjD,WAAW,EAAE,WAAW,IAAI,gBAAgB;YAC5C,aAAa,EAAE,iCAAiC;YAChD,iBAAiB,EAAE,CAAC,4BAA4B,CAAC;YACjD,UAAU,EAAE,4BAA4B;YACxC,QAAQ,EAAE,qBAAqB,CAAC,WAAW,EAAE,WAAW,CAAC;SAC1D,CAAC,CAAC;QAEH,4BAA4B;QAC5B,MAAM,YAAY,GAAG,eAAe,CAAC,kBAAkB,CACrD,YAAY,EACZ,SAAS,EACT,eAAe,CAChB,CAAC;QACF,SAAS,CAAC,IAAI,CAAC,YAAY,CAAC,CAAC;QAE7B,MAAM,YAAY,GAAG,eAAe,CAAC,kBAAkB,CACrD,YAAY,EACZ,mBAAmB,WAAW,EAAE,EAChC,eAAe,CAChB,CAAC;QACF,SAAS,CAAC,IAAI,CAAC,YAAY,CAAC,CAAC;QAE7B,QAAQ,CAAC,SAAS,CAAC,IAAI,CAAC,GAAG,SAAS,CAAC,CAAC;QAEtC,wBAAwB;QACxB,MAAM,iBAAiB,CAAC,eAAe,EAAE,SAAS,EAAE,OAAO,CAAC,CAAC;QAE7D,OAAO,aAAa,CAClB,eAAe,EACf,SAAS,EACT,oCAAoC,QAAQ,CAAC,aAAa,EAAE,CAC7D,CAAC;IACJ,CAAC;IAAC,OAAO,GAAG,EAAE,CAAC;QACb,MAAM,OAAO,GAAG,GAAG,YAAY,KAAK,CAAC,CAAC,CAAC,GAAG,CAAC,OAAO,CAAC,CAAC,CAAC,eAAe,CAAC;QACrE,OAAO,aAAa,CAAC,eAAe,EAAE,sBAAsB,EAAE,OAAO,CAAC,CAAC;IACzE,CAAC;AACH,CAAC;AAED,gDAAgD;AAChD,SAAS,qBAAqB,CAC5B,YAAoB,EACpB,WAAsC;IAEtC,2EAA2E;IAC3E,IAAI,WAAW,KAAK,iBAAiB,IAAI,WAAW,KAAK,OAAO,EAAE,CAAC;QACjE,OAAO,gBAAgB,CAAC;IAC1B,CAAC;IACD,qCAAqC;IACrC,IAAI,WAAW,KAAK,eAAe,EAAE,CAAC;QACpC,OAAO,gBAAgB,CAAC;IAC1B,CAAC;IACD,8DAA8D;IAC9D,IAAI,WAAW,KAAK,uBAAuB;QAAE,OAAO,QAAQ,CAAC;IAC7D,IAAI,WAAW,KAAK,wBAAwB;QAAE,OAAO,cAAc,CAAC;IACpE,IAAI,WAAW,KAAK,sBAAsB;QAAE,OAAO,eAAe,CAAC;IAEnE,OAAO,SAAS,CAAC;AACnB,CAAC"}
+{"version":3,"file":"recovery-loop.js","sourceRoot":"","sources":["../../../src/pipeline/phases/recovery-loop.ts"],"names":[],"mappings":"AAAA;;;;;GAKG;AAEH,OAAO,EAAE,UAAU,EAAE,UAAU,EAAE,MAAM,SAAS,CAAC;AACjD,OAAO,EAAE,IAAI,EAAE,MAAM,WAAW,CAAC;AAIjC,OAAO,EAAE,aAAa,EAAE,aAAa,EAAE,iBAAiB,EAAE,MAAM,oBAAoB,CAAC;AACrF,OAAO,EAAE,cAAc,EAAE,MAAM,kCAAkC,CAAC;AAElE,MAAM,CAAC,KAAK,UAAU,eAAe,CAAC,OAAqB;IACzD,MAAM,EAAE,QAAQ,EAAE,eAAe,EAAE,WAAW,EAAE,kBAAkB,EAAE,GAAG,OAAO,CAAC;IAC/E,MAAM,SAAS,GAAG,EAAE,CAAC;IAErB,IAAI,CAAC;QACH,uCAAuC;QACvC,MAAM,EAAE,UAAU,EAAE,aAAa,EAAE,IAAI,EAAE,YAAY,EAAE,GAAG,WAAW,CAAC,iBAAiB,CAAC,UAAU,CAAC,CAAC;QAEpG,6BAA6B;QAC7B,MAAM,WAAW,GAAG,QAAQ,CAAC,WAAW,CAAC;QACzC,MAAM,gBAAgB,GAAG,WAAW,CAAC,CAAC,CAAC,QAAQ,CAAC,WAAW,CAAC,WAAW,CAAC,CAAC,CAAC,CAAC,SAAS,CAAC;QACrF,MAAM,YAAY,GAAG,WAAW,CAAC,CAAC,CAAC,QAAQ,CAAC,UAAU,CAAC,WAAW,CAAC,IAAI,EAAE,CAAC,CAAC,CAAC,EAAE,CAAC;QAE/E,yEAAyE;QACzE,MAAM,cAAc,GAAG,YAAY;aAChC,MAAM,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,MAAM,KAAK,MAAM,CAAC;aAClC,GAAG,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,cAAc,IAAI,EAAE,CAAC;aAClC,IAAI,CAAC,IAAI,CAAC,CAAC;QACd,MAAM,aAAa,GAAG,iEAAiE;aACpF,IAAI,CAAC,cAAc,CAAC,CAAC;QACxB,IAAI,aAAa,EAAE,CAAC;YAClB,IAAI,CAAC;gBACH,MAAM,UAAU,GAAG,IAAI,CAAC,OAAO,CAAC,UAAU,EAAE,SAAS,EAAE,qBAAqB,CAAC,CAAC;gBAC9E,IAAI,UAAU,CAAC,UAAU,CAAC;oBAAE,UAAU,CAAC,UAAU,CAAC,CAAC;YACrD,CAAC;YAAC,MAAM,CAAC,CAAC,eAAe,CAAC,CAAC;QAC7B,CAAC;QAED,MAAM,eAAe,GAAG;YACtB,iBAAiB,WAAW,IAAI,SAAS,EAAE;YAC3C,gBAAgB;gBACd,CAAC,CAAC,kBAAkB,gBAAgB,CAAC,QAAQ,CAAC,IAAI,CAAC,IAAI,CAAC,EAAE;gBAC1D,CAAC,CAAC,0BAA0B;YAC9B,YAAY,CAAC,MAAM,GAAG,CAAC;gBACrB,CAAC,CAAC,kBAAkB,YAAY,CAAC,MAAM,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,MAAM,KAAK,MAAM,CAAC,CAAC,GAAG,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,GAAG,CAAC,CAAC,UAAU,KAAK,CAAC,CAAC,cAAc,EAAE,KAAK,CAAC,CAAC,EAAE,GAAG,CAAC,IAAI,YAAY,EAAE,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,EAAE;gBAClK,CAAC,CAAC,mBAAmB;SACxB,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;QAEb,8EAA8E;QAC9E,IAAI,WAAW,EAAE,UAAU,CAAC,YAAY,CAAC,EAAE,CAAC;YAC1C,MAAM,SAAS,GAAG,sBAAsB,CAAC,QAAQ,EAAE,WAAW,CAAC,CAAC;YAChE,IAAI,SAAS,EAAE,CAAC;gBACd,MAAM,QAAQ,GAAG,QAAQ,CAAC,eAAe,IAAI,EAAE,CAAC;gBAChD,MAAM,MAAM,GAAG,4BAA4B,CAAC;gBAC5C,MAAM,IAAI,GAAG,QAAQ,CAAC,QAAQ,CAAC,MAAM,CAAC;oBACpC,CAAC,CAAC,QAAQ,CAAC,KAAK,CAAC,CAAC,EAAE,QAAQ,CAAC,OAAO,CAAC,MAAM,CAAC,CAAC,CAAC,IAAI,EAAE;oBACpD,CAAC,CAAC,QAAQ,CAAC;gBACb,QAAQ,CAAC,eAAe,GAAG,CAAC,IAAI,EAAE,EAAE,EAAE,MAAM,EAAE,SAAS,CAAC,KAAK,CAAC,CAAC,EAAE,IAAI,CAAC,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC,IAAI,EAAE,CAAC;YAC5F,CAAC;QACH,CAAC;QAED,6EAA6E;QAC7E,mEAAmE;QACnE,IAAI,WAAW,KAAK,eAAe,IAAI,WAAW,KAAK,iBAAiB;eACjE,WAAW,KAAK,gBAAgB,EAAE,CAAC;YACxC,MAAM,kBAAkB,GAAG,YAAY;iBACpC,MAAM,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,MAAM,KAAK,MAAM,CAAC;iBAClC,GAAG,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC;gBACV,KAAK,CAAC,CAAC,UAAU,iBAAiB,CAAC,CAAC,SAAS,IAAI;gBACjD,cAAc,CAAC,CAAC,OAAO,IAAI;gBAC3B,CAAC,CAAC,cAAc,CAAC,CAAC,CAAC,CAAC,CAAC,cAAc,CAAC,KAAK,CAAC,CAAC,EAAE,GAAG,CAAC,CAAC,CAAC,CAAC,oBAAoB;aACzE,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;iBACZ,IAAI,CAAC,MAAM,CAAC,CAAC;YAEhB,IAAI,kBAAkB,EAAE,CAAC;gBACvB,MAAM,QAAQ,GAAG,QAAQ,CAAC,eAAe,IAAI,EAAE,CAAC;gBAChD,MAAM,MAAM,GAAG,0BAA0B,CAAC;gBAC1C,MAAM,IAAI,GAAG,QAAQ,CAAC,QAAQ,CAAC,MAAM,CAAC;oBACpC,CAAC,CAAC,QAAQ,CAAC,KAAK,CAAC,CAAC,EAAE,QAAQ,CAAC,OAAO,CAAC,MAAM,CAAC,CAAC,CAAC,IAAI,EAAE;oBACpD,CAAC,CAAC,QAAQ,CAAC;gBACb,MAAM,SAAS,GAAG;oBAChB,kDAAkD,QAAQ,CAAC,aAAa,IAAI;oBAC5E,EAAE;oBACF,kBAAkB;oBAClB,EAAE;oBACF,oEAAoE;iBACrE,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;gBACb,QAAQ,CAAC,eAAe,GAAG,CAAC,IAAI,EAAE,EAAE,EAAE,MAAM,EAAE,SAAS,CAAC,KAAK,CAAC,CAAC,EAAE,IAAI,CAAC,CAAC;qBACpE,IAAI,CAAC,IAAI,CAAC,CAAC,IAAI,EAAE,CAAC;YACvB,CAAC;QACH,CAAC;QAED,iDAAiD;QACjD,MAAM,EAAE,aAAa,EAAE,GAAG,MAAM,MAAM,CAAC,0BAA0B,CAAC,CAAC;QACnE,MAAM,QAAQ,GAAG,QAAQ,CAAC,eAAe,CAAC;QAC1C,MAAM,SAAS,GAAG;YAChB,aAAa,CAAC,YAAY;YAC1B,EAAE;YACF,GAAG,CAAC,QAAQ,CAAC,CAAC,CAAC,CAAC,kBAAkB,EAAE,QAAQ,EAAE,EAAE,CAAC,CAAC,CAAC,CAAC,EAAE,CAAC;YACvD,qBAAqB;YACrB,eAAe;YACf,EAAE;YACF,iBAAiB;YACjB,gCAAgC;YAChC,uBAAuB;YACvB,iBAAiB;YACjB,qBAAqB;YACrB,uBAAuB;YACvB,wDAAwD;YACxD,8BAA8B;SAC/B,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;QAEb,MAAM,SAAS,GAAG,MAAM,aAAa,CAAC,SAAS,CAAC,CAAC;QACjD,MAAM,WAAW,GAAG,SAAS,CAAC,QAAQ,CAAC;QAEvC,+DAA+D;QAC/D,kBAAkB,CAAC,MAAM,CAAC,UAAU,EAAE,eAAe,EAAE,eAAe,EAAE,YAAY,CAAC,MAAM,EAAE,YAAY,CAAC,OAAO,CAAC,CAAC;QAEnH,kDAAkD;QAClD,MAAM,SAAS,GAAG,sBAAsB,CAAC,WAAW,EAAE,YAAY,EAAE,QAAQ,CAAC,aAAa,CAAC,CAAC;QAE5F,oDAAoD;QACpD,MAAM,cAAc,GAAG,eAAe,CAAC,kBAAkB,CACvD,mBAAmB,EACnB,SAAS,CAAC,IAAI,EACd,eAAe,CAChB,CAAC;QACF,SAAS,CAAC,IAAI,CAAC,cAAc,CAAC,CAAC;QAE/B,gFAAgF;QAChF,CAAC;YACC,MAAM,QAAQ,GAAG,QAAQ,CAAC,eAAe,IAAI,EAAE,CAAC;YAChD,MAAM,OAAO,GAAG,CAAC,0BAA0B,EAAE,2BAA2B,CAAC,CAAC;YAC1E,IAAI,IAAI,GAAG,QAAQ,CAAC;YACpB,KAAK,MAAM,CAAC,IAAI,OAAO,EAAE,CAAC;gBACxB,IAAI,IAAI,CAAC,QAAQ,CAAC,CAAC,CAAC;oBAAE,IAAI,GAAG,IAAI,CAAC,KAAK,CAAC,CAAC,EAAE,IAAI,CAAC,OAAO,CAAC,CAAC,CAAC,CAAC,CAAC,IAAI,EAAE,CAAC;YACrE,CAAC;YACD,QAAQ,CAAC,eAAe,GAAG;gBACzB,IAAI,EAAE,EAAE,EAAE,2BAA2B,EAAE,SAAS,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC,EAAE,IAAI,CAAC;aACrE,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC,IAAI,EAAE,CAAC;QACtB,CAAC;QAED,sBAAsB;QACtB,MAAM,SAAS,GAAG,cAAc,CAAC;YAC/B,eAAe,EAAE,mBAAmB,WAAW,IAAI,SAAS,wBAAwB,QAAQ,CAAC,aAAa,GAAG;YAC7G,QAAQ,EAAE,gBAAgB,EAAE,QAAQ,IAAI,CAAC,aAAa,CAAC;YACvD,SAAS,EAAE,WAAW,CAAC,KAAK,CAAC,CAAC,EAAE,GAAG,CAAC;YACpC,gBAAgB,EAAE,WAAW,IAAI,gBAAgB;YACjD,WAAW,EAAE,WAAW,IAAI,gBAAgB;YAC5C,aAAa,EAAE,iCAAiC;YAChD,iBAAiB,EAAE,CAAC,4BAA4B,CAAC;YACjD,UAAU,EAAE,4BAA4B;YACxC,QAAQ,EAAE,qBAAqB,CAAC,WAAW,EAAE,WAAW,CAAC;SAC1D,CAAC,CAAC;QAEH,4BAA4B;QAC5B,MAAM,YAAY,GAAG,eAAe,CAAC,kBAAkB,CACrD,YAAY,EACZ,SAAS,EACT,eAAe,CAChB,CAAC;QACF,SAAS,CAAC,IAAI,CAAC,YAAY,CAAC,CAAC;QAE7B,MAAM,YAAY,GAAG,eAAe,CAAC,kBAAkB,CACrD,YAAY,EACZ,mBAAmB,WAAW,EAAE,EAChC,eAAe,CAChB,CAAC;QACF,SAAS,CAAC,IAAI,CAAC,YAAY,CAAC,CAAC;QAE7B,QAAQ,CAAC,SAAS,CAAC,IAAI,CAAC,GAAG,SAAS,CAAC,CAAC;QAEtC,wBAAwB;QACxB,MAAM,iBAAiB,CAAC,eAAe,EAAE,SAAS,EAAE,OAAO,CAAC,CAAC;QAE7D,OAAO,aAAa,CAClB,eAAe,EACf,SAAS,EACT,oCAAoC,QAAQ,CAAC,aAAa,EAAE,CAC7D,CAAC;IACJ,CAAC;IAAC,OAAO,GAAG,EAAE,CAAC;QACb,MAAM,OAAO,GAAG,GAAG,YAAY,KAAK,CAAC,CAAC,CAAC,GAAG,CAAC,OAAO,CAAC,CAAC,CAAC,eAAe,CAAC;QACrE,OAAO,aAAa,CAAC,eAAe,EAAE,sBAAsB,EAAE,OAAO,CAAC,CAAC;IACzE,CAAC;AACH,CAAC;AAED,gDAAgD;AAChD,SAAS,qBAAqB,CAC5B,YAAoB,EACpB,WAAsC;IAEtC,IAAI,WAAW,KAAK,iBAAiB,IAAI,WAAW,KAAK,OAAO,EAAE,CAAC;QACjE,OAAO,gBAAgB,CAAC;IAC1B,CAAC;IACD,IAAI,WAAW,KAAK,eAAe,EAAE,CAAC;QACpC,OAAO,gBAAgB,CAAC;IAC1B,CAAC;IACD,IAAI,WAAW,KAAK,uBAAuB;QAAE,OAAO,QAAQ,CAAC;IAC7D,IAAI,WAAW,KAAK,wBAAwB;QAAE,OAAO,cAAc,CAAC;IACpE,IAAI,WAAW,KAAK,sBAAsB;QAAE,OAAO,eAAe,CAAC;IAEnE,OAAO,SAAS,CAAC;AACnB,CAAC;AAED;;;;;GAKG;AACH,SAAS,sBAAsB,CAC7B,QAAmE,EACnE,WAAmB;IAEnB,oDAAoD;IACpD,MAAM,kBAAkB,GAAG,QAAQ,CAAC,SAAS,CAAC,MAAM,CAClD,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,IAAI,KAAK,WAAW,IAAI,CAAC,CAAC,OAAO,CAC3C,CAAC;IACF,IAAI,kBAAkB,CAAC,MAAM,KAAK,CAAC;QAAE,OAAO,IAAI,CAAC;IAEjD,MAAM,MAAM,GAAG,kBAAkB,CAAC,kBAAkB,CAAC,MAAM,GAAG,CAAC,CAAC,CAAC;IACjE,MAAM,MAAM,GAAG,MAAM,CAAC,OAAsC,CAAC;IAC7D,IAAI,CAAC,MAAM,EAAE,cAAc;QAAE,OAAO,IAAI,CAAC;IAEzC,MAAM,QAAQ,GAAG,IAAI,GAAG,EAAU,CAAC;IACnC,MAAM,QAAQ,GAAG,IAAI,GAAG,EAAU,CAAC;IACnC,MAAM,WAAW,GAAG,IAAI,GAAG,EAAU,CAAC;IAEtC,KAAK,MAAM,IAAI,IAAI,MAAM,CAAC,cAAc,EAAE,CAAC;QACzC,KAAK,MAAM,KAAK,IAAI,IAAI,CAAC,eAAe,EAAE,CAAC;YACzC,MAAM,OAAO,GAAG,KAAK,CAAC,IAAI,EAAE,CAAC;YAC7B,IAAI,OAAO;gBAAE,QAAQ,CAAC,GAAG,CAAC,OAAO,CAAC,CAAC;QACrC,CAAC;QACD,KAAK,MAAM,MAAM,IAAI,CAAC,IAAI,CAAC,gBAAgB,IAAI,EAAE,CAAC,EAAE,CAAC;YACnD,MAAM,OAAO,GAAG,MAAM,CAAC,IAAI,EAAE,CAAC;YAC9B,IAAI,OAAO;gBAAE,QAAQ,CAAC,GAAG,CAAC,OAAO,CAAC,CAAC;QACrC,CAAC;QACD,KAAK,MAAM,UAAU,IAAI,IAAI,CAAC,WAAW,EAAE,CAAC;YAC1C,MAAM,OAAO,GAAG,UAAU,CAAC,IAAI,EAAE,CAAC;YAClC,IAAI,OAAO;gBAAE,WAAW,CAAC,GAAG,CAAC,OAAO,CAAC,CAAC;QACxC,CAAC;IACH,CAAC;IAED,IAAI,QAAQ,CAAC,IAAI,KAAK,CAAC,IAAI,QAAQ,CAAC,IAAI,KAAK,CAAC,IAAI,WAAW,CAAC,IAAI,KAAK,CAAC;QAAE,OAAO,IAAI,CAAC;IAEtF,MAAM,KAAK,GAAa;QACtB,qDAAqD,WAAW,GAAG;QACnE,EAAE;KACH,CAAC;IAEF,IAAI,QAAQ,CAAC,IAAI,GAAG,CAAC,EAAE,CAAC;QACtB,KAAK,CAAC,IAAI,CAAC,sBAAsB,CAAC,CAAC;QACnC,KAAK,MAAM,CAAC,IAAI,QAAQ;YAAE,KAAK,CAAC,IAAI,CAAC,KAAK,CAAC,EAAE,CAAC,CAAC;QAC/C,KAAK,CAAC,IAAI,CAAC,EAAE,CAAC,CAAC;IACjB,CAAC;IAED,IAAI,QAAQ,CAAC,IAAI,GAAG,CAAC,EAAE,CAAC;QACtB,KAAK,CAAC,IAAI,CAAC,mBAAmB,CAAC,CAAC;QAChC,KAAK,MAAM,CAAC,IAAI,QAAQ;YAAE,KAAK,CAAC,IAAI,CAAC,KAAK,CAAC,EAAE,CAAC,CAAC;QAC/C,KAAK,CAAC,IAAI,CAAC,EAAE,CAAC,CAAC;IACjB,CAAC;IAED,IAAI,WAAW,CAAC,IAAI,GAAG,CAAC,EAAE,CAAC;QACzB,KAAK,CAAC,IAAI,CAAC,cAAc,CAAC,CAAC;QAC3B,KAAK,MAAM,CAAC,IAAI,WAAW;YAAE,KAAK,CAAC,IAAI,CAAC,KAAK,CAAC,EAAE,CAAC,CAAC;QAClD,KAAK,CAAC,IAAI,CAAC,EAAE,CAAC,CAAC;IACjB,CAAC;IAED,KAAK,CAAC,IAAI,CAAC,8DAA8D,CAAC,CAAC;IAE3E,OAAO,KAAK,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;AAC1B,CAAC;AAED;;;;;;;;GAQG;AACH,SAAS,sBAAsB,CAC7B,WAAmB,EACnB,YAA+B,EAC/B,aAAqB;IAErB,MAAM,WAAW,GAAG,YAAY;SAC7B,MAAM,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,MAAM,KAAK,MAAM,CAAC;SAClC,GAAG,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,cAAc,IAAI,EAAE,CAAC;SAClC,IAAI,CAAC,IAAI,CAAC,CAAC;IAEd,6CAA6C;IAC7C,MAAM,QAAQ,GAAG,WAAW,GAAG,IAAI,GAAG,WAAW,CAAC;IAClD,MAAM,aAAa,GAAG,QAAQ,CAAC,WAAW,EAAE,CAAC;IAE7C,MAAM,aAAa,GAAG,8CAA8C,CAAC,IAAI,CAAC,aAAa,CAAC,CAAC;IACzF,MAAM,WAAW,GAAG,oEAAoE;SACrF,IAAI,CAAC,aAAa,CAAC,CAAC;IACvB,MAAM,aAAa,GACjB,4FAA4F;SAC3F,IAAI,CAAC,aAAa,CAAC,CAAC;IACvB,MAAM,UAAU,GAAG,+CAA+C,CAAC,IAAI,CAAC,aAAa,CAAC,CAAC;IAEvF,8CAA8C;IAC9C,MAAM,cAAc,GAAG,QAAQ,CAAC,KAAK,CAAC,2CAA2C,CAAC,IAAI,EAAE,CAAC;IACzF,MAAM,WAAW,GAAG,CAAC,GAAG,IAAI,GAAG,CAAC,cAAc,CAAC,CAAC,CAAC;IAEjD,IAAI,SAAS,GAA8B,KAAK,CAAC;IACjD,IAAI,UAAU,IAAI,WAAW,CAAC,MAAM,GAAG,CAAC;QAAE,SAAS,GAAG,MAAM,CAAC;SACxD,IAAI,aAAa,IAAI,WAAW,IAAI,aAAa;QAAE,SAAS,GAAG,QAAQ,CAAC;IAE7E,6DAA6D;IAC7D,MAAM,cAAc,GAAG,SAAS,KAAK,KAAK,IAAI,aAAa,IAAI,CAAC,CAAC;IAEjE,MAAM,IAAI,GAAG;QACX,kCAAkC,aAAa,GAAG;QAClD,EAAE;QACF,mBAAmB,SAAS,EAAE;QAC9B,8BAA8B,WAAW,CAAC,MAAM,GAAG,CAAC,CAAC,CAAC,CAAC,WAAW,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC,SAAS,EAAE;QAC3F,2BAA2B,cAAc,CAAC,CAAC,CAAC,KAAK,CAAC,CAAC,CAAC,IAAI,EAAE;QAC1D,EAAE;QACF,uBAAuB;QACvB,WAAW,CAAC,KAAK,CAAC,CAAC,EAAE,GAAG,CAAC;QACzB,EAAE;QACF,kBAAkB;QAClB,WAAW,CAAC,KAAK,CAAC,CAAC,EAAE,IAAI,CAAC,IAAI,oBAAoB;QAClD,EAAE;QACF,kBAAkB;QAClB,2CAA2C;QAC3C,mCAAmC;QACnC,8CAA8C;QAC9C,aAAa,CAAC,CAAC,CAAC,uDAAuD,CAAC,CAAC,CAAC,EAAE;QAC5E,WAAW,CAAC,CAAC,CAAC,8DAA8D,CAAC,CAAC,CAAC,EAAE;KAClF,CAAC,MAAM,CAAC,OAAO,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;IAE7B,OAAO,EAAE,IAAI,EAAE,cAAc,EAAE,SAAS,EAAE,CAAC;AAC7C,CAAC"}

package/dist/pipeline/phases/review.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"review.d.ts","sourceRoot":"","sources":["../../../src/pipeline/phases/review.ts"],"names":[],"mappings":"AAAA;;;;GAIG;AAEH,OAAO,KAAK,EAAE,YAAY,EAAE,WAAW,EAAE,MAAM,oBAAoB,CAAC;AAQpE,wBAAsB,SAAS,CAAC,OAAO,EAAE,YAAY,GAAG,OAAO,CAAC,WAAW,CAAC,CAsI3E"}
+{"version":3,"file":"review.d.ts","sourceRoot":"","sources":["../../../src/pipeline/phases/review.ts"],"names":[],"mappings":"AAAA;;;;GAIG;AAEH,OAAO,KAAK,EAAE,YAAY,EAAE,WAAW,EAAE,MAAM,oBAAoB,CAAC;AAQpE,wBAAsB,SAAS,CAAC,OAAO,EAAE,YAAY,GAAG,OAAO,CAAC,WAAW,CAAC,CAiL3E"}

package/dist/pipeline/phases/review.js

@@ -5,11 +5,11 @@
  */
 import { successResult, failureResult } from './phase-context.js';
 import { generateRepoSnapshot, createSnapshotArtifact, diffSnapshots } from '../repo-snapshot.js';
-import { buildChangeRequest, formatChangeRequest, routeChangeRequest } from '../change-request.js';
+import { buildChangeRequest, formatChangeRequest, routeChangeRequest, computeDriftKey, isDuplicateCR } from '../change-request.js';
 import { existsSync, readFileSync } from 'node:fs';
 import { join } from 'node:path';
 export async function runReview(context) {
-    const { pipeline, artifactManager, projectDir } = context;
+    const { pipeline, artifactManager, skillLoader, skillUsageRegistry, projectDir } = context;
     const artifacts = [];
     const changeRequests = [];
     try {
@@ -18,9 +18,16 @@ export async function runReview(context) {
         const snapshotEntry = createSnapshotArtifact(currentSnapshot, artifactManager, 'REVIEW');
         artifacts.push(snapshotEntry);
         pipeline.latestRepoSnapshot = artifactManager.toArtifactRef(snapshotEntry);
-        // 2. Find role-plan-approval snapshot for drift detection
-        const rolePlanSnapshots = pipeline.artifacts.filter((a) => a.type === 'repo_snapshot' && a.phase === 'CONSENSUS_ROLE_PLANS');
-        const baselineSnapshot = rolePlanSnapshots[rolePlanSnapshots.length - 1];
+        // 2. Find baseline snapshot for drift detection
+        // v2.4.9: Check baselineSnapshotOverride first (set after config CR resolved)
+        let baselineSnapshot = pipeline.baselineSnapshotOverride
+            ? pipeline.artifacts.find((a) => a.id === pipeline.baselineSnapshotOverride.artifact_id)
+            : undefined;
+        // Fallback to CONSENSUS_ROLE_PLANS snapshot
+        if (!baselineSnapshot) {
+            const rolePlanSnapshots = pipeline.artifacts.filter((a) => a.type === 'repo_snapshot' && a.phase === 'CONSENSUS_ROLE_PLANS');
+            baselineSnapshot = rolePlanSnapshots[rolePlanSnapshots.length - 1];
+        }
         let driftReport = 'No baseline snapshot found for drift detection.';
         let hasDrift = false;
         if (baselineSnapshot) {
@@ -41,31 +48,49 @@ export async function runReview(context) {
                             diff.changed_configs.length > 0 ? `Changed configs: ${diff.changed_configs.join(', ')}` : '',
                         ].filter(Boolean).join('\n');
                         // v1.1: Create change requests for detected drift
+                        // v2.4.9: Deduplicate — skip if an active CR with the same drift_key exists
                         if (diff.changed_configs.length > 0) {
-                            const cr = buildChangeRequest({
-                                originPhase: 'REVIEW',
-                                requestedBy: 'REVIEWER',
-                                changeType: 'config',
-                                description: `Config files changed during implementation: ${diff.changed_configs.join(', ')}`,
-                                justification: 'Detected by snapshot diff during review phase',
-                                affectedArtifacts: [artifactManager.toArtifactRef(snapshotEntry)],
-                                affectedPhases: ['IMPLEMENTATION', 'QA_VALIDATION'],
-                                riskLevel: diff.changed_configs.length > 3 ? 'high' : 'medium',
+                            const configHashPairs = diff.changed_configs.map((cfgPath) => {
+                                const before = baselineData.config_files?.find((f) => f.path === cfgPath)?.content_hash ?? 'unknown';
+                                const after = currentSnapshot.config_files?.find((f) => f.path === cfgPath)?.content_hash ?? 'unknown';
+                                return `${cfgPath}:${before}->${after}`;
                             });
-                            changeRequests.push(cr);
+                            const configDriftKey = computeDriftKey('config', baselineSnapshot.id, diff.changed_configs, configHashPairs);
+                            if (!isDuplicateCR(pipeline.pendingChangeRequests, configDriftKey)) {
+                                const cr = buildChangeRequest({
+                                    originPhase: 'REVIEW',
+                                    requestedBy: 'REVIEWER',
+                                    changeType: 'config',
+                                    description: `Config files changed during implementation: ${diff.changed_configs.join(', ')}`,
+                                    justification: 'Detected by snapshot diff during review phase',
+                                    affectedArtifacts: [artifactManager.toArtifactRef(snapshotEntry)],
+                                    affectedPhases: ['IMPLEMENTATION', 'QA_VALIDATION'],
+                                    riskLevel: diff.changed_configs.length > 3 ? 'high' : 'medium',
+                                    driftKey: configDriftKey,
+                                });
+                                changeRequests.push(cr);
+                            }
                         }
-                        if (Math.abs(diff.lines_delta) > 1000) {
-                            const cr = buildChangeRequest({
-                                originPhase: 'REVIEW',
-                                requestedBy: 'REVIEWER',
-                                changeType: 'scope',
-                                description: `Significant scope drift detected: ${diff.lines_delta > 0 ? '+' : ''}${diff.lines_delta} lines`,
-                                justification: 'Large line delta suggests scope changes beyond approved plans',
-                                affectedArtifacts: [artifactManager.toArtifactRef(snapshotEntry)],
-                                affectedPhases: ['CONSENSUS_MASTER_PLAN', 'IMPLEMENTATION'],
-                                riskLevel: 'high',
-                            });
-                            changeRequests.push(cr);
+                        // v2.5.1: Only check scope drift on revision-over-revision passes.
+                        // On first pass, baseline = CONSENSUS_ROLE_PLANS (pre-implementation),
+                        // so large line deltas are expected from implementation — not scope drift.
+                        const isRevisionComparison = !!pipeline.baselineSnapshotOverride;
+                        if (isRevisionComparison && Math.abs(diff.lines_delta) > 1000) {
+                            const scopeDriftKey = computeDriftKey('scope', baselineSnapshot.id, [`lines_delta:${diff.lines_delta}`], []);
+                            if (!isDuplicateCR(pipeline.pendingChangeRequests, scopeDriftKey)) {
+                                const cr = buildChangeRequest({
+                                    originPhase: 'REVIEW',
+                                    requestedBy: 'REVIEWER',
+                                    changeType: 'scope',
+                                    description: `Significant scope drift detected: ${diff.lines_delta > 0 ? '+' : ''}${diff.lines_delta} lines`,
+                                    justification: 'Large line delta suggests scope changes beyond approved plans',
+                                    affectedArtifacts: [artifactManager.toArtifactRef(snapshotEntry)],
+                                    affectedPhases: ['CONSENSUS_MASTER_PLAN', 'IMPLEMENTATION'],
+                                    riskLevel: 'high',
+                                    driftKey: scopeDriftKey,
+                                });
+                                changeRequests.push(cr);
+                            }
                         }
                     }
                     else {
@@ -90,9 +115,13 @@ export async function runReview(context) {
                 change_type: cr.change_type,
                 target_phase: routeChangeRequest(cr),
                 status: 'proposed',
+                drift_key: cr.drift_key,
             });
         }
-        // 4. Create review decision artifact
+        // 3b. Load REVIEWER skill and record usage for skill-guided review
+        const { definition: reviewerSkill, meta: reviewerMeta } = skillLoader.loadSkillWithMeta('REVIEWER');
+        skillUsageRegistry.record('REVIEWER', 'REVIEW', 'review_prompt', reviewerMeta.source, reviewerMeta.version);
+        // 4. Create review decision artifact (skill-guided)
         const reviewDoc = [
             '# Review Decision',
             '',
@@ -107,6 +136,7 @@ export async function runReview(context) {
             changeRequests.length > 0 ? '## Change Requests\n' + changeRequests.map((cr) => `- ${cr.cr_id}: ${cr.description}`).join('\n') : '',
             '',
             '## Plan Alignment',
+            `Reviewed using ${reviewerSkill.role} skill (v${reviewerSkill.version}).`,
             'Implementation reviewed against approved role plans.',
             '',
             '## Decision',