plugin-agent-orchestrator 1.1.8 → 1.2.1

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (495) hide show
  1. package/LICENSE +201 -0
  2. package/README.md +207 -204
  3. package/client-v2.d.ts +2 -2
  4. package/client-v2.js +1 -1
  5. package/client.d.ts +2 -2
  6. package/client.js +1 -1
  7. package/dist/client/117.6c69b6a87751dd18.js +10 -0
  8. package/dist/client/253.52f62e1bc0e9520a.js +10 -0
  9. package/dist/client/325.8f7f509bdb35e142.js +10 -0
  10. package/dist/client/404.86593f98c9768ed5.js +10 -0
  11. package/dist/client/453.fa2d169576262213.js +10 -0
  12. package/dist/client/53.567db3ae078650c6.js +10 -0
  13. package/dist/client/619.01713281e5e951d3.js +10 -0
  14. package/dist/client/652.69da1598312b3a3f.js +10 -0
  15. package/dist/client/773.648965568ff476f9.js +10 -0
  16. package/dist/client/981.37e7aeecdb1ef6fa.js +10 -0
  17. package/dist/client/993.ac89f3852990918d.js +10 -0
  18. package/dist/client/index.js +1 -1
  19. package/dist/client-v2/117.c982d79ff68738f5.js +10 -0
  20. package/dist/client-v2/214.94c4257bf2838577.js +10 -0
  21. package/dist/client-v2/253.8e19956d2a44dfb8.js +10 -0
  22. package/dist/client-v2/264.80e8e358c8c6c2e5.js +10 -0
  23. package/dist/client-v2/325.fafe5a6e83ba9cb3.js +10 -0
  24. package/dist/client-v2/404.ab032b79c95dab6f.js +10 -0
  25. package/dist/client-v2/{41.3deb9e57a0f64fc4.js → 41.cd5610fcf7446127.js} +1 -1
  26. package/dist/client-v2/453.42c6d70628d56cc2.js +10 -0
  27. package/dist/client-v2/{53.349fff8db80b19d4.js → 53.37c08089a648f89a.js} +1 -1
  28. package/dist/client-v2/{619.0a2144aaffefe018.js → 619.6e9618550101e819.js} +1 -1
  29. package/dist/client-v2/652.eeba4e0c38367321.js +10 -0
  30. package/dist/client-v2/{70.ffff2997c10fd4b0.js → 70.332698e53eb59677.js} +1 -1
  31. package/dist/client-v2/773.4de2ba5acb07318c.js +10 -0
  32. package/dist/client-v2/981.76060f466e6f7c11.js +10 -0
  33. package/dist/client-v2/993.f8cdb5172566ce75.js +10 -0
  34. package/dist/client-v2/index.js +1 -1
  35. package/dist/externalVersion.js +13 -7
  36. package/dist/locale/en-US.json +308 -1
  37. package/dist/locale/vi-VN.json +5 -1
  38. package/dist/locale/zh-CN.json +308 -1
  39. package/dist/node_modules/acorn/LICENSE +21 -0
  40. package/dist/node_modules/acorn/bin/acorn +4 -0
  41. package/dist/node_modules/acorn/dist/acorn.d.mts +857 -0
  42. package/dist/node_modules/acorn/dist/acorn.d.ts +857 -0
  43. package/dist/node_modules/acorn/dist/acorn.js +1 -0
  44. package/dist/node_modules/acorn/dist/bin.js +90 -0
  45. package/dist/node_modules/acorn/package.json +1 -0
  46. package/dist/node_modules/acorn-walk/LICENSE +21 -0
  47. package/dist/node_modules/acorn-walk/dist/walk.d.mts +177 -0
  48. package/dist/node_modules/acorn-walk/dist/walk.d.ts +177 -0
  49. package/dist/node_modules/acorn-walk/dist/walk.js +1 -0
  50. package/dist/node_modules/acorn-walk/node_modules/.bin/acorn +15 -0
  51. package/dist/node_modules/acorn-walk/node_modules/.bin/acorn.cmd +7 -0
  52. package/dist/node_modules/acorn-walk/node_modules/acorn/bin/acorn +4 -0
  53. package/dist/node_modules/acorn-walk/node_modules/acorn/dist/acorn.d.mts +866 -0
  54. package/dist/node_modules/acorn-walk/node_modules/acorn/dist/acorn.d.ts +866 -0
  55. package/dist/node_modules/acorn-walk/node_modules/acorn/dist/acorn.js +6174 -0
  56. package/dist/node_modules/acorn-walk/node_modules/acorn/dist/bin.js +90 -0
  57. package/dist/node_modules/acorn-walk/node_modules/acorn/package.json +50 -0
  58. package/dist/node_modules/acorn-walk/package.json +1 -0
  59. package/dist/node_modules/adm-zip/adm-zip.js +1 -1
  60. package/dist/node_modules/adm-zip/package.json +1 -1
  61. package/dist/node_modules/ajv/package.json +1 -1
  62. package/dist/node_modules/zod/index.cjs +1 -1
  63. package/dist/node_modules/zod/package.json +1 -1
  64. package/dist/server/collections/agent-auto-approval-checkpoints.js +47 -0
  65. package/dist/server/collections/agent-execution-spans.js +148 -9
  66. package/dist/server/collections/agent-governance-audit-events.js +47 -0
  67. package/dist/server/collections/agent-governance-policies.js +47 -0
  68. package/dist/server/collections/agent-governance-policy-versions.js +48 -0
  69. package/dist/server/collections/agent-governance-prompt-bindings.js +50 -0
  70. package/dist/server/collections/agent-hierarchy-invocations.js +59 -0
  71. package/dist/server/collections/agent-loop-runs.js +23 -5
  72. package/dist/server/collections/agent-routing-graph-locks.js +40 -0
  73. package/dist/server/collections/agent-session-auto-approvals.js +45 -0
  74. package/dist/server/collections/orchestrator-config.js +17 -0
  75. package/dist/server/migrations/20261110000000-add-usage-pricing-snapshots.js +117 -0
  76. package/dist/server/migrations/20261110010000-add-usage-department-attribution.js +54 -0
  77. package/dist/server/migrations/20261119000000-widen-native-employee-identifiers.js +59 -0
  78. package/dist/server/plugin.js +169 -33
  79. package/dist/server/resources/agent-auto-approval.js +80 -0
  80. package/dist/server/resources/agent-governance.js +192 -0
  81. package/dist/server/resources/agent-harness-profile.js +11 -3
  82. package/dist/server/resources/agent-monitor.js +109 -339
  83. package/dist/server/resources/agent-usage.js +423 -0
  84. package/dist/server/resources/hierarchical-routing.js +60 -0
  85. package/dist/server/resources/native-monitor-format.js +179 -0
  86. package/dist/server/resources/tracing.js +35 -12
  87. package/dist/server/services/AgentGovernanceService.js +500 -0
  88. package/dist/server/services/AutoApprovalCheckpoint.js +133 -0
  89. package/dist/server/services/CodeValidator.js +8 -4
  90. package/dist/server/services/DepartmentAttribution.js +65 -0
  91. package/dist/server/services/ExecutionSpanService.js +96 -3
  92. package/dist/server/services/GovernanceAdmission.js +271 -0
  93. package/dist/server/services/HarnessCapabilities.js +118 -0
  94. package/dist/server/services/HarnessCompiler.js +3 -0
  95. package/dist/server/services/HarnessSchema.js +13 -1
  96. package/dist/server/services/HierarchicalAgentRuntime.js +925 -0
  97. package/dist/server/services/HierarchyEnrollmentGuard.js +216 -0
  98. package/dist/server/services/HierarchyInvocationJournal.js +157 -0
  99. package/dist/server/services/HierarchyRequestCancellation.js +150 -0
  100. package/dist/server/services/LoopBudgetService.js +29 -11
  101. package/dist/server/services/LoopRunRepository.js +16 -7
  102. package/dist/server/services/LoopRunStateMachine.js +20 -9
  103. package/dist/server/services/LoopTriggerService.js +1 -1
  104. package/dist/server/services/LoopWorkerService.js +71 -37
  105. package/dist/server/services/ManagedPromptProtection.js +99 -0
  106. package/dist/server/services/NativeAgentMonitorSyncService.js +584 -0
  107. package/dist/server/services/NativeSubAgentObserver.js +141 -508
  108. package/dist/server/services/NativeUsageAttribution.js +97 -0
  109. package/dist/server/services/PluginAiRuntimeAdapter.js +107 -9
  110. package/dist/server/services/RoutingBindingRepository.js +156 -0
  111. package/dist/server/services/RoutingBindingValidation.js +161 -0
  112. package/dist/server/services/SandboxRunner.js +19 -0
  113. package/dist/server/services/SessionAutoApproval.js +173 -0
  114. package/dist/server/services/TokenTracker.js +787 -104
  115. package/dist/server/services/TracingRetentionPolicy.js +66 -0
  116. package/dist/server/services/VerificationService.js +20 -10
  117. package/dist/server/skill-hub/plugin.js +17 -0
  118. package/dist/server/skill-hub/sandbox-config.json +6 -6
  119. package/dist/server/skill-hub/services/RegistrySkillInstallationService.js +2 -2
  120. package/dist/server/skill-hub/services/registry-node-package.js +191 -0
  121. package/dist/server/skill-hub/tasks/SkillExecutionTask.js +21 -6
  122. package/dist/server/tools/skill-execute.js +1 -0
  123. package/dist/server/utils/ensure-indexes.js +15 -5
  124. package/package.json +66 -53
  125. package/server.d.ts +2 -2
  126. package/server.js +1 -1
  127. package/src/client/AgentRunsTab.tsx +2 -2
  128. package/src/client/ApprovalsTab.tsx +2 -2
  129. package/src/client/HarnessProfilesTab.tsx +2 -2
  130. package/src/client/OrchestratorSettings.tsx +152 -152
  131. package/src/client/SkillPages.tsx +34 -0
  132. package/src/client/__tests__/embedded-settings.test.tsx +225 -0
  133. package/src/client/hooks/useRunEventStream.ts +76 -76
  134. package/src/client/index.tsx +2 -2
  135. package/src/client/plugin.tsx +71 -33
  136. package/src/client/skill-hub/components/ExecutionHistory.tsx +200 -200
  137. package/src/client/skill-hub/components/GitSkillImport.tsx +562 -562
  138. package/src/client/skill-hub/components/LoopSettings.tsx +331 -331
  139. package/src/client/skill-hub/components/SkillEditor.tsx +460 -460
  140. package/src/client/skill-hub/components/SkillManager.tsx +194 -194
  141. package/src/client/skill-hub/components/SkillMetrics.tsx +162 -162
  142. package/src/client/skill-hub/components/SkillTestPanel.tsx +141 -141
  143. package/src/client/skill-hub/index.tsx +6 -6
  144. package/src/client/skill-hub/locale.ts +16 -16
  145. package/src/client/skill-hub/tools/InteractionSchemasProvider.tsx +147 -132
  146. package/src/client/skill-hub/tools/SkillHubCard.tsx +110 -104
  147. package/src/client/skill-hub/tools/__tests__/skill-hub-card.test.tsx +255 -0
  148. package/src/client/skill-hub/tools/loopTemplates.ts +52 -52
  149. package/src/client/skill-hub/tools/registerSkillLoopCards.ts +80 -71
  150. package/src/client/skill-hub/utils/jsonFields.ts +41 -41
  151. package/src/client-v2/__tests__/embedded-settings.test.tsx +202 -0
  152. package/src/client-v2/__tests__/hierarchical-routing-settings.test.tsx +350 -0
  153. package/src/client-v2/auto-approval/AutoApprovalBridge.tsx +513 -0
  154. package/src/client-v2/auto-approval/AutoApprovalProvider.tsx +399 -0
  155. package/src/client-v2/auto-approval/__tests__/session-auto-approval.test.tsx +1676 -0
  156. package/src/client-v2/components/AIEmployeeSelect.tsx +47 -47
  157. package/src/client-v2/components/AIEmployeesContext.tsx +97 -97
  158. package/src/client-v2/components/AgentBindingsTab.tsx +541 -269
  159. package/src/client-v2/components/AgentRunsTab.tsx +85 -83
  160. package/src/client-v2/components/ApprovalsTab.tsx +337 -337
  161. package/src/client-v2/components/EmployeeGovernanceTab.tsx +695 -0
  162. package/src/client-v2/components/HarnessProfilesTab.tsx +700 -541
  163. package/src/client-v2/components/HarnessSettingsForm.tsx +221 -0
  164. package/src/client-v2/components/KnowledgeAccessTab.tsx +116 -116
  165. package/src/client-v2/components/RetrievalTraceTab.tsx +162 -162
  166. package/src/client-v2/components/UsageGovernanceTab.tsx +379 -0
  167. package/src/client-v2/index.tsx +1 -1
  168. package/src/client-v2/pages/AgentBindingsPage.tsx +15 -13
  169. package/src/client-v2/pages/ApprovalsPage.tsx +12 -10
  170. package/src/client-v2/pages/EmployeeGovernancePage.tsx +15 -0
  171. package/src/client-v2/pages/ExecutionHistoryPage.tsx +12 -10
  172. package/src/client-v2/pages/HarnessProfilesPage.tsx +12 -10
  173. package/src/client-v2/pages/KnowledgeAccessPage.tsx +12 -10
  174. package/src/client-v2/pages/LoopSettingsPage.tsx +12 -10
  175. package/src/client-v2/pages/MemoryInspectorPage.tsx +15 -13
  176. package/src/client-v2/pages/RetrievalTracePage.tsx +12 -10
  177. package/src/client-v2/pages/RulesPage.tsx +15 -13
  178. package/src/client-v2/pages/SkillDefinitionsPage.tsx +12 -10
  179. package/src/client-v2/pages/SkillMetricsPage.tsx +12 -10
  180. package/src/client-v2/pages/TracingPage.tsx +15 -13
  181. package/src/client-v2/pages/UsageGovernancePage.tsx +15 -0
  182. package/src/client-v2/plugin.tsx +134 -111
  183. package/src/client-v2/skill-hub/components/ExecutionHistory.tsx +196 -196
  184. package/src/client-v2/skill-hub/components/FileLinkList.tsx +37 -37
  185. package/src/client-v2/skill-hub/components/GitSkillImport.tsx +539 -539
  186. package/src/client-v2/skill-hub/components/LoopSettings.tsx +331 -331
  187. package/src/client-v2/skill-hub/components/SkillEditor.tsx +453 -453
  188. package/src/client-v2/skill-hub/components/SkillManager.tsx +191 -174
  189. package/src/client-v2/skill-hub/components/SkillMetrics.tsx +162 -162
  190. package/src/client-v2/skill-hub/components/SkillTestPanel.tsx +135 -135
  191. package/src/client-v2/skill-hub/locale.ts +13 -13
  192. package/src/client-v2/skill-hub/tools/InteractionSchemasProvider.tsx +62 -0
  193. package/src/client-v2/skill-hub/tools/SkillHubCard.tsx +104 -0
  194. package/src/client-v2/skill-hub/tools/__tests__/interactions.test.ts +126 -0
  195. package/src/client-v2/skill-hub/tools/interactions.ts +137 -0
  196. package/src/client-v2/skill-hub/tools/loopTemplates.ts +52 -52
  197. package/src/client-v2/skill-hub/utils/jsonFields.ts +41 -41
  198. package/src/client-v2/utils/jsonFields.ts +41 -41
  199. package/src/index.ts +2 -2
  200. package/src/locale/en-US.json +308 -1
  201. package/src/locale/vi-VN.json +5 -1
  202. package/src/locale/zh-CN.json +308 -1
  203. package/src/server/__tests__/agent-execution-context.test.ts +18 -18
  204. package/src/server/__tests__/agent-governance.integration.test.ts +385 -0
  205. package/src/server/__tests__/agent-knowledge-insights.test.ts +123 -123
  206. package/src/server/__tests__/agent-monitor-acl.integration.test.ts +267 -0
  207. package/src/server/__tests__/agent-registry-service.test.ts +147 -147
  208. package/src/server/__tests__/agent-runtime-lifecycle.test.ts +46 -46
  209. package/src/server/__tests__/agent-usage-report.integration.test.ts +335 -0
  210. package/src/server/__tests__/auto-approval-checkpoint.integration.test.ts +295 -0
  211. package/src/server/__tests__/code-validator.test.ts +63 -63
  212. package/src/server/__tests__/external-rag-search.test.ts +107 -107
  213. package/src/server/__tests__/harness-capabilities.test.ts +88 -0
  214. package/src/server/__tests__/harness-compiler.test.ts +278 -214
  215. package/src/server/__tests__/harness-profile-service.test.ts +167 -167
  216. package/src/server/__tests__/harness-runtime-policy.test.ts +293 -293
  217. package/src/server/__tests__/harness-tool-plan.test.ts +175 -172
  218. package/src/server/__tests__/hierarchical-routing.integration.test.ts +2318 -0
  219. package/src/server/__tests__/hierarchy-invocation-journal.integration.test.ts +119 -0
  220. package/src/server/__tests__/input-schema-validator.test.ts +26 -26
  221. package/src/server/__tests__/loop-approval-decision.test.ts +624 -512
  222. package/src/server/__tests__/loop-approval-expiry.test.ts +258 -258
  223. package/src/server/__tests__/loop-budget-service.test.ts +29 -0
  224. package/src/server/__tests__/loop-pattern-schema.test.ts +73 -73
  225. package/src/server/__tests__/loop-run-repository.test.ts +25 -0
  226. package/src/server/__tests__/loop-run-state-machine.test.ts +101 -101
  227. package/src/server/__tests__/loop-trigger-service.test.ts +185 -148
  228. package/src/server/__tests__/loop-worker-claim.test.ts +110 -10
  229. package/src/server/__tests__/loop-worker-execution.test.ts +375 -317
  230. package/src/server/__tests__/native-agent-monitor-sync.test.ts +343 -0
  231. package/src/server/__tests__/native-hierarchy-probe.integration.test.ts +527 -0
  232. package/src/server/__tests__/native-sub-agent-observer.test.ts +463 -662
  233. package/src/server/__tests__/native-usage-attribution.integration.test.ts +168 -0
  234. package/src/server/__tests__/plugin-ai-runtime-adapter.test.ts +403 -0
  235. package/src/server/__tests__/registry-node-package.test.ts +299 -0
  236. package/src/server/__tests__/routing-binding-graph.integration.test.ts +217 -0
  237. package/src/server/__tests__/routing-binding-validation.test.ts +256 -0
  238. package/src/server/__tests__/session-auto-approval.integration.test.ts +329 -0
  239. package/src/server/__tests__/skill-access-service.test.ts +64 -64
  240. package/src/server/__tests__/skill-execute.test.ts +81 -70
  241. package/src/server/__tests__/skill-execution-task-policy.test.ts +140 -140
  242. package/src/server/__tests__/skill-review-guard.test.ts +171 -0
  243. package/src/server/__tests__/skill-sandbox-worker-mode.test.ts +15 -15
  244. package/src/server/__tests__/skill-settings.test.ts +63 -63
  245. package/src/server/__tests__/skill-tool-name.test.ts +23 -23
  246. package/src/server/__tests__/token-tracker.test.ts +632 -0
  247. package/src/server/__tests__/tool-loop-detection.test.ts +276 -276
  248. package/src/server/__tests__/tracing-retention-policy.test.ts +30 -0
  249. package/src/server/__tests__/usage-ledger.integration.test.ts +187 -0
  250. package/src/server/collections/agent-auto-approval-checkpoints.ts +18 -0
  251. package/src/server/collections/agent-execution-spans.ts +386 -245
  252. package/src/server/collections/agent-governance-audit-events.ts +19 -0
  253. package/src/server/collections/agent-governance-policies.ts +19 -0
  254. package/src/server/collections/agent-governance-policy-versions.ts +20 -0
  255. package/src/server/collections/agent-governance-prompt-bindings.ts +22 -0
  256. package/src/server/collections/agent-hierarchy-invocations.ts +30 -0
  257. package/src/server/collections/agent-loop-action-approvals.ts +39 -39
  258. package/src/server/collections/agent-loop-runs.ts +389 -369
  259. package/src/server/collections/agent-loop-steps.ts +220 -220
  260. package/src/server/collections/agent-memory-contexts.ts +95 -95
  261. package/src/server/collections/agent-routing-graph-locks.ts +11 -0
  262. package/src/server/collections/agent-session-auto-approvals.ts +16 -0
  263. package/src/server/collections/orchestrator-config.ts +113 -87
  264. package/src/server/collections/orchestrator-logs.ts +116 -116
  265. package/src/server/collections/skill-definitions.ts +159 -159
  266. package/src/server/collections/skill-executions.ts +154 -154
  267. package/src/server/collections/skill-loop-configs.ts +65 -65
  268. package/src/server/collections/skill-metrics.ts +36 -36
  269. package/src/server/collections/skill-registry-installations.ts +41 -41
  270. package/src/server/collections/skill-worker-configs.ts +86 -86
  271. package/src/server/index.ts +1 -1
  272. package/src/server/migrations/20260423000000-add-progress-fields.ts +50 -50
  273. package/src/server/migrations/20260425000000-add-interaction-schema.ts +37 -37
  274. package/src/server/migrations/20260427000000-add-tracing-detail-fields.ts +41 -41
  275. package/src/server/migrations/20260427000001-change-other-json-to-text.ts +61 -61
  276. package/src/server/migrations/20260524001000-add-plan-approval-and-harness-profiles.ts +145 -145
  277. package/src/server/migrations/20260601000000-add-token-fields.ts +89 -89
  278. package/src/server/migrations/20260615000000-normalize-ai-employee-tool-bindings.ts +39 -39
  279. package/src/server/migrations/20260621000000-native-policy-profile-defaults.ts +190 -190
  280. package/src/server/migrations/20260727000000-remove-unused-knowledge-scopes.ts +25 -25
  281. package/src/server/migrations/20260727010000-backfill-skill-tool-names.ts +45 -45
  282. package/src/server/migrations/20261110000000-add-usage-pricing-snapshots.ts +110 -0
  283. package/src/server/migrations/20261110010000-add-usage-department-attribution.ts +28 -0
  284. package/src/server/migrations/20261119000000-widen-native-employee-identifiers.ts +37 -0
  285. package/src/server/plugin.ts +724 -573
  286. package/src/server/resources/agent-auto-approval.ts +51 -0
  287. package/src/server/resources/agent-governance.ts +161 -0
  288. package/src/server/resources/agent-harness-profile.ts +103 -94
  289. package/src/server/resources/agent-knowledge-insights.ts +306 -306
  290. package/src/server/resources/agent-loop-approval.ts +84 -84
  291. package/src/server/resources/agent-loop-events-stream.ts +108 -108
  292. package/src/server/resources/agent-loop.ts +252 -252
  293. package/src/server/resources/agent-monitor.ts +208 -482
  294. package/src/server/resources/agent-usage.ts +413 -0
  295. package/src/server/resources/hierarchical-routing.ts +39 -0
  296. package/src/server/resources/native-monitor-format.ts +150 -0
  297. package/src/server/resources/tracing.ts +296 -267
  298. package/src/server/services/AgentExecutionContext.ts +23 -23
  299. package/src/server/services/AgentGovernanceService.ts +541 -0
  300. package/src/server/services/AgentMemoryContextService.ts +344 -344
  301. package/src/server/services/AgentRegistryService.ts +220 -220
  302. package/src/server/services/AgentRuntimeLifecycle.ts +64 -64
  303. package/src/server/services/AutoApprovalCheckpoint.ts +140 -0
  304. package/src/server/services/CodeValidator.ts +257 -238
  305. package/src/server/services/DepartmentAttribution.ts +47 -0
  306. package/src/server/services/DurableCircuitBreakerService.ts +235 -235
  307. package/src/server/services/ExecutionSpanService.ts +271 -146
  308. package/src/server/services/FileManager.ts +159 -159
  309. package/src/server/services/GovernanceAdmission.ts +314 -0
  310. package/src/server/services/HarnessCapabilities.ts +112 -0
  311. package/src/server/services/HarnessCompiler.ts +182 -170
  312. package/src/server/services/HarnessProfileService.ts +235 -235
  313. package/src/server/services/HarnessSchema.ts +224 -194
  314. package/src/server/services/HierarchicalAgentRuntime.ts +1052 -0
  315. package/src/server/services/HierarchyEnrollmentGuard.ts +211 -0
  316. package/src/server/services/HierarchyInvocationJournal.ts +172 -0
  317. package/src/server/services/HierarchyRequestCancellation.ts +132 -0
  318. package/src/server/services/InputSchemaValidator.ts +44 -44
  319. package/src/server/services/LoopBudgetService.ts +325 -271
  320. package/src/server/services/LoopControlService.ts +120 -120
  321. package/src/server/services/LoopPatternSchema.ts +231 -231
  322. package/src/server/services/LoopPatternService.ts +171 -171
  323. package/src/server/services/LoopRunRepository.ts +343 -332
  324. package/src/server/services/LoopRunStateMachine.ts +538 -525
  325. package/src/server/services/LoopSchedulerService.ts +195 -195
  326. package/src/server/services/LoopTriggerService.ts +162 -159
  327. package/src/server/services/LoopWorkerService.ts +975 -912
  328. package/src/server/services/ManagedPromptProtection.ts +81 -0
  329. package/src/server/services/NativeAgentMonitorSyncService.ts +684 -0
  330. package/src/server/services/NativeSubAgentObserver.ts +324 -757
  331. package/src/server/services/NativeUsageAttribution.ts +91 -0
  332. package/src/server/services/PathLockService.ts +317 -317
  333. package/src/server/services/PluginAiRuntimeAdapter.ts +518 -387
  334. package/src/server/services/RoutingBindingRepository.ts +146 -0
  335. package/src/server/services/RoutingBindingValidation.ts +161 -0
  336. package/src/server/services/RunEventBus.ts +58 -58
  337. package/src/server/services/SandboxRunner.ts +526 -492
  338. package/src/server/services/SessionAutoApproval.ts +167 -0
  339. package/src/server/services/SkillAccessService.ts +175 -175
  340. package/src/server/services/SkillManager.ts +585 -585
  341. package/src/server/services/SkillRepositoryService.ts +236 -236
  342. package/src/server/services/TokenTracker.ts +1151 -287
  343. package/src/server/services/ToolLoopDetectionService.ts +210 -210
  344. package/src/server/services/TracingRetentionPolicy.ts +49 -0
  345. package/src/server/services/VerificationSchema.ts +31 -31
  346. package/src/server/services/VerificationService.ts +325 -313
  347. package/src/server/services/WorkerEnvManager.ts +198 -198
  348. package/src/server/services/__tests__/SkillRepositoryService.test.ts +33 -33
  349. package/src/server/services/harness-runtime-policy.ts +134 -134
  350. package/src/server/services/pythonGuardTemplate.ts +87 -87
  351. package/src/server/services/sandboxCapabilities.ts +348 -348
  352. package/src/server/skill-hub/actions/__tests__/git-import.test.ts +563 -563
  353. package/src/server/skill-hub/actions/git-import.ts +936 -936
  354. package/src/server/skill-hub/mcp/McpController.ts +107 -107
  355. package/src/server/skill-hub/middlewares/git-import-request-method-policy.ts +51 -51
  356. package/src/server/skill-hub/plugin.ts +1272 -1232
  357. package/src/server/skill-hub/sandbox-config.json +6 -6
  358. package/src/server/skill-hub/services/RegistrySkillInstallationService.ts +291 -281
  359. package/src/server/skill-hub/services/__tests__/RegistrySkillInstallationService.test.ts +295 -295
  360. package/src/server/skill-hub/services/registry-node-package.ts +191 -0
  361. package/src/server/skill-hub/tasks/SkillExecutionTask.ts +597 -568
  362. package/src/server/skill-hub/utils/json-fields.ts +57 -57
  363. package/src/server/tools/delegate-task.ts +30 -30
  364. package/src/server/tools/external-rag-search.ts +329 -329
  365. package/src/server/tools/skill-execute.ts +226 -216
  366. package/src/server/types.ts +21 -21
  367. package/src/server/utils/ai-manager.ts +24 -24
  368. package/src/server/utils/ctx-utils.ts +132 -132
  369. package/src/server/utils/ensure-indexes.ts +113 -96
  370. package/src/server/utils/ha-lock.ts +80 -80
  371. package/src/server/utils/loop-pattern-context.ts +84 -84
  372. package/src/server/utils/record-utils.ts +19 -19
  373. package/src/server/utils/skill-settings.ts +135 -135
  374. package/src/server/utils/skill-tool-name.ts +58 -58
  375. package/dist/client-v2/117.7565cff57c39318a.js +0 -10
  376. package/dist/client-v2/214.106635011859dede.js +0 -10
  377. package/dist/client-v2/253.59577b40d9875be0.js +0 -10
  378. package/dist/client-v2/264.7ed8bee71fa5935c.js +0 -10
  379. package/dist/client-v2/418.41ed200e7d6da332.js +0 -10
  380. package/dist/client-v2/794.a67a2614405ba627.js +0 -10
  381. package/dist/client-v2/981.e4a1f41cfc94a856.js +0 -10
  382. package/dist/client-v2/993.b0688fdc5ccb000a.js +0 -10
  383. package/dist/node_modules/simple-git/dist/cjs/index.js +0 -7399
  384. package/dist/node_modules/simple-git/dist/esm/index.js +0 -4745
  385. package/dist/node_modules/simple-git/dist/esm/package.json +0 -3
  386. package/dist/node_modules/simple-git/dist/src/lib/api.d.ts +0 -13
  387. package/dist/node_modules/simple-git/dist/src/lib/args/log-format.d.ts +0 -9
  388. package/dist/node_modules/simple-git/dist/src/lib/errors/git-construct-error.d.ts +0 -15
  389. package/dist/node_modules/simple-git/dist/src/lib/errors/git-error.d.ts +0 -30
  390. package/dist/node_modules/simple-git/dist/src/lib/errors/git-plugin-error.d.ts +0 -7
  391. package/dist/node_modules/simple-git/dist/src/lib/errors/git-response-error.d.ts +0 -32
  392. package/dist/node_modules/simple-git/dist/src/lib/errors/task-configuration-error.d.ts +0 -12
  393. package/dist/node_modules/simple-git/dist/src/lib/git-factory.d.ts +0 -15
  394. package/dist/node_modules/simple-git/dist/src/lib/git-logger.d.ts +0 -21
  395. package/dist/node_modules/simple-git/dist/src/lib/parsers/parse-branch-delete.d.ts +0 -5
  396. package/dist/node_modules/simple-git/dist/src/lib/parsers/parse-branch.d.ts +0 -2
  397. package/dist/node_modules/simple-git/dist/src/lib/parsers/parse-commit.d.ts +0 -2
  398. package/dist/node_modules/simple-git/dist/src/lib/parsers/parse-diff-summary.d.ts +0 -3
  399. package/dist/node_modules/simple-git/dist/src/lib/parsers/parse-fetch.d.ts +0 -2
  400. package/dist/node_modules/simple-git/dist/src/lib/parsers/parse-list-log-summary.d.ts +0 -6
  401. package/dist/node_modules/simple-git/dist/src/lib/parsers/parse-merge.d.ts +0 -11
  402. package/dist/node_modules/simple-git/dist/src/lib/parsers/parse-move.d.ts +0 -2
  403. package/dist/node_modules/simple-git/dist/src/lib/parsers/parse-pull.d.ts +0 -6
  404. package/dist/node_modules/simple-git/dist/src/lib/parsers/parse-push.d.ts +0 -4
  405. package/dist/node_modules/simple-git/dist/src/lib/parsers/parse-remote-messages.d.ts +0 -5
  406. package/dist/node_modules/simple-git/dist/src/lib/parsers/parse-remote-objects.d.ts +0 -3
  407. package/dist/node_modules/simple-git/dist/src/lib/plugins/abort-plugin.d.ts +0 -3
  408. package/dist/node_modules/simple-git/dist/src/lib/plugins/block-unsafe-operations-plugin.d.ts +0 -3
  409. package/dist/node_modules/simple-git/dist/src/lib/plugins/command-config-prefixing-plugin.d.ts +0 -2
  410. package/dist/node_modules/simple-git/dist/src/lib/plugins/completion-detection.plugin.d.ts +0 -3
  411. package/dist/node_modules/simple-git/dist/src/lib/plugins/custom-binary.plugin.d.ts +0 -3
  412. package/dist/node_modules/simple-git/dist/src/lib/plugins/error-detection.plugin.d.ts +0 -7
  413. package/dist/node_modules/simple-git/dist/src/lib/plugins/index.d.ts +0 -11
  414. package/dist/node_modules/simple-git/dist/src/lib/plugins/plugin-store.d.ts +0 -11
  415. package/dist/node_modules/simple-git/dist/src/lib/plugins/progress-monitor-plugin.d.ts +0 -3
  416. package/dist/node_modules/simple-git/dist/src/lib/plugins/simple-git-plugin.d.ts +0 -48
  417. package/dist/node_modules/simple-git/dist/src/lib/plugins/spawn-options-plugin.d.ts +0 -3
  418. package/dist/node_modules/simple-git/dist/src/lib/plugins/suffix-paths.plugin.d.ts +0 -2
  419. package/dist/node_modules/simple-git/dist/src/lib/plugins/timout-plugin.d.ts +0 -3
  420. package/dist/node_modules/simple-git/dist/src/lib/responses/BranchDeleteSummary.d.ts +0 -12
  421. package/dist/node_modules/simple-git/dist/src/lib/responses/BranchSummary.d.ts +0 -14
  422. package/dist/node_modules/simple-git/dist/src/lib/responses/CheckIgnore.d.ts +0 -4
  423. package/dist/node_modules/simple-git/dist/src/lib/responses/CleanSummary.d.ts +0 -9
  424. package/dist/node_modules/simple-git/dist/src/lib/responses/ConfigList.d.ts +0 -13
  425. package/dist/node_modules/simple-git/dist/src/lib/responses/DiffSummary.d.ts +0 -10
  426. package/dist/node_modules/simple-git/dist/src/lib/responses/FileStatusSummary.d.ts +0 -9
  427. package/dist/node_modules/simple-git/dist/src/lib/responses/GetRemoteSummary.d.ts +0 -11
  428. package/dist/node_modules/simple-git/dist/src/lib/responses/InitSummary.d.ts +0 -9
  429. package/dist/node_modules/simple-git/dist/src/lib/responses/MergeSummary.d.ts +0 -16
  430. package/dist/node_modules/simple-git/dist/src/lib/responses/PullSummary.d.ts +0 -25
  431. package/dist/node_modules/simple-git/dist/src/lib/responses/StatusSummary.d.ts +0 -19
  432. package/dist/node_modules/simple-git/dist/src/lib/responses/TagList.d.ts +0 -7
  433. package/dist/node_modules/simple-git/dist/src/lib/runners/git-executor-chain.d.ts +0 -25
  434. package/dist/node_modules/simple-git/dist/src/lib/runners/git-executor.d.ts +0 -14
  435. package/dist/node_modules/simple-git/dist/src/lib/runners/promise-wrapped.d.ts +0 -2
  436. package/dist/node_modules/simple-git/dist/src/lib/runners/scheduler.d.ts +0 -11
  437. package/dist/node_modules/simple-git/dist/src/lib/runners/tasks-pending-queue.d.ts +0 -23
  438. package/dist/node_modules/simple-git/dist/src/lib/simple-git-api.d.ts +0 -20
  439. package/dist/node_modules/simple-git/dist/src/lib/task-callback.d.ts +0 -2
  440. package/dist/node_modules/simple-git/dist/src/lib/tasks/apply-patch.d.ts +0 -3
  441. package/dist/node_modules/simple-git/dist/src/lib/tasks/branch.d.ts +0 -7
  442. package/dist/node_modules/simple-git/dist/src/lib/tasks/change-working-directory.d.ts +0 -2
  443. package/dist/node_modules/simple-git/dist/src/lib/tasks/check-ignore.d.ts +0 -2
  444. package/dist/node_modules/simple-git/dist/src/lib/tasks/check-is-repo.d.ts +0 -9
  445. package/dist/node_modules/simple-git/dist/src/lib/tasks/checkout.d.ts +0 -2
  446. package/dist/node_modules/simple-git/dist/src/lib/tasks/clean.d.ts +0 -25
  447. package/dist/node_modules/simple-git/dist/src/lib/tasks/clone.d.ts +0 -9
  448. package/dist/node_modules/simple-git/dist/src/lib/tasks/commit.d.ts +0 -4
  449. package/dist/node_modules/simple-git/dist/src/lib/tasks/config.d.ts +0 -8
  450. package/dist/node_modules/simple-git/dist/src/lib/tasks/count-objects.d.ts +0 -12
  451. package/dist/node_modules/simple-git/dist/src/lib/tasks/diff-name-status.d.ts +0 -12
  452. package/dist/node_modules/simple-git/dist/src/lib/tasks/diff.d.ts +0 -5
  453. package/dist/node_modules/simple-git/dist/src/lib/tasks/fetch.d.ts +0 -4
  454. package/dist/node_modules/simple-git/dist/src/lib/tasks/first-commit.d.ts +0 -2
  455. package/dist/node_modules/simple-git/dist/src/lib/tasks/grep.d.ts +0 -12
  456. package/dist/node_modules/simple-git/dist/src/lib/tasks/hash-object.d.ts +0 -5
  457. package/dist/node_modules/simple-git/dist/src/lib/tasks/init.d.ts +0 -3
  458. package/dist/node_modules/simple-git/dist/src/lib/tasks/log.d.ts +0 -32
  459. package/dist/node_modules/simple-git/dist/src/lib/tasks/merge.d.ts +0 -4
  460. package/dist/node_modules/simple-git/dist/src/lib/tasks/move.d.ts +0 -3
  461. package/dist/node_modules/simple-git/dist/src/lib/tasks/pull.d.ts +0 -3
  462. package/dist/node_modules/simple-git/dist/src/lib/tasks/push.d.ts +0 -9
  463. package/dist/node_modules/simple-git/dist/src/lib/tasks/remote.d.ts +0 -8
  464. package/dist/node_modules/simple-git/dist/src/lib/tasks/reset.d.ts +0 -11
  465. package/dist/node_modules/simple-git/dist/src/lib/tasks/show.d.ts +0 -2
  466. package/dist/node_modules/simple-git/dist/src/lib/tasks/stash-list.d.ts +0 -4
  467. package/dist/node_modules/simple-git/dist/src/lib/tasks/status.d.ts +0 -3
  468. package/dist/node_modules/simple-git/dist/src/lib/tasks/sub-module.d.ts +0 -5
  469. package/dist/node_modules/simple-git/dist/src/lib/tasks/tag.d.ts +0 -18
  470. package/dist/node_modules/simple-git/dist/src/lib/tasks/task.d.ts +0 -14
  471. package/dist/node_modules/simple-git/dist/src/lib/tasks/version.d.ts +0 -9
  472. package/dist/node_modules/simple-git/dist/src/lib/types/handlers.d.ts +0 -21
  473. package/dist/node_modules/simple-git/dist/src/lib/types/index.d.ts +0 -136
  474. package/dist/node_modules/simple-git/dist/src/lib/types/tasks.d.ts +0 -19
  475. package/dist/node_modules/simple-git/dist/src/lib/utils/argument-filters.d.ts +0 -14
  476. package/dist/node_modules/simple-git/dist/src/lib/utils/exit-codes.d.ts +0 -10
  477. package/dist/node_modules/simple-git/dist/src/lib/utils/git-output-streams.d.ts +0 -7
  478. package/dist/node_modules/simple-git/dist/src/lib/utils/index.d.ts +0 -8
  479. package/dist/node_modules/simple-git/dist/src/lib/utils/line-parser.d.ts +0 -15
  480. package/dist/node_modules/simple-git/dist/src/lib/utils/simple-git-options.d.ts +0 -2
  481. package/dist/node_modules/simple-git/dist/src/lib/utils/task-options.d.ts +0 -13
  482. package/dist/node_modules/simple-git/dist/src/lib/utils/task-parser.d.ts +0 -5
  483. package/dist/node_modules/simple-git/dist/src/lib/utils/util.d.ts +0 -47
  484. package/dist/node_modules/simple-git/dist/typings/errors.d.ts +0 -5
  485. package/dist/node_modules/simple-git/dist/typings/index.d.ts +0 -14
  486. package/dist/node_modules/simple-git/dist/typings/response.d.ts +0 -556
  487. package/dist/node_modules/simple-git/dist/typings/simple-git.d.ts +0 -1033
  488. package/dist/node_modules/simple-git/dist/typings/types.d.ts +0 -22
  489. package/dist/node_modules/simple-git/node_modules/debug/package.json +0 -64
  490. package/dist/node_modules/simple-git/node_modules/debug/src/browser.js +0 -272
  491. package/dist/node_modules/simple-git/node_modules/debug/src/common.js +0 -292
  492. package/dist/node_modules/simple-git/node_modules/debug/src/index.js +0 -10
  493. package/dist/node_modules/simple-git/node_modules/debug/src/node.js +0 -263
  494. package/dist/node_modules/simple-git/package.json +0 -1
  495. package/dist/node_modules/simple-git/promise.js +0 -17
@@ -1,512 +1,624 @@
1
- import type { Database } from '@nocobase/database';
2
- import type { Application } from '@nocobase/server';
3
- import { beforeEach, describe, expect, it, vi } from 'vitest';
4
- import { compileHarness } from '../services/HarnessCompiler';
5
- import type { CompiledHarness } from '../services/HarnessCompiler';
6
- import { loopPatternPolicySchema } from '../services/LoopPatternSchema';
7
-
8
- type Row = Record<string, unknown>;
9
-
10
- type InvokeCall = { username: string; prompt: string; harness: CompiledHarness };
11
- type ResumeCall = {
12
- username: string;
13
- sessionId: string;
14
- messageId: string;
15
- decisions: Array<{ toolCallId: string; decision: { type: string; message?: string; editedAction?: unknown } }>;
16
- };
17
- type ResumeOutcome = {
18
- sessionId: string;
19
- messageId: string;
20
- interrupted: Array<{ toolCallId: string; toolName: string; args: unknown; interruptId: string }>;
21
- content: string;
22
- };
23
-
24
- const invokeCalls: InvokeCall[] = [];
25
- const resumeCalls: ResumeCall[] = [];
26
- let resumeOutcome: ResumeOutcome = { sessionId: 'session-1', messageId: 'message-2', interrupted: [], content: '' };
27
-
28
- vi.mock('../services/PluginAiRuntimeAdapter', () => ({
29
- PluginAiRuntimeAdapter: class {
30
- async createConversation() {
31
- return 'session-1';
32
- }
33
- async invoke(input: InvokeCall) {
34
- invokeCalls.push(input);
35
- return { sessionId: 'session-1', messageId: 'message-1', interrupted: [], content: `${input.username} done` };
36
- }
37
- async resume(input: ResumeCall) {
38
- resumeCalls.push(input);
39
- return resumeOutcome;
40
- }
41
- },
42
- }));
43
-
44
- vi.mock('../services/VerificationService', () => ({
45
- VerificationService: class {
46
- async verifyAndFinalize() {
47
- return { verdict: { verdict: 'pass' }, finalStatus: 'succeeded' as const };
48
- }
49
- },
50
- }));
51
-
52
- const { LoopRunRepository } = await import('../services/LoopRunRepository');
53
- const { LoopWorkerService } = await import('../services/LoopWorkerService');
54
-
55
- class MemoryRepository {
56
- private nextId = 1;
57
-
58
- constructor(readonly rows: Row[] = []) {
59
- this.nextId = rows.reduce((maximum, row) => Math.max(maximum, Number(row.id) || 0), 0) + 1;
60
- }
61
-
62
- async find(options: Row = {}) {
63
- const filter = (options.filter as Row | undefined) || {};
64
- return this.rows.filter((row) => Object.entries(filter).every(([key, value]) => row[key] === value));
65
- }
66
-
67
- async findOne(options: Row) {
68
- if (options.filterByTk !== undefined) return this.rows.find((row) => row.id === options.filterByTk) || null;
69
- return (await this.find(options))[0] || null;
70
- }
71
-
72
- async create(options: Row) {
73
- const row = { id: this.nextId++, ...((options.values as Row | undefined) || {}) };
74
- this.rows.push(row);
75
- return row;
76
- }
77
-
78
- async update(options: Row) {
79
- const values = (options.values as Row | undefined) || {};
80
- for (const row of this.rows) {
81
- if (row.id === options.filterByTk) Object.assign(row, values);
82
- }
83
- }
84
- }
85
-
86
- function createDatabase(repositories: Map<string, MemoryRepository>) {
87
- return {
88
- getRepository(name: string) {
89
- const repository = repositories.get(name);
90
- if (!repository) throw new Error(`Unexpected repository ${name}`);
91
- return repository;
92
- },
93
- sequelize: {
94
- transaction<T>(callback: (value: { LOCK: { UPDATE: string } }) => Promise<T>) {
95
- return callback({ LOCK: { UPDATE: 'UPDATE' } });
96
- },
97
- },
98
- } as unknown as Database;
99
- }
100
-
101
- beforeEach(() => {
102
- invokeCalls.length = 0;
103
- resumeCalls.length = 0;
104
- resumeOutcome = { sessionId: 'session-1', messageId: 'message-2', interrupted: [], content: 'resumed done' };
105
- });
106
-
107
- function waitingRun(overrides: Row = {}) {
108
- return {
109
- id: 1,
110
- runtimeVersion: 'control-plane-v2',
111
- patternId: 1,
112
- userId: 7,
113
- status: 'waiting_approval',
114
- approvalStatus: 'pending',
115
- resumeContext: null,
116
- lockedBy: null,
117
- lockedUntil: null,
118
- ...overrides,
119
- };
120
- }
121
-
122
- function pendingApproval(overrides: Row = {}) {
123
- return {
124
- id: 10,
125
- runId: 1,
126
- toolCallId: 'call-1',
127
- toolName: 'editFile',
128
- inputHash: 'hash-1',
129
- status: 'pending',
130
- assignedToId: null,
131
- expiresAt: new Date(Date.now() + 3_600_000),
132
- consumedAt: null,
133
- decisionNote: null,
134
- editedInput: undefined,
135
- ...overrides,
136
- };
137
- }
138
-
139
- describe('LoopRunRepository.decideApproval', () => {
140
- function setup(runs: Row[], approvals: Row[]) {
141
- const repositories = new Map<string, MemoryRepository>([
142
- ['agentLoopRuns', new MemoryRepository(runs)],
143
- ['agentLoopActionApprovals', new MemoryRepository(approvals)],
144
- ['agentLoopEvents', new MemoryRepository()],
145
- ]);
146
- return { repositories, repository: new LoopRunRepository(createDatabase(repositories)) };
147
- }
148
-
149
- it('records the decision and requeues the run once every approval is decided', async () => {
150
- const { repositories, repository } = setup(
151
- [waitingRun()],
152
- [pendingApproval({ id: 10, status: 'approved', consumedAt: null }), pendingApproval({ id: 11 })],
153
- );
154
-
155
- const result = await repository.decideApproval({
156
- approvalId: 11,
157
- userId: 7,
158
- isAdmin: false,
159
- decision: 'approved',
160
- note: 'looks safe',
161
- });
162
-
163
- expect(result).toMatchObject({ status: 'approved', decidedById: 7, requeued: true });
164
- expect(repositories.get('agentLoopRuns')?.rows[0]).toMatchObject({ status: 'queued', approvalStatus: 'decided' });
165
- const decided = repositories.get('agentLoopActionApprovals')?.rows.find((row) => row.id === 11);
166
- expect(decided).toMatchObject({ status: 'approved', decidedById: 7, decisionNote: 'looks safe' });
167
- expect(decided?.decidedAt).toBeInstanceOf(Date);
168
-
169
- const events = repositories.get('agentLoopEvents')?.rows || [];
170
- expect(events).toHaveLength(1);
171
- expect(events[0]).toMatchObject({ runId: 1, type: 'run_approval_decided', actorType: 'human' });
172
- });
173
-
174
- it('records the decision but keeps the run parked while approvals remain pending', async () => {
175
- const { repositories, repository } = setup(
176
- [waitingRun()],
177
- [pendingApproval({ id: 10 }), pendingApproval({ id: 11 })],
178
- );
179
-
180
- const result = await repository.decideApproval({ approvalId: 10, userId: 7, isAdmin: false, decision: 'rejected' });
181
-
182
- expect(result).toMatchObject({ status: 'rejected', requeued: false });
183
- expect(repositories.get('agentLoopRuns')?.rows[0].status).toBe('waiting_approval');
184
- expect(repositories.get('agentLoopEvents')?.rows).toHaveLength(0);
185
- });
186
-
187
- it('stores editedInput only for approvals', async () => {
188
- const { repositories, repository } = setup([waitingRun()], [pendingApproval()]);
189
-
190
- await repository.decideApproval({
191
- approvalId: 10,
192
- userId: 7,
193
- isAdmin: false,
194
- decision: 'approved',
195
- editedInput: { path: '/tmp/safe.txt' },
196
- });
197
-
198
- expect(repositories.get('agentLoopActionApprovals')?.rows[0].editedInput).toEqual({ path: '/tmp/safe.txt' });
199
- });
200
-
201
- it('rejects a decision on an approval that is already decided', async () => {
202
- const { repository } = setup([waitingRun()], [pendingApproval({ status: 'approved' })]);
203
-
204
- await expect(
205
- repository.decideApproval({ approvalId: 10, userId: 7, isAdmin: false, decision: 'rejected' }),
206
- ).rejects.toMatchObject({ status: 409 });
207
- });
208
-
209
- it('rejects a decision once the approval window has expired', async () => {
210
- const { repositories, repository } = setup(
211
- [waitingRun()],
212
- [pendingApproval({ expiresAt: new Date(Date.now() - 1_000) })],
213
- );
214
-
215
- await expect(
216
- repository.decideApproval({ approvalId: 10, userId: 7, isAdmin: false, decision: 'approved' }),
217
- ).rejects.toMatchObject({ status: 409 });
218
- // Fail closed: the row stays pending for the reaper to expire, a late click cannot revive it.
219
- expect(repositories.get('agentLoopActionApprovals')?.rows[0].status).toBe('pending');
220
- });
221
-
222
- it('rejects a decision once the run has moved on', async () => {
223
- const { repository } = setup([waitingRun({ status: 'running' })], [pendingApproval()]);
224
-
225
- await expect(
226
- repository.decideApproval({ approvalId: 10, userId: 7, isAdmin: false, decision: 'approved' }),
227
- ).rejects.toMatchObject({ status: 409 });
228
- });
229
-
230
- it('records decisions for a paused run without requeueing it', async () => {
231
- const { repositories, repository } = setup([waitingRun({ status: 'paused' })], [pendingApproval()]);
232
-
233
- const result = await repository.decideApproval({
234
- approvalId: 10,
235
- userId: 7,
236
- isAdmin: false,
237
- decision: 'approved',
238
- });
239
-
240
- expect(result).toMatchObject({ status: 'approved', requeued: false });
241
- expect(repositories.get('agentLoopRuns')?.rows[0].status).toBe('paused');
242
- });
243
-
244
- it('refuses decisions from users who own neither the run nor the approval', async () => {
245
- const { repository } = setup([waitingRun()], [pendingApproval({ assignedToId: 8 })]);
246
-
247
- await expect(
248
- repository.decideApproval({ approvalId: 10, userId: 9, isAdmin: false, decision: 'approved' }),
249
- ).rejects.toMatchObject({ status: 403 });
250
- });
251
-
252
- it('lets the assigned approver decide even without owning the run', async () => {
253
- const { repository } = setup([waitingRun()], [pendingApproval({ assignedToId: 8 })]);
254
-
255
- const result = await repository.decideApproval({
256
- approvalId: 10,
257
- userId: 8,
258
- isAdmin: false,
259
- decision: 'approved',
260
- });
261
-
262
- expect(result).toMatchObject({ status: 'approved', decidedById: 8 });
263
- });
264
- });
265
-
266
- describe('LoopWorkerService approval resume-mode', () => {
267
- type WorkerInternals = { execute(claimed: { run: Row; leaseToken: string; leaseUntil: Date }): Promise<void> };
268
-
269
- function harnessSnapshot(allow: string[]) {
270
- return { effective: compileHarness([{ source: 'test', settings: { tools: { allow } } }]) };
271
- }
272
-
273
- const policy = loopPatternPolicySchema.parse({ maxConcurrency: 1 });
274
-
275
- function createWorker(run: Row, approvals: Row[] = []) {
276
- const repositories = new Map<string, MemoryRepository>([
277
- [
278
- 'agentLoopControlSettings',
279
- new MemoryRepository([
280
- { id: 1, key: 'global', state: 'running', acceptNewRuns: true, globalMaxConcurrency: 5 },
281
- ]),
282
- ],
283
- ['agentLoopRuns', new MemoryRepository([{ ...run }])],
284
- ['agentLoopActionApprovals', new MemoryRepository(approvals)],
285
- ['agentLoopEvents', new MemoryRepository()],
286
- ['agentLoopSteps', new MemoryRepository()],
287
- ['aiMessages', new MemoryRepository()],
288
- ['agentLoopUsageBuckets', new MemoryRepository()],
289
- ['agentLoopCircuitStates', new MemoryRepository()],
290
- ['agentLoopPathLocks', new MemoryRepository()],
291
- ['agentLoopArtifacts', new MemoryRepository()],
292
- ]);
293
- const app = {
294
- name: 'test',
295
- logger: { warn: vi.fn(), error: vi.fn(), info: vi.fn() },
296
- log: { warn: vi.fn(), error: vi.fn(), info: vi.fn() },
297
- lockManager: { runExclusive: <T>(_key: string, operation: () => Promise<T>) => operation() },
298
- };
299
- const worker = new LoopWorkerService(app as unknown as Application, createDatabase(repositories));
300
- return { repositories, worker: worker as unknown as WorkerInternals };
301
- }
302
-
303
- function resumedRun(overrides: Row = {}) {
304
- return {
305
- id: 1,
306
- runtimeVersion: 'control-plane-v2',
307
- patternId: 1,
308
- userId: 7,
309
- status: 'preparing',
310
- lockedBy: 'worker-a:lease',
311
- lockedUntil: new Date(Date.now() + 60_000),
312
- goal: 'Ship the feature',
313
- autonomyLevel: 'L1',
314
- policySnapshot: policy,
315
- roleBindingsSnapshot: { leader: 'lead', makers: ['maker-one', 'maker-two'], verifier: 'checker' },
316
- leaderHarnessSnapshot: harnessSnapshot(['readFile']),
317
- makerHarnessSnapshot: {
318
- 'maker-one': harnessSnapshot(['editFile']),
319
- 'maker-two': harnessSnapshot(['runTests']),
320
- },
321
- verifierHarnessSnapshot: harnessSnapshot(['readFile']),
322
- repositoryKey: '',
323
- actingOn: [],
324
- approvalStatus: 'decided',
325
- resumeContext: {
326
- role: 'maker',
327
- username: 'maker-one',
328
- sessionId: 'session-1',
329
- messageId: 'message-1',
330
- makerReports: ['the leader plan'],
331
- makerQueue: ['maker-two'],
332
- },
333
- ...overrides,
334
- };
335
- }
336
-
337
- function claimed(run: Row) {
338
- return { run, leaseToken: 'worker-a:lease', leaseUntil: new Date(Date.now() + 60_000) };
339
- }
340
-
341
- it('resumes the interrupted role instead of restarting from the leader', async () => {
342
- const run = resumedRun();
343
- const { repositories, worker } = createWorker(run, [
344
- pendingApproval({ status: 'approved', decidedById: 7, consumedAt: null }),
345
- ]);
346
-
347
- await worker.execute(claimed(run));
348
-
349
- expect(resumeCalls).toHaveLength(1);
350
- expect(resumeCalls[0]).toMatchObject({
351
- username: 'maker-one',
352
- sessionId: 'session-1',
353
- messageId: 'message-1',
354
- decisions: [{ toolCallId: 'call-1', decision: { type: 'approve' } }],
355
- });
356
- // Only the makers still queued run; the leader and completed makers are not re-invoked.
357
- expect(invokeCalls.map((call) => call.username)).toEqual(['maker-two']);
358
- expect(repositories.get('agentLoopRuns')?.rows[0].status).toBe('verifying');
359
- });
360
-
361
- it('maps edited and rejected approvals onto plugin-ai decisions', async () => {
362
- const run = resumedRun();
363
- const { worker } = createWorker(run, [
364
- pendingApproval({
365
- id: 10,
366
- toolCallId: 'call-1',
367
- status: 'approved',
368
- editedInput: { path: '/tmp/safe.txt' },
369
- consumedAt: null,
370
- }),
371
- pendingApproval({
372
- id: 11,
373
- toolCallId: 'call-2',
374
- status: 'rejected',
375
- decisionNote: 'too risky',
376
- consumedAt: null,
377
- }),
378
- ]);
379
-
380
- await worker.execute(claimed(run));
381
-
382
- expect(resumeCalls[0].decisions).toEqual([
383
- {
384
- toolCallId: 'call-1',
385
- decision: { type: 'edit', editedAction: { name: 'editFile', args: { path: '/tmp/safe.txt' } } },
386
- },
387
- { toolCallId: 'call-2', decision: { type: 'reject', message: 'too risky' } },
388
- ]);
389
- });
390
-
391
- it('consumes each decision exactly once', async () => {
392
- const run = resumedRun();
393
- const { repositories, worker } = createWorker(run, [pendingApproval({ status: 'approved', consumedAt: null })]);
394
-
395
- await worker.execute(claimed(run));
396
-
397
- const approval = repositories.get('agentLoopActionApprovals')?.rows[0];
398
- expect(approval?.consumedAt).toBeInstanceOf(Date);
399
- });
400
-
401
- it('parks again with the same resume point when the resumed call hits another gate', async () => {
402
- resumeOutcome = {
403
- sessionId: 'session-1',
404
- messageId: 'message-3',
405
- interrupted: [{ toolCallId: 'call-9', toolName: 'runShell', args: { cmd: 'rm' }, interruptId: 'int-9' }],
406
- content: '',
407
- };
408
- const run = resumedRun();
409
- const { repositories, worker } = createWorker(run, [pendingApproval({ status: 'approved', consumedAt: null })]);
410
-
411
- await worker.execute(claimed(run));
412
-
413
- const row = repositories.get('agentLoopRuns')?.rows[0];
414
- expect(row?.status).toBe('waiting_approval');
415
- expect(row?.approvalStatus).toBe('pending');
416
- // The queue and reports survive the second gate, so the next resume continues in place.
417
- expect(row?.resumeContext).toMatchObject({
418
- role: 'maker',
419
- username: 'maker-one',
420
- messageId: 'message-3',
421
- makerQueue: ['maker-two'],
422
- makerReports: ['the leader plan'],
423
- });
424
- const approvals = repositories.get('agentLoopActionApprovals')?.rows || [];
425
- expect(approvals.filter((approval) => approval.status === 'pending')).toHaveLength(1);
426
- expect(approvals[approvals.length - 1]).toMatchObject({ toolCallId: 'call-9' });
427
- });
428
-
429
- it('tags approvals for escalatable tools as escalations', async () => {
430
- resumeOutcome = {
431
- sessionId: 'session-1',
432
- messageId: 'message-3',
433
- interrupted: [
434
- { toolCallId: 'call-9', toolName: 'runShell', args: { cmd: 'ls' }, interruptId: 'int-9' },
435
- { toolCallId: 'call-10', toolName: 'editFile', args: { path: '/tmp/x' }, interruptId: 'int-10' },
436
- ],
437
- content: '',
438
- };
439
- const run = resumedRun({
440
- makerHarnessSnapshot: {
441
- 'maker-one': {
442
- // runShell is not granted but escalatable; editFile is granted yet still ask-gated here
443
- // because the interrupted call reached the approval gate through the plan.
444
- effective: compileHarness([
445
- { source: 'test', settings: { tools: { allow: ['editFile'], escalate: ['runShell'] } } },
446
- ]),
447
- },
448
- 'maker-two': harnessSnapshot(['runTests']),
449
- },
450
- });
451
- const { repositories, worker } = createWorker(run, [pendingApproval({ status: 'approved', consumedAt: null })]);
452
-
453
- await worker.execute(claimed(run));
454
-
455
- const approvals = repositories.get('agentLoopActionApprovals')?.rows || [];
456
- const escalation = approvals.find((approval) => approval.toolCallId === 'call-9');
457
- const plain = approvals.find((approval) => approval.toolCallId === 'call-10');
458
- expect(escalation).toMatchObject({
459
- actionType: 'escalation',
460
- toolName: 'runShell',
461
- status: 'pending',
462
- });
463
- expect(String(escalation?.reason)).toContain('widens authority for this single call only');
464
- expect(plain).toMatchObject({ actionType: 'tool_call', toolName: 'editFile' });
465
- expect(String(plain?.reason)).toContain('requires human approval');
466
- });
467
-
468
- it('re-parks a requeued run whose decisions never arrived', async () => {
469
- const run = resumedRun({ approvalStatus: 'pending' });
470
- const { repositories, worker } = createWorker(run, [pendingApproval()]);
471
-
472
- await worker.execute(claimed(run));
473
-
474
- expect(resumeCalls).toHaveLength(0);
475
- expect(invokeCalls).toHaveLength(0);
476
- expect(repositories.get('agentLoopRuns')?.rows[0].status).toBe('waiting_approval');
477
- });
478
-
479
- it('ignores a stale resume context left behind by an expired window', async () => {
480
- // The reaper blocks expired runs; a later retry clears approvalStatus to null. Either way the
481
- // saved context must not replay an old conversation, so the run starts fresh from the leader.
482
- const run = resumedRun({ approvalStatus: 'expired' });
483
- const { worker } = createWorker(run, []);
484
-
485
- await worker.execute(claimed(run));
486
-
487
- expect(resumeCalls).toHaveLength(0);
488
- expect(invokeCalls.map((call) => call.username)).toEqual(['lead', 'maker-one', 'maker-two']);
489
- });
490
-
491
- it('resumes the leader into a full maker pass', async () => {
492
- const run = resumedRun({
493
- resumeContext: {
494
- role: 'leader',
495
- username: 'lead',
496
- sessionId: 'session-1',
497
- messageId: 'message-1',
498
- makerReports: [],
499
- makerQueue: ['maker-one', 'maker-two'],
500
- },
501
- });
502
- resumeOutcome = { sessionId: 'session-1', messageId: 'message-2', interrupted: [], content: 'the resumed plan' };
503
- const { worker } = createWorker(run, [pendingApproval({ status: 'approved', consumedAt: null })]);
504
-
505
- await worker.execute(claimed(run));
506
-
507
- expect(resumeCalls).toHaveLength(1);
508
- expect(invokeCalls.map((call) => call.username)).toEqual(['maker-one', 'maker-two']);
509
- // The resumed leader content replaces the plan handed to the makers.
510
- expect(invokeCalls[0].prompt).toContain('the resumed plan');
511
- });
512
- });
1
+ // SPDX-License-Identifier: Apache-2.0
2
+
3
+ import type { Database } from '@nocobase/database';
4
+ import type { Application } from '@nocobase/server';
5
+ import { beforeEach, describe, expect, it, vi } from 'vitest';
6
+ import { compileHarness } from '../services/HarnessCompiler';
7
+ import type { CompiledHarness } from '../services/HarnessCompiler';
8
+ import { loopPatternPolicySchema } from '../services/LoopPatternSchema';
9
+
10
+ type Row = Record<string, unknown>;
11
+
12
+ type InvokeCall = { username: string; prompt: string; harness: CompiledHarness };
13
+ type ResumeCall = {
14
+ username: string;
15
+ sessionId: string;
16
+ messageId: string;
17
+ decisions: Array<{ toolCallId: string; decision: { type: string; message?: string; editedAction?: unknown } }>;
18
+ };
19
+ type ResumeOutcome = {
20
+ sessionId: string;
21
+ messageId: string;
22
+ interrupted: Array<{ toolCallId: string; toolName: string; args: unknown; interruptId: string }>;
23
+ content: string;
24
+ };
25
+
26
+ const invokeCalls: InvokeCall[] = [];
27
+ const resumeCalls: ResumeCall[] = [];
28
+ let resumeOutcome: ResumeOutcome = { sessionId: 'session-1', messageId: 'message-2', interrupted: [], content: '' };
29
+
30
+ vi.mock('../services/PluginAiRuntimeAdapter', () => ({
31
+ PluginAiRuntimeAdapter: class {
32
+ async createConversation() {
33
+ return 'session-1';
34
+ }
35
+ async invoke(input: InvokeCall) {
36
+ invokeCalls.push(input);
37
+ return { sessionId: 'session-1', messageId: 'message-1', interrupted: [], content: `${input.username} done` };
38
+ }
39
+ async resume(input: ResumeCall) {
40
+ resumeCalls.push(input);
41
+ return resumeOutcome;
42
+ }
43
+ },
44
+ }));
45
+
46
+ vi.mock('../services/VerificationService', () => ({
47
+ VerificationService: class {
48
+ async verifyAndFinalize() {
49
+ return { verdict: { verdict: 'pass' }, finalStatus: 'succeeded' as const };
50
+ }
51
+ },
52
+ }));
53
+
54
+ const { LoopRunRepository } = await import('../services/LoopRunRepository');
55
+ const { LoopRunStateMachine } = await import('../services/LoopRunStateMachine');
56
+ const { LoopWorkerService } = await import('../services/LoopWorkerService');
57
+
58
+ class MemoryRepository {
59
+ private nextId = 1;
60
+
61
+ constructor(readonly rows: Row[] = []) {
62
+ this.nextId = rows.reduce((maximum, row) => Math.max(maximum, Number(row.id) || 0), 0) + 1;
63
+ }
64
+
65
+ async find(options: Row = {}) {
66
+ const filter = (options.filter as Row | undefined) || {};
67
+ return this.rows.filter((row) =>
68
+ Object.entries(filter).every(([key, value]) => {
69
+ if (value && typeof value === 'object' && '$in' in value && Array.isArray(value.$in)) {
70
+ return value.$in.includes(row[key]);
71
+ }
72
+ return row[key] === value;
73
+ }),
74
+ );
75
+ }
76
+
77
+ async findOne(options: Row) {
78
+ if (options.filterByTk !== undefined) return this.rows.find((row) => row.id === options.filterByTk) || null;
79
+ return (await this.find(options))[0] || null;
80
+ }
81
+
82
+ async count(options: Row = {}) {
83
+ return (await this.find(options)).length;
84
+ }
85
+
86
+ async create(options: Row) {
87
+ const row = { id: this.nextId++, ...((options.values as Row | undefined) || {}) };
88
+ this.rows.push(row);
89
+ return row;
90
+ }
91
+
92
+ async update(options: Row) {
93
+ const values = (options.values as Row | undefined) || {};
94
+ for (const row of this.rows) {
95
+ if (row.id === options.filterByTk) Object.assign(row, values);
96
+ }
97
+ }
98
+ }
99
+
100
+ class UniqueEventRepository extends MemoryRepository {
101
+ async create(options: Row) {
102
+ const values = (options.values as Row | undefined) || {};
103
+ const duplicate =
104
+ values.correlationKey !== undefined &&
105
+ values.correlationKey !== null &&
106
+ this.rows.some(
107
+ (row) => row.runId === values.runId && row.type === values.type && row.correlationKey === values.correlationKey,
108
+ );
109
+ if (duplicate) throw new Error('Unique constraint violation on (runId, type, correlationKey)');
110
+ return super.create(options);
111
+ }
112
+ }
113
+
114
+ function createDatabase(repositories: Map<string, MemoryRepository>) {
115
+ return {
116
+ getRepository(name: string) {
117
+ const repository = repositories.get(name);
118
+ if (!repository) throw new Error(`Unexpected repository ${name}`);
119
+ return repository;
120
+ },
121
+ sequelize: {
122
+ transaction<T>(callback: (value: { LOCK: { UPDATE: string } }) => Promise<T>) {
123
+ return callback({ LOCK: { UPDATE: 'UPDATE' } });
124
+ },
125
+ },
126
+ } as unknown as Database;
127
+ }
128
+
129
+ beforeEach(() => {
130
+ invokeCalls.length = 0;
131
+ resumeCalls.length = 0;
132
+ resumeOutcome = { sessionId: 'session-1', messageId: 'message-2', interrupted: [], content: 'resumed done' };
133
+ });
134
+
135
+ function waitingRun(overrides: Row = {}) {
136
+ return {
137
+ id: 1,
138
+ runtimeVersion: 'control-plane-v2',
139
+ patternId: 1,
140
+ userId: 7,
141
+ status: 'waiting_approval',
142
+ approvalStatus: 'pending',
143
+ resumeContext: null,
144
+ lockedBy: null,
145
+ lockedUntil: null,
146
+ ...overrides,
147
+ };
148
+ }
149
+
150
+ function pendingApproval(overrides: Row = {}) {
151
+ return {
152
+ id: 10,
153
+ runId: 1,
154
+ toolCallId: 'call-1',
155
+ toolName: 'editFile',
156
+ inputHash: 'hash-1',
157
+ status: 'pending',
158
+ assignedToId: null,
159
+ expiresAt: new Date(Date.now() + 3_600_000),
160
+ consumedAt: null,
161
+ decisionNote: null,
162
+ editedInput: undefined,
163
+ ...overrides,
164
+ };
165
+ }
166
+
167
+ describe('LoopRunRepository.decideApproval', () => {
168
+ function setup(runs: Row[], approvals: Row[]) {
169
+ const repositories = new Map<string, MemoryRepository>([
170
+ ['agentLoopRuns', new MemoryRepository(runs)],
171
+ ['agentLoopActionApprovals', new MemoryRepository(approvals)],
172
+ ['agentLoopEvents', new UniqueEventRepository()],
173
+ ]);
174
+ return { repositories, repository: new LoopRunRepository(createDatabase(repositories)) };
175
+ }
176
+
177
+ it('records the decision and requeues the run once every approval is decided', async () => {
178
+ const { repositories, repository } = setup(
179
+ [waitingRun()],
180
+ [pendingApproval({ id: 10, status: 'approved', consumedAt: null }), pendingApproval({ id: 11 })],
181
+ );
182
+
183
+ const result = await repository.decideApproval({
184
+ approvalId: 11,
185
+ userId: 7,
186
+ isAdmin: false,
187
+ decision: 'approved',
188
+ note: 'looks safe',
189
+ });
190
+
191
+ expect(result).toMatchObject({ status: 'approved', decidedById: 7, requeued: true });
192
+ expect(repositories.get('agentLoopRuns')?.rows[0]).toMatchObject({ status: 'queued', approvalStatus: 'decided' });
193
+ const decided = repositories.get('agentLoopActionApprovals')?.rows.find((row) => row.id === 11);
194
+ expect(decided).toMatchObject({ status: 'approved', decidedById: 7, decisionNote: 'looks safe' });
195
+ expect(decided?.decidedAt).toBeInstanceOf(Date);
196
+
197
+ const events = repositories.get('agentLoopEvents')?.rows || [];
198
+ expect(events).toHaveLength(1);
199
+ expect(events[0]).toMatchObject({ runId: 1, type: 'run_approval_decided', actorType: 'human' });
200
+ });
201
+
202
+ it('uses distinct event keys for successive approval rounds on one run', async () => {
203
+ const { repositories, repository } = setup([waitingRun()], [pendingApproval()]);
204
+
205
+ const first = await repository.decideApproval({
206
+ approvalId: 10,
207
+ userId: 7,
208
+ isAdmin: false,
209
+ decision: 'approved',
210
+ });
211
+ expect(first.requeued).toBe(true);
212
+
213
+ const approvals = repositories.get('agentLoopActionApprovals');
214
+ const runs = repositories.get('agentLoopRuns');
215
+ if (!approvals || !runs) throw new Error('Approval test repositories are missing.');
216
+ await approvals.create({ values: pendingApproval({ id: 11, toolCallId: 'call-2', inputHash: 'hash-2' }) });
217
+ await runs.update({ filterByTk: 1, values: { status: 'waiting_approval', approvalStatus: 'pending' } });
218
+
219
+ const second = await repository.decideApproval({
220
+ approvalId: 11,
221
+ userId: 7,
222
+ isAdmin: false,
223
+ decision: 'rejected',
224
+ });
225
+
226
+ expect(second.requeued).toBe(true);
227
+ const events = repositories.get('agentLoopEvents')?.rows || [];
228
+ expect(events).toHaveLength(2);
229
+ expect(events[0].correlationKey).not.toBe(events[1].correlationKey);
230
+ expect(new Set(events.map((event) => `${event.runId}:${event.type}:${event.correlationKey}`)).size).toBe(2);
231
+ });
232
+
233
+ it('records the decision but keeps the run parked while approvals remain pending', async () => {
234
+ const { repositories, repository } = setup(
235
+ [waitingRun()],
236
+ [pendingApproval({ id: 10 }), pendingApproval({ id: 11 })],
237
+ );
238
+
239
+ const result = await repository.decideApproval({ approvalId: 10, userId: 7, isAdmin: false, decision: 'rejected' });
240
+
241
+ expect(result).toMatchObject({ status: 'rejected', requeued: false });
242
+ expect(repositories.get('agentLoopRuns')?.rows[0].status).toBe('waiting_approval');
243
+ expect(repositories.get('agentLoopEvents')?.rows).toHaveLength(0);
244
+ });
245
+
246
+ it('stores editedInput only for approvals', async () => {
247
+ const { repositories, repository } = setup([waitingRun()], [pendingApproval()]);
248
+
249
+ await repository.decideApproval({
250
+ approvalId: 10,
251
+ userId: 7,
252
+ isAdmin: false,
253
+ decision: 'approved',
254
+ editedInput: { path: '/tmp/safe.txt' },
255
+ });
256
+
257
+ expect(repositories.get('agentLoopActionApprovals')?.rows[0].editedInput).toEqual({ path: '/tmp/safe.txt' });
258
+ });
259
+
260
+ it('rejects a decision on an approval that is already decided', async () => {
261
+ const { repository } = setup([waitingRun()], [pendingApproval({ status: 'approved' })]);
262
+
263
+ await expect(
264
+ repository.decideApproval({ approvalId: 10, userId: 7, isAdmin: false, decision: 'rejected' }),
265
+ ).rejects.toMatchObject({ status: 409 });
266
+ });
267
+
268
+ it('rejects a decision once the approval window has expired', async () => {
269
+ const { repositories, repository } = setup(
270
+ [waitingRun()],
271
+ [pendingApproval({ expiresAt: new Date(Date.now() - 1_000) })],
272
+ );
273
+
274
+ await expect(
275
+ repository.decideApproval({ approvalId: 10, userId: 7, isAdmin: false, decision: 'approved' }),
276
+ ).rejects.toMatchObject({ status: 409 });
277
+ // Fail closed: the row stays pending for the reaper to expire, a late click cannot revive it.
278
+ expect(repositories.get('agentLoopActionApprovals')?.rows[0].status).toBe('pending');
279
+ });
280
+
281
+ it('rejects a decision once the run has moved on', async () => {
282
+ const { repository } = setup([waitingRun({ status: 'running' })], [pendingApproval()]);
283
+
284
+ await expect(
285
+ repository.decideApproval({ approvalId: 10, userId: 7, isAdmin: false, decision: 'approved' }),
286
+ ).rejects.toMatchObject({ status: 409 });
287
+ });
288
+
289
+ it('records decisions for a paused run without requeueing it', async () => {
290
+ const { repositories, repository } = setup([waitingRun({ status: 'paused' })], [pendingApproval()]);
291
+
292
+ const result = await repository.decideApproval({
293
+ approvalId: 10,
294
+ userId: 7,
295
+ isAdmin: false,
296
+ decision: 'approved',
297
+ });
298
+
299
+ expect(result).toMatchObject({ status: 'approved', requeued: false });
300
+ expect(repositories.get('agentLoopRuns')?.rows[0]).toMatchObject({
301
+ status: 'paused',
302
+ approvalStatus: 'decided',
303
+ });
304
+ });
305
+
306
+ it('keeps a paused run pending until all approvals have decisions', async () => {
307
+ const { repositories, repository } = setup(
308
+ [waitingRun({ status: 'paused' })],
309
+ [pendingApproval(), pendingApproval({ id: 11 })],
310
+ );
311
+
312
+ await repository.decideApproval({ approvalId: 10, userId: 7, isAdmin: false, decision: 'approved' });
313
+
314
+ expect(repositories.get('agentLoopRuns')?.rows[0]).toMatchObject({
315
+ status: 'paused',
316
+ approvalStatus: 'pending',
317
+ });
318
+ });
319
+
320
+ it('refuses decisions from users who own neither the run nor the approval', async () => {
321
+ const { repository } = setup([waitingRun()], [pendingApproval({ assignedToId: 8 })]);
322
+
323
+ await expect(
324
+ repository.decideApproval({ approvalId: 10, userId: 9, isAdmin: false, decision: 'approved' }),
325
+ ).rejects.toMatchObject({ status: 403 });
326
+ });
327
+
328
+ it('lets the assigned approver decide even without owning the run', async () => {
329
+ const { repository } = setup([waitingRun()], [pendingApproval({ assignedToId: 8 })]);
330
+
331
+ const result = await repository.decideApproval({
332
+ approvalId: 10,
333
+ userId: 8,
334
+ isAdmin: false,
335
+ decision: 'approved',
336
+ });
337
+
338
+ expect(result).toMatchObject({ status: 'approved', decidedById: 8 });
339
+ });
340
+ });
341
+
342
+ describe('LoopWorkerService approval resume-mode', () => {
343
+ type WorkerInternals = { execute(claimed: { run: Row; leaseToken: string; leaseUntil: Date }): Promise<void> };
344
+
345
+ function harnessSnapshot(allow: string[]) {
346
+ return { effective: compileHarness([{ source: 'test', settings: { tools: { allow } } }]) };
347
+ }
348
+
349
+ const policy = loopPatternPolicySchema.parse({ maxConcurrency: 1 });
350
+
351
+ function createWorker(run: Row, approvals: Row[] = [], events: Row[] = []) {
352
+ const repositories = new Map<string, MemoryRepository>([
353
+ [
354
+ 'agentLoopControlSettings',
355
+ new MemoryRepository([
356
+ { id: 1, key: 'global', state: 'running', acceptNewRuns: true, globalMaxConcurrency: 5 },
357
+ ]),
358
+ ],
359
+ ['agentLoopRuns', new MemoryRepository([{ ...run }])],
360
+ ['agentLoopPatterns', new MemoryRepository([{ id: 1, enabled: true }])],
361
+ ['agentLoopActionApprovals', new MemoryRepository(approvals)],
362
+ ['agentLoopEvents', new UniqueEventRepository(events)],
363
+ ['agentLoopSteps', new MemoryRepository()],
364
+ ['aiMessages', new MemoryRepository()],
365
+ ['agentLoopUsageBuckets', new MemoryRepository()],
366
+ ['agentLoopCircuitStates', new MemoryRepository()],
367
+ ['agentLoopPathLocks', new MemoryRepository()],
368
+ ['agentLoopArtifacts', new MemoryRepository()],
369
+ ]);
370
+ const app = {
371
+ name: 'test',
372
+ logger: { warn: vi.fn(), error: vi.fn(), info: vi.fn() },
373
+ log: { warn: vi.fn(), error: vi.fn(), info: vi.fn() },
374
+ lockManager: { runExclusive: <T>(_key: string, operation: () => Promise<T>) => operation() },
375
+ };
376
+ const database = createDatabase(repositories);
377
+ const worker = new LoopWorkerService(app as unknown as Application, database);
378
+ return { repositories, database, worker: worker as unknown as WorkerInternals };
379
+ }
380
+
381
+ function resumedRun(overrides: Row = {}) {
382
+ return {
383
+ id: 1,
384
+ runtimeVersion: 'control-plane-v2',
385
+ patternId: 1,
386
+ userId: 7,
387
+ status: 'preparing',
388
+ lockedBy: 'worker-a:lease',
389
+ lockedUntil: new Date(Date.now() + 60_000),
390
+ goal: 'Ship the feature',
391
+ autonomyLevel: 'L1',
392
+ policySnapshot: policy,
393
+ roleBindingsSnapshot: { leader: 'lead', makers: ['maker-one', 'maker-two'], verifier: 'checker' },
394
+ leaderHarnessSnapshot: harnessSnapshot(['readFile']),
395
+ makerHarnessSnapshot: {
396
+ 'maker-one': harnessSnapshot(['editFile']),
397
+ 'maker-two': harnessSnapshot(['runTests']),
398
+ },
399
+ verifierHarnessSnapshot: harnessSnapshot(['readFile']),
400
+ repositoryKey: '',
401
+ actingOn: [],
402
+ approvalStatus: 'decided',
403
+ resumeContext: {
404
+ role: 'maker',
405
+ username: 'maker-one',
406
+ sessionId: 'session-1',
407
+ messageId: 'message-1',
408
+ makerReports: ['the leader plan'],
409
+ makerQueue: ['maker-two'],
410
+ },
411
+ ...overrides,
412
+ };
413
+ }
414
+
415
+ function claimed(run: Row) {
416
+ return { run, leaseToken: 'worker-a:lease', leaseUntil: new Date(Date.now() + 60_000) };
417
+ }
418
+
419
+ it('resumes the interrupted role instead of restarting from the leader', async () => {
420
+ const run = resumedRun();
421
+ const { repositories, worker } = createWorker(run, [
422
+ pendingApproval({ status: 'approved', decidedById: 7, consumedAt: null }),
423
+ ]);
424
+
425
+ await worker.execute(claimed(run));
426
+
427
+ expect(resumeCalls).toHaveLength(1);
428
+ expect(resumeCalls[0]).toMatchObject({
429
+ username: 'maker-one',
430
+ sessionId: 'session-1',
431
+ messageId: 'message-1',
432
+ decisions: [{ toolCallId: 'call-1', decision: { type: 'approve' } }],
433
+ });
434
+ // Only the makers still queued run; the leader and completed makers are not re-invoked.
435
+ expect(invokeCalls.map((call) => call.username)).toEqual(['maker-two']);
436
+ expect(repositories.get('agentLoopRuns')?.rows[0].status).toBe('verifying');
437
+ });
438
+
439
+ it.each(['approved', 'rejected'] as const)(
440
+ 'resumes the interrupted role after a paused approval is %s and the owner resumes the run',
441
+ async (decision) => {
442
+ const run = resumedRun({ status: 'paused', approvalStatus: 'pending', lockedBy: null, lockedUntil: null });
443
+ const { repositories, database, worker } = createWorker(
444
+ run,
445
+ [pendingApproval()],
446
+ [{ id: 20, runId: 1, type: 'run_started', correlationKey: 'started:1' }],
447
+ );
448
+ const repository = new LoopRunRepository(database);
449
+ const stateMachine = new LoopRunStateMachine(database);
450
+
451
+ await repository.decideApproval({ approvalId: 10, userId: 7, isAdmin: false, decision });
452
+ await stateMachine.transition({ runId: 1, to: 'queued', actorType: 'human', actorIdentity: '7' });
453
+ const nextClaim = await stateMachine.claimNext('worker-a', 60_000);
454
+ if (!nextClaim) throw new Error('Expected the resumed run to be claimed.');
455
+ await worker.execute(nextClaim);
456
+
457
+ expect(resumeCalls).toHaveLength(1);
458
+ expect(resumeCalls[0]).toMatchObject({
459
+ username: 'maker-one',
460
+ decisions: [{ toolCallId: 'call-1', decision: { type: decision === 'approved' ? 'approve' : 'reject' } }],
461
+ });
462
+ expect(invokeCalls.map((call) => call.username)).toEqual(['maker-two']);
463
+ expect(repositories.get('agentLoopActionApprovals')?.rows[0].consumedAt).toBeInstanceOf(Date);
464
+ expect(repositories.get('agentLoopRuns')?.rows[0].status).toBe('verifying');
465
+ const startedEvents = (repositories.get('agentLoopEvents')?.rows || []).filter(
466
+ (event) => event.type === 'run_started',
467
+ );
468
+ expect(startedEvents).toHaveLength(2);
469
+ expect(startedEvents[0].correlationKey).not.toBe(startedEvents[1].correlationKey);
470
+ },
471
+ );
472
+
473
+ it('maps edited and rejected approvals onto plugin-ai decisions', async () => {
474
+ const run = resumedRun();
475
+ const { worker } = createWorker(run, [
476
+ pendingApproval({
477
+ id: 10,
478
+ toolCallId: 'call-1',
479
+ status: 'approved',
480
+ editedInput: { path: '/tmp/safe.txt' },
481
+ consumedAt: null,
482
+ }),
483
+ pendingApproval({
484
+ id: 11,
485
+ toolCallId: 'call-2',
486
+ status: 'rejected',
487
+ decisionNote: 'too risky',
488
+ consumedAt: null,
489
+ }),
490
+ ]);
491
+
492
+ await worker.execute(claimed(run));
493
+
494
+ expect(resumeCalls[0].decisions).toEqual([
495
+ {
496
+ toolCallId: 'call-1',
497
+ decision: { type: 'edit', editedAction: { name: 'editFile', args: { path: '/tmp/safe.txt' } } },
498
+ },
499
+ { toolCallId: 'call-2', decision: { type: 'reject', message: 'too risky' } },
500
+ ]);
501
+ });
502
+
503
+ it('consumes each decision exactly once', async () => {
504
+ const run = resumedRun();
505
+ const { repositories, worker } = createWorker(run, [pendingApproval({ status: 'approved', consumedAt: null })]);
506
+
507
+ await worker.execute(claimed(run));
508
+
509
+ const approval = repositories.get('agentLoopActionApprovals')?.rows[0];
510
+ expect(approval?.consumedAt).toBeInstanceOf(Date);
511
+ });
512
+
513
+ it('parks again with the same resume point when the resumed call hits another gate', async () => {
514
+ resumeOutcome = {
515
+ sessionId: 'session-1',
516
+ messageId: 'message-3',
517
+ interrupted: [{ toolCallId: 'call-9', toolName: 'runShell', args: { cmd: 'rm' }, interruptId: 'int-9' }],
518
+ content: '',
519
+ };
520
+ const run = resumedRun();
521
+ const { repositories, worker } = createWorker(run, [pendingApproval({ status: 'approved', consumedAt: null })]);
522
+
523
+ await worker.execute(claimed(run));
524
+
525
+ const row = repositories.get('agentLoopRuns')?.rows[0];
526
+ expect(row?.status).toBe('waiting_approval');
527
+ expect(row?.approvalStatus).toBe('pending');
528
+ // The queue and reports survive the second gate, so the next resume continues in place.
529
+ expect(row?.resumeContext).toMatchObject({
530
+ role: 'maker',
531
+ username: 'maker-one',
532
+ messageId: 'message-3',
533
+ makerQueue: ['maker-two'],
534
+ makerReports: ['the leader plan'],
535
+ });
536
+ const approvals = repositories.get('agentLoopActionApprovals')?.rows || [];
537
+ expect(approvals.filter((approval) => approval.status === 'pending')).toHaveLength(1);
538
+ expect(approvals[approvals.length - 1]).toMatchObject({ toolCallId: 'call-9' });
539
+ });
540
+
541
+ it('tags approvals for escalatable tools as escalations', async () => {
542
+ resumeOutcome = {
543
+ sessionId: 'session-1',
544
+ messageId: 'message-3',
545
+ interrupted: [
546
+ { toolCallId: 'call-9', toolName: 'runShell', args: { cmd: 'ls' }, interruptId: 'int-9' },
547
+ { toolCallId: 'call-10', toolName: 'editFile', args: { path: '/tmp/x' }, interruptId: 'int-10' },
548
+ ],
549
+ content: '',
550
+ };
551
+ const run = resumedRun({
552
+ makerHarnessSnapshot: {
553
+ 'maker-one': {
554
+ // runShell is not granted but escalatable; editFile is granted yet still ask-gated here
555
+ // because the interrupted call reached the approval gate through the plan.
556
+ effective: compileHarness([
557
+ { source: 'test', settings: { tools: { allow: ['editFile'], escalate: ['runShell'] } } },
558
+ ]),
559
+ },
560
+ 'maker-two': harnessSnapshot(['runTests']),
561
+ },
562
+ });
563
+ const { repositories, worker } = createWorker(run, [pendingApproval({ status: 'approved', consumedAt: null })]);
564
+
565
+ await worker.execute(claimed(run));
566
+
567
+ const approvals = repositories.get('agentLoopActionApprovals')?.rows || [];
568
+ const escalation = approvals.find((approval) => approval.toolCallId === 'call-9');
569
+ const plain = approvals.find((approval) => approval.toolCallId === 'call-10');
570
+ expect(escalation).toMatchObject({
571
+ actionType: 'escalation',
572
+ toolName: 'runShell',
573
+ status: 'pending',
574
+ });
575
+ expect(String(escalation?.reason)).toContain('widens authority for this single call only');
576
+ expect(plain).toMatchObject({ actionType: 'tool_call', toolName: 'editFile' });
577
+ expect(String(plain?.reason)).toContain('requires human approval');
578
+ });
579
+
580
+ it('re-parks a requeued run whose decisions never arrived', async () => {
581
+ const run = resumedRun({ approvalStatus: 'pending' });
582
+ const { repositories, worker } = createWorker(run, [pendingApproval()]);
583
+
584
+ await worker.execute(claimed(run));
585
+
586
+ expect(resumeCalls).toHaveLength(0);
587
+ expect(invokeCalls).toHaveLength(0);
588
+ expect(repositories.get('agentLoopRuns')?.rows[0].status).toBe('waiting_approval');
589
+ });
590
+
591
+ it('ignores a stale resume context left behind by an expired window', async () => {
592
+ // The reaper blocks expired runs; a later retry clears approvalStatus to null. Either way the
593
+ // saved context must not replay an old conversation, so the run starts fresh from the leader.
594
+ const run = resumedRun({ approvalStatus: 'expired' });
595
+ const { worker } = createWorker(run, []);
596
+
597
+ await worker.execute(claimed(run));
598
+
599
+ expect(resumeCalls).toHaveLength(0);
600
+ expect(invokeCalls.map((call) => call.username)).toEqual(['lead', 'maker-one', 'maker-two']);
601
+ });
602
+
603
+ it('resumes the leader into a full maker pass', async () => {
604
+ const run = resumedRun({
605
+ resumeContext: {
606
+ role: 'leader',
607
+ username: 'lead',
608
+ sessionId: 'session-1',
609
+ messageId: 'message-1',
610
+ makerReports: [],
611
+ makerQueue: ['maker-one', 'maker-two'],
612
+ },
613
+ });
614
+ resumeOutcome = { sessionId: 'session-1', messageId: 'message-2', interrupted: [], content: 'the resumed plan' };
615
+ const { worker } = createWorker(run, [pendingApproval({ status: 'approved', consumedAt: null })]);
616
+
617
+ await worker.execute(claimed(run));
618
+
619
+ expect(resumeCalls).toHaveLength(1);
620
+ expect(invokeCalls.map((call) => call.username)).toEqual(['maker-one', 'maker-two']);
621
+ // The resumed leader content replaces the plan handed to the makers.
622
+ expect(invokeCalls[0].prompt).toContain('the resumed plan');
623
+ });
624
+ });