plugin-agent-orchestrator 1.1.8 → 1.2.1

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (495) hide show
  1. package/LICENSE +201 -0
  2. package/README.md +207 -204
  3. package/client-v2.d.ts +2 -2
  4. package/client-v2.js +1 -1
  5. package/client.d.ts +2 -2
  6. package/client.js +1 -1
  7. package/dist/client/117.6c69b6a87751dd18.js +10 -0
  8. package/dist/client/253.52f62e1bc0e9520a.js +10 -0
  9. package/dist/client/325.8f7f509bdb35e142.js +10 -0
  10. package/dist/client/404.86593f98c9768ed5.js +10 -0
  11. package/dist/client/453.fa2d169576262213.js +10 -0
  12. package/dist/client/53.567db3ae078650c6.js +10 -0
  13. package/dist/client/619.01713281e5e951d3.js +10 -0
  14. package/dist/client/652.69da1598312b3a3f.js +10 -0
  15. package/dist/client/773.648965568ff476f9.js +10 -0
  16. package/dist/client/981.37e7aeecdb1ef6fa.js +10 -0
  17. package/dist/client/993.ac89f3852990918d.js +10 -0
  18. package/dist/client/index.js +1 -1
  19. package/dist/client-v2/117.c982d79ff68738f5.js +10 -0
  20. package/dist/client-v2/214.94c4257bf2838577.js +10 -0
  21. package/dist/client-v2/253.8e19956d2a44dfb8.js +10 -0
  22. package/dist/client-v2/264.80e8e358c8c6c2e5.js +10 -0
  23. package/dist/client-v2/325.fafe5a6e83ba9cb3.js +10 -0
  24. package/dist/client-v2/404.ab032b79c95dab6f.js +10 -0
  25. package/dist/client-v2/{41.3deb9e57a0f64fc4.js → 41.cd5610fcf7446127.js} +1 -1
  26. package/dist/client-v2/453.42c6d70628d56cc2.js +10 -0
  27. package/dist/client-v2/{53.349fff8db80b19d4.js → 53.37c08089a648f89a.js} +1 -1
  28. package/dist/client-v2/{619.0a2144aaffefe018.js → 619.6e9618550101e819.js} +1 -1
  29. package/dist/client-v2/652.eeba4e0c38367321.js +10 -0
  30. package/dist/client-v2/{70.ffff2997c10fd4b0.js → 70.332698e53eb59677.js} +1 -1
  31. package/dist/client-v2/773.4de2ba5acb07318c.js +10 -0
  32. package/dist/client-v2/981.76060f466e6f7c11.js +10 -0
  33. package/dist/client-v2/993.f8cdb5172566ce75.js +10 -0
  34. package/dist/client-v2/index.js +1 -1
  35. package/dist/externalVersion.js +13 -7
  36. package/dist/locale/en-US.json +308 -1
  37. package/dist/locale/vi-VN.json +5 -1
  38. package/dist/locale/zh-CN.json +308 -1
  39. package/dist/node_modules/acorn/LICENSE +21 -0
  40. package/dist/node_modules/acorn/bin/acorn +4 -0
  41. package/dist/node_modules/acorn/dist/acorn.d.mts +857 -0
  42. package/dist/node_modules/acorn/dist/acorn.d.ts +857 -0
  43. package/dist/node_modules/acorn/dist/acorn.js +1 -0
  44. package/dist/node_modules/acorn/dist/bin.js +90 -0
  45. package/dist/node_modules/acorn/package.json +1 -0
  46. package/dist/node_modules/acorn-walk/LICENSE +21 -0
  47. package/dist/node_modules/acorn-walk/dist/walk.d.mts +177 -0
  48. package/dist/node_modules/acorn-walk/dist/walk.d.ts +177 -0
  49. package/dist/node_modules/acorn-walk/dist/walk.js +1 -0
  50. package/dist/node_modules/acorn-walk/node_modules/.bin/acorn +15 -0
  51. package/dist/node_modules/acorn-walk/node_modules/.bin/acorn.cmd +7 -0
  52. package/dist/node_modules/acorn-walk/node_modules/acorn/bin/acorn +4 -0
  53. package/dist/node_modules/acorn-walk/node_modules/acorn/dist/acorn.d.mts +866 -0
  54. package/dist/node_modules/acorn-walk/node_modules/acorn/dist/acorn.d.ts +866 -0
  55. package/dist/node_modules/acorn-walk/node_modules/acorn/dist/acorn.js +6174 -0
  56. package/dist/node_modules/acorn-walk/node_modules/acorn/dist/bin.js +90 -0
  57. package/dist/node_modules/acorn-walk/node_modules/acorn/package.json +50 -0
  58. package/dist/node_modules/acorn-walk/package.json +1 -0
  59. package/dist/node_modules/adm-zip/adm-zip.js +1 -1
  60. package/dist/node_modules/adm-zip/package.json +1 -1
  61. package/dist/node_modules/ajv/package.json +1 -1
  62. package/dist/node_modules/zod/index.cjs +1 -1
  63. package/dist/node_modules/zod/package.json +1 -1
  64. package/dist/server/collections/agent-auto-approval-checkpoints.js +47 -0
  65. package/dist/server/collections/agent-execution-spans.js +148 -9
  66. package/dist/server/collections/agent-governance-audit-events.js +47 -0
  67. package/dist/server/collections/agent-governance-policies.js +47 -0
  68. package/dist/server/collections/agent-governance-policy-versions.js +48 -0
  69. package/dist/server/collections/agent-governance-prompt-bindings.js +50 -0
  70. package/dist/server/collections/agent-hierarchy-invocations.js +59 -0
  71. package/dist/server/collections/agent-loop-runs.js +23 -5
  72. package/dist/server/collections/agent-routing-graph-locks.js +40 -0
  73. package/dist/server/collections/agent-session-auto-approvals.js +45 -0
  74. package/dist/server/collections/orchestrator-config.js +17 -0
  75. package/dist/server/migrations/20261110000000-add-usage-pricing-snapshots.js +117 -0
  76. package/dist/server/migrations/20261110010000-add-usage-department-attribution.js +54 -0
  77. package/dist/server/migrations/20261119000000-widen-native-employee-identifiers.js +59 -0
  78. package/dist/server/plugin.js +169 -33
  79. package/dist/server/resources/agent-auto-approval.js +80 -0
  80. package/dist/server/resources/agent-governance.js +192 -0
  81. package/dist/server/resources/agent-harness-profile.js +11 -3
  82. package/dist/server/resources/agent-monitor.js +109 -339
  83. package/dist/server/resources/agent-usage.js +423 -0
  84. package/dist/server/resources/hierarchical-routing.js +60 -0
  85. package/dist/server/resources/native-monitor-format.js +179 -0
  86. package/dist/server/resources/tracing.js +35 -12
  87. package/dist/server/services/AgentGovernanceService.js +500 -0
  88. package/dist/server/services/AutoApprovalCheckpoint.js +133 -0
  89. package/dist/server/services/CodeValidator.js +8 -4
  90. package/dist/server/services/DepartmentAttribution.js +65 -0
  91. package/dist/server/services/ExecutionSpanService.js +96 -3
  92. package/dist/server/services/GovernanceAdmission.js +271 -0
  93. package/dist/server/services/HarnessCapabilities.js +118 -0
  94. package/dist/server/services/HarnessCompiler.js +3 -0
  95. package/dist/server/services/HarnessSchema.js +13 -1
  96. package/dist/server/services/HierarchicalAgentRuntime.js +925 -0
  97. package/dist/server/services/HierarchyEnrollmentGuard.js +216 -0
  98. package/dist/server/services/HierarchyInvocationJournal.js +157 -0
  99. package/dist/server/services/HierarchyRequestCancellation.js +150 -0
  100. package/dist/server/services/LoopBudgetService.js +29 -11
  101. package/dist/server/services/LoopRunRepository.js +16 -7
  102. package/dist/server/services/LoopRunStateMachine.js +20 -9
  103. package/dist/server/services/LoopTriggerService.js +1 -1
  104. package/dist/server/services/LoopWorkerService.js +71 -37
  105. package/dist/server/services/ManagedPromptProtection.js +99 -0
  106. package/dist/server/services/NativeAgentMonitorSyncService.js +584 -0
  107. package/dist/server/services/NativeSubAgentObserver.js +141 -508
  108. package/dist/server/services/NativeUsageAttribution.js +97 -0
  109. package/dist/server/services/PluginAiRuntimeAdapter.js +107 -9
  110. package/dist/server/services/RoutingBindingRepository.js +156 -0
  111. package/dist/server/services/RoutingBindingValidation.js +161 -0
  112. package/dist/server/services/SandboxRunner.js +19 -0
  113. package/dist/server/services/SessionAutoApproval.js +173 -0
  114. package/dist/server/services/TokenTracker.js +787 -104
  115. package/dist/server/services/TracingRetentionPolicy.js +66 -0
  116. package/dist/server/services/VerificationService.js +20 -10
  117. package/dist/server/skill-hub/plugin.js +17 -0
  118. package/dist/server/skill-hub/sandbox-config.json +6 -6
  119. package/dist/server/skill-hub/services/RegistrySkillInstallationService.js +2 -2
  120. package/dist/server/skill-hub/services/registry-node-package.js +191 -0
  121. package/dist/server/skill-hub/tasks/SkillExecutionTask.js +21 -6
  122. package/dist/server/tools/skill-execute.js +1 -0
  123. package/dist/server/utils/ensure-indexes.js +15 -5
  124. package/package.json +66 -53
  125. package/server.d.ts +2 -2
  126. package/server.js +1 -1
  127. package/src/client/AgentRunsTab.tsx +2 -2
  128. package/src/client/ApprovalsTab.tsx +2 -2
  129. package/src/client/HarnessProfilesTab.tsx +2 -2
  130. package/src/client/OrchestratorSettings.tsx +152 -152
  131. package/src/client/SkillPages.tsx +34 -0
  132. package/src/client/__tests__/embedded-settings.test.tsx +225 -0
  133. package/src/client/hooks/useRunEventStream.ts +76 -76
  134. package/src/client/index.tsx +2 -2
  135. package/src/client/plugin.tsx +71 -33
  136. package/src/client/skill-hub/components/ExecutionHistory.tsx +200 -200
  137. package/src/client/skill-hub/components/GitSkillImport.tsx +562 -562
  138. package/src/client/skill-hub/components/LoopSettings.tsx +331 -331
  139. package/src/client/skill-hub/components/SkillEditor.tsx +460 -460
  140. package/src/client/skill-hub/components/SkillManager.tsx +194 -194
  141. package/src/client/skill-hub/components/SkillMetrics.tsx +162 -162
  142. package/src/client/skill-hub/components/SkillTestPanel.tsx +141 -141
  143. package/src/client/skill-hub/index.tsx +6 -6
  144. package/src/client/skill-hub/locale.ts +16 -16
  145. package/src/client/skill-hub/tools/InteractionSchemasProvider.tsx +147 -132
  146. package/src/client/skill-hub/tools/SkillHubCard.tsx +110 -104
  147. package/src/client/skill-hub/tools/__tests__/skill-hub-card.test.tsx +255 -0
  148. package/src/client/skill-hub/tools/loopTemplates.ts +52 -52
  149. package/src/client/skill-hub/tools/registerSkillLoopCards.ts +80 -71
  150. package/src/client/skill-hub/utils/jsonFields.ts +41 -41
  151. package/src/client-v2/__tests__/embedded-settings.test.tsx +202 -0
  152. package/src/client-v2/__tests__/hierarchical-routing-settings.test.tsx +350 -0
  153. package/src/client-v2/auto-approval/AutoApprovalBridge.tsx +513 -0
  154. package/src/client-v2/auto-approval/AutoApprovalProvider.tsx +399 -0
  155. package/src/client-v2/auto-approval/__tests__/session-auto-approval.test.tsx +1676 -0
  156. package/src/client-v2/components/AIEmployeeSelect.tsx +47 -47
  157. package/src/client-v2/components/AIEmployeesContext.tsx +97 -97
  158. package/src/client-v2/components/AgentBindingsTab.tsx +541 -269
  159. package/src/client-v2/components/AgentRunsTab.tsx +85 -83
  160. package/src/client-v2/components/ApprovalsTab.tsx +337 -337
  161. package/src/client-v2/components/EmployeeGovernanceTab.tsx +695 -0
  162. package/src/client-v2/components/HarnessProfilesTab.tsx +700 -541
  163. package/src/client-v2/components/HarnessSettingsForm.tsx +221 -0
  164. package/src/client-v2/components/KnowledgeAccessTab.tsx +116 -116
  165. package/src/client-v2/components/RetrievalTraceTab.tsx +162 -162
  166. package/src/client-v2/components/UsageGovernanceTab.tsx +379 -0
  167. package/src/client-v2/index.tsx +1 -1
  168. package/src/client-v2/pages/AgentBindingsPage.tsx +15 -13
  169. package/src/client-v2/pages/ApprovalsPage.tsx +12 -10
  170. package/src/client-v2/pages/EmployeeGovernancePage.tsx +15 -0
  171. package/src/client-v2/pages/ExecutionHistoryPage.tsx +12 -10
  172. package/src/client-v2/pages/HarnessProfilesPage.tsx +12 -10
  173. package/src/client-v2/pages/KnowledgeAccessPage.tsx +12 -10
  174. package/src/client-v2/pages/LoopSettingsPage.tsx +12 -10
  175. package/src/client-v2/pages/MemoryInspectorPage.tsx +15 -13
  176. package/src/client-v2/pages/RetrievalTracePage.tsx +12 -10
  177. package/src/client-v2/pages/RulesPage.tsx +15 -13
  178. package/src/client-v2/pages/SkillDefinitionsPage.tsx +12 -10
  179. package/src/client-v2/pages/SkillMetricsPage.tsx +12 -10
  180. package/src/client-v2/pages/TracingPage.tsx +15 -13
  181. package/src/client-v2/pages/UsageGovernancePage.tsx +15 -0
  182. package/src/client-v2/plugin.tsx +134 -111
  183. package/src/client-v2/skill-hub/components/ExecutionHistory.tsx +196 -196
  184. package/src/client-v2/skill-hub/components/FileLinkList.tsx +37 -37
  185. package/src/client-v2/skill-hub/components/GitSkillImport.tsx +539 -539
  186. package/src/client-v2/skill-hub/components/LoopSettings.tsx +331 -331
  187. package/src/client-v2/skill-hub/components/SkillEditor.tsx +453 -453
  188. package/src/client-v2/skill-hub/components/SkillManager.tsx +191 -174
  189. package/src/client-v2/skill-hub/components/SkillMetrics.tsx +162 -162
  190. package/src/client-v2/skill-hub/components/SkillTestPanel.tsx +135 -135
  191. package/src/client-v2/skill-hub/locale.ts +13 -13
  192. package/src/client-v2/skill-hub/tools/InteractionSchemasProvider.tsx +62 -0
  193. package/src/client-v2/skill-hub/tools/SkillHubCard.tsx +104 -0
  194. package/src/client-v2/skill-hub/tools/__tests__/interactions.test.ts +126 -0
  195. package/src/client-v2/skill-hub/tools/interactions.ts +137 -0
  196. package/src/client-v2/skill-hub/tools/loopTemplates.ts +52 -52
  197. package/src/client-v2/skill-hub/utils/jsonFields.ts +41 -41
  198. package/src/client-v2/utils/jsonFields.ts +41 -41
  199. package/src/index.ts +2 -2
  200. package/src/locale/en-US.json +308 -1
  201. package/src/locale/vi-VN.json +5 -1
  202. package/src/locale/zh-CN.json +308 -1
  203. package/src/server/__tests__/agent-execution-context.test.ts +18 -18
  204. package/src/server/__tests__/agent-governance.integration.test.ts +385 -0
  205. package/src/server/__tests__/agent-knowledge-insights.test.ts +123 -123
  206. package/src/server/__tests__/agent-monitor-acl.integration.test.ts +267 -0
  207. package/src/server/__tests__/agent-registry-service.test.ts +147 -147
  208. package/src/server/__tests__/agent-runtime-lifecycle.test.ts +46 -46
  209. package/src/server/__tests__/agent-usage-report.integration.test.ts +335 -0
  210. package/src/server/__tests__/auto-approval-checkpoint.integration.test.ts +295 -0
  211. package/src/server/__tests__/code-validator.test.ts +63 -63
  212. package/src/server/__tests__/external-rag-search.test.ts +107 -107
  213. package/src/server/__tests__/harness-capabilities.test.ts +88 -0
  214. package/src/server/__tests__/harness-compiler.test.ts +278 -214
  215. package/src/server/__tests__/harness-profile-service.test.ts +167 -167
  216. package/src/server/__tests__/harness-runtime-policy.test.ts +293 -293
  217. package/src/server/__tests__/harness-tool-plan.test.ts +175 -172
  218. package/src/server/__tests__/hierarchical-routing.integration.test.ts +2318 -0
  219. package/src/server/__tests__/hierarchy-invocation-journal.integration.test.ts +119 -0
  220. package/src/server/__tests__/input-schema-validator.test.ts +26 -26
  221. package/src/server/__tests__/loop-approval-decision.test.ts +624 -512
  222. package/src/server/__tests__/loop-approval-expiry.test.ts +258 -258
  223. package/src/server/__tests__/loop-budget-service.test.ts +29 -0
  224. package/src/server/__tests__/loop-pattern-schema.test.ts +73 -73
  225. package/src/server/__tests__/loop-run-repository.test.ts +25 -0
  226. package/src/server/__tests__/loop-run-state-machine.test.ts +101 -101
  227. package/src/server/__tests__/loop-trigger-service.test.ts +185 -148
  228. package/src/server/__tests__/loop-worker-claim.test.ts +110 -10
  229. package/src/server/__tests__/loop-worker-execution.test.ts +375 -317
  230. package/src/server/__tests__/native-agent-monitor-sync.test.ts +343 -0
  231. package/src/server/__tests__/native-hierarchy-probe.integration.test.ts +527 -0
  232. package/src/server/__tests__/native-sub-agent-observer.test.ts +463 -662
  233. package/src/server/__tests__/native-usage-attribution.integration.test.ts +168 -0
  234. package/src/server/__tests__/plugin-ai-runtime-adapter.test.ts +403 -0
  235. package/src/server/__tests__/registry-node-package.test.ts +299 -0
  236. package/src/server/__tests__/routing-binding-graph.integration.test.ts +217 -0
  237. package/src/server/__tests__/routing-binding-validation.test.ts +256 -0
  238. package/src/server/__tests__/session-auto-approval.integration.test.ts +329 -0
  239. package/src/server/__tests__/skill-access-service.test.ts +64 -64
  240. package/src/server/__tests__/skill-execute.test.ts +81 -70
  241. package/src/server/__tests__/skill-execution-task-policy.test.ts +140 -140
  242. package/src/server/__tests__/skill-review-guard.test.ts +171 -0
  243. package/src/server/__tests__/skill-sandbox-worker-mode.test.ts +15 -15
  244. package/src/server/__tests__/skill-settings.test.ts +63 -63
  245. package/src/server/__tests__/skill-tool-name.test.ts +23 -23
  246. package/src/server/__tests__/token-tracker.test.ts +632 -0
  247. package/src/server/__tests__/tool-loop-detection.test.ts +276 -276
  248. package/src/server/__tests__/tracing-retention-policy.test.ts +30 -0
  249. package/src/server/__tests__/usage-ledger.integration.test.ts +187 -0
  250. package/src/server/collections/agent-auto-approval-checkpoints.ts +18 -0
  251. package/src/server/collections/agent-execution-spans.ts +386 -245
  252. package/src/server/collections/agent-governance-audit-events.ts +19 -0
  253. package/src/server/collections/agent-governance-policies.ts +19 -0
  254. package/src/server/collections/agent-governance-policy-versions.ts +20 -0
  255. package/src/server/collections/agent-governance-prompt-bindings.ts +22 -0
  256. package/src/server/collections/agent-hierarchy-invocations.ts +30 -0
  257. package/src/server/collections/agent-loop-action-approvals.ts +39 -39
  258. package/src/server/collections/agent-loop-runs.ts +389 -369
  259. package/src/server/collections/agent-loop-steps.ts +220 -220
  260. package/src/server/collections/agent-memory-contexts.ts +95 -95
  261. package/src/server/collections/agent-routing-graph-locks.ts +11 -0
  262. package/src/server/collections/agent-session-auto-approvals.ts +16 -0
  263. package/src/server/collections/orchestrator-config.ts +113 -87
  264. package/src/server/collections/orchestrator-logs.ts +116 -116
  265. package/src/server/collections/skill-definitions.ts +159 -159
  266. package/src/server/collections/skill-executions.ts +154 -154
  267. package/src/server/collections/skill-loop-configs.ts +65 -65
  268. package/src/server/collections/skill-metrics.ts +36 -36
  269. package/src/server/collections/skill-registry-installations.ts +41 -41
  270. package/src/server/collections/skill-worker-configs.ts +86 -86
  271. package/src/server/index.ts +1 -1
  272. package/src/server/migrations/20260423000000-add-progress-fields.ts +50 -50
  273. package/src/server/migrations/20260425000000-add-interaction-schema.ts +37 -37
  274. package/src/server/migrations/20260427000000-add-tracing-detail-fields.ts +41 -41
  275. package/src/server/migrations/20260427000001-change-other-json-to-text.ts +61 -61
  276. package/src/server/migrations/20260524001000-add-plan-approval-and-harness-profiles.ts +145 -145
  277. package/src/server/migrations/20260601000000-add-token-fields.ts +89 -89
  278. package/src/server/migrations/20260615000000-normalize-ai-employee-tool-bindings.ts +39 -39
  279. package/src/server/migrations/20260621000000-native-policy-profile-defaults.ts +190 -190
  280. package/src/server/migrations/20260727000000-remove-unused-knowledge-scopes.ts +25 -25
  281. package/src/server/migrations/20260727010000-backfill-skill-tool-names.ts +45 -45
  282. package/src/server/migrations/20261110000000-add-usage-pricing-snapshots.ts +110 -0
  283. package/src/server/migrations/20261110010000-add-usage-department-attribution.ts +28 -0
  284. package/src/server/migrations/20261119000000-widen-native-employee-identifiers.ts +37 -0
  285. package/src/server/plugin.ts +724 -573
  286. package/src/server/resources/agent-auto-approval.ts +51 -0
  287. package/src/server/resources/agent-governance.ts +161 -0
  288. package/src/server/resources/agent-harness-profile.ts +103 -94
  289. package/src/server/resources/agent-knowledge-insights.ts +306 -306
  290. package/src/server/resources/agent-loop-approval.ts +84 -84
  291. package/src/server/resources/agent-loop-events-stream.ts +108 -108
  292. package/src/server/resources/agent-loop.ts +252 -252
  293. package/src/server/resources/agent-monitor.ts +208 -482
  294. package/src/server/resources/agent-usage.ts +413 -0
  295. package/src/server/resources/hierarchical-routing.ts +39 -0
  296. package/src/server/resources/native-monitor-format.ts +150 -0
  297. package/src/server/resources/tracing.ts +296 -267
  298. package/src/server/services/AgentExecutionContext.ts +23 -23
  299. package/src/server/services/AgentGovernanceService.ts +541 -0
  300. package/src/server/services/AgentMemoryContextService.ts +344 -344
  301. package/src/server/services/AgentRegistryService.ts +220 -220
  302. package/src/server/services/AgentRuntimeLifecycle.ts +64 -64
  303. package/src/server/services/AutoApprovalCheckpoint.ts +140 -0
  304. package/src/server/services/CodeValidator.ts +257 -238
  305. package/src/server/services/DepartmentAttribution.ts +47 -0
  306. package/src/server/services/DurableCircuitBreakerService.ts +235 -235
  307. package/src/server/services/ExecutionSpanService.ts +271 -146
  308. package/src/server/services/FileManager.ts +159 -159
  309. package/src/server/services/GovernanceAdmission.ts +314 -0
  310. package/src/server/services/HarnessCapabilities.ts +112 -0
  311. package/src/server/services/HarnessCompiler.ts +182 -170
  312. package/src/server/services/HarnessProfileService.ts +235 -235
  313. package/src/server/services/HarnessSchema.ts +224 -194
  314. package/src/server/services/HierarchicalAgentRuntime.ts +1052 -0
  315. package/src/server/services/HierarchyEnrollmentGuard.ts +211 -0
  316. package/src/server/services/HierarchyInvocationJournal.ts +172 -0
  317. package/src/server/services/HierarchyRequestCancellation.ts +132 -0
  318. package/src/server/services/InputSchemaValidator.ts +44 -44
  319. package/src/server/services/LoopBudgetService.ts +325 -271
  320. package/src/server/services/LoopControlService.ts +120 -120
  321. package/src/server/services/LoopPatternSchema.ts +231 -231
  322. package/src/server/services/LoopPatternService.ts +171 -171
  323. package/src/server/services/LoopRunRepository.ts +343 -332
  324. package/src/server/services/LoopRunStateMachine.ts +538 -525
  325. package/src/server/services/LoopSchedulerService.ts +195 -195
  326. package/src/server/services/LoopTriggerService.ts +162 -159
  327. package/src/server/services/LoopWorkerService.ts +975 -912
  328. package/src/server/services/ManagedPromptProtection.ts +81 -0
  329. package/src/server/services/NativeAgentMonitorSyncService.ts +684 -0
  330. package/src/server/services/NativeSubAgentObserver.ts +324 -757
  331. package/src/server/services/NativeUsageAttribution.ts +91 -0
  332. package/src/server/services/PathLockService.ts +317 -317
  333. package/src/server/services/PluginAiRuntimeAdapter.ts +518 -387
  334. package/src/server/services/RoutingBindingRepository.ts +146 -0
  335. package/src/server/services/RoutingBindingValidation.ts +161 -0
  336. package/src/server/services/RunEventBus.ts +58 -58
  337. package/src/server/services/SandboxRunner.ts +526 -492
  338. package/src/server/services/SessionAutoApproval.ts +167 -0
  339. package/src/server/services/SkillAccessService.ts +175 -175
  340. package/src/server/services/SkillManager.ts +585 -585
  341. package/src/server/services/SkillRepositoryService.ts +236 -236
  342. package/src/server/services/TokenTracker.ts +1151 -287
  343. package/src/server/services/ToolLoopDetectionService.ts +210 -210
  344. package/src/server/services/TracingRetentionPolicy.ts +49 -0
  345. package/src/server/services/VerificationSchema.ts +31 -31
  346. package/src/server/services/VerificationService.ts +325 -313
  347. package/src/server/services/WorkerEnvManager.ts +198 -198
  348. package/src/server/services/__tests__/SkillRepositoryService.test.ts +33 -33
  349. package/src/server/services/harness-runtime-policy.ts +134 -134
  350. package/src/server/services/pythonGuardTemplate.ts +87 -87
  351. package/src/server/services/sandboxCapabilities.ts +348 -348
  352. package/src/server/skill-hub/actions/__tests__/git-import.test.ts +563 -563
  353. package/src/server/skill-hub/actions/git-import.ts +936 -936
  354. package/src/server/skill-hub/mcp/McpController.ts +107 -107
  355. package/src/server/skill-hub/middlewares/git-import-request-method-policy.ts +51 -51
  356. package/src/server/skill-hub/plugin.ts +1272 -1232
  357. package/src/server/skill-hub/sandbox-config.json +6 -6
  358. package/src/server/skill-hub/services/RegistrySkillInstallationService.ts +291 -281
  359. package/src/server/skill-hub/services/__tests__/RegistrySkillInstallationService.test.ts +295 -295
  360. package/src/server/skill-hub/services/registry-node-package.ts +191 -0
  361. package/src/server/skill-hub/tasks/SkillExecutionTask.ts +597 -568
  362. package/src/server/skill-hub/utils/json-fields.ts +57 -57
  363. package/src/server/tools/delegate-task.ts +30 -30
  364. package/src/server/tools/external-rag-search.ts +329 -329
  365. package/src/server/tools/skill-execute.ts +226 -216
  366. package/src/server/types.ts +21 -21
  367. package/src/server/utils/ai-manager.ts +24 -24
  368. package/src/server/utils/ctx-utils.ts +132 -132
  369. package/src/server/utils/ensure-indexes.ts +113 -96
  370. package/src/server/utils/ha-lock.ts +80 -80
  371. package/src/server/utils/loop-pattern-context.ts +84 -84
  372. package/src/server/utils/record-utils.ts +19 -19
  373. package/src/server/utils/skill-settings.ts +135 -135
  374. package/src/server/utils/skill-tool-name.ts +58 -58
  375. package/dist/client-v2/117.7565cff57c39318a.js +0 -10
  376. package/dist/client-v2/214.106635011859dede.js +0 -10
  377. package/dist/client-v2/253.59577b40d9875be0.js +0 -10
  378. package/dist/client-v2/264.7ed8bee71fa5935c.js +0 -10
  379. package/dist/client-v2/418.41ed200e7d6da332.js +0 -10
  380. package/dist/client-v2/794.a67a2614405ba627.js +0 -10
  381. package/dist/client-v2/981.e4a1f41cfc94a856.js +0 -10
  382. package/dist/client-v2/993.b0688fdc5ccb000a.js +0 -10
  383. package/dist/node_modules/simple-git/dist/cjs/index.js +0 -7399
  384. package/dist/node_modules/simple-git/dist/esm/index.js +0 -4745
  385. package/dist/node_modules/simple-git/dist/esm/package.json +0 -3
  386. package/dist/node_modules/simple-git/dist/src/lib/api.d.ts +0 -13
  387. package/dist/node_modules/simple-git/dist/src/lib/args/log-format.d.ts +0 -9
  388. package/dist/node_modules/simple-git/dist/src/lib/errors/git-construct-error.d.ts +0 -15
  389. package/dist/node_modules/simple-git/dist/src/lib/errors/git-error.d.ts +0 -30
  390. package/dist/node_modules/simple-git/dist/src/lib/errors/git-plugin-error.d.ts +0 -7
  391. package/dist/node_modules/simple-git/dist/src/lib/errors/git-response-error.d.ts +0 -32
  392. package/dist/node_modules/simple-git/dist/src/lib/errors/task-configuration-error.d.ts +0 -12
  393. package/dist/node_modules/simple-git/dist/src/lib/git-factory.d.ts +0 -15
  394. package/dist/node_modules/simple-git/dist/src/lib/git-logger.d.ts +0 -21
  395. package/dist/node_modules/simple-git/dist/src/lib/parsers/parse-branch-delete.d.ts +0 -5
  396. package/dist/node_modules/simple-git/dist/src/lib/parsers/parse-branch.d.ts +0 -2
  397. package/dist/node_modules/simple-git/dist/src/lib/parsers/parse-commit.d.ts +0 -2
  398. package/dist/node_modules/simple-git/dist/src/lib/parsers/parse-diff-summary.d.ts +0 -3
  399. package/dist/node_modules/simple-git/dist/src/lib/parsers/parse-fetch.d.ts +0 -2
  400. package/dist/node_modules/simple-git/dist/src/lib/parsers/parse-list-log-summary.d.ts +0 -6
  401. package/dist/node_modules/simple-git/dist/src/lib/parsers/parse-merge.d.ts +0 -11
  402. package/dist/node_modules/simple-git/dist/src/lib/parsers/parse-move.d.ts +0 -2
  403. package/dist/node_modules/simple-git/dist/src/lib/parsers/parse-pull.d.ts +0 -6
  404. package/dist/node_modules/simple-git/dist/src/lib/parsers/parse-push.d.ts +0 -4
  405. package/dist/node_modules/simple-git/dist/src/lib/parsers/parse-remote-messages.d.ts +0 -5
  406. package/dist/node_modules/simple-git/dist/src/lib/parsers/parse-remote-objects.d.ts +0 -3
  407. package/dist/node_modules/simple-git/dist/src/lib/plugins/abort-plugin.d.ts +0 -3
  408. package/dist/node_modules/simple-git/dist/src/lib/plugins/block-unsafe-operations-plugin.d.ts +0 -3
  409. package/dist/node_modules/simple-git/dist/src/lib/plugins/command-config-prefixing-plugin.d.ts +0 -2
  410. package/dist/node_modules/simple-git/dist/src/lib/plugins/completion-detection.plugin.d.ts +0 -3
  411. package/dist/node_modules/simple-git/dist/src/lib/plugins/custom-binary.plugin.d.ts +0 -3
  412. package/dist/node_modules/simple-git/dist/src/lib/plugins/error-detection.plugin.d.ts +0 -7
  413. package/dist/node_modules/simple-git/dist/src/lib/plugins/index.d.ts +0 -11
  414. package/dist/node_modules/simple-git/dist/src/lib/plugins/plugin-store.d.ts +0 -11
  415. package/dist/node_modules/simple-git/dist/src/lib/plugins/progress-monitor-plugin.d.ts +0 -3
  416. package/dist/node_modules/simple-git/dist/src/lib/plugins/simple-git-plugin.d.ts +0 -48
  417. package/dist/node_modules/simple-git/dist/src/lib/plugins/spawn-options-plugin.d.ts +0 -3
  418. package/dist/node_modules/simple-git/dist/src/lib/plugins/suffix-paths.plugin.d.ts +0 -2
  419. package/dist/node_modules/simple-git/dist/src/lib/plugins/timout-plugin.d.ts +0 -3
  420. package/dist/node_modules/simple-git/dist/src/lib/responses/BranchDeleteSummary.d.ts +0 -12
  421. package/dist/node_modules/simple-git/dist/src/lib/responses/BranchSummary.d.ts +0 -14
  422. package/dist/node_modules/simple-git/dist/src/lib/responses/CheckIgnore.d.ts +0 -4
  423. package/dist/node_modules/simple-git/dist/src/lib/responses/CleanSummary.d.ts +0 -9
  424. package/dist/node_modules/simple-git/dist/src/lib/responses/ConfigList.d.ts +0 -13
  425. package/dist/node_modules/simple-git/dist/src/lib/responses/DiffSummary.d.ts +0 -10
  426. package/dist/node_modules/simple-git/dist/src/lib/responses/FileStatusSummary.d.ts +0 -9
  427. package/dist/node_modules/simple-git/dist/src/lib/responses/GetRemoteSummary.d.ts +0 -11
  428. package/dist/node_modules/simple-git/dist/src/lib/responses/InitSummary.d.ts +0 -9
  429. package/dist/node_modules/simple-git/dist/src/lib/responses/MergeSummary.d.ts +0 -16
  430. package/dist/node_modules/simple-git/dist/src/lib/responses/PullSummary.d.ts +0 -25
  431. package/dist/node_modules/simple-git/dist/src/lib/responses/StatusSummary.d.ts +0 -19
  432. package/dist/node_modules/simple-git/dist/src/lib/responses/TagList.d.ts +0 -7
  433. package/dist/node_modules/simple-git/dist/src/lib/runners/git-executor-chain.d.ts +0 -25
  434. package/dist/node_modules/simple-git/dist/src/lib/runners/git-executor.d.ts +0 -14
  435. package/dist/node_modules/simple-git/dist/src/lib/runners/promise-wrapped.d.ts +0 -2
  436. package/dist/node_modules/simple-git/dist/src/lib/runners/scheduler.d.ts +0 -11
  437. package/dist/node_modules/simple-git/dist/src/lib/runners/tasks-pending-queue.d.ts +0 -23
  438. package/dist/node_modules/simple-git/dist/src/lib/simple-git-api.d.ts +0 -20
  439. package/dist/node_modules/simple-git/dist/src/lib/task-callback.d.ts +0 -2
  440. package/dist/node_modules/simple-git/dist/src/lib/tasks/apply-patch.d.ts +0 -3
  441. package/dist/node_modules/simple-git/dist/src/lib/tasks/branch.d.ts +0 -7
  442. package/dist/node_modules/simple-git/dist/src/lib/tasks/change-working-directory.d.ts +0 -2
  443. package/dist/node_modules/simple-git/dist/src/lib/tasks/check-ignore.d.ts +0 -2
  444. package/dist/node_modules/simple-git/dist/src/lib/tasks/check-is-repo.d.ts +0 -9
  445. package/dist/node_modules/simple-git/dist/src/lib/tasks/checkout.d.ts +0 -2
  446. package/dist/node_modules/simple-git/dist/src/lib/tasks/clean.d.ts +0 -25
  447. package/dist/node_modules/simple-git/dist/src/lib/tasks/clone.d.ts +0 -9
  448. package/dist/node_modules/simple-git/dist/src/lib/tasks/commit.d.ts +0 -4
  449. package/dist/node_modules/simple-git/dist/src/lib/tasks/config.d.ts +0 -8
  450. package/dist/node_modules/simple-git/dist/src/lib/tasks/count-objects.d.ts +0 -12
  451. package/dist/node_modules/simple-git/dist/src/lib/tasks/diff-name-status.d.ts +0 -12
  452. package/dist/node_modules/simple-git/dist/src/lib/tasks/diff.d.ts +0 -5
  453. package/dist/node_modules/simple-git/dist/src/lib/tasks/fetch.d.ts +0 -4
  454. package/dist/node_modules/simple-git/dist/src/lib/tasks/first-commit.d.ts +0 -2
  455. package/dist/node_modules/simple-git/dist/src/lib/tasks/grep.d.ts +0 -12
  456. package/dist/node_modules/simple-git/dist/src/lib/tasks/hash-object.d.ts +0 -5
  457. package/dist/node_modules/simple-git/dist/src/lib/tasks/init.d.ts +0 -3
  458. package/dist/node_modules/simple-git/dist/src/lib/tasks/log.d.ts +0 -32
  459. package/dist/node_modules/simple-git/dist/src/lib/tasks/merge.d.ts +0 -4
  460. package/dist/node_modules/simple-git/dist/src/lib/tasks/move.d.ts +0 -3
  461. package/dist/node_modules/simple-git/dist/src/lib/tasks/pull.d.ts +0 -3
  462. package/dist/node_modules/simple-git/dist/src/lib/tasks/push.d.ts +0 -9
  463. package/dist/node_modules/simple-git/dist/src/lib/tasks/remote.d.ts +0 -8
  464. package/dist/node_modules/simple-git/dist/src/lib/tasks/reset.d.ts +0 -11
  465. package/dist/node_modules/simple-git/dist/src/lib/tasks/show.d.ts +0 -2
  466. package/dist/node_modules/simple-git/dist/src/lib/tasks/stash-list.d.ts +0 -4
  467. package/dist/node_modules/simple-git/dist/src/lib/tasks/status.d.ts +0 -3
  468. package/dist/node_modules/simple-git/dist/src/lib/tasks/sub-module.d.ts +0 -5
  469. package/dist/node_modules/simple-git/dist/src/lib/tasks/tag.d.ts +0 -18
  470. package/dist/node_modules/simple-git/dist/src/lib/tasks/task.d.ts +0 -14
  471. package/dist/node_modules/simple-git/dist/src/lib/tasks/version.d.ts +0 -9
  472. package/dist/node_modules/simple-git/dist/src/lib/types/handlers.d.ts +0 -21
  473. package/dist/node_modules/simple-git/dist/src/lib/types/index.d.ts +0 -136
  474. package/dist/node_modules/simple-git/dist/src/lib/types/tasks.d.ts +0 -19
  475. package/dist/node_modules/simple-git/dist/src/lib/utils/argument-filters.d.ts +0 -14
  476. package/dist/node_modules/simple-git/dist/src/lib/utils/exit-codes.d.ts +0 -10
  477. package/dist/node_modules/simple-git/dist/src/lib/utils/git-output-streams.d.ts +0 -7
  478. package/dist/node_modules/simple-git/dist/src/lib/utils/index.d.ts +0 -8
  479. package/dist/node_modules/simple-git/dist/src/lib/utils/line-parser.d.ts +0 -15
  480. package/dist/node_modules/simple-git/dist/src/lib/utils/simple-git-options.d.ts +0 -2
  481. package/dist/node_modules/simple-git/dist/src/lib/utils/task-options.d.ts +0 -13
  482. package/dist/node_modules/simple-git/dist/src/lib/utils/task-parser.d.ts +0 -5
  483. package/dist/node_modules/simple-git/dist/src/lib/utils/util.d.ts +0 -47
  484. package/dist/node_modules/simple-git/dist/typings/errors.d.ts +0 -5
  485. package/dist/node_modules/simple-git/dist/typings/index.d.ts +0 -14
  486. package/dist/node_modules/simple-git/dist/typings/response.d.ts +0 -556
  487. package/dist/node_modules/simple-git/dist/typings/simple-git.d.ts +0 -1033
  488. package/dist/node_modules/simple-git/dist/typings/types.d.ts +0 -22
  489. package/dist/node_modules/simple-git/node_modules/debug/package.json +0 -64
  490. package/dist/node_modules/simple-git/node_modules/debug/src/browser.js +0 -272
  491. package/dist/node_modules/simple-git/node_modules/debug/src/common.js +0 -292
  492. package/dist/node_modules/simple-git/node_modules/debug/src/index.js +0 -10
  493. package/dist/node_modules/simple-git/node_modules/debug/src/node.js +0 -263
  494. package/dist/node_modules/simple-git/package.json +0 -1
  495. package/dist/node_modules/simple-git/promise.js +0 -17
@@ -1,563 +1,563 @@
1
- import type { Context } from '@nocobase/actions';
2
-
3
- import { GIT_SKILL_MARKDOWN_LIMITS, gitListSkills, gitSyncSkills } from '../git-import';
4
- import { createGitImportRequestMethodPolicy } from '../../middlewares/git-import-request-method-policy';
5
-
6
- const commitSha = 'a'.repeat(40);
7
- const actor = { kind: 'user' as const, roles: ['developer'] };
8
-
9
- type GitEntry = { type: 'blob' | 'tree'; path: string; size: number };
10
-
11
- type SkillDefinitionsRepository = {
12
- find?: ReturnType<typeof vi.fn>;
13
- findOne: ReturnType<typeof vi.fn>;
14
- create?: ReturnType<typeof vi.fn>;
15
- };
16
-
17
- type ContentService = {
18
- contractVersion: number;
19
- capabilities: string[];
20
- resolveCommit: ReturnType<typeof vi.fn>;
21
- listTree: ReturnType<typeof vi.fn>;
22
- readFile: ReturnType<typeof vi.fn>;
23
- };
24
-
25
- type TestContext = {
26
- context: Context;
27
- getRepository: ReturnType<typeof vi.fn>;
28
- skillDefinitions: SkillDefinitionsRepository;
29
- };
30
-
31
- function gitError(code: string, message = code): Error & { code: string } {
32
- const error = new Error(message) as Error & { code: string };
33
- error.code = code;
34
- return error;
35
- }
36
-
37
- function httpError(status: number, message: string): Error & { status: number } {
38
- const error = new Error(message) as Error & { status: number };
39
- error.status = status;
40
- return error;
41
- }
42
-
43
- function createContentService(input?: Partial<ContentService>): ContentService {
44
- return {
45
- contractVersion: 2,
46
- capabilities: ['skill-hub-content-with-actor'],
47
- resolveCommit: vi.fn().mockResolvedValue(commitSha),
48
- listTree: vi.fn().mockResolvedValue([]),
49
- readFile: vi.fn().mockResolvedValue(Buffer.from(JSON.stringify({ skills: [] }))),
50
- ...input,
51
- };
52
- }
53
-
54
- function skillsRootEntries(rootPath: string): GitEntry[] {
55
- if (rootPath === 'skills') {
56
- return [{ type: 'tree', path: 'alpha', size: 0 }];
57
- }
58
- if (rootPath === 'skills/alpha') {
59
- return [{ type: 'blob', path: 'SKILL.md', size: 16 }];
60
- }
61
- return [];
62
- }
63
-
64
- function createContext(input: {
65
- service?: ContentService;
66
- params: Record<string, unknown>;
67
- skillDefinitions?: SkillDefinitionsRepository;
68
- }): TestContext {
69
- const skillDefinitions =
70
- input.skillDefinitions ||
71
- ({
72
- find: vi.fn().mockResolvedValue([]),
73
- findOne: vi.fn().mockResolvedValue(null),
74
- create: vi.fn().mockResolvedValue(undefined),
75
- } satisfies SkillDefinitionsRepository);
76
- const getRepository = vi.fn((name: string) => {
77
- if (name === 'gitRepositories') {
78
- throw new Error('Git repositories must only be read through Git Manager.');
79
- }
80
- if (name === 'skillDefinitions') {
81
- return skillDefinitions;
82
- }
83
- throw new Error(`Unexpected repository: ${name}`);
84
- });
85
- const context = {
86
- action: { params: input.params },
87
- state: { currentRoles: actor.roles },
88
- app: {
89
- pm: {
90
- get: vi.fn().mockReturnValue(input.service ? { skillHubContentService: input.service } : undefined),
91
- },
92
- },
93
- db: { getRepository },
94
- throw(status: number, message: string): never {
95
- throw httpError(status, message);
96
- },
97
- } as unknown as Context;
98
- return { context, getRepository, skillDefinitions };
99
- }
100
-
101
- function createMethodContext(actionName: 'gitListSkills' | 'gitSyncSkills', method: string) {
102
- const headers = new Map<string, string>();
103
- return {
104
- headers,
105
- method,
106
- action: { resourceName: 'skillHub', actionName, params: {} },
107
- set(name: string, value: string) {
108
- headers.set(name, value);
109
- },
110
- throw(status: number, message: string): never {
111
- throw httpError(status, message);
112
- },
113
- } as unknown as Context;
114
- }
115
-
116
- describe('Skill Hub Git import', () => {
117
- it('allows only GET/HEAD for listing and POST for syncing', async () => {
118
- const middleware = createGitImportRequestMethodPolicy();
119
- const next = vi.fn().mockResolvedValue(undefined);
120
-
121
- await middleware(createMethodContext('gitListSkills', 'GET'), next);
122
- await middleware(createMethodContext('gitListSkills', 'HEAD'), next);
123
- await middleware(createMethodContext('gitSyncSkills', 'POST'), next);
124
- expect(next).toHaveBeenCalledTimes(3);
125
-
126
- const rejectedList = createMethodContext('gitListSkills', 'POST');
127
- await expect(middleware(rejectedList, next)).rejects.toMatchObject({ status: 405 });
128
- expect((rejectedList as unknown as { headers: Map<string, string> }).headers.get('Allow')).toBe('GET, HEAD');
129
-
130
- const rejectedSync = createMethodContext('gitSyncSkills', 'GET');
131
- await expect(middleware(rejectedSync, next)).rejects.toMatchObject({ status: 405 });
132
- expect((rejectedSync as unknown as { headers: Map<string, string> }).headers.get('Allow')).toBe('POST');
133
- });
134
-
135
- it('lists skills through the actor-aware Git Manager service without reading gitRepositories', async () => {
136
- const service = createContentService({
137
- listTree: vi.fn().mockImplementation(async ({ rootPath }: { rootPath: string }) => skillsRootEntries(rootPath)),
138
- readFile: vi
139
- .fn()
140
- .mockResolvedValue(
141
- Buffer.from(JSON.stringify({ skills: [{ folder: 'alpha', name: 'alpha', title: 'Alpha' }] })),
142
- ),
143
- });
144
- const { context, getRepository } = createContext({
145
- service,
146
- params: { repositoryId: 42, rootFolder: 'skills' },
147
- });
148
- const next = vi.fn().mockResolvedValue(undefined);
149
-
150
- await gitListSkills(context, next);
151
-
152
- expect(service.resolveCommit).toHaveBeenCalledWith(42, 'HEAD', actor);
153
- expect(service.readFile).toHaveBeenCalledWith(
154
- { repositoryId: 42, commitSha, filePath: 'skills/skills.json' },
155
- actor,
156
- );
157
- expect(getRepository).toHaveBeenCalledWith('skillDefinitions');
158
- expect(getRepository).not.toHaveBeenCalledWith('gitRepositories');
159
- expect((context as unknown as { body: { data: Array<{ name: string }> } }).body.data).toEqual([
160
- expect.objectContaining({ name: 'alpha', existsInDb: false }),
161
- ]);
162
- expect(next).toHaveBeenCalledOnce();
163
- });
164
-
165
- it('rejects a role outside the Git repository scope before any database read', async () => {
166
- const service = createContentService({
167
- resolveCommit: vi.fn().mockRejectedValue(gitError('SKILL_HUB_REPOSITORY_ACCESS_DENIED', 'Scope denied')),
168
- });
169
- const { context, getRepository } = createContext({
170
- service,
171
- params: { repositoryId: 42, rootFolder: 'skills' },
172
- });
173
-
174
- await expect(gitListSkills(context, vi.fn())).rejects.toMatchObject({ status: 403, message: 'Scope denied' });
175
- expect(getRepository).not.toHaveBeenCalled();
176
- expect(service.listTree).not.toHaveBeenCalled();
177
- expect(service.readFile).not.toHaveBeenCalled();
178
- });
179
-
180
- it('localizes Git Manager bridge setup errors', async () => {
181
- const { context } = createContext({ params: { repositoryId: 42, rootFolder: 'skills' } });
182
- const translate = vi.fn((key: string) => `localized:${key}`);
183
- (context as unknown as { t: typeof translate }).t = translate;
184
-
185
- await expect(gitListSkills(context, vi.fn())).rejects.toMatchObject({
186
- status: 424,
187
- message: 'localized:Git Manager is not enabled for Skill Hub imports.',
188
- });
189
- expect(translate).toHaveBeenCalledWith('Git Manager is not enabled for Skill Hub imports.', {
190
- ns: 'plugin-agent-orchestrator',
191
- });
192
- });
193
-
194
- it('uses a virtual manifest without writing a Git checkout when skills.json is missing', async () => {
195
- const service = createContentService({
196
- listTree: vi.fn().mockImplementation(async ({ rootPath }: { rootPath: string }) => skillsRootEntries(rootPath)),
197
- readFile: vi.fn().mockRejectedValue(gitError('REGISTRY_GIT_FILE_NOT_FOUND')),
198
- });
199
- const { context } = createContext({
200
- service,
201
- params: { repositoryId: 42, rootFolder: 'skills' },
202
- });
203
-
204
- await gitListSkills(context, vi.fn());
205
-
206
- const body = context as unknown as {
207
- body: { data: Array<{ name: string }>; config: { initializedSkillsJson: boolean } };
208
- };
209
- expect(body.body.data).toEqual([expect.objectContaining({ name: 'alpha' })]);
210
- expect(body.body.config.initializedSkillsJson).toBe(false);
211
- });
212
-
213
- it('uses the same actor and pinned commit when syncing a selected skill', async () => {
214
- const created: Array<Record<string, unknown>> = [];
215
- const service = createContentService({
216
- listTree: vi.fn().mockImplementation(async ({ rootPath }: { rootPath: string }) => skillsRootEntries(rootPath)),
217
- readFile: vi
218
- .fn()
219
- .mockResolvedValue(
220
- Buffer.from(JSON.stringify({ skills: [{ name: 'alpha', storageType: 'plugin', pluginSource: 'alpha' }] })),
221
- ),
222
- });
223
- const skillDefinitions: SkillDefinitionsRepository = {
224
- findOne: vi.fn().mockResolvedValue(null),
225
- create: vi.fn().mockImplementation(async ({ values }: { values: Record<string, unknown> }) => {
226
- created.push(values);
227
- }),
228
- };
229
- const { context, getRepository } = createContext({
230
- service,
231
- skillDefinitions,
232
- params: { repositoryId: 42, rootFolder: 'skills', values: { skills: ['alpha'] } },
233
- });
234
-
235
- await gitSyncSkills(context, vi.fn());
236
-
237
- expect(getRepository).not.toHaveBeenCalledWith('gitRepositories');
238
- expect(service.resolveCommit).toHaveBeenCalledWith(42, 'HEAD', actor);
239
- expect(service.readFile).toHaveBeenCalledWith(
240
- { repositoryId: 42, commitSha, filePath: 'skills/skills.json' },
241
- actor,
242
- );
243
- expect(created).toEqual([
244
- expect.objectContaining({ name: 'alpha', storageUrl: `git://42/skills@${commitSha}#alpha` }),
245
- ]);
246
- });
247
-
248
- it('rejects a selected key absent from an explicit skills.json manifest before writing a skill', async () => {
249
- const service = createContentService({
250
- listTree: vi.fn().mockImplementation(async ({ rootPath }: { rootPath: string }) => skillsRootEntries(rootPath)),
251
- readFile: vi
252
- .fn()
253
- .mockResolvedValue(Buffer.from(JSON.stringify({ skills: [{ folder: 'alpha', name: 'alpha' }] }))),
254
- });
255
- const skillDefinitions: SkillDefinitionsRepository = {
256
- findOne: vi.fn(),
257
- create: vi.fn(),
258
- };
259
- const { context } = createContext({
260
- service,
261
- skillDefinitions,
262
- params: { repositoryId: 42, rootFolder: 'skills', values: { skills: ['unlisted'] } },
263
- });
264
-
265
- await expect(gitSyncSkills(context, vi.fn())).rejects.toMatchObject({
266
- status: 400,
267
- message: 'Selected skills are not listed in the explicit skills.json manifest: unlisted',
268
- });
269
- expect(skillDefinitions.findOne).not.toHaveBeenCalled();
270
- expect(skillDefinitions.create).not.toHaveBeenCalled();
271
- });
272
-
273
- it('allows a selected key from a virtual manifest when skills.json is absent', async () => {
274
- const service = createContentService({
275
- listTree: vi.fn().mockImplementation(async ({ rootPath }: { rootPath: string }) => skillsRootEntries(rootPath)),
276
- readFile: vi.fn().mockRejectedValue(gitError('REGISTRY_GIT_FILE_NOT_FOUND')),
277
- });
278
- const skillDefinitions: SkillDefinitionsRepository = {
279
- findOne: vi.fn().mockResolvedValue(null),
280
- create: vi.fn(),
281
- };
282
- const { context } = createContext({
283
- service,
284
- skillDefinitions,
285
- params: { repositoryId: 42, rootFolder: 'skills', values: { skills: ['alpha'] } },
286
- });
287
-
288
- await gitSyncSkills(context, vi.fn());
289
-
290
- expect(skillDefinitions.create).toHaveBeenCalledOnce();
291
- });
292
-
293
- it('rejects too many supplemental Markdown files before reading any of them', async () => {
294
- const supplementalFiles: GitEntry[] = Array.from(
295
- { length: GIT_SKILL_MARKDOWN_LIMITS.maxFiles + 1 },
296
- (_, index) => ({
297
- type: 'blob',
298
- path: `docs/${index}.md`,
299
- size: 1,
300
- }),
301
- );
302
- const service = createContentService({
303
- listTree: vi
304
- .fn()
305
- .mockImplementation(async ({ rootPath, recursive }: { rootPath: string; recursive: boolean }) => {
306
- if (rootPath === 'skills') return [{ type: 'tree', path: 'alpha', size: 0 }];
307
- if (rootPath === 'skills/alpha' && recursive) return supplementalFiles;
308
- if (rootPath === 'skills/alpha') return [{ type: 'blob', path: 'SKILL.md', size: 16 }];
309
- return [];
310
- }),
311
- readFile: vi.fn().mockImplementation(async ({ filePath }: { filePath: string }) => {
312
- if (filePath === 'skills/skills.json') {
313
- return Buffer.from(JSON.stringify({ skills: [{ folder: 'alpha', name: 'alpha' }] }));
314
- }
315
- if (filePath === 'skills/alpha/SKILL.md') {
316
- return Buffer.from('# Alpha');
317
- }
318
- throw new Error(`Unexpected file read: ${filePath}`);
319
- }),
320
- });
321
- const skillDefinitions: SkillDefinitionsRepository = {
322
- findOne: vi.fn(),
323
- create: vi.fn(),
324
- };
325
- const { context } = createContext({
326
- service,
327
- skillDefinitions,
328
- params: { repositoryId: 42, rootFolder: 'skills', values: { skills: ['alpha'] } },
329
- });
330
-
331
- await expect(gitSyncSkills(context, vi.fn())).rejects.toMatchObject({ status: 422 });
332
- expect(service.readFile).not.toHaveBeenCalledWith(
333
- expect.objectContaining({ filePath: 'skills/alpha/docs/0.md' }),
334
- actor,
335
- );
336
- expect(skillDefinitions.create).not.toHaveBeenCalled();
337
- });
338
-
339
- it('rejects supplemental Markdown whose declared aggregate size exceeds the import limit before reading it', async () => {
340
- const service = createContentService({
341
- listTree: vi
342
- .fn()
343
- .mockImplementation(async ({ rootPath, recursive }: { rootPath: string; recursive: boolean }) => {
344
- if (rootPath === 'skills') return [{ type: 'tree', path: 'alpha', size: 0 }];
345
- if (rootPath === 'skills/alpha' && recursive) {
346
- return [{ type: 'blob', path: 'GUIDE.md', size: GIT_SKILL_MARKDOWN_LIMITS.maxBytes }];
347
- }
348
- if (rootPath === 'skills/alpha') return [{ type: 'blob', path: 'SKILL.md', size: 16 }];
349
- return [];
350
- }),
351
- readFile: vi.fn().mockImplementation(async ({ filePath }: { filePath: string }) => {
352
- if (filePath === 'skills/skills.json') {
353
- return Buffer.from(JSON.stringify({ skills: [{ folder: 'alpha', name: 'alpha' }] }));
354
- }
355
- if (filePath === 'skills/alpha/SKILL.md') {
356
- return Buffer.from('# Alpha');
357
- }
358
- throw new Error(`Unexpected file read: ${filePath}`);
359
- }),
360
- });
361
- const skillDefinitions: SkillDefinitionsRepository = {
362
- findOne: vi.fn(),
363
- create: vi.fn(),
364
- };
365
- const { context } = createContext({
366
- service,
367
- skillDefinitions,
368
- params: { repositoryId: 42, rootFolder: 'skills', values: { skills: ['alpha'] } },
369
- });
370
-
371
- await expect(gitSyncSkills(context, vi.fn())).rejects.toMatchObject({ status: 422 });
372
- expect(service.readFile).not.toHaveBeenCalledWith(
373
- expect.objectContaining({ filePath: 'skills/alpha/GUIDE.md' }),
374
- actor,
375
- );
376
- expect(skillDefinitions.create).not.toHaveBeenCalled();
377
- });
378
-
379
- it('caps each supplemental Markdown read by the remaining aggregate budget', async () => {
380
- const service = createContentService({
381
- listTree: vi
382
- .fn()
383
- .mockImplementation(async ({ rootPath, recursive }: { rootPath: string; recursive: boolean }) => {
384
- if (rootPath === 'skills') return [{ type: 'tree', path: 'alpha', size: 0 }];
385
- if (rootPath === 'skills/alpha' && recursive) return [{ type: 'blob', path: 'GUIDE.md', size: 1 }];
386
- if (rootPath === 'skills/alpha') return [{ type: 'blob', path: 'SKILL.md', size: 16 }];
387
- return [];
388
- }),
389
- readFile: vi.fn().mockImplementation(async ({ filePath }: { filePath: string }) => {
390
- if (filePath === 'skills/skills.json') {
391
- return Buffer.from(JSON.stringify({ skills: [{ folder: 'alpha', name: 'alpha' }] }));
392
- }
393
- if (filePath === 'skills/alpha/SKILL.md') {
394
- return Buffer.from('# Alpha');
395
- }
396
- if (filePath === 'skills/alpha/GUIDE.md') {
397
- return Buffer.alloc(GIT_SKILL_MARKDOWN_LIMITS.maxBytes, 'a');
398
- }
399
- throw new Error(`Unexpected file read: ${filePath}`);
400
- }),
401
- });
402
- const skillDefinitions: SkillDefinitionsRepository = {
403
- findOne: vi.fn(),
404
- create: vi.fn(),
405
- };
406
- const { context } = createContext({
407
- service,
408
- skillDefinitions,
409
- params: { repositoryId: 42, rootFolder: 'skills', values: { skills: ['alpha'] } },
410
- });
411
-
412
- await expect(gitSyncSkills(context, vi.fn())).rejects.toMatchObject({ status: 422 });
413
- expect(service.readFile).toHaveBeenCalledWith(
414
- expect.objectContaining({
415
- filePath: 'skills/alpha/GUIDE.md',
416
- maxBytes: expect.any(Number),
417
- }),
418
- actor,
419
- );
420
- expect(skillDefinitions.create).not.toHaveBeenCalled();
421
- });
422
-
423
- it('does not convert an access denial during sync into a per-skill error', async () => {
424
- const service = createContentService({
425
- listTree: vi.fn().mockImplementation(async ({ rootPath }: { rootPath: string }) => skillsRootEntries(rootPath)),
426
- readFile: vi.fn().mockImplementation(async ({ filePath }: { filePath: string }) => {
427
- if (filePath === 'skills/skills.json') {
428
- return Buffer.from(JSON.stringify({ skills: [{ folder: 'alpha', name: 'alpha' }] }));
429
- }
430
- throw gitError('SKILL_HUB_REPOSITORY_ACCESS_DENIED', 'Scope was revoked');
431
- }),
432
- });
433
- const skillDefinitions: SkillDefinitionsRepository = {
434
- findOne: vi.fn().mockResolvedValue(null),
435
- create: vi.fn(),
436
- };
437
- const { context } = createContext({
438
- service,
439
- skillDefinitions,
440
- params: { repositoryId: 42, rootFolder: 'skills', values: { skills: ['alpha'] } },
441
- });
442
-
443
- await expect(gitSyncSkills(context, vi.fn())).rejects.toMatchObject({ status: 403, message: 'Scope was revoked' });
444
- expect(skillDefinitions.create).not.toHaveBeenCalled();
445
- });
446
-
447
- it('requires the Skill Hub actor-aware Git Manager contract', async () => {
448
- const service = createContentService({
449
- contractVersion: 1,
450
- capabilities: ['registry-content-with-actor'],
451
- });
452
- const { context, getRepository } = createContext({
453
- service,
454
- params: { repositoryId: 42, rootFolder: 'skills' },
455
- });
456
-
457
- await expect(gitListSkills(context, vi.fn())).rejects.toMatchObject({ status: 424 });
458
- expect(getRepository).not.toHaveBeenCalled();
459
- expect(service.resolveCommit).not.toHaveBeenCalled();
460
- });
461
-
462
- it('uses the configured skills root before falling back to a nested skills folder', async () => {
463
- const service = createContentService({
464
- listTree: vi.fn().mockImplementation(async ({ rootPath }: { rootPath: string }) => {
465
- if (rootPath === 'agent-assets/skills') {
466
- return [{ type: 'tree', path: 'alpha', size: 0 }];
467
- }
468
- if (rootPath === 'agent-assets/skills/alpha') {
469
- return [{ type: 'blob', path: 'SKILL.md', size: 16 }];
470
- }
471
- if (rootPath === 'agent-assets/skills/skills') {
472
- throw new Error('must not fall back to skills/skills');
473
- }
474
- return [];
475
- }),
476
- readFile: vi.fn().mockRejectedValue(gitError('REGISTRY_GIT_FILE_NOT_FOUND')),
477
- });
478
- const { context } = createContext({
479
- service,
480
- params: { repositoryId: 42, rootFolder: 'agent-assets/skills' },
481
- });
482
-
483
- await gitListSkills(context, vi.fn());
484
-
485
- expect(service.listTree).not.toHaveBeenCalledWith(
486
- expect.objectContaining({ rootPath: 'agent-assets/skills/skills' }),
487
- actor,
488
- );
489
- });
490
-
491
- it('falls back to a nested skills folder only when the configured root has no direct skill', async () => {
492
- const created: Array<Record<string, unknown>> = [];
493
- const service = createContentService({
494
- listTree: vi.fn().mockImplementation(async ({ rootPath }: { rootPath: string }) => {
495
- if (rootPath === 'agent-assets') {
496
- return [{ type: 'tree', path: 'skills', size: 0 }];
497
- }
498
- if (rootPath === 'agent-assets/skills') {
499
- return [{ type: 'tree', path: 'alpha', size: 0 }];
500
- }
501
- if (rootPath === 'agent-assets/skills/alpha') {
502
- return [{ type: 'blob', path: 'SKILL.md', size: 16 }];
503
- }
504
- return [];
505
- }),
506
- readFile: vi.fn().mockImplementation(async ({ filePath }: { filePath: string }) => {
507
- if (filePath === 'agent-assets/skills/skills.json') {
508
- return Buffer.from(JSON.stringify({ skills: [{ folder: 'alpha', name: 'alpha' }] }));
509
- }
510
- if (filePath === 'agent-assets/skills/alpha/SKILL.md') {
511
- return Buffer.from('# Alpha');
512
- }
513
- throw gitError('REGISTRY_GIT_FILE_NOT_FOUND');
514
- }),
515
- });
516
- const skillDefinitions: SkillDefinitionsRepository = {
517
- findOne: vi.fn().mockResolvedValue(null),
518
- create: vi.fn().mockImplementation(async ({ values }: { values: Record<string, unknown> }) => {
519
- created.push(values);
520
- }),
521
- };
522
- const { context } = createContext({
523
- service,
524
- skillDefinitions,
525
- params: { repositoryId: 42, rootFolder: 'agent-assets', values: { skills: ['alpha'] } },
526
- });
527
-
528
- await gitSyncSkills(context, vi.fn());
529
-
530
- expect(service.readFile).toHaveBeenCalledWith(
531
- expect.objectContaining({ filePath: 'agent-assets/skills/alpha/SKILL.md' }),
532
- actor,
533
- );
534
- expect(created).toEqual([
535
- expect.objectContaining({ name: 'alpha', storageUrl: `git://42/agent-assets/skills/alpha@${commitSha}` }),
536
- ]);
537
- });
538
-
539
- it('keeps a direct child folder named skills when the configured root already ends in skills', async () => {
540
- const service = createContentService({
541
- listTree: vi.fn().mockImplementation(async ({ rootPath }: { rootPath: string }) => {
542
- if (rootPath === 'agent-assets/skills') {
543
- return [{ type: 'tree', path: 'skills', size: 0 }];
544
- }
545
- if (rootPath === 'agent-assets/skills/skills') {
546
- return [{ type: 'blob', path: 'SKILL.md', size: 16 }];
547
- }
548
- return [];
549
- }),
550
- readFile: vi.fn().mockRejectedValue(gitError('REGISTRY_GIT_FILE_NOT_FOUND')),
551
- });
552
- const { context } = createContext({
553
- service,
554
- params: { repositoryId: 42, rootFolder: 'agent-assets/skills' },
555
- });
556
-
557
- await gitListSkills(context, vi.fn());
558
-
559
- expect((context as unknown as { body: { data: Array<{ name: string }> } }).body.data).toEqual([
560
- expect.objectContaining({ name: 'skills' }),
561
- ]);
562
- });
563
- });
1
+ import type { Context } from '@nocobase/actions';
2
+
3
+ import { GIT_SKILL_MARKDOWN_LIMITS, gitListSkills, gitSyncSkills } from '../git-import';
4
+ import { createGitImportRequestMethodPolicy } from '../../middlewares/git-import-request-method-policy';
5
+
6
+ const commitSha = 'a'.repeat(40);
7
+ const actor = { kind: 'user' as const, roles: ['developer'] };
8
+
9
+ type GitEntry = { type: 'blob' | 'tree'; path: string; size: number };
10
+
11
+ type SkillDefinitionsRepository = {
12
+ find?: ReturnType<typeof vi.fn>;
13
+ findOne: ReturnType<typeof vi.fn>;
14
+ create?: ReturnType<typeof vi.fn>;
15
+ };
16
+
17
+ type ContentService = {
18
+ contractVersion: number;
19
+ capabilities: string[];
20
+ resolveCommit: ReturnType<typeof vi.fn>;
21
+ listTree: ReturnType<typeof vi.fn>;
22
+ readFile: ReturnType<typeof vi.fn>;
23
+ };
24
+
25
+ type TestContext = {
26
+ context: Context;
27
+ getRepository: ReturnType<typeof vi.fn>;
28
+ skillDefinitions: SkillDefinitionsRepository;
29
+ };
30
+
31
+ function gitError(code: string, message = code): Error & { code: string } {
32
+ const error = new Error(message) as Error & { code: string };
33
+ error.code = code;
34
+ return error;
35
+ }
36
+
37
+ function httpError(status: number, message: string): Error & { status: number } {
38
+ const error = new Error(message) as Error & { status: number };
39
+ error.status = status;
40
+ return error;
41
+ }
42
+
43
+ function createContentService(input?: Partial<ContentService>): ContentService {
44
+ return {
45
+ contractVersion: 2,
46
+ capabilities: ['skill-hub-content-with-actor'],
47
+ resolveCommit: vi.fn().mockResolvedValue(commitSha),
48
+ listTree: vi.fn().mockResolvedValue([]),
49
+ readFile: vi.fn().mockResolvedValue(Buffer.from(JSON.stringify({ skills: [] }))),
50
+ ...input,
51
+ };
52
+ }
53
+
54
+ function skillsRootEntries(rootPath: string): GitEntry[] {
55
+ if (rootPath === 'skills') {
56
+ return [{ type: 'tree', path: 'alpha', size: 0 }];
57
+ }
58
+ if (rootPath === 'skills/alpha') {
59
+ return [{ type: 'blob', path: 'SKILL.md', size: 16 }];
60
+ }
61
+ return [];
62
+ }
63
+
64
+ function createContext(input: {
65
+ service?: ContentService;
66
+ params: Record<string, unknown>;
67
+ skillDefinitions?: SkillDefinitionsRepository;
68
+ }): TestContext {
69
+ const skillDefinitions =
70
+ input.skillDefinitions ||
71
+ ({
72
+ find: vi.fn().mockResolvedValue([]),
73
+ findOne: vi.fn().mockResolvedValue(null),
74
+ create: vi.fn().mockResolvedValue(undefined),
75
+ } satisfies SkillDefinitionsRepository);
76
+ const getRepository = vi.fn((name: string) => {
77
+ if (name === 'gitRepositories') {
78
+ throw new Error('Git repositories must only be read through Git Manager.');
79
+ }
80
+ if (name === 'skillDefinitions') {
81
+ return skillDefinitions;
82
+ }
83
+ throw new Error(`Unexpected repository: ${name}`);
84
+ });
85
+ const context = {
86
+ action: { params: input.params },
87
+ state: { currentRoles: actor.roles },
88
+ app: {
89
+ pm: {
90
+ get: vi.fn().mockReturnValue(input.service ? { skillHubContentService: input.service } : undefined),
91
+ },
92
+ },
93
+ db: { getRepository },
94
+ throw(status: number, message: string): never {
95
+ throw httpError(status, message);
96
+ },
97
+ } as unknown as Context;
98
+ return { context, getRepository, skillDefinitions };
99
+ }
100
+
101
+ function createMethodContext(actionName: 'gitListSkills' | 'gitSyncSkills', method: string) {
102
+ const headers = new Map<string, string>();
103
+ return {
104
+ headers,
105
+ method,
106
+ action: { resourceName: 'skillHub', actionName, params: {} },
107
+ set(name: string, value: string) {
108
+ headers.set(name, value);
109
+ },
110
+ throw(status: number, message: string): never {
111
+ throw httpError(status, message);
112
+ },
113
+ } as unknown as Context;
114
+ }
115
+
116
+ describe('Skill Hub Git import', () => {
117
+ it('allows only GET/HEAD for listing and POST for syncing', async () => {
118
+ const middleware = createGitImportRequestMethodPolicy();
119
+ const next = vi.fn().mockResolvedValue(undefined);
120
+
121
+ await middleware(createMethodContext('gitListSkills', 'GET'), next);
122
+ await middleware(createMethodContext('gitListSkills', 'HEAD'), next);
123
+ await middleware(createMethodContext('gitSyncSkills', 'POST'), next);
124
+ expect(next).toHaveBeenCalledTimes(3);
125
+
126
+ const rejectedList = createMethodContext('gitListSkills', 'POST');
127
+ await expect(middleware(rejectedList, next)).rejects.toMatchObject({ status: 405 });
128
+ expect((rejectedList as unknown as { headers: Map<string, string> }).headers.get('Allow')).toBe('GET, HEAD');
129
+
130
+ const rejectedSync = createMethodContext('gitSyncSkills', 'GET');
131
+ await expect(middleware(rejectedSync, next)).rejects.toMatchObject({ status: 405 });
132
+ expect((rejectedSync as unknown as { headers: Map<string, string> }).headers.get('Allow')).toBe('POST');
133
+ });
134
+
135
+ it('lists skills through the actor-aware Git Manager service without reading gitRepositories', async () => {
136
+ const service = createContentService({
137
+ listTree: vi.fn().mockImplementation(async ({ rootPath }: { rootPath: string }) => skillsRootEntries(rootPath)),
138
+ readFile: vi
139
+ .fn()
140
+ .mockResolvedValue(
141
+ Buffer.from(JSON.stringify({ skills: [{ folder: 'alpha', name: 'alpha', title: 'Alpha' }] })),
142
+ ),
143
+ });
144
+ const { context, getRepository } = createContext({
145
+ service,
146
+ params: { repositoryId: 42, rootFolder: 'skills' },
147
+ });
148
+ const next = vi.fn().mockResolvedValue(undefined);
149
+
150
+ await gitListSkills(context, next);
151
+
152
+ expect(service.resolveCommit).toHaveBeenCalledWith(42, 'HEAD', actor);
153
+ expect(service.readFile).toHaveBeenCalledWith(
154
+ { repositoryId: 42, commitSha, filePath: 'skills/skills.json' },
155
+ actor,
156
+ );
157
+ expect(getRepository).toHaveBeenCalledWith('skillDefinitions');
158
+ expect(getRepository).not.toHaveBeenCalledWith('gitRepositories');
159
+ expect((context as unknown as { body: { data: Array<{ name: string }> } }).body.data).toEqual([
160
+ expect.objectContaining({ name: 'alpha', existsInDb: false }),
161
+ ]);
162
+ expect(next).toHaveBeenCalledOnce();
163
+ });
164
+
165
+ it('rejects a role outside the Git repository scope before any database read', async () => {
166
+ const service = createContentService({
167
+ resolveCommit: vi.fn().mockRejectedValue(gitError('SKILL_HUB_REPOSITORY_ACCESS_DENIED', 'Scope denied')),
168
+ });
169
+ const { context, getRepository } = createContext({
170
+ service,
171
+ params: { repositoryId: 42, rootFolder: 'skills' },
172
+ });
173
+
174
+ await expect(gitListSkills(context, vi.fn())).rejects.toMatchObject({ status: 403, message: 'Scope denied' });
175
+ expect(getRepository).not.toHaveBeenCalled();
176
+ expect(service.listTree).not.toHaveBeenCalled();
177
+ expect(service.readFile).not.toHaveBeenCalled();
178
+ });
179
+
180
+ it('localizes Git Manager bridge setup errors', async () => {
181
+ const { context } = createContext({ params: { repositoryId: 42, rootFolder: 'skills' } });
182
+ const translate = vi.fn((key: string) => `localized:${key}`);
183
+ (context as unknown as { t: typeof translate }).t = translate;
184
+
185
+ await expect(gitListSkills(context, vi.fn())).rejects.toMatchObject({
186
+ status: 424,
187
+ message: 'localized:Git Manager is not enabled for Skill Hub imports.',
188
+ });
189
+ expect(translate).toHaveBeenCalledWith('Git Manager is not enabled for Skill Hub imports.', {
190
+ ns: 'plugin-agent-orchestrator',
191
+ });
192
+ });
193
+
194
+ it('uses a virtual manifest without writing a Git checkout when skills.json is missing', async () => {
195
+ const service = createContentService({
196
+ listTree: vi.fn().mockImplementation(async ({ rootPath }: { rootPath: string }) => skillsRootEntries(rootPath)),
197
+ readFile: vi.fn().mockRejectedValue(gitError('REGISTRY_GIT_FILE_NOT_FOUND')),
198
+ });
199
+ const { context } = createContext({
200
+ service,
201
+ params: { repositoryId: 42, rootFolder: 'skills' },
202
+ });
203
+
204
+ await gitListSkills(context, vi.fn());
205
+
206
+ const body = context as unknown as {
207
+ body: { data: Array<{ name: string }>; config: { initializedSkillsJson: boolean } };
208
+ };
209
+ expect(body.body.data).toEqual([expect.objectContaining({ name: 'alpha' })]);
210
+ expect(body.body.config.initializedSkillsJson).toBe(false);
211
+ });
212
+
213
+ it('uses the same actor and pinned commit when syncing a selected skill', async () => {
214
+ const created: Array<Record<string, unknown>> = [];
215
+ const service = createContentService({
216
+ listTree: vi.fn().mockImplementation(async ({ rootPath }: { rootPath: string }) => skillsRootEntries(rootPath)),
217
+ readFile: vi
218
+ .fn()
219
+ .mockResolvedValue(
220
+ Buffer.from(JSON.stringify({ skills: [{ name: 'alpha', storageType: 'plugin', pluginSource: 'alpha' }] })),
221
+ ),
222
+ });
223
+ const skillDefinitions: SkillDefinitionsRepository = {
224
+ findOne: vi.fn().mockResolvedValue(null),
225
+ create: vi.fn().mockImplementation(async ({ values }: { values: Record<string, unknown> }) => {
226
+ created.push(values);
227
+ }),
228
+ };
229
+ const { context, getRepository } = createContext({
230
+ service,
231
+ skillDefinitions,
232
+ params: { repositoryId: 42, rootFolder: 'skills', values: { skills: ['alpha'] } },
233
+ });
234
+
235
+ await gitSyncSkills(context, vi.fn());
236
+
237
+ expect(getRepository).not.toHaveBeenCalledWith('gitRepositories');
238
+ expect(service.resolveCommit).toHaveBeenCalledWith(42, 'HEAD', actor);
239
+ expect(service.readFile).toHaveBeenCalledWith(
240
+ { repositoryId: 42, commitSha, filePath: 'skills/skills.json' },
241
+ actor,
242
+ );
243
+ expect(created).toEqual([
244
+ expect.objectContaining({ name: 'alpha', storageUrl: `git://42/skills@${commitSha}#alpha` }),
245
+ ]);
246
+ });
247
+
248
+ it('rejects a selected key absent from an explicit skills.json manifest before writing a skill', async () => {
249
+ const service = createContentService({
250
+ listTree: vi.fn().mockImplementation(async ({ rootPath }: { rootPath: string }) => skillsRootEntries(rootPath)),
251
+ readFile: vi
252
+ .fn()
253
+ .mockResolvedValue(Buffer.from(JSON.stringify({ skills: [{ folder: 'alpha', name: 'alpha' }] }))),
254
+ });
255
+ const skillDefinitions: SkillDefinitionsRepository = {
256
+ findOne: vi.fn(),
257
+ create: vi.fn(),
258
+ };
259
+ const { context } = createContext({
260
+ service,
261
+ skillDefinitions,
262
+ params: { repositoryId: 42, rootFolder: 'skills', values: { skills: ['unlisted'] } },
263
+ });
264
+
265
+ await expect(gitSyncSkills(context, vi.fn())).rejects.toMatchObject({
266
+ status: 400,
267
+ message: 'Selected skills are not listed in the explicit skills.json manifest: unlisted',
268
+ });
269
+ expect(skillDefinitions.findOne).not.toHaveBeenCalled();
270
+ expect(skillDefinitions.create).not.toHaveBeenCalled();
271
+ });
272
+
273
+ it('allows a selected key from a virtual manifest when skills.json is absent', async () => {
274
+ const service = createContentService({
275
+ listTree: vi.fn().mockImplementation(async ({ rootPath }: { rootPath: string }) => skillsRootEntries(rootPath)),
276
+ readFile: vi.fn().mockRejectedValue(gitError('REGISTRY_GIT_FILE_NOT_FOUND')),
277
+ });
278
+ const skillDefinitions: SkillDefinitionsRepository = {
279
+ findOne: vi.fn().mockResolvedValue(null),
280
+ create: vi.fn(),
281
+ };
282
+ const { context } = createContext({
283
+ service,
284
+ skillDefinitions,
285
+ params: { repositoryId: 42, rootFolder: 'skills', values: { skills: ['alpha'] } },
286
+ });
287
+
288
+ await gitSyncSkills(context, vi.fn());
289
+
290
+ expect(skillDefinitions.create).toHaveBeenCalledOnce();
291
+ });
292
+
293
+ it('rejects too many supplemental Markdown files before reading any of them', async () => {
294
+ const supplementalFiles: GitEntry[] = Array.from(
295
+ { length: GIT_SKILL_MARKDOWN_LIMITS.maxFiles + 1 },
296
+ (_, index) => ({
297
+ type: 'blob',
298
+ path: `docs/${index}.md`,
299
+ size: 1,
300
+ }),
301
+ );
302
+ const service = createContentService({
303
+ listTree: vi
304
+ .fn()
305
+ .mockImplementation(async ({ rootPath, recursive }: { rootPath: string; recursive: boolean }) => {
306
+ if (rootPath === 'skills') return [{ type: 'tree', path: 'alpha', size: 0 }];
307
+ if (rootPath === 'skills/alpha' && recursive) return supplementalFiles;
308
+ if (rootPath === 'skills/alpha') return [{ type: 'blob', path: 'SKILL.md', size: 16 }];
309
+ return [];
310
+ }),
311
+ readFile: vi.fn().mockImplementation(async ({ filePath }: { filePath: string }) => {
312
+ if (filePath === 'skills/skills.json') {
313
+ return Buffer.from(JSON.stringify({ skills: [{ folder: 'alpha', name: 'alpha' }] }));
314
+ }
315
+ if (filePath === 'skills/alpha/SKILL.md') {
316
+ return Buffer.from('# Alpha');
317
+ }
318
+ throw new Error(`Unexpected file read: ${filePath}`);
319
+ }),
320
+ });
321
+ const skillDefinitions: SkillDefinitionsRepository = {
322
+ findOne: vi.fn(),
323
+ create: vi.fn(),
324
+ };
325
+ const { context } = createContext({
326
+ service,
327
+ skillDefinitions,
328
+ params: { repositoryId: 42, rootFolder: 'skills', values: { skills: ['alpha'] } },
329
+ });
330
+
331
+ await expect(gitSyncSkills(context, vi.fn())).rejects.toMatchObject({ status: 422 });
332
+ expect(service.readFile).not.toHaveBeenCalledWith(
333
+ expect.objectContaining({ filePath: 'skills/alpha/docs/0.md' }),
334
+ actor,
335
+ );
336
+ expect(skillDefinitions.create).not.toHaveBeenCalled();
337
+ });
338
+
339
+ it('rejects supplemental Markdown whose declared aggregate size exceeds the import limit before reading it', async () => {
340
+ const service = createContentService({
341
+ listTree: vi
342
+ .fn()
343
+ .mockImplementation(async ({ rootPath, recursive }: { rootPath: string; recursive: boolean }) => {
344
+ if (rootPath === 'skills') return [{ type: 'tree', path: 'alpha', size: 0 }];
345
+ if (rootPath === 'skills/alpha' && recursive) {
346
+ return [{ type: 'blob', path: 'GUIDE.md', size: GIT_SKILL_MARKDOWN_LIMITS.maxBytes }];
347
+ }
348
+ if (rootPath === 'skills/alpha') return [{ type: 'blob', path: 'SKILL.md', size: 16 }];
349
+ return [];
350
+ }),
351
+ readFile: vi.fn().mockImplementation(async ({ filePath }: { filePath: string }) => {
352
+ if (filePath === 'skills/skills.json') {
353
+ return Buffer.from(JSON.stringify({ skills: [{ folder: 'alpha', name: 'alpha' }] }));
354
+ }
355
+ if (filePath === 'skills/alpha/SKILL.md') {
356
+ return Buffer.from('# Alpha');
357
+ }
358
+ throw new Error(`Unexpected file read: ${filePath}`);
359
+ }),
360
+ });
361
+ const skillDefinitions: SkillDefinitionsRepository = {
362
+ findOne: vi.fn(),
363
+ create: vi.fn(),
364
+ };
365
+ const { context } = createContext({
366
+ service,
367
+ skillDefinitions,
368
+ params: { repositoryId: 42, rootFolder: 'skills', values: { skills: ['alpha'] } },
369
+ });
370
+
371
+ await expect(gitSyncSkills(context, vi.fn())).rejects.toMatchObject({ status: 422 });
372
+ expect(service.readFile).not.toHaveBeenCalledWith(
373
+ expect.objectContaining({ filePath: 'skills/alpha/GUIDE.md' }),
374
+ actor,
375
+ );
376
+ expect(skillDefinitions.create).not.toHaveBeenCalled();
377
+ });
378
+
379
+ it('caps each supplemental Markdown read by the remaining aggregate budget', async () => {
380
+ const service = createContentService({
381
+ listTree: vi
382
+ .fn()
383
+ .mockImplementation(async ({ rootPath, recursive }: { rootPath: string; recursive: boolean }) => {
384
+ if (rootPath === 'skills') return [{ type: 'tree', path: 'alpha', size: 0 }];
385
+ if (rootPath === 'skills/alpha' && recursive) return [{ type: 'blob', path: 'GUIDE.md', size: 1 }];
386
+ if (rootPath === 'skills/alpha') return [{ type: 'blob', path: 'SKILL.md', size: 16 }];
387
+ return [];
388
+ }),
389
+ readFile: vi.fn().mockImplementation(async ({ filePath }: { filePath: string }) => {
390
+ if (filePath === 'skills/skills.json') {
391
+ return Buffer.from(JSON.stringify({ skills: [{ folder: 'alpha', name: 'alpha' }] }));
392
+ }
393
+ if (filePath === 'skills/alpha/SKILL.md') {
394
+ return Buffer.from('# Alpha');
395
+ }
396
+ if (filePath === 'skills/alpha/GUIDE.md') {
397
+ return Buffer.alloc(GIT_SKILL_MARKDOWN_LIMITS.maxBytes, 'a');
398
+ }
399
+ throw new Error(`Unexpected file read: ${filePath}`);
400
+ }),
401
+ });
402
+ const skillDefinitions: SkillDefinitionsRepository = {
403
+ findOne: vi.fn(),
404
+ create: vi.fn(),
405
+ };
406
+ const { context } = createContext({
407
+ service,
408
+ skillDefinitions,
409
+ params: { repositoryId: 42, rootFolder: 'skills', values: { skills: ['alpha'] } },
410
+ });
411
+
412
+ await expect(gitSyncSkills(context, vi.fn())).rejects.toMatchObject({ status: 422 });
413
+ expect(service.readFile).toHaveBeenCalledWith(
414
+ expect.objectContaining({
415
+ filePath: 'skills/alpha/GUIDE.md',
416
+ maxBytes: expect.any(Number),
417
+ }),
418
+ actor,
419
+ );
420
+ expect(skillDefinitions.create).not.toHaveBeenCalled();
421
+ });
422
+
423
+ it('does not convert an access denial during sync into a per-skill error', async () => {
424
+ const service = createContentService({
425
+ listTree: vi.fn().mockImplementation(async ({ rootPath }: { rootPath: string }) => skillsRootEntries(rootPath)),
426
+ readFile: vi.fn().mockImplementation(async ({ filePath }: { filePath: string }) => {
427
+ if (filePath === 'skills/skills.json') {
428
+ return Buffer.from(JSON.stringify({ skills: [{ folder: 'alpha', name: 'alpha' }] }));
429
+ }
430
+ throw gitError('SKILL_HUB_REPOSITORY_ACCESS_DENIED', 'Scope was revoked');
431
+ }),
432
+ });
433
+ const skillDefinitions: SkillDefinitionsRepository = {
434
+ findOne: vi.fn().mockResolvedValue(null),
435
+ create: vi.fn(),
436
+ };
437
+ const { context } = createContext({
438
+ service,
439
+ skillDefinitions,
440
+ params: { repositoryId: 42, rootFolder: 'skills', values: { skills: ['alpha'] } },
441
+ });
442
+
443
+ await expect(gitSyncSkills(context, vi.fn())).rejects.toMatchObject({ status: 403, message: 'Scope was revoked' });
444
+ expect(skillDefinitions.create).not.toHaveBeenCalled();
445
+ });
446
+
447
+ it('requires the Skill Hub actor-aware Git Manager contract', async () => {
448
+ const service = createContentService({
449
+ contractVersion: 1,
450
+ capabilities: ['registry-content-with-actor'],
451
+ });
452
+ const { context, getRepository } = createContext({
453
+ service,
454
+ params: { repositoryId: 42, rootFolder: 'skills' },
455
+ });
456
+
457
+ await expect(gitListSkills(context, vi.fn())).rejects.toMatchObject({ status: 424 });
458
+ expect(getRepository).not.toHaveBeenCalled();
459
+ expect(service.resolveCommit).not.toHaveBeenCalled();
460
+ });
461
+
462
+ it('uses the configured skills root before falling back to a nested skills folder', async () => {
463
+ const service = createContentService({
464
+ listTree: vi.fn().mockImplementation(async ({ rootPath }: { rootPath: string }) => {
465
+ if (rootPath === 'agent-assets/skills') {
466
+ return [{ type: 'tree', path: 'alpha', size: 0 }];
467
+ }
468
+ if (rootPath === 'agent-assets/skills/alpha') {
469
+ return [{ type: 'blob', path: 'SKILL.md', size: 16 }];
470
+ }
471
+ if (rootPath === 'agent-assets/skills/skills') {
472
+ throw new Error('must not fall back to skills/skills');
473
+ }
474
+ return [];
475
+ }),
476
+ readFile: vi.fn().mockRejectedValue(gitError('REGISTRY_GIT_FILE_NOT_FOUND')),
477
+ });
478
+ const { context } = createContext({
479
+ service,
480
+ params: { repositoryId: 42, rootFolder: 'agent-assets/skills' },
481
+ });
482
+
483
+ await gitListSkills(context, vi.fn());
484
+
485
+ expect(service.listTree).not.toHaveBeenCalledWith(
486
+ expect.objectContaining({ rootPath: 'agent-assets/skills/skills' }),
487
+ actor,
488
+ );
489
+ });
490
+
491
+ it('falls back to a nested skills folder only when the configured root has no direct skill', async () => {
492
+ const created: Array<Record<string, unknown>> = [];
493
+ const service = createContentService({
494
+ listTree: vi.fn().mockImplementation(async ({ rootPath }: { rootPath: string }) => {
495
+ if (rootPath === 'agent-assets') {
496
+ return [{ type: 'tree', path: 'skills', size: 0 }];
497
+ }
498
+ if (rootPath === 'agent-assets/skills') {
499
+ return [{ type: 'tree', path: 'alpha', size: 0 }];
500
+ }
501
+ if (rootPath === 'agent-assets/skills/alpha') {
502
+ return [{ type: 'blob', path: 'SKILL.md', size: 16 }];
503
+ }
504
+ return [];
505
+ }),
506
+ readFile: vi.fn().mockImplementation(async ({ filePath }: { filePath: string }) => {
507
+ if (filePath === 'agent-assets/skills/skills.json') {
508
+ return Buffer.from(JSON.stringify({ skills: [{ folder: 'alpha', name: 'alpha' }] }));
509
+ }
510
+ if (filePath === 'agent-assets/skills/alpha/SKILL.md') {
511
+ return Buffer.from('# Alpha');
512
+ }
513
+ throw gitError('REGISTRY_GIT_FILE_NOT_FOUND');
514
+ }),
515
+ });
516
+ const skillDefinitions: SkillDefinitionsRepository = {
517
+ findOne: vi.fn().mockResolvedValue(null),
518
+ create: vi.fn().mockImplementation(async ({ values }: { values: Record<string, unknown> }) => {
519
+ created.push(values);
520
+ }),
521
+ };
522
+ const { context } = createContext({
523
+ service,
524
+ skillDefinitions,
525
+ params: { repositoryId: 42, rootFolder: 'agent-assets', values: { skills: ['alpha'] } },
526
+ });
527
+
528
+ await gitSyncSkills(context, vi.fn());
529
+
530
+ expect(service.readFile).toHaveBeenCalledWith(
531
+ expect.objectContaining({ filePath: 'agent-assets/skills/alpha/SKILL.md' }),
532
+ actor,
533
+ );
534
+ expect(created).toEqual([
535
+ expect.objectContaining({ name: 'alpha', storageUrl: `git://42/agent-assets/skills/alpha@${commitSha}` }),
536
+ ]);
537
+ });
538
+
539
+ it('keeps a direct child folder named skills when the configured root already ends in skills', async () => {
540
+ const service = createContentService({
541
+ listTree: vi.fn().mockImplementation(async ({ rootPath }: { rootPath: string }) => {
542
+ if (rootPath === 'agent-assets/skills') {
543
+ return [{ type: 'tree', path: 'skills', size: 0 }];
544
+ }
545
+ if (rootPath === 'agent-assets/skills/skills') {
546
+ return [{ type: 'blob', path: 'SKILL.md', size: 16 }];
547
+ }
548
+ return [];
549
+ }),
550
+ readFile: vi.fn().mockRejectedValue(gitError('REGISTRY_GIT_FILE_NOT_FOUND')),
551
+ });
552
+ const { context } = createContext({
553
+ service,
554
+ params: { repositoryId: 42, rootFolder: 'agent-assets/skills' },
555
+ });
556
+
557
+ await gitListSkills(context, vi.fn());
558
+
559
+ expect((context as unknown as { body: { data: Array<{ name: string }> } }).body.data).toEqual([
560
+ expect.objectContaining({ name: 'skills' }),
561
+ ]);
562
+ });
563
+ });